Since the model list is highly macrofied, keep ppc_def_t for now and
save a pointer to it in PowerPCCPUClass. This results in a flat list of
subclasses including aliases, to be refined later.
Move cpu_ppc_init() to translate_init.c and drop helper.c.
Long-term the idea is to turn translate_init.c
Previously we silently exited, with subclasses we got an opcode warning.
Instead explicitly tell the user what's wrong.
An indication for this is -cpu ? showing "host" with an all-zero PVR.
Signed-off-by: Andreas Färber
---
target-ppc/kvm.c |7 +++
1 Datei geändert, 7 Zeilen hinzugefügt
remove_port() is called from qdev's unplug callback, and we're certain
the port will be found in our list of ports. Adding an assert()
documents this.
This was flagged by Coverity, fix suggested by Markus.
CC: Markus Armbruster
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 6 ++
1
Amit Shah writes:
> On (Mon) 17 Dec 2012 [18:23:53], Markus Armbruster wrote:
>> >> However, it now worries find_port_by_id() in remove_port() could return
>> >> a null pointer, which is then dereferenced. No idea why it didn't
>> >> report that before. Obvious suppressor:
>> >>
>> >> diff
Il 17/12/2012 22:43, Michael S. Tsirkin ha scritto:
> On Mon, Dec 17, 2012 at 05:24:35PM +0100, Paolo Bonzini wrote:
>> After discussion with mst on the topic of resetting virtio devices,
>> here is a series that hopefully clarifies the semantics of bus and
>> device resets.
>>
>> After this series
Zero out tcg_ctx.gen_opc_instr_start for instructions representing the
last guest opcode in the TB.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Filippov
---
target-xtensa/translate.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/target-xtensa/translate.c b/tar
> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Tuesday, December 18, 2012 7:00 AM
> To: Bhushan Bharat-R65777
> Cc: qemu-devel qemu-devel; Peter Maydell; Jan Kiszka; qemu-...@nongnu.org
> List;
> Marcelo Tosatti; David Howells
> Subject: Re: [PATCH v2] Added u
On 18.12.2012, at 02:27, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Alexander Graf [mailto:ag...@suse.de]
>> Sent: Tuesday, December 18, 2012 6:51 AM
>> To: Bhushan Bharat-R65777
>> Cc: qemu-devel qemu-devel; Peter Maydell; Jan Kiszka; qemu-...@nongnu.org
>> List;
The Buildbot has detected a new failure on builder pci_x86_64_debian_6_0 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/pci_x86_64_debian_6_0/builds/482
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
Build Re
The Buildbot has detected a new failure on builder pci_i386_debian_6_0 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/pci_i386_debian_6_0/builds/482
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
Build Reason
> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Tuesday, December 18, 2012 6:51 AM
> To: Bhushan Bharat-R65777
> Cc: qemu-devel qemu-devel; Peter Maydell; Jan Kiszka; qemu-...@nongnu.org
> List;
> Marcelo Tosatti; David Howells
> Subject: Re: [PATCH v2] Added u
On 18.12.2012, at 02:14, Bhushan Bharat-R65777 wrote:
>>> +++ b/scripts/update-linux-headers.sh
>>> @@ -46,14 +46,26 @@ for arch in $ARCHLIST; do
>>>
>>>make -C "$linux" INSTALL_HDR_PATH="$tmpdir" SRCARCH=$arch
>>> headers_install
>>>
>>> +if [ -e "$linux/arch/$arch/include/uapi" ] &&
>
> > +++ b/scripts/update-linux-headers.sh
> > @@ -46,14 +46,26 @@ for arch in $ARCHLIST; do
> >
> > make -C "$linux" INSTALL_HDR_PATH="$tmpdir" SRCARCH=$arch
> > headers_install
> >
> > +if [ -e "$linux/arch/$arch/include/uapi" ] &&
> > +! [ -e "$output/linux-headers/uapi" ] ; then
Am 18.12.2012 01:30, schrieb Michael S. Tsirkin:
> On Tue, Dec 18, 2012 at 01:13:18AM +0100, Andreas Färber wrote:
>> Am 17.12.2012 23:58, schrieb Michael S. Tsirkin:
>>> On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote:
Am 17.12.2012 22:18, schrieb Michael S. Tsirkin:
> On M
"Michael S. Tsirkin" writes:
> On Mon, Dec 17, 2012 at 11:59:15PM +0100, Andreas Färber wrote:
>> Am 17.12.2012 22:40, schrieb Michael S. Tsirkin:
>> > Move bindings from opaque to DeviceState.
>> > This gives us better type safety with no performance cost.
>> > Add macros to make future QOM work
On Tue, Dec 18, 2012 at 01:13:18AM +0100, Andreas Färber wrote:
> Am 17.12.2012 23:58, schrieb Michael S. Tsirkin:
> > On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote:
> >> Am 17.12.2012 22:18, schrieb Michael S. Tsirkin:
> >>> On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber
Am 17.12.2012 23:58, schrieb Michael S. Tsirkin:
> On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote:
>> Am 17.12.2012 22:18, schrieb Michael S. Tsirkin:
>>> On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote:
Am 17.12.2012 21:48, schrieb Michael S. Tsirkin:
> On M
On 18.12.2012, at 00:00, David Gibson wrote:
> On Mon, Dec 17, 2012 at 11:10:12AM +0100, Alexander Graf wrote:
>>
>>
>> On 17.12.2012, at 03:32, David Gibson wrote:
>>
>>> On Thu, Dec 13, 2012 at 01:50:25PM +0100, Alexander Graf wrote:
On 04.12.2012, at 03:42, David Gibson wrote:
>
On Mon, Dec 17, 2012 at 11:59:15PM +0100, Andreas Färber wrote:
> Am 17.12.2012 22:40, schrieb Michael S. Tsirkin:
> > Move bindings from opaque to DeviceState.
> > This gives us better type safety with no performance cost.
> > Add macros to make future QOM work easier, document
> > which ones are
Am 17.12.2012 22:40, schrieb Michael S. Tsirkin:
> Move bindings from opaque to DeviceState.
> This gives us better type safety with no performance cost.
> Add macros to make future QOM work easier, document
> which ones are data-path sensitive.
>
> Signed-off-by: Michael S. Tsirkin
> ---
>
> Ch
On Mon, Dec 17, 2012 at 11:10:12AM +0100, Alexander Graf wrote:
>
>
> On 17.12.2012, at 03:32, David Gibson wrote:
>
> > On Thu, Dec 13, 2012 at 01:50:25PM +0100, Alexander Graf wrote:
> >>
> >> On 04.12.2012, at 03:42, David Gibson wrote:
> >>
> >>> PAPR requires that the device tree's CPU n
On Mon, Dec 17, 2012 at 11:08:43PM +0100, Andreas Färber wrote:
> Am 17.12.2012 22:18, schrieb Michael S. Tsirkin:
> > On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote:
> >> Am 17.12.2012 21:48, schrieb Michael S. Tsirkin:
> >>> On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber
Am 17.12.2012 22:18, schrieb Michael S. Tsirkin:
> On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote:
>> Am 17.12.2012 21:48, schrieb Michael S. Tsirkin:
>>> On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote:
Am 17.12.2012 19:21, schrieb Paolo Bonzini:
> Il 17/12/
Am 17.12.2012 17:24, schrieb Paolo Bonzini:
> When a device creates a bus and more devices as part of its init callback, the
> child device could be reset while the parent is still only partly initialized.
> In this case, the right thing to do is to delay resetting the child. Do not
> do it at all
Am 17.12.2012 15:43, schrieb Markus Armbruster:
> Alexander Graf writes:
>
>> On 17.12.2012, at 15:05, Markus Armbruster wrote:
>>
>>> They complicate IDE data structures and keep getting in the way.
>>> Also, TRIM support (commit d353fb72) is broken for them, because
>>> ide_identify() accesses
On Mon, Dec 17, 2012 at 05:24:35PM +0100, Paolo Bonzini wrote:
> After discussion with mst on the topic of resetting virtio devices,
> here is a series that hopefully clarifies the semantics of bus and
> device resets.
>
> After this series, there are two kinds of resets:
So just to clarify, what
Move bindings from opaque to DeviceState.
This gives us better type safety with no performance cost.
Add macros to make future QOM work easier, document
which ones are data-path sensitive.
Signed-off-by: Michael S. Tsirkin
---
Changes from v1:
- Address comment by Anreas Färber: wrap contain
On Mon, 17 Dec 2012 21:43:33 +0100
Andreas Färber wrote:
> Am 17.12.2012 17:01, schrieb Igor Mammedov:
> > This series is several cleanups, moved out from CPU properties series,
> > since they do not really depend on CPU properties re-factoring and could
> > simplify CPU subclasses work as well.
On Mon, Dec 17, 2012 at 10:13:11PM +0100, Andreas Färber wrote:
> Am 17.12.2012 21:48, schrieb Michael S. Tsirkin:
> > On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote:
> >> Am 17.12.2012 19:21, schrieb Paolo Bonzini:
> >>> Il 17/12/2012 18:55, Andreas Färber ha scritto:
> Am 17.
Am 17.12.2012 21:48, schrieb Michael S. Tsirkin:
> On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote:
>> Am 17.12.2012 19:21, schrieb Paolo Bonzini:
>>> Il 17/12/2012 18:55, Andreas Färber ha scritto:
Am 17.12.2012 16:45, schrieb Michael S. Tsirkin:
> diff --git a/hw/virtio-pc
On Mon, Dec 17, 2012 at 06:55:46PM +0100, Andreas Färber wrote:
> Am 17.12.2012 16:45, schrieb Michael S. Tsirkin:
> > diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> > index 3ea4140..63ae888 100644
> > --- a/hw/virtio-pci.c
> > +++ b/hw/virtio-pci.c
> > @@ -98,34 +98,34 @@ bool virtio_is_big_endi
On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas Färber wrote:
> Am 17.12.2012 19:21, schrieb Paolo Bonzini:
> > Il 17/12/2012 18:55, Andreas Färber ha scritto:
> >> Am 17.12.2012 16:45, schrieb Michael S. Tsirkin:
> >>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> >>> index 3ea4140..63ae888 1
Am 17.12.2012 17:01, schrieb Igor Mammedov:
> This series is several cleanups, moved out from CPU properties series,
> since they do not really depend on CPU properties re-factoring and could
> simplify CPU subclasses work as well.
The initial cleanups (most of which I had already reviewed) look
p
On Mon, Dec 17, 2012 at 06:13:28PM +0100, KONRAD Frédéric wrote:
> On 17/12/2012 16:45, Michael S. Tsirkin wrote:
> >On Fri, Dec 07, 2012 at 02:32:29PM +0100, fred.kon...@greensocs.com wrote:
> >>From: KONRAD Frederic
> >>
> >>You can clone that from here :
> >>git.greensocs.com/home/greensocs/git
Or delete a.out.h which is unused.
Signed-off-by: Paolo Bonzini
---
a.out.h | 430 --
uboot_image.h => hw/uboot_image.h | 0
2 files changed, 430 deletions(-)
delete mode 100644 a.out.h
rename uboot_image.h => hw/uboot_image.h (10
Signed-off-by: Paolo Bonzini
---
Makefile.objs | 2 +-
net/Makefile.objs | 2 +-
net.c => net/net.c | 8
3 files changed, 6 insertions(+), 6 deletions(-)
rename net.c => net/net.c (99%)
diff --git a/Makefile.objs b/Makefile.objs
index 986f085..83092dc 100644
--- a/Makefile.objs
+
Signed-off-by: Paolo Bonzini
---
bt-host.c | 1 -
bt-host.h | 13 -
bt-vhci.c | 2 +-
hw/bt-hci-csr.c| 2 +-
hw/bt-hci.c| 2 +-
hw/bt.c| 2 +-
hw/usb/dev-bluetooth.c | 2 +-
net.h | 14 --
Signed-off-by: Paolo Bonzini
---
.gitignore | 1 +
Makefile | 9 ---
Makefile.dis | 20 ---
Makefile.objs | 19 +++---
Makefile.target| 5
Move its definition from qapi-visit-core.h to qapi-visit-impl.h.
Signed-off-by: Paolo Bonzini
---
qapi/qapi-visit-core.h | 40
qapi/qapi-visit-impl.h | 40
2 files changed, 40 insertions(+), 40 deletions(-)
diff --
Signed-off-by: Paolo Bonzini
---
Makefile| 10 --
audio/Makefile.objs | 3 +++
block/Makefile.objs | 2 ++
hw/Makefile.objs| 2 ++
ui/Makefile.objs| 5 +
5 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/Makefile b/Makefile
index 9ebd3cd..5810718
Signed-off-by: Paolo Bonzini
---
rules.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules.mak b/rules.mak
index 77d2360..8448b94 100644
--- a/rules.mak
+++ b/rules.mak
@@ -71,7 +71,7 @@ TRACETOOL=$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
@test -f $@ || cp $< $@
Am 17.12.2012 20:40, schrieb Stefan Weil:
> Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements
> with wrong format specifiers.
>
> GetLastError() returns a DWORD which is unsigned long, so %lu must be used.
>
> Signed-off-by: Stefan Weil
> ---
>
> Do we want those fprintf
Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements
with wrong format specifiers.
GetLastError() returns a DWORD which is unsigned long, so %lu must be used.
Signed-off-by: Stefan Weil
---
Do we want those fprintf statements here at all?
- Stefan
block/raw-win32.c |4
Signed-off-by: Paolo Bonzini
---
arch_init.c| 4 ++--
block-migration.c | 4 ++--
block/qcow.c | 2 +-
block/qed.c| 2 +-
block/vdi.c
On 17.12.2012, at 19:19, Richard Henderson wrote:
> On 12/17/2012 09:01 AM, Alexander Graf wrote:
>> Could you please send another pull request without the softfloat bits, then
>> rework those and get Peter's ack on them? :)
>
> I've got reviews on all the prerequisites, but they aren't merged
Signed-off-by: Paolo Bonzini
---
qapi/opts-visitor.c | 1 +
qapi/qapi-types-core.h | 1 -
qapi/qapi-visit-core.c | 1 +
scripts/qapi-commands.py | 1 +
scripts/qapi-visit.py| 1 +
5 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
Signed-off-by: Paolo Bonzini
---
backends/rng-egd.c | 2 +-
bt-host.c | 2 +-
bt-vhci.c | 2 +-
event_notifier-posix.c | 2 +-
gdbstub.c | 2 +-
hmp.c | 2 +-
hw/bau
Headers in the root directory are now used only from within that
directory.
Signed-off-by: Paolo Bonzini
---
config.h => include/config.h | 0
elf.h => include/elf.h | 0
libfdt_env.h => include/libfdt_env.h | 0
qemu-common.h => include/qemu-common.h | 0
4 files cha
Signed-off-by: Paolo Bonzini
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index d06fbad..7e38112 100644
--- a/Makefile
+++ b/Makefile
@@ -189,8 +189,9 @@ qemu-io$(EXESUF): qemu-io.o cmd.o $(tools-obj-y)
$(block-obj-y) libqemustub.a
qem
Signed-off-by: Paolo Bonzini
---
Makefile| 8 +++-
Makefile.objs | 3 ++-
Makefile.target | 3 +--
Makefile.user | 24
configure | 3 ---
5 files changed, 6 insertions(+), 35 deletions(-)
delete mode 100644 Makefile.user
diff --git a/Makefile b
Signed-off-by: Paolo Bonzini
---
configure| 2 +-
fpu/softfloat.c | 2 +-
{fpu => include/fpu}/softfloat.h | 0
include/qemu/bswap.h | 2 +-
linux-user/arm/nwfpe/double_cpdo.c | 2 +-
linux-user/arm/nwfpe/extended_cpdo.c | 2 +
Signed-off-by: Paolo Bonzini
---
Makefile | 9 +
Makefile.objs | 2 +-
qga/Makefile.objs | 2 +-
qemu-ga.c => qga/main.c| 0
qapi-schema-guest.json => qga/qapi-schem
Touching char/char.h basically causes the whole of QEMU to
be rebuilt. Avoid this, it is usually unnecessary.
Signed-off-by: Paolo Bonzini
---
audio/alsaaudio.c| 1 -
audio/ossaudio.c | 1 -
block/raw-posix.c| 1 -
bt-host.c| 1 -
bt-vhci.c
Signed-off-by: Paolo Bonzini
---
arch_init.c | 1 -
hw/alpha_sys.h | 1 -
hw/device-hotplug.c | 1 -
hw/lm32_boards.c | 1 -
hw/milkymist-hw.h| 1 +
hw/milkymist.c | 1 -
hw/s390-virtio-bus.c | 1 -
hw/spapr_vscsi.c | 1 -
hw/virtex_ml507.c| 1 -
hw/virtio-ne
On 12/12/2012 06:46 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> hbitmap.c| 48 +
> hbitmap.h| 11 +
> tests/test-hbitmap.c | 67
>
> 3 files changed, 126 i
Am 17.12.2012 19:21, schrieb Paolo Bonzini:
> Il 17/12/2012 18:55, Andreas Färber ha scritto:
>> Am 17.12.2012 16:45, schrieb Michael S. Tsirkin:
>>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>>> index 3ea4140..63ae888 100644
>>> --- a/hw/virtio-pci.c
>>> +++ b/hw/virtio-pci.c
>>> @@ -98,34 +9
On 12/17/2012 09:01 AM, Alexander Graf wrote:
> Could you please send another pull request without the softfloat bits, then
> rework those and get Peter's ack on them? :)
I've got reviews on all the prerequisites, but they aren't merged yet.
http://lists.nongnu.org/archive/html/qemu-devel/2012-1
Il 17/12/2012 18:55, Andreas Färber ha scritto:
> Am 17.12.2012 16:45, schrieb Michael S. Tsirkin:
>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>> index 3ea4140..63ae888 100644
>> --- a/hw/virtio-pci.c
>> +++ b/hw/virtio-pci.c
>> @@ -98,34 +98,34 @@ bool virtio_is_big_endian(void);
>>
>> /*
Signed-off-by: Paolo Bonzini
---
backends/rng-egd.c | 2 +-
backends/rng-random.c | 2 +-
backends/rng.c | 2 +-
balloon.c | 2 +-
block.c
Signed-off-by: Paolo Bonzini
---
aes.c | 2 +-
aio-posix.c | 2 +-
aio-win32.c | 2 +-
async.c | 2 +-
block-migration.
Signed-off-by: Paolo Bonzini
---
hw/qdev-core.h | 2 +-
hw/stream.h | 2 +-
include/qemu/rng-random.h | 2 +-
include/qemu/rng.h | 2 +-
include/{qemu => qom}/cpu.h | 2 +-
include/{qemu => qom}/object.h | 0
inc
Signed-off-by: Paolo Bonzini
---
arch_init.c | 2 +-
audio/audio.c| 2 +-
audio/wavcapture.c | 2 +-
balloon.c| 2 +-
balloon.h| 2 +-
block.c
Signed-off-by: Paolo Bonzini
---
gen-icount.h| 5 +
host-utils.h| 4
hw/9pfs/virtio-9p-synth.h | 4
hw/audiodev.h | 5 +
hw/baum.h | 4
hw/bt.h | 5 +
hw/cris-b
Signed-off-by: Paolo Bonzini
---
Makefile.objs | 4 +---
hmp.c | 2 +-
hw/adb.c | 2 +-
hw/ads7846.c | 2 +-
hw/applesmc.c
Move public headers to include/net, and leave private headers in net/.
Put the virtio headers in include/net/tap.h, removing the multiple copies
that existed. Leave include/net/tap.h as the interface for NICs, and
net/tap_int.h as the interface for OS-specific parts of the tap backend.
Signed-off
The file is only including error.h and qerror.h. Prefer explicit
inclusion of whatever files are needed.
Signed-off-by: Paolo Bonzini
---
qapi/opts-visitor.c | 1 +
qapi/qapi-dealloc-visitor.c | 1 +
qapi/qapi-types-core.h | 20
qapi/qapi-visit-core.c |
Signed-off-by: Paolo Bonzini
---
configure | 2 +-
alpha.ld => ldscripts/alpha.ld | 0
arm.ld => ldscripts/arm.ld | 0
hppa.ld => ldscripts/hppa.ld | 0
i386.ld => ldscripts/i386.ld | 0
ia64.ld => ldscripts/ia64.ld | 0
m68k.ld => ldscripts/
Various header files rely on qemu-char.h including qemu-config.h or
main-loop.h, but they really do not need qemu-char.h at all (particularly
interesting is the case of the block layer!). Clean this up, and also
add missing inclusions of qemu-char.h itself.
Signed-off-by: Paolo Bonzini
---
arch
Make it correct for nested directories, and move the static part
from Makefile to configure.
Signed-off-by: Paolo Bonzini
---
Makefile | 2 --
configure | 3 +--
rules.mak | 3 +++
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index 7e38112..9ebd3cd 100644
-
Signed-off-by: Paolo Bonzini
---
Makefile | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/Makefile b/Makefile
index 9ecbcbb..d06fbad 100644
--- a/Makefile
+++ b/Makefile
@@ -169,19 +169,11 @@ libqemustub.a: $(stub-obj-y)
# Support building shared library libcacard
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |6 +++---
target-i386/cpu.h |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index ed67de7..2b7272a 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -284,7 +284,7 @@ typ
Signed-off-by: Paolo Bonzini
---
hw/qdev-core.h | 51 ++-
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/hw/qdev-core.h b/hw/qdev-core.h
index 28f12a4..1274994 100644
--- a/hw/qdev-core.h
+++ b/hw/qdev-core.h
@@ -36,7 +36,24 @@ typede
Am 17.12.2012 16:45, schrieb Michael S. Tsirkin:
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index 3ea4140..63ae888 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -98,34 +98,34 @@ bool virtio_is_big_endian(void);
>
> /* virtio device */
>
> -static void virtio_pci_notify(vo
virtio-pci devices do not perform a full reset when zero is written
to the status byte. While PCI-specific status is initialized, the
reset does not propagate down the qdev bus hierarchy. Because of
this, a virtio reset does not cancel in-flight I/O for virtio-scsi
(where the cancellation is hand
A PCI bus reset will deassert the INTX pins, and this will make the
irq_count array all-zeroes. Check that this is the case, and remove
the existing loop which might even unsync irq_count and irq_state.
Signed-off-by: Paolo Bonzini
---
hw/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 del
Signed-off-by: Paolo Bonzini
---
hw/qdev-core.h | 12
hw/qdev.c | 7 ++-
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/hw/qdev-core.h b/hw/qdev-core.h
index d672cca..f8bf9dd 100644
--- a/hw/qdev-core.h
+++ b/hw/qdev-core.h
@@ -182,6 +182,18 @@ int qbus_walk
After discussion with mst on the topic of resetting virtio devices,
here is a series that hopefully clarifies the semantics of bus and
device resets.
After this series, there are two kinds of resets:
1) device-level reset is the kind of reset that you get with a register
write on the device. It
virtio-s390 devices do not perform a reset when zero is written to the
status byte. Because of this, a virtio reset does not cancel in-flight
I/O for virtio-scsi.
Use qdev_reset_all so that the reset correctly propagates down the qdev
bus hierarchy.
Reported-by: Bryan Venteicher
Cc: Alexander G
freeing resources in one place would require setting 'error'
to not NULL, so add some more error reporting before jumping to
exit branch.
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c | 16 +++-
1 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/target-i386/cpu.c b
On 17.12.2012, at 17:01, Bharat Bhushan wrote:
> Linux ARCH specific header files are now in uapi/ directory also.
> These header files (epapr_hcalls.h on powerpc) are needed in qemu
> in linux-headers/uapi/asm/ directory as these are referenced by
> other header files in linux-headers/asm/.
>
>
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 418c899..24bfd95 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -862,7 +862,6 @@ static int cpu_x86_fill_model_
When a device creates a bus and more devices as part of its init callback, the
child device could be reset while the parent is still only partly initialized.
In this case, the right thing to do is to delay resetting the child. Do not
do it at all in qdev_init, instead use qdev_reset_all to reset a
On 17.12.2012, at 18:21, Andreas Färber wrote:
> Am 17.12.2012 15:49, schrieb Alexander Graf:
>>
>> On 14.12.2012, at 17:46, Jens Freimann wrote:
>>
>>> @@ -37,12 +42,30 @@ static void s390_cpu_reset(CPUState *s)
>>>log_cpu_state(env, 0);
>>>}
>>>
>>> -scc->parent_reset(s);
>>>
Implement guest_reset as a bus-level reset callback. Then, the qdev
and virtio core will call it when needed every time the device is
reset or the status field is set to 0.
Signed-off-by: Paolo Bonzini
---
hw/virtio-serial-bus.c | 19 +--
1 file changed, 5 insertions(+), 14 dele
when CPU properties are implemented, ext2_features may change
between object_new(CPU) and cpu_realize_fn(). Sanitizing
ext2_features for AMD based CPU at realize() time will keep
current behavior after CPU features are converted to properties.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Hab
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c | 23 ---
1 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 24bfd95..e075b59 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -951,19 +951,20 @@ static int
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index b4b1e70..eb01bb0 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1301,13 +1301,7 @@ static int cpu_x86_parse_fe
Am 17.12.2012 15:47, schrieb Alexander Graf:
>
> On 14.12.2012, at 17:46, Jens Freimann wrote:
>
>> From: Viktor Mihajlovski
>>
>> This enables qemu -cpu help to return a list of supported CPU models
>> on s390 and also to query for cpu definitions in the monitor.
>> Initially only cpu model = h
They are reset implicitly by walking the qdev tree, before calling
intel_hda_reset.
Signed-off-by: Paolo Bonzini
---
hw/intel-hda.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/intel-hda.c b/hw/intel-hda.c
index a68c368..e7c9dd9 100644
--- a/hw/intel-hda.c
+++ b/hw/intel-hda.c
@@ -1112
On (Mon) 17 Dec 2012 [18:23:53], Markus Armbruster wrote:
> >> However, it now worries find_port_by_id() in remove_port() could return
> >> a null pointer, which is then dereferenced. No idea why it didn't
> >> report that before. Obvious suppressor:
> >>
> >> diff --git a/hw/virtio-serial-b
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 714ae79..a66bdd8 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1309,13 +1309,7 @@ static int cpu_x86_parse_fe
Amit Shah writes:
> On (Mon) 17 Dec 2012 [14:14:17], Markus Armbruster wrote:
>> Amit Shah writes:
>>
>> > Stuff the cpkt before calling send_control_msg(). it should not be
>> > concerned about contents, just send across the buffer.
>> >
>> > A few code refactorings recently have made mkaing
Am 17.12.2012 15:49, schrieb Alexander Graf:
>
> On 14.12.2012, at 17:46, Jens Freimann wrote:
>
>> @@ -37,12 +42,30 @@ static void s390_cpu_reset(CPUState *s)
>> log_cpu_state(env, 0);
>> }
>>
>> -scc->parent_reset(s);
>> +s390_del_running_cpu(env);
>>
>> +scc->parent_res
Signed-off-by: Paolo Bonzini
---
hw/lsi53c895a.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index 04f2fae..83ac5e9 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -1670,12 +1670,7 @@ static void lsi_reg_writeb(LSIState *s, int
virtio-s390 devices are not being reset when their bus is. To fix
this, add a reset method that forwards to virtio_reset. This is
only needed because of the "strange" modeling of virtio devices;
the ->vdev link is being handled manually rather than through qdev.
Signed-off-by: Paolo Bonzini
---
Il 17/12/2012 18:14, Eric Blake ha scritto:
> On 12/12/2012 06:46 AM, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini
>> ---
>> hbitmap.c | 57 +++--
>> hbitmap.h | 25 +
>> 2 files changed, 72 insertions(+), 10 dele
Resetting should be done in post-order, not pre-order. However,
qdev_walk_children and qbus_walk_children do not allow this. Fix
it by adding two extra arguments to the functions.
Signed-off-by: Paolo Bonzini
---
hw/qdev-core.h | 13 +
hw/qdev.c | 45 ++
Am 17.12.2012 14:29, schrieb Gerd Hoffmann:
> On 12/16/12 04:49, Andreas Färber wrote:
>> SysBus EHCI was introduced in a hurry before 1.3 Soft Freeze.
>> To use QOM casts in place of DO_UPCAST() / FROM_SYSBUS(), we need an
>> identifying type. Introduce generic abstract base types for PCI and
>> S
On 12/12/2012 06:46 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> hbitmap.c | 57 +++--
> hbitmap.h | 25 +
> 2 files changed, 72 insertions(+), 10 deletions(-)
When using hbitmap_alloc_with_data, must
It prepares for converting "+feature,-feature,feature=foo,feature" into
a set of key,value property pairs that will be applied to CPU by
cpu_x86_set_props().
Each feature handled by cpu_x86_parse_featurestr() will be converted into
foo,val pair and a corresponding property setter by following patc
1 - 100 of 241 matches
Mail list logo