Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-02 Thread Gerd Hoffmann
Hi, > Gerd: In order for me to use this with the new-style Tegra2 model we > will need to further move EHCISysBusState and the accompanying macros > that this series adds into the hcd-ehci.h header so that it can be > embedded into the SoC object. So if you're okay with my approach we'd > need a

[Qemu-devel] [PATCH] e1000: Discard packets that are too long if !SBP and !LPE

2012-12-02 Thread Michael Contreras
The e1000_receive function for the e1000 needs to discard packets longer than 1522 bytes if the SBP and LPE flags are disabled. The linux driver assumes this behavior and allocates memory based on this assumption. Signed-off-by: Michael Contreras --- Tested with linux guest. This error can poten

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-02 Thread walimis
On Sun, Dec 02, 2012 at 05:27:16PM +0100, Andreas F鋜ber wrote: >Am 02.12.2012 11:34, schrieb walimis: >> On Sun, Dec 02, 2012 at 03:57:17AM +0100, Andreas F鋜ber wrote: >>> Appended is Liming's patch to add an EHCI device to Exynos 4 as well as a >>> new patch of mine to prepare a Tegra 2 EHCI devic

[Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function

2012-12-02 Thread liguang
1. define names of breakpoints in dr7 2. slightly refactor bits field of breakpoint related functions. Signed-off-by: liguang --- target-i386/cpu.h |6 target-i386/helper.c | 59 target-i386/machine.c |2 +- target-i

Re: [Qemu-devel] [PATCH]target-i386:cpu_x86_init():do clean up work

2012-12-02 Thread li guang
在 2012-11-29四的 16:34 -0200,Eduardo Habkost写道: > On Wed, Nov 28, 2012 at 02:20:23PM +0800, liguang wrote: > > 1.remove unused variable env > > It's not unused. You are removing the line that sets env->cpu_model_str. > > > 2.remove redundant error handling > > > > Signed-off-by: liguang > > --- >

Re: [Qemu-devel] [PATCH 2/3] use dr7's bit name for breakpoint

2012-12-02 Thread li guang
在 2012-11-29四的 11:28 +,Peter Maydell写道: > On 29 November 2012 03:32, liguang wrote: > > Signed-off-by: liguang > > --- > > target-i386/cpu.h |2 ++ > > target-i386/helper.c | 24 +++- > > target-i386/misc_helper.c |6 +++--- > > target-i386/seg_help

Re: [Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi

2012-12-02 Thread Rusty Russell
David Gibson writes: > The virtio-scsi specification does not specify the correct endianness for > fields in the request structure. It's therefore best to assume that it is > "guest native" endian since that's the (stupid and poorly defined) norm in > virtio. > > However, the qemu device for vir

[Qemu-devel] [Bug 1085658] Re: exec, cpu log

2012-12-02 Thread Daniil Troshkov
** Changed in: qemu Assignee: (unassigned) => Daniil Troshkov (troshkovdanil) ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1085658 Title: ex

[Qemu-devel] [Bug 1085658] Re: exec, cpu log

2012-12-02 Thread Daniil Troshkov
** Description changed: Hello! CPU_LOG_EXEC (and CPU_LOG_TB_CPU) does not work (i.e. not of each tb dumped) because tb links is occur. Patch: diff --git a/cpu-exec.c b/cpu-exec.c index 904ee73..509d50c 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -582,7 +582,11 @@ int cpu_exe

[Qemu-devel] [PATCH] libcacard: correct T0 historical bytes size

2012-12-02 Thread Marc-André Lureau
The VCARD_ATR_PREFIX macro adds a prefix of 6 characters only. pcsc_scan was complaining before the patch: + Historical bytes: 56 43 41 52 44 5F 4E 53 53 ERROR! ATR is truncated: 2 byte(s) is/are missing --- libcacard/vcardt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Qemu-devel] [Bug 1085658] Re: exec, cpu log

2012-12-02 Thread Peter Maydell
> CPU_LOG_EXEC (and CPU_LOG_TB_CPU) does not work (i.e. not of each tb dumped) because tb links is occur. This is true, but I'm afraid I don't think this patch is the right approach. Enabling debug tracing shouldn't cause us to change behaviour, so we can't just disable TB linking when doing debug

[Qemu-devel] [Bug 1085658] [NEW] exec, cpu log

2012-12-02 Thread Daniil Troshkov
Public bug reported: Hello! CPU_LOG_EXEC (and CPU_LOG_TB_CPU) does not work (i.e. not of each tb dumped) because tb links is occur. Patch: diff --git a/cpu-exec.c b/cpu-exec.c index 904ee73..509d50c 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -582,7 +582,11 @@ int cpu_exec(CPUArchState *env)

[Qemu-devel] [Bug 1085658] Re: exec, cpu log

2012-12-02 Thread Daniil Troshkov
** Attachment added: "patch_exec" https://bugs.launchpad.net/qemu/+bug/1085658/+attachment/3449861/+files/patch_exec -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1085658 Title: exec, cpu log

[Qemu-devel] [PATCH 4/4] hw/ds1338.c: Handle stuck bits and preserve CH

2012-12-02 Thread Antoine Mathys
Preserve the CH bit when updating the time. Per the datasheet, some bits in the first eight registers must always read back as zero. These registers can be written in two ways: 1. By ourselves when we update the registers with the current time. 2. By user request Even though (1) is not supposed

[Qemu-devel] [PATCH 3/4] hw/ds1338.c: ensure OSF can only be cleared

2012-12-02 Thread Antoine Mathys
Per the datasheet, the OSF bit in the control register can only be cleared. Attempts to set it have no effect. Implement this. Signed-off-by: Antoine Mathys --- hw/ds1338.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index 1fb152e..f3c

[Qemu-devel] [PATCH 2/4] hw/ds1338.c: Minor fixes

2012-12-02 Thread Antoine Mathys
Minor fixes in the handling of the RTC registers. Signed-off-by: Antoine Mathys --- hw/ds1338.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index 1274b22..1fb152e 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -62,9 +62,9 @@ sta

[Qemu-devel] [PATCH 1/4] hw/ds1338.c: Fix handling of HOURS register.

2012-12-02 Thread Antoine Mathys
Per the datasheet, the mapping between 12 and 24 hours modes is: 0 <-> 12 PM 1-12 <-> 1-12 AM 13-23 <-> 1-11 PM Signed-off-by: Antoine Mathys --- hw/ds1338.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/ds1338.c b/hw/

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-02 Thread Andreas Färber
Am 02.12.2012 11:34, schrieb walimis: > On Sun, Dec 02, 2012 at 03:57:17AM +0100, Andreas Färber wrote: >> Appended is Liming's patch to add an EHCI device to Exynos 4 as well as a >> new patch of mine to prepare a Tegra 2 EHCI device (cf. my tegra branch) to > > BTW, where can I find your tegra b

Re: [Qemu-devel] lsi scsi driver is broken

2012-12-02 Thread Anthony Liguori
Blue Swirl writes: > On Fri, Nov 30, 2012 at 2:46 PM, Mark Cave-Ayland > wrote: >> On 30/11/12 14:26, Anthony Liguori wrote: >> Try latest seabios. [ yes, /me plans to update seabios for 1.3, just waiting for the q35 patches to find their way into seabios ]. >>> >>> >>> If

Re: [Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c to qdev.c

2012-12-02 Thread Peter Maydell
On 2 December 2012 05:44, Andreas Färber wrote: > Am 01.12.2012 12:26, schrieb Peter Maydell: >> On 30 November 2012 21:38, Eduardo Habkost wrote: >>> cpu_reset() is not that well-defined, otherwise we wouldn't have this on >>> linux-user: >>> >>> #if defined(TARGET_I386) || defined(TARGET_SPARC)

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-12-02 Thread Peter Maydell
** Changed in: qemu Status: New => Confirmed ** Changed in: qemu-linaro Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with qemu-arm

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v7 3/4] use elf_reset to reload elf image

2012-12-02 Thread Alexander Graf
Missing patch description On 29.11.2012, at 06:26, Olivia Yin wrote: > Signed-off-by: Olivia Yin > --- > elf.h| 10 ++ > hw/elf_ops.h | 44 +++- > hw/loader.c | 11 +++ > 3 files changed, 60 insertions(+), 5 deletions(-) > > d

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v7 2/4] use uimage_reset to reload uimage

2012-12-02 Thread Alexander Graf
On 29.11.2012, at 06:26, Olivia Yin wrote: > Signed-off-by: Olivia Yin > --- > hw/loader.c | 57 + > hw/loader.h |3 +++ > 2 files changed, 48 insertions(+), 12 deletions(-) > > diff --git a/hw/loader.c b/hw/loader.c > index f62aa7c..1

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v7 1/4] use image_file_reset to reload initrd

2012-12-02 Thread Alexander Graf
Missing patch description On 29.11.2012, at 06:26, Olivia Yin wrote: > Signed-off-by: Olivia Yin > --- > hw/loader.c | 24 > hw/loader.h |6 ++ > 2 files changed, 30 insertions(+), 0 deletions(-) > > diff --git a/hw/loader.c b/hw/loader.c > index ba01ca6..f62aa7

Re: [Qemu-devel] [PATCH RFT 0/5] usb: Clean up and extend SysBus EHCI

2012-12-02 Thread walimis
On Sun, Dec 02, 2012 at 03:57:17AM +0100, Andreas Färber wrote: >Hello, > >Some review comments for SysBus EHCI were ignored in favor of merging into 1.3. >As requested by Gerd, this now follows up with the cleanups I had requested >from Peter C. Apart from using the new-style QOM casts it also ach

Re: [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read

2012-12-02 Thread Alon Levy
> The current code waits until the chardev can read MIN(len, VMC_MAX) > But some chardev may never reach than amount, in fact some of them > will only ever accept write of 1. Fix the min computation and remove > the VMC_MAX constant. Looks good to me. > > Signed-off-by: Marc-André Lureau > ---

Re: [Qemu-devel] [PATCH V7 6/6] Adding VMXNET3 device implementation

2012-12-02 Thread Dmitry Fleytman
Hello, Stefan Thanks for the review. I'll go over it later this week and prepare new patches. Dmitry. On Fri, Nov 30, 2012 at 6:37 PM, Stefan Hajnoczi wrote: > On Fri, Nov 16, 2012 at 2:55 PM, Dmitry Fleytman > wrote: > > +/* Whether MSI-X support was installed successfully */ > > +

Re: [Qemu-devel] [PATCH V7 0/6] VMXNET3 paravirtual NIC device implementation

2012-12-02 Thread Dmitry Fleytman
Hi Paolo, Anthony No doubts I'm a nice guy :) We'll be glad to amend this implementation with tests as soon as infrastructure is ready. Dmitry On Fri, Nov 30, 2012 at 6:17 PM, Anthony Liguori wrote: > Paolo Bonzini writes: > > >> Yes, we tested this device with various guests (both Linux and