Re: [Qemu-devel] [PATCH] exec.c: Use tb1->phys_hash_next directly in tb_remove

2012-11-24 Thread Wei-Ren Chen
ping? On Tue, Nov 20, 2012 at 12:41:03PM +, Peter Maydell wrote: > On 20 November 2012 12:30, 陳韋任 (Wei-Ren Chen) > wrote: > > When tb_remove was first commited at fd6ce8f6, there were three different > > calls pass different names to offsetof. In current codebase, the other two > > calls

[Qemu-devel] qemu-system-arm v1.3.0-rc0 / 1.2.1 freeze on OSX 10.8.2

2012-11-24 Thread Pi LFS
I've compiled it using the apple-gcc42 toolchain from homebrew. qemu-system-arm starts up with a white window, CPU usage goes up but window just hangs there. I can access the menus and click the window to switch input focus, that's about it. There is no debug output/logging to give any clue what it

[Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan Using irqfd, so we can avoid switch between kernel and user when VMs interrupts each other. Signed-off-by: Liu Ping Fan --- hw/ivshmem.c | 54 +- 1 files changed, 53 insertions(+), 1 deletions(-) diff --git a/hw/ivshmem.

[Qemu-devel] [PATCH v2 1/2] ivshmem: remove msix_write_config

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan This logic has been integrated into pci core, so remove it. Signed-off-by: Liu Ping Fan --- hw/ivshmem.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index f6dbb21..7c8630c 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @

[Qemu-devel] [PATCH v7 7/7] vcpu: push mmio dispatcher out of big lock

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan To anti the recursive big lock, introduce separate interfaces to allow address space dispatcher called with/without big lock. Signed-off-by: Liu Ping Fan --- cpu-common.h |3 +++ exec.c | 21 + kvm-all.c|4 +++- 3 files changed, 23 ins

[Qemu-devel] [PATCH v7 6/7] memory: introduce tls context to trace nested mmio request issue

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan After breaking down big lock, nested MMIO request which not targeting at RAM can cause deadlock issue. Supposing the scene: dev_a,b with fine-grain locks lockA/B, then ABBA dealock issue can be triggered. We fix this by tracing and rejecting such request. Signed-off-by: Liu Pi

[Qemu-devel] [PATCH v7 5/7] memory: make mmio dispatch able to be out of biglock

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan Without biglock, we try to protect the mr by increase refcnt. If we cannot inc refcnt, go backward and resort to biglock. Another point is memory radix-tree can be flushed by another thread, so we should get the copy of terminal mr to survive from such issue. Signed-off-by: L

[Qemu-devel] [PATCH v7 4/7] memory: introduce local lock for address space

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan For those address spaces which want to be able out of big lock, they will be protected by their own local. Signed-off-by: Liu Ping Fan --- memory.c |1 + memory.h |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/memory.c b/memory.c index 2f68d67

[Qemu-devel] [PATCH v7 3/7] pci: remove pci device from mem view when unplug

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- hw/acpi_piix4.c |2 +- hw/pci.c| 13 - hw/pci.h|1 + 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 15275cf..b45a016 100644 --- a/hw/acpi_piix4.c +++

[Qemu-devel] [PATCH v7 2/7] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan When device unplug has been ack by guest, we first remove it from memory to prevent incoming access from dispatcher. Then we isolate it from device composition tree Signed-off-by: Liu Ping Fan --- hw/qdev.c | 26 ++ hw/qdev.h |3 ++- 2 files cha

[Qemu-devel] [PATCH v7 1/7] qom: apply atomic on object's refcount

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- qom/object.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index e3e9242..1a697b3 100644 --- a/qom/object.c +++ b/qom/object.c @@ -600,16 +600,15 @@ GSList *object_class_get_list(const

[Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

2012-11-24 Thread Liu Ping Fan
From: Liu Ping Fan v1: https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03312.html v2: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01275.html v3: http://lists.nongnu.org/archive/html/qemu-devel/2012-09/msg01474.html v4: http://lists.gnu.org/archive/html/qemu-devel/2012-10/m

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-24 Thread Andreas Färber
Am 22.11.2012 15:50, schrieb fred.kon...@greensocs.com: > diff --git a/hw/virtio-bus.c b/hw/virtio-bus.c > new file mode 100644 > index 000..991b6f5 > --- /dev/null > +++ b/hw/virtio-bus.c [...] > +#define DEBUG_VIRTIO_BUS 1 We probably want to disable debug output by default as done elsewhere

[Qemu-devel] [PATCH for 1.3] pflash_cfi01: Suppress warning when Linux probes for AMD flash

2012-11-24 Thread Stefan Weil
There are several ARM and MIPS boards which are manufactured with either Intel (pflash_cfi01.c) or AMD (pflash_cfi02.c) flash memory. The Linux kernel supports both and first probes for AMD flash which resulted in one or two warnings from the Intel flash emulation: pflash_write: Unimplemented fla

Re: [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer

2012-11-24 Thread Blue Swirl
Thanks, applied. On Thu, Nov 22, 2012 at 5:30 PM, Jan Kiszka wrote: > The vm clock may be stopped, and then we won't get open events anymore. > Seen with QMP sessions. > > Reported-by: Dietmar Maurer > Tested-by: Luiz Capitulino > Signed-off-by: Jan Kiszka > --- > qemu-char.c |4 ++-- > 1

Re: [Qemu-devel] [PATCH V11 1/7] Build system fix distclean error for pixman

2012-11-24 Thread Blue Swirl
Thanks, applied this patch only. On Sat, Nov 24, 2012 at 9:27 AM, Wenchao Xia wrote: > Currently Makefile test if pixman have configure log, but the script > directly > return error if that file do not exist. This patch fix it. > > v2: print out the command. > v3: resend as a stand alone fix p

Re: [Qemu-devel] [PATCH for 1.3 v2] block: Fix regression for MinGW (assertion caused by short string)

2012-11-24 Thread Blue Swirl
Thanks, applied. On Thu, Nov 22, 2012 at 6:25 AM, Stefan Weil wrote: > The local string tmp_filename is passed to function get_tmp_filename > which expects a string with minimum size MAX_PATH for w32 hosts. > > MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short. > > Commit eba2505

Re: [Qemu-devel] [PATCH] tci: Fix type of tci_read_label

2012-11-24 Thread Blue Swirl
Thanks, applied. On Mon, Nov 19, 2012 at 8:43 PM, Richard Henderson wrote: > Fixes the pointer truncation that was occurring for branches. > > Cc: Stefan Weil > Cc: Blue Swirl > Signed-off-by: Richard Henderson > --- > tci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-24 Thread Stefan Priebe
Am 24.11.2012 20:54, schrieb Blue Swirl: On Thu, Nov 22, 2012 at 10:00 AM, Stefan Priebe wrote: This one fixes a race which qemu had also in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. To archieve t

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-24 Thread Blue Swirl
On Thu, Nov 22, 2012 at 10:00 AM, Stefan Priebe wrote: > This one fixes a race which qemu had also in iscsi block driver > between cancellation and io completition. > > qemu_rbd_aio_cancel was not synchronously waiting for the end of > the command. > > To archieve this it introduces a new status f

Re: [Qemu-devel] [PATCH v2 3/4] buffered_file: rate-limit producers based on buffer size

2012-11-24 Thread Blue Swirl
On Tue, Nov 20, 2012 at 4:45 PM, Paolo Bonzini wrote: > buffered_rate_limit is called to prevent the RAM migration callback > from putting too much data in the buffer. So it has to check against > the amount of data currently in the buffer, not against the amount > of data that has been transferr

[Qemu-devel] [Bug 1082292] Re: [ARM] pflash_write: Unimplemented flash cmd sequence

2012-11-24 Thread Peter Maydell
We could drop it to a LOG_UNIMP/LOG_GUEST_ERROR qemu_log warning instead of a plain printf, I guess. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1082292 Title: [ARM] pflash_write: Unimplemented f

[Qemu-devel] [Bug 1082292] Re: [ARM] pflash_write: Unimplemented flash cmd sequence

2012-11-24 Thread Stefan Weil
The message from pflash_write is a warning which only says that the Intel flash emulation got a command sequence which is only supported by the AMD flash emulation. This warning is currently normal when Linux kernels try to determine the flash type. Linux tries AMD before Intel. So if there is

Re: [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-11-24 Thread Peter Maydell
On 24 November 2012 17:39, Richard Henderson wrote: > --- a/tcg/i386/tcg-target.c > +++ b/tcg/i386/tcg-target.c > @@ -97,6 +97,20 @@ static const int tcg_target_call_oarg_regs[] = { > # define TCG_REG_L1 TCG_REG_EDX > #endif > > +/* Attempt to determine at compile-time whether the compiler assum

[Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-11-24 Thread Richard Henderson
In addition to better compile-time detection, perform runtime detection. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 34 +- tcg/i386/tcg-target.h | 5 - 2 files changed, 33 insertions(+), 6 deletions(-) Yall are right that there's no particu

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-11-24 Thread Stefan Hajnoczi
On Mon, Jun 25, 2012 at 7:42 AM, Mike Lovell wrote: > This is what I've been calling QDES or QEMU Distributed Ethernet Switch. I > first had the idea when I was playing with the udp and mcast socket network > backends while exploring how to build a VM infrastructure. I liked the idea of > using th

[Qemu-devel] [PATCH for 1.3] target-i386: enable SSSE3 TCG support

2012-11-24 Thread Aurelien Jarno
SSSE3 support has been added to TCG more than 4 years ago in commit 4242b1bd8acc19cffdaad4ac23213d72a72b. It has been disabled by mistake in commit 551a2dec8fa55006a68393b9d6fb63577d2b3f1c. Signed-off-by: Aurelien Jarno --- target-i386/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [PATCH v3] target-mips: Clean up microMIPS32 major opcode

2012-11-24 Thread Aurelien Jarno
On Wed, Nov 21, 2012 at 02:04:41PM +0800, 陳韋任 (Wei-Ren Chen) wrote: > I check MIPS microMIPS manual [1], and found the major opcode might > be wrong. I add a comment to explicitly indicate what manual I am refering > to, and according that manual I remove microMIPS32 major opcodes 0x1f. > As for

Re: [Qemu-devel] [PATCH v2] target-mips: Add comments on POOL32Axf encoding

2012-11-24 Thread Aurelien Jarno
On Wed, Nov 21, 2012 at 01:50:45PM +0800, 陳韋任 (Wei-Ren Chen) wrote: > Current QEMU MIPS POOL32AXF encoding comes from microMIPS32 > and microMIPS32 DSP. Add comment here to help reading. > > Signed-off-by: Chen Wei-Ren > --- > > v2: Correct commit message formatting > > target-mips/translate

Re: [Qemu-devel] [PATCH] tcg: mark local temps as MEM in dead_temp()

2012-11-24 Thread Aurelien Jarno
On Sat, Nov 24, 2012 at 02:28:15PM +0300, Max Filippov wrote: > On Sat, Nov 24, 2012 at 2:58 PM, Aurelien Jarno wrote: > > In dead_temp, local temps should always be marked as back to memory, > > even if they have not been allocated (i.e. they are discared before > > cross a basic block). > > > >

Re: [Qemu-devel] [PATCH] tcg: mark local temps as MEM in dead_temp()

2012-11-24 Thread Max Filippov
On Sat, Nov 24, 2012 at 2:58 PM, Aurelien Jarno wrote: > In dead_temp, local temps should always be marked as back to memory, > even if they have not been allocated (i.e. they are discared before > cross a basic block). > > It fixes the following assertion in target-xtensa: > > qemu-system-xte

Re: [Qemu-devel] [PATCH] target-xtensa: make sar_m32 global instead of local temp

2012-11-24 Thread Max Filippov
On Sat, Nov 24, 2012 at 2:59 PM, Aurelien Jarno wrote: > On Sat, Nov 24, 2012 at 04:51:36AM +0400, Max Filippov wrote: >> This fixes the following assertion caused by local temp reaching the end >> of TB in discarded state: >> >> qemu-system-xtensa: tcg/tcg.c:1665: temp_save: Assertion >> `s->t

Re: [Qemu-devel] [PATCH] target-xtensa: make sar_m32 global instead of local temp

2012-11-24 Thread Aurelien Jarno
On Sat, Nov 24, 2012 at 04:51:36AM +0400, Max Filippov wrote: > This fixes the following assertion caused by local temp reaching the end > of TB in discarded state: > > qemu-system-xtensa: tcg/tcg.c:1665: temp_save: Assertion > `s->temps[temp].val_type == 2 || s->temps[temp].fixed_reg' failed.

[Qemu-devel] [PATCH] tcg: mark local temps as MEM in dead_temp()

2012-11-24 Thread Aurelien Jarno
In dead_temp, local temps should always be marked as back to memory, even if they have not been allocated (i.e. they are discared before cross a basic block). It fixes the following assertion in target-xtensa: qemu-system-xtensa: tcg/tcg.c:1665: temp_save: Assertion `s->temps[temp].val_type

[Qemu-devel] [PATCH V11 0/7] libqblock qemu block layer library

2012-11-24 Thread Wenchao Xia
These patches introduce libqblock API, make subdir-libqblock and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported

[Qemu-devel] [PATCH V11 7/7] libqblock test example

2012-11-24 Thread Wenchao Xia
In this example, first it will create some qcow2 images, then try get information including backing file relationship, then it will do sync IO on the image. v11: Use only gtester option -k, to avoid silent fail for segment fault. Little change according to API. Signed-off-by: Wenchao Xia -

[Qemu-devel] [PATCH V11 1/7] Build system fix distclean error for pixman

2012-11-24 Thread Wenchao Xia
Currently Makefile test if pixman have configure log, but the script directly return error if that file do not exist. This patch fix it. v2: print out the command. v3: resend as a stand alone fix patch, add reviewer. This patch have been sent as a stand alone fix for 1.3, if it is already mer

[Qemu-devel] [PATCH V11 2/7] Build system clean tests directory clearly

2012-11-24 Thread Wenchao Xia
Currently root Makefile try clean tests/tcg, hard to extend. This patch added command make check-clean, which clean all generated files used in tests. With this command root Makefile do not care tests clean method any more, it simply calls the command to do it, so any more clean script could be a

[Qemu-devel] [PATCH V11 4/7] libqblock build system

2012-11-24 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock. GCC

[Qemu-devel] [PATCH V11 5/7] libqblock API design and type defines

2012-11-24 Thread Wenchao Xia
Public API design header files: libqblock.h, libqblock-error.h. Public type define header files: libqblock-types.h. Private internal used header files: libqblock-internal, libqblock-aio.h. For ABI some reserved bytes are used in structure defines. v11: Moved API design into this patch.

[Qemu-devel] [PATCH V11 3/7] block export function path_has_protocol

2012-11-24 Thread Wenchao Xia
This function is needed in other module, so export it. There is already some patch on mail-list try export it, If that patch was applied, pls ignore this one. Signed-off-by: Wenchao Xia --- block.c |2 +- block.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/blo

[Qemu-devel] [PATCH V11 6/7] libqblock API implement

2012-11-24 Thread Wenchao Xia
This patch contains implemention for APIs. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockImage. It stands for an block image object. 3 QBlockStaticInfo. It contains static information such as location, backing file,