Re: [Qemu-devel] [PATCH 3/7] dataplane: add virtqueue vring code

2012-11-15 Thread Christian Borntraeger
On 15/11/12 16:19, Stefan Hajnoczi wrote: > +#include "trace.h" > +#include "hw/dataplane/vring.h" > + > +/* Map target physical address to host address > + */ > +static inline void *phys_to_host(Vring *vring, hwaddr phys) > +{ > +/* Adjust for 3.6-4 GB PCI memory range */ > +if (phys >= 0

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 19:28, Peter Lieven ha scritto: >>> >> I dont know if we should switch to use synchronous code here. >>> >> It is much nicer if all code is async. >> > >> > bdrv_open is generally synchronous, so I think Peter's patch is ok. > if all is sync wouldn't it be best to have all code in isc

Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 22:08, Anthony Liguori ha scritto: > Stefan Hajnoczi writes: > >> The virtio-blk-data-plane feature is easy to integrate into >> hw/virtio-blk.c. The data plane can be started and stopped similar to >> vhost-net. >> >> Users can take advantage of the virtio-blk-data-plane feature u

[Qemu-devel] [Bug 1077806] Re: Integrate Virtualbox/Qemu Guest booting as a desktop environment listing (request)

2012-11-15 Thread Cassidy James
** Changed in: pantheon-greeter Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077806 Title: Integrate Virtualbox/Qemu Guest booting as a desktop environment

[Qemu-devel] [PATCH] trace: Remove "info trace" from documents

2012-11-15 Thread Liming Wang
commit 88affa1c monitor: remove unused do_info_trace has removed "info trace" function from monitor, so remove it from documents. Signed-off-by: Liming Wang --- docs/tracing.txt |9 - hmp-commands.hx |7 --- 2 files changed, 16 deletions(-) diff --git a/docs/tracing.txt b/

[Qemu-devel] [PATCH] free the memory malloced by load_at()

2012-11-15 Thread Olivia Yin
Signed-off-by: Olivia Yin --- hw/elf_ops.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/elf_ops.h b/hw/elf_ops.h index db4630e..4495932 100644 --- a/hw/elf_ops.h +++ b/hw/elf_ops.h @@ -178,6 +178,8 @@ static int glue(load_symbols, SZ)(struct elfhdr *ehdr, int fd,

Re: [Qemu-devel] [PATCH 3/7] dataplane: add virtqueue vring code

2012-11-15 Thread Stefan Hajnoczi
On Thu, Nov 15, 2012 at 9:09 PM, Anthony Liguori wrote: > Stefan Hajnoczi writes: > >> The virtio-blk-data-plane cannot access memory using the usual QEMU >> functions since it executes outside the global mutex and the memory APIs >> are this time are not thread-safe. >> >> This patch introduces

Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-15 Thread Stefan Hajnoczi
On Thu, Nov 15, 2012 at 10:08 PM, Anthony Liguori wrote: > Stefan Hajnoczi writes: > >> The virtio-blk-data-plane feature is easy to integrate into >> hw/virtio-blk.c. The data plane can be started and stopped similar to >> vhost-net. >> >> Users can take advantage of the virtio-blk-data-plane f

Re: [Qemu-devel] [PATCH 1/7] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2012-11-15 Thread Stefan Hajnoczi
On Thu, Nov 15, 2012 at 9:03 PM, Anthony Liguori wrote: > Stefan Hajnoczi writes: > >> The raw_get_aio_fd() function allows virtio-blk-data-plane to get the >> file descriptor of a raw image file with Linux AIO enabled. This >> interface is really a layering violation that can be resolved once t

Re: [Qemu-devel] [RFC PATCH v4 2/3] use uimage_reset to reload uimage

2012-11-15 Thread Yin Olivia-R63875
Hi Stuart, load_uimage() is a public function which is called by below files: hw/dummy_m68k.c:kernel_size = load_uimage(kernel_filename, &entry, NULL, NULL); hw/an5206.c:kernel_size = load_uimage(kernel_filename, &entry, NULL, NULL); hw/ppc440_bamboo.c

Re: [Qemu-devel] [RFC PATCH v4 1/3] use image_file_reset to reload initrd image

2012-11-15 Thread Yin Olivia-R63875
Hi Stuart, I want to keep the Memory Region of rom which will be inserted to the queue roms. And then we can use "info roms" command to check the rom information. ROM images must be loaded at startup, so rom_add_* functions could be called only one time before all the reset handlers. Exactly a

[Qemu-devel] [PATCH 2/2] Buildsystem clean tests directory clearly

2012-11-15 Thread Wenchao Xia
Currently make clean only clean tests/tcg and hard to extend. This patch added command make check-clean, which clean all generated files used in tests. With this command root Makefile do not care tests clean method any more, it simply calls the command to do it, so any more clean script could be

[Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman

2012-11-15 Thread Wenchao Xia
Currently if pixman have no config.log inside, make file still try to clean it resulting error. This patch fix it. Signed-off-by: Wenchao Xia --- Makefile |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 81c660f..f40885b 100644 --- a/Makefi

[Qemu-devel] [PATCH 0/2] Buildsystem fix

2012-11-15 Thread Wenchao Xia
Following patch fix a problem and adjust build system, to make it more modulized and easier to extend. Wenchao Xia (2): Buildsystem fix distclean error in pixman Buildsystem clean tests directory clearly Makefile |7 +-- configure |2 +- tests/Makefile |7 +++

Re: [Qemu-devel] [PATCH v6 0/7] TCG global variables clean-up

2012-11-15 Thread Evgeny Voevodin
On 11/12/2012 01:27 PM, Evgeny Voevodin wrote: This set of patches moves global variables to tcg_ctx: gen_opc_ptr gen_opparam_ptr gen_opc_buf gen_opparam_buf Build tested for all targets. Execution tested on Exynos4210 target. After this patchset was aplied, I noticed 0.7% speed-up of code gene

[Qemu-devel] [PATCH] target-mips: Add comments on POOL32Axf encoding

2012-11-15 Thread Wei-Ren Chen
Hi all, Current QEMU MIPS POOL32AXF encoding comes from microMIPS32 and microMIPS32 DSP. Add comment here to help reading. Please review, thanks. Regards, chenwj Signed-off-by: Chen Wei-Ren --- target-mips/translate.c | 17 + 1 files changed, 17 insertions(+), 0 deletion

Re: [Qemu-devel] Question about comment on MIPS POOL32AXF encoding

2012-11-15 Thread Wei-Ren Chen
> Please refer to the following document. > > MIPS® Architecture for Programmers VolumeIV-e: The MIPS® DSP > Application-Specific Extension to the microMIPS32™ Architecture > > http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00764-2B-microMIPS32DSP-AFP-02.34.pdf Thanks, Eri

[Qemu-devel] [PATCH v2] target-mips: Clean up microMIPS32 major opcode

2012-11-15 Thread Wei-Ren Chen
Hi all, I check MIPS microMIPS manual [1], and found the major opcode might be wrong. I add a comment to explicitly indicate what manual I am refering to, and according that manual I remove microMIPS32 major opcodes 0x1f. As for others, like 0x16, 0x17, 0x36 and 0x37, they are for higher-order M

Re: [Qemu-devel] [PATCH v2 000/147] target-s390 reorg

2012-11-15 Thread Richard Henderson
Ping. I've updated the branch at git://repo.or.cz/qemu/rth.git s390-reorg to rebase vs mainline (ce34cf72fe508b27a78f83c184142e8d1e6a048a). There are minor changes due to Aurel's TCG_CALL_NO_* rewrite, but is otherwise unchanged. I can re-post the 140+ patches if required... r~ On 2012-09-

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-15 Thread Richard Henderson
On 2012-11-14 23:47, liu ping fan wrote: > Probably I made a mistake here, in vhost, log = > __sync_fetch_and_and(from, 0) is used to fetch 64bits atomically in > the case 32bits qemu running on 64bits linux. Right? But how can > we read 32bits twice in atomic? Seem that no instruction like

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-15 Thread Stefan Weil
Am 15.11.2012 21:52, schrieb Paolo Bonzini: Il 15/11/2012 19:01, Stefan Weil ha scritto: Hi Paolo, this patch breaks QEMU on 32 and 64 bit hosts, native and with Wine. It's easy to reproduce the SIGSEGV crash: just add a -snapshot option. Obviously the critical code is executed only when this o

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-11-15 Thread Adam Conrad
Hello Robert, or anyone else affected, Accepted qemu-kvm into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/qemu-kvm/1.0+noroms- 0ubuntu14.4 in a few hours, and then in the -proposed repository. Please help us by testing this new package. Se

Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-15 Thread Anthony Liguori
Khoa Huynh writes: > "Michael S. Tsirkin" wrote on 11/15/2012 12:48:49 PM: > >> From: "Michael S. Tsirkin" >> To: Stefan Hajnoczi , >> Cc: qemu-devel@nongnu.org, Anthony Liguori/Austin/IBM@IBMUS, Paolo >> Bonzini , Kevin Wolf , Asias >> He , Khoa Huynh/Austin/IBM@IBMUS >> Date: 11/15/2012 12:46

Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-15 Thread Anthony Liguori
Stefan Hajnoczi writes: > The virtio-blk-data-plane feature is easy to integrate into > hw/virtio-blk.c. The data plane can be started and stopped similar to > vhost-net. > > Users can take advantage of the virtio-blk-data-plane feature using the > new -device virtio-blk-pci,x-data-plane=on prop

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 19:01, Stefan Weil ha scritto: > Hi Paolo, > > this patch breaks QEMU on 32 and 64 bit hosts, native and with Wine. > It's easy to reproduce the SIGSEGV crash: just add a -snapshot option. > Obviously the critical code is executed only when this option was used. I cannot reproduce t

Re: [Qemu-devel] [RFC PATCH v4 2/3] use uimage_reset to reload uimage

2012-11-15 Thread Stuart Yoder
On Wed, Nov 14, 2012 at 2:28 PM, Olivia Yin wrote: > Signed-off-by: Olivia Yin > --- > hw/loader.c | 64 ++ > 1 files changed, 46 insertions(+), 18 deletions(-) > > diff --git a/hw/loader.c b/hw/loader.c > index a8a0a09..1a909d0 100644 >

[Qemu-devel] Fwd: buildbot failure in qemu on ubuntu-default

2012-11-15 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on ubuntu-default Date: Thu, 15 Nov 2012 17:54:06 +0100 From: build...@spunk.home.kraxel.org To: kraxel...@gmail.com The Buildbot has detected a failed build on builder ubuntu-default while building qemu. Full details are avail

Re: [Qemu-devel] [PATCH 3/7] dataplane: add virtqueue vring code

2012-11-15 Thread Anthony Liguori
Stefan Hajnoczi writes: > The virtio-blk-data-plane cannot access memory using the usual QEMU > functions since it executes outside the global mutex and the memory APIs > are this time are not thread-safe. > > This patch introduces a virtqueue module based on the kernel's vhost > vring code. The

Re: [Qemu-devel] [PATCH 1/7] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2012-11-15 Thread Anthony Liguori
Stefan Hajnoczi writes: > The raw_get_aio_fd() function allows virtio-blk-data-plane to get the > file descriptor of a raw image file with Linux AIO enabled. This > interface is really a layering violation that can be resolved once the > block layer is able to run outside the global mutex - at t

Re: [Qemu-devel] [RFC PATCH v4 1/3] use image_file_reset to reload initrd image

2012-11-15 Thread Stuart Yoder
> /* read()-like version */ > ssize_t read_targphys(const char *name, >int fd, hwaddr dst_addr, size_t nbytes) > @@ -113,6 +146,12 @@ int load_image_targphys(const char *filename, > } > if (size > 0) { > rom_add_file_fixed(filename, addr, -1); > +

Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-15 Thread Khoa Huynh
"Michael S. Tsirkin" wrote on 11/15/2012 12:48:49 PM: > From: "Michael S. Tsirkin" > To: Stefan Hajnoczi , > Cc: qemu-devel@nongnu.org, Anthony Liguori/Austin/IBM@IBMUS, Paolo > Bonzini , Kevin Wolf , Asias > He , Khoa Huynh/Austin/IBM@IBMUS > Date: 11/15/2012 12:46 PM > Subject: Re: [PATCH 7/7]

Re: [Qemu-devel] Question about comment on MIPS POOL32AXF encoding

2012-11-15 Thread Johnson, Eric
> -Original Message- > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > bounces+ericj=mips@nongnu.org] On Behalf Of ??? (Wei-Ren Chen) > Sent: Thursday, November 15, 2012 1:03 AM > To: qemu-devel@nongnu.org > Cc: Jia Liu > Subject: [Qemu-devel] Question about com

Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-15 Thread Michael S. Tsirkin
On Thu, Nov 15, 2012 at 04:19:06PM +0100, Stefan Hajnoczi wrote: > The virtio-blk-data-plane feature is easy to integrate into > hw/virtio-blk.c. The data plane can be started and stopped similar to > vhost-net. > > Users can take advantage of the virtio-blk-data-plane feature using the > new -de

Re: [Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c to qdev.c

2012-11-15 Thread Peter Maydell
On 15 November 2012 18:42, Eduardo Habkost wrote: > DeviceState CPUs have to be reset too, and DeviceState uses the > reset-handler system to make sure DeviceState objects are reset, so it > won't be softmmu-specific. > > An alternative is to make empty stubs for qemu_[un]register_reset(), and > n

Re: [Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c to qdev.c

2012-11-15 Thread Eduardo Habkost
On Thu, Nov 15, 2012 at 02:54:57AM +0100, Andreas Färber wrote: > Am 09.11.2012 15:56, schrieb Eduardo Habkost: > > The core qdev code uses the reset handler list from vl.c, so move > > qemu_register_reset(), qemu_unregister_reset() and qemu_devices_reset() > > to qdev.c. > > > > The function decl

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-15 Thread Peter Lieven
Dietmar Maurer wrote: >> > You can also reproduce the problem with RHEL6.2 as guest But it seems >> > RHEL 6.3 fixed it. >> >> RHEL6.2 on ubuntu host? > > I only tested with RHEL6.3 kernel on host. can you check if there is a difference on interrupt delivery between those two? cat /proc/interrupt

Re: [Qemu-devel] [PATCH v2] qga/channel-posix.c: include headers it needs

2012-11-15 Thread Eduardo Habkost
On Thu, Nov 15, 2012 at 02:19:31AM +0100, Igor Mammedov wrote: > From: Eduardo Habkost > > Include: > - for errno > - & for fcntl() > - "qemu-stdio.h" for qemu_open() > > Some of those headers were probably being included by accident because > some other headers were including qemu-common.

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Peter Lieven
Paolo Bonzini wrote: > Il 15/11/2012 15:57, ronnie sahlberg ha scritto: >> I dont know if we should switch to use synchronous code here. >> It is much nicer if all code is async. > > bdrv_open is generally synchronous, so I think Peter's patch is ok. if all is sync wouldn't it be best to have all

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-15 Thread Stefan Weil
Am 31.10.2012 16:30, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini --- cutils.c | 5 - osdep.c | 30 ++ qemu-common.h | 1 - qemu-tool.c | 20 qemu-user.c | 20 5 file modificati, 30 inserzioni

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-15 Thread Thanos Makatos
I'm not sure I understand your question. In XenServer blktap2 we set CHS to 65535*16*255 in the VHD metadata for disks larger than 127GB. We don't really care about these values, we just store them in the VHD metadata. > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.co

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-15 Thread Johnson, Eric
> -Original Message- > From: 陳韋任 (Wei-Ren Chen) [mailto:che...@iis.sinica.edu.tw] > Sent: Wednesday, November 14, 2012 9:51 PM > To: Johnson, Eric > Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org; Jia Liu; Aurelien > Jarno > Subject: Re: [Qemu-devel] [PATCH] target-mips: Clean up microM

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-15 Thread Johnson, Eric
> -Original Message- > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > Sent: Thursday, November 15, 2012 6:04 AM > To: Johnson, Eric > Cc: 陳韋任 (Wei-Ren Chen); qemu-devel@nongnu.org; qemu-triv...@nongnu.org; > che...@cs.nctu.edu.tw; Jia Liu > Subject: Re: [Qemu-devel] [PATCH] target-mip

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-11-15 Thread Serge Hallyn
** Changed in: qemu-kvm (Ubuntu Precise) Status: Triaged => In Progress ** Changed in: qemu-kvm (Ubuntu Quantal) Status: Triaged => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 17:46, Charles Arnold ha scritto: >>> We don't use qemu's VHD driver in XenServer. Instead, we use blktap2 >>> >> to create a block device in dom0 serving the VHD file in question, >>> >> and have qemu open that block device instead of the VHD file itself. >> > >> > Yes, the question

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-11-15 Thread Serge Hallyn
** Also affects: qemu-kvm (Ubuntu Precise) Importance: Undecided Status: New ** Also affects: qemu-kvm (Ubuntu Quantal) Importance: Undecided Status: New ** Changed in: qemu-kvm (Ubuntu Precise) Importance: Undecided => High ** Changed in: qemu-kvm (Ubuntu Quantal) Impo

Re: [Qemu-devel] Question on Xen management of qemu ram blocks and memory regions

2012-11-15 Thread Andres Lagar-Cavilla
On Nov 15, 2012, at 9:33 AM, Stefano Stabellini wrote: > On Wed, 14 Nov 2012, Andres Lagar-Cavilla wrote: >> Stefano, and Xen-qemu team, I have a question. >> >> The standard Xen-qemu workflow has Xen manage the physmap for a VM, and >> allocate all the backing memory for valid pfns, regardle

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-15 Thread Charles Arnold
>>> On 11/14/2012 at 09:35 AM, in message <50a3c853.4010...@redhat.com>, Paolo Bonzini wrote: > Il 14/11/2012 17:25, Thanos Makatos ha scritto: >> We don't use qemu's VHD driver in XenServer. Instead, we use blktap2 >> to create a block device in dom0 serving the VHD file in question, >> and have

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 17:13, ronnie sahlberg ha scritto: > On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini wrote: >> Il 15/11/2012 15:57, ronnie sahlberg ha scritto: >>> I dont know if we should switch to use synchronous code here. >>> It is much nicer if all code is async. >> >> bdrv_open is generally syn

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread ronnie sahlberg
On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini wrote: > Il 15/11/2012 15:57, ronnie sahlberg ha scritto: >> I dont know if we should switch to use synchronous code here. >> It is much nicer if all code is async. > > bdrv_open is generally synchronous, so I think Peter's patch is ok. I was thinkin

[Qemu-devel] Fwd: buildbot failure in qemu on rhel6-default

2012-11-15 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on rhel6-default Date: Thu, 15 Nov 2012 16:25:41 +0100 From: build...@spunk.home.kraxel.org To: kraxel...@gmail.com The Buildbot has detected a failed build on builder rhel6-default while building qemu. Full details are availab

[Qemu-devel] Fwd: buildbot failure in qemu on openbsd-default

2012-11-15 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on openbsd-default Date: Thu, 15 Nov 2012 16:06:14 +0100 From: build...@spunk.home.kraxel.org To: kraxel...@gmail.com The Buildbot has detected a failed build on builder openbsd-default while building qemu. Full details are ava

[Qemu-devel] [PATCH 5/7] dataplane: add Linux AIO request queue

2012-11-15 Thread Stefan Hajnoczi
The IOQueue has a pool of iocb structs and a function to add new read/write requests. Multiple requests can be added before calling the submit function to actually tell the host kernel to begin I/O. This allows callers to batch requests and submit them in one go. The actual I/O is performed usin

[Qemu-devel] [PATCH 2/7] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE

2012-11-15 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature only works with Linux AIO. Therefore add a ./configure option and necessary checks to implement this dependency. Signed-off-by: Stefan Hajnoczi --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index

[Qemu-devel] [PATCH 4/7] dataplane: add event loop

2012-11-15 Thread Stefan Hajnoczi
Outside the safety of the global mutex we need to poll on file descriptors. I found epoll(2) is a convenient way to do that, although other options could replace this module in the future (such as an AioContext-based loop or glib's GMainLoop). One important feature of this small event loop implem

Re: [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 15:42, Peter Lieven ha scritto: > If an invalid URL is specified iscsi_get_error(iscsi) is called > with iscsi == NULL. > > Signed-off-by: Peter Lieven Applied to scsi-next branch, but next time please disable format=flowed if you want to send patches with Thunderbird. It mangles

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-15 Thread Jan Kiszka
Hi Hans, On 2012-11-15 16:19, Hans de Goede wrote: > Hi Jan, > > I just saw your $subject patch in Gerd's usb-next tree, and I've a question > about it. The token should be enough to uniquely identify a device + ep, > and unless a guest uses multiple qhs for a singe ep, that _should_ be enough.

[Qemu-devel] [PATCH 1/7] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2012-11-15 Thread Stefan Hajnoczi
The raw_get_aio_fd() function allows virtio-blk-data-plane to get the file descriptor of a raw image file with Linux AIO enabled. This interface is really a layering violation that can be resolved once the block layer is able to run outside the global mutex - at that point virtio-blk-data-plane wi

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 15:57, ronnie sahlberg ha scritto: > I dont know if we should switch to use synchronous code here. > It is much nicer if all code is async. bdrv_open is generally synchronous, so I think Peter's patch is ok. Paolo > Is it possible to add a timeout instead that would break out if th

[Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-15 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c. The data plane can be started and stopped similar to vhost-net. Users can take advantage of the virtio-blk-data-plane feature using the new -device virtio-blk-pci,x-data-plane=on property. The x-data-plane name was chos

[Qemu-devel] [PATCH 1/2] usb-host: update tracing

2012-11-15 Thread Gerd Hoffmann
Now that we have separate status and length fields in USBPacket update the completion tracepoint to log both. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 20 trace-events|2 +- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/usb/ho

Re: [Qemu-devel] [PATCH 3/7] dataplane: add virtqueue vring code

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 16:19, Stefan Hajnoczi ha scritto: > +/* Map target physical address to host address > + */ > +static inline void *phys_to_host(Vring *vring, hwaddr phys) > +{ > +/* Adjust for 3.6-4 GB PCI memory range */ > +if (phys >= 0x1) { > +phys -= 0x1 - 0xe0

[Qemu-devel] [PATCH 6/7] dataplane: add virtio-blk data plane code

2012-11-15 Thread Stefan Hajnoczi
virtio-blk-data-plane is a subset implementation of virtio-blk. It only handles read, write, and flush requests. It does this using a dedicated thread that executes an epoll(2)-based event loop and processes I/O using Linux AIO. This approach performs very well but can be used for raw image file

[Qemu-devel] [PATCH] vmstate: drop orphan register_device_unmigratable() prototype

2012-11-15 Thread Stefan Hajnoczi
commit 38e0735eb76a1479917ef3501a208d4f70998494 ("ivshmem: use migration blockers to prevent live migration in peer mode (v2)") removed the definition of register_device_unmigratable() but forgot to remove the declaration in the header file. Signed-off-by: Stefan Hajnoczi --- vmstate.h | 3 ---

Re: [Qemu-devel] [PATCH 1/2] usb-host: update tracing

2012-11-15 Thread Hans de Goede
ACK series. Regards, Hans On 11/15/2012 04:19 PM, Gerd Hoffmann wrote: Now that we have separate status and length fields in USBPacket update the completion tracepoint to log both. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 20 trace-events|

[Qemu-devel] [PATCH 2/2] usb-host: fix splitted transfers

2012-11-15 Thread Gerd Hoffmann
USBPacket->actual_length wasn't updated correctly for USBPackets splitted into multiple urbs. Fix it. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index e3d394f..aa77

[Qemu-devel] [PATCH 3/7] dataplane: add virtqueue vring code

2012-11-15 Thread Stefan Hajnoczi
The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are this time are not thread-safe. This patch introduces a virtqueue module based on the kernel's vhost vring code. The trick is that we map guest memory ah

[Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-15 Thread Stefan Hajnoczi
This series adds the -device virtio-blk-pci,x-data-plane=on property that enables a high performance I/O codepath. A dedicated thread is used to process virtio-blk requests outside the global mutex and without going through the QEMU block layer. Khoa Huynh reported an increase from 140,000 IOPS

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-15 Thread Hans de Goede
Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a question about it. The token should be enough to uniquely identify a device + ep, and unless a guest uses multiple qhs for a singe ep, that _should_ be enough. So I'm wondering if you can give a (short) description of exa

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Peter Lieven
Am 15.11.2012 um 15:57 schrieb ronnie sahlberg : > I dont know if we should switch to use synchronous code here. > It is much nicer if all code is async. Of course, but its just the initial login after which qemu should exit if it fails. > > Is it possible to add a timeout instead that would

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread ronnie sahlberg
I dont know if we should switch to use synchronous code here. It is much nicer if all code is async. Is it possible to add a timeout instead that would break out if the connect/login has not completed within a certain amount of time? regards ronnie sahlberg On Thu, Nov 15, 2012 at 6:50 AM, Pete

Re: [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing

2012-11-15 Thread ronnie sahlberg
Acked-By: ronniesahlb...@gmail.com On Thu, Nov 15, 2012 at 6:42 AM, Peter Lieven wrote: > If an invalid URL is specified iscsi_get_error(iscsi) is called > with iscsi == NULL. > > Signed-off-by: Peter Lieven > --- > block/iscsi.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

[Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Peter Lieven
If the connection is interrupted before the first login is successfully completed qemu-kvm is waiting forever in qemu_aio_wait(). This is fixed by performing an sync login to the target. If the connection breaks after the first successful login errors are handled internally by libiscsi. Signed-o

[Qemu-devel] [PATCH] iscsi: fix segfault in url parsing

2012-11-15 Thread Peter Lieven
If an invalid URL is specified iscsi_get_error(iscsi) is called with iscsi == NULL. Signed-off-by: Peter Lieven --- block/iscsi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index d0b1a10..b5c3161 100644 --- a/block/iscsi.c +++ b/block/

Re: [Qemu-devel] Question on Xen management of qemu ram blocks and memory regions

2012-11-15 Thread Stefano Stabellini
On Wed, 14 Nov 2012, Andres Lagar-Cavilla wrote: > Stefano, and Xen-qemu team, I have a question. > > The standard Xen-qemu workflow has Xen manage the physmap for a VM, and > allocate all the backing memory for valid pfns, regardless of whether they > are MMIO, RAM, etc. On save/migrate, when u

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-15 Thread Aurelien Jarno
On Thu, Nov 15, 2012 at 02:34:31AM +, Johnson, Eric wrote: > Hi Chen, > > Please only remove the POOL48A opcode. > > The others are documented in the microMIPS64 Instruction Set manual ( > http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00087-2B-MIPS64BIS-AFP-03.51.pdf >

Re: [Qemu-devel] [PATCH] mips/malta: fix CBUS UART interrupt pin

2012-11-15 Thread Aurelien Jarno
On Wed, Nov 14, 2012 at 07:45:02PM +, Johnson, Eric wrote: > > -Original Message- > > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > > bounces+ericj=mips@nongnu.org] On Behalf Of Aurelien Jarno > > Sent: Wednesday, November 14, 2012 6:38 AM > > To: qemu-dev

[Qemu-devel] KVM Forum 2012 Block BoF minutes

2012-11-15 Thread Markus Armbruster
Attendees: Kevin Wolf Stefan Hajnoczi Jeff Cody Markus Armbruster and a few people dropping in and out. Minutes are basically a TODO list. Could be a bit terse in places; if anything's unclear, please ask. Block layer data structure cleanup: - Split block backend off BlockDriverState -

[Qemu-devel] [PATCH 2/3] usb-redir: Only add actually in flight packets to the in flight queue

2012-11-15 Thread Hans de Goede
Packets which are queued up, but not yet handed over to the device, are *not* in flight. Signed-off-by: Hans de Goede --- hw/usb/redirect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index d9236c5..4cd32d6 100644 --- a/hw/usb/redi

[Qemu-devel] [PATCH 3/3] usb-redir: Set default debug level to warning

2012-11-15 Thread Hans de Goede
The previous default of 0 means that even errors and warnings would not get printed, which is really not a good default. Signed-off-by: Hans de Goede --- hw/usb/redirect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 4cd32d6..c8e

[Qemu-devel] [PATCH 1/3] ehci: Don't verify the next pointer for periodic qh-s and qtd-s

2012-11-15 Thread Hans de Goede
While testing the move to async packet handling for interrupt endpoints I noticed that Windows-XP likes to play tricks with the next pointer for periodic qh-s, so we should not fail qh / qtd verification when it changes. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 9 ++--- 1 file ch

[Qemu-devel] [USB Fixes for 1.3]: ehci + usb-redir fixes for 1.3

2012-11-15 Thread Hans de Goede
As discussed here is one more ehci fix + 2 small usb-redir fixes for 1.3. Regards, Hans

Re: [Qemu-devel] [PATCH] ehci: handle dma errors

2012-11-15 Thread Hans de Goede
Looks good, ack. On 11/15/2012 01:22 PM, Gerd Hoffmann wrote: Starting with commit 1c380f9460522f32c8dd2577b2a53d518ec91c6d dma transfers can actually fail. This patch makes ehci keep track of the busmaster bit in pci config space, by setting/clearing the dma_context pointer. Attempts to dma

[Qemu-devel] [PATCH v2 2/2] block: Avoid second open for format probing

2012-11-15 Thread Kevin Wolf
This fixes problems that are caused by the additional open/close cycle of the existing format probing, for example related to qemu-nbd without -t option or file descriptor passing. Signed-off-by: Kevin Wolf --- block.c | 66 -- 1 file

[Qemu-devel] [PATCH v2 1/2] block: Factor out bdrv_open_flags

2012-11-15 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 35 +-- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/block.c b/block.c index bf0747f..95fd00e 100644 --- a/block.c +++ b/block.c @@ -634,6 +634,26 @@ void bdrv_disable_copy_on_read(BlockDriverState *bs)

[Qemu-devel] [PATCH v2 0/2] block: Avoid second open for format probing

2012-11-15 Thread Kevin Wolf
Kevin Wolf (2): block: Factor out bdrv_open_flags block: Avoid second open for format probing block.c | 101 -- 1 files changed, 59 insertions(+), 42 deletions(-) -- 1.7.6.5

Re: [Qemu-devel] [RFC] libqblock OOM issue

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 13:21, Wenchao Xia ha scritto: > >>>Personally agree, but I want to add a simple wrapper to let libqblock >>> get user faster. In this way I guess best choice now is making rpc >>> client and server not mirrored in implemention, server provides >>> r/w/info retrieving capabilitie

Re: [Qemu-devel] [RFC] libqblock OOM issue

2012-11-15 Thread Wenchao Xia
> Il 15/11/2012 05:18, Wenchao Xia ha scritto: Personally agree, but I want to add a simple wrapper to let libqblock get user faster. In this way I guess best choice now is making rpc client and server not mirrored in implemention, server provides r/w/info retrieving capabilities via XDR proto

[Qemu-devel] [PATCH] ehci: handle dma errors

2012-11-15 Thread Gerd Hoffmann
Starting with commit 1c380f9460522f32c8dd2577b2a53d518ec91c6d dma transfers can actually fail. This patch makes ehci keep track of the busmaster bit in pci config space, by setting/clearing the dma_context pointer. Attempts to dma without context will result in raising HSE (Host System Error) int

Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes

2012-11-15 Thread Gerd Hoffmann
Hi, >> Ok, so it looks like 1-3 are clear bugfixes which are needed in 1.3 >> > Moving it forward in the patch-set will cause a conflict though, I'll go > and > do the reshuffle myself, throw in 2 usb-redir fixes and then send a new set Oh, and I've picked 1-3 already, no need to resend them.

Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes

2012-11-15 Thread Gerd Hoffmann
On 11/15/12 12:58, Hans de Goede wrote: > Hi, > > On 11/15/2012 09:55 AM, Gerd Hoffmann wrote: >> On 11/14/12 17:21, Hans de Goede wrote: >>> While working on moving usb-redir and usb-hid over to using async packet >>> handling for their interrupt input endpoints. I've found and fixed quite >>> a

Re: [Qemu-devel] Virtio refactoring.

2012-11-15 Thread Cornelia Huck
On Thu, 15 Nov 2012 11:32:13 +0100 KONRAD Frédéric wrote: > For the qtree structure we have eg for virtio block : > > bus: main-system-bus >type System >dev: pcihost, id "" > bus: pci.0 >type PCI >dev: virtio-blk-pci, id "" > ... > My current virtio-ccw l

Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes

2012-11-15 Thread Hans de Goede
Hi, On 11/15/2012 09:55 AM, Gerd Hoffmann wrote: On 11/14/12 17:21, Hans de Goede wrote: While working on moving usb-redir and usb-hid over to using async packet handling for their interrupt input endpoints. I've found and fixed quite a few ehci bugs. Unfortunately the moving to async for inte

Re: [Qemu-devel] Fwd: buildbot failure in qemu on rhel5-default

2012-11-15 Thread Peter Maydell
On 15 November 2012 08:22, Gerd Hoffmann wrote: > CCs390x-softmmu/hw/s390x/event-facility.o > cc1: warnings being treated as errors > /home/buildbot/slave-spunk/rhel5-default/build/hw/s390x/event-facility.c: In > function ‘command_handler’: > /home/buildbot/slave-spunk/rhel5-default/build/hw

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 08:47, liu ping fan ha scritto: RCU prototype required pointer-sized access, which you cannot make type- >>> But I think that your RCU prototype should rely on atomic of CPU, not >>> gcc‘s atomic. >> >> What's the difference? gcc's atomic produces the same instructions as >> han

Re: [Qemu-devel] Virtio refactoring.

2012-11-15 Thread KONRAD Frédéric
Hi, On 13/11/2012 19:09, Cornelia Huck wrote: On Tue, 13 Nov 2012 17:31:40 +0100 KONRAD Frédéric wrote: We'd go from system bus -> virtio transport bridge dev (virtio-xxx-bridge) -> virtio transport bus (virtio-xxx-bus) -> virtio transport dev (virtio--xxx) to system bus -> vi

Re: [Qemu-devel] [RFC] libqblock OOM issue

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 05:18, Wenchao Xia ha scritto: > Personally agree, but I want to add a simple wrapper to let libqblock > get user faster. In this way I guess best choice now is making rpc > client and server not mirrored in implemention, server provides > r/w/info retrieving capabilities via XDR pr

Re: [Qemu-devel] [PATCH] Add domain-search option to slirp's DHCP server

2012-11-15 Thread Jan Kiszka
On 2012-10-27 19:53, Klaus Stengel wrote: > This patch will allow the user to include the domain-search option in > replies from the built-in DHCP server. The domain suffixes can be > specified by adding dnssearch= entries to the "-net user" parameter. > > Signed-off-by: Klaus Stengel > --- > ne

Re: [Qemu-devel] [PATCH v2] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-15 Thread Jan Kiszka
On 2012-11-12 17:59, Nickolai Zeldovich wrote: > LWIP can generate packets with a source of 0.0.0.0, which triggers an > assertion failure in arp_table_add(). Instead of crashing, simply return > to avoid adding an invalid ARP table entry. > > Signed-off-by: Nickolai Zeldovich > --- > slirp/arp

Re: [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors

2012-11-15 Thread Gerd Hoffmann
On 11/15/12 09:31, Jan Kiszka wrote: >> > I'd prefer to keep the error jump target to handle the parse error here. >> > Dumping the reset there is fine with me, but I'd prefer this event being >> > logged (trace point or stderr message or both) to ease trouble shooting >> > in case a device doesn't

Re: [Qemu-devel] [PATCH] usb: uhci: Look up queue by address, not token

2012-11-15 Thread Gerd Hoffmann
On 11/15/12 09:20, Jan Kiszka wrote: > -if (queue->token == token) { > +if (queue->qh_addr == qh_addr) { Patch added to usb patch queue. thanks, Gerd

  1   2   >