Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-12 Thread liu ping fan
On Mon, Nov 12, 2012 at 5:54 PM, Paolo Bonzini wrote: > Il 05/11/2012 06:38, Liu Ping Fan ha scritto: >> From: Liu Ping Fan >> >> If out of global lock, we will be challenged by SMP in low level, >> so need atomic ops. >> >> This file is a wrapper of GCC atomic builtin. > > I still object to this

Re: [Qemu-devel] [PATCH v6 3/8] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-11-12 Thread liu ping fan
On Mon, Nov 12, 2012 at 5:27 PM, Paolo Bonzini wrote: > Il 05/11/2012 06:38, Liu Ping Fan ha scritto: >> +void qdev_unplug_complete(DeviceState *dev, Error **errp) >> +{ >> +/* isolate from mem view */ >> +qdev_unmap(dev); >> +/* isolate from device tree */ >> +qdev_unset_parent(de

Re: [Qemu-devel] [RFC v1 2/3] ramlist: apply fine grain lock for ram_list

2012-11-12 Thread liu ping fan
On Mon, Nov 12, 2012 at 4:48 PM, Paolo Bonzini wrote: > Il 12/11/2012 07:22, liu ping fan ha scritto: >> On Sat, Nov 10, 2012 at 9:54 AM, Paolo Bonzini wrote: >>> Il 09/11/2012 04:14, Liu Ping Fan ha scritto: From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- cpu-all.h

Re: [Qemu-devel] [PATCH v3 2/2] qemu-ga: sample fsfreeze hooks

2012-11-12 Thread Tomoki Sekiyama
Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot Signed-off-by: Tomoki Sekiyama --- docs/qemu-guest-agent/fsfreeze-hook| 31 +

Re: [Qemu-devel] [PATCH v3 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-12 Thread Tomoki Sekiyama
To use the online disk snapshot for online-backup, application-level consistency of the snapshot image is required. However, currently the guest agent can provide only filesystem-level consistency, and the snapshot may contain dirty data, for example, incomplete transactions. This patch provides th

[Qemu-devel] [PATCH v3 0/2] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-12 Thread Tomoki Sekiyama
Hi, This is version 3 of the qemu-ga fsfreeze hook patchset. *Changes from v2: ( https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00918.html ) 1/2: Not changed. 2/2: fsfreeze-hook: Fixed typo. mysql-flush.sh: Use printf instead of echo to make it portable --- Tomoki Sekiyam

Re: [Qemu-devel] [PATCH v2 2/2] qemu-ga: sample fsfreeze hooks

2012-11-12 Thread Tomoki Sekiyama
Hi Eric, thank you for the review again. On 2012/11/13 7:16, Eric Blake wrote: > On 11/12/2012 02:32 AM, Tomoki Sekiyama wrote: >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. >> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ >> - fsfreeze-hook.d.sample/mysql-flush.sh

[Qemu-devel] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-12 Thread David Gibson
From: Alexey Kardashevskiy In future (with VFIO) we will have multiple PCI host bridges on pseries. Each one needs a unique LIOBN (IOMMU id). At the moment we derive these from the pci domain number, but the whole notion of domain numbers on the qemu side is bogus and in any case they're not ac

[Qemu-devel] [PATCH 09/12] pseries: Implement PAPR NVRAM

2012-11-12 Thread David Gibson
The PAPR specification requires a certain amount of NVRAM, accessed via RTAS, which we don't currently implement in qemu. This patch addresses this deficiency, implementing the NVRAM as a VIO device, with some glue to instantiate it automatically based on a machine option. The machine option spec

[Qemu-devel] [PATCH 02/12] pseries: Use #define for XICS base irq number

2012-11-12 Thread David Gibson
From: Ben Herrenschmidt Currently the lowest "real" irq number for the XICS irq controller (as opposed to numbers reserved for IPIs and other special purposes) is hard coded as 16 in two places - in xics_system_init() and in spapr.c. As well as being generally bad practice, we're going to need t

[Qemu-devel] [PATCH 04/12] pseries: Return the token when we register an RTAS call

2012-11-12 Thread David Gibson
From: Michael Ellerman The kernel will soon be able to service some RTAS calls. However the choice of tokens will still be up to userspace. To support this have spapr_rtas_register() return the token that is allocated for an RTAS call, that allows the calling code to tell the kernel what the toke

[Qemu-devel] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization

2012-11-12 Thread David Gibson
From: Ben Herrenschmidt Currently, the pseries machine initializes the cpus, then the XICS interrupt controller. However, to support the upcoming in-kernel XICS implementation we will need to initialize the irq controller before the vcpus. This patch makes the necesssary rearrangement. This me

[Qemu-devel] [PATCH 01/12] pseries: Fix incorrect initialization of interrupt controller

2012-11-12 Thread David Gibson
Currently in the reset code for the XICS interrupt controller, we initialize the pending_priority field to 0 (most favored, by XICS convention). This is incorrect, since there is no pending interrupt, it should be set to least favored - 0xff. At the moment our XICS implementation doesn't get hurt

[Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-12 Thread David Gibson
Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models to represent a TLB entry contains a hwaddr. That works reasonably for now, but is troublesome for saving the state, which we'll want to do in future. hwaddr is a large enough type to contain a physical address for any suppo

[Qemu-devel] [0/12] Pending pseries patches

2012-11-12 Thread David Gibson
Here again is my current set of outstanding pseries patches, updated for current upstream. I don't think any of these has changed in substance since their last posting. As explained last time around, some of the From/Signed-off-by combinations are a bit odd, but I think as accurate reflection of

[Qemu-devel] [PATCH 11/12] pseries: Fix bug in PCI MSI allocation

2012-11-12 Thread David Gibson
From: Alexey Kardashevskiy In one of the recent reworks to the XICS code, a bug was introduced where we use the wrong sense and allocate level interrupts instead of message interrupts for PCI MSIs. This patch fixes it. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- hw/sp

[Qemu-devel] [PATCH 07/12] pseries: Split xics irq configuration from state information

2012-11-12 Thread David Gibson
Currently the XICS irq controller code has a per-irq state structure which amongst other things includes whether the interrupt is level or message triggered - this is configured by the platform code, and is not directly visible to the guest. This leads to a slightly awkward construct at reset time

[Qemu-devel] [PATCH 06/12] pseries: Add tracepoints to the XICS interrupt controller

2012-11-12 Thread David Gibson
This patch adds tracing / debugging calls to the XICS interrupt controller implementation used on the pseries machine. Signed-off-by: Ben Herrenschmidt Signed-off-by: David Gibson --- hw/xics.c| 23 --- trace-events | 13 + 2 files changed, 33 insertions(

[Qemu-devel] [PATCH 05/12] pseries: Allow RTAS tokens without a qemu handler

2012-11-12 Thread David Gibson
From: Ben Herrenschmidt Kernel-based RTAS calls will not have a qemu handler, but will still be registered in qemu in order to be assigned a token number and appear in the device-tree. Let's test for the name being NULL rather than the handler when deciding to skip an entry while building the de

Re: [Qemu-devel] [PATCH v11] kvm: notify host when the guest is panicked

2012-11-12 Thread Marcelo Tosatti
On Fri, Nov 09, 2012 at 03:17:39PM -0500, Sasha Levin wrote: > On Mon, Nov 5, 2012 at 8:58 PM, Hu Tao wrote: > > But in the case of panic notification, more dependency means more > > chances of failure of panic notification. Say, if we use a virtio device > > to do panic notification, then we will

Re: [Qemu-devel] [PATCH 2/3] s390: Virtual channel subsystem support.

2012-11-12 Thread Marcelo Tosatti
Hi Cornelia, On Wed, Oct 31, 2012 at 05:24:47PM +0100, Cornelia Huck wrote: > Provide a mechanism for qemu to provide fully virtual subchannels to > the guest. In the KVM case, this relies on the kernel's css support > for I/O and machine check interrupt handling. The !KVM case handles > interrupt

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-11-12 Thread Serge Hallyn
Thanks, this still applies upstream as well. ** Changed in: qemu-kvm (Ubuntu) Status: New => Triaged ** Changed in: qemu-kvm (Ubuntu) Importance: Undecided => High ** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are

[Qemu-devel] [PATCH 00/17] target-i386: CPU init cleanup for CPU classes/properties

2012-11-12 Thread Eduardo Habkost
Hi, One of the problems when coordinating with the recent x86 CPU work (CPU properties, APIC ID topology fixes) is to have a sane x86 CPU initialization code to be used as base. To make things worse, the cleanups we're doing are buried inside series that do more intrusive work. This is an attempt

[Qemu-devel] [PATCH 14/17] target-i386: cpu_x86_init(): rename cpu_model to cpu_string

2012-11-12 Thread Eduardo Habkost
Rename the variable, to avoid confusion between the actual CPU model name and the -cpu string argument (that may contain additional parameters). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/targ

[Qemu-devel] [PATCH 02/17] target-i386: move cpu_x86_init() to cpu.c

2012-11-12 Thread Eduardo Habkost
Eventually all of the CPU init code will probably become just a simple object_new() call, with some arch-independent function that handles the CPU model string parsing. But right now we need to reorder and split many of the steps invoved in the CPU model string parsing and CPU object creation, and

[Qemu-devel] [PATCH 11/17] target-i386: return Error from cpu_x86_find_by_name()

2012-11-12 Thread Eduardo Habkost
It will allow us to use property setters there later. Signed-off-by: Igor Mammedov [ehabkost: rebased on top of CPU classes work in progress] Signed-off-by: Eduardo Habkost --- v2: - style change, add braces (requested by Blue Swirl) - removed unused error_is_set(errp) in properties set

Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation

2012-11-12 Thread Eduardo Habkost
On Mon, Nov 12, 2012 at 10:18:29PM +, Peter Maydell wrote: > On 12 November 2012 22:16, Eduardo Habkost wrote: > > > > Sorry for replying to a patch 7 months later, but I just have a question > > related to how we will handle CPU model classes on all targets: > > > > On Sat, Apr 14, 2012 at 05

Re: [Qemu-devel] KVM call agenda for 2012-11-12

2012-11-12 Thread Marcelo Tosatti
On Mon, Nov 12, 2012 at 01:58:38PM +0100, Juan Quintela wrote: > > Hi > > Please send in any agenda topics you are interested in. > > Later, Juan. It would be good to have a status report on qemu-kvm compatibility (the remaining TODO items are with Anthony). They are: - qemu-kvm 1.2 machine ty

[Qemu-devel] [PATCH] vga: fix mmio vga register mapping

2012-11-12 Thread Gerd Hoffmann
--- hw/vga-pci.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/vga-pci.c b/hw/vga-pci.c index ec29cac..947e35c 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -84,9 +84,10 @@ static void pci_vga_ioport_write(void *ptr, hwaddr addr,

Re: [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory

2012-11-12 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: > The bsd-user/qemu-types.h and linux-user/qemu-types.h files are almost > the same, but linux-user have the additional definitions of tswapal(). > > This moves the linux-user file to the main directory, so the same file > can be used by linux-user and

[Qemu-devel] [PATCH 04/17] target-i386: x86_cpudef_setup(): cosmetic change on comment

2012-11-12 Thread Eduardo Habkost
There are no "cpudef" models, all of them are builtin, now. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2dfcc9c..73b0fa1 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu

Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation

2012-11-12 Thread Peter Maydell
On 12 November 2012 22:16, Eduardo Habkost wrote: > > Sorry for replying to a patch 7 months later, but I just have a question > related to how we will handle CPU model classes on all targets: > > On Sat, Apr 14, 2012 at 05:42:10PM +0100, Peter Maydell wrote: >> Register subclasses for each ARM CP

Re: [Qemu-devel] [PATCH v2 2/2] qemu-ga: sample fsfreeze hooks

2012-11-12 Thread Eric Blake
On 11/12/2012 02:32 AM, Tomoki Sekiyama wrote: > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot > > Signed-off-by: Tomoki Sekiyama > --- > +LOGFI

[Qemu-devel] [PATCH 12/17] target-i386: cpu_x86_find_by_name(): split CPU model and feature string first

2012-11-12 Thread Eduardo Habkost
Instead of using strtok() for the whole cpu_model string, first split it into the CPU model name and the full feature string, then parse the feature string into pieces. When using CPU model classes, those two pieces of information will be used at different moments (CPU model name will be used to f

Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation

2012-11-12 Thread Eduardo Habkost
Sorry for replying to a patch 7 months later, but I just have a question related to how we will handle CPU model classes on all targets: On Sat, Apr 14, 2012 at 05:42:10PM +0100, Peter Maydell wrote: > Register subclasses for each ARM CPU implementation (with the > exception of "pxa270", which is

Re: [Qemu-devel] [PATCH 03/24] qemu-common.h: comment about usage rules

2012-11-12 Thread Eduardo Habkost
On Mon, Nov 12, 2012 at 10:57:42PM +0100, Andreas Färber wrote: > Am 09.11.2012 15:56, schrieb Eduardo Habkost: > > Every time we make a tiny change on a header file, we often find > > circular header dependency problems. To avoid this nightmare, we need to > > stop including qemu-common.h on other

[Qemu-devel] [PATCH 07/17] target-i386: cpu_x86_register(): report errors using Error parameter

2012-11-12 Thread Eduardo Habkost
Do it using a local Error variable and error_propagate(), so we don't miss any error reported by the property setters in case errp is NULL. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i

Re: [Qemu-devel] [PATCH 03/24] qemu-common.h: comment about usage rules

2012-11-12 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: > Every time we make a tiny change on a header file, we often find > circular header dependency problems. To avoid this nightmare, we need to > stop including qemu-common.h on other headers, and we should gradually "from other headers" as below? > mov

[Qemu-devel] [PATCH 15/17] target-i386: cpu_x86_init(): eliminate extra 'def1' variable

2012-11-12 Thread Eduardo Habkost
Just use '&def' where a pointer to the under-construction X86CPUDefinition struct is being used. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 57acf3a..9b8e480 100644 --

[Qemu-devel] [RFC] target-i386: register a class for each CPU model

2012-11-12 Thread Eduardo Habkost
This creates the following class hierarchy: - TYPE_X86_CPU ("-cpu") - TYPE_X86_DEFCPU "-cpu-predefined": abstract base class for the predefined CPU models - "-cpu-model-": a class for each predefined CPU model - TYPE_X86_HOST_CPU ("-cpu-model-host"): class for the "-cpu host" CPU model

[Qemu-devel] [PATCH 13/17] target-i386: cpu: create cpu_x86_find_cpudef() function

2012-11-12 Thread Eduardo Habkost
Move the code that looks for a given CPU model to a separate function. This will make it easier to separate the cpudef lookup code and the feature string parsing code, later. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 36 1 file changed, 28 inser

Re: [Qemu-devel] [PATCH 02/24] user: rename qemu-types.h to qemu-user-types.h

2012-11-12 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: > The header file is specific for *-user, but I plan to introduce a more > generic qemu-types.h file, so I'm renaming it. > > Signed-off-by: Eduardo Habkost linux-user builds okay and the bsd-user change looks fine, too. git-grep shows no more occurr

[Qemu-devel] [PATCH 01/17] target-i386/cpu.c: coding style fix

2012-11-12 Thread Eduardo Habkost
Use spaces instead of tabs on cpu_x86_cpuid(). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e1db639..fa8b5bd 100644 --- a/target-i386/cpu.c +++ b/targe

[Qemu-devel] [PATCH 16/17] target-i386: cpu: separate cpudef lookup from feature string parsing

2012-11-12 Thread Eduardo Habkost
- Move the CPU string split and cpudef lookup to cpu_x86_init(); - Rename cpu_x86_find_by_name() to cpu_x86_parse_feature_string(), and make it just get the feature string as input. This will allow us to use the CPU model name for the CPU class lookup, inside cpu_x86_init(). Signed-off-by: Edua

[Qemu-devel] [PATCH 17/17] target-i386: cpu_x86_init(): reorder split of CPU string and creation of CPU object

2012-11-12 Thread Eduardo Habkost
A step towards making the creation of CPU objects use the CPU model name as class name. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e47ec5d..5f2ce7d 100644

[Qemu-devel] [PATCH 06/17] target-i386: cpu_x86_init(): print error message in case of error

2012-11-12 Thread Eduardo Habkost
Error information is being ignored and never returned to the caller. While we don't change cpu_x86_init() to not return error information, print error message inside cpu_x86_init() in case of error. Signed-off-by: Eduardo Habkost --- Changes v2: - Use error_report() - Add "cpu_x86_init:" prefi

[Qemu-devel] [PATCH 09/17] target-i386: move out CPU features initialization to separate func

2012-11-12 Thread Eduardo Habkost
From: Igor Mammedov Later it will be used in cpu_x86_init() to init CPU from found cpudef. This is will make it easier to reorder and clean up the cpu_x86_init() code later. Signed-off-by: Igor Mammedov [ehabkost: added error reporting to function] Signed-off-by: Eduardo Habkost --- v2: -

[Qemu-devel] [PATCH 08/17] target-i386: cpu_x86_register(): reorder CPU property setting

2012-11-12 Thread Eduardo Habkost
Trivial code movement, before moving the code to another function. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 9334e0c..7f4e8f0 100644 --- a/target-i386/cpu.c +++ b/ta

[Qemu-devel] [PATCH 10/17] target-i386: kill cpu_x86_register()

2012-11-12 Thread Eduardo Habkost
Move the cpu_x86_register() code inside cpu_x86_init(), as the initialization steps are going to be reordered. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c in

[Qemu-devel] [PATCH 05/17] target-i386: cpu_x86_init(): move error handling to end of function

2012-11-12 Thread Eduardo Habkost
Doing error handling on a single place will make it easier to make sure memory is freed, and that error information is properly printed or returned to the caller. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 03/17] target-i386: cpu: rename x86_def_t to X86CPUDefinition

2012-11-12 Thread Eduardo Habkost
Change to match QEMU coding style. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b50ca8c..2dfcc9c 100644 --- a/target-i386/cpu.c +++ b/target

Re: [Qemu-devel] DOS boot problem with LSI 53C895A SCSI controller and LSI option ROM

2012-11-12 Thread Gerhard Wiesinger
On 12.11.2012 09:26, Paolo Bonzini wrote: Il 10/11/2012 22:39, Gerhard Wiesinger ha scritto: Hello, I bisected down a DOS boot problem with LSI 53C895A SCSI controller and LSI option ROM to the following commit: e93176d55f1eb4be1a366b51afeaf4f4c8c31d75 The emulation is known to be incomplete;

[Qemu-devel] [PATCHv3 5/5] seccomp: adding debug mode

2012-11-12 Thread Eduardo Otubo
This patch is meant for developer debug purposes only. It adds support that displays the offending system call number if QEMU is being killed by seccomp. The offending system call may need to be added to the appropriate system call white list in qemu-seccomp.c to prevent seccomp from killing QEMU

[Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-12 Thread Eduardo Otubo
According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist when using Qemu with Libvirt. [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 v2: Adding new syscalls to the list: readlink, rt_sigpending, and rt_sigtimedwait v3: * Added new syscalls based o

[Qemu-devel] [PATCH] vga: fix bochs alignment issue

2012-11-12 Thread Gerd Hoffmann
The bochs dispi interface traditionally uses port 0x1ce as 16bit index register and port 0x1cf as 16bit data register. The later is unaligned, and probably for that reason the the data register was moved to 0x1d0 for non-x86 archs. This patch makes the data register available at 0x1d0 on x86 too.

[Qemu-devel] [PATCHv3 4/5] seccomp: double whitelist support

2012-11-12 Thread Eduardo Otubo
This patch includes a second whitelist right before the main loop. The second whitelist is more restricted and does not contain execve(). Although it works fine the way it is now, it's optimal to update and fine tune it. v2: * ctx changed to main_loop_ctx * seccomp_on now inside ifdef * op

[Qemu-devel] [PATCHv3 2/5] seccomp: setting "-sandbox on" as deafult

2012-11-12 Thread Eduardo Otubo
Now the seccomp filter will be set to "on" even if no argument "-sandbox" is given. v3: * Introduced seccomp_states enum and new functions named seccomp_set_state() and seccomp_get_state() (pbonz...@redhat.com). * Merged seccomp_start() and install_seccomp_filter(), moved inst

[Qemu-devel] [PATCHv3 3/5] net: Disallow device hotplug that causes execve()

2012-11-12 Thread Eduardo Otubo
We'll soon be introducing a second whitelist that prevents execve() right before the main_loop() is entered. In preparation, we need to gracefully disable use of exec'd scripts/binaries when hotplugging network devices. For example, the following will not be allowed: netdev_add tap,id=tapdev0 ne

Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field

2012-11-12 Thread Charles Arnold
Ping? Is this ok? - Charles >>> On 11/2/2012 at 09:54 AM, in message <50a0e829.5b74.009...@suse.com>, >>> Charles Arnold wrote: > block/vpc: Initialize the uuid field in the footer with a generated uuid. > > Signed-off-by: Charles Arnold > > diff --git a/block/vpc.c b/block/vpc.c > index b6

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-12 Thread Charles Arnold
Ping? Any thoughts on whether this is acceptable? - Charles >>> On 10/30/2012 at 08:59 PM, in message <50a0e561.5b74.009...@suse.com>, >>> Charles Arnold wrote: > The VHD specification allows for up to a 2 TB disk size. The current > implementation in qemu emulates EIDE and ATA-2 hardware whic

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-11-12 Thread Corey Bryant
On 11/12/2012 08:16 AM, Stefan Berger wrote: On 11/08/2012 10:39 AM, Corey Bryant wrote: Thanks for your responses. I have a few comments below. On 10/24/2012 02:46 PM, Stefan Berger wrote: On 09/27/2012 10:22 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +

[Qemu-devel] [PATCH v2] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-12 Thread Nickolai Zeldovich
LWIP can generate packets with a source of 0.0.0.0, which triggers an assertion failure in arp_table_add(). Instead of crashing, simply return to avoid adding an invalid ARP table entry. Signed-off-by: Nickolai Zeldovich --- slirp/arp_table.c |4 +++- 1 file changed, 3 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-12 Thread Jan Kiszka
On 2012-11-12 15:41, Nickolai Zeldovich wrote: > On Mon, Nov 12, 2012 at 4:37 AM, Jan Kiszka wrote: >> On 2012-11-12 01:59, Nickolai Zeldovich wrote: >>> LWIP can generate packets with a source of 0.0.0.0, which triggers an >>> assertion failure in arp_table_add(). Instead of crashing, simply ret

Re: [Qemu-devel] [PATCH] aio: fix aio_ctx_prepare with idle bottom halves

2012-11-12 Thread malc
On Mon, 12 Nov 2012, Paolo Bonzini wrote: > Commit ed2aec4867f0d5f5de496bb765347b5d0cfe113d changed the return > value of aio_ctx_prepare from false to true when only idle bottom > halves are available. This broke PC old-style DMA, which uses them. > Fix this by making aio_ctx_prepare return true

[Qemu-devel] -mtdblock QEMU option

2012-11-12 Thread Vipin Gahlaut
Hi Experts, QEMU 1.2.0 Virtual Platform:versatilepb Linux Kernel:3.5.5 Command to run QEMU: /usr/local/bin/qemu-system-arm -M versatilepb -kernel /home/vgahlaut/labs/linux-3.5.5/arch/arm/boot/zImage -nographic -hda /home/vgahlaut/labs/disk.img -append "root

Re: [Qemu-devel] [PULL 1.3 0/5] SCSI updates for 2012-11-12

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 15:03, Paolo Bonzini ha scritto: > Anthony, > > The following changes since commit 3c5645fab3c4b65d0cffbe1aaafc787e4be63d0f: > > tcg: properly check that op's output needs to be synced to memory > (2012-11-11 16:06:46 +0100) > > are available in the git repository at: > > git

Re: [Qemu-devel] [PATCH] megasas: Correct target/lun mapping

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 15:42, Hannes Reinecke ha scritto: > The structure to reference a logical drive has an unused field, > which can be used to carry the lun ID. This enabled seabios to > establish the proper target/LUN mapping. > > Signed-off-by: Hannes Reinecke > Cc: Paolo Bonzini > Cc: Gerd Hofmann

[Qemu-devel] [PATCH] megasas: Correct target/lun mapping

2012-11-12 Thread Hannes Reinecke
The structure to reference a logical drive has an unused field, which can be used to carry the lun ID. This enabled seabios to establish the proper target/LUN mapping. Signed-off-by: Hannes Reinecke Cc: Paolo Bonzini Cc: Gerd Hofmann diff --git a/hw/megasas.c b/hw/megasas.c index 7a2036e..395f

Re: [Qemu-devel] qemu and transparent huge pages

2012-11-12 Thread Michael Tokarev
Ping^2 ? Thanks, /mjt 16.09.2012 15:19, Michael Tokarev wrote: > So, is the patch okay? > > Thanks, > > /mjt > > On 15.08.2012 19:03, Michael Tokarev wrote: >> On 15.08.2012 18:26, Avi Kivity wrote: >>> On 08/15/2012 05:22 PM, Michael Tokarev wrote: >>> > > Please provide extra info,

Re: [Qemu-devel] q35, usb-ehci1, and Mac OS X boot problems

2012-11-12 Thread Gabriel L. Somlo
Gerd, On Mon, Nov 12, 2012 at 11:26:18AM +0100, Gerd Hoffmann wrote: > Seems macos doesn't like something in our ehci emulation ... > Can you send a trace with all ehci tracepoints enabled? For brevity, I replaced each cluster of six "Port X not enabled" lines with one "Port 0..5 not enabled", bu

Re: [Qemu-devel] [PATCH] Revert "serial: fix retry logic"

2012-11-12 Thread Michael Tokarev
Ping^2 ? /mjt 27.10.2012 12:31, Michael Tokarev wrote: > Ping? > > On 19.09.2012 12:08, Michael Tokarev wrote: >> This reverts commit 67c5322d7000fd105a926eec44bc1765b7d70bdd: >> >> I'm not sure if the retry logic has ever worked when not using FIFO >> mode. I >> found this while writi

[Qemu-devel] [PATCH 3/7] nbd: accept URIs

2012-11-12 Thread Paolo Bonzini
The URI syntax is consistent with the Gluster syntax. Export names are specified in the path, preceded by one or more (otherwise unused) slashes. Signed-off-by: Paolo Bonzini --- block/nbd.c | 98 ++- qemu-doc.texi | 25 ++-

[Qemu-devel] [PATCH] ehci: fix compile error with EHCI_DEBUG enabled

2012-11-12 Thread Gabriel L. Somlo
This patch fixes a few debugging print statements whose arguments fell out of sync over time with changes being made to the active code base. Signed-off-by: Gabriel Somlo --- On Mon, Nov 12, 2012 at 11:26:18AM +0100, Gerd Hoffmann wrote: > Seems macos doesn't like something in our ehci emulation

Re: [Qemu-devel] [PATCH] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-12 Thread Nickolai Zeldovich
On Mon, Nov 12, 2012 at 4:37 AM, Jan Kiszka wrote: > On 2012-11-12 01:59, Nickolai Zeldovich wrote: >> LWIP can generate packets with a source of 0.0.0.0, which triggers an >> assertion failure in arp_table_add(). Instead of crashing, simply return >> to avoid adding an invalid ARP table entry. >

[Qemu-devel] [PATCH 5/7] nbd: force read-only export for read-only devices

2012-11-12 Thread Paolo Bonzini
This is the desired behavior for HMP, but it is a better choice for QMP as well. Signed-off-by: Paolo Bonzini --- blockdev-nbd.c | 7 +++ 1 file modificato, 7 inserzioni(+) diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 274fba6..e362572 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @

[Qemu-devel] [PATCH 4/7] nbd: fix nbd_server_stop crash when no server was running

2012-11-12 Thread Paolo Bonzini
This failed on the new assertion of qemu_set_fd_handler2: qemu-system-x86_64: /home/pbonzini/work/upstream/qemu/iohandler.c:60: qemu_set_fd_handler2: Assertion `fd >= 0' failed. Signed-off-by: Paolo Bonzini --- blockdev-nbd.c | 8 +--- 1 file modificato, 5 inserzioni(+), 3 rimozioni(-) di

[Qemu-devel] [PATCH 2/5] virtio-scsi: factor checks for VIRTIO_SCSI_S_DRIVER_OK when reporting events

2012-11-12 Thread Paolo Bonzini
Suggested by Laszlo Ersek. Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 8 +--- 1 file modificato, 5 inserzioni(+), 3 rimozioni(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index b54c789..30d3f8a 100644 --- a/hw/virtio-scsi.c +++ b/hw/virtio-scsi.c @@ -596,6 +596,10 @@ static

[Qemu-devel] [PATCH 6/7] nbd: disallow nbd-server-add before nbd-server-start

2012-11-12 Thread Paolo Bonzini
It works nicely with the QMP commands, but it adds useless complication with HMP. In particular, see the following: (qemu) nbd_server_add -w scsi0-hd0 (qemu) nbd_server_start -a localhost:10809 NBD server already exporting device scsi0-hd0 Signed-off-by: Paolo Bonzini --- blockdev-

[Qemu-devel] [PATCH 2/7] nbd: accept relative path to Unix socket

2012-11-12 Thread Paolo Bonzini
Adding the "is_unix" member now will simplify the parsing of NBD URIs. Signed-off-by: Paolo Bonzini --- block/nbd.c | 17 +++-- 1 file modificato, 7 inserzioni(+), 10 rimozioni(-) diff --git a/block/nbd.c b/block/nbd.c index 2bce47b..48bbeca 100644 --- a/block/nbd.c +++ b/block/nbd.

[Qemu-devel] [PATCH 7/7] hmp: add NBD server commands

2012-11-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hmp-commands.hx | 45 ++ hmp.c | 76 + hmp.h | 3 +++ 3 file modificati, 124 inserzioni(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index f916385..b

[Qemu-devel] [PATCH 1/7] qemu-nbd: initialize main loop before block layer

2012-11-12 Thread Paolo Bonzini
qemu-nbd was broken because they initialized the block layer while qemu_aio_context was still NULL. Signed-off-by: Paolo Bonzini --- qemu-nbd.c | 2 +- 1 file modificato, 1 inserzione(+). 1 rimozione(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 15bcd08..80f08d8 100644 --- a/qemu-nbd.c +++ b/qe

[Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12

2012-11-12 Thread Paolo Bonzini
Anthony, The following changes since commit 3c5645fab3c4b65d0cffbe1aaafc787e4be63d0f: tcg: properly check that op's output needs to be synced to memory (2012-11-11 16:06:46 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes u

[Qemu-devel] [PATCH 5/5] scsi-disk: flush cache after disabling it

2012-11-12 Thread Paolo Bonzini
SBC says that "if an application client changes the WCE bit from one to zero via a MODE SELECT command, then the device server shall write any data in volatile cache to non-volatile medium before completing the command". Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 9 + 1 file modif

[Qemu-devel] [PATCH] kvm: Actually remove software breakpoints from list on cleanup

2012-11-12 Thread Jan Kiszka
So far we only removed them from the guest, leaving its states in the list. This made it impossible for gdb to re-enable breakpoints on the same address after re-attaching. Signed-off-by: Jan Kiszka --- kvm-all.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kvm-all.c

[Qemu-devel] [PATCH 4/5] megasas: do not include block_int.h

2012-11-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/megasas.c | 1 - 1 file modificato. 1 rimozione(-) diff --git a/hw/megasas.c b/hw/megasas.c index 7a2036e..b845ea7 100644 --- a/hw/megasas.c +++ b/hw/megasas.c @@ -25,7 +25,6 @@ #include "iov.h" #include "scsi.h" #include "scsi-defs.h" -#include "block_int.

[Qemu-devel] [PATCH 3/5] scsi: remove superfluous call to scsi_device_set_ua

2012-11-12 Thread Paolo Bonzini
Suggested by Laszlo Ersek. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 1 - 1 file modificato. 1 rimozione(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 098558d..d15f891 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -1964,7 +1964,6 @@ static void scsi_disk_resize_cb(void *op

[Qemu-devel] [PATCH 1/5] scsi: do not return short responses for emulated commands

2012-11-12 Thread Paolo Bonzini
The inquiry command, for the case of VPD=1, was returning short responses; the number of returned bytes was just the number of bytes in the request, without padding to the specified allocation length with zero bytes. This is usually harmless, but it is a violation of the SCSI specification. To fi

[Qemu-devel] [PULL 1.3 0/5] SCSI updates for 2012-11-12

2012-11-12 Thread Paolo Bonzini
Anthony, The following changes since commit 3c5645fab3c4b65d0cffbe1aaafc787e4be63d0f: tcg: properly check that op's output needs to be synced to memory (2012-11-11 16:06:46 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes

Re: [Qemu-devel] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to'.

2012-11-12 Thread Markus Armbruster
Anthony PERARD writes: > Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken. > This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044. > > Signed-off-by: Anthony PERARD Thanks for taking the time to identify the commit that broke it. Reviewed-by: Mar

Re: [Qemu-devel] [PATCH V19 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-11-12 Thread Stefan Berger
On 11/08/2012 10:39 AM, Corey Bryant wrote: Thanks for your responses. I have a few comments below. On 10/24/2012 02:46 PM, Stefan Berger wrote: On 09/27/2012 10:22 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +/* check for ongoing seize by a highe

Re: [Qemu-devel] [PATCH V19 1/7] Support for TPM command line options

2012-11-12 Thread Stefan Berger
On 11/08/2012 10:52 AM, Corey Bryant wrote: On 10/24/2012 03:06 PM, Stefan Berger wrote: On 09/27/2012 10:12 AM, Corey Bryant wrote: On 06/04/2012 03:37 PM, Stefan Berger wrote: +if (!QLIST_EMPTY(&tpm_backends)) { +error_report("Only one TPM is allowed.\n"); +return 1

[Qemu-devel] KVM call agenda for 2012-11-12

2012-11-12 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

Re: [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack

2012-11-12 Thread Stefan Hajnoczi
On Sat, Nov 10, 2012 at 10:47 PM, Peter Maydell wrote: > Use the POSIX-specified stack_t type as the argument to sigaltstack() > rather than the legacy struct sigaltstack. This allows us to compile > on MacOSX with --with-coroutine=sigaltstack. > > Signed-off-by: Peter Maydell > --- > Tested on L

Re: [Qemu-devel] [Bug 1077514] [NEW] *** buffer overflow detected ***: qemu-system-x86_64 terminated with nowait enabled

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 13:47, Stefan Hajnoczi ha scritto: > > qemu-system-x86_64 -m 1024 -nographic -cpu coreduo -icount auto -hdachs > > 980,16,32 -kernel asa842-vmlinuz -initrd asa842-initrd.gz -append > > "ide_generic.probe_mask=0x01 ide_core.chs=0.0:980,16,32 auto nousb > > console=ttyS0,9600 bigphys

Re: [Qemu-devel] [Bug 1077514] [NEW] *** buffer overflow detected ***: qemu-system-x86_64 terminated with nowait enabled

2012-11-12 Thread Stefan Hajnoczi
On Sun, Nov 11, 2012 at 12:24 AM, Kaare Baastrup wrote: > Public bug reported: > > qemu-system-x86_64 -m 1024 -nographic -cpu coreduo -icount auto -hdachs > 980,16,32 -kernel asa842-vmlinuz -initrd asa842-initrd.gz -append > "ide_generic.probe_mask=0x01 ide_core.chs=0.0:980,16,32 auto nousb > c

Re: [Qemu-devel] qemu-kvm not listed by command "virsh list --all"

2012-11-12 Thread Stefan Hajnoczi
On Mon, Nov 12, 2012 at 9:01 AM, Peter Cheung wrote: > Dear All >Run a VM by qemu-kvm, and then i cannot list it by command "virsh list > --all". Why? > I am sure the VM is running because i can vnc to it. Libvirt does not manage qemu-kvm processes that were started outside its control by def

[Qemu-devel] [PATCH] aio: fix aio_ctx_prepare with idle bottom halves

2012-11-12 Thread Paolo Bonzini
Commit ed2aec4867f0d5f5de496bb765347b5d0cfe113d changed the return value of aio_ctx_prepare from false to true when only idle bottom halves are available. This broke PC old-style DMA, which uses them. Fix this by making aio_ctx_prepare return true only when non-idle bottom halves are scheduled to

Re: [Qemu-devel] [PATCH] qemu-nbd: Initialise main loop earlier

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 13:23, Kevin Wolf ha scritto: > Since the latest AIO changes qemu-nbd would segfault because > bdrv_init() requires qemu_aio_context to be initialised. Thanks... I had this in my NBD queue, going to send it out later. Paolo > Signed-off-by: Kevin Wolf > --- > qemu-nbd.c |2 +-

Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Stefan Hajnoczi
On Mon, Nov 12, 2012 at 12:49 PM, Lin Ma wrote: Paolo Bonzini 11/12/12 7:27 PM >>> > > Il 12/11/2012 12:18, Daniel P. Berrange ha scritto: >>> > QEMU doesn't check if there are mac collisions when adding nics. >>> > It causes mac address collisions in guest if adding the nics which >>> > inc

Re: [Qemu-devel] [PATCH] tap: reset vnet header size on open

2012-11-12 Thread Stefan Hajnoczi
On Mon, Nov 12, 2012 at 09:19:18AM +0200, Michael S. Tsirkin wrote: > For tap, we currently assume the vnet header size is 10 > (the default value) but that might not be the case > if tap is persistent and has been used by qemu previously. > To fix, set vnet header size correctly on open. > > Sign

  1   2   >