Re: [Qemu-devel] [patch v4 07/16] memory: make mmio dispatch able to be out of biglock

2012-10-23 Thread liu ping fan
On Wed, Oct 24, 2012 at 2:31 PM, liu ping fan wrote: > On Tue, Oct 23, 2012 at 8:36 PM, Avi Kivity wrote: >> On 10/23/2012 02:12 PM, Jan Kiszka wrote: >>> On 2012-10-22 11:23, Liu Ping Fan wrote: Without biglock, we try to protect the mr by increase refcnt. If we can inc refcnt, go back

Re: [Qemu-devel] [patch v4 13/16] e1000: add busy flag to anti broken device state

2012-10-23 Thread liu ping fan
On Tue, Oct 23, 2012 at 5:37 PM, Avi Kivity wrote: > On 10/23/2012 11:32 AM, liu ping fan wrote: >> On Tue, Oct 23, 2012 at 5:07 PM, Jan Kiszka wrote: >>> On 2012-10-23 07:52, liu ping fan wrote: On Mon, Oct 22, 2012 at 6:40 PM, Avi Kivity wrote: > On 10/22/2012 11:23 AM, Liu Ping Fan w

Re: [Qemu-devel] [patch v4 12/16] e1000: apply fine lock on e1000

2012-10-23 Thread liu ping fan
On Tue, Oct 23, 2012 at 5:04 PM, Jan Kiszka wrote: > On 2012-10-22 11:23, Liu Ping Fan wrote: >> Use local lock to protect e1000. When calling the system function, >> dropping the fine lock before acquiring the big lock. This will >> introduce broken device state, which need extra effort to fix. >

Re: [Qemu-devel] [patch v4 07/16] memory: make mmio dispatch able to be out of biglock

2012-10-23 Thread liu ping fan
On Tue, Oct 23, 2012 at 8:36 PM, Avi Kivity wrote: > On 10/23/2012 02:12 PM, Jan Kiszka wrote: >> On 2012-10-22 11:23, Liu Ping Fan wrote: >>> Without biglock, we try to protect the mr by increase refcnt. >>> If we can inc refcnt, go backward and resort to biglock. >>> >>> Another point is memory

Re: [Qemu-devel] [patch v4 09/16] memory: introduce mmio request pending to anti nested DMA

2012-10-23 Thread liu ping fan
On Tue, Oct 23, 2012 at 8:38 PM, Gleb Natapov wrote: > On Mon, Oct 22, 2012 at 05:23:52PM +0800, Liu Ping Fan wrote: >> Rejecting the nested mmio request which does not aim at RAM, so we >> can avoid the potential deadlock caused by the random lock sequence >> of two device's local lock. >> >> Sig

[Qemu-devel] [PATCH 04/24] move qemu_irq typedef out of cpu-common.h

2012-10-23 Thread Eduardo Habkost
From: Igor Mammedov it's necessary for making CPU child of DEVICE without causing circular header deps. Signed-off-by: Igor Mammedov [ehabkost: re-added the typedef to hw/irq.h after rebasing] Signed-off-by: Eduardo Habkost --- Changes v1 (from Igor) -> v2 (sent by Eduardo): - Chunk adding ty

[Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory

2012-10-23 Thread Eduardo Habkost
The bsd-user/qemu-types.h and linux-user/qemu-types.h files are almost the same, but linux-user have the additional definitions of tswapal(). This moves the linux-user file to the main directory, so the same file can be used by linux-user and bsd-user. Signed-off-by: Eduardo Habkost --- Cc: Blue

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: set boot-device property only if boot order specified

2012-10-23 Thread David Gibson
On Wed, Oct 24, 2012 at 07:31:19AM +0530, Avik Sil wrote: > On 10/24/2012 04:15 AM, David Gibson wrote: > > On Tue, Oct 23, 2012 at 03:39:35PM +0530, Avik Sil wrote: > >> Signed-off-by: Avik Sil > > > > As Anthony suggests, it would be better to explicitly remove the > > normal default boot order

[Qemu-devel] [PATCH 20/24] qdev: add stub vmstate handling to qdev.c

2012-10-23 Thread Eduardo Habkost
Add GCC_WEAK vmstate symbols to qdev.c, so that qdev.o can be used without savevm.o (i.e. by *-user). Signed-off-by: Eduardo Habkost --- Originally submitted as: Subject: qdev-core: isolate vmstate handling into separate functions Changes v1 -> v2: - Add GCC_WEAK_DECL to function declarations

[Qemu-devel] [PATCH 15/24] qlist.h: do not include qemu-common.h

2012-10-23 Thread Eduardo Habkost
I don't know why it was including it, as I don't see any code that depends on anything from qemu-common.h. Signed-off-by: Eduardo Habkost --- qlist.h | 1 - 1 file changed, 1 deletion(-) diff --git a/qlist.h b/qlist.h index ae776f9..7408947 100644 --- a/qlist.h +++ b/qlist.h @@ -15,7 +15,6 @@

Re: [Qemu-devel] [PATCH v2 2/7] translate-all.c: Introduce TCGContext *tcg_cur_ctx

2012-10-23 Thread Evgeny Voevodin
On 10/24/2012 01:18 AM, Richard Henderson wrote: On 2012-10-23 16:21, Evgeny Voevodin wrote: We will use this pointer from functions where we don't have an interface to pass tcg_ctx as a parameter. I don't think this is worthwhile. It'll just make the whole thing slower, passing around unneces

[Qemu-devel] [PATCH v5 00/24] CPU DeviceState, 5th try

2012-10-23 Thread Eduardo Habkost
Changes on v5: - Tons of header cleanups just to eliminate qlist.h <-> cpu-common.h circular dependency (patches 1-17) - Add copyright/license information to qdev-properties.c (patch 17) - Add copyright/license information to qdev-properties-system.c (patch 22) - use error_report()+abort()

[Qemu-devel] [PATCH 06/24] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h)

2012-10-23 Thread Eduardo Habkost
This will help reduce the qemu-common.h dependency hell. Signed-off-by: Eduardo Habkost -- Changes v1 -> v2: - move qemu_open() & qemu_close() to qemu-stdio.h, too --- qemu-common.h | 59 ++ qemu-stdio.h | 76 +

[Qemu-devel] [PATCH 13/24] create qemu-types.h for struct typedefs

2012-10-23 Thread Eduardo Habkost
Instead of keeping all those struct typedefs on qemu-common.h, move it to a header that can be safely included by other headers, containing only the struct typedefs and not pulling other dependencies. Also, move some of the qdev-core.h typedefs to the new file, too, so other headers don't need to

[Qemu-devel] [PATCH 23/24] include qdev code into *-user, too

2012-10-23 Thread Eduardo Habkost
The code depends on some functions from qemu-option.o, so add qemu-option.o to universal-obj-y to make sure it's included. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: - Keep files on the hw/ directory (it's simply easier to keep them there, as qdev.o depends on irq.o) - Add a $(hw-c

[Qemu-devel] [PATCH 10/24] qemu-config.h: include headers it needs

2012-10-23 Thread Eduardo Habkost
Include: - for FILE - qemu-option.h for QemuOptsList Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost --- qemu-config.h | 2 ++

[Qemu-devel] [PATCH 21/24] qdev: add sysbus_get_default() GCC_WEAK stub

2012-10-23 Thread Eduardo Habkost
This version will be used on cases where sysbus.c is not compiled in (e.g. *-user). Signed-off-by: Eduardo Habkost --- hw/qdev-core.h | 2 +- hw/qdev.c | 12 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/hw/qdev-core.h b/hw/qdev-core.h index 494b687..19d9e03 1

[Qemu-devel] [PATCH 24/24] qom: make CPU a child of DeviceState

2012-10-23 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov [ehabkost: change CPU type declaration to hae TYPE_DEVICE as parent] Signed-off-by: Eduardo Habkost --- Yes, there is "changelog" data before the "---" mark, but I believe that in this case they are important to indicate authorship and the scope

[Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c to qdev.c

2012-10-23 Thread Eduardo Habkost
The core qdev code uses the reset handler list from vl.c, so move qemu_register_reset(), qemu_unregister_reset() and qemu_devices_reset() to qdev.c. The function declarations were moved to a new qdev-reset.h file, that is included by hw.h to keep compatibility, so we don't need to change all files

[Qemu-devel] [PATCH 02/24] user: rename qemu-types.h to qemu-user-types.h

2012-10-23 Thread Eduardo Habkost
The header file is specific for *-user, but I plan to introduce a more generic qemu-types.h file, so I'm renaming it. Signed-off-by: Eduardo Habkost --- Cc: Blue Swirl Cc: Riku Voipio --- bsd-user/qemu.h | 2 +- cpu-all.h | 2 +- linux-user/qemu.h

[Qemu-devel] [PATCH 16/24] qapi-types.h: don't include qemu-common.h

2012-10-23 Thread Eduardo Habkost
From: Igor Mammedov needed to prevent build breakage when CPU becomes a child of DeviceState Signed-off-by: Igor Mammedov [ehabkost: include too] Signed-off-by: Eduardo Habkost --- Yes, there is "changelog" data before the "---" mark, but I believe that in this case they are important to indi

Re: [Qemu-devel] [RESEND PATCH v6 2/3] tcg: Add extended GETPC mechanism for MMU helpers with ldst optimization

2012-10-23 Thread Wei-Ren Chen
On Wed, Oct 24, 2012 at 12:11:23PM +0900, Yeongkyoon Lee wrote: > On 2012년 10월 24일 00:25, 陳韋任 (Wei-Ren Chen) wrote: > > Hi Yeongkyoon, > > > >> +#if defined(CONFIG_QEMU_LDST_OPTIMIZATION) && defined(CONFIG_SOFTMMU) > >> +/* check whether the give addr is in TCG generated code buffer or not */ > >

Re: [Qemu-devel] [RESEND PATCH v6 2/3] tcg: Add extended GETPC mechanism for MMU helpers with ldst optimization

2012-10-23 Thread Yeongkyoon Lee
On 2012년 10월 24일 00:25, 陳韋任 (Wei-Ren Chen) wrote: Hi Yeongkyoon, +#if defined(CONFIG_QEMU_LDST_OPTIMIZATION) && defined(CONFIG_SOFTMMU) +/* check whether the give addr is in TCG generated code buffer or not */ should be given. Cheers, chenwj Thanks a lot,

[Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers it needs

2012-10-23 Thread Eduardo Habkost
Include: - for errno - & for fcntl() - "qemu-stdio.h" for qemu_open() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PATCH 18/24] qdev: qdev_create(): use error_report() instead of hw_error()

2012-10-23 Thread Eduardo Habkost
hw_error() is specific for fatal hardware emulation errors, not for internal errors related to the qdev object/class abstraction or object initialization. Replace it with an error_report() call, followed by abort(). This will also help reduce dependencies of the qdev code (as hw_error() is from c

[Qemu-devel] [PATCH 05/24] qdev: split up header so it can be used in cpu.h

2012-10-23 Thread Eduardo Habkost
From: Anthony Liguori Header file dependency is a frickin' nightmare right now. cpu.h tends to get included in our 'include everything' header files but qdev also needs to include those headers mainly for qdev-properties since it knows about CharDriverState and friends. We can solve this for no

[Qemu-devel] [PATCH 11/24] qapi/qmp-registry.c: include headers it needs

2012-10-23 Thread Eduardo Habkost
Include: - for g_malloc0() - for strcmp() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost --- qapi/qmp-registry.c | 2 ++ 1

[Qemu-devel] [PATCH 22/24] qdev-properties.c: separate core from the code used only by qemu-system-*

2012-10-23 Thread Eduardo Habkost
This separates the qdev properties code in two parts: - qdev-properties.c, that contains most of the qdev properties code; - qdev-properties-system.c for code specific for qemu-system-*, containing: - Property types: drive, chr, netdev, vlan, that depend on code that won't be included

[Qemu-devel] [PATCH 08/24] vnc-palette.h: include

2012-10-23 Thread Eduardo Habkost
is needed for the 'bool' type, used in the header. The header is probably being included by accident because some other headers are including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost --- ui/vnc-palette.h | 1 + 1 file chang

[Qemu-devel] [PATCH 14/24] sysemu.h: include qemu-types.h instead of qemu-common.h

2012-10-23 Thread Eduardo Habkost
It just needs the Monitor and DeviceState typedefs, so it doesn't need all of qemu-common.h. Signed-off-by: Eduardo Habkost --- sysemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysemu.h b/sysemu.h index 0c39a3a..2b103a5 100644 --- a/sysemu.h +++ b/sysemu.h @@ -2,7 +2,

[Qemu-devel] [PATCH 17/24] qdev-properties.c: add copyright/license information

2012-10-23 Thread Eduardo Habkost
Add copyright and license information, based on git log, and discussion at: http://article.gmane.org/gmane.comp.emulators.qemu/176405 Message-ID: <20121017201414.ga5...@otherpad.lan.raisama.net> The list of Copyright owners is huge, but I didn't think I really could leave any of the authors out

[Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h

2012-10-23 Thread Eduardo Habkost
module.h is where machine_init() is defined, but qemu-fsdev-dummy.c doesn't include it. The header is probably being included by accident because some other headers are including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PATCH 09/24] ui/vnc-pallete.c: include headers it needs

2012-10-23 Thread Eduardo Habkost
Include: - for g_malloc0() - for memset() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost --- ui/vnc-palette.c | 2 ++ 1 f

[Qemu-devel] [PATCH 03/24] qemu-common.h: comment about usage rules

2012-10-23 Thread Eduardo Habkost
Every time we make a tiny change on a header file, we often find circular header dependency problems. To avoid this nightmare, we need to stop including qemu-common.h on other headers, and we should gradually move the declarations from the catchall qemu-common.h header to their specific headers. T

Re: [Qemu-devel] [PATCH 07/12] qdev-core: isolate reset register/unregister code

2012-10-23 Thread Eduardo Habkost
On Tue, Oct 23, 2012 at 12:56:18PM -0200, Eduardo Habkost wrote: > On Wed, Oct 17, 2012 at 01:08:23PM -0500, Anthony Liguori wrote: > > Eduardo Habkost writes: > > > > > The reset register/unregister code is specific to qemu-system-*, so > > > isolate it so it can be moved to qdev-system.c. > > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: set boot-device property only if boot order specified

2012-10-23 Thread Avik Sil
On 10/24/2012 04:15 AM, David Gibson wrote: > On Tue, Oct 23, 2012 at 03:39:35PM +0530, Avik Sil wrote: >> Signed-off-by: Avik Sil > > As Anthony suggests, it would be better to explicitly remove the > normal default boot order in this patch, after adding it for > absolutely everything in the fir

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific

2012-10-23 Thread Avik Sil
On 10/24/2012 05:13 AM, David Gibson wrote: > On Wed, Oct 24, 2012 at 12:47:34AM +0200, Alexander Graf wrote: >> >> On 24.10.2012, at 00:43, David Gibson wrote: >> >>> On Tue, Oct 23, 2012 at 12:20:08PM +0200, Alexander Graf wrote: On 23.10.2012, at 12:09, Avik Sil wrote: > This

[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-10-23 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/363 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason: The

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific

2012-10-23 Thread David Gibson
On Wed, Oct 24, 2012 at 12:47:34AM +0200, Alexander Graf wrote: > > On 24.10.2012, at 00:43, David Gibson wrote: > > > On Tue, Oct 23, 2012 at 12:20:08PM +0200, Alexander Graf wrote: > >> > >> On 23.10.2012, at 12:09, Avik Sil wrote: > >> > >>> This patch makes default boot order machine specif

Re: [Qemu-devel] [PATCH] target-sparc64: disable VGA cirrus

2012-10-23 Thread Richard Henderson
On 2012-10-22 08:50, Aurelien Jarno wrote: > OpenBIOS on sparc64 only support Standard VGA and not Cirrus VGA. Don't > build Cirrus VGA support so that it can't be selected. > > This fixes the breakage introduced by commit f2898771. > > Reported-by: Richard Henderson > Cc: Blue Swirl > Signed-o

[Qemu-devel] [memory] abort with head a8170e5

2012-10-23 Thread Richard Henderson
qemu-system-sparc64: /home/rth/work/qemu/qemu/memory.c:1022: memory_region_destroy: Assertion `memory_region_transaction_depth == 0' failed. Program received signal SIGABRT, Aborted. 0x75234925 in raise () from /lib64/libc.so.6 (gdb) where #0 0x75234925 in raise () from /lib64/li

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific

2012-10-23 Thread Alexander Graf
On 24.10.2012, at 00:43, David Gibson wrote: > On Tue, Oct 23, 2012 at 12:20:08PM +0200, Alexander Graf wrote: >> >> On 23.10.2012, at 12:09, Avik Sil wrote: >> >>> This patch makes default boot order machine specific instead of >>> set globally. The default boot order can be set per machine in

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: set boot-device property only if boot order specified

2012-10-23 Thread David Gibson
On Tue, Oct 23, 2012 at 03:39:35PM +0530, Avik Sil wrote: > Signed-off-by: Avik Sil As Anthony suggests, it would be better to explicitly remove the normal default boot order in this patch, after adding it for absolutely everything in the first patch. This also needs a better patch comment, expl

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific

2012-10-23 Thread David Gibson
On Tue, Oct 23, 2012 at 12:20:08PM +0200, Alexander Graf wrote: > > On 23.10.2012, at 12:09, Avik Sil wrote: > > > This patch makes default boot order machine specific instead of > > set globally. The default boot order can be set per machine in > > QEMUMachine default_machine_opts, or by the com

Re: [Qemu-devel] [PATCH 17/37] target-i386: make 'f-kvmclock' compatible with legacy behaviour

2012-10-23 Thread Don Slutz
On 10/22/12 11:03, Igor Mammedov wrote: It'll keep legacy behavior of kvmclock CPUID feature, which is toggles on KVM_FEATURE_CLOCKSOURCE and KVM_FEATURE_CLOCKSOURCE2 CPUID feature bits. Rename feature corresponding to KVM_FEATURE_CLOCKSOURCE to f-kvmclock1 to free f-kvmclock for use of legacy f

Re: [Qemu-devel] [PATCH 15/37] target-i386: set default value of "hypervisor" feature using static property

2012-10-23 Thread Don Slutz
On 10/22/12 11:03, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 3131945..dc4fcdf 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -174,7

Re: [Qemu-devel] [PATCH 13/37] target-i386: convert "level" to static property

2012-10-23 Thread Don Slutz
On 10/22/12 11:02, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index c9d8dbc..951d12b 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu

Re: [Qemu-devel] [PATCH 12/37] target-i386: convert "xlevel" to static property

2012-10-23 Thread Don Slutz
On 10/22/12 11:02, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- - convert to static property --- target-i386/cpu.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index fa974e7..c9d8dbc 100644 --- a/tar

Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server

2012-10-23 Thread Paolo Bonzini
On Tue, Oct 23, 2012 at 5:27 PM, Paolo Bonzini wrote: > Il 23/10/2012 14:34, Paolo Bonzini ha scritto: >> Fixed like this and pushed to the same place (tip is now commit >> 8b5c3381d28ebb1765f17a4cbe1852d3b68b7dc4). Sorry. >> >> I will try to clean up the dependencies before or during soft featur

Re: [Qemu-devel] [PATCH v2 2/7] translate-all.c: Introduce TCGContext *tcg_cur_ctx

2012-10-23 Thread Richard Henderson
On 2012-10-23 16:21, Evgeny Voevodin wrote: > We will use this pointer from functions where we don't have an > interface to pass tcg_ctx as a parameter. I don't think this is worthwhile. It'll just make the whole thing slower, passing around unnecessary pointers. r~

Re: [Qemu-devel] Resource reporting for VGA cards

2012-10-23 Thread Hervé Poussineau
Hi, Gerd Hoffmann a écrit : On 10/22/12 21:43, Hervé Poussineau wrote: Hello, I'm trying to add support for a S3 PCI VGA card to QEMU. It currently works on some non-x86 systems. However, on x86, it seems that the card is correctly detected, but there is no display at all; I think it is due to

Re: [Qemu-devel] 1.1.1 -> 1.1.2 migrate /managedsave issue

2012-10-23 Thread Doug Goldstein
On Mon, Oct 22, 2012 at 6:23 AM, Avi Kivity wrote: > On 10/22/2012 09:04 AM, Philipp Hahn wrote: >> Hello Doug, >> >> On Saturday 20 October 2012 00:46:43 Doug Goldstein wrote: >>> I'm using libvirt 0.10.2 and I had qemu-kvm 1.1.1 running all my VMs. >> ... >>> I had upgraded to qemu-kvm 1.1.2 >>

Re: [Qemu-devel] [PATCH 08/37] target-i386: define static properties for cpuid features

2012-10-23 Thread Don Slutz
On 10/23/12 06:29, Igor Mammedov wrote: On Mon, 22 Oct 2012 19:19:29 -0400 Don Slutz wrote: On 10/22/12 11:02, Igor Mammedov wrote: - static properties names of CPUID features are changed to have "f-" prefix, so that it would be easy to distinguish them from other properties. - us

Re: [Qemu-devel] [PULL] Memory core fixes

2012-10-23 Thread Anthony Liguori
Avi Kivity writes: > Please pull a few memory core fixes from: > > git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent > > Fixing ioeventfds on big endian systems, and potential use-after-free > (not really exploitable with the current code, but still). Pulled. Thanks. Regards,

[Qemu-devel] [PATCH 7/7] hw/mainstone: Don't prematurely explode QEMUMachineInitArgs

2012-10-23 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to mainstone_init(). Signed-off-by: Peter Maydell --- hw/mainstone.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/hw/mainstone.c b/hw/mainstone.c index c0d6034..95a6d61 100644 --- a/hw/mainstone.c

[Qemu-devel] [PATCH 5/7] hw/omap_sx1: Don't prematurely explode QEMUMachineInitArgs

2012-10-23 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to the omap_sx1 common init function. Signed-off-by: Peter Maydell --- hw/omap_sx1.c | 36 +--- 1 file changed, 9 insertions(+), 27 deletions(-) diff --git a/hw/omap_sx1.c b/hw/omap_sx1.c index ad17487..7474f2

[Qemu-devel] [PATCH] dma: Define dma_context_memory and use in sysbus-ohci

2012-10-23 Thread Peter Maydell
Define a new global dma_context_memory which is a DMAContext corresponding to the global address_space_memory AddressSpace. This can be used by sysbus peripherals like sysbus-ohci which need to do DMA. In particular, use it in the sysbus-ohci device, which fixes a segfault when attempting to use t

[Qemu-devel] [PATCH 2/7] hw/realview.c: Don't prematurely explode QEMUMachineInitArgs

2012-10-23 Thread Peter Maydell
Don't explode QEMUMachineInitArgs in every realview init function; just pass it to the common realview_init() code instead. Signed-off-by: Peter Maydell --- hw/realview.c | 68 - 1 file changed, 19 insertions(+), 49 deletions(-) diff --g

[Qemu-devel] [PATCH 3/7] hw/versatilepb: Don't prematurely explode QEMUMachineInitArgs

2012-10-23 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to the common versatile init function. Signed-off-by: Peter Maydell --- hw/versatilepb.c | 44 +++- 1 file changed, 11 insertions(+), 33 deletions(-) diff --git a/hw/versatilepb.c b/hw/versatilepb.c in

[Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs

2012-10-23 Thread Peter Maydell
A lot of the ARM board models follow the pattern of having a single common init function which is called with various parameters from the QEMUMachine init function for several board model variants. The change to QEMUMachineInitArgs in commit 5f072e took the fairly mechanical approach of splitting t

[Qemu-devel] [PATCH 4/7] hw/spitz: Don't prematurely explode QEMUMachineInitArgs

2012-10-23 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before calling common init function. Signed-off-by: Peter Maydell --- hw/spitz.c | 45 ++--- 1 file changed, 10 insertions(+), 35 deletions(-) diff --git a/hw/spitz.c b/hw/spitz.c index 2942626..04f5e85 100644 --- a/hw/

Re: [Qemu-devel] [PATCH 36/37] target-i386: use static properties to list CPUID features

2012-10-23 Thread Don Slutz
Turns out that patch #32 is the one that causes the command line: ./x86_64-softmmu/qemu-system-x86_64 -cpu 486,+fpu,+vme,+de,+pse,+tsc,+msr,+pae,+mce,+cx8,+apic,+sep,+mtrr,+pge,+mca,+cmov,+pat,+pse36,+pn,+clflush,+ds,+acpi,+mmx,+fxsr,+sse,+sse2,+ss,+ht,+tm,+ia64,+pbe,+pni,+sse3,+pclmulqdq,+pclmu

[Qemu-devel] [PATCH 1/7] hw/vexpress.c: Don't prematurely explode QEMUMachineInitArgs

2012-10-23 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to the vexpress common init function. Signed-off-by: Peter Maydell --- hw/vexpress.c | 38 +- 1 file changed, 9 insertions(+), 29 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 36503d6..cd5a

[Qemu-devel] [PATCH 6/7] hw/nseries: Don't prematurely explode QEMUMachineInitArgs

2012-10-23 Thread Peter Maydell
Don't explode QEMUMachineInitArgs before passing it to n8x0_init(). Signed-off-by: Peter Maydell --- hw/nseries.c | 39 +++ 1 file changed, 11 insertions(+), 28 deletions(-) diff --git a/hw/nseries.c b/hw/nseries.c index 7ada90d..6560d3c 100644 --- a/hw/nse

Re: [Qemu-devel] [PATCH] qemu-img rebase: allow backing file to be specified as '-'

2012-10-23 Thread Christoph Hellwig
On Mon, Oct 15, 2012 at 12:07:37PM -0600, Eric Blake wrote: > On 10/15/2012 11:29 AM, Alex Bligh wrote: > > This patch allows qemu-img rebase to rebase an image to > > have no backing file, as opposed to merely allowing it to > > rebase to an existing backing file. > > You can already do that by r

Re: [Qemu-devel] [PATCHv2 4/4] Warning messages on net devices hotplug

2012-10-23 Thread Eric Blake
On 10/23/2012 09:59 AM, Corey Bryant wrote: > Only network devices are prevented, right? > > Also, as I mentioned before, can you limit this to the subset of options > that cause execve() to be issued? For example, can we allow libvirt to > pass an fd for hotplugging a network device (e.g. netde

[Qemu-devel] sysbus-ohci segfaults with NULL DMAContext*

2012-10-23 Thread Peter Maydell
(found while trying to rebase the qemu-linaro OMAP3 patches; dunno if it's reproducable in plain mainline easily) Commit 9ac6a217 makes ohci_init_pxa() set up the OHCI code with a NULL DMAContext*, and asserts in the commit message: "in the SysBus case, it uses NULL - i.e. assumes for now that th

Re: [Qemu-devel] [PATCHv2 4/4] Warning messages on net devices hotplug

2012-10-23 Thread Corey Bryant
On 10/23/2012 01:55 AM, Eduardo Otubo wrote: With the inclusion of the new "double whitelist" seccomp filter, Qemu won't be able to execve() in runtime, thus, no hotplug net devices allowed. v2: * Error messages moved to the backend function, net_init_tap(), recommended by Paolo Bonzini

Re: [Qemu-devel] [PATCH v2] target-i386: use static properties to list CPUID features

2012-10-23 Thread Igor Mammedov
On Tue, 23 Oct 2012 11:51:49 -0200 Eduardo Habkost wrote: > On Tue, Oct 23, 2012 at 03:26:40PM +0200, Igor Mammedov wrote: > > convert x86_cpu_list() to use QDEV_FIND_PROP_FROM_BIT() for getting > > CPUID feature name. > > In addition since x86_cpu_list() was the last user of *feature_name > > ar

Re: [Qemu-devel] sysbus-ohci segfaults with NULL DMAContext*

2012-10-23 Thread Avi Kivity
On 10/23/2012 06:00 PM, Peter Maydell wrote: > (found while trying to rebase the qemu-linaro OMAP3 patches; > dunno if it's reproducable in plain mainline easily) > > Commit 9ac6a217 makes ohci_init_pxa() set up the OHCI code > with a NULL DMAContext*, and asserts in the commit message: > > "in t

Re: [Qemu-devel] [patch v4 05/16] memory: introduce ref, unref interface for MemoryRegionOps

2012-10-23 Thread Avi Kivity
On 10/23/2012 05:26 PM, Paolo Bonzini wrote: >>> Yes, that's the point of doing things asynchronously---you do not need >>> to do everything within stop_machine, you can start canceling AIO as >>> soon as the OS sends the hot-unplug request. Then you only proceed with >>> stop_machine and freeing

Re: [Qemu-devel] [PATCH 32/37] target-i386: use static properties for setting cpuid features

2012-10-23 Thread Igor Mammedov
On Tue, 23 Oct 2012 11:29:46 -0400 Don Slutz wrote: > On 10/22/12 11:03, Igor Mammedov wrote: > > - def->kvm_features was used only for setting hadcoded defaults, > > with defaults set by static props, we do not need it anymore, > > ignore it in cpudef_2_x86_cpu(). > > - take in accou

Re: [Qemu-devel] [PATCH 06/11] quorum: Add quorum_co_flush().

2012-10-23 Thread Eric Blake
On 10/23/2012 06:23 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/block/quorum.c b/block/quorum.c > index 878d930..1b40081 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -281,6 +28

Re: [Qemu-devel] [PATCH 03/11] quorum: Add quorum_open() and quorum_close().

2012-10-23 Thread Eric Blake
On 10/23/2012 06:23 AM, Benoît Canet wrote: > Valid quorum resources look like > quorum:threshold/total:path/to/image_1: ... :path/to/image_total > > ':' is used as a separator to allow to use networked path > '\' is the escaping character for filename containing ':' > '\' escape itself > > On th

Re: [Qemu-devel] [PATCH 32/37] target-i386: use static properties for setting cpuid features

2012-10-23 Thread Don Slutz
On 10/22/12 11:03, Igor Mammedov wrote: - def->kvm_features was used only for setting hadcoded defaults, with defaults set by static props, we do not need it anymore, ignore it in cpudef_2_x86_cpu(). - take in account CPUID_EXT_HYPERVISOR feature set by static property default val

Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server

2012-10-23 Thread Paolo Bonzini
Il 23/10/2012 14:34, Paolo Bonzini ha scritto: > Fixed like this and pushed to the same place (tip is now commit > 8b5c3381d28ebb1765f17a4cbe1852d3b68b7dc4). Sorry. > > I will try to clean up the dependencies before or during soft feature > freeze. Nevermind, still broken. :( Paolo

Re: [Qemu-devel] [patch v4 05/16] memory: introduce ref, unref interface for MemoryRegionOps

2012-10-23 Thread Paolo Bonzini
Il 23/10/2012 16:49, Avi Kivity ha scritto: > On 10/23/2012 02:32 PM, Paolo Bonzini wrote: >> Il 23/10/2012 14:15, Avi Kivity ha scritto: >>> On 10/23/2012 02:06 PM, Paolo Bonzini wrote: Il 23/10/2012 14:02, Avi Kivity ha scritto: > On 10/23/2012 01:57 PM, Paolo Bonzini wrote: >> Il 23

Re: [Qemu-devel] [RESEND PATCH v6 2/3] tcg: Add extended GETPC mechanism for MMU helpers with ldst optimization

2012-10-23 Thread Wei-Ren Chen
Hi Yeongkyoon, > +#if defined(CONFIG_QEMU_LDST_OPTIMIZATION) && defined(CONFIG_SOFTMMU) > +/* check whether the give addr is in TCG generated code buffer or not */ should be given. Cheers, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Informatio

Re: [Qemu-devel] [PATCHv2 3/4] Support for "double whitelist" filters

2012-10-23 Thread Corey Bryant
On 10/23/2012 01:55 AM, Eduardo Otubo wrote: This patch includes a second whitelist right before the main loop. It's a smaller and more restricted whitelist, excluding execve() among many others. v2: * ctx changed to main_loop_ctx * seccomp_on now inside ifdef * open syscall added to

Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server

2012-10-23 Thread Jamie Lokier
Nicholas Thomas wrote: > On Tue, 2012-10-23 at 12:33 +0200, Kevin Wolf wrote: > > Am 22.10.2012 13:09, schrieb n...@bytemark.co.uk: > > > > > > This is unlikely to come up now, but is a necessary prerequisite for > > > reconnection > > > behaviour. > > > > > > Signed-off-by: Nick Thomas > > > -

Re: [Qemu-devel] [PATCH 07/12] qdev-core: isolate reset register/unregister code

2012-10-23 Thread Eduardo Habkost
On Wed, Oct 17, 2012 at 01:08:23PM -0500, Anthony Liguori wrote: > Eduardo Habkost writes: > > > The reset register/unregister code is specific to qemu-system-*, so > > isolate it so it can be moved to qdev-system.c. > > > > Signed-off-by: Eduardo Habkost > > --- > > hw/qdev-core.c | 24 +++

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr

2012-10-23 Thread Avi Kivity
On 10/23/2012 02:55 PM, Anthony Liguori wrote: > Avi Kivity writes: > >> target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are >> reserved) and its purpose doesn't match the name (most target_phys_addr_t >> addresses are not target specific). Replace it with a finger-friendly

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr

2012-10-23 Thread Avi Kivity
On 10/23/2012 03:04 PM, Peter Maydell wrote: > On 23 October 2012 11:30, Avi Kivity wrote: >> target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are >> reserved) and its purpose doesn't match the name (most target_phys_addr_t >> addresses are not target specific). Replace it wi

Re: [Qemu-devel] [patch v4 05/16] memory: introduce ref, unref interface for MemoryRegionOps

2012-10-23 Thread Avi Kivity
On 10/23/2012 02:32 PM, Paolo Bonzini wrote: > Il 23/10/2012 14:15, Avi Kivity ha scritto: >> On 10/23/2012 02:06 PM, Paolo Bonzini wrote: >>> Il 23/10/2012 14:02, Avi Kivity ha scritto: On 10/23/2012 01:57 PM, Paolo Bonzini wrote: > Il 23/10/2012 13:55, Avi Kivity ha scritto: So

Re: [Qemu-devel] [PATCH] osdep: Less restrictive F_SEFL in qemu_dup_flags()

2012-10-23 Thread Kevin Wolf
Am 18.10.2012 22:41, schrieb Corey Bryant: > qemu_dup_flags() currently limits the flags that can be set on the > fcntl() F_SETFL call to those that we currently know can be set with > fcntl() F_SETFL. The problem with this is that it will prevent use > of new flags in the future without a code up

[Qemu-devel] [PATCH v4 16/16] qemu-iotests: add testcases for mirroring on-source-error/on-target-error

2012-10-23 Thread Paolo Bonzini
The new options are tested with blkdebug on both the source and the target. Signed-off-by: Paolo Bonzini --- The only change is in 041.out. tests/qemu-iotests/041| 253 ++ tests/qemu-iotests/041.out| 4 +- tests/qemu-iotests/iotests.

[Qemu-devel] [PATCH v4 12/16] qemu-iotests: add mirroring test case

2012-10-23 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/041 | 362 + tests/qemu-iotests/041.out | 5 + tests/qemu-iotests/group | 1 + 3 file modificati, 368 inserzioni(+) create mode 100755 tests/qemu-iotests/041 create mode 100644 tests/qemu-i

Re: [Qemu-devel] [patch v4 05/16] memory: introduce ref, unref interface for MemoryRegionOps

2012-10-23 Thread Avi Kivity
On 10/23/2012 02:40 PM, Jan Kiszka wrote: > On 2012-10-23 14:28, Avi Kivity wrote: >> On 10/23/2012 02:16 PM, Jan Kiszka wrote: >>> On 2012-10-23 14:12, Paolo Bonzini wrote: Il 23/10/2012 14:04, Jan Kiszka ha scritto: > > So the stop_machine idea is thrown away? >>> >

Re: [Qemu-devel] qemu <-> libvirt interaction broken

2012-10-23 Thread Anthony Liguori
Eric Blake writes: > On 10/23/2012 06:47 AM, Anthony Liguori wrote: > This change was postponed to after 1.2 was released to give libvirt a chance to wean itself off parsing our --help output. >>> >>> Yea, I know this has been the plan for a long time and I agree that it >>> i

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr

2012-10-23 Thread Paolo Bonzini
Il 23/10/2012 14:55, Anthony Liguori ha scritto: >> > target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are >> > reserved) and its purpose doesn't match the name (most target_phys_addr_t >> > addresses are not target specific). Replace it with a finger-friendly, >> > standards

Re: [Qemu-devel] [PATCH 00/37 v5] target-i386: convert CPU features into properties

2012-10-23 Thread Igor Mammedov
On Tue, 23 Oct 2012 09:32:53 -0400 Don Slutz wrote: > On 10/22/12 11:02, Igor Mammedov wrote: > > v5: > >- Use static properties instead of dynamic ones > >- Compile in KVM CPUID features only if CONFIG_KVM is defined > >- Add "f-kvm_steal_tm" and "f-kvmclock_stable" CPUID feature nam

Re: [Qemu-devel] [PATCH v2] target-i386: use static properties to list CPUID features

2012-10-23 Thread Eduardo Habkost
On Tue, Oct 23, 2012 at 03:26:40PM +0200, Igor Mammedov wrote: > convert x86_cpu_list() to use QDEV_FIND_PROP_FROM_BIT() for getting > CPUID feature name. > In addition since x86_cpu_list() was the last user of *feature_name > arrays, clean them up. > > Signed-off-by: Igor Mammedov > --- > v2: >

Re: [Qemu-devel] KVM call agenda for 2012-10-23

2012-10-23 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. No agenda -> no call Happy hacking, Juan.

Re: [Qemu-devel] [PATCH v3 1/2] qmp: handle stop/cont in INMIGRATE state

2012-10-23 Thread Luiz Capitulino
On Tue, 23 Oct 2012 14:54:21 +0200 Paolo Bonzini wrote: > Right now, stop followed by an incoming migration will let the > virtual machine start. cont before an incoming migration instead > will fail. > > This is bad because the actual behavior is not predictable; it is > racy with respect to t

Re: [Qemu-devel] [PATCH 00/37 v5] target-i386: convert CPU features into properties

2012-10-23 Thread Don Slutz
On 10/22/12 11:02, Igor Mammedov wrote: v5: - Use static properties instead of dynamic ones - Compile in KVM CPUID features only if CONFIG_KVM is defined - Add "f-kvm_steal_tm" and "f-kvmclock_stable" CPUID feature names - Some qdev hacking to: - allow iterate over Property[] bef

Re: [Qemu-devel] [PATCH 1/2] Make default boot order machine specific

2012-10-23 Thread Alexander Graf
On 23.10.2012, at 15:24, Anthony Liguori wrote: > Alexander Graf writes: > >> On 23.10.2012, at 12:09, Avik Sil wrote: >> >>> This patch makes default boot order machine specific instead of >>> set globally. The default boot order can be set per machine in >>> QEMUMachine default_machine_opts,

[Qemu-devel] [PATCH v2] target-i386: use static properties to list CPUID features

2012-10-23 Thread Igor Mammedov
convert x86_cpu_list() to use QDEV_FIND_PROP_FROM_BIT() for getting CPUID feature name. In addition since x86_cpu_list() was the last user of *feature_name arrays, clean them up. Signed-off-by: Igor Mammedov --- v2: * fix x86_cpu_list(), use X86CPU as base to count offset correctly * Do not f

[Qemu-devel] [PATCH v2] target-i386: use static properties in check_features_against_host() to print CPUID feature names

2012-10-23 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: * use separate for() for every feature word v3: * fix check_features_against_host(), use X86CPU as base to count offset correctly --- target-i386/cpu.c | 72 +-- 1 file changed, 43 insertions(+), 29 d

Re: [Qemu-devel] [PATCH 1/2] Make default boot order machine specific

2012-10-23 Thread Anthony Liguori
Alexander Graf writes: > On 23.10.2012, at 12:09, Avik Sil wrote: > >> This patch makes default boot order machine specific instead of >> set globally. The default boot order can be set per machine in >> QEMUMachine default_machine_opts, or by the command line using >> -machine ,boot=, or by stan

Re: [Qemu-devel] [PATCH 35/37] target-i386: use static properties in check_features_against_host() to print CPUID feature names

2012-10-23 Thread Igor Mammedov
On Mon, 22 Oct 2012 17:03:21 +0200 Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > v2: > * use separate for() for every feature word > --- > target-i386/cpu.c | 72 > +-- > 1 file changed, 43 insertions(+), 29 deletions(-) > >

  1   2   >