[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-10-19 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/359 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason: The

Re: [Qemu-devel] [PATCH v1 6/7] xilinx_zynq: add pl353

2012-10-19 Thread Peter Crosthwaite
On Fri, Oct 19, 2012 at 8:32 PM, Peter Maydell wrote: > On 19 October 2012 07:40, Peter Crosthwaite > wrote: >> Add the pl353 memory controller with both NAND and parallel flashes >> attached. >> >> Signed-off-by: Peter Crosthwaite >> --- >> >> hw/xilinx_zynq.c | 49 ++

[Qemu-devel] [PATCH v3 19/26] q35: Fix non-PCI IRQ processing in ich9_lpc_update_apic

2012-10-19 Thread Jason Baron
From: Jan Kiszka Avoid passing a non-PCI IRQ to ich9_gsi_to_pirq. It's wrong and triggers an assertion. Reviewed-by: Paolo Bonzini Signed-off-by: Jan Kiszka Signed-off-by: Jason Baron --- hw/lpc_ich9.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/lpc_ich9.

[Qemu-devel] [PATCH v3 04/26] tcg: sync output arguments on liveness request

2012-10-19 Thread Aurelien Jarno
Synchronize an output argument when requested by the liveness analysis. This is needed so that the temp can be declared dead later. For that, add a new op_sync_args table in which each bit tells if the corresponding output argument needs to be synchronized with the memory. Pass it to the tcg_reg_a

[Qemu-devel] [PATCH v3 10/26] pcie: pass pcie window size to pcie_host_mmcfg_update()

2012-10-19 Thread Jason Baron
From: Jason Baron This allows q35 to pass/set the size of the pcie window in its update routine. Reviewed-by: Paolo Bonzini Signed-off-by: Jason Baron --- hw/pcie_host.c | 21 - hw/pcie_host.h |8 +--- 2 files changed, 17 insertions(+), 12 deletions(-) diff --gi

[Qemu-devel] [PATCH v3 06/26] tcg: improve tcg_reg_alloc_movi()

2012-10-19 Thread Aurelien Jarno
Now that the liveness analysis might mark some output temps as dead, call temp_dead() if needed. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/tcg.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 567ec87..6586385 100644 --- a/tcg/tcg

[Qemu-devel] [PATCH v3 22/26] target-s390x: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Cc: Alexander Graf Signed-off-by: Aurelien Jarno --- target-s390x/helper.h | 76 - 1 file changed, 38 insertion

[Qemu-devel] [PATCH v3 17/26] target-cris: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Acked-by: Edgar E. Iglesias Signed-off-by: Aurelien Jarno --- target-cris/helper.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) di

[Qemu-devel] [PATCH v3 02/26] blockdev: Introduce IF_AHCI

2012-10-19 Thread Jason Baron
From: Jason Baron Introduce IF_AHCI so that q35 can differentiate between ide and ahci disks. This allows q35 to specify its default disk type. It also allows q35 to differentiate between ahci and ide disks, such that -drive if=ide does not result in the creating of an ahci disk. This is importan

[Qemu-devel] [PATCH v3 20/26] target-mips: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Signed-off-by: Aurelien Jarno --- target-mips/helper.h | 106 +- 1 file changed, 53 insertions(+), 53 deletions(-

[Qemu-devel] [PATCH 07/26] tcg: rewrite tcg_reg_alloc_mov()

2012-10-19 Thread Aurelien Jarno
Now that the liveness analysis provides more information, rewrite tcg_reg_alloc_mov(). This changes the behaviour about propagating constants and memory accesses. We now take the assumption that once a value is loaded into a register (from memory or from a constant), it's better to keep it there th

[Qemu-devel] [PATCH v3 03/26] pci: pci capability must be in PCI space

2012-10-19 Thread Jason Baron
From: Isaku Yamahata pci capability must be in PCI space. It can't lay in PCIe extended config space. Reviewed-by: Paolo Bonzini Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/p

[Qemu-devel] [PATCH v3 01/26] tcg: add temp_dead()

2012-10-19 Thread Aurelien Jarno
A lot of code is duplicated to mark a temporary as dead. Replace it by temp_dead(), which in addition marks the temp as saved in memory for globals and local temps, instead of doing this a posteriori in temp_save(). Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/tcg.c |

[Qemu-devel] [PATCH v3 12/26] ich9: Add acpi support and definitions

2012-10-19 Thread Jason Baron
From: Jason Baron Lay the groundwork for subsequent ich9 support. Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/acpi_ich9.c| 315 + hw/acpi_ich9.h| 47 hw/i386/Makefile.objs |1 + hw/ich9.h

[Qemu-devel] [PATCH v3 00/26] tcg: rework liveness analysis and register allocator

2012-10-19 Thread Aurelien Jarno
This patch series rework the liveness analysis and register allocator in order to generate more optimized code, by avoiding a lot of move instructions. I have measured a 9% performance improvement in user mode and 4% in system mode. The idea behind this patch series is to free registers as soon a

[Qemu-devel] [PATCH v3 04/26] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle

2012-10-19 Thread Jason Baron
From: Isaku Yamahata Introduce pci_swizzle_map_irq_fn() for interrupt pin swizzle which is standardized. PCI bridge swizzle is common logic, by introducing this function duplicated swizzle logic will be avoided later. [jba...@redhat.com: drop opaque argument] Reviewed-by: Paolo Bonzini Signed-o

[Qemu-devel] [PATCH v3 10/26] tcg: don't explicitly save globals and temps

2012-10-19 Thread Aurelien Jarno
The liveness analysis ensures that globals and temps are at the correct state at a basic block end or with an op with side effects. Avoid looping on all temps, this can be time consuming on targets with a lot of globals. Keep an assert in debug mode. Reviewed-by: Richard Henderson Signed-off-by:

[Qemu-devel] [PATCH v3 25/26] q35: fill in usb pci slots with -usb

2012-10-19 Thread Jason Baron
From: Jason Baron This fills out the usb slots on q35, when -usb is passed. We now have (lspci output): 00:1d.0 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #1 (rev 03) 00:1d.1 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #2 (rev 03)

[Qemu-devel] [PATCH v3 08/26] tcg: always mark dead input arguments as dead

2012-10-19 Thread Aurelien Jarno
Always mark dead input arguments as dead, even if the op is at the basic block end. This will allow to check that all temps are correctly saved. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/tcg.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) dif

[Qemu-devel] [PATCH v3 13/26] tcg: synchronize globals for ops with side effects

2012-10-19 Thread Aurelien Jarno
Operations with side effects (in practice qemu_ld/st ops), only need to synchronize globals to make sure the CPU state is consistent in case of exception. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/tcg.c | 33 - tcg/tcg.h |4 ++--

[Qemu-devel] [PATCH v3 26/26] tcg: remove compatiblity call flags

2012-10-19 Thread Aurelien Jarno
Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/tcg.h |4 1 file changed, 4 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 374eb30..202c185 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -268,10 +268,6 @@ typedef int TCGv_i64; #define TCG_CALL_NO_RWG_SE (TC

[Qemu-devel] [PATCH v3 02/26] tcg: add tcg_reg_sync()

2012-10-19 Thread Aurelien Jarno
Add a new function tcg_reg_sync() to synchronize the canonical location of a temp with the value in the associated register, but without freeing it. Rewrite tcg_reg_free() to first call tcg_reg_sync() and then to free the register. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno ---

Re: [Qemu-devel] [PATCH v2 14/26] tcg: rework TCG helper flags

2012-10-19 Thread Richard Henderson
On 2012-10-20 06:24, Aurelien Jarno wrote: > Agreed. On the other hand, the few lines just above the one your quoted > would be more complicated: > > +if (!(call_flags & TCG_CALL_NO_READ_GLOBALS)) { > +/* globals should be synced to memory */ > +

[Qemu-devel] [PATCH v3 11/26] pcie: Convert PCIExpressHost to use the QOM.

2012-10-19 Thread Jason Baron
From: Jason Baron Let's use PCIExpressHost with QOM. Reviewed-by: Paolo Bonzini Acked-by: Andreas Färber Signed-off-by: Jason Baron --- hw/pcie_host.c | 14 ++ hw/pcie_host.h |4 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/pcie_host.c b/hw/pcie_h

[Qemu-devel] [PATCH v3 18/26] target-i386: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-i386/helper.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH v3 11/26] tcg: fix some op flags

2012-10-19 Thread Aurelien Jarno
Some branch related ops are marked with TCG_OPF_SIDE_EFFECTS, some other not. In practice they don't need to, as they are all marked with TCG_OPF_BB_END, which is handled specifically in all the code. The call op is marked as TCG_OPF_SIDE_EFFECTS, which might be not true as there is are specific f

Re: [Qemu-devel] [PATCH v2 2/2] target-arm: Implement abs_i32 inline rather than as a helper

2012-10-19 Thread Aurelien Jarno
On Fri, Oct 19, 2012 at 02:06:59PM +0100, Peter Maydell wrote: > Implement abs_i32 inline (with movcond) rather than using a helper > function. > > Signed-off-by: Peter Maydell > --- > target-arm/helper.c|5 - > target-arm/helper.h|1 - > target-arm/translate.c | 11 +++

Re: [Qemu-devel] [PATCH v2 1/2] target-arm: Use TCG operation for Neon 64 bit negation

2012-10-19 Thread Aurelien Jarno
On Fri, Oct 19, 2012 at 02:06:58PM +0100, Peter Maydell wrote: > Use the TCG operation to do Neon 64 bit negations rather than calling > a helper routine for it. > > Signed-off-by: Peter Maydell > --- > target-arm/helper.h |1 - > target-arm/neon_helper.c |6 -- > target-arm/tra

Re: [Qemu-devel] [PATCH v2 0/2] target-arm: inline abs, 64-bit negate

2012-10-19 Thread Aurelien Jarno
On Fri, Oct 19, 2012 at 02:06:57PM +0100, Peter Maydell wrote: > Two minor patches which inline some operations rather than using helper > functions. The 64 bit negate is a no-brainer since there's a simple > TCG op for it. For abs we implement in terms of movcond: > movi_i32 tmp6,$0x0 > neg_i32

[Qemu-devel] [PATCH v3 23/26] q35: automatically load the q35 dsdt table

2012-10-19 Thread Jason Baron
From: Jason Baron Automatically, locate the required q35 dsdt table on load. Otherwise we error out. This could be done in the bios, but its harder to produce a good error message. Signed-off-by: Jason Baron --- hw/pc.c | 19 +++ hw/pc.h |2 ++ hw/pc_q35.c |7

[Qemu-devel] [PATCH v3 14/26] tcg: rework TCG helper flags

2012-10-19 Thread Aurelien Jarno
The current helper flags, TCG_CALL_CONST and TCG_CALL_PURE might be confusing and doesn't provide enough granularity for some helpers (FP helpers for example). This patch changes them into the following helpers flags: - TCG_CALL_NO_READ_GLOBALS means that the helper does not read globals, either

[Qemu-devel] [PATCH v3 03/26] tcg: add temp_sync()

2012-10-19 Thread Aurelien Jarno
Add a new function temp_sync() to synchronize the canonical location of a temp with the value in the corresponding register, but without freeing the associated register. Rewrite temp_save() to call temp_sync() followed by temp_dead(). Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno

[Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.

2012-10-19 Thread Jason Baron
From: Jason Baron This adds support for the DECchip 21154 PCI bridge. Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/Makefile.objs |2 +- hw/i21154.c | 113 ++ hw/i21154.h |9 3 files changed, 123 ins

[Qemu-devel] [PATCH v3 16/26] target-arm: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Cc: Paul Brook Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- target-arm/helper.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-

[Qemu-devel] [PATCH v3 12/26] tcg: forbid ld/st function to modify globals

2012-10-19 Thread Aurelien Jarno
Mapping a memory address using a global and accessing it through ld/st operations is currently broken. As it doesn't make any sense to do that performance wise, let's forbid that. Update the TCG documentation, and remove partial support for that. Reviewed-by: Richard Henderson Signed-off-by: Aur

[Qemu-devel] [PATCH v3 19/26] target-microblaze: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Acked-by: Edgar E. Iglesias Signed-off-by: Aurelien Jarno --- target-microblaze/helper.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

[Qemu-devel] [PATCH v3 16/26] ich9: Add i82801b11 dmi-to-pci bridge

2012-10-19 Thread Jason Baron
From: Jason Baron Add the dmi-to-pci i82801b11 bridge chip. This is the pci bridge chip that q35 uses on its host bus for PCI bus arbitration. Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/Makefile.objs |1 + hw/i82801b11.c | 125 ++

[Qemu-devel] [PATCH v3 24/26] target-sparc: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Cc: Blue Swirl Acked-by: Blue Swirl Signed-off-by: Aurelien Jarno --- target-sparc/helper.h | 50 - 1 file cha

[Qemu-devel] [PATCH v3 21/26] target-ppc: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Cc: Alexander Graf Signed-off-by: Aurelien Jarno --- target-ppc/helper.h | 38 +++--- 1 file changed, 19 insertions(+), 19 dele

[Qemu-devel] [PATCH v3 15/26] target-alpha: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Acked-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-alpha/helper.h | 176 - 1 file changed, 88

[Qemu-devel] [PATCH v3 05/26] tcg: rework liveness analysis

2012-10-19 Thread Aurelien Jarno
Rework the liveness analysis by tracking temps that need to go back to memory in addition to dead temps tracking. This allows to mark output arguments as "need sync", and to synchronize them back to memory as soon as they are not written anymore. This way even arguments mapping to globals can be ma

[Qemu-devel] [PATCH v3 23/26] target-sh4: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Signed-off-by: Aurelien Jarno --- target-sh4/helper.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-sh4/helper.h b/target-sh

[Qemu-devel] [PATCH v3 09/26] tcg: start with local temps in TEMP_VAL_MEM state

2012-10-19 Thread Aurelien Jarno
Start with local temps in TEMP_VAL_MEM state, to make possible a later check that all the temps are correctly saved back to memory. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/tcg.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tcg/tcg.c b/

[Qemu-devel] [PATCH v3 25/26] target-xtensa: rename helper flags

2012-10-19 Thread Aurelien Jarno
Rename helper flags to the new ones. This is purely a mechanical change, it's possible to use better flags by looking at the helpers. Cc: Max Filippov Signed-off-by: Aurelien Jarno --- target-xtensa/helper.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/

[Qemu-devel] [PATCH v3 07/26] pc/piix_pci: factor out smram/pam logic

2012-10-19 Thread Jason Baron
From: Isaku Yamahata Factor out smram/pam logic for later use. Which will be used by q35 too. Reviewed-by: Paolo Bonzini [jba...@redhat.com: changes for updated memory API] Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/i386/Makefile.objs |1 + hw/pam.c | 1

[Qemu-devel] [PATCH v3 18/26] q35: Suppress SMM BIOS initialization under KVM

2012-10-19 Thread Jason Baron
From: Jan Kiszka Same as for i44fx: KVM does not support SMM yet. Signal it initialized to Seabios to avoid failures. Reviewed-by: Paolo Bonzini Signed-off-by: Jan Kiszka Signed-off-by: Jason Baron --- hw/acpi_ich9.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --gi

[Qemu-devel] [PATCH v3 06/26] pc: Move ioapic_init() from pc_piix.c to pc.c

2012-10-19 Thread Jason Baron
From: Jason Baron Move ioapic_init from pc_piix.c to pc.c, to make it a common function. Rename ioapic_init -> ioapic_init_gsi. Reviewed-by: Paolo Bonzini Signed-off-by: Jason Baron --- hw/pc.c | 24 hw/pc.h |2 ++ hw/pc_piix.c | 25 +

[Qemu-devel] [PATCH] tcg/mips: use MUL instead of MULT on MIPS32 and above

2012-10-19 Thread Aurelien Jarno
MIPS32 and later instruction sets have a multiplication instruction directly operating on GPRs. It only produces a 32-bit result but it is exactly what is needed by QEMU. Signed-off-by: Aurelien Jarno --- tcg/mips/tcg-target.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/tcg/mip

[Qemu-devel] [PATCH v2] hmp: fix info cpus for sparc targets

2012-10-19 Thread Aurelien Jarno
On sparc targets, info cpus returns this kind of output: | info cpus | * CPU #0: pc=0x00424d18pc=0x00424d18npc=0x00424d1c thread_id=19460 pc is printed twice, there is no space between pc, pc and npc. With this patch, pc is not printed anymore when has_npc is set. In add

[Qemu-devel] [PATCH v3 05/26] pc, pc_piix: split out pc nic initialization

2012-10-19 Thread Jason Baron
From: Isaku Yamahata Factor out pc nic initialization. This simplifies the pc initialization and will reduce the code duplication of q35 pc initialization. Reviewed-by: Paolo Bonzini Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/pc.c | 15 +++ hw/pc.h

[Qemu-devel] [PATCH v3 09/26] pci: Add class 0xc05 as 'SMBus'

2012-10-19 Thread Jason Baron
From: Jan Kiszka [jba...@redhat.com: add PCI_CLASS_SERIAL_SMBUS definition] Reviewed-by: Paolo Bonzini Signed-off-by: Jan Kiszka Signed-off-by: Jason Baron --- hw/pci.c |1 + hw/pci_ids.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c inde

[Qemu-devel] [PATCH v3 01/26] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if

2012-10-19 Thread Jason Baron
From: Jason Baron The current QEMUMachine definition has a 'use_scsi' field to indicate if a machine type should use scsi by default. However, Q35 wants to use ahci by default. Thus, introdue a new field in the QEMUMachine defintion, mach_if. This field should be initialized by the machine type

Re: [Qemu-devel] [PATCH 3/4] Support for "double whitelist" filters

2012-10-19 Thread Corey Bryant
On 10/19/2012 04:36 PM, Eric Blake wrote: On 10/19/2012 02:08 PM, Corey Bryant wrote: On 10/19/2012 01:04 PM, Blue Swirl wrote: On Wed, Oct 17, 2012 at 1:15 PM, Eduardo Otubo wrote: This patch includes a second whitelist right before the main loop. It's a smaller and more restricted white

[Qemu-devel] [PATCH v3 26/26] ich9: add support pci assignment

2012-10-19 Thread Jason Baron
From: Jason Baron Fills out support for the pci assignment API. Added: PCIINTxRoute ich9_route_intx_pin_to_irq(void *opaque, int pirq_pin) Add calls to pci_bus_fire_intx_routing_notifier() when routing changes are made. Signed-off-by: Jason Baron --- hw/ich9.h |1 + hw/lpc_ich9.c |

[Qemu-devel] [PATCH v3 20/26] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask

2012-10-19 Thread Jason Baron
From: Jan Kiszka Both bits are added to the write-1-to-clear mask by default. As the smbus device does not allow writes at all, we have to remove it from that mask, also to avoid triggering a runtime assertion. Reviewed-by: Paolo Bonzini Signed-off-by: Jan Kiszka Signed-off-by: Jason Baron --

[Qemu-devel] [PATCH v3 21/26] q35: Add kvmclock support

2012-10-19 Thread Jason Baron
From: Jan Kiszka Reviewed-by: Paolo Bonzini Signed-off-by: Jan Kiszka Signed-off-by: Jason Baron --- hw/pc_q35.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/pc_q35.c b/hw/pc_q35.c index 630739f..82ad4e8 100644 --- a/hw/pc_q35.c +++ b/hw/pc_q35.c @@ -69,6 +69,

[Qemu-devel] [PATCH v3 22/26] Add a fallback bios file search, if -L fails.

2012-10-19 Thread Jason Baron
From: Jason Baron If -L is specified, and qemu does not find the bios file in , then the search fails. Add infrastructure such that the search will continue in the default paths, if not found in the -L path. Reviewed-by: Paolo Bonzini Signed-off-by: Jason Baron --- vl.c | 36 ++

[Qemu-devel] [PATCH v3 15/26] q35: Introduce q35 pc based chipset emulator

2012-10-19 Thread Jason Baron
From: Isaku Yamahata pc q35 based chipset emulator to support pci express natively. Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/i386/Makefile.objs |2 +- hw/pc.h |2 + hw/pc_piix.c |4 +- hw/pc_q35.c | 316 +

[Qemu-devel] [PATCH v3 13/26] ich9: Add the lpc chip

2012-10-19 Thread Jason Baron
From: Jason Baron Add support for the ich9 LPC chip. Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/i386/Makefile.objs |2 +- hw/lpc_ich9.c | 523 + 2 files changed, 524 insertions(+), 1 deletions(-) create mode 10

[Qemu-devel] [PATCH v3 24/26] q35: add acpi-based pci hotplug.

2012-10-19 Thread Jason Baron
From: Jason Baron Add piix style acpi hotplug to q35. Signed-off-by: Jason Baron --- hw/acpi_ich9.c | 172 +++- hw/acpi_ich9.h | 10 +++ 2 files changed, 181 insertions(+), 1 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index

[Qemu-devel] [PATCH v3 08/26] pci_ids: add intel 82801BA pci-to-pci bridge id

2012-10-19 Thread Jason Baron
From: Isaku Yamahata Adds pci id constants which will be used by q35. Reviewed-by: Paolo Bonzini Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 301bf1c..c1c8a

[Qemu-devel] [PATCH v3 14/26] ich9: Add smbus

2012-10-19 Thread Jason Baron
From: Jason Baron Add support for the ich9 smbus chip. Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/i386/Makefile.objs |2 +- hw/smbus_ich9.c | 159 + 2 files changed, 160 insertions(+), 1 deletions(-) create mode

[Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-19 Thread Jason Baron
Hi, Qemu bits for q35 support, I'm posting the seabios changes separately. The patches require '-M pc_q35' and -L 'seabios dir with q35 changes' on the qemu command line. Hopefully, we can make it the default for x86 at some future point when we feel comfortable with it. The current patches have

Re: [Qemu-devel] [PATCH 3/4] Support for "double whitelist" filters

2012-10-19 Thread Eric Blake
On 10/19/2012 02:08 PM, Corey Bryant wrote: > > > On 10/19/2012 01:04 PM, Blue Swirl wrote: >> On Wed, Oct 17, 2012 at 1:15 PM, Eduardo Otubo >> wrote: >>> This patch includes a second whitelist right before the main loop. It's >>> a smaller and more restricted whitelist, excluding execve() amon

Re: [Qemu-devel] [PATCH v2 14/26] tcg: rework TCG helper flags

2012-10-19 Thread Aurelien Jarno
On Wed, Oct 10, 2012 at 10:11:54AM -0700, Richard Henderson wrote: > On 10/09/2012 12:56 PM, Aurelien Jarno wrote: > > +if (!(call_flags & (TCG_CALL_NO_WRITE_GLOBALS | > > +TCG_CALL_NO_READ_GLOBALS))) { > > Code like this would be shorter

Re: [Qemu-devel] [PATCH 3/4] Support for "double whitelist" filters

2012-10-19 Thread Corey Bryant
On 10/19/2012 01:04 PM, Blue Swirl wrote: On Wed, Oct 17, 2012 at 1:15 PM, Eduardo Otubo wrote: This patch includes a second whitelist right before the main loop. It's a smaller and more restricted whitelist, excluding execve() among many others. Signed-off-by: Eduardo Otubo --- qemu-secc

Re: [Qemu-devel] [PATCH 3/4] Support for "double whitelist" filters

2012-10-19 Thread Corey Bryant
On 10/17/2012 09:15 AM, Eduardo Otubo wrote: This patch includes a second whitelist right before the main loop. It's a smaller and more restricted whitelist, excluding execve() among many others. Signed-off-by: Eduardo Otubo --- qemu-seccomp.c | 94 ++

Re: [Qemu-devel] [PATCH 1/4] Adding new syscalls (bugzilla 855162)

2012-10-19 Thread Corey Bryant
On 10/17/2012 09:15 AM, Eduardo Otubo wrote: According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist whenn using Qemu with Libvirt. [1] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 Reported-by: Paul Moore Signed-off-by: Eduardo Otubo --- qemu-secc

Re: [Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation

2012-10-19 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 07:09:25PM +0200, Jan Kiszka wrote: > We need to evaluate $libexecdir in configure, otherwise we literally end > up with "${prefix}/libexec" instead of the absolute path as > CONFIG_QEMU_HELPERDIR. > > Signed-off-by: Jan Kiszka > --- > configure |2 +- > 1 files chang

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update email address for Stefan Hajnoczi

2012-10-19 Thread Aurelien Jarno
On Sun, Oct 07, 2012 at 06:08:49PM +0200, Stefan Hajnoczi wrote: > Switch to my new work email address from which I am contributing. > > Signed-off-by: Stefan Hajnoczi > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > in

Re: [Qemu-devel] [PATCH v2] qemu-options.hx: Change from recommending '?' to 'help'

2012-10-19 Thread Aurelien Jarno
On Thu, Oct 04, 2012 at 04:22:01PM +0100, Peter Maydell wrote: > Update the -help output and documentation so that it recommends > 'help' rather than '?' for the various "list valid values for this > option" cases. '?' is deprecated (as it can fail confusingly if > not quoted), so it's better to st

Re: [Qemu-devel] [PATCH] tci: fix build breakage for target-sparc

2012-10-19 Thread Aurelien Jarno
On Mon, Oct 08, 2012 at 03:45:49PM -0500, Michael Roth wrote: > commit c28ae41 introduced GETPC() usage for sparc, which is currently > not defined when building with --enable-tcg-interpreter. Add sparc to > the list of targets we selectively define GETPC() for. > > Signed-off-by: Michael Roth >

Re: [Qemu-devel] [PATCH v2] allow make {dist, }clean work w/out configure

2012-10-19 Thread Aurelien Jarno
On Sun, Sep 16, 2012 at 04:07:13PM -0400, Mike Frysinger wrote: > There's no reason to require configure to run before running a clean > target, so check MAKECMDGOALS before. > > Signed-off-by: Mike Frysinger > --- > v2 > - handle edge cases > > Makefile |4 > 1 file changed, 4 i

Re: [Qemu-devel] [PULL 0/6] Trivial patches for 13 to 19 October 2012

2012-10-19 Thread Aurelien Jarno
On Fri, Oct 19, 2012 at 10:54:18AM +0200, Stefan Hajnoczi wrote: > The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4: > > target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200) > > are available in the git repository at: > > git://github.com/stefanha/qem

Re: [Qemu-devel] [PULL] [PATCH 00/11] Pending linux-user patches

2012-10-19 Thread Aurelien Jarno
On Thu, Oct 18, 2012 at 02:30:56PM +0300, riku.voi...@linaro.org wrote: > From: Riku Voipio > > The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade: > > ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000) > > are available in the git repository at: > > git

Re: [Qemu-devel] [PATCHv5] tests/tcg: fix build

2012-10-19 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 04:00:23PM -0400, Catalin Patulea wrote: > This broke when the tests were moved from tests/ to tests/tcg/. > > On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are > broken, but at least they build. > > To build/run the tests: > $ cd $BUILD_PATH/tests

[Qemu-devel] Change from using the disassembler to another tool

2012-10-19 Thread Itliang
Hi, I want to develop a target that will run an IR code instead of binary. A tool has been developed to read the IR code. But as my lack of knowledge in QEMU, I don't know where to start to merge the tool to QEMU. Could I ask for any assistances here? Any comments or consults would be apprecia

[Qemu-devel] [Bug 804517] Re: qemu crashes on Darwin in qemu_iohandler_poll

2012-10-19 Thread Oliver
I am seeing the same think when I try to run a sample built under gcc from the TI tools 117 void qemu_iohandler_poll(fd_set *readfds, fd_set *writefds, fd_set *xfds, int ret) 118 { 119 if (ret > 0) { 120 IOHandlerRecord *pioh, *ioh; 121 122 QLIST_FOREA

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-19 Thread Michael Roth
On Fri, Oct 19, 2012 at 05:18:46PM +, Blue Swirl wrote: > On Wed, Oct 17, 2012 at 8:14 PM, Eduardo Habkost wrote: > > On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > > [...] > >> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c > >> new file mode 100644 > >> index

Re: [Qemu-devel] nvram and boot order

2012-10-19 Thread Benjamin Herrenschmidt
On Fri, 2012-10-19 at 09:21 -0500, Anthony Liguori wrote: > > That's true to an extent. However, I vehemently disagree that it's > > arbitrary which one gets the new option. Neither -boot nor bootindex= > > alter any persistent data now and they should not suddenly start doing > > so. > > That'

Re: [Qemu-devel] [PATCH 11/14] pixman/vnc: use pixman images in vnc.

2012-10-19 Thread Stefano Stabellini
On Wed, 17 Oct 2012, Gerd Hoffmann wrote: > The vnc code uses *three* DisplaySurfaces: > > First is the surface of the actual QemuConsole, usually the guest > screen, but could also be a text console (monitor/serial reachable via > Ctrl-Alt- keys). This is left as-is. > > Second is the current s

Re: [Qemu-devel] [PATCH] Makefile: Forbid out-of-tree build from a source tree that has been built in

2012-10-19 Thread Blue Swirl
On Fri, Oct 19, 2012 at 1:54 PM, Peter Maydell wrote: > If we try to do an out-of-tree build but the source tree we're building from > has been used in the past for an in-tree build then things will go > confusingly wrong. Specifically, some parts of the build process will pull > in generated file

[Qemu-devel] [PATCH v3] hw/qdev-properties.c: Improve diagnostic for setting property after realize

2012-10-19 Thread Peter Maydell
Now we have error_setg() we can improve the error message emitted if you attempt to set a property of a device after the device is realized (the previous message was "permission denied" which was not very informative). Signed-off-by: Peter Maydell --- This is v3 of this patch (v2 was sent back in

Re: [Qemu-devel] [PATCH 0/6] *** TCG global variables clean-up ***

2012-10-19 Thread Blue Swirl
On Fri, Oct 19, 2012 at 12:42 PM, Evgeny wrote: > This set of patches moves global variables to tcg_ctx: > gen_opc_ptr > gen_opparam_ptr > gen_opc_buf > gen_opparam_buf > > Where it was possible I used s->... > Where we don't have an interface to pass a pointer to tcg_ctx, I used > tcg_ctx.xxx >

Re: [Qemu-devel] [PATCH 5/6] TCG: Use gen_opparam_buf from context instead of global variable.

2012-10-19 Thread Blue Swirl
On Fri, Oct 19, 2012 at 12:42 PM, Evgeny wrote: > Signed-off-by: Evgeny > --- > tcg/tcg.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index 3da1d83..77b15a0 100644 > --- a/tcg/tcg.c > +++ b/tcg/tcg.c > @@ -302,7 +302,7 @@ void tcg

Re: [Qemu-devel] [Qemu-trivial] [PATCH 00/11] static patches

2012-10-19 Thread Blue Swirl
On Fri, Oct 19, 2012 at 8:38 AM, Stefan Hajnoczi wrote: > On Sun, Oct 14, 2012 at 07:58:48PM +, Blue Swirl wrote: >> I made a small tool to detect unused functions and >> variables. Here's some fixes. >> >> Blue Swirl (11): >> target-sparc: make do_unaligned_access static >> vl.c: add miss

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-19 Thread Blue Swirl
On Thu, Oct 18, 2012 at 12:33 PM, Avi Kivity wrote: > On 10/18/2012 11:27 AM, Vasilis Liaskovitis wrote: >> On Wed, Oct 17, 2012 at 12:03:51PM +0200, Avi Kivity wrote: >>> On 10/17/2012 11:19 AM, Vasilis Liaskovitis wrote: >>> >> >>> >> I don't think so, but probably there's a limit of DIMMs that

[Qemu-devel] [PATCH v2 0/3] net: convert NetClientState to QOM

2012-10-19 Thread Stefan Hajnoczi
This series converts NetClientState from a plain C struct to QOM. This means emulated NICs and netdevs now derive from the NetClientState base class. There should be no user-visible change. Converting the net subsystem to QOM opens the door to the following improvements which can be built on top

Re: [Qemu-devel] nvram and boot order

2012-10-19 Thread Blue Swirl
On Thu, Oct 18, 2012 at 6:32 AM, Alexander Graf wrote: > > > On 18.10.2012, at 03:18, Benjamin Herrenschmidt > wrote: > >> On Thu, 2012-10-18 at 11:09 +1100, David Gibson wrote: >> > That's horrible; if you use -boot just once it will clobber a > persistent NVRAM's boot order. I see tha

[Qemu-devel] [PATCH 1/2] error: Distinguish critical and non-critical errors

2012-10-19 Thread Peter Maydell
Add the concept of a 'critical' error, which is one that must not be ignored. If, at the point when the error is raised or at any subsequent point while propagating it, we find that we would be throwing away the error because of a NULL Error**, we print the error message to stderr and abort(). Sig

[Qemu-devel] [PATCH 0/2] qom: detect attempts to add a property that already exists

2012-10-19 Thread Peter Maydell
The aim of this patch series is to make QEMU exit with a helpful error message for bugs where multiple properties of the same name are accidentally added to a QOM object. In order to achieve this for static properties whilst still allowing the hotplug case to gracefully fail without killing QEMU, w

Re: [Qemu-devel] [PATCH v3 12/16] qemu-iotests: add mirroring test case

2012-10-19 Thread Kevin Wolf
Am 18.10.2012 16:49, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > v2->v3: new testcases test_cancel_after_ready and > test_medium_not_found, removed obsolete workaround > for os.remove failure. Fixed copyright header. > > tests/qemu-iotests/041 | 364

[Qemu-devel] [PATCH 2/2] qom: Detect attempts to add a property that already exists

2012-10-19 Thread Peter Maydell
Detect attempts to add a property to an object if one of that name already exists, and report them as critical errors. In particular, for static properties (eg qdev Property arrays) this will manifest as an abort() with a useful error message. Signed-off-by: Peter Maydell --- qom/object.c | 13

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-19 Thread Blue Swirl
On Wed, Oct 17, 2012 at 8:14 PM, Eduardo Habkost wrote: > On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > [...] >> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c >> new file mode 100644 >> index 000..8b0d0ff >> --- /dev/null >> +++ b/hw/qdev-properties.c >> @@ -0,0 +

[Qemu-devel] [PATCH v2 2/3] net: extract notify_link_status_changed() function

2012-10-19 Thread Stefan Hajnoczi
From: Stefan Hajnoczi The code to invoke the NetClientInfo .link_status_changed() callback is duplicated in several places. Create a single notify_link_status_changed() function and avoid duplication. This is useful because later patches change net internals. By having a single function it is

[Qemu-devel] [PATCH v2 1/3] net: add public qemu_net_poll() function

2012-10-19 Thread Stefan Hajnoczi
From: Stefan Hajnoczi The NetClientInfo .poll() callback is being called directly by hw/vhost_net.c. Create a public net.c function so callers do not depend on internals. This change is useful because later patches change net internals. Those changes shouldn't affect .poll() callers. Signed-o

Re: [Qemu-devel] [PATCHv4] qemu-img rebase: use empty string to rebase without backing file

2012-10-19 Thread Eric Blake
On 10/19/2012 10:46 AM, Kevin Wolf wrote: >> As it happens, we despite what Eric Blake said, we couldn't get an unsafe >> rebase to no backing file to work with the existing code (with our without >> our patch). The second option may fix this bug. Reading line 1497, is this >> because the semantic

Re: [Qemu-devel] [PATCH] qemu: enable PV EOI for qemu 1.3

2012-10-19 Thread Blue Swirl
On Wed, Oct 17, 2012 at 7:40 PM, Michael S. Tsirkin wrote: > Enable KVM PV EOI by default. You can still disable it with > -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, > enable only for qemu 1.3 or newer machine type. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pc.h

Re: [Qemu-devel] [PATCH 3/4] Support for "double whitelist" filters

2012-10-19 Thread Blue Swirl
On Wed, Oct 17, 2012 at 1:15 PM, Eduardo Otubo wrote: > This patch includes a second whitelist right before the main loop. It's > a smaller and more restricted whitelist, excluding execve() among many > others. > > Signed-off-by: Eduardo Otubo > --- > qemu-seccomp.c | 94 > +

Re: [Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha fields for 32bpp

2012-10-19 Thread Stefano Stabellini
On Wed, 17 Oct 2012, Gerd Hoffmann wrote: > Currently it is inconstent, PixelFormat->amask is left unset whereas > abits and amax and ashift are filled. As an alpha channel doesn't make > sense for the vga framebuffer leave all alpha fields clear. > > Signed-off-by: Gerd Hoffmann Actually the a

  1   2   3   >