Re: [Qemu-devel] [PATCH] trivial fix of inet_listen() parameter

2012-09-29 Thread Igor Mammedov
On Sat, 29 Sep 2012 17:32:31 +0800 Amos Kong wrote: > .. int inet_listen(const char *str, char *ostr, int olen, > .. int socktype, int port_offset, Error **errp) > > Here 'ostr' is NULL, so change 'olen' to zero. > > Signed-off-by: Amos Kong > --- > migration-tcp.c |2 +- >

Re: [Qemu-devel] [PATCH 1/3] tcg-alpha: Fix type mismatch errors in cpu_signal_handler.

2012-09-29 Thread Stefan Weil
Am 29.09.2012 20:10, schrieb Richard Henderson: Signed-off-by: Richard Henderson --- user-exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/user-exec.c b/user-exec.c index ef9b172..1635e4a 100644 --- a/user-exec.c +++ b/user-exec.c @@ -352,8 +352,8 @@ int cpu_signa

[Qemu-devel] [PATCH 2/3] tcg-alpha: Don't use a custom linker script.

2012-09-29 Thread Richard Henderson
The default placement of the binary at 6G is fine. Signed-off-by: Richard Henderson --- alpha.ld | 127 --- 1 file changed, 127 deletions(-) delete mode 100644 alpha.ld diff --git a/alpha.ld b/alpha.ld deleted file mode 100644 index 9

[Qemu-devel] [PATCH 1/3] tcg-alpha: Fix type mismatch errors in cpu_signal_handler.

2012-09-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- user-exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/user-exec.c b/user-exec.c index ef9b172..1635e4a 100644 --- a/user-exec.c +++ b/user-exec.c @@ -352,8 +352,8 @@ int cpu_signal_handler(int host_signum, void *pinfo, { sig

[Qemu-devel] [PATCH 0/3] Alpha TCG host

2012-09-29 Thread Richard Henderson
A re-base and update of a tcg backend that I wrote almost 2 years ago. r~ Richard Henderson (3): tcg-alpha: Fix type mismatch errors in cpu_signal_handler. tcg-alpha: Don't use a custom linker script. tcg-alpha: New TCG target. alpha.ld | 127 configure

[Qemu-devel] Memory ballooning: wrong size?

2012-09-29 Thread Tiziano Müller
Hi everyone A look through recent changes didn't reveal anything (or I missed it), so please excuse me if this is already fixed, but with qemu-1.1.1 and guest linux kernels 3.3.x and 3.5.0 the size of the memory qemu sets via memory ballooning and what the guest sees do not match: hmp: `balloon 1

Re: [Qemu-devel] [PATCH 09/12] tcg-sparc: Drop use of Bicc in favor of BPcc

2012-09-29 Thread Richard Henderson
On 2012-09-29 05:07, Blue Swirl wrote: > On Thu, Sep 27, 2012 at 1:55 AM, Richard Henderson wrote: >> Now that we're always sparcv9, we can not bother using Bicc for >> 32-bit branches and BPcc for 64-bit branches and instead always >> use BPcc. > > But then the branch range is smaller (19 bits).

[Qemu-devel] [PATCH 1/2] signal: added a wrapper for sigprocmask function

2012-09-29 Thread Alex Barcelo
A transparent wrapper for sigprocmask function. --- linux-user/qemu.h|1 + linux-user/signal.c |8 linux-user/syscall.c | 20 ++-- 3 files changed, 19 insertions(+), 10 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index fc4cc00..e2dd6a6

[Qemu-devel] [PATCH 2/2] signal: sigsegv protection on do_sigprocmask

2012-09-29 Thread Alex Barcelo
The sigsegv protection is done by forcing the catch (needed in qemu-user) and then taking it off from the return mask (well, adding it in fact) --- linux-user/signal.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index

[Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user

2012-09-29 Thread Alex Barcelo
The first patch creates a sigprocmask wrapper on signal.c for its use in syscall.c The second patch changes the wrapper to protect sigsegv bit on the signal mask. Alex Barcelo (2): signal: added a wrapper for sigprocmask function signal: sigsegv protection on do_sigprocmask linux-user/qemu

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-29 Thread Alexander Graf
On 29.09.2012, at 16:11, Blue Swirl wrote: > On Sat, Sep 29, 2012 at 12:54 PM, Alexander Graf wrote: >> >> >> On 29.09.2012, at 13:46, Blue Swirl wrote: >> >>> On Wed, Sep 26, 2012 at 8:51 PM, Alexander Graf wrote: On 26.09.2012, at 22:03, Anthony Liguori wrote: >>

[Qemu-devel] [PATCH v5] Align PCI capabilities in pci_find_space

2012-09-29 Thread Matt Renzelmann
The current implementation of pci_find_space does not correctly align PCI capabilities in the PCI configuration space. It also does not support PCI-Express devices. This patch fixes these issues. Thanks to Alex Williamson for feedback. Signed-off-by: Matt Renzelmann --- Braces added. hw/pci

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-29 Thread Don Slutz
On 09/13/12 16:57, Anthony Liguori wrote: "Michael S. Tsirkin" writes: On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: +if (next_chain_offset) { +MptSGEntryChain sgec; +cpu_physical_memory_read(seg_start_pa + next_chain_offset, +

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-29 Thread Blue Swirl
On Sat, Sep 29, 2012 at 12:54 PM, Alexander Graf wrote: > > > On 29.09.2012, at 13:46, Blue Swirl wrote: > >> On Wed, Sep 26, 2012 at 8:51 PM, Alexander Graf wrote: >>> >>> >>> On 26.09.2012, at 22:03, Anthony Liguori wrote: >>> Alexander Graf writes: > On 22.09.2012, at 15:31, B

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-29 Thread Alexander Graf
On 29.09.2012, at 13:46, Blue Swirl wrote: > On Wed, Sep 26, 2012 at 8:51 PM, Alexander Graf wrote: >> >> >> On 26.09.2012, at 22:03, Anthony Liguori wrote: >> >>> Alexander Graf writes: >>> On 22.09.2012, at 15:31, Blue Swirl wrote: > On Fri, Sep 21, 2012 at 3:08 AM, Dav

Re: [Qemu-devel] [PATCH 09/12] tcg-sparc: Drop use of Bicc in favor of BPcc

2012-09-29 Thread Blue Swirl
On Thu, Sep 27, 2012 at 1:55 AM, Richard Henderson wrote: > Now that we're always sparcv9, we can not bother using Bicc for > 32-bit branches and BPcc for 64-bit branches and instead always > use BPcc. But then the branch range is smaller (19 bits). The code buffer is 32M, wouldn't we use BPcc fo

Re: [Qemu-devel] [PATCH 07/12] tcg-sparc: Use Z constraint for %g0

2012-09-29 Thread Blue Swirl
On Thu, Sep 27, 2012 at 1:55 AM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/sparc/tcg-target.c | 109 > ++--- > tcg/sparc/tcg-target.h | 5 ++- > 2 files changed, 60 insertions(+), 54 deletions(-) > > diff --git a/tcg/sp

Re: [Qemu-devel] [PATCH] gic: avoid a warning from clang

2012-09-29 Thread Blue Swirl
On Sat, Sep 29, 2012 at 11:44 AM, Peter Maydell wrote: > On 29 September 2012 12:25, Blue Swirl wrote: >> On Mon, Sep 24, 2012 at 2:56 PM, Peter Maydell >> wrote: >>> On 24 September 2012 14:22, Peter Maydell wrote: On 23 September 2012 17:33, Blue Swirl wrote: > Avoid this warning:

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define how to handle acronyms in CamelCase

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 9:59 PM, Anthony Liguori wrote: > Alex Williamson writes: > >> When creating structure names in CamelCase, it's easy to have >> back-to-back capitals when using acronyms (ex. PCIINTxRoutingNotifier, >> QEMUSGList, VFIOINTx). In the worst case these can look like macros, >

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 8:51 PM, Alexander Graf wrote: > > > On 26.09.2012, at 22:03, Anthony Liguori wrote: > >> Alexander Graf writes: >> >>> On 22.09.2012, at 15:31, Blue Swirl wrote: >>> On Fri, Sep 21, 2012 at 3:08 AM, David Gibson wrote: > Below is a patch which implements

Re: [Qemu-devel] [PATCH] gic: avoid a warning from clang

2012-09-29 Thread Peter Maydell
On 29 September 2012 12:25, Blue Swirl wrote: > On Mon, Sep 24, 2012 at 2:56 PM, Peter Maydell > wrote: >> On 24 September 2012 14:22, Peter Maydell wrote: >>> On 23 September 2012 17:33, Blue Swirl wrote: Avoid this warning: CCarm-softmmu/hw/arm/../arm_gic.o /src/qemu/hw/

Re: [Qemu-devel] [PATCH v4] Align PCI capabilities in pci_find_space

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 6:51 PM, Matt Renzelmann wrote: > The current implementation of pci_find_space does not correctly align > PCI capabilities in the PCI configuration space. It also does not > support PCI-Express devices. This patch fixes these issues. > > Thanks to Alex Williamson for feed

Re: [Qemu-devel] [PATCH v2 3/4] serial: add windows inf file for the pci card to docs

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 12:14 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > docs/qemupciserial.inf | 107 > > 1 files changed, 107 insertions(+), 0 deletions(-) > create mode 100644 docs/qemupciserial.inf > > diff --git a/docs

Re: [Qemu-devel] [PATCH 1/6] savevm: Add VMSTATE_UINT64_EQUAL helpers

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 3:21 AM, David Gibson wrote: > The savevm code already includes a number of *_EQUAL helpers which act as > sanity checks verifying that the configuration of the saved state matches > that of the machine we're loading into to work. Variants already exist > for 8 bit 16 bit

Re: [Qemu-devel] [PATCH 09/17] aio: prepare for introducing GSource-based dispatch

2012-09-29 Thread Blue Swirl
On Tue, Sep 25, 2012 at 12:55 PM, Paolo Bonzini wrote: > This adds a GPollFD to each AioHandler. It will then be possible to > attach these GPollFDs to a GSource, and from there to the main loop. > aio_wait examines the GPollFDs and avoids calling select() if any > is set (similar to what it does

Re: [Qemu-devel] [RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-29 Thread Blue Swirl
On Mon, Sep 24, 2012 at 3:27 PM, Vasilis Liaskovitis wrote: > On Sat, Sep 22, 2012 at 02:15:28PM +, Blue Swirl wrote: >> > + >> > +/* Function to configure memory offsets of hotpluggable dimms */ >> > + >> > +target_phys_addr_t pc_set_hp_memory_offset(uint64_t size) >> > +{ >> > +target_ph

Re: [Qemu-devel] [PATCH] gic: avoid a warning from clang

2012-09-29 Thread Blue Swirl
On Mon, Sep 24, 2012 at 2:56 PM, Peter Maydell wrote: > On 24 September 2012 14:22, Peter Maydell wrote: >> On 23 September 2012 17:33, Blue Swirl wrote: >>> Avoid this warning: >>> CCarm-softmmu/hw/arm/../arm_gic.o >>> /src/qemu/hw/arm/../arm_gic.c:432:17: error: implicit truncation from

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-09-29 Thread Blue Swirl
On Mon, Sep 24, 2012 at 10:42 AM, Vasilis Liaskovitis wrote: > On Sat, Sep 22, 2012 at 01:46:57PM +, Blue Swirl wrote: >> On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis >> wrote: >> > Example: >> > "-dimm id=dimm0,size=512M,node=0,populated=off" >> >> There should not be a need to intr

[Qemu-devel] vmstate within vmstate (VMS_STRUCT) versioning is broken ?

2012-09-29 Thread Hans de Goede
Hi All, While working on a bugfix for USB migration I noticed that the versioning of VMS_STRUCT does not work as I would expect. Currently when loading VMS_STRUCT state, the vmsd version gets passed: vmstate_load_state(f, field->vmsd, addr, field->vmsd->version_id); This means that any later ad

[Qemu-devel] [PATCH] trivial fix of inet_listen() parameter

2012-09-29 Thread Amos Kong
.. int inet_listen(const char *str, char *ostr, int olen, .. int socktype, int port_offset, Error **errp) Here 'ostr' is NULL, so change 'olen' to zero. Signed-off-by: Amos Kong --- migration-tcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/migrati

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-29 Thread liu ping fan
On Thu, Sep 27, 2012 at 5:16 PM, Avi Kivity wrote: > On 09/27/2012 05:13 AM, liu ping fan wrote: >> On Mon, Sep 24, 2012 at 5:42 PM, Avi Kivity wrote: >>> On 09/24/2012 10:32 AM, liu ping fan wrote: On Mon, Sep 24, 2012 at 3:44 PM, Avi Kivity wrote: > On 09/24/2012 08:33 AM, liu ping fa

[Qemu-devel] [PATCH V5 1/5] libqblock build system

2012-09-29 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock. GCC

Re: [Qemu-devel] [PATCH V5 3/5] libqblock API

2012-09-29 Thread Paolo Bonzini
Il 29/09/2012 10:13, Wenchao Xia ha scritto: > +static void qb_setup_info_addr(QBlockStaticInfo *info, > + QBlockStaticInfoAddr *info_addr) > +{ > +uint64_t *virt_size = NULL; > +QBlockLocationInfo *backing_loc = NULL; > +bool *encrypt = NULL; > +QBlock

[Qemu-devel] [PATCH V5 2/5] libqblock type defines

2012-09-29 Thread Wenchao Xia
This patch contains type and macro defines used in APIs, one file for public usage by user, one for libqblock internal usage. Signed-off-by: Wenchao Xia --- libqblock/libqblock-internal.h | 75 libqblock/libqblock-types.h| 256 2 fil

[Qemu-devel] [PATCH V5 3/5] libqblock API

2012-09-29 Thread Wenchao Xia
This patch contains the major APIs in the library. For ABI some reserved members were used. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockState. It stands for an block image object. 3 QBlockStaticInfo. It contains st

[Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-09-29 Thread Wenchao Xia
In this example, at first it will create some qcow2 images, then get information including backing file relationship. Then it will do sync IO on the image. Signed-off-by: Wenchao Xia --- tests/libqblock/libqblock-qcow2.c | 392 - 1 files changed, 390 insert

[Qemu-devel] [PATCH V5 4/5] libqblock test build system

2012-09-29 Thread Wenchao Xia
This patch added build system for testing libqblock, make check-libqblock will build and test it, make clean or make check-clean will delete generated binaries. Signed-off-by: Wenchao Xia --- .gitignore|2 ++ Makefile |2 +- tests/Makefi

[Qemu-devel] [PATCH V5 0/5] libqblock qemu block layer library

2012-09-29 Thread Wenchao Xia
This patch introduce libqblock API, make libqblock.la and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported Format