Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-19 Thread Abel Gordon
GaoYi wrote on 20/09/2012 08:42:51 AM: >    The CPU isolation in Hitachi patches is just to improve the real > time performance of GUEST. The core of it, direct IRQ delivery, is > very similar to that of ELI. >     For the ELI patches, >     (1) Since EOI part of ELI is already supported by the

Re: [Qemu-devel] [RFC PATCH 10/16] qcow2: Delay the COW

2012-09-19 Thread Kevin Wolf
Am 19.09.2012 20:47, schrieb Blue Swirl: > On Tue, Sep 18, 2012 at 11:40 AM, Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf >> --- >> block/qcow2-cluster.c | 29 + >> block/qcow2.c | 31 --- >> block/qcow2.h | 10 +

Re: [Qemu-devel] [PATCH v7 2/5] sockets: Change inet_parse() to accept address specification without port

2012-09-19 Thread Kevin Wolf
Am 20.09.2012 08:30, schrieb Bharata B Rao: > On Tue, Sep 18, 2012 at 04:08:43PM +0200, Kevin Wolf wrote: >> Am 18.09.2012 15:31, schrieb Paolo Bonzini: >>> Il 18/09/2012 15:22, Kevin Wolf ha scritto: Am 17.09.2012 17:23, schrieb Bharata B Rao: > sockets: Change inet_parse() to accept addr

Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling

2012-09-19 Thread Gerd Hoffmann
On 09/20/12 08:43, Michael Tokarev wrote: > For now it is irrelevant actually, since right after the > switch we already have "return", so "break" is now the > same as "return". For future it might not be the case. Oh, right. Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling

2012-09-19 Thread Michael Tokarev
On 20.09.2012 10:41, Gerd Hoffmann wrote: > On 09/19/12 15:41, Michael Tokarev wrote: >> This cleans up two additions of almost the same code in commits >> 511b13e2c9 and ccc2960d654. While at it, make error paths >> consistent (always use 'break' instead of 'return'). > > Other way around: shoul

Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling

2012-09-19 Thread Gerd Hoffmann
On 09/19/12 15:41, Michael Tokarev wrote: > This cleans up two additions of almost the same code in commits > 511b13e2c9 and ccc2960d654. While at it, make error paths > consistent (always use 'break' instead of 'return'). Other way around: should be 'return' not 'break'. cheers, Gerd

Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

2012-09-19 Thread Bharata B Rao
On Tue, Sep 18, 2012 at 04:01:58PM +0200, Kevin Wolf wrote: > > + > > +#define GLUSTER_TRANSPORT_DEFAULT"gluster://" > > +#define GLUSTER_TRANSPORT_DEFAULT_SZ strlen(GLUSTER_TRANSPORT_DEFAULT) > > +#define GLUSTER_TRANSPORT_TCP"gluster+tcp://" > > +#define GLUSTER_TRANSPORT_

[Qemu-devel] buildbot failure in qemu on block_x86_64_debian_6_0

2012-09-19 Thread qemu
The Buildbot has detected a new failure on builder block_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_x86_64_debian_6_0/builds/394 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Buil

[Qemu-devel] buildbot failure in qemu on block_i386_debian_6_0

2012-09-19 Thread qemu
The Buildbot has detected a new failure on builder block_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_i386_debian_6_0/builds/394 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Re

Re: [Qemu-devel] [PATCH v7 2/5] sockets: Change inet_parse() to accept address specification without port

2012-09-19 Thread Bharata B Rao
On Tue, Sep 18, 2012 at 04:08:43PM +0200, Kevin Wolf wrote: > Am 18.09.2012 15:31, schrieb Paolo Bonzini: > > Il 18/09/2012 15:22, Kevin Wolf ha scritto: > >> Am 17.09.2012 17:23, schrieb Bharata B Rao: > >>> sockets: Change inet_parse() to accept address specification without port > >>> > >>> From

Re: [Qemu-devel] [PATCH v2] add a boot parameter to set reboot timeout

2012-09-19 Thread Gleb Natapov
On Thu, Sep 20, 2012 at 11:15:26AM +0800, Amos Kong wrote: > On 07/09/12 11:11, Amos Kong wrote: > >Added an option to let qemu transfer a configuration file to bios, > >"etc/boot-fail-wait", which could be specified by command > > -boot reboot-timeout=T > >T have a max value of 0x, unit is

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-19 Thread Gerd Hoffmann
Hi, >> +if (surface) { >> +pixman_image_unref(surface); >> } >> +surface = pixman_from_displaystate(ds); > > Am I reading this right? Are you creating a new pixman surface in every > call to fbdev_update? No. The whole block doing this is wrapped into "if

[Qemu-devel] buildbot failure in qemu on block_openbsd_4.9

2012-09-19 Thread qemu
The Buildbot has detected a new failure on builder block_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_openbsd_4.9/builds/329 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_openbsd49 Build

[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-09-19 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/329 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason: The

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-19 Thread Michael S. Tsirkin
> @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) > return sock; > } > > - > -int inet_nonblocking_connect(const char *str, bool *in_progress, > - Error **errp) > +int inet_nonblocking_connect(const char *str, ConnectHandler *callback, > +

Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static.

2012-09-19 Thread Bharata B Rao
On Tue, Sep 18, 2012 at 02:57:59PM +0200, Paolo Bonzini wrote: > Il 18/09/2012 14:47, Kevin Wolf ha scritto: > >> > Makefile.objs |2 +- > >> > qemu-config.c | 31 +++ > >> > qemu-sockets.c | 42 ++ > >> > qemu_socket.h

Re: [Qemu-devel] [PATCH 2/9] tcg/optimizer: check types in copy propagation

2012-09-19 Thread Aurelien Jarno
On Wed, Sep 19, 2012 at 02:33:46PM -0700, Richard Henderson wrote: > On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > > The copy propagation doesn't check the types of the temps during copy > > propagation. However TCG is using the mov_i32 for the i64 to i32 > > conversion and thus the two are not e

Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd

2012-09-19 Thread Peter Portante
On Wed, Sep 19, 2012 at 10:27 AM, Jan Kiszka wrote: > Please turn of HTML in you mailer. It's very hard to parse your reply. > > On 2012-09-19 16:15, Peter Portante wrote: >> On Wed, Sep 19, 2012 at 3:44 AM, Jan Kiszka >> mailto:jan.kis...@siemens.com>> wrote: >> On 2012-09-19 09:26, Paolo Bonzin

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Gerd Hoffmann
Hi, >> +vbe_ioport_write_index(&d->vga, 0, index); >> +return vbe_ioport_read_data(&d->vga, 0); > > These functions are only available with CONFIG_BOCHS_VBE #defined, so > this code should be conditional as well. > > But building without CONFIG_BOCHS_VBE is not very useful since it's >

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-19 Thread GaoYi
The CPU isolation in Hitachi patches is just to improve the real time performance of GUEST. The core of it, direct IRQ delivery, is very similar to that of ELI. For the ELI patches, (1) Since EOI part of ELI is already supported by the Intel Sandy Bridge CPUs and requires modifications o

Re: [Qemu-devel] [PATCH 0/3] Intruduce qemu-ga-client

2012-09-19 Thread Michael Tokarev
On 20.09.2012 00:20, Luiz Capitulino wrote: > On Fri, 14 Sep 2012 21:44:19 +0900 > Ryota Ozaki wrote: > >> This patch series adds qemu-ga-client that is a command line >> script to use guest agent functions easily. Can't this be implemented in the agent itself, without a need for a wrapper? Not

[Qemu-devel] Any plan to support armv8 emulation

2012-09-19 Thread Michael.Kang
Is there any developers who have plan to support armv8 emulation? Or have some initial roadmap for support of armv8? I know there is already armv8 patch merged into linux kernel. -- MK -- www.skyeye.org

Re: [Qemu-devel] [PATCH v2] add a boot parameter to set reboot timeout

2012-09-19 Thread Amos Kong
On 07/09/12 11:11, Amos Kong wrote: Added an option to let qemu transfer a configuration file to bios, "etc/boot-fail-wait", which could be specified by command -boot reboot-timeout=T T have a max value of 0x, unit is ms. With this option, guest will wait for a given time if not find bo

Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd

2012-09-19 Thread Anthony Liguori
Jan Kiszka writes: > On 2012-09-19 09:26, Paolo Bonzini wrote: >> Il 18/09/2012 22:37, Anthony Liguori ha scritto: >>> Unfortunately, there's a lot of Windows code in qemu-timer.c and main-loop.c >>> right now otherwise the refactoring would be trivial. I'll leave that for >>> another day. >>> >

Re: [Qemu-devel] [PATCH v3 1/3] Refactor inet_connect_opts function

2012-09-19 Thread Amos Kong
On 19/09/12 16:33, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: From: "Michael S. Tsirkin" refactor address resolution code to fix nonblocking connect remove getnameinfo call Signed-off-by: Michael S. Tsirkin Signed-off-by: Amos Kong Signed-off-by: Orit Wasserman Hi Orit, H

Re: [Qemu-devel] [PATCH v6 08/13] m25p80: Initial implementation of SPI flash device

2012-09-19 Thread Peter Crosthwaite
On Thu, Sep 20, 2012 at 4:25 AM, Blue Swirl wrote: > On Tue, Sep 18, 2012 at 2:11 AM, Peter A. G. Crosthwaite >> +int64_t dirty_page; >> + >> +uint64_t waddr; >> +int write_enable; >> + >> +char *part_name; > > With 'const char *' here.. > >> +const FlashPartInfo *pi; >> + >> +

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-19 Thread HATAYAMA Daisuke
From: Luiz Capitulino Subject: Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it? Date: Wed, 19 Sep 2012 10:23:26 -0300 > On Wed, 19 Sep 2012 11:26:51 +0900 (JST) > HATAYAMA Daisuke wrote: > >> From: Wen Congyang >> Subject: Re: [Qemu-devel] qmp: dump-guest-memo

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread Max Filippov
On Wed, Sep 19, 2012 at 11:53 PM, Richard Henderson wrote: > On 09/19/2012 11:30 AM, Peter Maydell wrote: >> ...but on the other hand that ought to work for PPC too, so >> presumably my analysis is wrong somewhere. > > It isn't. It's a target-xtensa bug. > >> OP: >> 0xd0079cff >> movi_i32

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-19 Thread Muli Ben-Yehuda
On Tue, Sep 18, 2012 at 03:08:40PM +0200, Jan Kiszka wrote: > On 2012-09-18 14:50, GaoYi wrote: > > Hi Jan, > > > >I have followed a previous thread about ELI proposed by Abel Gordon, > > http://www.spinics.net/lists/kvm/msg73907.html. > >I wonder whether this mechanism will be incorporat

[Qemu-devel] [PATCH] linux-user: Add naive implementation of capget() syscall

2012-09-19 Thread Karol Lewandowski
libcap, library used to manipulate posix file capabilities uses getcap() to query version of capabilities supported by running kernel. Information obtained from this syscall is then used to initialize data structures that can be used to set process or/and file capabilities. Providing capget() alon

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-19 Thread Abel Gordon
> It's imperfect as you need to dedicate a core to pure guest-mode load > and cannot run userspace on that core (cannot walk through > userspace-based device models e.g.). That's not correct. For the evaluation, we dedicated a core for each guest to maximize the performance but this is not a requ

Re: [Qemu-devel] Fw: Qemu-ga : Guest Agent : Win 2008-64bit not working

2012-09-19 Thread Pengfei Hu
I found the same problem occur at Win7. At vioserial\app\device.app: BOOL CDevice::Init(BOOL ovrl) { PWCHAR DevicePath = NULL; if ((DevicePath = GetDevicePath((LPGUID)&GUID_VIOSERIAL_PORT)) != NULL) { m_hDevice = CreateFile(DevicePath, GENERIC_WRITE

Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd

2012-09-19 Thread Alon Ziv
Jan Kiszka siemens.com> writes: > What would be the advantage of timerfd over select? On Linux, both use > hrtimers (and low slack for RT processes). I'm starting to like the > select/WaitForMultipleObjects pattern as it would allow to consolidate > over basically two versions of timers and simpli

[Qemu-devel] [Bug 1052857] [NEW] qemu-user compiled static for ppc fails

2012-09-19 Thread Erik de Castro Lopo
Public bug reported: On debian I used debootstrap to set up a powerpc chroot. If I then copy in a statically linked qemu-user ppc binary it will work for some commands in the chroot and fail for others. Steps to reproduce: host$ mkdir powerpc host$ sudo debootstrap --arch=powerpc --foreign wheezy

Re: [Qemu-devel] [PATCH v3 08/10] target-xtensa: implement FP0 conversions

2012-09-19 Thread Max Filippov
On Thu, Sep 20, 2012 at 1:59 AM, Richard Henderson wrote: > On 09/18/2012 05:23 PM, Max Filippov wrote: >> +uint32_t HELPER(ftoi)(float32 v, uint32_t rounding_mode, uint32_t scale) >> +{ >> +float_status fp_status = {0}; >> + >> +set_float_rounding_mode(rounding_mode, &fp_status); >> +

Re: [Qemu-devel] [PATCH v3 08/10] target-xtensa: implement FP0 conversions

2012-09-19 Thread Richard Henderson
On 09/18/2012 05:23 PM, Max Filippov wrote: > +uint32_t HELPER(ftoi)(float32 v, uint32_t rounding_mode, uint32_t scale) > +{ > +float_status fp_status = {0}; > + > +set_float_rounding_mode(rounding_mode, &fp_status); > +return float32_to_int32( > +float32_scalbn(v, scale, &f

Re: [Qemu-devel] [PATCH 9/9] tcg: remove #ifdef #endif around TCGOpcode tests

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > Commit 25c4d9cc changed all TCGOpcode enums to be available, so we don't > need to #ifdef #endif the one that are available only on some targets. > This makes the code easier to read. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 8/9] tcg/optimize: prefer the "op a, a, b" form for commutative ops

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > The "op a, a, b" form is better handled on non-RISC host than the "op > a, b, a" form, so swap the arguments to this form when possible, and > when b is not a constant. > > This reduces the number of generated instructions by a tiny bit. > > Signed-

Re: [Qemu-devel] [PATCH 7/9] tcg/optimize: further optimize brcond/setcond

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > When both arguments of brcond/setcond are the same or when one of > the two values is a constant equal to zero, it's possible to do > further optimizations. This helps the computation of carry flags > when one of the two args is 0. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 6/9] tcg/optimize: optimize "op r, a, a => movi r, 0"

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > +/* Simplify expression for "op r, a, a => movi r, 0" cases */ > +switch (op) { > +CASE_OP_32_64(andc): > +CASE_OP_32_64(sub): > +CASE_OP_32_64(xor): For completeness, nand, orc, eqv r, a, a -> -1. Reviewed-by

Re: [Qemu-devel] [PATCH 5/9] tcg/optimize: optimize "op r, a, a => mov r, a"

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > Now that we can easily detect all copies, we can optimize the > "op r, a, a => mov r, a" case a bit more. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 4/9] tcg/optimize: do copy propagation for all operations

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > It is possible to do copy propagation for all operations, even the ones > that have side effects or clobber arguments (it only concerns input > arguments). That said, the call operation should be handled differently > due to the variable number of arg

Re: [Qemu-devel] [PATCH 3/9] tcg/optimizer: rework copy progagation

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > The copy propagation pass tries to keep track of what is a copy of what > and what has copy of what, and in addition it keep a circular list of > of all the copies. Unfortunately this doesn't fully work: a mov from > a temp which has a state "COPY" ch

Re: [Qemu-devel] [PATCH 2/9] tcg/optimizer: check types in copy propagation

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > The copy propagation doesn't check the types of the temps during copy > propagation. However TCG is using the mov_i32 for the i64 to i32 > conversion and thus the two are not equivalent. > > With this patch tcg_opt_gen_mov() doesn't consider two temp

Re: [Qemu-devel] [PATCH v3 05/17] target-i386: Add x86_set_hyperv.

2012-09-19 Thread Don Slutz
On 09/19/12 15:32, Eduardo Habkost wrote: On Mon, Sep 17, 2012 at 10:00:55AM -0400, Don Slutz wrote: This is used to set the cpu object's hypervisor level to the default for Microsoft's Hypervisor. Signed-off-by: Don Slutz --- target-i386/cpu.c | 10 ++ 1 files changed, 10 insert

Re: [Qemu-devel] [PATCH 1/9] tcg/optimizer: remove TCG_TEMP_ANY

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:00 PM, Aurelien Jarno wrote: > TCG_TEMP_ANY has no different meaning than TCG_TEMP_UNDEF, so use > the later instead. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread Richard Henderson
On 09/19/2012 01:05 PM, Peter Maydell wrote: > I notice tcg/README doesn't actually mention this restriction > on goto_tb, incidentally. Nor does it mention that only indicies 0 and 1 are valid. I.e. no use of goto_tb $2 for multi-way branches. > (I wonder if there are enough easily checkable and

Re: [Qemu-devel] [PATCH] pflash: Avoid warnings from coverity

2012-09-19 Thread Stefan Weil
Am 19.09.2012 18:45, schrieb Peter Maydell: On 19 September 2012 17:41, Stefan Weil wrote: hw/pflash_cfi01.c:209: check_return: Calling function "bdrv_write" without checking return value (as is done elsewhere 35 out of 37 times). hw/pflash_cfi02.c:144: unterminated_default: The default case

Re: [Qemu-devel] [PATCH 02/12] monitor: add Error * argument to monitor_get_fd

2012-09-19 Thread Luiz Capitulino
On Wed, 19 Sep 2012 16:31:05 +0200 Paolo Bonzini wrote: > Differentiate monitor_get_fd and monitor_handle_fd_param by doing > correct error propagation in the former and its callers. > > Signed-off-by: Paolo Bonzini > --- > dump.c| 5 +++-- > monitor.c | 9 ++--- > monitor.h | 2 +- >

[Qemu-devel] [PATCH 0/9] tcg/optimize: rework copy propagation

2012-09-19 Thread Aurelien Jarno
This patch series rework the copy propagation in order to generate better code. The first two patches are cleanup and bug fixes, the third patch is the heart of the series, and the remaining ones are small optimizations using the new copy propagation. I have measured a decrease of the generated

Re: [Qemu-devel] [PATCH 01/12] monitor: use monitor_handle_fd_param for non-Error-friendly users of named fds

2012-09-19 Thread Luiz Capitulino
On Wed, 19 Sep 2012 16:31:04 +0200 Paolo Bonzini wrote: > monitor_handle_fd_param and monitor_get_fd are mostly the same, except > that monitor_handle_fd_param does error reporting wrong. Use it in all > other places that do it wrong, instead of reinventing it. Hmm, why do we want to do this?

[Qemu-devel] [PATCH 2/9] tcg/optimizer: check types in copy propagation

2012-09-19 Thread Aurelien Jarno
The copy propagation doesn't check the types of the temps during copy propagation. However TCG is using the mov_i32 for the i64 to i32 conversion and thus the two are not equivalent. With this patch tcg_opt_gen_mov() doesn't consider two temps with different types as copies anymore. So far it see

[Qemu-devel] [PATCH 5/9] tcg/optimize: optimize "op r, a, a => mov r, a"

2012-09-19 Thread Aurelien Jarno
Now that we can easily detect all copies, we can optimize the "op r, a, a => mov r, a" case a bit more. Signed-off-by: Aurelien Jarno --- tcg/optimize.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index a58de3b..cfee690 100644 --- a/tcg/

[Qemu-devel] [PATCH 1/9] tcg/optimizer: remove TCG_TEMP_ANY

2012-09-19 Thread Aurelien Jarno
TCG_TEMP_ANY has no different meaning than TCG_TEMP_UNDEF, so use the later instead. Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 9da333c..ca81198 100644 --- a/tcg/optimize

Re: [Qemu-devel] [PATCH 0/3] Intruduce qemu-ga-client

2012-09-19 Thread Luiz Capitulino
On Fri, 14 Sep 2012 21:44:19 +0900 Ryota Ozaki wrote: > This patch series adds qemu-ga-client that is a command line > script to use guest agent functions easily. Applied to qmp branch, thanks. > > Ryota Ozaki (3): > Make negotiation optional in QEMUMonitorProtocol > Support settimeout in

Re: [Qemu-devel] [PATCH v2] target-mips: Use TCG registers for the FPU.

2012-09-19 Thread Aurelien Jarno
On Tue, Sep 18, 2012 at 11:04:15PM -0700, Richard Henderson wrote: > With normal FP, this doesn't have much affect on the generated code, > because most of the FP operations are not CONST/PURE, and so we spill > registers in about the same frequency as the explicit load/stores. > > But with Loongs

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread Peter Maydell
On 19 September 2012 20:53, Richard Henderson wrote: > On 09/19/2012 11:30 AM, Peter Maydell wrote: >> ...but on the other hand that ought to work for PPC too, so >> presumably my analysis is wrong somewhere. > > It isn't. It's a target-xtensa bug. > There are two instances of goto_tb $0 in here

[Qemu-devel] [PATCH 3/9] tcg/optimizer: rework copy progagation

2012-09-19 Thread Aurelien Jarno
The copy propagation pass tries to keep track of what is a copy of what and what has copy of what, and in addition it keep a circular list of of all the copies. Unfortunately this doesn't fully work: a mov from a temp which has a state "COPY" changes it into a state "HAS_COPY". Later when this temp

[Qemu-devel] [PATCH 8/9] tcg/optimize: prefer the "op a, a, b" form for commutative ops

2012-09-19 Thread Aurelien Jarno
The "op a, a, b" form is better handled on non-RISC host than the "op a, b, a" form, so swap the arguments to this form when possible, and when b is not a constant. This reduces the number of generated instructions by a tiny bit. Signed-off-by: Aurelien Jarno --- tcg/optimize.c |5 - 1

[Qemu-devel] [PATCH 7/9] tcg/optimize: further optimize brcond/setcond

2012-09-19 Thread Aurelien Jarno
When both arguments of brcond/setcond are the same or when one of the two values is a constant equal to zero, it's possible to do further optimizations. This helps the computation of carry flags when one of the two args is 0. Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 121 ++

[Qemu-devel] [PATCH 9/9] tcg: remove #ifdef #endif around TCGOpcode tests

2012-09-19 Thread Aurelien Jarno
Commit 25c4d9cc changed all TCGOpcode enums to be available, so we don't need to #ifdef #endif the one that are available only on some targets. This makes the code easier to read. Signed-off-by: Aurelien Jarno --- tcg/tcg.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-)

[Qemu-devel] [PATCH 4/9] tcg/optimize: do copy propagation for all operations

2012-09-19 Thread Aurelien Jarno
It is possible to do copy propagation for all operations, even the ones that have side effects or clobber arguments (it only concerns input arguments). That said, the call operation should be handled differently due to the variable number of arguments. Signed-off-by: Aurelien Jarno --- tcg/optim

[Qemu-devel] [PATCH 6/9] tcg/optimize: optimize "op r, a, a => movi r, 0"

2012-09-19 Thread Aurelien Jarno
Now that it's possible to detect copies, we can optimize the case the "op r, a, a => movi r, 0". This helps the computation of overflow flags when one of the two args is 0. Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 17 + 1 file changed, 17 insertions(+) diff --git a/t

Re: [Qemu-devel] directory hierarchy

2012-09-19 Thread Blue Swirl
On Wed, Sep 19, 2012 at 12:54 PM, Avi Kivity wrote: > On 09/14/2012 10:51 PM, Blue Swirl wrote: >>> >>> exec: >> >> These files need cleanup so that TCG code gets into tcg/. Maybe also >> TB and CPUTLB handling. > > Some of that could be done by adding a separate MemoryListener for tcg. But the T

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread Richard Henderson
On 09/19/2012 11:30 AM, Peter Maydell wrote: > ...but on the other hand that ought to work for PPC too, so > presumably my analysis is wrong somewhere. It isn't. It's a target-xtensa bug. > OP: > 0xd0079cff > movi_i32 tmp0,$0xd0079cff > movi_i32 tmp1,$0x2 > movi_i32 tmp2,$0x1 > movi_i3

Re: [Qemu-devel] [PATCH v2 0/3] target-mips: MIPS_DEBUG cleanup

2012-09-19 Thread Aurelien Jarno
On Tue, Sep 18, 2012 at 09:55:31PM -0700, Richard Henderson wrote: > Patch set available at > > git://repo.or.cz/qemu/rth.git rth/mips/next > > The third patch is updated to avoid multiple copies, as suggested. > > > r~ > > > Richard Henderson (3): > target-mips: Set opn in gen_ldst_multi

Re: [Qemu-devel] [PATCH] target-mips: Implement Loongson Multimedia Instructions

2012-09-19 Thread Aurelien Jarno
On Tue, Sep 18, 2012 at 09:59:44PM -0700, Richard Henderson wrote: > Implements all of the COP2 instructions except for the S > family of comparisons. The documentation is unclear for those. > > Signed-off-by: Richard Henderson > --- > > It turns out that the previous patch was totally independ

Re: [Qemu-devel] [PATCH] hw/pflash_cfi0[12]: Use host-utils.h ctz32()

2012-09-19 Thread Aurelien Jarno
On Tue, Sep 18, 2012 at 02:53:42PM +0100, Peter Maydell wrote: > Drop the private reimplementation of ctz32() from pflash_cfi0[12] > in favour of using the standard version from host-utils.h. > > Signed-off-by: Peter Maydell > --- > hw/pflash_cfi01.c | 37 +

Re: [Qemu-devel] [PATCH v3 05/17] target-i386: Add x86_set_hyperv.

2012-09-19 Thread Eduardo Habkost
On Mon, Sep 17, 2012 at 10:00:55AM -0400, Don Slutz wrote: > This is used to set the cpu object's hypervisor level to the default for > Microsoft's Hypervisor. > > Signed-off-by: Don Slutz > --- > target-i386/cpu.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff

Re: [Qemu-devel] [PATCH 04/12] qapi: add "unix" to the set of reserved words

2012-09-19 Thread Blue Swirl
On Wed, Sep 19, 2012 at 4:02 PM, Paolo Bonzini wrote: > Il 19/09/2012 17:58, Paolo Bonzini ha scritto: >> Il 19/09/2012 17:46, Peter Maydell ha scritto: >>> On 19 September 2012 15:31, Paolo Bonzini wrote: It is #defined to 1. Signed-off-by: Paolo Bonzini --- scripts/qa

Re: [Qemu-devel] [PATCH RFC] hw/grlib: SMP support added to LEON interrupt controller

2012-09-19 Thread Blue Swirl
On Wed, Sep 19, 2012 at 3:30 PM, Ronald Hecht wrote: > This patch adds SMP support to the LEON SPARC interrupt controller. > I don't like that CPU status (halted/not halted) is accessed directly > from the interrupt controller. How can this be implemented more elegant? > Ideally the CPUSPARCState

Re: [Qemu-devel] [PATCH 0/5] tcg: movcond

2012-09-19 Thread Richard Henderson
On 09/19/2012 12:07 PM, Blue Swirl wrote: > It looks like Sparc64 version should be similar to i386 one, cmp + movcc. Yes. We should leave that til after tcg-sparc branch is merged, please. r~

Re: [Qemu-devel] [PATCH 0/5] tcg: movcond

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 9:11 PM, Aurelien Jarno wrote: > On Tue, Sep 18, 2012 at 07:23:55AM -0700, Richard Henderson wrote: >> As recently discussed, with the optional fallback to setcond. >> >> I include a patch to target-alpha to test correctness both >> before and after implementing the opcode

[Qemu-devel] [PATCH V10 5/8] hw/cirrus_vga.c: replace register_ioport*

2012-09-19 Thread Julien Grall
This patch replaces all register_ioport* with portio_*. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/cirrus_vga.c | 48 1 files changed, 28 insertions(+), 20 deletions(-) diff --git a/hw/cirrus_vga.c

Re: [Qemu-devel] [PATCH] Added more entries to the LEON processor configuration register

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 1:29 PM, Ronald Hecht wrote: > Signed-off-by: Ronald Hecht > --- > target-sparc/helper.h |1 + > target-sparc/ldst_helper.c |6 ++ > target-sparc/translate.c | 10 +++--- > 3 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/target-

[Qemu-devel] [PATCH V10 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-19 Thread Julien Grall
This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/acpi_piix4.c | 154 +-- 1 files changed, 116 insertions(+), 38 deletions(-) diff --git

[Qemu-devel] [PATCH V10 7/8] hw/pc.c: replace register_ioport*

2012-09-19 Thread Julien Grall
This patch replaces all register_ioport* with portio_* or isa_register_portio_list. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/pc.c | 49 - 1 files changed, 40 insertions(+), 9 deletions(-) diff --gi

Re: [Qemu-devel] [RFC PATCH 10/16] qcow2: Delay the COW

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 11:40 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/qcow2-cluster.c | 29 + > block/qcow2.c | 31 --- > block/qcow2.h | 10 ++ > 3 files changed, 67 insertions(+), 3 de

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 9:51 AM, Gerd Hoffmann wrote: > This patch adds a mmio bar to the qemu standard vga which allows to > access the standard vga registers and bochs dispi interface registers > via mmio. > > Cc: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann > --- > hw/vga-pci.c |

[Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport*

2012-09-19 Thread Julien Grall
This patch replaces all register_ioport* by a MemorySection. It permits to use the new Memory stuff like listener. Moreover, the PCI is added as an argument for apm_init, so we can register IO inside the pci IO address space. Signed-off-by: Julien Grall --- hw/acpi_piix4.c |2 +- hw/apm.c

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 7:17 AM, Gerd Hoffmann wrote: > Display works, requires truecolor framebuffer with 16 or 32 bpp on the > host. 32bpp is recommended. The framebuffer is used as-is, qemu > doesn't try to switch modes. With LCD displays mode switching is pretty > pointless IMHO, also it wo

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread Richard Henderson
On 09/19/2012 11:30 AM, Peter Maydell wrote: > On 19 September 2012 19:01, Richard Henderson wrote: >> On 09/19/2012 10:51 AM, Aurelien Jarno wrote: >>> That said it is not a valid reason to not keep the value during >>> re-translation, as it means the TB will exit instead of linking to >>> the ne

Re: [Qemu-devel] [PATCH v6 11/13] xilinx_spips: Xilinx Zynq SPI cntrlr device model

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 2:11 AM, Peter A. G. Crosthwaite wrote: > Added device model for the Xilinx Zynq SPI controller (SPIPS). > > Signed-off-by: Peter A. G. Crosthwaite > --- > > hw/arm/Makefile.objs |1 + > hw/xilinx_spips.c| 352 > ++

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread Peter Maydell
On 19 September 2012 19:01, Richard Henderson wrote: > On 09/19/2012 10:51 AM, Aurelien Jarno wrote: >> That said it is not a valid reason to not keep the value during >> re-translation, as it means the TB will exit instead of linking to >> the next one. The consequences are only the performance.

[Qemu-devel] [PATCH V10 8/8] hw/dma.c: replace register_ioport*

2012-09-19 Thread Julien Grall
This patch replaces all register_ioport* be the new memory API functions. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/dma.c | 108 + 1 files changed, 72 insertions(+), 36 deletions(-) diff

Re: [Qemu-devel] [PATCH v6 08/13] m25p80: Initial implementation of SPI flash device

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 2:11 AM, Peter A. G. Crosthwaite wrote: > Added device model for m25p80 style SPI flash family. > > Signed-off-by: Peter A. G. Crosthwaite > --- > changed from v4: > Added write-1 flag (EEPROM mode). > n25q128 table entry indentation fix. > updated for new SSI interface. >

Re: [Qemu-devel] [PATCH v6 08/13] m25p80: Initial implementation of SPI flash device

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 2:11 AM, Peter A. G. Crosthwaite wrote: > Added device model for m25p80 style SPI flash family. > > Signed-off-by: Peter A. G. Crosthwaite > --- > changed from v4: > Added write-1 flag (EEPROM mode). > n25q128 table entry indentation fix. > updated for new SSI interface. >

[Qemu-devel] [PATCH V10 3/8] smb: replace_register_ioport*

2012-09-19 Thread Julien Grall
This patch fix smb_ioport_* to be compliant with read/write memory callback. Moreover it replaces all register_ioport* which use theses functions by the new Memory API. Signed-off-by: Julien Grall --- hw/acpi_piix4.c | 18 -- hw/pm_smbus.c |7 --- hw/pm_smbus.h |

Re: [Qemu-devel] [PATCH] Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs

2012-09-19 Thread Jan Kiszka
On 2012-09-19 19:49, Auld, Will wrote: > From 9d5201975d2c9da4da8a945fcd9531c9fb2073c0 Mon Sep 17 00:00:00 2001 > From: Will Auld > Date: Wed, 12 Sep 2012 18:31:41 -0700 > Subject: [PATCH] Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs > > CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is

[Qemu-devel] [PATCH V10 6/8] hw/serial.c: replace register_ioport*

2012-09-19 Thread Julien Grall
This patch replaces all register_ioport* with a MemoryRegion. It permits to use the new Memory stuff like listener. For more flexibility, the IO address space is passed as an argument. Signed-off-by: Julien Grall --- hw/mips_mipssim.c |3 ++- hw/pc.h |2 +- hw/serial.c |

[Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-09-19 Thread Julien Grall
This is the tenth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions doesn't allow to use Memory Listener on it. Modifications between V1 and V2: - Remove the use of get_system_io. Instead of use isa and

[Qemu-devel] [PATCH V10 1/8] isa: add isa_address_space_io

2012-09-19 Thread Julien Grall
This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall --- hw/isa-bus.c |9 + hw/isa.h |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/is

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-19 Thread Stefano Stabellini
On Wed, 19 Sep 2012, Gerd Hoffmann wrote: > Stop reinventing the wheel, use the pixman library for raster ops. > Also add setdata callback. > > Signed-off-by: Gerd Hoffmann > --- > configure | 12 > ui/fbdev.c | 182 > +--- > 2 fi

Re: [Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-09-19 Thread Luiz Capitulino
On Wed, 12 Sep 2012 19:57:26 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > hmp.c | 42 ++ > monitor.c | 18 ++ > monitor.h |2 ++ > 3 files changed, 62 insertions(+), 0 deletions(-) > > diff --git a/hmp.c b/hmp.c > index

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-19 Thread Stefano Stabellini
On Wed, 19 Sep 2012, Gerd Hoffmann wrote: > +/* */ > +/* rendering*/ > + > +static void fbdev_render(DisplayState *ds, int x, int y, int w, int h) > +{ > +uint8_t *ds

Re: [Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-09-19 Thread Luiz Capitulino
On Wed, 12 Sep 2012 19:57:24 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > hmp-commands.hx | 23 ++ > hmp.c| 19 +++ > hmp.h|1 + > qapi-schema.json | 69 > ++ > qemu-char.c

Re: [Qemu-devel] [PATCH 15/12] hmp: add NBD server commands

2012-09-19 Thread Eric Blake
On 09/19/2012 08:31 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hmp-commands.hx | 29 + > hmp.c | 55 +++ > hmp.h | 2 ++ > 3 file modificati, 86 inserzioni(+) > > diff --git

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread Richard Henderson
On 09/19/2012 10:51 AM, Aurelien Jarno wrote: > That said it is not a valid reason to not keep the value during > re-translation, as it means the TB will exit instead of linking to > the next one. The consequences are only the performance. We still have the problem of when is the goto_tb link ini

Re: [Qemu-devel] Macvtap bug: contractor wanted

2012-09-19 Thread David Miller
Solicitation of paid services or employment is absolutely not appropriate on the vger.kernel.org mailing lists. Please do not do this ever again.

Re: [Qemu-devel] [PATCH v1 0/6] Microblaze Patches

2012-09-19 Thread Edgar E. Iglesias
On Mon, Sep 17, 2012 at 06:47:30PM +1000, Peter A. G. Crosthwaite wrote: > Misc microblaze patches. I've applied this (including your indentation fix to patch 5) Thanks, Edgar

  1   2   3   >