[Qemu-devel] buildbot failure in qemu on xen_x86_64_debian_6_0

The Buildbot has detected a new failure on builder xen_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen_x86_64_debian_6_0/builds/356 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Re

[Qemu-devel] buildbot failure in qemu on xen_i386_debian_6_0

The Buildbot has detected a new failure on builder xen_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen_i386_debian_6_0/builds/357 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason

[Qemu-devel] buildbot failure in qemu on trivial-patches_i386_debian_6_0

The Buildbot has detected a new failure on builder trivial-patches_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/trivial-patches_i386_debian_6_0/builds/356 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Bu

[Qemu-devel] buildbot failure in qemu on trivial-patches_x86_64_debian_6_0

The Buildbot has detected a new failure on builder trivial-patches_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/trivial-patches_x86_64_debian_6_0/builds/356 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for thi

[Qemu-devel] buildbot failure in qemu on qmp_x86_64_debian_6_0

The Buildbot has detected a new failure on builder qmp_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_x86_64_debian_6_0/builds/355 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Re

[Qemu-devel] buildbot failure in qemu on qmp_i386_debian_6_0

The Buildbot has detected a new failure on builder qmp_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_i386_debian_6_0/builds/355 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason

Re: [Qemu-devel] Is the return address of get_page_addr_code guest physical address?

On Fri, Aug 10, 2012 at 10:06 PM, Peter Maydell wrote: > On 10 August 2012 19:53, Steven wrote: >> On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell >> wrote: >>> On 10 August 2012 03:11, Steven wrote: The function definition has a return address type tb_page_addr_t. tb_page_addr_t get_

Re: [Qemu-devel] [PATCH] Fix QEMU

On 10 August 2012 20:48, Stefan Weil wrote: > One more... No problem with the patch but your commit message summary implies a rather wider effect than the patch actually has :-) -- PMM

Re: [Qemu-devel] Is the return address of get_page_addr_code guest physical address?

On 10 August 2012 19:53, Steven wrote: > On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell > wrote: >> On 10 August 2012 03:11, Steven wrote: >>> The function definition has a return address type tb_page_addr_t. >>> tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr) >>> >>> I

Re: [Qemu-devel] [PATCH 09/15] memory: prepare flatview and radix-tree for rcu style access

On Wed, Aug 8, 2012 at 5:41 PM, Avi Kivity wrote: > On 08/08/2012 09:25 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Flatview and radix view are all under the protection of pointer. >> And this make sure the change of them seem to be atomic! >> >> The mr accessed by radix-tree leaf or flat

Re: [Qemu-devel] [PATCH v5 08/15] ssd0323: abort() instead of exit(1) on error.

On Mon, Aug 6, 2012 at 7:41 PM, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> To be more consistent with the newer ways of error signalling. That and >> SIGABT >> is easier to debug with than exit(1). >> >> Signed-off-by: Peter A. G. Crosthwaite > > Reviewed

[Qemu-devel] [PATCH] json-parser: don't replicate tokens at each level of recursion

Currently, when parsing a stream of tokens we make a copy of the token list at the beginning of each level of recursion so that we do not modify the original list in cases where we need to fall back to an earlier state. In the worst case, we will only read 1 or 2 tokens off the list before recursi

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

Hi Andreas, > > I find quilt patches easier to manage when I need to reorder them, > > revert, manually edit the diffs (that I routinely do), etc. Perhaps I'm > > just outdated, but that's the workflow I've found most efficient for me > > while not disturbing anyone else. I've used quilt pat

Re: [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep

On Fri, Aug 10, 2012 at 11:42 PM, Stefan Hajnoczi wrote: > On Fri, Aug 10, 2012 at 01:54:26PM +1000, Peter A. G. Crosthwaite wrote: >> The sizep arg is populated with the size of the loaded device tree. Since >> this >> is one of those informational "please populate" type arguments it should be >

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

On 08/10/2012 09:30 AM, Andreas Färber wrote: > OK, so you didn't retract them but Meador did comment: > >> > I submitted a patch to fix this issue and the FCR0 issue a few months back >> > [1]. >> > Andreas reviewed it, but the patch never got committed. >> > >> > [1] http://patchwork.ozlabs.o

Re: [Qemu-devel] [PATCH v2 0/2] Probe the guest memory space when using -R

Ping ^ 2. On 08/01/2012 01:47 PM, Meador Inge wrote: > Ping. > > On 07/26/2012 09:50 PM, Meador Inge wrote: >> Hi, >> >> This patch series fixes an issue that was discussed here [1] where using -R >> can cause QEMU to fail to setup the guest address space because the guest >> base >> validation

[Qemu-devel] [PATCH] srp: Don't use QEMU_PACKED for single elements of a structured type

QEMU_PACKED results in a MinGW compiler warning when it is used for single structure elements: warning: 'gcc_struct' attribute ignored Using QEMU_PACKED for the whole structure avoids the compiler warning without changing the memory layout. Signed-off-by: Stefan Weil --- hw/srp.h |8 --

[Qemu-devel] [PATCH] Spelling fixes in comments and documentation

These wrong spellings were detected by codespell: * successully -> successfully * alot -> a lot * wanna -> want to * infomation -> information * occured -> occurred Signed-off-by: Stefan Weil --- docs/specs/ppc-spapr-hcalls.txt |2 +- docs/usb2.txt |4 ++-- hw/xen_

[Qemu-devel] [PATCH] Fix spelling (licenced -> licensed) in GPL

The patch also fixes the case of "written". Signed-off-by: Stefan Weil --- hw/imx_avic.c |4 ++-- hw/imx_timer.c |4 ++-- hw/kzm.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/imx_avic.c b/hw/imx_avic.c index 4f010e8..b1a8fe6 100644 --- a/hw/imx_avi

[Qemu-devel] [PATCH] Spelling fix in comment (peripherans -> peripherals)

Signed-off-by: Stefan Weil --- hw/versatilepb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/versatilepb.c b/hw/versatilepb.c index 4fd5d9b..7a92034 100644 --- a/hw/versatilepb.c +++ b/hw/versatilepb.c @@ -162,7 +162,7 @@ static int vpb_sic_init(SysBusDevice *dev) /*

[Qemu-devel] [PATCH] docs: Fix spelling (propery -> property)

Signed-off-by: Stefan Weil --- docs/bootindex.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/bootindex.txt b/docs/bootindex.txt index 16083b3..803ebfc 100644 --- a/docs/bootindex.txt +++ b/docs/bootindex.txt @@ -1,4 +1,4 @@ -= Bootindex propery = += Bootindex prop

[Qemu-devel] [PATCH] vnc: Improve comment

It's still not good, but hopefully better than before. Signed-off-by: Stefan Weil --- ui/vnc-enc-zywrle.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h index 188e247..addee55 100644 --- a/ui/vnc-enc-zywrle.h +++ b/ui/vnc-enc-

[Qemu-devel] [PATCH] Fix QEMU

One more... Signed-off-by: Stefan Weil --- scripts/simpletrace.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py index 1e74e75..9fce4bb 100755 --- a/scripts/simpletrace.py +++ b/scripts/simpletrace.py @@ -71,7 +71,7 @@ def r

[Qemu-devel] [PATCH] w64: Fix compiler warning [-Wformat]

Glib2 uses __printf__ in macro G_GNUC_PRINTF for printf like functions. For MinGW, we want __gnu_printf__ because we use POSIX format specifiers instead of the MS format specifiers. Signed-off-by: Stefan Weil --- configure |2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/conf

Re: [Qemu-devel] [PATCH 28/35] error: drop unused functions

On 08/10/2012 11:44 AM, Luiz Capitulino wrote: > Besides of being unused, they operate on the current error format, s/ of// > which is going to be replaced soon. > -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Descriptio

[Qemu-devel] [PATCH 07/35] qerror: QError: drop file, linenr, func

They have never been fully used and conflict with future error improvements. Also makes qerror_report() a proper function, as there's no point in having it as a macro anymore. Signed-off-by: Luiz Capitulino --- qerror.c | 20 +++- qerror.h | 8 +--- 2 files changed, 4 inser

[Qemu-devel] [PATCH 16/35] qerror: drop QERR_SOCKET_CONNECT_IN_PROGRESS

Unused since last commit. Signed-off-by: Luiz Capitulino --- qerror.c | 4 qerror.h | 3 --- 2 files changed, 7 deletions(-) diff --git a/qerror.c b/qerror.c index 5d38428..452ec69 100644 --- a/qerror.c +++ b/qerror.c @@ -309,10 +309,6 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 17/35] block: block_int: include qerror.h

Several block/ files are relying on qerror.h being provided by qapi-types.h. Fix this, as a future commit will change qapi-types.h not to provide qerror.h. Signed-off-by: Luiz Capitulino --- block_int.h | 1 + 1 file changed, 1 insertion(+) diff --git a/block_int.h b/block_int.h index 6c1d9ca..

Re: [Qemu-devel] [PATCH 00/10] Quorum disk image corruption resiliency

Le Wednesday 08 Aug 2012 à 15:55:58 (+0100), Stefan Hajnoczi a écrit : > On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote: > > This patchset create a block driver implementing a quorum using three qemu > > disk > > images. Writes are mirrored on the three files. > > For the reading part the thr

[Qemu-devel] [PATCH 11/35] qmp: query-block: add 'encryption_key_missing' field

Signed-off-by: Luiz Capitulino --- block.c | 1 + qapi-schema.json | 9 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 24323c1..016858b 100644 --- a/block.c +++ b/block.c @@ -2445,6 +2445,7 @@ BlockInfoList *qmp_query_block(Error **errp)

[Qemu-devel] [PATCH 32/35] error, qerror: pass desc string to error calls

This commit changes all QERR_ macros to contain a human message (ie. the desc string found in qerr_table[]) instead of a json dictionary in string format. Before this commit, error_set() and qerror_report() would receive a json dictionary in string format and build a qobject from it. Now, both fun

[Qemu-devel] [PATCH 30/35] qemu-ga: switch to the new error format on the wire

IMPORTANT: this BREAKS qemu-ga compatibility for the error response. Instead of returning something like: { "error": { "class": "InvalidParameterValue", "data": {"name": "mode", "expected": "halt|powerdown|reboot" } } } qemu-ga now returns: { "error": { "class": "GenericError",

[Qemu-devel] [PATCH 33/35] qerror: drop qerror_table and qerror_format()

They are unused since last commit. Signed-off-by: Luiz Capitulino --- qerror.c | 400 --- qerror.h | 7 -- 2 files changed, 407 deletions(-) diff --git a/qerror.c b/qerror.c index dda1427..ccc52be 100644 --- a/qerror.c +++ b/qerror.c

[Qemu-devel] [PATCH 08/35] qerror: qerror_format(): return an allocated string

Simplifies current and future users. Signed-off-by: Luiz Capitulino --- error.c | 5 + qerror.c | 10 -- qerror.h | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/error.c b/error.c index 58f55a0..3a62592 100644 --- a/error.c +++ b/error.c @@ -65,10 +65,7 @@

[Qemu-devel] [PATCH 18/35] hmp: hmp.h: include qdict.h

hmp.h is relying on qdict.h being provided by qapi-types.h. Fix this, as a future commit will change qapi-types.h not to provide qdict.h. Signed-off-by: Luiz Capitulino --- hmp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/hmp.h b/hmp.h index 8d2b0d7..3275522 100644 --- a/hmp.h +++ b/hmp

[Qemu-devel] [PATCH 21/35] qapi: don't convert enum strings to lowercase

Next commit will introduce enum strings in camel case. Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 9b7da96..cf601ae 100644 --- a/scripts/qapi-types.py +++ b/script

[Qemu-devel] [PATCH 22/35] qapi-schema: add ErrorClass enum

Signed-off-by: Luiz Capitulino --- qapi-schema.json | 30 ++ 1 file changed, 30 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a62bf68..b513935 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3,6 +3,36 @@ # QAPI Schema ## +# @ErrorCl

[Qemu-devel] [PATCH 27/35] hmp: hmp_change(): use error_get_class()

The error_is_type() function is going to be dropped. Signed-off-by: Luiz Capitulino --- hmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index 54c37d7..9b44dfc 100644 --- a/hmp.c +++ b/hmp.c @@ -793,7 +793,8 @@ void hmp_change(Monitor *mon, const QDict *q

Re: [Qemu-devel] Is the return address of get_page_addr_code guest physical address?

On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell wrote: > On 10 August 2012 03:11, Steven wrote: >> The function definition has a return address type tb_page_addr_t. >> tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr) >> >> I am wondering is this address the guest physical

[Qemu-devel] [PATCH 25/35] qerror: add proper ErrorClass value for QERR_ macros

This commit replaces the place holder value for the ErrorClass argument with a proper ErrorClass value for all QERR_ macros. All current errors are mapped to GenericError, except for errors CommandNotFound, DeviceEncrypted, DeviceNotActive, DeviceNotFound, KVMMissingCap and MigrationExpected, whic

[Qemu-devel] [PATCH 03/35] qerror: QERR_DEVICE_ENCRYPTED: change error message

Match what HMP commands print on DeviceEncrypted errors. Signed-off-by: Luiz Capitulino --- qerror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qerror.c b/qerror.c index 082de98..de0a79e 100644 --- a/qerror.c +++ b/qerror.c @@ -81,7 +81,7 @@ static const QErrorStringTabl

[Qemu-devel] [PATCH 29/35] qmp: switch to the new error format on the wire

IMPORTANT: this BREAKS QMP's compatibility for the error response. This commit changes QMP's wire protocol to make use of the simpler error format introduced by previous commits. There are two important (and mostly incompatible) changes: 1. Almost all error classes have been replaced by Generic

[Qemu-devel] [PATCH 34/35] error, qerror: drop QDict member

Used to store error information, but it's unused now. Signed-off-by: Luiz Capitulino --- error.c | 4 qerror.c | 4 qerror.h | 1 - 3 files changed, 9 deletions(-) diff --git a/error.c b/error.c index 0e10373..1f05fc4 100644 --- a/error.c +++ b/error.c @@ -19,7 +19,6 @@ struct Err

[Qemu-devel] [PATCH 05/35] qerror: drop qerror_abort()

qerror_abort() depends on the 'file', 'func' and 'linenr' members of QError. However, these members are going to be dropped by the next commit, so let's drop qerror_abort() in favor of printing an error message to stderr plus a call to abort(). Signed-off-by: Luiz Capitulino --- qerror.c | 41 ++

[Qemu-devel] [PATCH 04/35] qerror: reduce public exposure

qerror will be dropped in a near future, let's reduce its public exposure by making functions only used in qerror.c static. Signed-off-by: Luiz Capitulino --- qerror.c | 10 +- qerror.h | 5 - 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/qerror.c b/qerror.c index

[Qemu-devel] [PATCH 15/35] migration: don't rely on any QERR_SOCKET_*

Use the in_progress argument for QERR_SOCKET_CONNECT_IN_PROGRESS. The other errors are handled the same by checking if the error is set and then calling migrate_fd_error() if it's. It's also necessary to change inet_connect_opts() not to set QERR_SOCKET_CONNECT_IN_PROGRESS. This error is only used

[Qemu-devel] [PATCH 19/35] qapi: qapi-types.h: don't include qapi/qapi-types-core.h

qapi-types.h needs only qemu-common.h. Including qapi-types-core.h causes problems when qerror.h or error.h includes qapi-types.h. Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-t

[Qemu-devel] [PATCH 06/35] qerror: avoid passing qerr pointer

Helps dropping/modifying qerror functions. Signed-off-by: Luiz Capitulino --- qerror.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/qerror.c b/qerror.c index 7cb7c12..e717496 100644 --- a/qerror.c +++ b/qerror.c @@ -346,10 +346,10 @@ static QErro

[Qemu-devel] [PATCH 20/35] qapi: generate correct enum names for camel case enums

An enum like GenericError in the schema, should generate GENERIC_ERROR and not GENERICERROR. Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 3ed9f04..9b7d

[Qemu-devel] [PATCH 12/35] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

This commit changes hmp_cont() to loop through all block devices and proactively set an encryption key for any encrypted device missing a key. This change is needed because QERR_DEVICE_ENCRYPTED is going to be dropped by a future commit. Signed-off-by: Luiz Capitulino --- hmp.c | 37 +++

Re: [Qemu-devel] [PATCH 2/2] cpu: for cpu-user and cpu-softmmu and make cpu-softmmu a child of DeviceState

Eduardo Habkost writes: > On Fri, Aug 10, 2012 at 12:00:44PM -0500, Anthony Liguori wrote: >> The line between linux-user and softmmu is not very well defined right now. >> linux-user really don't want to include devices and making CpuState a child >> of >> DeviceState would require pulling lots

Re: [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable

Eric Blake writes: > On 08/10/2012 10:04 AM, Anthony Liguori wrote: >> We've had a cycle to tweak. It is time to commit to supporting them. >> >> Signed-off-by: Anthony Liguori >> --- >> qapi-schema.json | 19 --- >> 1 files changed, 4 insertions(+), 15 deletions(-) >> >> d

[Qemu-devel] [PATCH 23/35] qerror: qerror_table: don't use C99 struct initializers

This allows for changing QERR_ macros to initialize two struct members at the same time. See next commit for more details. Signed-off-by: Luiz Capitulino --- qerror.c | 276 +++ qerror.h | 2 +- 2 files changed, 139 insertions(+), 139

[Qemu-devel] [PATCH 09/35] qerror: don't delay error message construction

Today, the error message is only constructed when it's used. This commit changes qerror to construct the error message when the error object is built (ie. when the error is reported). This eliminates the need of storing a pointer to qerror_table[], which will be dropped soon, and also simplifies t

[Qemu-devel] [PATCH v3 00/35]: add new error format

v3 o rebase on top of master o replace 'valid_encryption_key' with 'encryption_key_missing', fixes a bug found by Markus o minor changes (changelogs, white-space fix and others) Only the following patches have changed: o [PATCH 11/35] qmp: query-block: add 'encryption_key_missing' field

Re: [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable

On 08/10/2012 10:04 AM, Anthony Liguori wrote: > We've had a cycle to tweak. It is time to commit to supporting them. > > Signed-off-by: Anthony Liguori > --- > qapi-schema.json | 19 --- > 1 files changed, 4 insertions(+), 15 deletions(-) > > diff --git a/qapi-schema.json b/

[Qemu-devel] [PATCH 26/35] error: add error_get_class()

Signed-off-by: Luiz Capitulino --- error.c | 5 + error.h | 5 + 2 files changed, 10 insertions(+) diff --git a/error.c b/error.c index 648706a..2d34cde 100644 --- a/error.c +++ b/error.c @@ -64,6 +64,11 @@ bool error_is_set(Error **errp) return (errp && *errp); } +ErrorClass err

[Qemu-devel] [PATCH 24/35] error, qerror: add ErrorClass argument to error functions

The new argument is added to functions qerror_report() and error_set(). It's stored in Error and QError. qerror_report_err() is also updated to take care of it. The QERR_ macros are changed to contain a place holder value for the new argument, so that the value is used on all current calls to qerr

[Qemu-devel] [PATCH 31/35] error: drop error_get_qobject()/error_set_qobject()

error_get_qobject() is unused since last commit, error_set_qobject() has never been used. Also drops error_int.h. Signed-off-by: Luiz Capitulino --- error.c | 20 error_int.h | 28 qapi/qmp-dispatch.c | 1 - qemu-ga.c

[Qemu-devel] [PATCH 13/35] hmp_change(): don't access DeviceEncrypted's data

It's not needed. As the device name is already known, we can replace the duplicated password prompting code by monitor_read_block_device_key(). This overly simplifies hmp_change(). Signed-off-by: Luiz Capitulino --- hmp.c | 29 ++--- 1 file changed, 2 insertions(+), 27 d

[Qemu-devel] [PATCH 35/35] docs: writing-qmp-commands.txt: update error section

Add information about the new error format and improve the text a bit. Signed-off-by: Luiz Capitulino --- docs/writing-qmp-commands.txt | 47 +-- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/docs/writing-qmp-commands.txt b/docs/writing-q

[Qemu-devel] [PATCH 28/35] error: drop unused functions

Besides of being unused, they operate on the current error format, which is going to be replaced soon. Signed-off-by: Luiz Capitulino --- error.c | 48 error.h | 16 error_int.h | 1 - 3 files changed, 65 deletions(-) di

[Qemu-devel] [PATCH 10/35] error: don't delay error message construction

Today, the error message is only constructed when it's used. This commit changes that to construct the error message when the error object is built (ie. when the error is reported). This simplifies the Error object. Signed-off-by: Luiz Capitulino --- error.c | 8 +--- qerror.c | 4 +--- 2

[Qemu-devel] [Bug 965327] Re: virtio-pci: can't reserve io 0x0000-0x001f

I'm probably the only person in the world who has this setup (ppc full emu on win32) but if anyone else out there was following this it was fixed in qemu.org git and the solution was another __attribute__ ((packed)) versus __attribute__ ((gcc_struct, packed)) -mms-bitfield issue in spapr_pci.c. You

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

On Fri, 10 Aug 2012 19:17:22 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Fri, 10 Aug 2012 18:35:26 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > On Fri, 10 Aug 2012 09:56:11 +0200 > >> > Markus Armbruster wrote: > >> > > >> >> Revisite

Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

Le Tuesday 07 Aug 2012 à 20:30:09 (+), Blue Swirl a écrit : > On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c | 62 > > > > 1 file changed, 62 insertions(+) > > > > diff

[Qemu-devel] [PATCH 14/35] net: inet_connect(), inet_connect_opts(): add in_progress argument

It's used to indicate the special case where a valid file-descriptor is returned (ie. success) but the connection can't be completed w/o blocking. This is needed because QERR_SOCKET_CONNECT_IN_PROGRESS is not treated like an error and a future commit will drop it. Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 02/35] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg

Actually, renames it to 'object'. This must be what the original author meant to write, as there's no 'object' in the error's data member. Signed-off-by: Luiz Capitulino --- qerror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qerror.c b/qerror.c index 92c4eff..082de98 10

[Qemu-devel] [PATCH 01/35] monitor: drop unused monitor debug code

In the old QMP days, this code was used to find out QMP commands that might be calling monitor_printf() down its call chain. This is almost impossible to happen today, because the qapi converted commands don't even have a monitor object. Besides, it's been more than a year since I used this last t

Re: [Qemu-devel] Is the return address of get_page_addr_code guest physical address?

On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell wrote: > On 10 August 2012 03:11, Steven wrote: >> The function definition has a return address type tb_page_addr_t. >> tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr) >> >> I am wondering is this address the guest physical

[Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpu-definitions (v2)

Signed-off-by: Anthony Liguori --- v1 -> v2 - rename query-cpudefs -> query-cpu-definitions --- target-i386/cpu.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 880cfea..6d5d0d6 100644 --- a/target-i386/c

[Qemu-devel] [PATCH 04/11] qemu-iotests: Save some sed processes

Instead of building a huge pipeline, just pass all expressions to a single sed process. Suggested-by: Eric Blake Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/common.rc | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/test

[Qemu-devel] [PATCH 02/11] ahci: Fix ahci cdrom read corruptions for reads > 128k

From: Jason Baron While testing q35, which has its cdrom attached to the ahci controller, I found that the Fedora 17 install would panic on boot. The panic occurs while squashfs is trying to read from the cdrom. The errors are: [8.622711] SQUASHFS error: xz_dec_run error, data probably corru

[Qemu-devel] [PATCH 11/11] qemu-iotests: skip 039 with ./check -nocache

From: Stefan Hajnoczi When the qemu-io --nocache option is used the 039 test case cannot abort QEMU at a point where the image is dirty. Skip the test case. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/039 |1 + tests/qemu-iotests/common.rc | 14

[Qemu-devel] [PATCH 09/11] qcow2: mark image clean after repair succeeds

From: Stefan Hajnoczi The dirty bit is cleared after image repair succeeds in qcow2_open(). Move this into qcow2_check() so that all callers benefit from this behavior when fix mode is enabled. This is necessary so qemu-img check can call .bdrv_check() and mark the image clean. Signed-off-by: S

Re: [Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpudefs

On Fri, Aug 10, 2012 at 12:09:44PM -0500, Anthony Liguori wrote: > Eduardo Habkost writes: > > > On Fri, Aug 10, 2012 at 11:37:30AM -0500, Anthony Liguori wrote: > >> Eduardo Habkost writes: > >> >> > - add machine-type-specific cpudef compatibility changes? > >> >> > >> >> I think we've discus

[Qemu-devel] [PATCH 08/11] qed: mark image clean after repair succeeds

From: Stefan Hajnoczi The dirty bit is cleared after image repair succeeds in qed_open(). Move this into qed_check() so that all callers benefit from this behavior when fix=true. This is necessary so qemu-img check can call .bdrv_check() and mark the image clean. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 06/11] virtio-blk: disable write cache if not negotiated

From: Paolo Bonzini If the guest does not support flushes, we should run in writethrough mode. The setting is temporary until the next reset, so that for example the BIOS will run in writethrough mode while Linux will run with a writeback cache. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

Luiz Capitulino writes: > On Fri, 10 Aug 2012 18:35:26 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Fri, 10 Aug 2012 09:56:11 +0200 >> > Markus Armbruster wrote: >> > >> >> Revisited this one on review of v2, replying here for context. >> >> >> >> Luiz Capitulino

[Qemu-devel] [PATCH 10/11] block: add BLOCK_O_CHECK for qemu-img check

From: Stefan Hajnoczi Image formats with a dirty bit, like qed and qcow2, repair dirty image files upon open with BDRV_O_RDWR. Performing automatic repair when qemu-img check runs is not ideal because the bdrv_open() call repairs the image before the actual bdrv_check() call from qemu-img.c. Fi

Re: [Qemu-devel] [PATCH RFC for-1.2] arm: Move some ARM devices into libhw

Am 02.08.2012 15:48, schrieb Peter Maydell: > On 2 August 2012 02:16, Andreas Färber wrote: >> +hw-obj-$(CONFIG_STELLARIS_ENET) += stellaris_enet.o > > Why just this stellaris device and not the others? So, turns out there was an actual reason: CClibhw64/hw/stellaris.o In file included fr

[Qemu-devel] [PATCH 01/11] virtio-blk: fix use-after-free while handling scsi commands

From: Avi Kivity The scsi passthrough handler falls through after completing a request into the failure path, resulting in a use after free. Reproducible by running a guest with aio=native on a block device. Reported-by: Stefan Priebe Signed-off-by: Avi Kivity Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpudefs

Eduardo Habkost writes: > On Fri, Aug 10, 2012 at 11:37:30AM -0500, Anthony Liguori wrote: >> Eduardo Habkost writes: >> >> > - add machine-type-specific cpudef compatibility changes? >> >> >> >> I think we've discussed this in IRC. I don't think we need to worry >> >> about this. >> > >> > I

[Qemu-devel] [NOT RFC] target-i386: prepare for convertion to subclasses

crude attempt to show how to move out cpu_model string handling out of cpu.c and make CPU more suitable to converting into subclasses. Signed-off-by: Igor Mammedov --- target-i386/cpu.c| 83 target-i386/helper.c | 89 ++

Re: [Qemu-devel] [PATCH 2/2] cpu: for cpu-user and cpu-softmmu and make cpu-softmmu a child of DeviceState

On Fri, Aug 10, 2012 at 12:00:44PM -0500, Anthony Liguori wrote: > The line between linux-user and softmmu is not very well defined right now. > linux-user really don't want to include devices and making CpuState a child of > DeviceState would require pulling lots of stuff into linux-user. > > To

[Qemu-devel] [PULL 00/11] Block patches

The following changes since commit 3d1d9652978ac5a32a0beb4bdf6065ca39440d89: handle device help before accelerator set up (2012-08-09 19:53:01 +) are available in the git repository at: http://repo.or.cz/r/qemu/kevin.git for-anthony Avi Kivity (1): virtio-blk: fix use-after-free wh

Re: [Qemu-devel] [PATCH v8 7/7] block: Enable qemu_open/close to work with fd sets

On 08/10/2012 12:56 PM, Corey Bryant wrote: On 08/10/2012 12:34 PM, Kevin Wolf wrote: Am 10.08.2012 04:10, schrieb Corey Bryant: When qemu_open is passed a filename of the "/dev/fdset/nnn" format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within

[Qemu-devel] [PATCH 2/2] cpu: for cpu-user and cpu-softmmu and make cpu-softmmu a child of DeviceState

The line between linux-user and softmmu is not very well defined right now. linux-user really don't want to include devices and making CpuState a child of DeviceState would require pulling lots of stuff into linux-user. To solve this, we simply fork cpu-user and cpu-softmmu letting them evolve ind

[Qemu-devel] [PATCH 1/2] qdev: split up header so it can be used in cpu.h

Header file dependency is a frickin' nightmare right now. cpu.h tends to get included in our 'include everything' header files but qdev also needs to include those headers mainly for qdev-properties since it knows about CharDriverState and friends. We can solve this for now by splitting out qdev.

[Qemu-devel] [PATCH 0/2] cpu: make a child of DeviceState

This is just a rebase of this series that I posted back in June. Andreas had a different approach involving a #define but I think doing a full split ends up being nicer. For instance, the recently added thread information is only relevant to cpu-softmmu so we can limit that entirely to cpu-softmm

[Qemu-devel] [PATCH 03/11] ahci: Fix sglist memleak in ahci_dma_rw_buf()

From: Jason Baron I noticed that in hw/ide/ahci:ahci_dma_rw_buf() we do not free the sglist. Thus, I've added a call to qemu_sglist_destroy() to fix this memory leak. In addition, I've adeed a call in qemu_sglist_destroy() to 0 all of the sglist fields, in case there is some other codepath that

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

On Fri, 10 Aug 2012 18:35:26 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Fri, 10 Aug 2012 09:56:11 +0200 > > Markus Armbruster wrote: > > > >> Revisited this one on review of v2, replying here for context. > >> > >> Luiz Capitulino writes: > >> > >> > On Thu, 02 Aug 20

Re: [Qemu-devel] [PATCH v8 0/7] file descriptor passing using fd sets

On 08/10/2012 12:36 PM, Kevin Wolf wrote: Am 10.08.2012 04:10, schrieb Corey Bryant: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU process from opening files tha

Re: [Qemu-devel] [PATCH v8 7/7] block: Enable qemu_open/close to work with fd sets

On 08/10/2012 12:34 PM, Kevin Wolf wrote: Am 10.08.2012 04:10, schrieb Corey Bryant: When qemu_open is passed a filename of the "/dev/fdset/nnn" format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within the specified monitor fd set. If the fd is fou

[Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2)

This series implements the necessary commands to implements danpb's idea to remove -help parsing in libvirt. We would introduce all of these commands in 1.2 and then change the -help output starting in 1.3. Here is Dan's plan from a previous thread: Basically I'd sum up my new idea as "just u

[Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable

We've had a cycle to tweak. It is time to commit to supporting them. Signed-off-by: Anthony Liguori --- qapi-schema.json | 19 --- 1 files changed, 4 insertions(+), 15 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 191a889..a938c8d 100644 --- a/qapi-schem

[Qemu-devel] [PATCH 07/11] blockdev: flip default cache mode from writethrough to writeback

From: Paolo Bonzini Now all major device models (IDE, SCSI, virtio) can choose between writethrough and writeback at run-time, and virtio will even revert to writethrough if the guest is not capable of sending flushes. So we can change the default to writeback at last. Tested, for lack of a bet

Re: [Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpudefs

On Fri, Aug 10, 2012 at 11:37:30AM -0500, Anthony Liguori wrote: > Eduardo Habkost writes: > > > On Fri, Aug 10, 2012 at 09:43:21AM -0500, Anthony Liguori wrote: > >> Eduardo Habkost writes: > >> > >> > On Fri, Jul 27, 2012 at 08:37:18AM -0500, Anthony Liguori wrote: > >> >> Signed-off-by: Anth

[Qemu-devel] [PATCH 05/11] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE

From: Paolo Bonzini Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with the spec. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/virtio-blk.c | 16 ++-- hw/virtio-blk.h |4 +++- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] ARM patches for QEMU 1.2: final call

On 08/10/2012 08:21 PM, Peter Maydell wrote: Last call for any ARM related patches to go into 1.2. My current queue looks like this: 59cbd70 hw/sd.c: make sd_wp_addr() return bool 8b4cc14 hw/sd.c: make sd_dataready() return bool 025caa6 hw/sd.c: convert binary variables to bool 38d24e6 hw/sd.c:

  1   2   3   >