[Qemu-devel] [PATCH] configure: Fix build for some versions of glibc (9pfs)

2012-06-06 Thread Stefan Weil
Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH. Extend the check in configure to test both preconditions. Signed-off-by: Stefan Weil --- configure |4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 799ad0f..f737f6c 100755 --- a/configu

Re: [Qemu-devel] [PATCH v2 3/3] qmp: do not include monitor.h from qapi-types-core.h

2012-06-06 Thread Paolo Bonzini
Il 07/06/2012 06:55, Anthony Liguori ha scritto: > On 06/07/2012 10:02 AM, Paolo Bonzini wrote: >> The comment is stale, monitor.h is not needed anymore (only qerror.h >> is, because it contains the schema for errors). >> >> Signed-off-by: Paolo Bonzini >> --- >> qapi/qapi-types-core.h |4 +--

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Anthony Liguori
On 06/07/2012 01:26 PM, Paolo Bonzini wrote: Il 07/06/2012 05:16, Anthony Liguori ha scritto: On 06/06/2012 07:54 PM, Paolo Bonzini wrote: From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 From: Anthony Liguori Date: Wed, 6 Jun 2012 16:57:00 +0800 Subject: [PATCH] config

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Paolo Bonzini
Il 07/06/2012 05:16, Anthony Liguori ha scritto: > On 06/06/2012 07:54 PM, Paolo Bonzini wrote: >>> From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 >>> From: Anthony Liguori >>> Date: Wed, 6 Jun 2012 16:57:00 +0800 >>> Subject: [PATCH] configure: ensure directory exists when

[Qemu-devel] [PATCH v3 2/4] exynos4210: introduce Exynos4210 SD host controller model

2012-06-06 Thread Peter A. G. Crosthwaite
From: Igor Mitsyanko Exynos4210 SD/MMC host controller is based on SD association standart host controller ver. 2.00 Signed-off-by: Igor Mitsyanko --- Makefile.target |1 + hw/exynos4210.c | 20 +++ hw/exynos4210_sdhci.c | 438

Re: [Qemu-devel] [PATCH v3 0/4] Standard SD host controller model

2012-06-06 Thread Peter Crosthwaite
Sorry, subject should read "Standard SD host controller model" On Thu, Jun 7, 2012 at 3:05 PM, Peter A. G. Crosthwaite wrote: > > [Original cover by Igor] > First patch introduces standard SD host controller model. This is accumulated > version of my previous patch I sent a while ago and a recen

[Qemu-devel] [PATCH v3 4/4] xilinx_zynq: Added sdhci controllers

2012-06-06 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 7290c64..42b6e69 100644 --- a/hw/xilinx_zynq.c +++ b/hw/xilinx_zynq.c @@ -130,6 +130,18 @@ static void zynq_in

[Qemu-devel] [PATCH v3 3/4] vl.c: allow for reapeated -sd arguments

2012-06-06 Thread Peter A. G. Crosthwaite
Allows for repeating of -sd arugments in the same way -pflash and -mtdblock can be repeated. Signed-off-by: Peter A. G. Crosthwaite --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 23ab3a3..a381e90 100644 --- a/vl.c +++ b/vl.c @@ -2437,7 +2437,

[Qemu-devel] [PATCH v3 0/4] *** SUBJECT HERE ***

2012-06-06 Thread Peter A. G. Crosthwaite
[Original cover by Igor] First patch introduces standard SD host controller model. This is accumulated version of my previous patch I sent a while ago and a recent SDHCI patch by Peter A. G. Crosthwaite. Second patch introduces Exynos4210-specific SDHCI built on top of standard SDHCI model. [New]

Re: [Qemu-devel] [PATCH v2 3/3] qmp: do not include monitor.h from qapi-types-core.h

2012-06-06 Thread Anthony Liguori
On 06/07/2012 10:02 AM, Paolo Bonzini wrote: The comment is stale, monitor.h is not needed anymore (only qerror.h is, because it contains the schema for errors). Signed-off-by: Paolo Bonzini --- qapi/qapi-types-core.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread li zhang
On Thu, Jun 7, 2012 at 12:43 PM, Anthony Liguori wrote: > On 06/07/2012 12:39 PM, li zhang wrote: > >> On Thu, Jun 7, 2012 at 9:15 AM, Anthony Liguori >> wrote: >> >> Hi Anthony, >> >> I think we can add usb to machine option, and set usb on as default in >> qemu, right? >> Does it conflict with

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread li zhang
On Thu, Jun 7, 2012 at 11:00 AM, Benjamin Herrenschmidt wrote: > On Thu, 2012-06-07 at 09:15 +0800, Anthony Liguori wrote: > > > You misunderstand what I'm saying. > > > > -nodefault is a dumb option. It's semantics are poorly defined because > it > > depends on machine. Further complicating tho

Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey

2012-06-06 Thread Anthony Liguori
On 06/06/2012 07:58 PM, Eric Blake wrote: On 06/06/2012 01:13 AM, Amos Kong wrote: Ho, I found another bug in my code, key in decimal or hexadecimal format is not supported. I will fix it. How do you plan to support decimal in QMP? In old do_sendkey(), only key-name and hexadecimal were sup

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread Anthony Liguori
On 06/07/2012 12:39 PM, li zhang wrote: On Thu, Jun 7, 2012 at 9:15 AM, Anthony Liguori wrote: Hi Anthony, I think we can add usb to machine option, and set usb on as default in qemu, right? Does it conflict with "-device pci-ohci" ? libvirt would want to pass '-machine type=pseries,usb=off'

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread li zhang
On Thu, Jun 7, 2012 at 9:15 AM, Anthony Liguori wrote: > On 06/07/2012 05:13 AM, Benjamin Herrenschmidt wrote: > >> On Wed, 2012-06-06 at 13:42 +0800, Anthony Liguori wrote: >> >>> On 06/06/2012 11:31 AM, Benjamin Herrenschmidt wrote: >>> On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote: >>

Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices

2012-06-06 Thread Benjamin Herrenschmidt
On Wed, 2012-06-06 at 21:56 -0600, Alex Williamson wrote: > In so far as vfio should only have to call pci_reset_function and > device > quirks take care of everything else, I agree with you, but that > doesn't > answer any of my questions. Sure, we may want pre- and post-reset > fixup > quirks an

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Bo Yang
> > Bo Yang, I believe you tested the new bridge helper recently. Did you > run into any path issues with /usr/libexec vs. /usr/lib? > I didn't install the package. I only build and test the functions. >From the source code of configure, the CONFIG_QEMU_HELPERDIR is hardcoded to $prefix/libex

Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices

2012-06-06 Thread Alex Williamson
On Thu, 2012-06-07 at 12:52 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-06 at 17:17 -0600, Alex Williamson wrote: > > > diff --git a/drivers/vfio/pci/vfio_pci.c > > b/drivers/vfio/pci/vfio_pci.c > > > index 1e5315c..6e7c12d 100644 > > > --- a/drivers/vfio/pci/vfio_pci.c > > > +++ b/drive

Re: [Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile

2012-06-06 Thread Aneesh Kumar K.V
Stefan Weil writes: > Am 06.06.2012 12:50, schrieb Stefano Stabellini: >> Hi Anthony, >> currently QEMU 1.1 doesn't compile virtfs correctly on Ubuntu: >> . > > The patch will fix the compiler error messages, but will the > resulting code work? Maybe it has runtime dependencies > (Linux kern

[Qemu-devel] [patch V9 5/5] i.MX31: KZM-ARM11-01 evaluation board

2012-06-06 Thread peter . chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the Freescale i.MX31. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb --- Makefile.target |2 hw/kzm.c| 156 2 files changed, 157 i

[Qemu-devel] [patch V9 1/5] i.MX: UART support

2012-06-06 Thread peter . chubb
Implement the Freescale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the Freescale i.MX series. This patch gives only a `bare-bones' implementation, enough to run Linux or OKL4, but that's about it. Signed-off-by: Philip O'Sullivan Signed-off-by

[Qemu-devel] [patch V9 2/5] i.MX31: Clock Control Module

2012-06-06 Thread peter . chubb
For Linux to be able to work out how fast its clocks are going, so that timer ticks come approximately at the right time, it needs to be able to query the clock control module (CCM). This is the start of a CCM implementation. It currently knows only about the MCU, HSP and IPG clocks --- i.e., t

[Qemu-devel] [patch V9 3/5] i.MX31: Timers

2012-06-06 Thread peter . chubb
Implement the timers on the Freescale i.MX31 SoC. This is not a complete implementation, but gives enough for Linux to boot and run. In particular external triggers, which are not useful under QEMU, are not implemented. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb --- Makefile

[Qemu-devel] [patch V9 4/5] i.MX31: Interrupt Controller

2012-06-06 Thread peter . chubb
Implement the Freescale i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb Reviewed-by: Peter Maydell --- Makefile.target |2 hw/imx_avic.c | 408 ++

[Qemu-devel] [patch V9 0/5] i.MX31: Add initial support

2012-06-06 Thread peter . chubb
Changes since V8: Recovered my stuff-up from backup --- changes that were in V7 are back in! Andreas's comments addressed (except adding MAINTAINER field) Peter Maydell's comments against V6/7 are addressed. Peter C -- Dr Peter Chubb peter

Re: [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum

2012-06-06 Thread Amos Kong
On 07/06/12 08:15, Michael Roth wrote: On Sat, Jun 02, 2012 at 06:54:27AM +0800, Amos Kong wrote: Currently, if define an 'enum' and use it in one command's data, List struct for enum could not be generated, but it's used in qmp function. For example: KeyCodesList could not be generated. qapi-

Re: [Qemu-devel] Any approach to log the file read/write (I/O data flow) like the "-d in_asm" option?

2012-06-06 Thread Wei-Ren Chen
On Wed, Jun 06, 2012 at 11:23:37AM +0100, Stefan Hajnoczi wrote: > On Sun, Jun 3, 2012 at 9:50 PM, Yue Chen wrote: > > I'm doing something like a simple and lightweight REPLAY program out of > > QEMU, only including CPU, MEMORY, and DISK. I'm implementing it with a > > shadow CPU (register state),

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Eric Blake
On 06/06/2012 09:15 PM, Anthony Liguori wrote: > On 06/06/2012 08:16 PM, Paolo Bonzini wrote: >> Il 06/06/2012 14:03, Peter Maydell ha scritto: >>> Can we use >>> mkdir -p "$(dirname "$2")" >>> >>> or are we still trying to be compatible with some non-POSIX >>> shell from the dawn of time? >> >>

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Anthony Liguori
On 06/06/2012 07:54 PM, Paolo Bonzini wrote: From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 From: Anthony Liguori Date: Wed, 6 Jun 2012 16:57:00 +0800 Subject: [PATCH] configure: ensure directory exists when creating symlink Signed-off-by: Anthony Liguori --- configure

Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

2012-06-06 Thread Anthony Liguori
On 06/06/2012 08:16 PM, Paolo Bonzini wrote: Il 06/06/2012 14:03, Peter Maydell ha scritto: Can we use mkdir -p "$(dirname "$2")" or are we still trying to be compatible with some non-POSIX shell from the dawn of time? Looks like we can, there are other occurrences of $() in configure. I

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-06-06 Thread Anthony Liguori
On 06/07/2012 06:56 AM, Paul Moore wrote: On Wednesday, June 06, 2012 01:56:52 AM Alexander Graf wrote: The other one (FIPS) is basically a list of encryption algorithms that are deemed OK and not crackable within seconds by anyone. Only one of the 2 doesn't help much. In combination they actua

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread Anthony Liguori
On 06/07/2012 11:00 AM, Benjamin Herrenschmidt wrote: On Thu, 2012-06-07 at 09:15 +0800, Anthony Liguori wrote: You misunderstand what I'm saying. -nodefault is a dumb option. It's semantics are poorly defined because it depends on machine. Further complicating those semantics by adding more

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread Benjamin Herrenschmidt
On Thu, 2012-06-07 at 09:15 +0800, Anthony Liguori wrote: > You misunderstand what I'm saying. > > -nodefault is a dumb option. It's semantics are poorly defined because it > depends on machine. Further complicating those semantics by adding more > magic > for -M spapr just makes the situati

Re: [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum

2012-06-06 Thread Amos Kong
On 07/06/12 08:26, Michael Roth wrote: On Wed, Jun 06, 2012 at 03:40:37PM -0300, Luiz Capitulino wrote: On Sat, 2 Jun 2012 06:54:27 +0800 Amos Kong wrote: Currently, if define an 'enum' and use it in one command's data, List struct for enum could not be generated, but it's used in qmp functi

Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices

2012-06-06 Thread Benjamin Herrenschmidt
On Wed, 2012-06-06 at 17:17 -0600, Alex Williamson wrote: > > diff --git a/drivers/vfio/pci/vfio_pci.c > b/drivers/vfio/pci/vfio_pci.c > > index 1e5315c..6e7c12d 100644 > > --- a/drivers/vfio/pci/vfio_pci.c > > +++ b/drivers/vfio/pci/vfio_pci.c > > @@ -88,6 +88,8 @@ static void vfio_pci_disable(str

Re: [Qemu-devel] What target could be a QOM example?

2012-06-06 Thread Jia Liu
Hi Andreas, On Thu, Jun 7, 2012 at 8:53 AM, Andreas Färber wrote: > Hi Jia, > > Am 30.05.2012 11:29, schrieb Jia Liu: >> Since target-or32 is a new target, I would like to implement it in QOM >> way. Is there a good QOM example I can refer to? > > You could peek at my target-rl78 that I've starte

[Qemu-devel] [Bug 1007269] Re: Can’t install or boot up 32bit win8 guest.

2012-06-06 Thread Yongjie Ren
For 32bit Win8, I used different cpu mode and got different results as following. n270: can boot up athlon: fail (Error code: 0x005D) pentium3: can boot up pentium2: fail(Error code: 0x005D) Pentium: fail(error code: 0xc260) 486: fail(error code: 0xc260) Coreduo: can b

[Qemu-devel] [patch] target-microblaze/translate.c fails to compile with gcc 4.7

2012-06-06 Thread Peter Chubb
n current qemu.git, I see: CCmicroblaze-softmmu/translate.o /home/peterc/src/work/QEMU/qemu-working/target-microblaze/translate.c: In function ‘dec_store’: /home/peterc/src/work/QEMU/qemu-working/target-microblaze/translate.c:1108:5: error: invalid initializer This is the obvious fix: ---

[Qemu-devel] [PATCH v2 3/3] qmp: do not include monitor.h from qapi-types-core.h

2012-06-06 Thread Paolo Bonzini
The comment is stale, monitor.h is not needed anymore (only qerror.h is, because it contains the schema for errors). Signed-off-by: Paolo Bonzini --- qapi/qapi-types-core.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/qapi/qapi-types-core.h b/qapi/qapi-types-core.h

[Qemu-devel] [PATCH v2 2/3] qmp: include monitor.h when needed

2012-06-06 Thread Paolo Bonzini
This is needed to get file descriptors from SCM_RIGHTS. Signed-off-by: Paolo Bonzini --- hmp.c |1 + net/tap.c |1 + 2 file changed, 2 insertion(+) diff --git a/hmp.c b/hmp.c index 2ce8cb9..b9cec1d 100644 --- a/hmp.c +++ b/hmp.c @@ -18,6 +18,7 @@ #include "qemu-option.h" #include

[Qemu-devel] [PATCH v2 1/3] kvm: add missing include files

2012-06-06 Thread Paolo Bonzini
These are included via monitor.h right now, add them explicitly. Signed-off-by: Paolo Bonzini --- kvm-all.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kvm-all.c b/kvm-all.c index 489ee53..831651d 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -22,6 +22,8 @@ #include "qemu-common.h"

[Qemu-devel] [PATCH v2 0/3] Clean up includes of monitor.h

2012-06-06 Thread Paolo Bonzini
There is no reason why QAPI clients should use monitor.h at all, qerror.h suffices. qmp-commands.h uses the Monitor typedef, but it is only included from files that already get the typedef from qemu-common.h. v1->v2: rebase to queue/qmp Paolo Bonzini (3): kvm: add missing include files qmp:

Re: [Qemu-devel] qemu wiki file upload & images?

2012-06-06 Thread Anthony Liguori
On 06/07/2012 02:42 AM, Jeff Cody wrote: Hi, I am working on some design documentation for a live block commit proposal, and I have several SVG / PNG diagrams that I've put together for it. Ideally, I'd like to just place this document (with diagrams) on the QEMU wiki, and get some feedback, an

Re: [Qemu-devel] [PULL 00/12] Block patches

2012-06-06 Thread Anthony Liguori
On 06/04/2012 07:13 PM, Kevin Wolf wrote: The following changes since commit 8cc9b43f7c5f826b39af4b012ad89bb55faac29c: target-microblaze: lwx/swx: first implementation (2012-06-04 10:19:46 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled.

Re: [Qemu-devel] [PULL] QOM CPUState, part 3: cpu_state_reset()

2012-06-06 Thread Anthony Liguori
On 06/05/2012 09:21 AM, Andreas Färber wrote: Hello Anthony, Please pull the next batch of QOM CPUState conversions cherry-picked from qom-next branch. These are more than 50 but all pretty trivial and a self-contained series. Pulled. Thanks. Regards, Anthony Liguori As before, there are

Re: [Qemu-devel] [PULL 00/29]: QMP queue

2012-06-06 Thread Anthony Liguori
On 06/06/2012 01:24 AM, Luiz Capitulino wrote: Contains the new commands dump-guest-memory and query-events; and the netdev_add/netdev_del conversion to the QAPI. The changes (since 8cc9b43f7c5f826b39af4b012ad89bb55faac29c) are available in the following repository: git://repo.or.cz/qemu/q

Re: [Qemu-devel] [PULL] Fix for ppc build breakage

2012-06-06 Thread Anthony Liguori
On 06/06/2012 05:04 PM, Avi Kivity wrote: Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Pulled. Thanks. Regards, Anthony Liguori Jan Kiszka (1): kvm: Fix build for non-CAP_IRQ_ROUT

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread Anthony Liguori
On 06/07/2012 05:13 AM, Benjamin Herrenschmidt wrote: On Wed, 2012-06-06 at 13:42 +0800, Anthony Liguori wrote: On 06/06/2012 11:31 AM, Benjamin Herrenschmidt wrote: On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote: Hi Anthony, Any comment on this? Allright, this is all quite confusing...

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/31] dt: add helpers for 2, 3 and 4 cell adds

2012-06-06 Thread David Gibson
[snip] > > You mean internally? Yeah, probably. Externally? The point of these > > helpers is to make the code look less cluttered. We can already pass in > > an array just fine, but C is quite annoying about generating those on > > the fly, while it's easy to pass in ints as parameters :) > > Var

Re: [Qemu-devel] What target could be a QOM example?

2012-06-06 Thread Andreas Färber
Hi Jia, Am 30.05.2012 11:29, schrieb Jia Liu: > Since target-or32 is a new target, I would like to implement it in QOM > way. Is there a good QOM example I can refer to? You could peek at my target-rl78 that I've started redoing in a QOM way and with CONFIG_TCG_PASS_AREG0: https://github.com/afa

Re: [Qemu-devel] [patch v8 0/5] i.MX31 support

2012-06-06 Thread Peter Chubb
> "Andreas" == Andreas Färber writes: Andreas> Hello Peter, Am 06.06.2012 05:47, schrieb Peter Chubb: >> There are no major changes since last time, just rebased to current >> tip now that QEMU 1.2 is open. >> >> For those who have come into the story late, this is a series of >> patches to

Re: [Qemu-devel] [PATCH 07/31] dt: add helper for phandle allocation

2012-06-06 Thread Scott Wood
On 06/06/2012 07:15 PM, Peter Crosthwaite wrote: > On Thu, Jun 7, 2012 at 2:55 AM, Scott Wood wrote: >> On 06/06/2012 11:00 AM, Alexander Graf wrote: >>> On 06/06/2012 07:18 AM, Peter Crosthwaite wrote: On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote: > +uint32_t qemu_devtree_allo

Re: [Qemu-devel] [PATCH 05/31] dt: add helper for phandle enumeration

2012-06-06 Thread Peter Crosthwaite
On Thu, Jun 7, 2012 at 1:58 AM, Alexander Graf wrote: > On 06/06/2012 07:11 AM, Peter Crosthwaite wrote: >> >> On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote: >>> >>> This patch adds a helper to search for a node's phandle by its path. This >>> is especially useful when the phandle is par

Re: [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum

2012-06-06 Thread Michael Roth
On Wed, Jun 06, 2012 at 03:40:37PM -0300, Luiz Capitulino wrote: > On Sat, 2 Jun 2012 06:54:27 +0800 > Amos Kong wrote: > > > Currently, if define an 'enum' and use it in one command's data, > > List struct for enum could not be generated, but it's used in > > qmp function. > > > > For example:

Re: [Qemu-devel] [PATCH 07/31] dt: add helper for phandle allocation

2012-06-06 Thread Peter Crosthwaite
On Thu, Jun 7, 2012 at 2:55 AM, Scott Wood wrote: > On 06/06/2012 11:00 AM, Alexander Graf wrote: >> On 06/06/2012 07:18 AM, Peter Crosthwaite wrote: >>> On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote: Phandle references work by having 2 pieces:    - a "phandle" 1-cell prop

Re: [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum

2012-06-06 Thread Michael Roth
On Sat, Jun 02, 2012 at 06:54:27AM +0800, Amos Kong wrote: > Currently, if define an 'enum' and use it in one command's data, > List struct for enum could not be generated, but it's used in > qmp function. > > For example: KeyCodesList could not be generated. > >>> qapi-schema.json: > { 'enum': 'K

Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-06 Thread Peter Maydell
On 6 June 2012 13:55, Markus Armbruster wrote: > Peter Maydell writes: > >> On 5 June 2012 13:51, Markus Armbruster wrote: >>> @@ -554,6 +553,7 @@ static int blk_init(struct XenDevice *xendev) >>>  { >>>     struct XenBlkDev *blkdev = container_of(xendev, struct XenBlkDev, >>> xendev); >>>    

Re: [Qemu-devel] [PATCH qom-next] target-i386: Use uint32 visitor for [x]level properties

2012-06-06 Thread Michael Roth
On Wed, Jun 06, 2012 at 11:57:54PM +0200, Andreas Färber wrote: > This simplifies the code and resolves TODOs. > > Signed-off-by: Andreas Färber Reviewed-by: Michael Roth > --- > Seems I only submitted this as an attachment once... > Can someone please review tomorrow so that I can include i

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Anthony Liguori
On 06/05/2012 06:06 PM, Avi Kivity wrote: On 06/05/2012 04:00 AM, Michael Roth wrote: This is an import of Anthony's qidl compiler, with some changes squashed in to add support for doing the visitor generation via QEMU's qapi code generators rather than directly. Documentation has been imported

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Bruce Rogers
>>> On 6/6/2012 at 04:36 PM, Andreas Färber wrote: > Am 07.06.2012 00:23, schrieb Michael Tokarev: >> On 07.06.2012 02:21, Andreas Färber wrote: >>> Trust me, it [works]. Otherwise our package build would still fail since >>> our %_libexecdir is /usr/lib. >>> >>> See Makefile, that one actually u

Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices

2012-06-06 Thread Alex Williamson
On Fri, 2012-05-25 at 17:35 +1000, Alexey Kardashevskiy wrote: > Some adapters (like NEC PCI USB controller) do not flush their config > on a sioftware reset and remember DMA config, etc. > > If we use such an adapter with QEMU, then crash QEMU (stop it with > ctrl-A ctrl-X), and try to use it in

Re: [Qemu-devel] [PATCH v2 3/6] rename keyname '<' to 'less'

2012-06-06 Thread Amos Kong
- Original Message - > On Sat, 2 Jun 2012 06:54:25 +0800 > Amos Kong wrote: > > > There are many maps of keycode 0x56 in pc-bios/keymaps/* > > pc-bios/keymaps/common:less 0x56 > > pc-bios/keymaps/common:greater 0x56 shift > > pc-bios/keymaps/common:bar 0x56 altgr > > pc-bios/keym

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-06-06 Thread Paul Moore
On Wednesday, June 06, 2012 01:56:52 AM Alexander Graf wrote: > On 06.06.2012, at 01:07, Anthony Liguori wrote: > > On 06/06/2012 06:06 AM, Paul Moore wrote: > >> On Tuesday, June 05, 2012 11:51:40 PM Alexander Graf wrote: > >>> On 05.06.2012, at 23:45, Paul Moore wrote: > On Tuesday, June 05,

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Michael Tokarev
On 07.06.2012 02:36, Andreas Färber wrote: > Am 07.06.2012 00:23, schrieb Michael Tokarev: >> On 07.06.2012 02:21, Andreas Färber wrote: >>> Trust me, it [works]. Otherwise our package build would still fail since >>> our %_libexecdir is /usr/lib. >>> >>> See Makefile, that one actually uses $(libe

Re: [Qemu-devel] [PATCH 11/17] qapi: add qidl-generated qapi schema for rtc

2012-06-06 Thread Michael Roth
On Wed, Jun 06, 2012 at 09:38:24AM +0200, Kevin Wolf wrote: > Am 05.06.2012 18:03, schrieb Michael Roth: > > On Tue, Jun 05, 2012 at 11:29:24AM +0200, Kevin Wolf wrote: > >> Am 05.06.2012 03:00, schrieb Michael Roth: > >>> Signed-off-by: Michael Roth > >>> --- > >>> qidl-generated/mc146818rtc.jso

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Andreas Färber
Am 07.06.2012 00:23, schrieb Michael Tokarev: > On 07.06.2012 02:21, Andreas Färber wrote: >> Trust me, it [works]. Otherwise our package build would still fail since >> our %_libexecdir is /usr/lib. >> >> See Makefile, that one actually uses $(libexecdir): > > Makefile installs stuff to /usr/lib,

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Michael Tokarev
On 07.06.2012 02:21, Andreas Färber wrote: [] > Trust me, it does. Otherwise our package build would still fail since > our %_libexecdir is /usr/lib. > > See Makefile, that one actually uses $(libexecdir): Makefile installs stuff to /usr/lib, but does the resulting qemu binary look there too? /m

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Andreas Färber
Am 07.06.2012 00:12, schrieb Michael Tokarev: > On 07.06.2012 02:06, Andreas Färber wrote: >> Am 06.06.2012 23:11, schrieb Michael Tokarev: > [] >> Reviewed-by: Andreas Färber >> >> I noticed the lack of this and just passed libexecdir= to make as a >> workaround for our openSUSE package. > > Tha

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread Andreas Färber
Am 06.06.2012 05:31, schrieb Benjamin Herrenschmidt: > On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote: [context: sPAPR] > -usb should be essentially useless by default unless -nodefault is > passed in which case it is necessary to enable usb support, and -device > (or equivalent) to manually add

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Michael Tokarev
On 07.06.2012 02:06, Andreas Färber wrote: > Am 06.06.2012 23:11, schrieb Michael Tokarev: [] > Reviewed-by: Andreas Färber > > I noticed the lack of this and just passed libexecdir= to make as a > workaround for our openSUSE package. Thank you for your review. However, passing libexecdir= to m

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Andreas Färber
Am 06.06.2012 23:11, schrieb Michael Tokarev: > Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 "Add basic version > of bridge helper" put the bridge helper executable into a fixed > ${prefix}/libexec/ location, instead of using ${libexecdir} for > this. At the same time, --libexecdir is being hap

Re: [Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile

2012-06-06 Thread Serge Hallyn
- Original message - > Am 06.06.2012 19:49, schrieb Serge Hallyn: > > Quoting Stefan Weil (s...@weilnetz.de): > > > The patch will fix the compiler error messages, but will the > > > resulting code work? Maybe it has runtime dependencies > > > (Linux kernel?) which should be checked at run

[Qemu-devel] [PATCH qom-next] target-i386: Use uint32 visitor for [x]level properties

2012-06-06 Thread Andreas Färber
This simplifies the code and resolves TODOs. Signed-off-by: Andreas Färber --- Seems I only submitted this as an attachment once... Can someone please review tomorrow so that I can include it in the PULL? Thanks! target-i386/cpu.c | 42 -- 1 files ch

Re: [Qemu-devel] [PATCH 02/31] dt: add helpers for 2, 3 and 4 cell adds

2012-06-06 Thread Scott Wood
On 06/06/2012 10:55 AM, Alexander Graf wrote: > On 06/06/2012 07:01 AM, Peter Crosthwaite wrote: >> On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote: >>> We have device tree helpers that allow us to create single cell (u32) >>> wide properties. However, when creating properties that contain

Re: [Qemu-devel] [PATCH] virtio-9p-handle: define AT_EMPTY_PATH if needed

2012-06-06 Thread Serge Hallyn
Quoting Aneesh Kumar K.V (aneesh.ku...@linux.vnet.ibm.com): > Serge Hallyn writes: > > > If AT_EMPTY_PATH is not in one of the included files, go ahead and > > define it. qemu won't compile on ubuntu for me without this. > > > > (Note - alternatively we could #include to pick > > up the definit

Re: [Qemu-devel] [RFC PATCH 1/2] ivring: Add a ring-buffer driver on IVShmem

2012-06-06 Thread Masami Hiramatsu
(2012/06/06 8:22), Greg Kroah-Hartman wrote: > On Wed, Jun 06, 2012 at 07:03:06AM +0800, Anthony Liguori wrote: >> On 06/05/2012 09:10 PM, Borislav Petkov wrote: >>> On Tue, Jun 05, 2012 at 10:01:17PM +0900, Yoshihiro YUNOMAE wrote: This patch adds a ring-buffer driver for IVShmem device, a vi

Re: [Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile

2012-06-06 Thread Serge Hallyn
Quoting Stefan Weil (s...@weilnetz.de): > Am 06.06.2012 12:50, schrieb Stefano Stabellini: > >Hi Anthony, > >currently QEMU 1.1 doesn't compile virtfs correctly on Ubuntu: > > > >qemu/hw/9pfs/virtio-9p-handle.c: In function ‘handle_update_file_cred’: > >qemu/hw/9pfs/virtio-9p-handle.c:66:58: error:

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

2012-06-06 Thread Michael Roth
On Wed, Jun 06, 2012 at 10:31:56AM +0300, Avi Kivity wrote: > On 06/06/2012 12:11 AM, Michael Roth wrote: > >> > >> Is is possible to let the compiler process the .c file, with the IDL > >> delimited by some marker? I like how device models are self contained > >> in one file now. > > > > It's p

Re: [Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile

2012-06-06 Thread Stefan Weil
Am 06.06.2012 19:49, schrieb Serge Hallyn: Quoting Stefan Weil (s...@weilnetz.de): The patch will fix the compiler error messages, but will the resulting code work? Maybe it has runtime dependencies (Linux kernel?) which should be checked at runtime. Would an enhanced test in configure be a bet

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-06 Thread Benjamin Herrenschmidt
On Wed, 2012-06-06 at 13:42 +0800, Anthony Liguori wrote: > On 06/06/2012 11:31 AM, Benjamin Herrenschmidt wrote: > > On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote: > >> Hi Anthony, > >> > >> > >> Any comment on this? > > > > Allright, this is all quite confusing... > > > > He's what I think sh

[Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-06-06 Thread Michael Tokarev
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 "Add basic version of bridge helper" put the bridge helper executable into a fixed ${prefix}/libexec/ location, instead of using ${libexecdir} for this. At the same time, --libexecdir is being happily ignored by ./configure. Even more, the same patc

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-06 Thread Andreas Färber
Am 06.06.2012 22:09, schrieb Michael Roth: > On Wed, Jun 06, 2012 at 06:49:19PM +0200, Laszlo Ersek wrote: >> On 06/06/12 18:14, Michael Roth wrote: >>> On Wed, Jun 06, 2012 at 05:30:03PM +0200, Laszlo Ersek wrote: >> value < 0 >>> >>> I think this last one will cause problems though, since

[Qemu-devel] [PATCH] Allow loading U-Boot initrd images

2012-06-06 Thread Ben Collins
The hooks were already there for the kernel, so enabled it for initrd's too. The caveat is that we don't decompress initrd's, since the kernel can do this itself (and actually gets confused if it encounters an uncompressed image). This is based on a patch by Scott Wood that was for another purpose

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-06 Thread Michael Roth
On Wed, Jun 06, 2012 at 06:49:19PM +0200, Laszlo Ersek wrote: > On 06/06/12 18:14, Michael Roth wrote: > > On Wed, Jun 06, 2012 at 05:30:03PM +0200, Laszlo Ersek wrote: > > >> value < 0 > > > > I think this last one will cause problems though, since uint64_t's > > within the valid range for vis

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-06 Thread Corey Bryant
On 06/06/2012 01:50 PM, Luiz Capitulino wrote: On Wed, 06 Jun 2012 10:04:23 -0400 Corey Bryant wrote: Today, we return a dict on success: { "return": {} } But this patch changes it to: { "return": 42 } There are two ways to do this without breaking compatibility: 1. Add a new c

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-06 Thread Laszlo Ersek
On 06/06/12 18:14, Michael Roth wrote: > On Wed, Jun 06, 2012 at 05:30:03PM +0200, Laszlo Ersek wrote: >> value < 0 > > I think this last one will cause problems though, since uint64_t's > within the valid range for visit_type_uint64() will fail due to being > interpreted as < 0 when cast to in

Re: [Qemu-devel] [PATCH 0/2] Clean up includes of monitor.h

2012-06-06 Thread Luiz Capitulino
On Wed, 6 Jun 2012 08:08:42 +0200 Paolo Bonzini wrote: > There is no reason why QAPI clients should use monitor.h at all, > qerror.h suffices. > > qmp-commands.h uses the Monitor typedef, but it is only included > from files that already get the typedef from qemu-common.h. Could you please reb

[Qemu-devel] qemu wiki file upload & images?

2012-06-06 Thread Jeff Cody
Hi, I am working on some design documentation for a live block commit proposal, and I have several SVG / PNG diagrams that I've put together for it. Ideally, I'd like to just place this document (with diagrams) on the QEMU wiki, and get some feedback, and modify it according to feedback. Looking

Re: [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum

2012-06-06 Thread Luiz Capitulino
On Sat, 2 Jun 2012 06:54:27 +0800 Amos Kong wrote: > Currently, if define an 'enum' and use it in one command's data, > List struct for enum could not be generated, but it's used in > qmp function. > > For example: KeyCodesList could not be generated. > >>> qapi-schema.json: > { 'enum': 'KeyCod

Re: [Qemu-devel] [PATCH v2 3/6] rename keyname '<' to 'less'

2012-06-06 Thread Luiz Capitulino
On Sat, 2 Jun 2012 06:54:25 +0800 Amos Kong wrote: > There are many maps of keycode 0x56 in pc-bios/keymaps/* > pc-bios/keymaps/common:less 0x56 > pc-bios/keymaps/common:greater 0x56 shift > pc-bios/keymaps/common:bar 0x56 altgr > pc-bios/keymaps/common:brokenbar 0x56 shift altgr > > Th

Re: [Qemu-devel] [PATCH v2 2/6] fix doc of using raw values with sendkey

2012-06-06 Thread Luiz Capitulino
On Sat, 2 Jun 2012 06:54:24 +0800 Amos Kong wrote: > (qemu) sendkey a > (qemu) sendkey 0x1e > (qemu) sendkey #0x1e > unknown key: '#0x1e' > > The last command doesn't work, '#' is not request before raw values. > > Signed-off-by: Amos Kong > --- > hmp-commands.hx |4 ++-- > 1 files chan

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-06 Thread Luiz Capitulino
On Wed, 06 Jun 2012 10:04:23 -0400 Corey Bryant wrote: > > Today, we return a dict on success: > > > > { "return": {} } > > > > But this patch changes it to: > > > > { "return": 42 } > > > > There are two ways to do this without breaking compatibility: > > > > 1. Add a new command (say get-

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-06 Thread Laszlo Ersek
On 06/06/12 18:49, Laszlo Ersek wrote: > The fallback (*v->type_int)() call stores an int64_t, according to its > prototype ("interface contract"). IMHO it shouldn't try to communicate a > mathematical value outside of [INT64_MIN, INT64_MAX]; it should report > an error in this case. Suppose the

Re: [Qemu-devel] [PATCH] virtio-9p-handle: define AT_EMPTY_PATH if needed

2012-06-06 Thread Aneesh Kumar K.V
Serge Hallyn writes: > If AT_EMPTY_PATH is not in one of the included files, go ahead and > define it. qemu won't compile on ubuntu for me without this. > > (Note - alternatively we could #include to pick > up the definitions there) Then why don't we do that ? I do get the below errors In fil

[Qemu-devel] [PATCH v2 1/2] xen: Don't change -drive if=xen device name during machine init

2012-06-06 Thread Markus Armbruster
A "top" BlockDriverState has a non-empty device_name. If the user doesn't specify one with -drive parameter id, the system supplies a default name. xen_config_dev_blk() changes this name, during machine initialization. Naughty. Don't do that. Signed-off-by: Markus Armbruster --- hw/xen_devcon

[Qemu-devel] [PATCH v2 2/2] xen: Don't peek behind the BlockDriverState abstraction

2012-06-06 Thread Markus Armbruster
First offender is xen_config_dev_blk()'s use of disk->bdrv->filename. Get the filename from disk->opts instead. Same result, except for snapshots: there, we now get the filename specified by the user instead of the name of the temporary image created by bdrv_open(). Should be an improvement. Seco

[Qemu-devel] [PATCH v2 0/2] xen: Clean up BlockDriverState use

2012-06-06 Thread Markus Armbruster
Compile tested only. Stefano, please give it a whirl. v2: Moved a declaration to an inner block on Stefano's request. Markus Armbruster (2): xen: Don't change -drive if=xen device name during machine init xen: Don't peek behind the BlockDriverState abstraction hw/xen_devconfig.c | 13 +++

Re: [Qemu-devel] [PATCH 07/31] dt: add helper for phandle allocation

2012-06-06 Thread Scott Wood
On 06/06/2012 11:00 AM, Alexander Graf wrote: > On 06/06/2012 07:18 AM, Peter Crosthwaite wrote: >> On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote: >>> Phandle references work by having 2 pieces: >>> >>>- a "phandle" 1-cell property in the device tree node >>>- a reference to the s

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-06 Thread Paolo Bonzini
Il 06/06/2012 18:14, Michael Roth ha scritto: > uint64_t's > within the valid range for visit_type_uint64() will fail due to being > interpreted as < 0 when cast to int64_t. With the others we can detect > these cases since the max unsigned value doesn't exceed the max signed > value of the interme

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-06 Thread Max Filippov
Hi Jia, more comments on remaining issues visible with unaided eye. On Wed, Jun 6, 2012 at 4:27 PM, Jia Liu wrote: > Add OpenRISC translation routines. > > Signed-off-by: Jia Liu > --- [...] > +    case 0x0009: > +        switch (op1) { > +        case 0x03:   /*l.div*/ > +            LOG_DIS

  1   2   3   >