Re: [Qemu-devel] general question

2012-05-30 Thread Max Filippov
On Thu, May 31, 2012 at 6:39 AM, ���f任 (Wei-Ren Chen) wrote: > On Wed, May 30, 2012 at 11:09:23PM +0400, Max Filippov wrote: >> On Wed, May 30, 2012 at 5:19 PM, 吴晓琳 wrote: >> > >> > Hello, Does qemu support invlpg instruction? >> >> Yes, it does. You can grep target-i386/translate.c for the word

Re: [Qemu-devel] [PATCH] net: Include the peer's information in VLANClientState->info_str when using the udp socket backend.

2012-05-30 Thread Benjamin Epitech
It's a trivial patch, IIRC I should send it somewhere else, right? On Mon, May 7, 2012 at 12:21 AM, Benjamin MARSILI wrote: > > Signed-off-by: Benjamin MARSILI > --- > > It makes it easier to debug and figure out what's going on behind the > scene. > > When using this syntax: > -device DEVICE,ne

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc4 release

2012-05-30 Thread Stefan Weil
Am 31.05.2012 05:21, schrieb Anthony Liguori: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 1.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Evgeny Voevodin
On 31.05.2012 08:53, Anthony Liguori wrote: On 05/31/2012 12:06 PM, Evgeny Voevodin wrote: On 31.05.2012 03:02, Anthony Liguori wrote: On 05/31/2012 12:28 AM, Markus Armbruster wrote: Stefan Hajnoczi writes: On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: Ordinary device models hav

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Anthony Liguori
On 05/31/2012 12:06 PM, Evgeny Voevodin wrote: On 31.05.2012 03:02, Anthony Liguori wrote: On 05/31/2012 12:28 AM, Markus Armbruster wrote: Stefan Hajnoczi writes: On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: Ordinary device models have a single state struct. The first member is

[Qemu-devel] [Bug 1006702] [NEW] something wrong in function type_initialize() in object.c in the source code of qemu-1.1.0

2012-05-30 Thread zdguo
Public bug reported: In the function type_initialize() in file object.c, about line 237, the sentence : memset((void *)ti->class + class_size, 0, ti->class_size - class_size); after the if (type_has_parent(ti)){} will clean the information copied from the parent in the if block. I'm wond

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Evgeny Voevodin
On 31.05.2012 03:02, Anthony Liguori wrote: On 05/31/2012 12:28 AM, Markus Armbruster wrote: Stefan Hajnoczi writes: On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: Ordinary device models have a single state struct. The first member is a DeviceState or a specialization of DeviceStat

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Evgeny Voevodin
Oh, previous thread was with wrong address... try again here ) On 30.05.2012 20:28, Markus Armbruster wrote: Stefan Hajnoczi writes: On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: Ordinary device models have a single state struct. The first member is a DeviceState or a specializ

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Evgeny Voevodin
On 30.05.2012 20:05, Markus Armbruster wrote: Stefan Hajnoczi writes: On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: Ordinary device models have a single state struct. The first member is a DeviceState or a specialization of DeviceState, e.g. a PCIDevice. Simple enough. I think

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Evgeny Voevodin
On 30.05.2012 20:05, Markus Armbruster wrote: Stefan Hajnoczi writes: On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: Ordinary device models have a single state struct. The first member is a DeviceState or a specialization of DeviceState, e.g. a PCIDevice. Simple enough. I think

[Qemu-devel] [ANNOUNCE] QEMU 1.1-rc4 release

2012-05-30 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 1.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.1.0-rc4.tar.bz2 You can help im

Re: [Qemu-devel] general question

2012-05-30 Thread Wei-Ren Chen
On Wed, May 30, 2012 at 11:09:23PM +0400, Max Filippov wrote: > On Wed, May 30, 2012 at 5:19 PM, 吴晓琳 wrote: > > > > Hello, Does qemu support invlpg instruction? > > Yes, it does. You can grep target-i386/translate.c for the word > 'invlpg' to see how it is decoded > and see helper_invlpg functio

Re: [Qemu-devel] [PULL 0/5] Block patches for 1.1

2012-05-30 Thread Anthony Liguori
On 05/30/2012 09:37 PM, Kevin Wolf wrote: The following changes since commit e78bd5ab07d65fec77fcae468b2836c79a836d49: xhci: add usage info to docs (2012-05-30 10:28:44 +0800) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christian Borntraeger (1):

[Qemu-devel] Can't convert to vmdk with the streamOptimized subformat

2012-05-30 Thread Sebastien Douche
Hi all, I'm trying to convert a qcow2 image file to the vmdk (on Ubuntu Server 12.04): root@srv8:/srv/kvm/lib# qemu-img convert -f qcow2 -O vmdk -o Stream spv-2912.qcow2 spv-2912-3.vmdk -o subformat=streamOptimized VMDK: can't write to allocated cluster for streamOptimized qemu-img: error while wr

Re: [Qemu-devel] [PATCH] slirp: add 'cmd:' target for guestfwd

2012-05-30 Thread Anthony Liguori
On 05/31/2012 07:08 AM, Alexander Graf wrote: On 04.06.2011, at 08:12, Alexander Graf wrote: When using guestfwd=, Qemu only connects the virtual server's TCP port to a single chardev. This is useless in most cases, as we usually want to have more than a single connection from the guest to the

Re: [Qemu-devel] [PATCH] slirp: add 'cmd:' target for guestfwd

2012-05-30 Thread Alexander Graf
On 04.06.2011, at 08:12, Alexander Graf wrote: > When using guestfwd=, Qemu only connects the virtual server's TCP port > to a single chardev. This is useless in most cases, as we usually want > to have more than a single connection from the guest to the outside world. > > This patch adds a new

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Anthony Liguori
On 05/31/2012 12:28 AM, Markus Armbruster wrote: Stefan Hajnoczi writes: On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: Ordinary device models have a single state struct. The first member is a DeviceState or a specialization of DeviceState, e.g. a PCIDevice. Simple enough. I th

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-30 Thread Luigi Rizzo
On Thu, May 31, 2012 at 12:11 AM, Jan Kiszka wrote: > On 2012-05-30 23:55, Luigi Rizzo wrote: > > you can take the freebsd image from the netmap page in my link and run it > > in qemu, and then run the pkt-gen program in the image in either > > send or receive mode. But this is overkill, as you h

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-30 Thread Jan Kiszka
On 2012-05-30 23:55, Luigi Rizzo wrote: > you can take the freebsd image from the netmap page in my link and run it > in qemu, and then run the pkt-gen program in the image in either > send or receive mode. But this is overkill, as you have described the > problem exactly in your post: when the gue

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-30 Thread Luigi Rizzo
On Wed, May 30, 2012 at 11:39 PM, Jan Kiszka wrote: > Please keep CCs. > > ok > On 2012-05-30 23:23, Luigi Rizzo wrote: > >> On Wed, May 30, 2012 at 10:23:11PM +0200, Luigi Rizzo wrote: > > ... > >>> The problem was fixed by the following one-line addition to > >>> hw/e1000.c :: e1000_mmio_writ

Re: [Qemu-devel] [PATCH 06/10] qdev: generalize properties to Objects

2012-05-30 Thread Andreas Färber
Am 23.05.2012 17:44, schrieb Paolo Bonzini: > The property machinery uses DeviceState arguments in a few places. > Replace this with Object so that we can push properties up. > > Signed-off-by: Paolo Bonzini > --- > hw/qdev-addr.c | 19 +++--- > hw/qdev-properties.c | 180 > +++

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-30 Thread Jan Kiszka
Please keep CCs. On 2012-05-30 23:23, Luigi Rizzo wrote: >> On Wed, May 30, 2012 at 10:23:11PM +0200, Luigi Rizzo wrote: > ... >>> The problem was fixed by the following one-line addition to >>> hw/e1000.c :: e1000_mmio_write() , to wakeup the qemu mainloop and >>> check that some buffers might be

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Anthony Liguori
On 05/31/2012 01:35 AM, Alexander Graf wrote: On 30.05.2012, at 19:33, Alexander Graf wrote: On 30.05.2012, at 19:32, Blue Swirl wrote: On Wed, May 30, 2012 at 2:23 PM, Andreas Färber wrote: Hello Alex, Here's the mentioned version of your "qemu.areg0" repository (considered v3), includi

Re: [Qemu-devel] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Andreas Färber
Am 30.05.2012 19:32, schrieb Blue Swirl: > On Wed, May 30, 2012 at 2:23 PM, Andreas Färber wrote: >> Hello Alex, >> >> Here's the mentioned version of your "qemu.areg0" repository (considered v3), >> including your fixed-up version of Blue's AREG0 v2 conversion and François' >> ppc 440 TLB dump, r

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-30 Thread Luigi Rizzo
> On Wed, May 30, 2012 at 10:23:11PM +0200, Luigi Rizzo wrote: ... > > The problem was fixed by the following one-line addition to > > hw/e1000.c :: e1000_mmio_write() , to wakeup the qemu mainloop and > > check that some buffers might be available. > > > > --- hw/e1000.c.orig 2012-02-17 20:4

Re: [Qemu-devel] Keysymbol interpretation missing in QEMU's VNC server?

2012-05-30 Thread Erik Rull
Hi Fabian, Fabian Holler wrote: Howdy Erik, On Tue, May 29, 2012 at 09:22:02PM +0200, Erik Rull wrote: Fabian Holler wrote: I just want to route all keypresses to the guest without interfering with the native QEMU key layout. Is that possible? Yes, if you start kvm without the "-k" option a

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 10:23:16PM +0200, Jan Kiszka wrote: > On 2012-05-30 21:30, Michael S. Tsirkin wrote: > > On Wed, May 30, 2012 at 09:06:25PM +0200, Jan Kiszka wrote: > >> On 2012-05-30 20:51, Michael S. Tsirkin wrote: > >>> On Wed, May 30, 2012 at 09:29:13PM +0300, Michael S. Tsirkin wrote:

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-30 Thread Jan Kiszka
On 2012-05-30 22:23, Luigi Rizzo wrote: > Hi, > while testing qemu with netmap (see [Note 1] for details) on e1000 > emulation, i noticed that my sender program using a custom backend > [Note 2] could reach 1 Mpps (million packets per second) but on the > receive side i was limited to 50 Kpps (and

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 21:30, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 09:06:25PM +0200, Jan Kiszka wrote: >> On 2012-05-30 20:51, Michael S. Tsirkin wrote: >>> On Wed, May 30, 2012 at 09:29:13PM +0300, Michael S. Tsirkin wrote: On Wed, May 30, 2012 at 09:23:56PM +0300, Michael S. Tsirkin wr

[Qemu-devel] [Bug 712416] Re: kvm_intel kernel module crash with via nano vmx

2012-05-30 Thread Serge Hallyn
Retargetting at the kernel as this is a kernel bug. khetzal, can you confirm whether you are still having this bug? ** Package changed: kvm (Ubuntu) => linux (Ubuntu) ** Tags added: kernel-kvm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH 4/8] block: add mirror job

2012-05-30 Thread Jeff Cody
On 04/13/2012 12:23 PM, Paolo Bonzini wrote: > This patch adds the implementation of a new job that mirrors a disk to > a new image while letting the guest continue using the old image. > The target is treated as a "black box" and data is copied from the > source to the target in the background. >

[Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-30 Thread Luigi Rizzo
Hi, while testing qemu with netmap (see [Note 1] for details) on e1000 emulation, i noticed that my sender program using a custom backend [Note 2] could reach 1 Mpps (million packets per second) but on the receive side i was limited to 50 Kpps (and CPU always below 5%). The problem was fixed by th

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 09:06:25PM +0200, Jan Kiszka wrote: > On 2012-05-30 20:51, Michael S. Tsirkin wrote: > > On Wed, May 30, 2012 at 09:29:13PM +0300, Michael S. Tsirkin wrote: > >> On Wed, May 30, 2012 at 09:23:56PM +0300, Michael S. Tsirkin wrote: > >>> On Wed, May 30, 2012 at 07:57:04PM +020

Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event

2012-05-30 Thread Luiz Capitulino
On Mon, 21 May 2012 14:50:51 +0800 Wen Congyang wrote: > When the guest is panicked, it will write 0x1 to the port 0x505. So if > qemu reads 0x1 from this port, we can do the folloing three things > according to the parameter -onpanic: > 1. emit QEVENT_GUEST_PANICKED only > 2. emit QEVENT_GUEST_P

Re: [Qemu-devel] [PATCH 1/3] start vm after reseting it

2012-05-30 Thread Luiz Capitulino
On Mon, 21 May 2012 14:49:32 +0800 Wen Congyang wrote: > The guest should run after reseting it, but it does not > run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > Signed-off-by: Wen Congyang > --- > vl.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >

Re: [Qemu-devel] general question

2012-05-30 Thread Max Filippov
On Wed, May 30, 2012 at 5:19 PM, 吴晓琳 wrote: > > Hello, Does qemu support invlpg instruction? Yes, it does. You can grep target-i386/translate.c for the word 'invlpg' to see how it is decoded and see helper_invlpg function in the target-i386/op_helper.c to see how it is implemented. -- Thanks. -

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 20:51, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 09:29:13PM +0300, Michael S. Tsirkin wrote: >> On Wed, May 30, 2012 at 09:23:56PM +0300, Michael S. Tsirkin wrote: >>> On Wed, May 30, 2012 at 07:57:04PM +0200, Jan Kiszka wrote: On 2012-05-30 19:51, Jan Kiszka wrote: >>>

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 09:29:13PM +0300, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 09:23:56PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 30, 2012 at 07:57:04PM +0200, Jan Kiszka wrote: > > > On 2012-05-30 19:51, Jan Kiszka wrote: > > > >> Well, I'll stop ranting here. The patch th

Re: [Qemu-devel] [PATCH v2 3/3] Add rate limiting of RTC_CHANGE, BALLOON_CHANGE & WATCHDOG events

2012-05-30 Thread Luiz Capitulino
On Mon, 21 May 2012 17:59:53 +0100 "Daniel P. Berrange" wrote: > From: "Daniel P. Berrange" > > Allow certain event types to be rate limited to avoid flooding > monitor clients. The monitor_protocol_event() method is changed > such that instead of immediately emitting the event to Monitor > ins

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 09:23:56PM +0300, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 07:57:04PM +0200, Jan Kiszka wrote: > > On 2012-05-30 19:51, Jan Kiszka wrote: > > >> Well, I'll stop ranting here. The patch that I sent is not intrusive > > >> and simply gives you a simple way to imple

[Qemu-devel] ARM7TDMI support

2012-05-30 Thread Vinicius Sanches
Hello All, I'm a new dev/user of QEMU. I was wondering if it supports the ARM7TDMI/ARM7TDMI-S natively. Is that possible or do I have to apply some additional patch? I'm wondering it because of those differences related to Branch instructions and some missing instructions and coprocessors. Thanks

[Qemu-devel] general question

2012-05-30 Thread 吴晓琳
Hello,  Does qemu support invlpg instruction?

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 07:57:04PM +0200, Jan Kiszka wrote: > On 2012-05-30 19:51, Jan Kiszka wrote: > >> Well, I'll stop ranting here. The patch that I sent is not intrusive > >> and simply gives you a simple way to implement pci_device_get_host_irq, > >> also optimizing emulated devices somewhat

Re: [Qemu-devel] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Alexander Graf
On 30.05.2012, at 19:48, Blue Swirl wrote: > On Wed, May 30, 2012 at 5:33 PM, Alexander Graf wrote: >> >> On 30.05.2012, at 19:32, Blue Swirl wrote: >> >>> On Wed, May 30, 2012 at 2:23 PM, Andreas Färber wrote: Hello Alex, Here's the mentioned version of your "qemu.areg0" repo

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 19:51, Jan Kiszka wrote: >> Well, I'll stop ranting here. The patch that I sent is not intrusive >> and simply gives you a simple way to implement pci_device_get_host_irq, >> also optimizing emulated devices somewhat. So if you think you need >> pci_device_get_host_irq I think this

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 19:41, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 07:29:52PM +0200, Jan Kiszka wrote: >> On 2012-05-30 19:20, Michael S. Tsirkin wrote: >>> On Wed, May 30, 2012 at 06:46:03PM +0200, Jan Kiszka wrote: On 2012-05-30 18:17, Michael S. Tsirkin wrote: > On Wed, May 30, 20

Re: [Qemu-devel] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Blue Swirl
On Wed, May 30, 2012 at 5:33 PM, Alexander Graf wrote: > > On 30.05.2012, at 19:32, Blue Swirl wrote: > >> On Wed, May 30, 2012 at 2:23 PM, Andreas Färber wrote: >>> Hello Alex, >>> >>> Here's the mentioned version of your "qemu.areg0" repository (considered >>> v3), >>> including your fixed-up

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 07:29:52PM +0200, Jan Kiszka wrote: > On 2012-05-30 19:20, Michael S. Tsirkin wrote: > > On Wed, May 30, 2012 at 06:46:03PM +0200, Jan Kiszka wrote: > >> On 2012-05-30 18:17, Michael S. Tsirkin wrote: > >>> On Wed, May 30, 2012 at 05:47:45PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Alexander Graf
On 30.05.2012, at 19:33, Alexander Graf wrote: > > On 30.05.2012, at 19:32, Blue Swirl wrote: > >> On Wed, May 30, 2012 at 2:23 PM, Andreas Färber wrote: >>> Hello Alex, >>> >>> Here's the mentioned version of your "qemu.areg0" repository (considered >>> v3), >>> including your fixed-up vers

Re: [Qemu-devel] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Alexander Graf
On 30.05.2012, at 19:32, Blue Swirl wrote: > On Wed, May 30, 2012 at 2:23 PM, Andreas Färber wrote: >> Hello Alex, >> >> Here's the mentioned version of your "qemu.areg0" repository (considered v3), >> including your fixed-up version of Blue's AREG0 v2 conversion and François' >> ppc 440 TLB du

Re: [Qemu-devel] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Blue Swirl
On Wed, May 30, 2012 at 2:23 PM, Andreas Färber wrote: > Hello Alex, > > Here's the mentioned version of your "qemu.areg0" repository (considered v3), > including your fixed-up version of Blue's AREG0 v2 conversion and François' > ppc 440 TLB dump, rebased onto qom-next. Many thanks for rebasing.

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 19:20, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 06:46:03PM +0200, Jan Kiszka wrote: >> On 2012-05-30 18:17, Michael S. Tsirkin wrote: >>> On Wed, May 30, 2012 at 05:47:45PM +0200, Jan Kiszka wrote: On 2012-05-30 16:59, Michael S. Tsirkin wrote: > On Wed, May 30, 20

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 06:46:03PM +0200, Jan Kiszka wrote: > On 2012-05-30 18:17, Michael S. Tsirkin wrote: > > On Wed, May 30, 2012 at 05:47:45PM +0200, Jan Kiszka wrote: > >> On 2012-05-30 16:59, Michael S. Tsirkin wrote: > >>> On Wed, May 30, 2012 at 04:46:14PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-30 Thread Igor Mitsyanko
On 05/30/2012 08:19 PM, Igor Mammedov wrote: without assert it will crash at following point: OBJECT_CHECK(type, obj, name) \ ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) => object_dynamic_cast(obj, typename) => object_is_type(obj, target_type)

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-30 Thread Andreas Färber
Am 30.05.2012 09:53, schrieb Alexander Graf: > Mind to elaborate (in the patch description maybe) why we need a CPU specific > TLB flush callback that merely calls the globally visible tlb_flush? :) Ouch! That's one patch description I forgot to fill in. :-/ The issue is that env is defined in X

Re: [Qemu-devel] OpenBIOS for v1.1.0

2012-05-30 Thread Blue Swirl
On Wed, May 30, 2012 at 2:38 AM, Anthony Liguori wrote: > On 05/30/2012 06:28 AM, Peter Maydell wrote: >> >> On 29 May 2012 16:02, Andreas Färber  wrote: >>> >>> commit 7d21dcc84b8c07918124a9c0708694d2fb013f65 >>> updated the binaries to r1056 but did not update the submodule, so the >>> tarballs

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 18:17, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 05:47:45PM +0200, Jan Kiszka wrote: >> On 2012-05-30 16:59, Michael S. Tsirkin wrote: >>> On Wed, May 30, 2012 at 04:46:14PM +0200, Jan Kiszka wrote: On 2012-05-30 16:42, Michael S. Tsirkin wrote: > On Wed, May 30, 20

Re: [Qemu-devel] [PATCH v2 0/2] qmp: implement readline handlig for stdio

2012-05-30 Thread Luiz Capitulino
On Wed, 30 May 2012 18:01:06 +0200 Pavel Hrdina wrote: > For debug it would be nice to have a same functionality for the qmp monitor > on stdio as the hmp monitor on stdio has. For this purpose we also use > readline mode for qmp monitor on stdio. I dislike this series. It's adding a user featur

[Qemu-devel] [PATCH v4 17/23] ppc: Split off misc helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl Move misc helpers from op_helper.c to misc_helpers.c. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- Makefile.target |5 ++- target-ppc/misc_helper.c | 116 ++ target-ppc/op_

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-30 Thread Luiz Capitulino
On Wed, 30 May 2012 16:19:43 +0200 Kevin Wolf wrote: > Am 30.05.2012 12:01, schrieb Pavel Hrdina: > > For debug it would be nice to have a same functionality for the qmp monitor > > on stdio as the hmp monitor on stdio has. For this purpose we also use > > readline mode for qmp monitor on stdio.

[Qemu-devel] [PATCH v4 16/23] ppc: Avoid AREG0 for timebase helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl Add an explicit CPUPPCState parameter instead of relying on AREG0. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- Makefile.target |3 -- target-ppc/helper.h | 42

[Qemu-devel] [PATCH 08/14] console: vga_hw_screen_dump_ptr: take an Error argument

2012-05-30 Thread Luiz Capitulino
All devices that register a screen dump callback via graphic_console_init() are updated. The new argument is not used in this commit. Error handling will be added to each device individually by the next commits. This work is required by the future conversion of the screendump command to the QAPI.

[Qemu-devel] [PATCH v4 23/23] target-ppc: Some support for dumping TLB_EMB TLBs

2012-05-30 Thread Andreas Färber
From: François Revol Add mmubooke_dump_mmu(). TODO: Add printing of individual flags. Signed-off-by: François Revol [agraf: fix coding style] Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- target-ppc/mmu_helper.c | 50 +++ 1 fil

[Qemu-devel] [PATCH v4 09/23] ppc: Avoid AREG0 for integer and vector helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl Add an explicit CPUPPCState parameter instead of relying on AREG0. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- Makefile.target |4 +- target-ppc/helper.h | 176 +++--- targ

[Qemu-devel] [PATCH v2 1/2] qmp: use readline mode for stdio

2012-05-30 Thread Pavel Hrdina
Instead of using an echo for '-qmp stdio' we use a readline mode. The readline mode adds a history for users which is useful. Tab completion is disabled for now. Signed-off-by: Pavel Hrdina --- monitor.c | 92 + vl.c |3 ++

[Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-30 Thread Luiz Capitulino
New errors for write() and open() failures. Will be used by the next commits. Signed-off-by: Luiz Capitulino --- qerror.c | 28 qerror.h | 21 + 2 files changed, 49 insertions(+) diff --git a/qerror.c b/qerror.c index 6c78759..97670a3 100644 ---

[Qemu-devel] [PATCH v4 18/23] ppc: Avoid AREG0 for misc helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl Add an explicit CPUPPCState parameter instead of relying on AREG0. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- Makefile.target |3 --- target-ppc/helper.h | 18 +- target-ppc/misc_helper.

[Qemu-devel] [PATCH v4 04/23] ppc: Fix coding style in helper.c

2012-05-30 Thread Andreas Färber
From: Blue Swirl helper.c will be spilt by the next patches, fix style issues before that. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- target-ppc/helper.c | 394 ++- 1 files changed, 230 insertions

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: >> Ordinary device models have a single state struct.  The first member is >> a DeviceState or a specialization of DeviceState, e.g. a PCIDevice. >> Simple enough. > > I think Evgeny's virtio mmio patches change

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Markus Armbruster
Fat-fingered Evgeny's address, let me try again.

[Qemu-devel] [PATCH v4 15/23] ppc: Split off timebase helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl Move decrementer and timebase helpers to a dedicated file. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- Makefile.target |4 + target-ppc/op_helper.c | 135 --- target-ppc/tim

[Qemu-devel] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Andreas Färber
Hello Alex, Here's the mentioned version of your "qemu.areg0" repository (considered v3), including your fixed-up version of Blue's AREG0 v2 conversion and François' ppc 440 TLB dump, rebased onto qom-next. Conflicts were removal of cpu_state_reset() and change of cpu_ppc_init() return type on qo

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-30 Thread Andreas Färber
Am 30.05.2012 18:19, schrieb Igor Mammedov: > without assert it will crash at following point: >OBJECT_CHECK(type, obj, name) \ > ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) > => object_dynamic_cast(obj, typename) > => object_is_type(obj, target_type) >

[Qemu-devel] [PATCH v4 12/23] ppc: Avoid a warning with the next patch

2012-05-30 Thread Andreas Färber
From: Blue Swirl When the code is moved together by the next patch, compiler detects a possible uninitialized variable use. Avoid the warning by initializing the variables. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- target-ppc/mmu_helper.c |

Re: [Qemu-devel] [RFC next] ui: Split main() in two to not have Cocoa hijack it

2012-05-30 Thread Andreas Färber
Am 30.05.2012 11:00, schrieb Paolo Bonzini: > Il 28/05/2012 20:18, Andreas Färber ha scritto: >> Only call into cocoa.m when determined necessary by QEMU's option >> handling. Avoids redoing all option parsing in ui/cocoa.m:main() >> and constantly missing new options like -machine accel=qtest. >>

[Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-30 Thread Igor Mammedov
without assert it will crash at following point: OBJECT_CHECK(type, obj, name) \ ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) => object_dynamic_cast(obj, typename) => object_is_type(obj, target_type) => type_is_ancestor(obj->class->type, target_type);

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 05:47:45PM +0200, Jan Kiszka wrote: > On 2012-05-30 16:59, Michael S. Tsirkin wrote: > > On Wed, May 30, 2012 at 04:46:14PM +0200, Jan Kiszka wrote: > >> On 2012-05-30 16:42, Michael S. Tsirkin wrote: > >>> On Wed, May 30, 2012 at 04:38:25PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 1/1] Fix "strcpy" calls

2012-05-30 Thread Crístian Viana
On 30-05-2012 02:41, Peter Maydell wrote: Nak. This is duplicating a much better patchset from Jim Meyering: http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg01151.html -- PMM Sorry, I hadn't seen his patchset. Is it OK for me to proceed with a similar patch regarding the function "str

Re: [Qemu-devel] [RFC next] ui: Split main() in two to not have Cocoa hijack it

2012-05-30 Thread Andreas Färber
Am 30.05.2012 09:11, schrieb Anthony Liguori: > On 05/29/2012 02:18 AM, Andreas Färber wrote: >> Only call into cocoa.m when determined necessary by QEMU's option >> handling. Avoids redoing all option parsing in ui/cocoa.m:main() >> and constantly missing new options like -machine accel=qtest. >>

[Qemu-devel] [PATCH v4 20/23] ppc: Move load and store helpers, switch to AREG0 free mode

2012-05-30 Thread Andreas Färber
From: Blue Swirl Add an explicit CPUPPCState parameter instead of relying on AREG0 and rename op_helper.c (which only contains load and store helpers) to mem_helper.c. Remove AREG0 swapping in tlb_fill(). Switch to AREG0 free mode. Use cpu_ld{l,uw}_code in translation and interrupt handling, cpu

Re: [Qemu-devel] [PATCH qom-next 07/12] target-i386: move cpu halted decision into x86_cpu_reset

2012-05-30 Thread Igor Mammedov
On 05/30/2012 02:11 PM, Andreas Färber wrote: Am 30.05.2012 00:10, schrieb Igor Mammedov: From: Igor Mammedov MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However ther

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster wrote: >> Ordinary device models have a single state struct.  The first member is >> a DeviceState or a specialization of DeviceState, e.g. a PCIDevice. >> Simple enough. > > I think Evgeny's virtio mmio patches change

[Qemu-devel] [PATCH 10/14] omap_lcdc: omap_ppm_save(): add error handling

2012-05-30 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]->hw_screen_dump() with errp=NULL. The error will be propa

[Qemu-devel] [PATCH v2 0/2] qmp: implement readline handlig for stdio

2012-05-30 Thread Pavel Hrdina
For debug it would be nice to have a same functionality for the qmp monitor on stdio as the hmp monitor on stdio has. For this purpose we also use readline mode for qmp monitor on stdio. Because we don't need anymore an echo function for stdio, there is also revert of a commit, which added this f

[Qemu-devel] [PATCH v2 2/2] qmp: revert "add set_echo implementation for qemu_chr_stdio"

2012-05-30 Thread Pavel Hrdina
This reverts commit bb002513a9bd2bff169c3d431a8f00c5b2e3aa99 because this code is not used in order that we use readline mode for '-qmp stdio'. Signed-off-by: Pavel Hrdina --- qemu-char.c | 26 ++ 1 files changed, 10 insertions(+), 16 deletions(-) diff --git a/qemu-ch

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-30 Thread Pavel Hrdina
On 05/30/2012 04:19 PM, Kevin Wolf wrote: Am 30.05.2012 12:01, schrieb Pavel Hrdina: For debug it would be nice to have a same functionality for the qmp monitor on stdio as the hmp monitor on stdio has. For this purpose we also use readline mode for qmp monitor on stdio. Because we don't need a

[Qemu-devel] [PATCH 13/14] tcx: tcx_screen_dump(): add error handling

2012-05-30 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]->hw_screen_dump() with errp=NULL. The error will be propa

Re: [Qemu-devel] [PATCHv2 03/22] block: avoid buffer overrun by using pstrcpy, not strncpy

2012-05-30 Thread Jim Meyering
Stefan Weil wrote: > Am 30.05.2012 09:46, schrieb Jim Meyering: >> From: Jim Meyering >> >> Also, use PATH_MAX, rather than the arbitrary 1024. >> Using PATH_MAX is more consistent with other filename-related >> variables in this file, like backing_filename and tmp_filename. >> >> Acked-by: Kevin W

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-30 Thread Luiz Capitulino
On Wed, 30 May 2012 18:17:54 +0800 Amos Kong wrote: > On 29/05/12 21:24, Luiz Capitulino wrote: > > On Tue, 29 May 2012 20:17:53 +0800 > > Amos Kong wrote: > > > >> On 05/29/2012 07:57 PM, Amos Kong wrote: > >>> On 05/25/2012 09:14 PM, Anthony Liguori wrote: > On 05/24/2012 10:51 PM, Eric B

[Qemu-devel] [PATCH v4 19/23] ppc: Move misc helpers from helper.c to misc_helper.c

2012-05-30 Thread Andreas Färber
From: Blue Swirl Move more misc helpers from helper.c to misc_helper.c. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- target-ppc/helper.c |9 - target-ppc/misc_helper.c |9 + 2 files changed, 9 insertions(+), 9 deletion

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 16:59, Michael S. Tsirkin wrote: > On Wed, May 30, 2012 at 04:46:14PM +0200, Jan Kiszka wrote: >> On 2012-05-30 16:42, Michael S. Tsirkin wrote: >>> On Wed, May 30, 2012 at 04:38:25PM +0200, Jan Kiszka wrote: On 2012-05-30 15:34, Michael S. Tsirkin wrote: > Below's as far as

[Qemu-devel] [PATCH 07/14] omap_lcdc: rename ppm_save() to omap_ppm_save()

2012-05-30 Thread Luiz Capitulino
Avoids confusion with the global ppm_save() defined in hw/vga.c. Signed-off-by: Luiz Capitulino --- hw/omap_lcdc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/omap_lcdc.c b/hw/omap_lcdc.c index 4a08e9d..6d2e83a 100644 --- a/hw/omap_lcdc.c +++ b/hw/omap_lcdc.

[Qemu-devel] [PATCH v4 21/23] ppc: Add missing break

2012-05-30 Thread Andreas Färber
From: Blue Swirl Add obviously missing 'break' statement. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- target-ppc/fpu_helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper

Re: [Qemu-devel] [PATCHv2 03/22] block: avoid buffer overrun by using pstrcpy, not strncpy

2012-05-30 Thread Stefan Weil
Am 30.05.2012 09:46, schrieb Jim Meyering: From: Jim Meyering Also, use PATH_MAX, rather than the arbitrary 1024. Using PATH_MAX is more consistent with other filename-related variables in this file, like backing_filename and tmp_filename. Acked-by: Kevin Wolf Signed-off-by: Jim Meyering ---

[Qemu-devel] [PATCH v4 14/23] ppc: Cleanup MMU merge

2012-05-30 Thread Andreas Färber
From: Blue Swirl Remove useless wrappers. In some cases 'int' parameters are changed to uint32_t. Make internal functions static. Signed-off-by: Blue Swirl [agraf: fix kvm compilation] Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- target-ppc/cpu.h| 21 t

Re: [Qemu-devel] [PATCH qom-next 01/12] store prev_debug_excp_handler globaly and not per target

2012-05-30 Thread Igor Mammedov
On 05/30/2012 05:07 PM, Jan Kiszka wrote: On 2012-05-30 15:35, Igor Mammedov wrote: On 05/30/2012 12:51 PM, Jan Kiszka wrote: On 2012-05-30 00:10, Igor Mammedov wrote: current callers all do the same thing, storing in prev_debug_excp_handler previous handler and then calling it in breakpoint_h

[Qemu-devel] [PATCH 03/14] cutils: introduce qemu_fopen_err()

2012-05-30 Thread Luiz Capitulino
A fopen() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino --- cutils.c | 45 + qemu-common.h | 3 +++ 2 files changed, 48 insertions(+) diff --git a/cutils.c b/cutils.c index af308cd..85dbb06 100644 --- a/cutils.c +++ b/cuti

Re: [Qemu-devel] [PATCH qom-next 08/12] target-i386: introduce cpu-model property for x86_cpu

2012-05-30 Thread Andreas Färber
Am 30.05.2012 00:10, schrieb Igor Mammedov: > it's probably intermidiate step till cpu modeled as > sub-classes. After then we probably could drop it. > > However it still could be used for overiding default > cpu subclasses definition, and probably renamed to > something like 'features'. > > v2:

Re: [Qemu-devel] [PATCH qom-next 07/12] target-i386: move cpu halted decision into x86_cpu_reset

2012-05-30 Thread Igor Mammedov
On 05/30/2012 04:54 PM, Andreas Färber wrote: Am 30.05.2012 16:13, schrieb Igor Mammedov: On 05/30/2012 02:11 PM, Andreas Färber wrote: Am 30.05.2012 00:10, schrieb Igor Mammedov: From: Igor Mammedov MP initialization protocol differs between cpu families, and for P6 and onward models it is u

[Qemu-devel] [PATCH v4 10/23] ppc: Split MMU etc. helpers from op_helper.c

2012-05-30 Thread Andreas Färber
From: Blue Swirl Move MMU, TLB, SLB and BAT ops to mmu_helper.c. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf Signed-off-by: Andreas Färber --- Makefile.target |5 +- target-ppc/mmu_helper.c | 882 +++ target-ppc/op_helper.c

  1   2   3   >