Re: [Qemu-devel] [QEMU 1.1 PATCH v3] Expose CPUID leaf 7 only for -cpu host

2012-05-29 Thread Anthony Liguori
On 05/21/2012 10:27 PM, Eduardo Habkost wrote: Changes v2 -> v3; - Check for kvm_enabled() before setting cpuid_7_0_ebx_features Changes v1 -> v2: - Use kvm_arch_get_supported_cpuid() instead of host_cpuid() on cpu_x86_fill_host(). We should use GET_SUPPORTED_CPUID for all bits

Re: [Qemu-devel] [PATCH 1.1] xhci: add usage info to docs

2012-05-29 Thread Anthony Liguori
On 05/29/2012 05:20 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori --- docs/usb2.txt | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/docs/usb2.txt b/docs/usb2.txt index 228aa33..d17e3c0 100644 --- a

Re: [Qemu-devel] [RESEND PATCH 1.1] vnc: fix segfault in vnc_display_pw_expire()

2012-05-29 Thread Anthony Liguori
On 05/24/2012 04:55 PM, Gerd Hoffmann wrote: NULL pointer dereference in case no vnc server is configured. Catch this and return -EINVAL like vnc_display_password() does. Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori --- ui/vnc.c |4 1 files changed, 4

Re: [Qemu-devel] [PATCH v3] Prevent disk data loss when closing qemu

2012-05-29 Thread Pavel Dovgaluk
> From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Wednesday, May 30, 2012 6:29 AM > On 05/29/2012 09:26 PM, Pavel Dovgaluk wrote: > > Prevent disk data loss when closing qemu console window > > under Windows 7. > > > > v3. Comment for Sleep() parameter was updated. > > > > Signed-off-b

[Qemu-devel] [PATCH v3] Prevent disk data loss when closing qemu

2012-05-29 Thread Pavel Dovgaluk
Prevent disk data loss when closing qemu console window under Windows 7. v3. Comment for Sleep() parameter was updated. Signed-off-by: Pavel Dovgalyuk --- os-win32.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/os-win32.c b/os-win32.c index ad76370..13892ba 100

Re: [Qemu-devel] [PATCH 1/1] Fix "strcpy" calls

2012-05-29 Thread Peter Maydell
On 30 May 2012 05:59, Crístian Viana wrote: > Replace some "strcpy" and "strncpy" calls by "pstrcpy" because the former ones > may cause buffer overflow and may also not write a null-terminating character > at > the end of the resulting string > > Signed-off-by: Crístian Viana Nak. This is dupl

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-05-29 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 10:13:07AM +0800, Anthony Liguori wrote: > On 05/20/2012 05:57 PM, Amos Kong wrote: > >Start VM with 8 multiple-function block devs, hot-removing > >those block devs by 'device_del ...' would cause qemu abort. > > > >| (qemu) device_del virti0-0-0 > >| (qemu) ** > >|ERROR:qo

[Qemu-devel] [PATCH 1/1] Fix "strcpy" calls

2012-05-29 Thread Crístian Viana
Replace some "strcpy" and "strncpy" calls by "pstrcpy" because the former ones may cause buffer overflow and may also not write a null-terminating character at the end of the resulting string Signed-off-by: Crístian Viana --- According to the file HACKING, the functions "strcpy" and "strncpy" sho

Re: [Qemu-devel] [PATCH 1/1 v5] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-29 Thread Peter Maydell
On 30 May 2012 04:57, 陳韋任 (Wei-Ren Chen) wrote: > On Wed, May 30, 2012 at 04:54:26AM +0100, Peter Maydell wrote: >> On 30 May 2012 04:51, 陳韋任 (Wei-Ren Chen) wrote: >> >> diff --git a/hw/bt-sdp.c b/hw/bt-sdp.c >> >> index 3e390ab..c0431d1 100644 >> >> --- a/hw/bt-sdp.c >> >> +++ b/hw/bt-sdp.c >> >

Re: [Qemu-devel] [PATCH 1/1 v5] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-29 Thread Wei-Ren Chen
On Wed, May 30, 2012 at 04:54:26AM +0100, Peter Maydell wrote: > On 30 May 2012 04:51, 陳韋任 (Wei-Ren Chen) wrote: > >> diff --git a/hw/bt-sdp.c b/hw/bt-sdp.c > >> index 3e390ab..c0431d1 100644 > >> --- a/hw/bt-sdp.c > >> +++ b/hw/bt-sdp.c > >> @@ -834,7 +834,7 @@ SERVICE(hid, > >>      ATTRIBUTE(DO

Re: [Qemu-devel] [PATCH 1/1 v5] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-29 Thread Peter Maydell
On 30 May 2012 04:51, 陳韋任 (Wei-Ren Chen) wrote: >> diff --git a/hw/bt-sdp.c b/hw/bt-sdp.c >> index 3e390ab..c0431d1 100644 >> --- a/hw/bt-sdp.c >> +++ b/hw/bt-sdp.c >> @@ -834,7 +834,7 @@ SERVICE(hid, >>      ATTRIBUTE(DOC_URL,         URL("http://bellard.org/qemu/user-doc.html";)) > >  I know it'

Re: [Qemu-devel] [PATCH 1/1 v5] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-29 Thread Wei-Ren Chen
> diff --git a/hw/bt-sdp.c b/hw/bt-sdp.c > index 3e390ab..c0431d1 100644 > --- a/hw/bt-sdp.c > +++ b/hw/bt-sdp.c > @@ -834,7 +834,7 @@ SERVICE(hid, > ATTRIBUTE(DOC_URL, URL("http://bellard.org/qemu/user-doc.html";)) I know it's not relate to this patch, but the above link seems not

[Qemu-devel] [PATCH 1/1 v5] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-29 Thread Crístian Viana
QEMU exposes its version to the guest's hardware and in some cases that is wrong (e.g. Windows prints messages about driver updates when you switch the QEMU version). There is a new field now on the struct QEmuMachine, hw_version, which may contain the version that the specific machine should repor

[Qemu-devel] [PATCH 1/2] qemu-ga: Fix use of environ on Darwin

2012-05-29 Thread Michael Roth
From: Andreas Färber Use _NSGetEnviron() helper to access the environment. Signed-off-by: Andreas Färber Cc: Charlie Somerville Signed-off-by: Michael Roth --- qga/commands-posix.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/command

[Qemu-devel] [PATCH 2/2] qemu-ga: avoid blocking on atime update when reading /etc/mtab

2012-05-29 Thread Michael Roth
Currently we re-read/re-process /etc/mtab to get an updated list of mounts when guest-fsfreeze-thaw is called. This can cause an atime update on /etc/mtab, which will block if we're in a frozen state. Instead, use /proc's version of mtab, which may not be up-to-date with options passed via -o remo

[Qemu-devel] [PULL 1.1] qemu-ga build/fsfreeze fixes v2

2012-05-29 Thread Michael Roth
The following changes since commit 1c4ad9d2b4b5f2be08588a91e4193d13cc314282: Merge remote-tracking branch 'afaerber-or/cocoa-for-upstream' into staging (2012-05-29 06:54:16 -0500) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-5-29-12-v2 Andreas Färber (1

Re: [Qemu-devel] [PULL 1.1] qemu-ga build fix for OpenBSD

2012-05-29 Thread Michael Roth
On Wed, May 30, 2012 at 10:37:09AM +0800, Anthony Liguori wrote: > On 05/30/2012 09:54 AM, Michael Roth wrote: > >On Tue, May 29, 2012 at 08:25:54PM -0500, Anthony Liguori wrote: > >>On 05/29/2012 10:30 AM, Michael Roth wrote: > >>>On Thu, May 24, 2012 at 01:52:39PM -0500, Michael Roth wrote: > >>>

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Anthony Liguori
On 05/30/2012 05:07 AM, Paolo Bonzini wrote: Il 29/05/2012 19:09, Stefan Weil ha scritto: Am 29.05.2012 15:35, schrieb Stefano Stabellini: qemu_rearm_alarm_timer partially duplicates the code in qemu_next_alarm_deadline to figure out if it needs to rearm the timer. If it calls qemu_next_alarm_d

Re: [Qemu-devel] OpenBIOS for v1.1.0

2012-05-29 Thread Anthony Liguori
On 05/30/2012 06:28 AM, Peter Maydell wrote: On 29 May 2012 16:02, Andreas Färber wrote: commit 7d21dcc84b8c07918124a9c0708694d2fb013f65 updated the binaries to r1056 but did not update the submodule, so the tarballs are shipping old sources. ...I wonder if it would be possible to write a git

Re: [Qemu-devel] [PULL 1.1] qemu-ga build fix for OpenBSD

2012-05-29 Thread Anthony Liguori
On 05/30/2012 09:54 AM, Michael Roth wrote: On Tue, May 29, 2012 at 08:25:54PM -0500, Anthony Liguori wrote: On 05/29/2012 10:30 AM, Michael Roth wrote: On Thu, May 24, 2012 at 01:52:39PM -0500, Michael Roth wrote: The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d:

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc3 release

2012-05-29 Thread Anthony Liguori
On 05/22/2012 11:09 PM, Jan Kiszka wrote: On 2012-05-22 11:32, Anthony Liguori wrote: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 1.1 release. This release is meant for testing purposes and should not be used in a production

Re: [Qemu-devel] [PATCH v3] Prevent disk data loss when closing qemu

2012-05-29 Thread Anthony Liguori
On 05/29/2012 09:26 PM, Pavel Dovgaluk wrote: Prevent disk data loss when closing qemu console window under Windows 7. v3. Comment for Sleep() parameter was updated. Signed-off-by: Pavel Dovgalyuk --- os-win32.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/os

Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts

2012-05-29 Thread Anthony Liguori
On 05/28/2012 08:39 PM, Stefan Hajnoczi wrote: On Wed, May 23, 2012 at 5:03 PM, Stefan Weil wrote: Am 23.05.2012 17:32, schrieb Kevin Wolf: Maybe, but I already had patches rejected because of that style. Did this policy change? I'd appreciate that! Agreed, people have been asked to declare

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-29 Thread Wei-Ren Chen
> > Is goldfish still a relevant Android dev platform? In other words - > > would goldfish be useful to Android developers or just cool for QEMU > > hackers and "old-school" Android enthusiasts? > > It's still the base of the emulator you get with current SDKs. > > FWIW, latest AOSP (today's git

Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()

2012-05-29 Thread Anthony Liguori
On 05/20/2012 05:57 PM, Amos Kong wrote: Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would cause qemu abort. | (qemu) device_del virti0-0-0 | (qemu) ** |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0) It's a regression

Re: [Qemu-devel] [PATCH] vga: fix vram double-mapping with -vga std and -M pc-0.12

2012-05-29 Thread Anthony Liguori
On 05/09/2012 11:23 PM, Avi Kivity wrote: With pc-0.12, we map the video RAM both through the PCI BAR (the guest does this) and through a fixed mapping at 0xe000. The memory API doesn't allow this double map, and aborts. Fix by using an alias. Reported-by: Michael Tokarev Signed-off-by: Av

Re: [Qemu-devel] [PATCH] fix multiboot loading if load_end_addr == 0

2012-05-29 Thread Anthony Liguori
On 03/27/2012 03:27 AM, Scott Moser wrote: The previous multiboot load code did not treat the case where load_end_addr was 0 specially. The multiboot specification says the following: * load_end_addr Contains the physical address of the end of the data segment. (load_end_addr - load_ad

Re: [Qemu-devel] [PATCH 1/3 v9] add-cow file format

2012-05-29 Thread Anthony Liguori
On 05/08/2012 01:34 AM, Dong Xu Wang wrote: Provide a new file format: add-cow. The usage can be found in add-cow.txt of this patch. CC: Kevin Wolf CC: Stefan Hajnoczi Signed-off-by: Dong Xu Wang You should split out the spec to be the first patch. That makes it easier for people to review t

Re: [Qemu-devel] [PULL 1.1] qemu-ga build fix for OpenBSD

2012-05-29 Thread Michael Roth
On Tue, May 29, 2012 at 08:25:54PM -0500, Anthony Liguori wrote: > On 05/29/2012 10:30 AM, Michael Roth wrote: > >On Thu, May 24, 2012 at 01:52:39PM -0500, Michael Roth wrote: > >>The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d: > >> > >> audio: Always call fini on exi

Re: [Qemu-devel] [PATCH 1/3 v9] add-cow file format

2012-05-29 Thread Dong Xu Wang
On Tue, May 29, 2012 at 11:50 PM, Stefan Hajnoczi wrote: >> +    image_sectors = image_bs->total_sectors; > > Please use bdrv_getlength() instead of accessing total_sectors directly. > >> +    image_drv = bdrv_find_format("raw"); >> +    ret = bdrv_open(s->image_hd, image_filename, flags, image_dr

Re: [Qemu-devel] [PULL 1.1] Xen fixes for 1.1-rc3

2012-05-29 Thread Anthony Liguori
On 05/17/2012 11:52 AM, Stefano Stabellini wrote: Hi Anthony, please pull: git://xenbits.xen.org/people/sstabellini/qemu-dm.git for_1.1_rc3 Pulled. Thanks. Regards, Anthony Liguori Anthony PERARD (1): xen: Fix PV-on-HVM Jan Beulich (1): xen_disk: properly update stats in

Re: [Qemu-devel] [PULL 00/10] Block patches for 1.1

2012-05-29 Thread Anthony Liguori
On 05/25/2012 12:38 PM, Kevin Wolf wrote: The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d: audio: Always call fini on exit (2012-05-24 19:35:27 +0400) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at: git://repo.or.cz/qemu/

Re: [Qemu-devel] [PULL] slirp: Various build fixes

2012-05-29 Thread Anthony Liguori
On 05/29/2012 02:39 AM, Jan Kiszka wrote: The following changes since commit 24f50d7ea5896a30b0e78f68884586bb8b40ff97: tcg/ppc: Handle _CALL_DARWIN being undefined on Darwin (2012-05-27 21:52:56 +0400) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp P

Re: [Qemu-devel] [PULL 0/6] updated SCSI changes for 1.1.0-rc4

2012-05-29 Thread Anthony Liguori
On 05/29/2012 04:20 AM, Paolo Bonzini wrote: The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d: audio: Always call fini on exit (2012-05-24 19:35:27 +0400) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch chan

Re: [Qemu-devel] [PULL 1.1 0/2] SCSI patches for 1.1.0-rc3

2012-05-29 Thread Anthony Liguori
On 05/22/2012 07:25 AM, Paolo Bonzini wrote: The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45: Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at: git://github.com/bonzi

Re: [Qemu-devel] [PULL 1.1] qemu-ga build fix for OpenBSD

2012-05-29 Thread Anthony Liguori
On 05/29/2012 10:30 AM, Michael Roth wrote: On Thu, May 24, 2012 at 01:52:39PM -0500, Michael Roth wrote: The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d: audio: Always call fini on exit (2012-05-24 19:35:27 +0400) are available in the git repository at: git:/

Re: [Qemu-devel] [PULL 1.1] Cocoa patch queue for v1.1 2012-05-29

2012-05-29 Thread Anthony Liguori
On 05/29/2012 04:59 AM, Andreas Färber wrote: Hello Anthony, Please pull the Cocoa queue into qemu.git master: Pulled. Thanks. Regards, Anthony Liguori One general build fix for Darwin/ppc, one behavioral fix for make check with Cocoa. The following changes since commit 24f50d7ea5896a30

Re: [Qemu-devel] ARM: Virtual / Physical address translation

2012-05-29 Thread Peter Maydell
On 30 May 2012 02:00, Ira Ray Jenkins wrote: > What I would like is to be able to get the physical addresses of both > data and instructions. Can anyone help me work through how to get the > properly translated physical addresses given the virtual address? See the function get_phys_addr() in targ

Re: [Qemu-devel] [PATCH, repost 2] qemu-keymaps: Finnish keyboard mapping broken

2012-05-29 Thread Anthony Liguori
On 05/09/2012 03:31 PM, Michael Tokarev wrote: As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping is kind of broken. Fix it as Timo Sirainen suggests in #660154. Signed-off-By: Michael Tokarev index 2a4e0f0..4be7586 100644 Please post patches with git-send-email. Regar

[Qemu-devel] ARM: Virtual / Physical address translation

2012-05-29 Thread Ira Ray Jenkins
I am working on a qemu modification that would output memory traces in a format acceptable to Dinero IV. I've seen some previous proto-type work done on this with mips and x86, but I am specifically interested in arm. Currently, I am able to dump the virtual address of all ld/st instructions. I bel

Re: [Qemu-devel] [PATCH v2 01/17] Openrisc: add target stubs

2012-05-29 Thread Jia Liu
Hi Andreas, On Sun, May 27, 2012 at 8:44 PM, Andreas Färber wrote: > Am 27.05.2012 07:32, schrieb Jia Liu: >> add openrisc target stubs. >> >> Signed-off-by: Jia Liu > > Minor nitpick: I'd recommend to stick to the typographic conventions > outlined here: > https://live.gnome.org/Git/CommitMessa

[Qemu-devel] [PATCH 1.1 v2] sheepdog: add coroutine_fn markers to coroutine functions

2012-05-29 Thread MORITA Kazutaka
Signed-off-by: MORITA Kazutaka --- Changes from v1: - use spaces for indentation block/sheepdog.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index f46ca8f..8877f45 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@

Re: [Qemu-devel] [PATCH 1.1] sheepdog: add coroutine_fn markers to coroutine functions

2012-05-29 Thread MORITA Kazutaka
At Tue, 29 May 2012 18:30:17 +0200, Andreas Färber wrote: > > Am 29.05.2012 18:22, schrieb MORITA Kazutaka: > > Signed-off-by: MORITA Kazutaka > > Patch is tab-damaged. Oops, I'll send a new version. Thanks, Kazutaka > > Andreas > > > --- > > block/sheepdog.c |9 + > > 1 file

[Qemu-devel] [Bug 688052] Re: usb does not work 0.13.0

2012-05-29 Thread Jan Matejka
the correct syntax is -usb -device usb-host,vendorid=x,productid=y -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/688052 Title: usb does not work 0.13.0 Status in QEMU: New Bug description: Hi

[Qemu-devel] [Bug 688052] Re: usb does not work 0.13.0

2012-05-29 Thread Jan Matejka
at leats on my app-emulation/qemu-kvm-1.0-r2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/688052 Title: usb does not work 0.13.0 Status in QEMU: New Bug description: Hi all, I'm using both,

[Qemu-devel] [PATCH qom-next 03/12] target-i386: use global prev_debug_excp_handler instead of local one

2012-05-29 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/helper.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 2cc8097..da6f850 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -941,8 +941,6 @@ int check_hw_break

[Qemu-devel] [PATCH qom-next v3 0/12] target-i386: re-factor CPU creation/initialization to QOM

2012-05-29 Thread Igor Mammedov
Moving code related to CPU creation and initialization internal parts from board level into apic and cpu objects will allow X86CPU to better model QOM object life-cycle. It will allow to create X86CPU as any other object by creating it with object_new() then setting properties and then calling x86_

[Qemu-devel] [PATCH qom-next 12/12] target-i386: move reset callback to cpu.c and call cpu_reset() in x86_cpu_realize()

2012-05-29 Thread Igor Mammedov
Moving reset callback into cpu object from board level and resetting cpu at the end of x86_cpu_realize() will allow properly create cpu object during run-time (hotplug). When reset over QOM hierarchy is implemented, reset callback should be removed. Additionally, there is only call to cpu_x86_ini

[Qemu-devel] [PATCH qom-next 10/12] pc: Enable MSI support at APIC level

2012-05-29 Thread Igor Mammedov
From: Jan Kiszka Push msi_supported enabling to the APIC implementations where we can encapsulate the decision more cleanly, hiding the details from the generic code. Acked-by: Stefano Stabellini Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/apic.c |3 +++ hw/pc.c

[Qemu-devel] [PATCH qom-next 05/12] pc: Add CPU as /machine/cpu[n]

2012-05-29 Thread Igor Mammedov
From: Andreas Färber Using the cpu_index, give the X86CPU a canonical path. This must be done before initializing the APIC. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/pc.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/

[Qemu-devel] [PATCH qom-next 07/12] target-i386: move cpu halted decision into x86_cpu_reset

2012-05-29 Thread Igor Mammedov
From: Igor Mammedov MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in implementing MP initialization protocol in qemu. Thus first CPU is always m

[Qemu-devel] [PATCH qom-next 02/12] target-xtensa: use global prev_debug_excp_handler instead of local one

2012-05-29 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-xtensa/helper.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/target-xtensa/helper.c b/target-xtensa/helper.c index 5e7e72e..e2ab83c 100644 --- a/target-xtensa/helper.c +++ b/target-xtensa/helper.c @@ -54,8 +54,6 @@ static uin

[Qemu-devel] [PATCH qom-next 06/12] apic: Replace cpu_env pointer by X86CPU link

2012-05-29 Thread Igor Mammedov
From: Andreas Färber Needed for converting cpu_is_bsp(). Signed-off-by: Andreas Färber Cc: Paolo Bonzini --- hw/apic.c | 34 +++--- hw/apic_common.c | 14 +++--- hw/apic_internal.h |2 +- hw/kvm/apic.c |9 + hw/pc.c

[Qemu-devel] [PATCH qom-next 01/12] store prev_debug_excp_handler globaly and not per target

2012-05-29 Thread Igor Mammedov
current callers all do the same thing, storing in prev_debug_excp_handler previous handler and then calling it in breakpoint_handler. Move prev_debug_excp_handler from local scope to global and make cpu_set_debug_excp_handler() always to store previous handler. Signed-off-by: Igor Mammedov --- c

[Qemu-devel] [PATCH qom-next 09/12] target-i386: make cpu a child of /machine right after it's created

2012-05-29 Thread Igor Mammedov
Make cpu child of /machine before any properties are set. It is reqired before apic creation is moved to cpu_model property setter because setting link to cpu in apic requires cpu to have canonical path. Signed-off-by: Igor Mammedov --- hw/pc.c | 11 --- target-i386/helper

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-29 Thread Peter Maydell
On 28 May 2012 13:28, Stefan Hajnoczi wrote: > Is goldfish still a relevant Android dev platform?  In other words - > would goldfish be useful to Android developers or just cool for QEMU > hackers and "old-school" Android enthusiasts? I would suggest not, unless we're going to actually solve the

Re: [Qemu-devel] OpenBIOS for v1.1.0

2012-05-29 Thread Peter Maydell
On 29 May 2012 16:02, Andreas Färber wrote: > commit 7d21dcc84b8c07918124a9c0708694d2fb013f65 > updated the binaries to r1056 but did not update the submodule, so the > tarballs are shipping old sources. ...I wonder if it would be possible to write a git commit hook that spotted commits which upd

[Qemu-devel] [PATCH qom-next 04/12] target-i386: move tcg initialization into x86_cpu_initfn()

2012-05-29 Thread Igor Mammedov
In order to make cpu object not depended on external ad-hoc initialization routines, move tcg initialization from cpu_x86_init inside cpu object "x86_cpu_initfn()". Signed-off-by: Igor Mammedov --- target-i386/cpu.c| 10 ++ target-i386/cpu.h|2 ++ target-i386/helper.c | 1

[Qemu-devel] [PATCH qom-next 08/12] target-i386: introduce cpu-model property for x86_cpu

2012-05-29 Thread Igor Mammedov
it's probably intermidiate step till cpu modeled as sub-classes. After then we probably could drop it. However it still could be used for overiding default cpu subclasses definition, and probably renamed to something like 'features'. v2: - remove accidential tcg_* init code move Signed-off-by:

[Qemu-devel] [PATCH qom-next 11/12] target-i386: initialize APIC at CPU level

2012-05-29 Thread Igor Mammedov
(L)APIC is a part of cpu [1] so move APIC initialization inside of x86_cpu object. Since cpu_model and override flags currently specify whether APIC should be created or not, APIC creation is moved into cpu_model property setter. And APIC initialization is moved into x86_cpu_apic_init() which is ca

[Qemu-devel] [PATCH qom-next v3 0/12] target-i386: re-factor CPU creation/initialization to QOM

2012-05-29 Thread Igor Mammedov
Moving code related to CPU creation and initialization internal parts from board level into apic and cpu objects will allow X86CPU to better model QOM object life-cycle. It will allow to create X86CPU as any other object by creating it with object_new() then setting properties and then calling x86_

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Paolo Bonzini
Il 29/05/2012 19:09, Stefan Weil ha scritto: > Am 29.05.2012 15:35, schrieb Stefano Stabellini: >> qemu_rearm_alarm_timer partially duplicates the code in >> qemu_next_alarm_deadline to figure out if it needs to rearm the timer. >> If it calls qemu_next_alarm_deadline, it always rearms the timer ev

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-29 Thread Paolo Bonzini
Il 29/05/2012 13:57, Geert Jansen ha scritto: > I assume the target can be any QEmu block driver including e.g. NBD? A > networked block driver would be required for a continuous replication > solution. Yes. > Does the drive-mirror coroutine send the writes to the target in the > same order as th

Re: [Qemu-devel] Keysymbol interpretation missing in QEMU's VNC server?

2012-05-29 Thread Erik Rull
Hi Fabian, Fabian Holler wrote: Hello Erik, I just want to route all keypresses to the guest without interfering with the native QEMU key layout. Is that possible? Yes, if you start kvm without the "-k" option and use a linux VNC client that supports RFB extended key events (eg gtk-vnc, tige

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Stefano Stabellini
On Tue, 29 May 2012, Stefan Weil wrote: > Yes, we could set the upper limit to LONG_MAX seconds for some > timers, but I did not want to have a dependency of the > upper limit on sizeof(long). The function win32_rearm_timer > only allows 4294967 seconds. Is there any reason why we > should allow ti

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Stefan Weil
Am 29.05.2012 19:23, schrieb Stefano Stabellini: On Tue, 29 May 2012, Stefan Weil wrote: Am 29.05.2012 15:35, schrieb Stefano Stabellini: qemu_rearm_alarm_timer partially duplicates the code in qemu_next_alarm_deadline to figure out if it needs to rearm the timer. If it calls qemu_next_alarm_de

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Stefano Stabellini
On Tue, 29 May 2012, Stefan Weil wrote: > Am 29.05.2012 15:35, schrieb Stefano Stabellini: > > qemu_rearm_alarm_timer partially duplicates the code in > > qemu_next_alarm_deadline to figure out if it needs to rearm the timer. > > If it calls qemu_next_alarm_deadline, it always rearms the timer even

Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Stefan Weil
Am 29.05.2012 15:35, schrieb Stefano Stabellini: qemu_rearm_alarm_timer partially duplicates the code in qemu_next_alarm_deadline to figure out if it needs to rearm the timer. If it calls qemu_next_alarm_deadline, it always rearms the timer even if the next deadline is INT64_MAX. This patch simp

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-29 Thread Luiz Capitulino
On Tue, 29 May 2012 17:51:50 +0300 Alon Levy wrote: > On Tue, May 29, 2012 at 10:38:20AM -0300, Luiz Capitulino wrote: > > On Tue, 29 May 2012 09:25:40 +0200 > > Gerd Hoffmann wrote: > > > > > Hi, > > > > > > >> How would that work? I have QXLInfo that only makes sense when the > > > >> info

[Qemu-devel] [Bug 998435] Re: qemu-kvm-spice doesn't support spice/qxl installs

2012-05-29 Thread lequeux1
Confirmed for winXP guest: qemu-kvm-spice doesn't support spice/qxl (bugs: 100%CPU, vdservice doesnt start, no guest screen at boot) Boris's recipe works ( http://bderzhavets.wordpress.com/2012/05/22/set- up-qemu-kvm-1-0noroms-as-spice-enabled-qemu-server/) NB: used guest winXP drivers from spic

Re: [Qemu-devel] [PATCH 1.1] sheepdog: add coroutine_fn markers to coroutine functions

2012-05-29 Thread Andreas Färber
Am 29.05.2012 18:22, schrieb MORITA Kazutaka: > Signed-off-by: MORITA Kazutaka Patch is tab-damaged. Andreas > --- > block/sheepdog.c |9 + > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index f46ca8f..046f52a 100644 > ---

[Qemu-devel] [PATCH 1.1] sheepdog: add coroutine_fn markers to coroutine functions

2012-05-29 Thread MORITA Kazutaka
Signed-off-by: MORITA Kazutaka --- block/sheepdog.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index f46ca8f..046f52a 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -522,8 +522,8 @@ static int send_req(int sockfd,

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-29 Thread Geert Jansen
Hi, On 05/24/2012 04:19 PM, Paolo Bonzini wrote: Here is how the bitmaps are handled when doing I/O on the source: - after writing to the source: - clear bit in the volatile in-flight bitmap - set bit in the persistent dirty bitmap - after flushing the source: - msync the persistent b

[Qemu-devel] [PATCH 1.1 v2] sheepdog: fix return value of do_load_save_vm_state

2012-05-29 Thread MORITA Kazutaka
bdrv_save_vmstate and bdrv_load_vmstate should return the vmstate size on success, and -errno on error. Signed-off-by: MORITA Kazutaka --- Changes from v1 - return an error for short reads/writes - fix a coding style problem block/sheepdog.c | 10 +- 1 files changed, 5 insertions(+)

Re: [Qemu-devel] [PATCH 1/3 v9] add-cow file format

2012-05-29 Thread Stefan Hajnoczi
> +    image_sectors = image_bs->total_sectors; Please use bdrv_getlength() instead of accessing total_sectors directly. > +    image_drv = bdrv_find_format("raw"); > +    ret = bdrv_open(s->image_hd, image_filename, flags, image_drv); > +    if (ret < 0) { > +        bdrv_delete(s->image_hd); >

[Qemu-devel] arm exit code.

2012-05-29 Thread Davide Ferraretto
In arm user mode, where does qemu exit? Where is last qemu's instruction?

[Qemu-devel] [PATCH] linux-user: ARM: Ignore immediate value for svc in thumb mode

2012-05-29 Thread Alexander Graf
When running in thumb mode, Linux doesn't evaluate the immediate value of the svc instruction, but instead just always assumes the syscall number to be in r7. This fixes executing go_bootstrap while building go for me. Signed-off-by: Alexander Graf --- linux-user/main.c |3 +-- 1 files chan

Re: [Qemu-devel] [PULL 1.1] qemu-ga build fix for OpenBSD

2012-05-29 Thread Michael Roth
On Thu, May 24, 2012 at 01:52:39PM -0500, Michael Roth wrote: > The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d: > > audio: Always call fini on exit (2012-05-24 19:35:27 +0400) > > are available in the git repository at: > git://github.com/mdroth/qemu.git qga-pull-

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-29 Thread Jan Kiszka
On 2012-05-28 14:28, Stefan Hajnoczi wrote: > On Sat, May 26, 2012 at 2:25 PM, 陳韋任 wrote: >> On Sat, May 26, 2012 at 02:51:29PM +0200, Andreas Färber wrote: >>> Am 26.05.2012 07:55, schrieb 陳韋任: On Fri, May 25, 2012 at 06:13:25PM -0400, Ira Ray Jenkins wrote: > I found a GSOC11 project th

Re: [Qemu-devel] [PATCH for-1.1] qemu-ga: Fix use of environ on Darwin

2012-05-29 Thread Michael Roth
On Sun, May 27, 2012 at 05:02:20PM +0200, Andreas Färber wrote: > Use _NSGetEnviron() helper to access the environment. > > Signed-off-by: Andreas Färber > Cc: Charlie Somerville > --- > Michael, can you please append this to your qemu-ga PULL? Thanks, applied to qga tree. I'll send an updated

[Qemu-devel] OpenBIOS for v1.1.0

2012-05-29 Thread Andreas Färber
Hello Blue, commit 7d21dcc84b8c07918124a9c0708694d2fb013f65 Author: Blue Swirl Date: Tue May 1 10:56:46 2012 + pc-bios: update OpenBIOS images Update OpenBIOS images to SVN r1056. Signed-off-by: Blue Swirl updated the binaries to r1056 but did not update the submodule, so t

Re: [Qemu-devel] [PATCH 8/9] unicore32-softmmu: add config and makefile support

2012-05-29 Thread guanxuetao
> Am 28.05.2012 12:08, schrieb guanxue...@mprc.pku.edu.cn: >>> Am 25.05.2012 13:29, schrieb Guan Xuetao: This patch adds configure and makefile support for unicore32-softmmu. All puv3-soc devices are put into hw/pkunity directory, so this dir will be added when unicore32-softmmu is s

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-29 Thread Alon Levy
On Tue, May 29, 2012 at 10:38:20AM -0300, Luiz Capitulino wrote: > On Tue, 29 May 2012 09:25:40 +0200 > Gerd Hoffmann wrote: > > > Hi, > > > > >> How would that work? I have QXLInfo that only makes sense when the > > >> information is about a qxl device. Can't have opaque data in a QMP > > >>

Re: [Qemu-devel] [PATCH 5/9] unicore32-softmmu: initialize ucv2 cpu

2012-05-29 Thread guanxuetao
> Am 28.05.2012 11:43, schrieb guanxue...@mprc.pku.edu.cn: >>> Am 25.05.2012 13:29, schrieb Guan Xuetao: Signed-off-by: Guan Xuetao --- target-unicore32/cpu.c | 17 + target-unicore32/cpu.h |2 +- 2 files changed, 14 insertions(+), 5 deletions(-) >>>

Re: [Qemu-devel] KVM call agenda for Tuesday, May 29th

2012-05-29 Thread Juan Quintela
Anthony Liguori wrote: > On 05/28/2012 06:20 PM, Juan Quintela wrote: >> >> Hi >> >> Please send in any agenda items you are interested in covering. > > I'm in China for the next two weeks and this time is now pretty > inconvenient. Unless there's anything that requires urgent discussion > on the

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-29 Thread Luiz Capitulino
On Tue, 29 May 2012 09:25:40 +0200 Gerd Hoffmann wrote: > Hi, > > >> How would that work? I have QXLInfo that only makes sense when the > >> information is about a qxl device. Can't have opaque data in a QMP > >> response, so would this be a "info display qxl" "info display cirrus" > >> etc. o

[Qemu-devel] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-05-29 Thread Stefano Stabellini
qemu_rearm_alarm_timer partially duplicates the code in qemu_next_alarm_deadline to figure out if it needs to rearm the timer. If it calls qemu_next_alarm_deadline, it always rearms the timer even if the next deadline is INT64_MAX. This patch simplifies the behavior of qemu_rearm_alarm_timer and r

Re: [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu

2012-05-29 Thread Pavel Dovgaluk
> From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Thursday, May 24, 2012 5:12 PM > On 05/24/2012 05:10 AM, Paolo Bonzini wrote: > > Il 24/05/2012 09:42, Pavel Dovgaluk ha scritto: > >> Prevent disk data loss when closing qemu console window > >> under Windows 7. > >> > >> Signed-off-by

[Qemu-devel] [PATCH v3] Prevent disk data loss when closing qemu

2012-05-29 Thread Pavel Dovgaluk
Prevent disk data loss when closing qemu console window under Windows 7. v3. Comment for Sleep() parameter was updated. Signed-off-by: Pavel Dovgalyuk --- os-win32.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/os-win32.c b/os-win32.c index ad76370..66c39b8 1006

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-29 Thread Luiz Capitulino
On Tue, 29 May 2012 20:17:53 +0800 Amos Kong wrote: > On 05/29/2012 07:57 PM, Amos Kong wrote: > > On 05/25/2012 09:14 PM, Anthony Liguori wrote: > >> On 05/24/2012 10:51 PM, Eric Blake wrote: > >>> On 05/24/2012 09:32 PM, Amos Kong wrote: > Convert 'sendkey' to use. do_sendkey() depends on

Re: [Qemu-devel] qtest: setitimer() failures on Darwin and illumos

2012-05-29 Thread Andreas Färber
Am 28.05.2012 22:15, schrieb Paolo Bonzini: > Il 28/05/2012 21:40, Andreas Färber ha scritto: >> I'm seeing qemu-timer.c:unix_rearm_timer()'s setitimer() abort with >> EINVAL during `make check` on both platforms. The value of >> nearest_delta_ns appears to be INT64_MAX. Is this expected? Is it >>

[Qemu-devel] [PATCH] ANSI escape characters support for Windows console

2012-05-29 Thread Pavel Dovgaluk
This patch adds support of ANSI escape characters used in readline module to impelementation of stdio character device for Windows. Signed-off-by: Pavel Dovgalyuk --- qemu-char.c | 48 ++-- 1 files changed, 38 insertions(+), 10 deletions(-) diff --g

Re: [Qemu-devel] [PATCH 0/3][v17] megasas: LSI Megaraid SAS HBA emulation

2012-05-29 Thread Paolo Bonzini
Il 29/05/2012 13:51, Hannes Reinecke ha scritto: > This is an updated patchset for megasas. Upon popular demand > I've split it into three parts, the header file, the emulation > itself, and a patch adding trace events to the emulation. > > Paolo, can you merge it via your tree? Or should I ask >

Re: [Qemu-devel] qtest: setitimer() failures on Darwin and illumos

2012-05-29 Thread Paolo Bonzini
Il 29/05/2012 14:01, Stefano Stabellini ha scritto: > On Mon, 28 May 2012, Paolo Bonzini wrote: >> Il 28/05/2012 21:40, Andreas Färber ha scritto: >>> I'm seeing qemu-timer.c:unix_rearm_timer()'s setitimer() abort with >>> EINVAL during `make check` on both platforms. The value of >>> nearest_delta

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-29 Thread Amos Kong
On 05/29/2012 07:57 PM, Amos Kong wrote: > On 05/25/2012 09:14 PM, Anthony Liguori wrote: >> On 05/24/2012 10:51 PM, Eric Blake wrote: >>> On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sendkey() to m

Re: [Qemu-devel] qtest: setitimer() failures on Darwin and illumos

2012-05-29 Thread Stefano Stabellini
On Mon, 28 May 2012, Paolo Bonzini wrote: > Il 28/05/2012 21:40, Andreas Färber ha scritto: > > I'm seeing qemu-timer.c:unix_rearm_timer()'s setitimer() abort with > > EINVAL during `make check` on both platforms. The value of > > nearest_delta_ns appears to be INT64_MAX. Is this expected? Is it >

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-29 Thread Amos Kong
On 05/25/2012 09:14 PM, Anthony Liguori wrote: > On 05/24/2012 10:51 PM, Eric Blake wrote: >> On 05/24/2012 09:32 PM, Amos Kong wrote: >>> Convert 'sendkey' to use. do_sendkey() depends on some variables >>> in monitor.c, so reserve qmp_sendkey() to monitor.c Rename >>> 'string' to 'keys', rename

[Qemu-devel] [PATCH 3/3] megasas: Add trace events

2012-05-29 Thread Hannes Reinecke
This patch add trace events to the megasas HBA emulation. Signed-off-by: Hannes Reinecke --- hw/megasas.c | 348 +- trace-events | 79 + 2 files changed, 377 insertions(+), 50 deletions(-) diff --git a/hw/megasas.c b/hw/mega

[Qemu-devel] [PATCH 1/3] megasas: Add header file

2012-05-29 Thread Hannes Reinecke
This patch adds the header file for megasas. Signed-off-by: Hannes Reinecke --- hw/mfi.h | 1248 ++ 1 files changed, 1248 insertions(+), 0 deletions(-) create mode 100644 hw/mfi.h diff --git a/hw/mfi.h b/hw/mfi.h new file mode 100644

[Qemu-devel] [PATCH 0/3][v17] megasas: LSI Megaraid SAS HBA emulation

2012-05-29 Thread Hannes Reinecke
This is an updated patchset for megasas. Upon popular demand I've split it into three parts, the header file, the emulation itself, and a patch adding trace events to the emulation. Paolo, can you merge it via your tree? Or should I ask someone else? Changes since v17: - Fix crash when booting wi

  1   2   >