Re: [Qemu-devel] nested page table translation for non-x86 operating system

2012-05-28 Thread Wei-Ren Chen
Hi Xin Tong, On Fri, Jan 20, 2012 at 08:54:12AM -0500, Xin Tong wrote: > On Fri, Jan 20, 2012 at 3:23 AM, 陳韋任 wrote: > >> 1. The control of gCR3 and hCR3 needs kernel access. While they can > >> be set with a device module as what is done in kvm. Trapping into the > >> kernel every time gCR3 is

Re: [Qemu-devel] Lack of codes in logging

2012-05-28 Thread Max Filippov
On Tue, May 29, 2012 at 8:25 AM, Yue Chen wrote: > Do you know how to use that? When I use "log(-d) exec" and "log(-d) pcall", > the "qemu.log" is always empty. AFAIK exec only prints execution trace in the debug build of QEMU. -- Thanks. -- Max

Re: [Qemu-devel] Lack of codes in logging

2012-05-28 Thread Wei-Ren Chen
On Tue, May 29, 2012 at 12:25:51AM -0400, Yue Chen wrote: > Do you know how to use that? When I use "log(-d) exec" and "log(-d) pcall", > the > "qemu.log" is always empty. `qemu -d in_asm,exec` will do. Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Scie

Re: [Qemu-devel] Lack of codes in logging

2012-05-28 Thread Yue Chen
Do you know how to use that? When I use* "log(-d) exec" and "log(-d) pcall"*, the "qemu.log" is always empty. On Mon, May 28, 2012 at 10:47 PM, 陳韋任 (Wei-Ren Chen) < che...@iis.sinica.edu.tw> wrote: > On Mon, May 28, 2012 at 10:37:47PM -0400, Yue Chen wrote: > > What's the helper function? Thanks.

Re: [Qemu-devel] Virtio-pci issue

2012-05-28 Thread Evgeny Voevodin
On 28.05.2012 16:37, Stefan Hajnoczi wrote: On Thu, May 24, 2012 at 4:18 AM, Evgeny Voevodin wrote: And also there is another problem that I've faced with. It is the ability to plug as many pci back-ends as board wants. I mean that if for each back-end board should create a transport, then user

Re: [Qemu-devel] [PATCH V1] cadence_ttc: changed master clock frequency

2012-05-28 Thread Peter Maydell
On 29 May 2012 04:16, Peter A. G. Crosthwaite wrote: > Change the timer clock frequency to 133MHz which is correct. the old 2.5MHz > value was for the pre-silicon emulation platform. > > Signed-off-by: Peter A. G. Crosthwaite Thanks; queued in arm-devs.next (I plan to do a pullreq when master re

[Qemu-devel] [PATCH V1] cadence_ttc: changed master clock frequency

2012-05-28 Thread Peter A. G. Crosthwaite
Change the timer clock frequency to 133MHz which is correct. the old 2.5MHz value was for the pre-silicon emulation platform. Signed-off-by: Peter A. G. Crosthwaite --- hw/cadence_ttc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/cadence_ttc.c b/hw/cadence_ttc.c

[Qemu-devel] KVM call agenda for Tuesday, May 29th

2012-05-28 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH for-1.1 v2] slirp: Avoid redefining MAX_TCPOPTLEN

2012-05-28 Thread Jan Kiszka
On 2012-05-28 19:52, Andreas Färber wrote: > MAX_TCPOPTLEN is being defined as 32. Darwin already has it as 40, > causing a warning. The value is only used to declare an array, > into which currently 4 bytes are written at most. > > Therefore always override MAX_TCPOPTLEN for now. > > Suggested-b

Re: [Qemu-devel] [PATCH for-1.1 v3] slirp: Avoid statements without effect on Big Endian host

2012-05-28 Thread Jan Kiszka
On 2012-05-28 19:34, Andreas Färber wrote: > Darwin has HTON*/NTOH* macros that on BE simply return the argument. > This is incompatible with SLIRP's use of these macros as a statement. > > Undefine the macros in the HOST_WORDS_BIGENDIAN code path to redefine > these macros as no-op, as already do

Re: [Qemu-devel] [PATCH for-1.1 v2] slirp: Avoid redefining MAX_TCPOPTLEN

2012-05-28 Thread Stefan Weil
Am 28.05.2012 19:52, schrieb Andreas Färber: MAX_TCPOPTLEN is being defined as 32. Darwin already has it as 40, causing a warning. The value is only used to declare an array, into which currently 4 bytes are written at most. Therefore always override MAX_TCPOPTLEN for now. Suggested-by: Jan Kis

Re: [Qemu-devel] qtest: setitimer() failures on Darwin and illumos

2012-05-28 Thread Paolo Bonzini
Il 28/05/2012 21:40, Andreas Färber ha scritto: > I'm seeing qemu-timer.c:unix_rearm_timer()'s setitimer() abort with > EINVAL during `make check` on both platforms. The value of > nearest_delta_ns appears to be INT64_MAX. Is this expected? Is it > possible that this value is too large for it_value

[Qemu-devel] qtest: setitimer() failures on Darwin and illumos

2012-05-28 Thread Andreas Färber
Hello, I'm seeing qemu-timer.c:unix_rearm_timer()'s setitimer() abort with EINVAL during `make check` on both platforms. The value of nearest_delta_ns appears to be INT64_MAX. Is this expected? Is it possible that this value is too large for it_value on some platforms? Apple's man page mentions th

Re: [Qemu-devel] How to compile the source code to get the images and executable to run the QEMU?

2012-05-28 Thread Arturo CV
Hello Daniel, I really thank you for the answer to my question.. I was following the steps that are shown in the link that you point out, but when I get into the step: - Install the MinGW version of zlib and make sure zlib.h and libz.dll.a are in MinGW's default header and linker search paths. I

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-28 Thread Luiz Capitulino
On Mon, 28 May 2012 16:36:16 +0300 Alon Levy wrote: > On Mon, May 28, 2012 at 10:13:28AM -0300, Luiz Capitulino wrote: > > On Mon, 28 May 2012 12:08:13 +0300 > > Alon Levy wrote: > > > > > On Fri, May 25, 2012 at 11:43:11AM -0300, Luiz Capitulino wrote: > > > > On Thu, 24 May 2012 19:22:52 +030

[Qemu-devel] [RFC next] ui: Split main() in two to not have Cocoa hijack it

2012-05-28 Thread Andreas Färber
Only call into cocoa.m when determined necessary by QEMU's option handling. Avoids redoing all option parsing in ui/cocoa.m:main() and constantly missing new options like -machine accel=qtest. Move function declarations to a new ui.h header to avoid recompiling everything when the new UI-internal

[Qemu-devel] [PATCH for-1.1] cocoa: Suppress Cocoa frontend for -qtest

2012-05-28 Thread Andreas Färber
Signed-off-by: Andreas Färber --- ui/cocoa.m |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index e7d6e89..4724d2c 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -879,7 +879,8 @@ int main (int argc, const char * argv[]) { !strcmp(o

[Qemu-devel] [PATCH for-1.1 v2] slirp: Avoid redefining MAX_TCPOPTLEN

2012-05-28 Thread Andreas Färber
MAX_TCPOPTLEN is being defined as 32. Darwin already has it as 40, causing a warning. The value is only used to declare an array, into which currently 4 bytes are written at most. Therefore always override MAX_TCPOPTLEN for now. Suggested-by: Jan Kiszka Signed-off-by: Andreas Färber --- slirp/

[Qemu-devel] [PATCH for-1.1 v3] slirp: Avoid statements without effect on Big Endian host

2012-05-28 Thread Andreas Färber
Darwin has HTON*/NTOH* macros that on BE simply return the argument. This is incompatible with SLIRP's use of these macros as a statement. Undefine the macros in the HOST_WORDS_BIGENDIAN code path to redefine these macros as no-op, as already done when they were undefined. Suggested-by: Peter May

Re: [Qemu-devel] [PATCH 5/9] unicore32-softmmu: initialize ucv2 cpu

2012-05-28 Thread guanxuetao
> Am 25.05.2012 13:29, schrieb Guan Xuetao: >> Signed-off-by: Guan Xuetao >> --- >> target-unicore32/cpu.c | 17 + >> target-unicore32/cpu.h |2 +- >> 2 files changed, 14 insertions(+), 5 deletions(-) >> >> diff --git a/target-unicore32/cpu.c b/target-unicore32/cpu.c >> inde

Re: [Qemu-devel] [PATCH 7/9] unicore32-softmmu: add puv3 soc support

2012-05-28 Thread guanxuetao
> Am 25.05.2012 13:29, schrieb Guan Xuetao: >> This patch only add minimal necessary system-control modules simulation >> for successfully kernel booting and busybox running. >> >> Signed-off-by: Guan Xuetao >> --- >> hw/pkunity/puv3.c | 130 + >> hw/

Re: [Qemu-devel] [PATCH 6/9] unicore32-softmmu: add generic cpu state save/load functions

2012-05-28 Thread guanxuetao
> Hi Guan, > >> +void cpu_save(QEMUFile *f, void *opaque) >> +{ >> +int i; >> +CPUUniCore32State *env = (CPUUniCore32State *)opaque; >> + >> +for (i = 0; i < 32; i++) { >> +qemu_put_be32(f, env->regs[i]); >> +} >> +qemu_put_be32(f, cpu_asr_read(env)); >> +qemu_put_be

Re: [Qemu-devel] [PATCH 6/9] unicore32-softmmu: add generic cpu state save/load functions

2012-05-28 Thread guanxuetao
> Am 25.05.2012 13:29, schrieb Guan Xuetao: >> This patch adds generic cpu state save/load functions for UniCore32 ISA. >> All architecture related registers are saved or loaded, and no >> optimization. >> >> Signed-off-by: Guan Xuetao >> --- >> target-unicore32/machine.c | 99 >> ++

Re: [Qemu-devel] [PATCH 8/9] unicore32-softmmu: add config and makefile support

2012-05-28 Thread guanxuetao
> Am 25.05.2012 13:29, schrieb Guan Xuetao: >> This patch adds configure and makefile support for unicore32-softmmu. >> All puv3-soc devices are put into hw/pkunity directory, so this dir >> will be added when unicore32-softmmu is selected. >> >> Signed-off-by: Guan Xuetao >> --- >> Makefile.targ

Re: [Qemu-devel] [PATCH 7/9] unicore32-softmmu: add puv3 soc support

2012-05-28 Thread guanxuetao
> Am 25.05.2012 13:29, schrieb Guan Xuetao: >> This patch only add minimal necessary system-control modules simulation >> for successfully kernel booting and busybox running. >> >> Signed-off-by: Guan Xuetao >> --- >> hw/pkunity/puv3.c | 130 + >> hw/

Re: [Qemu-devel] [PATCH 1.1] es1370: Fix debug code

2012-05-28 Thread Andreas Färber
Am 28.05.2012 17:18, schrieb malc: > On Mon, 28 May 2012, Stefan Weil wrote: > >> Am 28.05.2012 06:11, schrieb Peter Maydell: >>> On 23 May 2012 22:26, Stefan Weil wrote: When DEBUG_ES1370 is defined, the compiler shows these warnings: hw/es1370.c: In function ?es1370_update_voices

Re: [Qemu-devel] [PATCH 1.1] es1370: Fix debug code

2012-05-28 Thread malc
On Mon, 28 May 2012, Stefan Weil wrote: > Am 28.05.2012 06:11, schrieb Peter Maydell: > > On 23 May 2012 22:26, Stefan Weil wrote: > > > When DEBUG_ES1370 is defined, the compiler shows these warnings: > > > > > > hw/es1370.c: In function ?es1370_update_voices?: > > > hw/es1370.c:414: warning: f

Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without effect on Big Endian host

2012-05-28 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 28.05.2012 13:47, schrieb Jan Kiszka: > On 2012-05-28 00:10, Peter Maydell wrote: >> On 27 May 2012 17:42, Andreas Färber >> wrote: >>> +# if defined(__APPLE__) +# undef NTOHL +# undef NTOHS +# >>> undef HTONL +# undef HTONS +# define NTOHL(d)

Re: [Qemu-devel] [PATCH for-1.1?] slirp: Avoid redefining MAX_TCPOPTLEN

2012-05-28 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 28.05.2012 13:40, schrieb Jan Kiszka: > On 2012-05-27 14:02, Andreas Färber wrote: >> MAX_TCPOPTLEN is being defined as 32. Darwin has it as 40, >> causing a warning. The value is only used to declare an array, >> into which currently 4 bytes are wr

Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts

2012-05-28 Thread Andreas Färber
Am 23.05.2012 10:09, schrieb Stefan Hajnoczi: > On Tue, May 22, 2012 at 10:23 PM, Stefan Weil wrote: >> The local variables ret, i are only used if __linux__ is defined. >> >> Signed-off-by: Stefan Weil >> --- >> hw/virtio-blk.c |4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without effect on Big Endian host

2012-05-28 Thread Andreas Färber
Am 28.05.2012 14:00, schrieb Peter Maydell: > On 28 May 2012 12:47, Jan Kiszka wrote: >> On 2012-05-28 00:10, Peter Maydell wrote: >>> On 27 May 2012 17:42, Andreas Färber wrote: +# if defined(__APPLE__) +# undef NTOHL +# undef NTOHS +# undef HTONL +# undef HTONS

Re: [Qemu-devel] [PATCH qom-next] qom: Introduce object_property_is_{child, link}()

2012-05-28 Thread Andreas Färber
Am 28.05.2012 08:47, schrieb Paolo Bonzini: > Il 27/05/2012 01:19, Andreas Färber ha scritto: >> Avoids hardcoding partial string comparisons. >> >> Signed-off-by: Alexander Barabash >> Signed-off-by: Andreas Färber [...] > Reviewed-by: Paolo Bonzini Thanks, applied to qom-next: http://repo.or.

Re: [Qemu-devel] [PATCH qemu 5/6] implement -no-user-config command-line option (v3)

2012-05-28 Thread Andreas Färber
Am 28.05.2012 08:35, schrieb Paolo Bonzini: > Il 27/05/2012 16:02, Andreas Färber ha scritto: >> Any suggestion how to fix? Sorry, I forgot to reply here that I've sent a patch. > Does it work to "typedef _Bool __bool" before including altivec.h (and > in the same #ifdef)? Haven't tried but I'm

Re: [Qemu-devel] [PATCH 8/9] unicore32-softmmu: add config and makefile support

2012-05-28 Thread Andreas Färber
Am 28.05.2012 12:08, schrieb guanxue...@mprc.pku.edu.cn: >> Am 25.05.2012 13:29, schrieb Guan Xuetao: >>> This patch adds configure and makefile support for unicore32-softmmu. >>> All puv3-soc devices are put into hw/pkunity directory, so this dir >>> will be added when unicore32-softmmu is selecte

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-28 Thread Alon Levy
On Mon, May 28, 2012 at 10:13:28AM -0300, Luiz Capitulino wrote: > On Mon, 28 May 2012 12:08:13 +0300 > Alon Levy wrote: > > > On Fri, May 25, 2012 at 11:43:11AM -0300, Luiz Capitulino wrote: > > > On Thu, 24 May 2012 19:22:52 +0300 > > > Alon Levy wrote: > > > > > > > For all devices print id,

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-28 Thread Luiz Capitulino
On Mon, 28 May 2012 12:17:04 +0100 Stefan Hajnoczi wrote: > What we need to decide is whether it's okay to drop QEMU "VLANs" > completely and change dump command-line syntax? I'd vote for dropping it. > I think vlan-hub doesn't hurt anyone because the code has been isolated > and we keep backwa

Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices

2012-05-28 Thread Michael S. Tsirkin
On Mon, May 28, 2012 at 02:48:10PM +0200, Jan Kiszka wrote: > On 2012-05-28 14:44, Michael S. Tsirkin wrote: > > On Fri, May 25, 2012 at 05:35:03PM +1000, Alexey Kardashevskiy wrote: > >> Some adapters (like NEC PCI USB controller) do not flush their config > >> on a sioftware reset and remember DM

Re: [Qemu-devel] [PATCH 5/9] unicore32-softmmu: initialize ucv2 cpu

2012-05-28 Thread Andreas Färber
Am 28.05.2012 11:43, schrieb guanxue...@mprc.pku.edu.cn: >> Am 25.05.2012 13:29, schrieb Guan Xuetao: >>> Signed-off-by: Guan Xuetao >>> --- >>> target-unicore32/cpu.c | 17 + >>> target-unicore32/cpu.h |2 +- >>> 2 files changed, 14 insertions(+), 5 deletions(-) >>> >>> dif

Re: [Qemu-devel] [PATCH v2] net: add the support for -netdev socket, listen

2012-05-28 Thread Zhi Yong Wu
On Mon, May 28, 2012 at 6:51 PM, Stefan Hajnoczi wrote: > On Mon, May 28, 2012 at 03:49:11PM +0800, Zhi Yong Wu wrote: >> On Sun, Feb 26, 2012 at 10:48 PM, Stefan Hajnoczi wrote: >> > On Sat, Feb 18, 2012 at 9:19 AM,   wrote: >> >> From: Zhi Yong Wu >> >> >> >> The -net socket,listen option does

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-28 Thread Luiz Capitulino
On Mon, 28 May 2012 12:08:13 +0300 Alon Levy wrote: > On Fri, May 25, 2012 at 11:43:11AM -0300, Luiz Capitulino wrote: > > On Thu, 24 May 2012 19:22:52 +0300 > > Alon Levy wrote: > > > > > For all devices print id, mode and guest_bug status. > > > > Is qxl really tied to spice? In the meaning

Re: [Qemu-devel] [PATCH 14/14] qapi: convert screendump

2012-05-28 Thread Luiz Capitulino
On Mon, 28 May 2012 11:56:31 +0300 Alon Levy wrote: > On Fri, May 25, 2012 at 04:41:19PM -0300, Luiz Capitulino wrote: > > One small note below. > > > Also activates error reporting from devices. > > > > Signed-off-by: Luiz Capitulino > > --- > > console.c| 7 --- > > console.h

Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts

2012-05-28 Thread Peter Maydell
On 28 May 2012 13:39, Stefan Hajnoczi wrote: > Agreed, people have been asked to declare variables at the beginning > of the scope.  I don't understand why, C99 allows them to be declared > anywhere and it usually makes the code more readable IMO (you don't > have to jump to the definition to chec

Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices

2012-05-28 Thread Jan Kiszka
On 2012-05-28 14:44, Michael S. Tsirkin wrote: > On Fri, May 25, 2012 at 05:35:03PM +1000, Alexey Kardashevskiy wrote: >> Some adapters (like NEC PCI USB controller) do not flush their config >> on a sioftware reset and remember DMA config, etc. >> >> If we use such an adapter with QEMU, then crash

Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts

2012-05-28 Thread Daniel P. Berrange
On Mon, May 28, 2012 at 01:39:58PM +0100, Stefan Hajnoczi wrote: > On Wed, May 23, 2012 at 5:03 PM, Stefan Weil wrote: > > Am 23.05.2012 17:32, schrieb Kevin Wolf: > > > >> Am 23.05.2012 17:29, schrieb Stefan Weil: > >>> > >>> Am 23.05.2012 10:09, schrieb Stefan Hajnoczi: > > On Tue, May

Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices

2012-05-28 Thread Michael S. Tsirkin
On Fri, May 25, 2012 at 05:35:03PM +1000, Alexey Kardashevskiy wrote: > Some adapters (like NEC PCI USB controller) do not flush their config > on a sioftware reset and remember DMA config, etc. > > If we use such an adapter with QEMU, then crash QEMU (stop it with > ctrl-A ctrl-X), and try to use

Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts

2012-05-28 Thread Stefan Hajnoczi
On Wed, May 23, 2012 at 5:03 PM, Stefan Weil wrote: > Am 23.05.2012 17:32, schrieb Kevin Wolf: > >> Am 23.05.2012 17:29, schrieb Stefan Weil: >>> >>> Am 23.05.2012 10:09, schrieb Stefan Hajnoczi: On Tue, May 22, 2012 at 10:23 PM, Stefan Weil   wrote: > > The local variables ret,

Re: [Qemu-devel] Virtio-pci issue

2012-05-28 Thread Stefan Hajnoczi
On Thu, May 24, 2012 at 4:18 AM, Evgeny Voevodin wrote: > And also there is another problem that I've faced with. It is the ability to > plug as many pci back-ends as board wants. > I mean that if for each back-end board should create a transport, then user > have to know maximum number of transpo

Re: [Qemu-devel] Tracing message for mu

2012-05-28 Thread Stefan Hajnoczi
On Sat, May 26, 2012 at 7:50 AM, Charles.Tsai-蔡清海-研究發展部 wrote: > Hans replied me back and he suggested me to use strace. > Hopefully, this issue can be resolved. > > Additionally, we encountered a tough issue right now. > When we ran a 64-bit Windows 7 VM overnight, the kvm process was killed for

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-28 Thread Stefan Hajnoczi
On Sat, May 26, 2012 at 2:25 PM, 陳韋任 wrote: > On Sat, May 26, 2012 at 02:51:29PM +0200, Andreas Färber wrote: >> Am 26.05.2012 07:55, schrieb 陳韋任: >> > On Fri, May 25, 2012 at 06:13:25PM -0400, Ira Ray Jenkins wrote: >> >> I found a GSOC11 project that attempted to port the Android "Goldfish" >> >

Re: [Qemu-devel] [PATCH for-1.1] virtio-blk: Fix unused variables in virtio_blk_handle_scsi()

2012-05-28 Thread Stefan Hajnoczi
On Sun, May 27, 2012 at 3:41 PM, Andreas Färber wrote: > Commit f34e73cd69bdbdb9b1d56b288c5e14d6fff58165 (virtio-blk: report > non-zero status when failing SG_IO requests) exposed the function > to non-Linux guests. Move all Linux-only variable declarations into > an #ifdef in the variable declara

Re: [Qemu-devel] [PATCH] block: prevent snapshot mode $TMPDIR symlink attack

2012-05-28 Thread Stefan Hajnoczi
On Mon, May 28, 2012 at 8:27 AM, Jim Meyering wrote: > diff --git a/block/vvfat.c b/block/vvfat.c > index 2dc9d50..0fd3367 100644 > --- a/block/vvfat.c > +++ b/block/vvfat.c > @@ -2808,7 +2808,12 @@ static int enable_write_target(BDRVVVFATState *s) >     array_init(&(s->commits), sizeof(commit_t))

Re: [Qemu-devel] [PATCH 4/4] ISCSI: If the device we open is a SMC device, then force the use of sg. We dont have any medium changer emulation so only passthrough via real sg or scsi-generic via iscsi

2012-05-28 Thread Paolo Bonzini
Il 28/05/2012 13:55, ronnie sahlberg ha scritto: > Paolo > > > I think I have seen a problem inside libiscsi that could be triggered > by the shortcut. > > Can you remove this shortcut completely : > > -/* Try to write as much as we can to the socket > - * without setting up an event. >

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-28 Thread Avi Kivity
On 05/28/2012 02:54 PM, Max Filippov wrote: >>> >>> Right. If the fix is going to be checked in then TeLeMan's original version >>> with '|' is preferable for this reason. >> >> I disagree. Whatever we call cpu_get_phys_page_debug() has to either >> mask out the low bits, or not (I prefer the latt

Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without effect on Big Endian host

2012-05-28 Thread Peter Maydell
On 28 May 2012 12:47, Jan Kiszka wrote: > On 2012-05-28 00:10, Peter Maydell wrote: >> On 27 May 2012 17:42, Andreas Färber wrote: >>> +# if defined(__APPLE__) >>> +#  undef NTOHL >>> +#  undef NTOHS >>> +#  undef HTONL >>> +#  undef HTONS >>> +#  define NTOHL(d) do { } while (0) >>> +#  define N

Re: [Qemu-devel] [PATCH 4/4] ISCSI: If the device we open is a SMC device, then force the use of sg. We dont have any medium changer emulation so only passthrough via real sg or scsi-generic via iscsi

2012-05-28 Thread ronnie sahlberg
Paolo I think I have seen a problem inside libiscsi that could be triggered by the shortcut. Can you remove this shortcut completely : -/* Try to write as much as we can to the socket - * without setting up an event. - * Only do this if we are completely logged in, so we know that -

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-28 Thread Max Filippov
On Mon, May 28, 2012 at 1:34 PM, Avi Kivity wrote: > On 05/24/2012 10:58 PM, Max Filippov wrote: >> On Thu, May 24, 2012 at 6:26 PM, Avi Kivity wrote: >>> On 05/24/2012 05:11 PM, Max Filippov wrote: > > Not in breakpoint_invalidate as the missing offset was compensated > before your c

Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without effect on Big Endian host

2012-05-28 Thread Jan Kiszka
On 2012-05-28 00:10, Peter Maydell wrote: > On 27 May 2012 17:42, Andreas Färber wrote: >> +# if defined(__APPLE__) >> +# undef NTOHL >> +# undef NTOHS >> +# undef HTONL >> +# undef HTONS >> +# define NTOHL(d) do { } while (0) >> +# define NTOHS(d) do { } while (0) >> +# define HTONL(d) do

Re: [Qemu-devel] [PATCH for-1.1] slirp: Untangle TCPOLEN_* from TCPOPT_*

2012-05-28 Thread Jan Kiszka
On 2012-05-27 19:43, Andreas Färber wrote: > Am 28.04.2012 00:29, schrieb Andreas Färber: >> From: Andreas Färber >> >> Commit b72210568ef0c0fb141a01cffb71a09c4efa0364 (slirp: clean up >> conflicts with system headers) enclosed TCPOLEN_MAXSEG with an #ifdef >> TCPOPT_EOL. This broke the build on i

Re: [Qemu-devel] [PATCH for-1.1?] slirp: Avoid redefining MAX_TCPOPTLEN

2012-05-28 Thread Jan Kiszka
On 2012-05-27 14:02, Andreas Färber wrote: > MAX_TCPOPTLEN is being defined as 32. Darwin has it as 40, causing a > warning. The value is only used to declare an array, into which currently > 4 bytes are written at most. It should therefore be acceptable to adopt > the host's definition. > > There

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-28 Thread Stefan Hajnoczi
On Fri, May 25, 2012 at 10:56:28AM -0300, Luiz Capitulino wrote: > On Fri, 25 May 2012 15:47:28 +0200 > Paolo Bonzini wrote: > > > Il 25/05/2012 15:43, Luiz Capitulino ha scritto: > > >> Yeah, VDE probably includes something like an hub. But then we could > > >> drop even "-net socket", "-net ud

Re: [Qemu-devel] [PATCH v2] net: add the support for -netdev socket, listen

2012-05-28 Thread Stefan Hajnoczi
On Mon, May 28, 2012 at 03:49:11PM +0800, Zhi Yong Wu wrote: > On Sun, Feb 26, 2012 at 10:48 PM, Stefan Hajnoczi wrote: > > On Sat, Feb 18, 2012 at 9:19 AM,   wrote: > >> From: Zhi Yong Wu > >> > >> The -net socket,listen option does not work with the newer -netdev > >> syntax: > >> http://lists.

[Qemu-devel] cpsr_write...

2012-05-28 Thread Davide Ferraretto
Hi!!! 1)How can I use cpsr_write(var, tmp_mask) in qemu- arm(user mode)?? 2)What are "var" and "tmp_mask"?? 3)How does QEMU use cpsr register in "sigle step mode"??

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-28 Thread Avi Kivity
On 05/24/2012 10:58 PM, Max Filippov wrote: > On Thu, May 24, 2012 at 6:26 PM, Avi Kivity wrote: >> On 05/24/2012 05:11 PM, Max Filippov wrote: Not in breakpoint_invalidate as the missing offset was compensated before your commit (well, starting with c2f07f81a2 in fact). >>> >>> I'd

Re: [Qemu-devel] [ANNOUNCE] qemu-kvm-1.1-rc3

2012-05-28 Thread Avi Kivity
On 05/25/2012 11:36 AM, Veruca Salt wrote: > > Avi- would love to test out 1.1, as we are currently using the ehci method > which has been frozen at 'experimental' for so long. > > Is there any user documentation on the xhci methods? Copying qemu-devel, where someone may know the answer. -- e

Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: hardware random number generator device

2012-05-28 Thread Amit Shah
On (Mon) 28 May 2012 [09:33:57], Daniel P. Berrange wrote: > On Sat, May 26, 2012 at 01:02:49AM +0530, Amit Shah wrote: > > The Linux kernel already has a virtio-rng driver, this is the device > > implementation. > > > > When the guest asks for entropy from the virtio hwrng, it puts a buffer > > i

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-28 Thread Alon Levy
On Fri, May 25, 2012 at 11:43:11AM -0300, Luiz Capitulino wrote: > On Thu, 24 May 2012 19:22:52 +0300 > Alon Levy wrote: > > > For all devices print id, mode and guest_bug status. > > Is qxl really tied to spice? In the meaning that it's impossible to use it > without spice? Wouldn't it be bette

Re: [Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump

2012-05-28 Thread Alon Levy
On Fri, May 25, 2012 at 04:41:05PM -0300, Luiz Capitulino wrote: > Converting the screendump command is simple and shouldn't take more than > or or two patches, the complicated part is to report all errors correctly. > > I hope I didn't go too far there, but at least this series does the right > t

Re: [Qemu-devel] [PATCH 14/14] qapi: convert screendump

2012-05-28 Thread Alon Levy
On Fri, May 25, 2012 at 04:41:19PM -0300, Luiz Capitulino wrote: One small note below. > Also activates error reporting from devices. > > Signed-off-by: Luiz Capitulino > --- > console.c| 7 --- > console.h| 1 - > hmp-commands.hx | 5 ++--- > hmp.c| 9

Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: hardware random number generator device

2012-05-28 Thread Daniel P. Berrange
On Sat, May 26, 2012 at 01:02:49AM +0530, Amit Shah wrote: > The Linux kernel already has a virtio-rng driver, this is the device > implementation. > > When the guest asks for entropy from the virtio hwrng, it puts a buffer > in the vq. We then put entropy into that buffer, and push it back to >

Re: [Qemu-devel] [PATCH v2] net: add the support for -netdev socket, listen

2012-05-28 Thread Zhi Yong Wu
On Sun, Feb 26, 2012 at 10:48 PM, Stefan Hajnoczi wrote: > On Sat, Feb 18, 2012 at 9:19 AM,   wrote: >> From: Zhi Yong Wu >> >> The -net socket,listen option does not work with the newer -netdev >> syntax: >> http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html >> >> This patch make

[Qemu-devel] [PATCH] block: prevent snapshot mode $TMPDIR symlink attack

2012-05-28 Thread Jim Meyering
In snapshot mode, bdrv_open creates an empty temporary file without checking for mkstemp or close failure, and ignoring the possibility of a buffer overrun given a surprisingly long $TMPDIR. Change the get_tmp_filename function to return int (not void), so that it can inform its two callers of tho

Re: [Qemu-devel] [PATCH for-1.1?] slirp: Avoid redefining MAX_TCPOPTLEN

2012-05-28 Thread Stefan Weil
Am 28.05.2012 08:49, schrieb Paolo Bonzini: Il 27/05/2012 19:02, Andreas Färber ha scritto: MAX_TCPOPTLEN is being defined as 32. Darwin has it as 40, causing a warning. The value is only used to declare an array, into which currently 4 bytes are written at most. It should therefore be acceptabl