Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind

2012-05-23 Thread Gerd Hoffmann
On 05/24/12 08:43, Alon Levy wrote: > On Wed, May 23, 2012 at 08:59:22PM +0200, Gerd Hoffmann wrote: >> On 05/22/12 17:29, Alon Levy wrote: >>> We can't initialize QXLDevSurfaceCreate field by field because it has a >>> pa hole, and so 4 bytes remain uninitialized when building on x86-64, so >>> ju

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Michael S. Tsirkin
On Thu, May 24, 2012 at 02:31:00PM +0800, Kelvin Wang wrote: > On Wed, May 23, 2012 at 05:45:33PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote: > > > Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: > > > >> > 2, Run qemu with the option -mon

Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind

2012-05-23 Thread Alon Levy
On Wed, May 23, 2012 at 08:59:22PM +0200, Gerd Hoffmann wrote: > On 05/22/12 17:29, Alon Levy wrote: > > We can't initialize QXLDevSurfaceCreate field by field because it has a > > pa hole, and so 4 bytes remain uninitialized when building on x86-64, so > > just memset. > > So you get valgrind war

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Kelvin Wang
On Wed, May 23, 2012 at 05:45:33PM +0300, Michael S. Tsirkin wrote: > On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote: > > Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: > > >> > 2, Run qemu with the option -monitor. > > >> > > > >> > 3, In the guest, insert necessary modules: >

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Kelvin Wang
On Wed, May 23, 2012 at 05:12:16PM +0300, Michael S. Tsirkin wrote: > On Wed, May 23, 2012 at 09:52:06PM +0800, Kelvin Wang wrote: > > Support the virtio-scsi-pci adapter hot-plug. However, this patch can only > > make > > adapter hot-plugable. More effort is needed for LUN hot-plug. Actually, >

Re: [Qemu-devel] [PATCH v2 15/15] net: invoke qemu_can_send_packet only before net queue sending function

2012-05-23 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 12:00 AM, Paolo Bonzini wrote: > Il 23/05/2012 17:14, zwu.ker...@gmail.com ha scritto: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >>  net/queue.c      |    4 ++-- >>  net/slirp.c      |    7 --- >>  net/tap.c        |    2 +- >>  slirp/if.c       |  

Re: [Qemu-devel] Virtio-pci issue

2012-05-23 Thread Evgeny Voevodin
On 23.05.2012 17:36, Stefan Hajnoczi wrote: On Thu, May 10, 2012 at 12:24 PM, Evgeny Voevodin wrote: Hi, guys! While trying to refactor virtio-pci as continuation of my RFC virtio-mmio patch series: http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg03665.html I've faced a problem. I tr

[Qemu-devel] [PATCH] vfio-powerpc: enabled and supported on power

2012-05-23 Thread Alexey Kardashevskiy
patch is made on top of git://github.com/awilliam/linux-vfio.git iommu-group-vfio-20120523 (which is iommu-group-vfio-20120521 + some fixes) Signed-off-by: Alexey Kardashevskiy --- arch/powerpc/Kconfig |6 + arch/powerpc/include/asm/iommu.h |3 + arch/powerpc/kernel/Makefile

[Qemu-devel] [Bug 393430] Re: kvm: use PulseAudio instead of ALSA

2012-05-23 Thread Serge Hallyn
** Changed in: kvm (Ubuntu) Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/393430 Title: kvm: use PulseAudio instead of ALSA Status in QEMU: Incomplete S

[Qemu-devel] [PATCH] version: update version info

2012-05-23 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- VERSION |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/VERSION b/VERSION index 87903b6..9084fa2 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.0.93 +1.1.0 -- 1.7.6

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-23 Thread Jan Kiszka
On 2012-05-23 23:34, Jan Kiszka wrote: > From: Jan Kiszka > > tb_invalidate_phys_addr has to called with the exact physical address of > the breakpoint we add/remove, not just the page's base address. > Otherwise we easily fail to flush the right TB. > > Regression of 1e7855a558. Sorry, forgot

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-23 Thread Zhi Yong Wu
On Wed, May 23, 2012 at 11:41 PM, Jan Kiszka wrote: > On 2012-05-23 12:14, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >>  net.c |    1 - >>  1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/net.c b/net.c >> index 61dc28d..8c8e703 1

[Qemu-devel] [PATCH] Clarify comments of tb_invalidate_phys_[page_]range

2012-05-23 Thread Jan Kiszka
From: Jan Kiszka They could suggest that all TBs of the page containing the range would be invalidated. Signed-off-by: Jan Kiszka --- exec.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/exec.c b/exec.c index efa1345..a1c12ec 100644 --- a/exec.

Re: [Qemu-devel] The image size of instance VM keeps growing

2012-05-23 Thread Charles . Tsai-蔡清海-研究發展部
Thanks. Good alternative view. -Original Message- From: Michael Tokarev [mailto:m...@tls.msk.ru] Sent: Wednesday, May 23, 2012 9:11 PM To: Stefan Hajnoczi Cc: Charles.Tsai-蔡清海-研究發展部; Jonah.Wu-吳君勉-研究發展部; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] The image size of instance VM keeps gr

[Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-23 Thread Jan Kiszka
From: Jan Kiszka tb_invalidate_phys_addr has to called with the exact physical address of the breakpoint we add/remove, not just the page's base address. Otherwise we easily fail to flush the right TB. Regression of 1e7855a558. Reported-by: TeLeMan Signed-off-by: Jan Kiszka --- exec.c |3

Re: [Qemu-devel] The image size of instance VM keeps growing

2012-05-23 Thread Charles . Tsai-蔡清海-研究發展部
Stefan, Thank you for information. What we worried is an endless growth of the image size. If virtual disk size is the ceiling of the max. image size to be grew, we should not have to worry about this issue. -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: We

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 23:00, Jan Kiszka wrote: > On 2012-05-23 22:29, TeLeMan wrote: >> On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: >>> On 2012-05-23 13:02, Jan Kiszka wrote: On 2012-05-23 11:11, TeLeMan wrote: > On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka > wrote: >> On 2012-05-

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Thu, May 24, 2012 at 10:00 AM, Jan Kiszka wrote: > On 2012-05-23 22:29, TeLeMan wrote: >> On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: >>> On 2012-05-23 13:02, Jan Kiszka wrote: On 2012-05-23 11:11, TeLeMan wrote: > On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka > wrote:

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Thu, May 24, 2012 at 4:44 AM, Anthony Liguori wrote: > On 05/23/2012 03:28 PM, Blue Swirl wrote: >> >> On Wed, May 23, 2012 at 8:04 PM, Andreas Färber  wrote: >>> >>> Am 23.05.2012 21:40, schrieb Blue Swirl: On Wed, May 23, 2012 at 3:41 AM, Andreas Färber  wrote: > > Am 1

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 22:29, TeLeMan wrote: > On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: >> On 2012-05-23 13:02, Jan Kiszka wrote: >>> On 2012-05-23 11:11, TeLeMan wrote: On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: > On 2012-05-23 04:09, TeLeMan wrote: >> On Wed, May 23, 2012

Re: [Qemu-devel] [PATCH 10/21] qdev: do not propagate properties to subclasses

2012-05-23 Thread Andreas Färber
Am 24.05.2012 01:46, schrieb Andreas Färber: > Am 02.05.2012 13:31, schrieb Paolo Bonzini: >> As soon as we'll look up properties along the inheritance chain, we >> will have duplicates if class A defines some properties and its >> subclass B does not define any, because class_b->props will be >> l

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: > On 2012-05-23 13:02, Jan Kiszka wrote: >> On 2012-05-23 11:11, TeLeMan wrote: >>> On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: On 2012-05-23 04:09, TeLeMan wrote: > On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: >>

[Qemu-devel] buildbot failure in qemu on block_openbsd_current

2012-05-23 Thread qemu
The Buildbot has detected a new failure on builder block_openbsd_current while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_openbsd_current/builds/234 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: brad_openbsd_cur

[Qemu-devel] buildbot failure in qemu on block_openbsd_4.9

2012-05-23 Thread qemu
The Buildbot has detected a new failure on builder block_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_openbsd_4.9/builds/222 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_openbsd49 Build

Re: [Qemu-devel] [PATCH 10/21] qdev: do not propagate properties to subclasses

2012-05-23 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > As soon as we'll look up properties along the inheritance chain, we > will have duplicates if class A defines some properties and its > subclass B does not define any, because class_b->props will be > left equal to class_a->props. > > The solution here

Re: [Qemu-devel] [PATCH 09/21] qdev: move bus properties to a separate global

2012-05-23 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > Simple code movement in order to simplify future refactoring. > > Signed-off-by: Paolo Bonzini Thanks, re-verified all movements on qdev-props-4 and applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Andreas --

Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd

2012-05-23 Thread Michael Roth
On Thu, May 24, 2012 at 12:15:18AM +0200, Andreas Färber wrote: > Am 24.05.2012 00:02, schrieb Michael Roth: > > On Wed, May 23, 2012 at 06:25:36PM -0300, Luiz Capitulino wrote: > >> All the -Wno-redundant-decls warnings are still there on 5.1, if I remove > >> that > >> flag I still get the follo

Re: [Qemu-devel] Signal management in qemu-user

2012-05-23 Thread Peter Maydell
On 23 May 2012 23:38, Alex Barcelo wrote: > This *always* goes wrong without calling the signal handler I haven't looked too closely, but I suspect we're just not paying any attention to whether memory does or doesn't have the PROT_EXEC permission when we translate code from it. This is the kind

Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd

2012-05-23 Thread Michael Roth
On Thu, May 24, 2012 at 12:15:18AM +0200, Andreas Färber wrote: > Am 24.05.2012 00:02, schrieb Michael Roth: > > On Wed, May 23, 2012 at 06:25:36PM -0300, Luiz Capitulino wrote: > >> All the -Wno-redundant-decls warnings are still there on 5.1, if I remove > >> that > >> flag I still get the follo

Re: [Qemu-devel] Signal management in qemu-user

2012-05-23 Thread Andreas Färber
Am 24.05.2012 00:38, schrieb Alex Barcelo: >>> Running it in a i386 machine works and gives an output of "0x0d\n0x20". >>> Running it in a qemu-i386 segfaults. Because the self-modifying code >>> raises a SIGSEGV in the qemu (I understand that it is the method used by >>> qemu to handle self-modify

Re: [Qemu-devel] Signal management in qemu-user

2012-05-23 Thread Alex Barcelo
>> Running it in a i386 machine works and gives an output of "0x0d\n0x20". >> Running it in a qemu-i386 segfaults. Because the self-modifying code >> raises a SIGSEGV in the qemu (I understand that it is the method used by >> qemu to handle self-modifying code). But the sigprocmask disables the >>

Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd

2012-05-23 Thread Andreas Färber
Am 24.05.2012 00:02, schrieb Michael Roth: > On Wed, May 23, 2012 at 06:25:36PM -0300, Luiz Capitulino wrote: >> All the -Wno-redundant-decls warnings are still there on 5.1, if I remove >> that >> flag I still get the following ones. Michael, do you want me to fix the >> qemu-ga >> one for 1.1?

Re: [Qemu-devel] [PATCH 1.1] es1370: Fix debug code

2012-05-23 Thread malc
On Wed, 23 May 2012, Stefan Weil wrote: > When DEBUG_ES1370 is defined, the compiler shows these warnings: > [..snip..] Thanks, applied. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd

2012-05-23 Thread Michael Roth
On Wed, May 23, 2012 at 06:25:36PM -0300, Luiz Capitulino wrote: > On Wed, 23 May 2012 15:08:43 -0500 > Michael Roth wrote: > > > On Wed, May 23, 2012 at 03:48:03PM -0300, Luiz Capitulino wrote: > > > Build error found by buildbot: > > > > > > qga/commands-posix.c: In function 'qmp_guest_shutdo

Re: [Qemu-devel] [PATCH qom-next 5/6] target-i386: make initialize CPU in QOM way

2012-05-23 Thread Andreas Färber
Am 23.05.2012 18:39, schrieb Igor Mammedov: > Make CPU creation/initialization consistent with QOM object > behavior in this, by moving tcg and apic initialization from board > level into CPU's initfn/realize calls and cpu_model property setter. > > Which makes CPU object self-sufficient in respec

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-23 Thread Peter Maydell
On 23 May 2012 22:09, Igor Mammedov wrote: > For cpu-hotplug it was suggested to use device_add/del > interface for it. To do so in a generalized way hot-plugged cpu > should follow general QOM object creation sequence, i.e. >  - create new cpu instance >  - set properties >  - realize instance >

[Qemu-devel] [PATCH 1.1] es1370: Fix debug code

2012-05-23 Thread Stefan Weil
When DEBUG_ES1370 is defined, the compiler shows these warnings: hw/es1370.c: In function ‘es1370_update_voices’: hw/es1370.c:414: warning: format ‘%d’ expects type ‘int’, but argument 3 has type ‘size_t’ hw/es1370.c: In function ‘es1370_writel’: hw/es1370.c:582: warning: format ‘%d’ expects type

Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd

2012-05-23 Thread Luiz Capitulino
On Wed, 23 May 2012 15:08:43 -0500 Michael Roth wrote: > On Wed, May 23, 2012 at 03:48:03PM -0300, Luiz Capitulino wrote: > > Build error found by buildbot: > > > > qga/commands-posix.c: In function 'qmp_guest_shutdown': > > qga/commands-posix.c:65: error: 'environ' undeclared (first use in th

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-23 Thread Igor Mammedov
- Original Message - > From: "Peter Maydell" > To: "Igor Mammedov" > Cc: aligu...@us.ibm.com, "wei liu2" , > ehabk...@redhat.com, "stefano stabellini" > , s...@weilnetz.de, mtosa...@redhat.com, > qemu-devel@nongnu.org, ag...@suse.de, > blauwir...@gmail.com, a...@redhat.com, "jan kiszka"

Re: [Qemu-devel] [PATCH qom-next 00/59] QOM CPUState, part 4: CPU_COMMON

2012-05-23 Thread Blue Swirl
On Wed, May 23, 2012 at 3:07 AM, Andreas Färber wrote: > Hello, > > This series, based on qom-next and the two pending ARM cleanup patches, starts > moving fields from CPUArchState (CPU_COMMON) to QOM CPUState. It stops short > of moving all easily possible fields (i.e., those not depending on >

Re: [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-23 Thread Peter Maydell
On 23 May 2012 21:06, Crístian Viana wrote: > This would be the new code: > > snprintf((void *) w, 12, "QEMU %s", qemu_get_version()); /* char version[12] > */ > > I'm not sure of what value the pointer contains at that moment, > concatenating doesn't seem safe to me. What if w already contains a

[Qemu-devel] [PATCH 1.1] vga: Initialise VRAM with 0

2012-05-23 Thread Stefan Weil
The VNC code reads this memory before it is written by BIOS or other code. Avoid random values by setting the VRAM to 0. This bug was reported by Valgrind. Signed-off-by: Stefan Weil --- hw/vga.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/vga.c b/hw/vga.c index 1469680..80b8ec3 1

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Anthony Liguori
On 05/23/2012 03:28 PM, Blue Swirl wrote: On Wed, May 23, 2012 at 8:04 PM, Andreas Färber wrote: Am 23.05.2012 21:40, schrieb Blue Swirl: On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: Am 18.05.2012 11:49, schrieb TeLeMan: This breakage was introduced by the commit "memory: make phy

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Blue Swirl
On Wed, May 23, 2012 at 8:04 PM, Andreas Färber wrote: > Am 23.05.2012 21:40, schrieb Blue Swirl: >> On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: >>> Am 18.05.2012 11:49, schrieb TeLeMan: This breakage was introduced by the commit "memory: make phys_page_find() return an unadj

Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd

2012-05-23 Thread Michael Roth
On Wed, May 23, 2012 at 03:48:03PM -0300, Luiz Capitulino wrote: > Build error found by buildbot: > > qga/commands-posix.c: In function 'qmp_guest_shutdown': > qga/commands-posix.c:65: error: 'environ' undeclared (first use in this > function) > qga/commands-posix.c:65: error: (Each undeclared

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-23 Thread Jan Kiszka
On 2012-05-23 13:44, Peter Maydell wrote: > On 23 May 2012 17:39, Igor Mammedov wrote: >> @@ -295,6 +297,15 @@ static int apic_init_common(SysBusDevice *dev) >> >> sysbus_init_mmio(dev, &s->io_memory); >> >> +/* XXX: mapping more APICs at the same memory location */ >> +if (apic_mapped

Re: [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-23 Thread Crístian Viana
On 23-05-2012 13:11, Eric Blake wrote: pstrcat is more efficient than snprintf() - the former is dedicated to a single task, while the latter has to parse a format string and decode that it is doing a single %s expansion. In other words, just because *printf can do string concatenation doesn't m

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Andreas Färber
Am 23.05.2012 21:40, schrieb Blue Swirl: > On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: >> Am 18.05.2012 11:49, schrieb TeLeMan: >>> This breakage was introduced by the commit "memory: make >>> phys_page_find() return an unadjusted". >> >> You seem to have found the origin of your proble

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Blue Swirl
On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: > Am 18.05.2012 11:49, schrieb TeLeMan: >> This breakage was introduced by the commit "memory: make >> phys_page_find() return an unadjusted". > > You seem to have found the origin of your problem. If you also mention > the commit hash in your

Re: [Qemu-devel] [PATCH 10/15] Openrisc: add a simulation board

2012-05-23 Thread Blue Swirl
On Wed, May 23, 2012 at 7:54 AM, Jia Liu wrote: > Hi Blue, > > On Sat, May 19, 2012 at 3:51 PM, Blue Swirl wrote: >> On Thu, May 17, 2012 at 8:35 AM, Jia Liu wrote: >>> add a simulation board for openrisc. >>> >>> Signed-off-by: Jia Liu >>> --- >>>  Makefile.target   |    1 + >>>  hw/openrisc_s

[Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd

2012-05-23 Thread Luiz Capitulino
Build error found by buildbot: qga/commands-posix.c: In function 'qmp_guest_shutdown': qga/commands-posix.c:65: error: 'environ' undeclared (first use in this function) qga/commands-posix.c:65: error: (Each undeclared identifier is reported only once qga/commands-posix.c:65: error: for each

Re: [Qemu-devel] [PATCH 05/15] Openrisc: add exception support

2012-05-23 Thread Blue Swirl
On Wed, May 23, 2012 at 7:09 AM, Jia Liu wrote: > Hi Blue, > > On Sat, May 19, 2012 at 3:22 PM, Blue Swirl wrote: >> On Thu, May 17, 2012 at 8:35 AM, Jia Liu wrote: >>> add the openrisc exception support. >>> >>> Signed-off-by: Jia Liu >>> --- >>>  Makefile.target               |    2 +- >>>  t

Re: [Qemu-devel] How to create new target port?

2012-05-23 Thread Michael Eager
On 05/23/2012 08:59 AM, Stefan Weil wrote: Am 23.05.2012 16:37, schrieb Michael Eager: On 05/22/2012 11:18 PM, 陳韋任 wrote: I'm investigating adding a new target architecture to QEMU. Are there documents, how-to's, or other guidance on how to approach this? Or any advice? I noticed that there ar

[Qemu-devel] [PATCH 2/2] qemu-ga: Fix missing environ declaration

2012-05-23 Thread Luiz Capitulino
Commit 3674838cd05268954bb6473239cd7f700a79bf0f uses the environ global variable, but is relying on environ to be declared somewhere else. This worked for me because on F16 environ is declared in , but that doesn't happen in OpenBSD for example, causing a build failure. This commit fixes the buil

Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind

2012-05-23 Thread Gerd Hoffmann
On 05/22/12 17:29, Alon Levy wrote: > We can't initialize QXLDevSurfaceCreate field by field because it has a > pa hole, and so 4 bytes remain uninitialized when building on x86-64, so > just memset. So you get valgrind warnings for the hole? why? nobody should ever access the hole, so the missi

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-23 Thread Blue Swirl
On Tue, May 22, 2012 at 12:34 AM, Andreas Färber wrote: > Am 21.05.2012 20:20, schrieb Blue Swirl: >> On Mon, May 21, 2012 at 9:09 AM, Andreas Färber wrote: >>> Am 14.05.2012 23:22, schrieb Blue Swirl: On Mon, May 14, 2012 at 8:59 PM, Andreas Färber wrote: > Am 14.05.2012 21:54, schrieb

[Qemu-devel] [PATCH 1/2] configure: check if environ is declared

2012-05-23 Thread Luiz Capitulino
Some systems may declare environ automatically, others don't. Check for it. Signed-off-by: Luiz Capitulino --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure b/configure index b55a792..1f338f8 100755 --- a/configure +++ b/configure @@ -2831,6 +2831

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-05-23 Thread Luiz Capitulino
On Wed, 23 May 2012 10:01:02 -0600 Eric Blake wrote: > > #include > > +#include > > #include > > #include > > #include "qga/guest-agent-core.h" > > @@ -20,6 +21,10 @@ > > #include "qemu-queue.h" > > #include "host-utils.h" > > > > +#ifndef _GNU_SOURCE > > +extern char **environ; > > +

Re: [Qemu-devel] [PATCH 06/21] qdev: push "type" property up to Object

2012-05-23 Thread Paolo Bonzini
Il 23/05/2012 19:40, Andreas Färber ha scritto: > Paolo, please let me know if you're okay with my commit messages, then I > can override the author to be you as well (same for preceding one). Don't worry, you have carte blanche. :) Paolo

Re: [Qemu-devel] [PATCH 06/21] qdev: push "type" property up to Object

2012-05-23 Thread Andreas Färber
Am 23.05.2012 19:18, schrieb Paolo Bonzini: > Il 23/05/2012 19:06, Andreas Färber ha scritto: >> Am 02.05.2012 13:30, schrieb Paolo Bonzini: >>> Now that Object is a type, add an instance_init function and push >>> the "type" property from qdev to there. >>> >>> Signed-off-by: Paolo Bonzini >> >>

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 13:02, Jan Kiszka wrote: > On 2012-05-23 11:11, TeLeMan wrote: >> On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: >>> On 2012-05-23 04:09, TeLeMan wrote: On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: > Am 18.05.2012 11:49, schrieb TeLeMan: >> This breakage

Re: [Qemu-devel] [PATCH 06/21] qdev: push "type" property up to Object

2012-05-23 Thread Paolo Bonzini
Il 23/05/2012 19:06, Andreas Färber ha scritto: > Am 02.05.2012 13:30, schrieb Paolo Bonzini: >> Now that Object is a type, add an instance_init function and push >> the "type" property from qdev to there. >> >> Signed-off-by: Paolo Bonzini > > The rebased version from qdev-props-4 breaks and han

[Qemu-devel] [PATCH qom-next 3/6] target-i386: add cpu-model property to x86_cpu

2012-05-23 Thread Igor Mammedov
it's probably intermidiate step till cpu modeled as sub-classes. After then we probably could drop it. However it still could be used for overiding default cpu subclasses definition, and probably renamed to something like 'features'. v2: - remove accidential tcg_* init code move Signed-off-by:

[Qemu-devel] [PATCH qom-next 5/6] target-i386: make initialize CPU in QOM way

2012-05-23 Thread Igor Mammedov
Make CPU creation/initialization consistent with QOM object behavior in this, by moving tcg and apic initialization from board level into CPU's initfn/realize calls and cpu_model property setter. Which makes CPU object self-sufficient in respect of creation/initialization and matches a typical obj

Re: [Qemu-devel] [PATCH 06/21] qdev: push "type" property up to Object

2012-05-23 Thread Andreas Färber
Am 02.05.2012 13:30, schrieb Paolo Bonzini: > Now that Object is a type, add an instance_init function and push > the "type" property from qdev to there. > > Signed-off-by: Paolo Bonzini The rebased version from qdev-props-4 breaks and hangs `make check`: GTESTER check-qtest-sparc qemu-system-s

[Qemu-devel] [PATCH v2 06/15] net: Remove vlan qdev property

2012-05-23 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature is implemented using hubs and no longer uses special-purpose VLANState structs that are accessible as qdev properties. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/qdev-properties.c | 72 -

Re: [Qemu-devel] [PATCH v2 15/15] net: invoke qemu_can_send_packet only before net queue sending function

2012-05-23 Thread Paolo Bonzini
Il 23/05/2012 17:14, zwu.ker...@gmail.com ha scritto: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > net/queue.c |4 ++-- > net/slirp.c |7 --- > net/tap.c|2 +- > slirp/if.c |5 - > slirp/libslirp.h |1 - > 5 files changed, 3 inse

Re: [Qemu-devel] [PATCH 05/21] qom: assert that public types have a non-NULL parent field

2012-05-23 Thread Andreas Färber
Am 02.05.2012 14:35, schrieb Andreas Färber: > Am 02.05.2012 13:30, schrieb Paolo Bonzini: >> This protects against unwanted effects of changing TYPE_OBJECT from >> NULL to a string. Suggested by Andreas Faerber. >> >> Signed-off-by: Paolo Bonzini >> --- >> include/qemu/object.h |1 - >> qom

[Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to qom/object.c

2012-05-23 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 487 + hw/qdev.c | 47 + hw/qdev.h | 87 - include/qemu/object.h | 98 ++ qom/object.c | 459 ++

[Qemu-devel] [PATCH qom-next 1/6] pc: Enable MSI support at APIC level

2012-05-23 Thread Igor Mammedov
From: Jan Kiszka Push msi_supported enabling to the APIC implementations where we can encapsulate the decision more cleanly, hiding the details from the generic code. Acked-by: Stefano Stabellini Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/apic.c |3 +++ hw/pc.c

[Qemu-devel] [PATCH 06/10] qdev: generalize properties to Objects

2012-05-23 Thread Paolo Bonzini
The property machinery uses DeviceState arguments in a few places. Replace this with Object so that we can push properties up. Signed-off-by: Paolo Bonzini --- hw/qdev-addr.c | 19 +++--- hw/qdev-properties.c | 180 +- hw/qdev.c

Re: [Qemu-devel] [PATCH 04/21] qom: make Object a type

2012-05-23 Thread Andreas Färber
Am 16.05.2012 10:16, schrieb Andreas Färber: > Am 02.05.2012 13:30, schrieb Paolo Bonzini: >> Right now the base Object class has a special NULL type. Change this so >> that we will be able to add class_init and class_base_init callbacks. >> To do this, remove some special casing of ObjectClass th

[Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-23 Thread Igor Mammedov
Move from apic_init in pc.c, the code that belongs to apic_init_common. Signed-off-by: Igor Mammedov --- hw/apic_common.c | 11 +++ hw/msi.h |2 ++ hw/pc.c | 12 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/apic_common.c b/hw/a

[Qemu-devel] [PATCH qom-next 2/6] target-i386: move cpu halted decision into x86_cpu_reset

2012-05-23 Thread Igor Mammedov
From: Igor Mammedov MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in implementing MP initialization protocol in qemu. Thus first CPU is always m

Re: [Qemu-devel] [PATCH qom-next 4/6] pc: move apic_mapped initialization into common apic init code

2012-05-23 Thread Peter Maydell
On 23 May 2012 17:39, Igor Mammedov wrote: > @@ -295,6 +297,15 @@ static int apic_init_common(SysBusDevice *dev) > >     sysbus_init_mmio(dev, &s->io_memory); > > +    /* XXX: mapping more APICs at the same memory location */ > +    if (apic_mapped == 0) { > +        /* NOTE: the APIC is directly

[Qemu-devel] [PATCH qom-next 6/6] target-i386: move reset callback to cpu.c

2012-05-23 Thread Igor Mammedov
Moving reset callback into cpu object from board level will allow properly create object during run-time (hotplug). When reset over QOM hierarchy is implemented, this reset callback should be removed. v2: - fix build for i386-linux-target Signed-off-by: Igor Mammedov --- hw/pc.c |

[Qemu-devel] [PATCH qom-next v2 0/6] target-i386: re-factor CPU creation/initialization to QOM

2012-05-23 Thread Igor Mammedov
Moving code related to CPU creation and initialization internal parts from board level into apic and cpu objects will allow X86CPU to better model QOM object life-cycle. It will allow to create X86CPU as any other object by creating it with object_new() then setting properties and then calling x86_

[Qemu-devel] [PATCH 05/10] qdev: push state up to Object

2012-05-23 Thread Paolo Bonzini
qdev properties use the state member (an embryo of the "realized" property) in order to disable setting them after a device has been initialized. So, in order to push qdev properties up to Object we need to push this bit there too. Signed-off-by: Paolo Bonzini --- hw/qdev-addr.c|3 +

[Qemu-devel] [PATCH 10/10] qom: Add QERR_PROPERTY_SET_AFTER_REALIZE

2012-05-23 Thread Paolo Bonzini
From: Peter Maydell Add a new QError QERR_PROPERTY_SET_AFTER_REALIZE for attempts to set a QOM or qdev property after the object/device has been realized. This allows a slightly more informative diagnostic than the previous "Insufficient permission" message. Signed-off-by: Peter Maydell Signed-

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-05-23 Thread Michael Roth
On Wed, May 23, 2012 at 12:57:11PM -0300, Luiz Capitulino wrote: > On Wed, 23 May 2012 11:35:49 -0300 > Luiz Capitulino wrote: > > > > Maybe we need a patch to declare environ for openbsd > > > > Yes, I have the patch already but am installing openbsd on a VM to test it. > > I'm getting lots of

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Dave Hansen
On 05/23/2012 01:48 AM, Peter Zijlstra wrote: > On Wed, 2012-05-23 at 16:34 +0800, Liu ping fan wrote: >> > so we need to migrate some of vcpus from node-B to node-A, or to >> > node-C. > This is absolutely broken, you cannot do that. > > A guest task might want to be node affine, it looks at the

[Qemu-devel] [PATCH 02/10] qdev: remove qdev_prop_exists

2012-05-23 Thread Paolo Bonzini
Can be replaced everywhere with object_property_find. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c |5 - hw/qdev.c |2 +- hw/qdev.h |1 - hw/scsi-bus.c |2 +- include/qemu/object.h |9 + qom/object.c |2 +- 6

Re: [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-23 Thread Eric Blake
On 05/23/2012 10:08 AM, Crístian Viana wrote: >> So when you posted the previous version of your patch it was pointed >> out that this is a buffer overflow: >> http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg01657.html >> >> You need to fix this. > > I have sent a reply to that thread exp

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-05-23 Thread Luiz Capitulino
On Wed, 23 May 2012 18:06:18 +0200 Paolo Bonzini wrote: > Il 23/05/2012 17:57, Luiz Capitulino ha scritto: > > On Wed, 23 May 2012 11:35:49 -0300 > > Luiz Capitulino wrote: > > > >>> Maybe we need a patch to declare environ for openbsd > >> > >> Yes, I have the patch already but am installing o

Re: [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-23 Thread Crístian Viana
Hi Peter, Thanks for all your tips! OK, this has been bugging me for the last three versions, and since I'm complaining about other things anyway: can you reword this commit message, please, so that it is a standalone paragraph explaining (a) what the commit does and (b) why it is doing it, rat

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-05-23 Thread Paolo Bonzini
Il 23/05/2012 17:57, Luiz Capitulino ha scritto: > On Wed, 23 May 2012 11:35:49 -0300 > Luiz Capitulino wrote: > >>> Maybe we need a patch to declare environ for openbsd >> >> Yes, I have the patch already but am installing openbsd on a VM to test it. > > I'm getting lots of make errors on openb

Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts

2012-05-23 Thread Stefan Weil
Am 23.05.2012 17:32, schrieb Kevin Wolf: Am 23.05.2012 17:29, schrieb Stefan Weil: Am 23.05.2012 10:09, schrieb Stefan Hajnoczi: On Tue, May 22, 2012 at 10:23 PM, Stefan Weil wrote: The local variables ret, i are only used if __linux__ is defined. Signed-off-by: Stefan Weil --- hw/virtio

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 11:11, TeLeMan wrote: > On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: >> On 2012-05-23 04:09, TeLeMan wrote: >>> On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: Am 18.05.2012 11:49, schrieb TeLeMan: > This breakage was introduced by the commit "memory: make >>>

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-05-23 Thread Eric Blake
On 05/23/2012 09:57 AM, Luiz Capitulino wrote: > > Anyone knows what I did wrong? Or, if anybody could test the attached fix... Sorry, I'm not in a position to test the patch, but I can at least review it. > > > 0001-qemu-ga-Fix-missing-environ-declarion.patch > > >>From 4a3f4cff8aa27fe3810

[Qemu-devel] [PATCH v2 08/15] net: Remove VLANState

2012-05-23 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 127 ++--- net.h |8 net/socket.c |6 +- net/tap.c |6 +- net/

Re: [Qemu-devel] How to create new target port?

2012-05-23 Thread Stefan Weil
Am 23.05.2012 16:37, schrieb Michael Eager: On 05/22/2012 11:18 PM, 陳韋任 wrote: I'm investigating adding a new target architecture to QEMU. Are there documents, how-to's, or other guidance on how to approach this? Or any advice? I noticed that there are a number of directories for architecture

[Qemu-devel] [PATCH v2 05/15] net: Drop vlan argument to qemu_new_net_client()

2012-05-23 Thread zwu . kernel
From: Stefan Hajnoczi Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27

Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-05-23 Thread Luiz Capitulino
On Wed, 23 May 2012 11:35:49 -0300 Luiz Capitulino wrote: > > Maybe we need a patch to declare environ for openbsd > > Yes, I have the patch already but am installing openbsd on a VM to test it. I'm getting lots of make errors on openbsd 4.9: "Makefile", line 7: Missing dependency operator "/r

[Qemu-devel] [PATCH 04/10] qom: add get_id

2012-05-23 Thread Paolo Bonzini
Some classes may present objects differently in errors, for example if they are not part of the composition tree or if they are not assigned an id by the user. Let them do this with a get_id method on Object, and use the method consistently where a %(device) appears in the error. Signed-off-by: P

[Qemu-devel] [PATCH v2 15/15] net: invoke qemu_can_send_packet only before net queue sending function

2012-05-23 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/queue.c |4 ++-- net/slirp.c |7 --- net/tap.c|2 +- slirp/if.c |5 - slirp/libslirp.h |1 - 5 files changed, 3 insertions(+), 16 deletions(-) diff --git a/net/queue.c b/net/queue.c index 0

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Peter Zijlstra
On Wed, 2012-05-23 at 08:23 -0700, Dave Hansen wrote: > On 05/23/2012 01:48 AM, Peter Zijlstra wrote: > > On Wed, 2012-05-23 at 16:34 +0800, Liu ping fan wrote: > >> > so we need to migrate some of vcpus from node-B to node-A, or to > >> > node-C. > > This is absolutely broken, you cannot do that.

[Qemu-devel] [PATCH v2 14/15] net: cleanup deliver/deliver_iov func pointers

2012-05-23 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 insertions(+), 48 deletions(-) diff --git a/net.c b/net.c index 8

[Qemu-devel] [PATCH v2 07/15] net: Remove vlan code from net.c

2012-05-23 Thread zwu . kernel
From: Stefan Hajnoczi The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1

[Qemu-devel] [PATCH v2 04/15] hub: Check that hubs are configured correctly

2012-05-23 Thread zwu . kernel
From: Stefan Hajnoczi Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks perfo

Re: [Qemu-devel] [PATCH] ahci: SATA FIS is 20 bytes, not 0x20

2012-05-23 Thread Stefan Weil
Am 23.05.2012 01:26, schrieb Daniel Verkamp: As in the SATA and AHCI specifications, a FIS is 5 Dwords of 4 bytes each, which comes to 20 bytes (decimal), not 0x20. Signed-off-by: Daniel Verkamp --- hw/ide/ahci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i

  1   2   3   >