Re: [Qemu-devel] [PATCH] Revert "rtl8139: do the network/host communication only in normal operating mode"

2012-05-13 Thread Michael S. Tsirkin
On Mon, May 14, 2012 at 01:31:22PM +0800, Jason Wang wrote: > On 05/10/2012 07:05 PM, Michael S. Tsirkin wrote: > >On Thu, May 10, 2012 at 05:31:56PM +0800, Jason Wang wrote: > >>On 05/10/2012 04:54 PM, Michael S. Tsirkin wrote: > >>>On Thu, May 10, 2012 at 04:37:22PM +0800, Jason Wang wrote: > >>>

[Qemu-devel] [PULL] Fixes for QEMU 1.1

2012-05-13 Thread Stefan Weil
Hello Anthony, here are some patches with bug fixes for 1.1. Regards, Stefan W. The following changes since commit 94d1991445fa3582c042ee4e5b72606e2fc39cc2: sun4u: implement interrupt clearing registers (2012-05-12 09:49:19 +) are available in the git repository at: git://qemu.weil

Re: [Qemu-devel] [PATCH] Revert "rtl8139: do the network/host communication only in normal operating mode"

2012-05-13 Thread Jason Wang
On 05/10/2012 07:05 PM, Michael S. Tsirkin wrote: On Thu, May 10, 2012 at 05:31:56PM +0800, Jason Wang wrote: On 05/10/2012 04:54 PM, Michael S. Tsirkin wrote: On Thu, May 10, 2012 at 04:37:22PM +0800, Jason Wang wrote: This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is beca

Re: [Qemu-devel] [PATCH 2/2] cadence_gem: avoid stack-writing buffer-overrun

2012-05-13 Thread Peter Crosthwaite
ACK and Thanks Jim, Reviewed-by: Peter A.G. Crosthwaite On Fri, May 11, 2012 at 2:19 AM, Jim Meyering wrote: > From: Jim Meyering > > Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number > of bytes to clear.  The latter would always clear 4 or 8 > bytes, possibly writing beyond the en

Re: [Qemu-devel] [PATCH] kernel vfio: PCI ROM size calculation

2012-05-13 Thread Alex Williamson
On Mon, 2012-05-14 at 13:24 +1000, Alexey Kardashevskiy wrote: > On 14/05/12 12:55, Alex Williamson wrote: > > On Sat, 2012-05-12 at 16:50 +1000, Alexey Kardashevskiy wrote: > >> The original code calculated the real size of the ROM and passed it to > >> QEMU which tried to do pci_register_bar and

[Qemu-devel] sigaction in windows

2012-05-13 Thread bang bang
Hi, everyone: I am very sorry to trouble you, but I have a question that need your help. As we know, sigaction is not defined in windows, but qemu can run on windows, I want to know how the qemu to implement sigaction so that it can run on windows an linux. I am very sorry to not find their im

Re: [Qemu-devel] [PATCH 02/13] iommu: IOMMU Groups

2012-05-13 Thread David Gibson
On Fri, May 11, 2012 at 04:55:41PM -0600, Alex Williamson wrote: > IOMMU device groups are currently a rather vague associative notion > with assembly required by the user or user level driver provider to > do anything useful. This patch intends to grow the IOMMU group concept > into something a b

Re: [Qemu-devel] vfio with iommu groups

2012-05-13 Thread Benjamin Herrenschmidt
On Sun, 2012-05-13 at 22:16 -0600, Alex Williamson wrote: > > However theoretically we might want to show these 3 PCIe bridges as well > > (but not the root complex). > > For example, INTx lines should be swizzled when the guest parses a device > > tree and > > tries to calculate a real IRQ numbe

Re: [Qemu-devel] [RFC PATCH] qemu spapr-pci: added IRQ list to PCIBus

2012-05-13 Thread Alexey Kardashevskiy
On 14/05/12 11:58, David Gibson wrote: > On Sat, May 12, 2012 at 05:29:53PM +1000, Alexey Kardashevskiy wrote: >> There is a need for a mechanism to obtain an IRQ line number to >> initialize End-Of-Interrupt handler. >> >> There is another proposed solution (commit >> b7790763828b732059ad24ba0e64c

Re: [Qemu-devel] vfio with iommu groups

2012-05-13 Thread Alex Williamson
On Sat, 2012-05-12 at 17:31 +1000, Alexey Kardashevskiy wrote: > Hi! > > I pulled new VFIO from github, ported to POWER and got some issues/thoughts > which I post as patches. > However PCI bridges handling is an open question to discuss. > > My test setup includes PCIe card Intel E1000E which l

Re: [Qemu-devel] [RFC PATCH] kernel vfio: enabled and supported on power

2012-05-13 Thread Alex Williamson
On Sat, 2012-05-12 at 17:31 +1000, Alexey Kardashevskiy wrote: > The idea of the patch is to demonstrate what POWER needs to support VFIO. > > Added support on POWER. Than includes: > > 1) IOMMU API driver for POWER. > It also includes subsys_initcall_sync(power_pci_iommu_init) which walks > thr

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-05-13 Thread Alexey Kardashevskiy
On 12/05/12 00:13, Alexander Graf wrote: > > On 11.05.2012, at 14:47, Alexey Kardashevskiy wrote: > >> 11.05.2012 20:52, Alexander Graf написал: >>> >>> On 11.05.2012, at 08:45, Alexey Kardashevskiy wrote: >>> Normally the pci_add_capability is called on devices to add new capability. T

Re: [Qemu-devel] [PATCH] kernel vfio: PCI ROM size calculation

2012-05-13 Thread Alexey Kardashevskiy
On 14/05/12 12:55, Alex Williamson wrote: > On Sat, 2012-05-12 at 16:50 +1000, Alexey Kardashevskiy wrote: >> The original code calculated the real size of the ROM and passed it to >> QEMU which tried to do pci_register_bar and failed with error message >> "ERROR: PCI region size must be pow2". >>

Re: [Qemu-devel] [PATCH] kernel vfio: PCI ROM size calculation

2012-05-13 Thread Alex Williamson
On Sat, 2012-05-12 at 16:50 +1000, Alexey Kardashevskiy wrote: > The original code calculated the real size of the ROM and passed it to > QEMU which tried to do pci_register_bar and failed with error message > "ERROR: PCI region size must be pow2". > > The example card is PCIe Intel E1000E with th

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-05-13 Thread Alex Williamson
On Sat, 2012-05-12 at 10:27 +1000, Alexey Kardashevskiy wrote: > 12.05.2012 5:20, Jason Baron написал: > > On Fri, May 11, 2012 at 04:45:21PM +1000, Alexey Kardashevskiy wrote: > >> Normally the pci_add_capability is called on devices to add new > >> capability. This is ok for emulated devices whic

Re: [Qemu-devel] [RFC PATCH] qemu spapr-pci: added IRQ list to PCIBus

2012-05-13 Thread David Gibson
On Sat, May 12, 2012 at 05:29:53PM +1000, Alexey Kardashevskiy wrote: > There is a need for a mechanism to obtain an IRQ line number to > initialize End-Of-Interrupt handler. > > There is another proposed solution (commit > b7790763828b732059ad24ba0e64ce327563fe1a "pci: Add callbacks > to support

Re: [Qemu-devel] [PATCH 01/32] target-arm: initial coprocessor register framework

2012-05-13 Thread Andreas Färber
Am 15.04.2012 15:45, schrieb Peter Maydell: > Initial infrastructure for data-driven registration of > coprocessor register implementations. > > We still fall back to the old-style switch statements pending > complete conversion of all existing registers. > > Signed-off-by: Peter Maydell > --- >

Re: [Qemu-devel] [PATCH qom-next] nseries: Rename n800_s::cpu to mpu

2012-05-13 Thread Andreas Färber
Am 13.05.2012 23:20, schrieb Peter Maydell: > On 13 May 2012 21:29, Andreas Färber wrote: >> omap_mpu_state_s::env was renamed to cpu while changing its type. >> With n800_s::cpu of type omap_mpu_state_s* this leads to s->cpu->cpu. >> >> Rename the field to "mpu" to avoid this ugliness. >> >> Sign

Re: [Qemu-devel] [PATCH qom-next] nseries: Rename n800_s::cpu to mpu

2012-05-13 Thread Peter Maydell
On 13 May 2012 21:29, Andreas Färber wrote: > omap_mpu_state_s::env was renamed to cpu while changing its type. > With n800_s::cpu of type omap_mpu_state_s* this leads to s->cpu->cpu. > > Rename the field to "mpu" to avoid this ugliness. > > Signed-off-by: Andreas Färber > Cc: Peter Maydell Ack

[Qemu-devel] x86 AREG0 patches

2012-05-13 Thread Blue Swirl
Hi, A preview of x86 AREG0 patches can be found at the usual place: URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git This is obviously 1.2 material.

Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store ARMCPU in omap_mpu_state_s

2012-05-13 Thread Andreas Färber
Am 11.05.2012 14:52, schrieb Andreas Färber: > Am 10.05.2012 23:38, schrieb Peter Maydell: >> On 10 May 2012 01:14, Andreas Färber wrote: >>> Fix tab indentations of comments, add braces, use cpu_reset(). >>> >>> Signed-off-by: Andreas Färber >>> --- >>> hw/nseries.c |6 +++--- >>> hw/omap.

[Qemu-devel] [PATCH qom-next] nseries: Rename n800_s::cpu to mpu

2012-05-13 Thread Andreas Färber
omap_mpu_state_s::env was renamed to cpu while changing its type. With n800_s::cpu of type omap_mpu_state_s* this leads to s->cpu->cpu. Rename the field to "mpu" to avoid this ugliness. Signed-off-by: Andreas Färber Cc: Peter Maydell --- hw/nseries.c | 72 +---

[Qemu-devel] [Bug 998435] Re: qemu-kvm-spice doesn't support spice/qxl installs

2012-05-13 Thread Boris Derzhavets
Normal start in my system :- boris@boris-System-Product-P5Q3:~$ sudo /usr/bin/kvm -cpu host -enable-kvm -name WIN7 -m 2048 -drive file=/dev/sda7,if=ide,media=disk,aio=native,cache=off -net nic,model=rtl8139 -net user -localtime -usb -vga qxl -spice port=5900,disable-ticketing -cdrom /home/bori

[Qemu-devel] [Bug 998435] Re: qemu-kvm-spice doesn't support spice/qxl installs

2012-05-13 Thread Boris Derzhavets
>It has nothing to do with spice enabled qemu version. Not exactly :- boris@boris-P5Q-E:~$ sudo /usr/bin/kvm-spice -cpu host -enable-kvm -name W7 -m 2048 -drive file=/dev/sda7,if=virtio,media=disk,aio=native,cache=off -net nic,model=rtl8139 -net user -localtime -usb -vga qxl -spice port=5900 ,dis

[Qemu-devel] [PATCH 7/7] mips_fulong2e: Don't register "cpu" VMState twice

2012-05-13 Thread Andreas Färber
From: Juan Quintela We have the following simplified callgraph in mips_fulong2e_init(): cpu_init() => cpu_mips_init() object_new() mips_cpu_initfn() cpu_exec_init() register_savevm(NULL, "cpu", cpu_index, CPU_SAVE_VERSION, cpu_save, cpu_loa

[Qemu-devel] [PATCH 6/7] pc: Add back PCI.rombar compat property

2012-05-13 Thread Andreas Färber
From: Paolo Bonzini This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84 (pc: reduce duplication in compat machine types). Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber Acked-by: Michael S. Tsirkin --- hw/pc_piix.c |4 1 files changed, 4 insertions(+

[Qemu-devel] [PATCH 3/7] target-i386: Defer MCE init

2012-05-13 Thread Andreas Färber
Commit de024815e3b523addf58f1f79846b7fe74643678 (target-i386: QOM'ify CPU init) moved mce_init() call from helper.c:cpu_x86_init() into X86CPU's cpu.c:x86_cpu_initfn(). mce_init() checks for a family >= 6 though, so we could end up with a sequence such as for -cpu somecpu,family=6: x86_cpu_initf

[Qemu-devel] [PULL for-1.1-rc2] Fixes from QOM-related series

2012-05-13 Thread Andreas Färber
Hello Anthony, Please pull the following patches cherry-picked from various QOM-related series. I've dropped Paolo's "Fix -device foo,?" since you already had that queued. QMP patches will be handled by Luiz. Cc: Anthony Liguori If there's other QOM bugfixes or cleanups for 1.1 that I've missed

Re: [Qemu-devel] [PATCH] mips: Fix BC1ANY[24]F instructions

2012-05-13 Thread Andreas Färber
Am 26.11.2011 14:37, schrieb Richard Sandiford: > There's some dodgy application of De Morgan's law in the emulation > of the MIPS BC1ANY[24]F instructions: they end up branching only > if all CCs are false, rather than if one CC is. > > Tested on mips64-linux-gnu, where it fixes the GCC MIPS3D te

[Qemu-devel] [PATCH 4/7] qdev: Use object_property_print() in info qtree

2012-05-13 Thread Andreas Färber
From: Paolo Bonzini Otherwise, non-string properties without a legacy counterpart are missed. Also fix error propagation in object_property_print() itself. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Signed-off-by: Andreas Färber --- hw/qdev-monitor.c |2 +- qom/object.c

[Qemu-devel] [PATCH 5/7] qdev: Fix adding of ptr properties

2012-05-13 Thread Andreas Färber
From: Anthony Liguori ptr properties have neither a get/set or a print/parse which means that when they're added they aren't treated as static or legacy properties. Just assume properties like this are legacy properties and treat them as such. Signed-off-by: Anthony Liguori Signed-off-by: Paol

[Qemu-devel] [PATCH 1/7] target-mips: Remove commented-out function declaration

2012-05-13 Thread Andreas Färber
There is no function cpu_mips_get_clock(), so drop it. Signed-off-by: Andreas Färber Acked-by: Stefan Weil --- target-mips/cpu.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index c0f8826..44c1152 100644 --- a/target-mips/cpu.h +

[Qemu-devel] [PATCH 2/7] qom: Documentation addition for object_class_by_name()

2012-05-13 Thread Andreas Färber
From: Paolo Bonzini Signed-off-by: Paolo Bonzini [AF: Document the possible NULL return value] Signed-off-by: Andreas Färber --- include/qemu/object.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index ca1649c..d93b

Re: [Qemu-devel] [PATCH 17/35] mips_fulong2e: cpu vmstate already registered in cpu_exec_init

2012-05-13 Thread Andreas Färber
Am 04.05.2012 12:54, schrieb Juan Quintela: > This is the second place that register cpu migration code, it is done > in general in cpu_exec_init(), just remove this call. > > Signed-off-by: Juan Quintela Thanks, I've queued this for qom-1.1 (with extended commit message): http://repo.or.cz/w/qe

Re: [Qemu-devel] [PATCH for-1.1 v2] pc: Add back PCI.rombar compat property

2012-05-13 Thread Andreas Färber
Am 13.05.2012 16:40, schrieb Michael S. Tsirkin: > On Sat, May 12, 2012 at 04:21:06PM +0200, Andreas Färber wrote: >> From: Paolo Bonzini >> >> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84 >> (pc: reduce duplication in compat machine types). >> >> Cc: Michael S. Tsirkin

[Qemu-devel] [Bug 998435] Re: qemu-kvm-spice doesn't support spice/qxl installs

2012-05-13 Thread Boris Derzhavets
Alon, I testedF16 and W7. Installs attempted via VIrtManager (spice/qx l, spice/vga) poped up black screen for ever. F17 (beta) requires several minutes to activate SPICE/QXL install window, and behaves same way during runtime. Any Spice-Gtk build mentioned in #1 does it in few sec

[Qemu-devel] fixing qemu-0.1X endless loop in qcow2_alloc_cluster_offset

2012-05-13 Thread Zhouyi Zhou
hi all sometimes, qemu/kvm-0.1x will hang in endless loop in qcow2_alloc_cluster_offset. after some investigation, I found that: in function posix_aio_process_queue(void *opaque) 440 ret = qemu_paio_error(acb); 441 if (ret == ECANCELED) { 442 /* rem

Re: [Qemu-devel] [PATCH for-1.1 v2] pc: Add back PCI.rombar compat property

2012-05-13 Thread Michael S. Tsirkin
On Sat, May 12, 2012 at 04:21:06PM +0200, Andreas Färber wrote: > From: Paolo Bonzini > > This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84 > (pc: reduce duplication in compat machine types). > > Cc: Michael S. Tsirkin > Signed-off-by: Paolo Bonzini > Signed-off-by: Andr

Re: [Qemu-devel] [PATCH for-1.1 v2] pc: Add back PCI.rombar compat property

2012-05-13 Thread Michael S. Tsirkin
On Sun, May 13, 2012 at 03:53:55PM +0200, Andreas Färber wrote: > Am 13.05.2012 12:59, schrieb Michael S. Tsirkin: > > On Sat, May 12, 2012 at 04:21:06PM +0200, Andreas Färber wrote: > >> From: Paolo Bonzini > >> > >> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84 > >> (p

Re: [Qemu-devel] [PATCH for-1.1 v2] pc: Add back PCI.rombar compat property

2012-05-13 Thread Andreas Färber
Am 13.05.2012 12:59, schrieb Michael S. Tsirkin: > On Sat, May 12, 2012 at 04:21:06PM +0200, Andreas Färber wrote: >> From: Paolo Bonzini >> >> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84 >> (pc: reduce duplication in compat machine types). >> >> Cc: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature

2012-05-13 Thread Michael S. Tsirkin
On Sun, May 13, 2012 at 03:02:58PM +0300, Michael S. Tsirkin wrote: > On Fri, May 11, 2012 at 06:47:43AM -0600, Eric Blake wrote: > > [adding libvirt, dropping kernel] > > > > On 05/11/2012 01:43 AM, Michael S. Tsirkin wrote: > > > Whitelist kvm pv eoi feature. The feature is enabled > > > with -c

Re: [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature

2012-05-13 Thread Michael S. Tsirkin
On Fri, May 11, 2012 at 06:47:43AM -0600, Eric Blake wrote: > [adding libvirt, dropping kernel] > > On 05/11/2012 01:43 AM, Michael S. Tsirkin wrote: > > Whitelist kvm pv eoi feature. The feature is enabled > > with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi. > > > > Signed-off-by: Michael S. Ts

Re: [Qemu-devel] [PATCH for-1.1 v2] pc: Add back PCI.rombar compat property

2012-05-13 Thread Michael S. Tsirkin
On Sat, May 12, 2012 at 04:21:06PM +0200, Andreas Färber wrote: > From: Paolo Bonzini > > This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84 > (pc: reduce duplication in compat machine types). > > Cc: Michael S. Tsirkin > Signed-off-by: Paolo Bonzini > Signed-off-by: Andr

Re: [Qemu-devel] [PATCH] pci: unplug all devs of same slot once

2012-05-13 Thread Michael S. Tsirkin
On Fri, May 11, 2012 at 10:57:25PM +0800, Amos Kong wrote: > The whole PCI slot should be removed once. Currently only one func > is cleaned in pci_unplug_device(), if you try to remove a single > func by monitor cmd. > > Start VM with 8 multiple-function block devs, hot-removing > those block dev

[Qemu-devel] [Bug 998435] Re: qemu-kvm-spice doesn't support spice/qxl installs

2012-05-13 Thread Alon Levy
Hi Boris, I don't get it - what is the error exactly? I don't use qemu-kvm-spice on ubuntu, but maybe I could help if you provided more details, like the qemu command line, the output on stdout/stderr, for both cases, spice+qxl and spice+not-qxl Thanks, Alon -- You received this bug notificati