Re: [Qemu-devel] qemu physical address

2012-04-20 Thread Blue Swirl
On Thu, Apr 19, 2012 at 22:56, Xin Tong wrote: > On Thu, Apr 19, 2012 at 1:03 PM, Blue Swirl wrote: >> On Thu, Apr 19, 2012 at 01:55, Xin Tong wrote: >>> but should not the address be within 1 - 4G-1 even with PAE. is not >>> the PAE just using 64bits addresses as supposed to 32 bit ? what does

Re: [Qemu-devel] [PATCH 3/4] sparc: fix qtest

2012-04-20 Thread Blue Swirl
On Thu, Apr 19, 2012 at 20:48, Peter Maydell wrote: > On 19 April 2012 21:27, Blue Swirl wrote: >> @@ -119,7 +120,9 @@ CPUSPARCState *cpu_sparc_init(const char *cpu_model) >>     cpu = SPARC_CPU(object_new(TYPE_SPARC_CPU)); >>     env = &cpu->env; >> >> -    gen_intermediate_code_init(env); >> +

Re: [Qemu-devel] [PATCH v2 0/4] QOM'ify Motorola 68k CPU

2012-04-20 Thread Andreas Färber
Am 15.04.2012 05:10, schrieb Andreas Färber: > Hello, > > This series splits up my m68k QOM'ification patch from the qom-cpu-others RFC > series. > CPU models are now modelled as subclasses with their own initfns, leaving the > setting of feature flags imperative. > > Please review and apply. P

Re: [Qemu-devel] [PATCH v2 0/3] QOM'ify CRIS CPU

2012-04-20 Thread Andreas Färber
Am 12.04.2012 01:00, schrieb Andreas Färber: > Hello Edgar, > > This series strips down my CRIS QOM'ification patch from the qom-cpu-others.v1 > RFC series and splits it into multiple steps. I still think the code is > calling for subclasses for crisv8 etc. but, given the timing, my priority is >

Re: [Qemu-devel] [PATCH v3 0/3] QOM'ify MicroBlaze CPU

2012-04-20 Thread Andreas Färber
Am 12.04.2012 13:20, schrieb Andreas Färber: > Hi Edgar, > > Here's a rebased version of MicroBlaze CPU QOM'ification. Ping! Any problem or just lack of time? Hard Freeze is Monday in a week... I'd have one additional optional change to cpu_mb_init() for a v4, so let me know if I need to change a

Re: [Qemu-devel] [RFC PATCH v1 2/4] m25p80: initial verion

2012-04-20 Thread Andreas Färber
Hi Peter, Am 19.04.2012 04:33, schrieb Peter Crosthwaite: > So is there any standard policy on setting maintainer-ships for device > models? When I pushed the cadence IP device models (hw/cadence*) for > xilinx zynq there was insistence that they be in the MAINTAINERS, Yes, that was my request.

[Qemu-devel] [PATCH 14/16] net: net_client_init(): use error_set()

2012-04-20 Thread Luiz Capitulino
Callers are changed to use qerror_report_err() to keep their QError semantics. Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c |8 ++-- hw/usb/dev-network.c |7 +-- net.c| 53 +++--- net.h|2

[Qemu-devel] [PATCH 04/16] qemu-option: parse_option_size(): use error_set()

2012-04-20 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-option.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index a8b50af..61354af 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -203,7 +203,8 @@ static void parse_option_number(cons

[Qemu-devel] [PATCH 15/16] qapi: convert netdev_add

2012-04-20 Thread Luiz Capitulino
This is not a full QAPI conversion, but an intermediate step. In essence, do_netdev_add() is split into three functions: 1. netdev_add(): performs the actual work. This function is fully converted to Error (thus, it's "qapi-friendly") 2. qmp_netdev_add(): the QMP front-end for netdev_add()

[Qemu-devel] [PATCH 07/16] qemu-option: opt_set(): use error_set()

2012-04-20 Thread Luiz Capitulino
The functions qemu_opt_set() and opts_do_parse() both call opt_set(), but their callers expect QError semantics. Thus, both functions call qerro_report_err() to keep the expected semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 31 --- 1 file changed, 2

[Qemu-devel] [PATCH 06/16] qemu-option: qemu_opts_validate(): use error_set()

2012-04-20 Thread Luiz Capitulino
net_client_init() propagates the error up by calling qerror_report_err(), because its users expect QError semantics. Signed-off-by: Luiz Capitulino --- net.c |6 +- qemu-option.c | 13 + qemu-option.h |2 +- 3 files changed, 11 insertions(+), 10 deletions(-) di

[Qemu-devel] [PATCH 16/16] qapi: convert netdev_del

2012-04-20 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|9 + hmp.h|1 + net.c| 11 +-- net.h|1 - qapi-schema.json | 14 ++ qmp-commands.hx |5 + 7 fi

[Qemu-devel] [PATCH 05/16] qemu-option: qemu_opt_parse(): use error_set()

2012-04-20 Thread Luiz Capitulino
The functions opt_set() and qemu_opts_validate() both call qemu_opt_parse(), but their callers expect QError semantics. Thus, both functions call qerro_report_err() to keep the expected semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 36 +--- 1 fil

[Qemu-devel] [PATCH 03/16] qemu-option: parse_option_bool(): use error_set()

2012-04-20 Thread Luiz Capitulino
Note that set_option_parameter() callers still expect automatic error reporting with QError, so set_option_parameter() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletio

[Qemu-devel] [PATCH 12/16] qemu-config: introduce qemu_find_opts_err()

2012-04-20 Thread Luiz Capitulino
This is like qemu_find_opts(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_find_opts(). Signed-off-by: Luiz Capitulino --- qemu-config.c |5 + qemu-config.h |3 +++ 2 files changed, 8 insertions(+) diff --git a/qe

[Qemu-devel] [PATCH 09/16] qemu-option: qemu_opts_from_qdict(): use error_set()

2012-04-20 Thread Luiz Capitulino
do_device_add() and do_netdev_add() call qerror_report_err() to maintain their QError semantics. Signed-off-by: Luiz Capitulino --- hw/qdev-monitor.c |7 +-- net.c |5 - qemu-option.c | 31 --- qemu-option.h |3 ++- 4 files ch

[Qemu-devel] [PATCH 08/16] qemu-option: introduce qemu_opt_set_err()

2012-04-20 Thread Luiz Capitulino
This is like qemu_opt_set(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_opt_set(). Signed-off-by: Luiz Capitulino --- qemu-option.c |6 ++ qemu-option.h |2 ++ 2 files changed, 8 insertions(+) diff --git a/qemu-o

[Qemu-devel] [PATCH 13/16] net: purge the monitor object from all init functions

2012-04-20 Thread Luiz Capitulino
The only backend that really uses it is the socket one, which calls monitor_get_fd(). But it can use 'cur_mon' instead. Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c |2 +- hw/usb/dev-network.c |2 +- net.c| 18 +++--- net.h|2 +

[Qemu-devel] [PATCH 10/16] qerror: introduce QERR_INVALID_OPTION_GROUP

2012-04-20 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/qerror.c b/qerror.c index 96fbe71..5d92096 100644 --- a/qerror.c +++ b/qerror.c @@ -156,6 +156,10 @@ static const QErrorStringTable qerror_table[] = { .desc =

[Qemu-devel] [PATCH 01/16] qemu-option: qemu_opts_create(): use error_set()

2012-04-20 Thread Luiz Capitulino
This commit converts qemu_opts_create() from qerror_report() to error_set(). Currently, most calls to qemu_opts_create() can't fail, so most callers don't need any changes. The two cases where code checks for qemu_opts_create() erros are: 1. Initialization code in vl.c. All of them print their

[Qemu-devel] [PATCH 11/16] qemu-config: find_list(): use error_set()

2012-04-20 Thread Luiz Capitulino
Note that qemu_find_opts() and qemu_config_parse() need to call error_report() to maintain their semantics on error. Signed-off-by: Luiz Capitulino --- qemu-config.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/qemu-config.c b/qemu-confi

[Qemu-devel] [PATCH 02/16] qemu-option: parse_option_number(): use error_set()

2012-04-20 Thread Luiz Capitulino
Note that qemu_opt_parse() callers still expect automatic error reporting with QError, so qemu_opts_parse() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH v2 00/16]: qapi: convert netdev_add & netdev_del

2012-04-20 Thread Luiz Capitulino
v2 - convert netdev_add by using gen=no as suggested by Paolo - drop unneeded patches (qemu-option & code generator changes) - re-work some error handling changes - improve some changelogs blockdev.c |2 +- hmp-commands.hx |6 +- hmp.c| 30 + hmp.

Re: [Qemu-devel] [PATCH 00/12 v13] introducing a new, dedicated guest memory dump mechanism

2012-04-20 Thread Luiz Capitulino
On Thu, 19 Apr 2012 19:00:39 +0800 Wen Congyang wrote: > At 04/18/2012 08:49 PM, Wen Congyang Wrote: > > Hi, all > > > > 'virsh dump' can not work when host pci device is used by guest. We have > > discussed this issue here: > > http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.ht

Re: [Qemu-devel] Poking at m68k gitorious branch.

2012-04-20 Thread Rob Landley
On 04/19/2012 05:47 AM, Laurent Vivier wrote: > Hi Rob, > > you need to do a fresh clone because I rebase the branch frequently on > the qemu/master instead of merging it. It is easier to manage for me. Ok. (Did that.) > BTW, qemu-system-m68k is not working currently. Did it ever? :) > I'm wo

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Gleb Natapov
On Fri, Apr 20, 2012 at 09:39:59PM +0200, Paolo Bonzini wrote: > Il 20/04/2012 19:26, Michael Roth ha scritto: > > Do we have a way of differentiating a guest shutting down as a result of > > shutdown vs. suspend-to-disk? AFAIK they both have the same ending state. If > > so I'm not sure we can say

Re: [Qemu-devel] Fault Tolerance (Kemari) Status?

2012-04-20 Thread aaron.sto...@celestech.com
So my next question is, does qemu have a way that features can be sponsored? Aaron Stover Celestech Inc. 480-940-1640 x205 - Reply message - From: "Brian Jackson" To: , "Aaron Stover (Celestech)" Subject: [Qemu-devel] Fault Tolerance (Kemari) Status? Date: Fri, Apr 20, 2012 9:44 am

Re: [Qemu-devel] [PATCH v3 1/4] SSI: Built in multiple device support

2012-04-20 Thread Paul Brook
> /* QEMU Synchronous Serial Interface support. */ > > -/* In principle SSI is a point-point interface. As such the qemu > - implementation has a single slave device on a "bus". > +/* In principle SSI is a point-point interface. > However it is fairly common for boards to have multiple sl

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-20 Thread MORITA Kazutaka
At Fri, 20 Apr 2012 20:05:48 +0200, Christoph Hellwig wrote: > > On Tue, Apr 03, 2012 at 01:35:50AM +0800, Liu Yuan wrote: > > From: Liu Yuan > > > > Flush operation is supposed to flush the write-back cache of > > sheepdog cluster. > > > > By issuing flush operation, we can assure the Guest of

[Qemu-devel] [Bug 986318] [NEW] [sdl] Mouse grab breaks GNOME 3 screensaver unlock screen

2012-04-20 Thread Philippe Gauthier
Public bug reported: When the GNOME 3 screensaver activates with the mouse cursor over the SDL window, the screensaver will not unlock unless the gnome-shell process is killed and restarted manually. This seems to be related to the fact that the key strokes are grabbed by SDL, but the screensaver

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Paolo Bonzini
Il 20/04/2012 19:26, Michael Roth ha scritto: > Do we have a way of differentiating a guest shutting down as a result of > shutdown vs. suspend-to-disk? AFAIK they both have the same ending state. If > so I'm not sure we can say anything other than "the machine may or may not > resume when you star

[Qemu-devel] [PATCH 09/38] qcow2: Fix error handling in qcow2_alloc_cluster_offset

2012-04-20 Thread Kevin Wolf
If do_alloc_cluster_offset() fails, the error handling code tried to remove the request from the in-flight queue, to which it wasn't added yet, resulting in a NULL pointer dereference. m->nb_clusters really only becomes != 0 when the request is in the list. Signed-off-by: Kevin Wolf --- block/q

[Qemu-devel] [PATCH 15/38] aio: remove process_queue callback and qemu_aio_process_queue

2012-04-20 Thread Kevin Wolf
From: Paolo Bonzini Both unused after the previous patch. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- aio.c | 29 ++--- block/curl.c | 10 -- block/iscsi.c |4 ++-- block/nbd.c|8 block/rbd.c

[Qemu-devel] [PATCH 23/38] qcow2: Ignore reserved bits in get_cluster_offset

2012-04-20 Thread Kevin Wolf
With this change, reading from a qcow2 image ignores all reserved bits that are set in an L1 or L2 table entry. Now get_cluster_offset() assigns *cluster_offset only the offset without any other flags. The cluster type is not longer encoded in the offset, but a positive return value in case of suc

[Qemu-devel] [PATCH 25/38] qcow2: Fail write_compressed when overwriting data

2012-04-20 Thread Kevin Wolf
qcow2_alloc_compressed_cluster_offset() already fails if the copied flag is set, because qcow2_write_compressed() doesn't perform COW as it would have to do to allow this. However, what we really want to check here is whether the cluster is allocated or not. With internal snapshots the copied flag

[Qemu-devel] [PATCH 35/38] qemu-iotests: Test backing file COW with zero clusters

2012-04-20 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/034 | 113 tests/qemu-iotests/034.out | 81 +++ tests/qemu-iotests/group |1 + 3 files changed, 195 insertions(+), 0 deletions(-) create mode 100755 tests/qemu-i

[Qemu-devel] [PATCH 07/38] ide: convert ide_sector_read() to asynchronous I/O

2012-04-20 Thread Kevin Wolf
From: Stefan Hajnoczi The IDE PIO interface currently uses bdrv_read() to perform reads synchronously. Synchronous I/O in the vcpu thread is bad because it prevents the guest from executing code - it makes the guest unresponsive. This patch converts IDE PIO to use bdrv_aio_readv(). We simply n

[Qemu-devel] [PATCH 06/38] qemu-io: Add command line switch for cache mode

2012-04-20 Thread Kevin Wolf
To be used as in 'qemu-io -t writeback test.img' Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- qemu-io.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index e6fcd77..3095a22 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1784,6 +1

[Qemu-devel] [PATCH 30/38] qcow2: Ignore reserved bits in check_refcounts

2012-04-20 Thread Kevin Wolf
Also don't infer the cluster type directly from the L2 entries, but use qcow2_get_cluster_type() to keep everything in a single place. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 98 ++- 1 files changed, 54 insertions(+), 44 deletions(-)

[Qemu-devel] [PATCH 01/38] qemu-iotests: Always filter cluster_size out in _make_test_img

2012-04-20 Thread Kevin Wolf
Some image formats do have a cluster size, others don't, but there are tests that work with both sets of images and currently we get failures because the qemu-img create output doesn't mention the cluster size for some formats. Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- tests/qemu

[Qemu-devel] [PATCH 33/38] qcow2: Support for feature table header extension

2012-04-20 Thread Kevin Wolf
Instead of printing an ugly bitmask, qemu can now print a more helpful string even for yet unknown features. Signed-off-by: Kevin Wolf --- block/qcow2.c | 66 +--- block/qcow2.h | 12 ++ 2 files changed, 69 insertions(+), 9 deletion

[Qemu-devel] [PATCH 04/38] iotests: fix error in 005

2012-04-20 Thread Kevin Wolf
From: Dong Xu Wang According comment, we should not read again, we will write. Signed-off-by: Dong Xu Wang Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/005 |2 +- tests/qemu-iotests/005.out |2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 05/38] block: Fix spelling in comment (ineffcient -> inefficient)

2012-04-20 Thread Kevin Wolf
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block/cow.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/cow.c b/block/cow.c index 8d3c9f8..a5a00eb 100644 --- a/block/cow.c +++ b/block/cow.c @@ -103,7 +103,7 @@ static int cow_open(B

[Qemu-devel] [PATCH 32/38] qcow2: Support reading zero clusters

2012-04-20 Thread Kevin Wolf
This adds support for reading zero clusters in version 3 images. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 17 + block/qcow2-refcount.c |7 +++ block/qcow2.c |8 block/qcow2.h |5 + 4 files changed, 33 insertions(+), 4

[Qemu-devel] [PATCH 21/38] Specification for qcow2 version 3

2012-04-20 Thread Kevin Wolf
This updates the qcow2 specification to cover version 3. It contains the following changes: - Added compatible/incompatible/auto-clear feature bits plus an optional feature name table to allow useful error messages even if an older version doesn't know some feature at all. - Configurable refc

[Qemu-devel] [PATCH 31/38] qcow2: Version 3 images

2012-04-20 Thread Kevin Wolf
This adds the basic infrastructure to qcow2 to handle version 3 images. It includes code to create v3 images, allow header updates for v3 images and checks feature bits. It still misses support for zero clusters, so this is not a fully compliant implementation of v3 yet. The default for creating

[Qemu-devel] [PATCH 12/38] qemu-io: use main_loop_wait

2012-04-20 Thread Kevin Wolf
From: Paolo Bonzini This will let timers run during aio_read and aio_write commands, though not during synchronous commands. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- cmd.c | 10 +- qemu-io.c |7 --- 2 files changed, 9 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH 37/38] qemu-iotests: Add -o and make v3 the default for qcow2

2012-04-20 Thread Kevin Wolf
This adds an -o option to qemu-iotests, which is an option string that is passed through to qemu-img create -o... This allows testing different subformat with a command like './check -qcow2 -o compat=0.10'. For qcow2, if no compat option is specified, compat=1.1 is the new default. Signed-off-by:

[Qemu-devel] [PATCH 19/38] iotests: Resolve test failures caused by hostname

2012-04-20 Thread Kevin Wolf
From: Andreas Färber `hostname -s` may output an errror: hostname: Name or service not known This causes all tests to fail for `make check-block`. Suppress such error messages, letting the tests succeed. Signed-off-by: Andreas Färber Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.co

[Qemu-devel] [PATCH 28/38] qcow2: Simplify count_cow_clusters

2012-04-20 Thread Kevin Wolf
count_cow_clusters() tries to reuse existing functions, and all it achieves is to make things much more complicated than they really are: Everything needs COW, unless it's a normal cluster with refcount 1. This patch implements the obvious way of doing this, and by using qcow2_get_cluster_type() i

[Qemu-devel] [PATCH 34/38] qemu-iotests: add a simple test for write_zeroes

2012-04-20 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- tests/qemu-iotests/033 | 73 tests/qemu-iotests/033.out | 29 + tests/qemu-iotests/group |1 + 3 files changed, 103 insertions(+), 0 deletio

[Qemu-devel] [PATCH 36/38] qcow2: Zero write support

2012-04-20 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 14 +++-- block/qcow2-cluster.c | 72 + block/qcow2.c | 21 ++ block/qcow2.h |1 + 4 files changed, 105 insertions(+), 3 deletions(-) diff --git a/block

[Qemu-devel] [PATCH 26/38] qcow2: Ignore reserved bits in L1/L2 entries

2012-04-20 Thread Kevin Wolf
This changes the still existing places that assume that the only flags are QCOW_OFLAG_COPIED and QCOW_OFLAG_COMPRESSED to properly mask out reserved bits. It does not convert bdrv_check yet. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 26 +- block/qcow2-refc

[Qemu-devel] [PATCH 16/38] aio: return "AIO in progress" state from qemu_aio_wait

2012-04-20 Thread Kevin Wolf
From: Paolo Bonzini The definition of when qemu_aio_flush should loop is much simpler than it looks. It just has to call qemu_aio_wait until it makes no progress and all flush callbacks return false. qemu_aio_wait is the logical place to tell the caller about this. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 29/38] qcow2: Ignore reserved bits in refcount table entries

2012-04-20 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c |2 +- block/qcow2.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 909d615..e0854dc 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c

[Qemu-devel] [PATCH 18/38] qemu-img: let 'qemu-img convert' flush data

2012-04-20 Thread Kevin Wolf
From: Liu Yuan The 'qemu-img convert -h' advertise that the default cache mode is 'writeback', while in fact it is 'unsafe'. This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush() 2) is needed because some backend storage doesn't have a self-flush mechanism(for e.g., sheepd

[Qemu-devel] [PATCH 38/38] qemu-iotests: Fix test 031 for qcow2 v3 support

2012-04-20 Thread Kevin Wolf
qcow2.py must be updated to work with version 3 images at all, the output has changed since the feature table extension has been added, and version 2 and version 3 images can't possibly have the same test output. Change the test case to completely ignore IMGOPTS and run the test for both compat=1.

[Qemu-devel] [PATCH 11/38] block: allow interrupting a co_sleep_ns

2012-04-20 Thread Kevin Wolf
From: Paolo Bonzini In the next patch we want to reenter the coroutine from block_job_cancel_sync and cancel the timer. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- qemu-coroutine-sleep.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-coroutine-s

[Qemu-devel] [PATCH 24/38] qcow2: Ignore reserved bits in count_contiguous_clusters()

2012-04-20 Thread Kevin Wolf
Until now, count_contiguous_clusters() has an argument that allowed to specify flags that should be ignored in the comparison, i.e. that are allowed to change between contiguous clusters. This patch changes the function so that it ignores all flags by default now and you need to pass the flags on

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-20 Thread Christoph Hellwig
On Tue, Apr 03, 2012 at 01:35:50AM +0800, Liu Yuan wrote: > From: Liu Yuan > > Flush operation is supposed to flush the write-back cache of > sheepdog cluster. > > By issuing flush operation, we can assure the Guest of data > reaching the sheepdog cluster storage. How does qemu know that the ca

[Qemu-devel] [PATCH 22/38] qcow2: Save disk size in snapshot header

2012-04-20 Thread Kevin Wolf
This allows that different snapshots of an image can have different sizes, which is a requirement for enabling image resizing even with images that have internal snapshots. We don't do the actual support for it now, but make sure that the additional field is present and not completely ignored in a

[Qemu-devel] [PATCH 08/38] ide: convert ide_sector_write() to asynchronous I/O

2012-04-20 Thread Kevin Wolf
From: Stefan Hajnoczi The IDE PIO write sector code path uses bdrv_write() and hence can make the guest unresponsive while the I/O request is in progress. This patch converts ide_sector_write() to use bdrv_aio_writev() by using the BUSY_STAT bit to tell the guest that the request is in progress.

Re: [Qemu-devel] [PATCH 25/25] qdev: split part of device_finalize to device_unrealize

2012-04-20 Thread Anthony Liguori
On 04/03/2012 06:15 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- hw/qdev.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index e674248..45f1133 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -601,27 +60

[Qemu-devel] [PATCH 17/38] aio: simplify qemu_aio_wait

2012-04-20 Thread Kevin Wolf
From: Paolo Bonzini The do...while loop can never loop, because select will just not return 0 when invoked with infinite timeout. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- aio.c | 133 +++- 1 files changed, 64 inser

[Qemu-devel] [PATCH 20/38] qcow2: Fix refcount block allocation during qcow2_alloc_cluster_at()

2012-04-20 Thread Kevin Wolf
Refcount block allocation and refcount table growth rely on s->free_cluster_index pointing to somewhere after the current allocation. Change qcow2_alloc_cluster_at() to fulfill this assumption. Without this change it could happen that a newly allocated refcount block and the allocated data block p

[Qemu-devel] [PATCH 14/38] posix-aio: merge posix_aio_process_queue and posix_aio_read

2012-04-20 Thread Kevin Wolf
From: Paolo Bonzini posix_aio_read already calls qemu_aio_process_queue, and dually qemu_aio_process_queue is always followed by a select loop that calls posix_aio_read. No races are possible, so there is no need for a separate process_queue callback. Signed-off-by: Paolo Bonzini Signed-off-by

[Qemu-devel] [PATCH 2/4] versatilepb: add ds1338 rtc device

2012-04-20 Thread Peter Maydell
From: Oskar Andero Add ds1338 rtc attached on i2c. Signed-off-by: Oskar Andero Signed-off-by: Peter Maydell --- hw/versatilepb.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/versatilepb.c b/hw/versatilepb.c index 25afb1e..d011554 100644 --- a/hw/versatilepb

[Qemu-devel] [PATCH 1/4] realview: break out versatile i2c controller code

2012-04-20 Thread Peter Maydell
From: Oskar Andero The versatile i2c controller implementation was separated to its own file called versatile_i2c.c. This is done as a preparation for adding i2c support to the versatilepb board. Signed-off-by: Oskar Andero Signed-off-by: Peter Maydell --- Makefile.target|1 + hw/real

[Qemu-devel] [PATCH 3/4] hw/arm_mptimer: Reset the qemu_timer at reset

2012-04-20 Thread Peter Maydell
On reset of the mpcore timer/watchdog block we need to delete the qemu_timer in case it was running. Signed-off-by: Peter Maydell --- hw/arm_mptimer.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/arm_mptimer.c b/hw/arm_mptimer.c index df7fb4c..fe43cbb 100644 ---

[Qemu-devel] [PATCH 4/4] versatiblepb: add NOR flash support

2012-04-20 Thread Peter Maydell
From: Eric Benard - add support for the 64MB NOR CFI01 flash available at 0x3400 on the versatilepb board http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0225d/BBAJIHEC.html - tested with barebox bootloader Signed-off-by: Eric Bénard Signed-off-by: Peter Maydell --- hw/ver

[Qemu-devel] [PULL 0/4] arm-devs queue

2012-04-20 Thread Peter Maydell
Hi; this is a pullreq for the arm-devs queue, fairly minor stuff. Please pull. thanks -- PMM The following changes since commit 51006bbc45bc74977ae538190a53df2af534acb9: Merge remote-tracking branch 'origin/master' into staging (2012-04-18 10:06:09 -0500) are available in the git repository

[Qemu-devel] [PATCH v3 2/2] target-arm: Move A9 config_base_address reset value to ARMCPU

2012-04-20 Thread Andreas Färber
From: Peter Maydell Move the A9 config_base_address cp15 register reset value to ARMCPU. This should become a QOM property so that the Highbank board can set it without having to pull in cpu-qom.h, but at least this avoids the implicit dependency on reset ordering that the previous workaround had

[Qemu-devel] [PATCH 1/2] target-arm: Change cpu_arm_init() return type to ARMCPU

2012-04-20 Thread Andreas Färber
Make cpu_arm_init() return a QOM ARMCPU, so that we don't need to obtain an ARMCPU through arm_env_get_cpu() in machine init code. This requires to adjust the inclusion site of cpu-qom.h and in turn, forward-looking, to homogenize its include order. cpu_init() must still return a CPUARMState for b

[Qemu-devel] [PATCH 0/2] QOM'ify ARM CPU init

2012-04-20 Thread Andreas Färber
From: Andreas Färber Hello Peter, This mini-series redoes your drop-reset-model-init patch 14/14 v2. I've investigated doing it this way for sh4 and plan to adjust all targets. Note that I haven't tested Highbank, just the Integrator/CP using old cpu_init(). Regards, Andreas Cc: Peter Maydel

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Michael Roth
On Fri, Apr 20, 2012 at 12:26:10PM -0500, Michael Roth wrote: > On Fri, Apr 20, 2012 at 10:36:38AM -0300, Luiz Capitulino wrote: > > On Fri, 20 Apr 2012 14:07:16 +0200 > > Michal Privoznik wrote: > > > > > >> But, I think if we tell users we'll *only* send response on error, > > > >> we should do

[Qemu-devel] [PATCH 27/38] qcow2: Refactor qcow2_free_any_clusters

2012-04-20 Thread Kevin Wolf
Zero clusters will add another cluster type. Refactor the open-coded cluster type detection into a switch of QCOW2_CLUSTER_* options so that the detection is in a single place. This makes it easier to add new cluster types. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 41

[Qemu-devel] [PATCH 13/38] qemu-tool: map vm_clock to rt_clock

2012-04-20 Thread Kevin Wolf
From: Paolo Bonzini QED uses vm_clock timers so that images are not touched during and after migration. This however does not apply to qemu-io and qemu-img. Treat vm_clock as a synonym for rt_clock there, and enable it. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- qemu-tool.c |

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Michael Roth
On Fri, Apr 20, 2012 at 10:36:38AM -0300, Luiz Capitulino wrote: > On Fri, 20 Apr 2012 14:07:16 +0200 > Michal Privoznik wrote: > > > >> But, I think if we tell users we'll *only* send response on error, > > >> we should do our part to *not* send the responses, rather than relying > > >> on them

Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_address reset value to ARMCPU

2012-04-20 Thread Peter Maydell
On 20 April 2012 18:01, Andreas Färber wrote: > Am 14.04.2012 18:42, schrieb Peter Maydell: >> @@ -213,14 +207,17 @@ static void highbank_init(ram_addr_t ram_size, >>      } >> >>      for (n = 0; n < smp_cpus; n++) { >> +        ARMCPU *cpu; >>          env = cpu_init(cpu_model); >>          if (

[Qemu-devel] [PATCH 10/38] qcow2: Fix return value of alloc_refcount_block

2012-04-20 Thread Kevin Wolf
Someone forgot something in commit 29c1a730... Documenting the right return value is not enough, you also need to actually return it in the code. This bug sometimes causes error return values even when everything has succeeded: The new offset of the refcount block is truncated to 32 bits and inter

Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_address reset value to ARMCPU

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: > Move the A9 config_base_address cp15 register reset value to > ARMCPU. This should become a QOM property so that the Highbank > board can set it without having to pull in cpu-qom.h, but at > least this avoids the implicit dependency on reset ordering >

[Qemu-devel] [PATCH 02/38] qemu-iotests: Test bdrv_close while AIO is in flight

2012-04-20 Thread Kevin Wolf
If the BlockDriverState is closed/freed without draining the AIO requests first, the request coroutines may work on invalid data and file descriptors or have some dangling pointers that cause segfaults. Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- tests/qemu-iotests/032 | 69 +

[Qemu-devel] [PULL 00/38] Block patches

2012-04-20 Thread Kevin Wolf
The following changes since commit 51006bbc45bc74977ae538190a53df2af534acb9: Merge remote-tracking branch 'origin/master' into staging (2012-04-18 10:06:09 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Andreas Färber (1): iotests: Resolve

[Qemu-devel] [PATCH 03/38] block: Drain requests in bdrv_close

2012-04-20 Thread Kevin Wolf
If an AIO request is in flight that refers to a BlockDriverState that has been closed and possibly even freed, more or less anything could happen. I have seen segfaults, -EBADF return values and qcow2 sometimes actually catches the situation in bdrv_close() and abort()s. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v2 13/14] target-arm: Move reset handling to arm_cpu_reset

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: > Now that cpu_reset_model_id() has gone we can move the > reset code over to the class reset function and have cpu_state_reset > simply do a reset on the CPU QOM object. > > Signed-off-by: Peter Maydell Acked-by: Andreas Färber /-F -- SUSE LINUX P

Re: [Qemu-devel] [HelenOS-devel] First UDP packet dropped after initial ARP request/reply

2012-04-20 Thread Jakub Jermar
On 20.4.2012 12:17, Jakub Jermar wrote: > I am observing an interesting phenomenon on the latest QEMU git and the > latest HelenOS mainline (the problem is likely guest-neutral though). > The QEMU command line is as follows: > > $ qemu-system-i386 -device rtl8139,vlan=0 -net user -boot d -redir \

[Qemu-devel] First UDP packet dropped after initial ARP request/reply

2012-04-20 Thread Jakub Jermar
Hi, I am observing an interesting phenomenon on the latest QEMU git and the latest HelenOS mainline (the problem is likely guest-neutral though). The QEMU command line is as follows: $ qemu-system-i386 -device rtl8139,vlan=0 -net user -boot d -redir \ udp:8080::8080 -redir udp:8081::8081 -redir

Re: [Qemu-devel] Fault Tolerance (Kemari) Status?

2012-04-20 Thread Brian Jackson
On Thu, 19 Apr 2012 14:59:25 -0500, Aaron Stover (Celestech) wrote: Hi, I'm curious as to the current status of the fault tolerance features of QEMU? From reading what I could find on the wiki, it appears as though the code was ready to be merged into version 0.14 but it does appear to

Re: [Qemu-devel] [RFC PATCH 6/9] pc: pass paravirt info for hotplug memory slots to BIOS

2012-04-20 Thread Vasilis Liaskovitis
On Fri, Apr 20, 2012 at 12:33:57PM +0200, Igor Mammedov wrote: > On 04/19/2012 04:08 PM, Vasilis Liaskovitis wrote: > >-numa_fw_cfg = g_malloc0((1 + max_cpus + nb_numa_nodes) * 8); > >+numa_fw_cfg = g_malloc0((2 + max_cpus + nb_numa_nodes + 3 * > >nb_hp_memslots) * 8); > > numa_fw_cfg

Re: [Qemu-devel] [PATCH v2 11/14] target-arm: Move cache ID register setup to cpu specific init fns

2012-04-20 Thread Andreas Färber
Am 20.04.2012 18:05, schrieb Peter Maydell: > On 20 April 2012 17:00, Andreas Färber wrote: >> Am 14.04.2012 18:42, schrieb Peter Maydell: >>> +cpu->clidr = (1 << 27) | (2 << 24) | 3; >> >> Copy&paste, should be (1 << 27) | (1 << 24) | 3. > > Fixed and pushed, sigh. Acked-by: Andreas Färber

Re: [Qemu-devel] [PATCH v2 12/14] target-arm: Drop cpu_reset_model_id()

2012-04-20 Thread Peter Maydell
On 20 April 2012 17:14, Andreas Färber wrote: > Am 14.04.2012 18:42, schrieb Peter Maydell: >>  /* TODO Move contents into arm_cpu_reset() in cpu.c, >>   *      once cpu_reset_model_id() is eliminated, > > ...if you were to drop this comment line it would be cleaner. There is > no cpu_reset_model_

Re: [Qemu-devel] [PATCH 0/5] qemu-timer: Clean code

2012-04-20 Thread Paolo Bonzini
Il 20/04/2012 12:03, Stefan Weil ha scritto: > These patches remove timer code which is no longer needed > and try to improve the remaining code. > > [PATCH 1/5] qemu-timer: Remove redundant include statements > [PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending > [PATCH 3/5] qemu-t

Re: [Qemu-devel] [PATCH v2 12/14] target-arm: Drop cpu_reset_model_id()

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: > cpu_reset_model_id() is now empty and we can remove it. > > Signed-off-by: Peter Maydell Acked-by: Andreas Färber However, ... > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 5cbc7e0..653885a 100644 > --- a/target-arm/helper.c > +

Re: [Qemu-devel] [PATCH v2 11/14] target-arm: Move cache ID register setup to cpu specific init fns

2012-04-20 Thread Peter Maydell
On 20 April 2012 17:00, Andreas Färber wrote: > Am 14.04.2012 18:42, schrieb Peter Maydell: >> +    cpu->clidr = (1 << 27) | (2 << 24) | 3; > > Copy&paste, should be (1 << 27) | (1 << 24) | 3. Fixed and pushed, sigh. -- PMM

Re: [Qemu-devel] [PATCH v2 11/14] target-arm: Move cache ID register setup to cpu specific init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: > Move cache ID register reset out of cpu_reset_model_id() by > creating a field for the reset value in ARMCPU and setting it > up in the cpu specific init functions. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu-qom.h |5 + > target-

Re: [Qemu-devel] [PATCH v2 09/14] target-arm: Move feature register setup to per-CPU init fns

2012-04-20 Thread Peter Maydell
On 20 April 2012 16:50, Andreas Färber wrote: > Missing cpu->id_mmfr3 = 0x11; [etc] Whoops, that was a bit sloppy. Fixed and new version pushed to git://git.linaro.org/people/pmaydell/qemu-arm.git drop-reset-model-id -- PMM

Re: [Qemu-devel] [PATCH v2 09/14] target-arm: Move feature register setup to per-CPU init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: > Move feature register value setup to per-CPU init functions. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu-qom.h | 14 > target-arm/cpu.c | 91 > ++ > target-arm/helper.c |

[Qemu-devel] [Bug 986241] [NEW] Misspelling of env parameter in deregister_dtl() [hw/spapr_hcall.c]

2012-04-20 Thread Peter Portante
Public bug reported: Looks like there is a simple misspelling of the env parameter, as "emv", in hw/spapr_hcall.c:485: static target_ulong deregister_dtl(CPUPPCState *emv, target_ulong addr) ** Affects: qemu Importance: Undecided Status: New -- You received this bug notificatio

[Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly

2012-04-20 Thread Peter Portante
Signed-off-by: Peter Portante --- hw/spapr_hcall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c index 634763e..94bb504 100644 --- a/hw/spapr_hcall.c +++ b/hw/spapr_hcall.c @@ -482,7 +482,7 @@ static target_ulong register_dtl(CPUPPCS

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-04-20 Thread Eduardo Habkost
On Fri, Apr 20, 2012 at 05:19:17PM +0200, Jan Kiszka wrote: > On 2012-04-20 17:00, Eduardo Habkost wrote: > > On Fri, Apr 20, 2012 at 12:12:38PM +0200, Jan Kiszka wrote: > >> On 2012-04-19 22:03, Eduardo Habkost wrote: > >>> Jan/Avi: ping? > >>> > >>> I would like to get this ABI detail clarified s

  1   2   >