Re: [Qemu-devel] RFC: delete darwin-user ?

2012-04-12 Thread Alexander Graf
On 13.04.2012, at 02:01, Andreas Färber wrote: > Am 13.04.2012 01:57, schrieb Peter Maydell: >> So, the darwin-user/ subdirectory is officially Orphan, and looking >> at the git history the last commit to it which wasn't either "apply >> a global change", "fix cppcheck/spelling error/similar auto

Re: [Qemu-devel] [PATCH 3/3] virtio_balloon: Bugfixes for PAGE_SIZE != 4k

2012-04-12 Thread David Gibson
On Thu, Apr 12, 2012 at 01:14:06PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 12, 2012 at 03:36:35PM +1000, David Gibson wrote: [snip] > Good catch! > > Unfortunately I find the approach a bit convoluted. > It also looks like when host asks for 5 balloon pages > you interpret this as 0 where 1

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] pseries: Fix RTAS based config access

2012-04-12 Thread David Gibson
On Thu, Apr 12, 2012 at 04:50:46PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 12, 2012 at 02:29:33PM +0200, Andreas Färber wrote: > > Am 02.04.2012 06:17, schrieb David Gibson: > > > On the pseries platform, access to PCI config space is via RTAS calls( > > > which go to the hypervisor) rather

Re: [Qemu-devel] [PATCH v2 4/5] target-ppc: QOM'ify CPU reset

2012-04-12 Thread David Gibson
On Fri, Apr 06, 2012 at 06:17:11PM +0200, Andreas Färber wrote: > Move code from cpu_state_reset() into ppc_cpu_reset(). > Reorder #include of helper_regs.h to use it in translate_init.c. > > Adjust whitespace and add braces. > > Signed-off-by: Andreas Färber Acked-by: David Gibson Looks fine

[Qemu-devel] [Bug 979714] Re: The pit interrupt still exists even with tickless guest

2012-04-12 Thread chao zhou
** Summary changed: - Guest timer interrupt isn't switched off when local timer is enabled + The pit interrupt still exists even with tickless guest -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/9797

Re: [Qemu-devel] Question about the block linking limitation

2012-04-12 Thread Max Filippov
>>  Doesn't a tb spanning guest pages have above problem? I mean what if the >> guest page 2 is changed? In this case, the execution flow jump from tb.a to >> tb.b. It seems it may have the same problem as above to me. > > I agree. I see that only i386 and m68k TBs may cross page boundary. > Maybe

Re: [Qemu-devel] [PATCH v2] qemu-img: let 'qemu-img convert' flush data

2012-04-12 Thread Liu Yuan
On 04/11/2012 11:21 PM, Liu Yuan wrote: > On 04/11/2012 11:01 PM, Paolo Bonzini wrote: > >> bdrv_delete already does this. >> >> Paolo > > > Ah yes. Thanks pointing out. > Hi Kevin, If no further comment, would you pick up following patch? Yuan > From 459414f677f6449482f9cfcb7917ff0e242

[Qemu-devel] [PATCH 1/7] kvm: add flightrecorder script

2012-04-12 Thread Marcelo Tosatti
From: Stefan Hajnoczi The kvm kernel module includes a number of trace events which can be useful when debugging system behavior. Even on production systems these trace events can be used to observe guest behavior and identify the source of problems. The kvm_flightrecorder script is a command-l

[Qemu-devel] [PATCH 4/7] kvm: Drop unused kvm_pit_in_kernel

2012-04-12 Thread Marcelo Tosatti
From: Jan Kiszka This is now implied by kvm_irqchip_in_kernel. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c |6 -- kvm-stub.c |6 -- kvm.h |2 -- 3 files changed, 0 insertions(+), 14 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index f1c

Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests

2012-04-12 Thread Zhi Yong Wu
On Thu, Apr 12, 2012 at 8:00 PM, Paolo Bonzini wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > [ Iterate until all block devices have processed all requests, >  add comments. - Paolo ] > Signed-off-by: Paolo Bonzini > --- >  block.c |   21 - >  1 file changed, 20

[Qemu-devel] [PATCH 3/7] kvm: allow arbitrarily sized mmio ioeventfd

2012-04-12 Thread Marcelo Tosatti
From: "Michael S. Tsirkin" We use a 2 byte ioeventfd for virtio memory, add support for this. Signed-off-by: Michael S. Tsirkin Reviewed-by: Amos Kong Signed-off-by: Avi Kivity --- hw/ivshmem.c |8 kvm-all.c| 15 --- kvm-stub.c |2 +- kvm.h|3

[Qemu-devel] [PATCH 5/7] kvm: set gsi_bits and max_gsi correctly

2012-04-12 Thread Marcelo Tosatti
From: Jason Baron The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap correctly, and as a consequence pins max_gsi to 32 when it really should be 1024. I ran into this limitation while testing pci passthrough, where I consistently got an -ENOSPC return from kvm_get_irq_route_gsi

[Qemu-devel] [PATCH 7/7] kvmclock: guest stop notification

2012-04-12 Thread Marcelo Tosatti
From: Eric B Munson Often when a guest is stopped from the qemu console, it will report spurious soft lockup warnings on resume. There are kernel patches being discussed that will give the host the ability to tell the guest that it is being stopped and should ignore the soft lockup warning that

[Qemu-devel] [PATCH 2/7] kvm: Drop redundant kvm_enabled from cpu_thread_is_idle

2012-04-12 Thread Marcelo Tosatti
From: Jan Kiszka This is now implied by kvm_irqchip_in_kernel. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity --- cpus.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index eb22bd5..b182b3d 100644 --- a/cpus.c +++ b/cpus.c @@ -441,8 +441,7 @@

[Qemu-devel] [PATCH 6/7] kvm: update linux headers

2012-04-12 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti --- linux-headers/asm-powerpc/kvm.h |1 + linux-headers/asm-s390/kvm.h|2 ++ linux-headers/linux/kvm.h |9 + 3 files changed, 12 insertions(+), 0 deletions(-) diff --git a/linux-headers/asm-powerpc/kvm.h b/linux-headers/asm-powerpc/kvm

[Qemu-devel] [PATCH 0/7] [PULL] qemu-kvm.git uq/master queue

2012-04-12 Thread Marcelo Tosatti
The following changes since commit dadc1064c348545695b8a14d9dc72ccaa2983be7: target-microblaze: added PetaLogix copyright (2012-04-12 09:56:51 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Eric B Munson (1): kvmclock: guest

Re: [Qemu-devel] [PATCH 00/12 v11] introducing a new, dedicated guest memory dump mechanism

2012-04-12 Thread Wen Congyang
Hi, Anthony, Jan I am sorry to ping you again. I know you are very busy recently. But this patchset is very very important to us. I hope you can review it if you have time. Thanks Wen Congyang At 03/26/2012 05:58 PM, Wen Congyang Wrote: > Hi, all > > 'virsh dump' can not work when host pci devi

Re: [Qemu-devel] RFC: delete darwin-user ?

2012-04-12 Thread Andreas Färber
Am 13.04.2012 01:57, schrieb Peter Maydell: > So, the darwin-user/ subdirectory is officially Orphan, and looking > at the git history the last commit to it which wasn't either "apply > a global change", "fix cppcheck/spelling error/similar autodetected > nit" or "duplicate a linux-user fix into da

[Qemu-devel] RFC: delete darwin-user ?

2012-04-12 Thread Peter Maydell
So, the darwin-user/ subdirectory is officially Orphan, and looking at the git history the last commit to it which wasn't either "apply a global change", "fix cppcheck/spelling error/similar autodetected nit" or "duplicate a linux-user fix into darwin-user and bsd-user" was way back in 2009, perhap

Re: [Qemu-devel] [PATCH 3/4] Switch from array based resource allocation to list

2012-04-12 Thread Kevin O'Connor
On Thu, Apr 12, 2012 at 03:28:02PM +1200, Alexey Korolev wrote: > On 12/04/12 15:15, Kevin O'Connor wrote: > > > > This was also me playing with one of Gerd's patches. It just makes > > the bar read/write code 64bit aware. It doesn't actually program > > them. The logic to do real 64bit allocati

Re: [Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-12 Thread Alex Williamson
On Thu, 2012-04-12 at 18:27 +0300, Michael S. Tsirkin wrote: > On Thu, Apr 12, 2012 at 08:57:18AM -0600, Alex Williamson wrote: > > On Wed, 2012-04-11 at 10:40 +0300, Michael S. Tsirkin wrote: > > > On Tue, Apr 10, 2012 at 04:07:41PM -0600, Alex Williamson wrote: > > > > > Some points I remember >

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Andreas Färber
Am 13.04.2012 00:09, schrieb Anthony Liguori: > On 04/12/2012 05:02 PM, Andreas Färber wrote: >> Am 12.04.2012 23:24, schrieb Anthony Liguori: >>> I guess I don't understand what the problem we're trying to solve is. >>> >>> Why can't we introduce an Object::realize() and just have it not >>> autom

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Andreas Färber
Am 12.04.2012 23:24, schrieb Anthony Liguori: > I think you're trying to run before we walk. The opposite is the case: I am trying to walk by improving code that was not even qdev'ified before I touched it (see the sh4 commit in my previous message). But now you are telling me I can't get a functi

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Peter Maydell
On 12 April 2012 22:57, Anthony Liguori wrote: > On 04/12/2012 04:50 PM, Peter Maydell wrote: >> My main desire from shifting to QOM is named connections between >> devices and killing off the strict hierarchy of qbus buses; > > We're pretty much there, no? > > I think the only thing really left i

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 05:02 PM, Andreas Färber wrote: Am 12.04.2012 23:24, schrieb Anthony Liguori: I guess I don't understand what the problem we're trying to solve is. Why can't we introduce an Object::realize() and just have it not automatically call DeviceState::init()? That way we have a way to c

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Andreas Färber
Am 12.04.2012 23:24, schrieb Anthony Liguori: > I guess I don't understand what the problem we're trying to solve is. > > Why can't we introduce an Object::realize() and just have it not > automatically call DeviceState::init()? That way we have a way to > clearly indicate whether a device needs

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 04:50 PM, Peter Maydell wrote: On 12 April 2012 22:24, Anthony Liguori wrote: The end goal shouldn't be s/qdev/object/g. That doesn't make things better by just using a new shiny infrastructure. Splitting device initialization into two stages is the fundamental reason for introd

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Peter Maydell
On 12 April 2012 22:24, Anthony Liguori wrote: > The end goal shouldn't be s/qdev/object/g.  That doesn't make things better > by just using a new shiny infrastructure.  Splitting device initialization > into two stages is the fundamental reason for introducing QOM in the first > place. It might

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/5] target-ppc: Add CPU finalizer

2012-04-12 Thread Andreas Färber
Am 11.04.2012 03:06, schrieb David Gibson: > On Fri, Apr 06, 2012 at 06:17:12PM +0200, Andreas Färber wrote: >> free() opcode tables. They are being malloc()'ed in create_new_table(). > > This doesn't seem right. Unless I've missed something in the call > path, create_new_table() is not called fr

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 04:08 PM, Andreas Färber wrote: Am 12.04.2012 21:59, schrieb Anthony Liguori: On 04/12/2012 11:52 AM, Andreas Färber wrote: Am 12.04.2012 17:41, schrieb Anthony Liguori: On 04/12/2012 09:04 AM, Andreas Färber wrote: Am 12.04.2012 16:59, schrieb Paolo Bonzini: Il 12/04/2012 16:4

Re: [Qemu-devel] [PATCH 01/19] Specification for qcow2 version 3

2012-04-12 Thread Anthony Liguori
On 04/12/2012 10:01 AM, Kevin Wolf wrote: This updates the qcow2 specification to cover version 3. It contains the following changes: - Added compatible/incompatible/auto-clear feature bits plus an optional feature name table to allow useful error messages even if an older version doesn't

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Andreas Färber
Am 12.04.2012 21:59, schrieb Anthony Liguori: > On 04/12/2012 11:52 AM, Andreas Färber wrote: >> Am 12.04.2012 17:41, schrieb Anthony Liguori: >>> On 04/12/2012 09:04 AM, Andreas Färber wrote: Am 12.04.2012 16:59, schrieb Paolo Bonzini: > Il 12/04/2012 16:47, Anthony Liguori ha scritto: >>

Re: [Qemu-devel] [PATCH v2] qemu-timer.c: Remove 250us timeouts

2012-04-12 Thread Anthony Liguori
On 04/12/2012 03:56 PM, Paolo Bonzini wrote: Il 12/04/2012 22:55, Anthony Liguori ha scritto: It makes sense to me but since this is a subtle change, Paolo, could you also take a look at this change? It looks fine, Peter and I already looked at the patch prior to his submitting. Thanks. I'l

Re: [Qemu-devel] [PATCH v2] qemu-timer.c: Remove 250us timeouts

2012-04-12 Thread Paolo Bonzini
Il 12/04/2012 22:55, Anthony Liguori ha scritto: > It makes sense to me but since this is a subtle change, Paolo, could you > also take a look at this change? It looks fine, Peter and I already looked at the patch prior to his submitting. > Reviewed-by: Anthony Liguori Paolo

Re: [Qemu-devel] [PATCH v2] qemu-timer.c: Remove 250us timeouts

2012-04-12 Thread Anthony Liguori
On 04/05/2012 10:00 AM, Peter Portante wrote: Basically, the main wait loop calls qemu_run_all_timers() unconditionally. The first thing this routine used to do is to see if a timer had been serviced, and then reset the loop timeout to the next deadline. However, the new deadlines had not been c

Re: [Qemu-devel] [PATCH v4 00/14] configure: --with-confsuffix option

2012-04-12 Thread Anthony Liguori
On 04/12/2012 03:41 PM, Eduardo Habkost wrote: On Wed, Apr 04, 2012 at 03:32:11PM -0300, Eduardo Habkost wrote: I was going to resend only patch 14/14 with a fixed description, but then I noticed the series had to be rebased, with small conflicts on patches 04/14 and 12/14, so I am submitting th

Re: [Qemu-devel] [PATCH v4 00/14] configure: --with-confsuffix option

2012-04-12 Thread Eduardo Habkost
On Wed, Apr 04, 2012 at 03:32:11PM -0300, Eduardo Habkost wrote: > I was going to resend only patch 14/14 with a fixed description, but then I > noticed the series had to be rebased, with small conflicts on patches 04/14 > and 12/14, so I am submitting the whole series again. > Anthony, are you O

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 11:52 AM, Andreas Färber wrote: Am 12.04.2012 17:41, schrieb Anthony Liguori: On 04/12/2012 09:04 AM, Andreas Färber wrote: Am 12.04.2012 16:59, schrieb Paolo Bonzini: Il 12/04/2012 16:47, Anthony Liguori ha scritto: Wrap setting of Object::realized property, error reporting a

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 12:02 PM, Paolo Bonzini wrote: Il 12/04/2012 18:52, Andreas Färber ha scritto: Selecting the type of an object should be done by having a link<> property and letting the user create an object and setup the link. No, that's not what a link does. A link<> property lets the user as

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 01/15] hvm: Modify interface to support multiple ioreq server

2012-04-12 Thread Julien Grall
On 03/23/2012 11:33 AM, Ian Campbell wrote: On Thu, 2012-03-22 at 15:59 +, Julien Grall wrote: Add structure to handle ioreq server. It's server which can handle a range of IO (MMIO and/or PIO) and emulate a PCI. Each server as its own shared page to receive ioreq. So we have introduced

[Qemu-devel] DOS VM problem with QEMU-KVM and newer kernels

2012-04-12 Thread Gerhard Wiesinger
Hello, I'm having problems with recents kernels and qemu-kvm with a DOS VM: TD286 System: Bad selector: 0007 System: Bad selector: 0D87 System: Bad selector: 001F System: Bad selector: 0007 GP at 0020 21D4 EC 0DC4 Error 269 loading D:\BP\BIN\TD286.EXE into extended memory Another 286 DOS Extende

[Qemu-devel] [PATCH] configure: Insist on a Python 2, not Python 3

2012-04-12 Thread Peter Maydell
Our Python scripts require Python 2 and will fail on Python 3, eg: File "/home/petmay01/linaro/qemu-from-laptop/qemu/scripts/qapi-commands.py", line 378 except getopt.GetoptError, err: ^ SyntaxError: invalid syntax Add a check to configure that Python is n

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-12 Thread Scott Wood
On 04/12/2012 11:59 AM, Andreas Färber wrote: > Am 10.04.2012 22:04, schrieb Meador Inge: >> commit f7aa558396dd0f6b7a2b22c05cb503c655854102 pulled the dcache and icache >> line size initialization inside of a '#if !defined(CONFIG_USER_ONLY)' block. >> This is not correct because instructions like

Re: [Qemu-devel] [PATCH 3/3] block: Drain requests in bdrv_close

2012-04-12 Thread Paolo Bonzini
Il 11/04/2012 12:40, Kevin Wolf ha scritto: > @@ -816,6 +816,8 @@ void bdrv_close(BlockDriverState *bs) > if (bs->job) { > block_job_cancel_sync(bs->job); > } > +bdrv_drain_all(); Actually the bdrv_drain_all needs to go first. This is because block_job_cance

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Paolo Bonzini
Il 12/04/2012 18:52, Andreas Färber ha scritto: >> Selecting the type of an object should be done by having a link<> >> property and letting the user create an object and setup the link. > > No, that's not what a link does. A link<> property lets the user > associate one instance, not a type that

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-12 Thread Andreas Färber
Am 10.04.2012 22:04, schrieb Meador Inge: > commit f7aa558396dd0f6b7a2b22c05cb503c655854102 pulled the dcache and icache > line size initialization inside of a '#if !defined(CONFIG_USER_ONLY)' block. > This is not correct because instructions like 'dcbz' need the dcache size > initialized even for

Re: [Qemu-devel] Fiber switching and stack protection

2012-04-12 Thread Paolo Bonzini
Il 12/04/2012 18:31, Stefan Weil ha scritto: > Am 12.04.2012 12:18, schrieb Paolo Bonzini: >> Il 12/04/2012 12:13, Kevin Wolf ha scritto: >>> I guess it's this non-thread-local TLS once again, basically a >>> compiler bug. >>> >>> Paolo, wasn't there a compiler option that works around the problem?

Re: [Qemu-devel] [PATCH v2 17/24] qdev: remove qdev_prop_exists

2012-04-12 Thread Andreas Färber
Am 11.04.2012 23:30, schrieb Paolo Bonzini: > Can be replaced everywhere with object_property_find. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Andreas Färber
Am 12.04.2012 17:41, schrieb Anthony Liguori: > On 04/12/2012 09:04 AM, Andreas Färber wrote: >> Am 12.04.2012 16:59, schrieb Paolo Bonzini: >>> Il 12/04/2012 16:47, Anthony Liguori ha scritto: > Wrap setting of Object::realized property, error reporting and exit(1) > into a helper fun

Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type

2012-04-12 Thread Paolo Bonzini
Il 12/04/2012 18:26, Andreas Färber ha scritto: > I had also pointed out that no longer handling .parent = NULL as > TYPE_OBJECT can have unwanted effects of not deriving some objects from > TYPE_OBJECT. I see no statement that the code was reviewed for TypeInfos > that don't set .parent (or set it

[Qemu-devel] [PATCH 1/2] pflash_cfi01: remove redundant line

2012-04-12 Thread Eric Bénard
Signed-off-by: Eric Bénard --- hw/pflash_cfi01.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index b03f623..d1c7423 100644 --- a/hw/pflash_cfi01.c +++ b/hw/pflash_cfi01.c @@ -144,7 +144,6 @@ static uint32_t pflash_read (pflash_t *

Re: [Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-12 Thread Alex Williamson
On Wed, 2012-04-11 at 10:40 +0300, Michael S. Tsirkin wrote: > On Tue, Apr 10, 2012 at 04:07:41PM -0600, Alex Williamson wrote: > > > Some points I remember > > > - power on is better called slot enabled > > > - guests dont actually call _PSX like you want them to > > > (PS3 for sure, in my testi

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Andreas Färber
Am 12.04.2012 16:47, schrieb Anthony Liguori: > On 04/12/2012 08:44 AM, Andreas Färber wrote: >> Wrap setting of Object::realized property, error reporting and exit(1) >> into a helper function. It is the equivalent of qdev_init_nofail(). > > I don't like this. > > If for no reason other than, a

[Qemu-devel] [PATCH 18/19] [RFC] Possible qcow2 specification extensions

2012-04-12 Thread Kevin Wolf
This contains the changes that were part of the first version 3 specification RFC, but aren't implemented by qemu yet. They are not meant to become official yet. Changes implemented in this RFC: - Added a dirty flag which tells that the refcount may not be accurate ("QED mode"). This means that

[Qemu-devel] [PATCH 01/19] Specification for qcow2 version 3

2012-04-12 Thread Kevin Wolf
This updates the qcow2 specification to cover version 3. It contains the following changes: - Added compatible/incompatible/auto-clear feature bits plus an optional feature name table to allow useful error messages even if an older version doesn't know some feature at all. - Configurable refc

[Qemu-devel] [PATCH 06/19] qcow2: Ignore reserved bits in L1/L2 entries

2012-04-12 Thread Kevin Wolf
This changes the still existing places that assume that the only flags are QCOW_OFLAG_COPIED and QCOW_OFLAG_COMPRESSED to properly mask out reserved bits. It does not convert bdrv_check yet. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 26 +- block/qcow2-refc

Re: [Qemu-devel] [PATCH v2] bsd-user: fix compile failure

2012-04-12 Thread Stefan Weil
Am 12.04.2012 13:43, schrieb Peter Maydell: bsd-user doesn't actually support reserving a memory area for the guest address space, but we need to at least define the reserved_va global so that cpu-all.h's RESERVED_VA macro will work correctly. This fixes a compilation error introduced in commit

[Qemu-devel] [PATCH 19/19] [RFC] Add feature table entries for new flags

2012-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 1b29572..6f8228f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -949,7 +949,15 @@ int qcow2_update_header(BlockDriverState *bs)

[Qemu-devel] [PATCH 08/19] qcow2: Simplify count_cow_clusters

2012-04-12 Thread Kevin Wolf
count_cow_clusters() tries to reuse existing functions, and all it achieves is to make things much more complicated than they really are: Everything needs COW, unless it's a normal cluster with refcount 1. This patch implements the obvious way of doing this, and by using qcow2_get_cluster_type() i

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 11:09 AM, Peter Maydell wrote: On 12 April 2012 17:02, Anthony Liguori wrote: On 04/12/2012 10:52 AM, Peter Maydell wrote: Why would you design an infrastructure that lets you coherently bundle together a collection of devices and have configurable properties on that bundle as we

Re: [Qemu-devel] Fiber switching and stack protection

2012-04-12 Thread Stefan Weil
Am 12.04.2012 12:18, schrieb Paolo Bonzini: Il 12/04/2012 12:13, Kevin Wolf ha scritto: I guess it's this non-thread-local TLS once again, basically a compiler bug. Paolo, wasn't there a compiler option that works around the problem? Kevin I asked to test it (-D_MT) but never got any answer.

Re: [Qemu-devel] [PATCH v2 06/24] qdev: fix -device foo,?

2012-04-12 Thread Andreas Färber
Am 11.04.2012 23:30, schrieb Paolo Bonzini: > Since most property types do not have a parse property now, this was > broken. Fix it by looking at the setter instead. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg,

[Qemu-devel] [PATCH 00/19] qcow2: Add basic version 3 support

2012-04-12 Thread Kevin Wolf
In this submission, the TODO items that the RFC still had should all be cleaned up now. The parts of the spec and the code that refer to not yet implemented features are moved to two RFC patches at the end of the series, which are not meant to be applied at this point. I think the rest can be merge

Re: [Qemu-devel] [PATCH v2 05/24] qdev: push "type" property up to Object

2012-04-12 Thread Andreas Färber
Am 11.04.2012 23:30, schrieb Paolo Bonzini: > Now that Object is a type, add an instance_init function and push > the "type" property from qdev to there. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber Although I think Anthony already reviewed this in v1? /-F -- SUSE LINUX Prod

Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type

2012-04-12 Thread Andreas Färber
Am 11.04.2012 23:30, schrieb Paolo Bonzini: > Right now the base Object class has a special NULL type. Change this so > that we will be able to add class_init and class_base_init callbacks. > To do this, remove some special casing of ObjectClass that is not really > necessary. > > Signed-off-by:

[Qemu-devel] [Bug 979714] [NEW] Guest timer interrupt isn't switched off when local timer is enabled

2012-04-12 Thread chao zhou
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows): Linux(RHEL6u1) kvm.git Commit:4f324a1b qemu-kvm Commit: b5ed4b6f Host Kernel Version:3.3.0-rc5 Hardware: Romley-EP, WSM-EP Bug detailed description:

[Qemu-devel] [PATCH 05/19] qcow2: Fail write_compressed when overwriting data

2012-04-12 Thread Kevin Wolf
qcow2_alloc_compressed_cluster_offset() already fails if the copied flag is set, because qcow2_write_compressed() doesn't perform COW as it would have to do to allow this. However, what we really want to check here is whether the cluster is allocated or not. With internal snapshots the copied flag

Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type

2012-04-12 Thread Andreas Färber
Am 12.04.2012 18:11, schrieb Paolo Bonzini: > Il 12/04/2012 18:09, Andreas Färber ha scritto: >> I think I had suggested static const and moving them to before the >> register_types() function? > > I'm not sure why that would be useful... Well, I'm not sure why Anthony is doing it differently fro

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Paolo Bonzini
Il 12/04/2012 18:09, Peter Maydell ha scritto: > On 12 April 2012 17:02, Anthony Liguori wrote: >> On 04/12/2012 10:52 AM, Peter Maydell wrote: >>> Why would you design an infrastructure that lets you coherently bundle >>> together a collection of devices and have configurable properties on >>> th

Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type

2012-04-12 Thread Paolo Bonzini
Il 12/04/2012 18:09, Andreas Färber ha scritto: > I think I had suggested static const and moving them to before the > register_types() function? I'm not sure why that would be useful... Paolo

[Qemu-devel] [PATCH 02/19] qcow2: Save disk size in snapshot header

2012-04-12 Thread Kevin Wolf
This allows that different snapshots of an image can have different sizes, which is a requirement for enabling image resizing even with images that have internal snapshots. We don't do the actual support for it now, but make sure that the additional field is present and not completely ignored in a

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Peter Maydell
On 12 April 2012 17:02, Anthony Liguori wrote: > On 04/12/2012 10:52 AM, Peter Maydell wrote: >> Why would you design an infrastructure that lets you coherently bundle >> together a collection of devices and have configurable properties on >> that bundle as well as on the devices, and then *not* u

Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type

2012-04-12 Thread Andreas Färber
Am 11.04.2012 23:30, schrieb Paolo Bonzini: > Right now the base Object class has a special NULL type. Change this so > that we will be able to add class_init and class_base_init callbacks. > To do this, remove some special casing of ObjectClass that is not really > necessary. > > Signed-off-by:

[Qemu-devel] [PATCH 10/19] qcow2: Ignore reserved bits in check_refcounts

2012-04-12 Thread Kevin Wolf
Also don't infer the cluster type directly from the L2 entries, but use qcow2_get_cluster_type() to keep everything in a single place. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 98 ++- 1 files changed, 54 insertions(+), 44 deletions(-)

[Qemu-devel] [PATCH 11/19] qcow2: Version 3 images

2012-04-12 Thread Kevin Wolf
This adds the basic infrastructure to qcow2 to handle version 3 images. It includes code to create v3 images, allow header updates for v3 images and checks feature bits. It still misses support for zero clusters, so this is not a fully compliant implementation of v3 yet. The default for creating

[Qemu-devel] [PATCH 14/19] qemu-iotests: add a simple test for write_zeroes

2012-04-12 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- tests/qemu-iotests/033 | 73 tests/qemu-iotests/033.out | 29 + tests/qemu-iotests/group |1 + 3 files changed, 103 insertions(+), 0 deletio

[Qemu-devel] [PATCH 03/19] qcow2: Ignore reserved bits in get_cluster_offset

2012-04-12 Thread Kevin Wolf
With this change, reading from a qcow2 image ignores all reserved bits that are set in an L1 or L2 table entry. Now get_cluster_offset() assigns *cluster_offset only the offset without any other flags. The cluster type is not longer encoded in the offset, but a positive return value in case of suc

Re: [Qemu-devel] [PATCH v2 02/24] qom: add object_child_foreach

2012-04-12 Thread Andreas Färber
Am 11.04.2012 23:30, schrieb Paolo Bonzini: > A utility function that will be used to implement hierarchical realization. > > Signed-off-by: Paolo Bonzini > --- > include/qemu/object.h | 14 +- > qom/object.c | 17 + > 2 files changed, 30 insertions(+), 1

[Qemu-devel] [PATCH 15/19] qemu-iotests: Test backing file COW with zero clusters

2012-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/034 | 113 tests/qemu-iotests/034.out | 81 +++ tests/qemu-iotests/group |1 + 3 files changed, 195 insertions(+), 0 deletions(-) create mode 100755 tests/qemu-i

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 10:52 AM, Peter Maydell wrote: On 12 April 2012 16:43, Anthony Liguori wrote: I don't think machines should be objects. Chipsets should be QOM objects. What the machines currently do does not map well to modeling as an object. Why would you design an infrastructure that lets y

Re: [Qemu-devel] [PATCH v2 01/24] qom: add object_class_get_parent

2012-04-12 Thread Andreas Färber
Am 11.04.2012 23:30, schrieb Paolo Bonzini: > This simple bit of functionality was missing and we'll need it soon, > so add it. > > Signed-off-by: Paolo Bonzini > --- > include/qemu/object.h | 14 ++ > qom/object.c | 13 + > 2 files changed, 27 insertions(+)

[Qemu-devel] [Bug 979714] Re: Guest timer interrupt isn't switched off when local timer is enabled

2012-04-12 Thread chao zhou
** Attachment added: "dmesg in guest" https://bugs.launchpad.net/bugs/979714/+attachment/3051557/+files/timerdmesg.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/979714 Title: Guest timer in

[Qemu-devel] [PATCH 09/19] qcow2: Ignore reserved bits in refcount table entries

2012-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c |2 +- block/qcow2.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 2ec3aa7..50bf44e 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c

[Qemu-devel] [PATCH 04/19] qcow2: Ignore reserved bits in count_contiguous_clusters()

2012-04-12 Thread Kevin Wolf
Until now, count_contiguous_clusters() has an argument that allowed to specify flags that should be ignored in the comparison, i.e. that are allowed to change between contiguous clusters. This patch changes the function so that it ignores all flags by default now and you need to pass the flags on

[Qemu-devel] [PATCH 12/19] qcow2: Support reading zero clusters

2012-04-12 Thread Kevin Wolf
This adds support for reading zero clusters in version 3 images. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 17 + block/qcow2-refcount.c |7 +++ block/qcow2.c |8 block/qcow2.h |5 + 4 files changed, 33 insertions(+), 4

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Andreas Färber
Am 12.04.2012 17:43, schrieb Anthony Liguori: > On 04/12/2012 10:15 AM, Paolo Bonzini wrote: >> Il 12/04/2012 15:58, Andreas Färber ha scritto: >>> The big clash that Paolo and I had turned out to stem from tackling two >>> virtually inconsolable goals, both under the banner of "realize": >> >> I t

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Peter Maydell
On 12 April 2012 16:43, Anthony Liguori wrote: > I don't think machines should be objects. > > Chipsets should be QOM objects.  What the machines currently do does not map > well to modeling as an object. Why would you design an infrastructure that lets you coherently bundle together a collection

[Qemu-devel] [PATCH 16/19] qcow2: Zero write support

2012-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 14 +++-- block/qcow2-cluster.c | 72 + block/qcow2.c | 21 ++ block/qcow2.h |1 + 4 files changed, 105 insertions(+), 3 deletions(-) diff --git a/block

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 10:15 AM, Paolo Bonzini wrote: Il 12/04/2012 15:58, Andreas Färber ha scritto: The big clash that Paolo and I had turned out to stem from tackling two virtually inconsolable goals, both under the banner of "realize": I think the code was similar enough that the goals are not unre

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Anthony Liguori
On 04/12/2012 09:04 AM, Andreas Färber wrote: Am 12.04.2012 16:59, schrieb Paolo Bonzini: Il 12/04/2012 16:47, Anthony Liguori ha scritto: Wrap setting of Object::realized property, error reporting and exit(1) into a helper function. It is the equivalent of qdev_init_nofail(). I don't like

[Qemu-devel] [PATCH 13/19] qcow2: Support for feature table header extension

2012-04-12 Thread Kevin Wolf
Instead of printing an ugly bitmask, qemu can now print a more helpful string even for yet unknown features. Signed-off-by: Kevin Wolf --- block/qcow2.c | 66 +--- block/qcow2.h | 12 ++ 2 files changed, 69 insertions(+), 9 deletion

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Paolo Bonzini
Il 12/04/2012 16:47, Anthony Liguori ha scritto: > >> Wrap setting of Object::realized property, error reporting and exit(1) >> into a helper function. It is the equivalent of qdev_init_nofail(). > > I don't like this. > > If for no reason other than, a much more specific justification is > need

[Qemu-devel] [PATCH 17.5/19] qemu-iotests: Fix test 031 for qcow2 v3 support

2012-04-12 Thread Kevin Wolf
qcow2.py must be updated to work with version 3 images at all, the output has changed since the feature table extension has been added, and version 2 and version 3 images can't possibly have the same test output. Change the test case to completely ignore IMGOPTS and run the test for both compat=1.

Re: [Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-12 Thread Michael S. Tsirkin
On Thu, Apr 12, 2012 at 08:57:18AM -0600, Alex Williamson wrote: > On Wed, 2012-04-11 at 10:40 +0300, Michael S. Tsirkin wrote: > > On Tue, Apr 10, 2012 at 04:07:41PM -0600, Alex Williamson wrote: > > > > Some points I remember > > > > - power on is better called slot enabled > > > > - guests dont

[Qemu-devel] [PATCH 07/19] qcow2: Refactor qcow2_free_any_clusters

2012-04-12 Thread Kevin Wolf
Zero clusters will add another cluster type. Refactor the open-coded cluster type detection into a switch of QCOW2_CLUSTER_* options so that the detection is in a single place. This makes it easier to add new cluster types. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 41

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Paolo Bonzini
Il 12/04/2012 15:58, Andreas Färber ha scritto: > The big clash that Paolo and I had turned out to stem from tackling two > virtually inconsolable goals, both under the banner of "realize": I think the code was similar enough that the goals are not unreconcilable (though QOM goals can certainly be

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-12 Thread Andreas Färber
Am 12.04.2012 16:59, schrieb Paolo Bonzini: > Il 12/04/2012 16:47, Anthony Liguori ha scritto: >> >>> Wrap setting of Object::realized property, error reporting and exit(1) >>> into a helper function. It is the equivalent of qdev_init_nofail(). >> >> I don't like this. >> >> If for no reason other

[Qemu-devel] [PATCH 17/19] qemu-iotests: Add -o and make v3 the default for qcow2

2012-04-12 Thread Kevin Wolf
This adds an -o option to qemu-iotests, which is an option string that is passed through to qemu-img create -o... This allows testing different subformat with a command like './check -qcow2 -o compat=0.10'. For qcow2, if no compat option is specified, compat=1.1 is the new default. Signed-off-by:

Re: [Qemu-devel] current git master compile fails on Debian 4.0

2012-04-12 Thread Kai NODA
Hi Paolo, I've encountered the same problem as Erik on my RHEL5 machine with glib 2.12, and made a patch to replace GHashTableIter with g_hash_table_find(). https://github.com/nodakai/QEMU/commit/4a9dd009feb1d78e3566069336a0d1b9a296bd23 I think it's an almost same approach with yours, but have not

[Qemu-devel] [PATCH 2/2] versatiblepb: add NOR flash support

2012-04-12 Thread Eric Bénard
- add support for the 64MB NOR CFI01 flash available at 0x3400 on the versatilepb board http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0225d/BBAJIHEC.html - give the possibility to boot from the flash if no kernel is provided to qemu - initial idea from http://lists.gnu.org/ar

  1   2   >