Re: [Qemu-devel] [V6 PATCH] virtio-net: send gratuitous packets when needed

2012-04-04 Thread Michael S. Tsirkin
On Thu, Apr 05, 2012 at 01:56:15PM +0800, Jason Wang wrote: > On 04/04/2012 03:49 PM, Michael S. Tsirkin wrote: > >On Wed, Mar 28, 2012 at 01:44:28PM +0800, Jason Wang wrote: > >>As hypervior does not have the knowledge of guest network configuration, > >>it's > >>better to ask guest to send gratu

[Qemu-devel] [PATCH 4/5] acpi_piix4: Remove PCI_RMV_BASE write code

2012-04-04 Thread Alex Williamson
Achieves the same result with less code. Signed-off-by: Alex Williamson --- docs/specs/acpi_pci_hotplug.txt |2 +- hw/acpi_piix4.c |6 -- 2 files changed, 1 insertions(+), 7 deletions(-) diff --git a/docs/specs/acpi_pci_hotplug.txt b/docs/specs/acpi_pci_hotplug.txt

[Qemu-devel] [PATCH 5/5] acpi_piix4: Fix PCI hotplug race

2012-04-04 Thread Alex Williamson
As Michael Tsirkin demonstrated, current PCI hotplug is vulnerable to a few races. The first is a race with other hotplug operations because we clear the up & down registers at each event. If a new event comes before the last is processed, up/down is cleared and the event is lost. To fix this fo

Re: [Qemu-devel] [V6 PATCH] virtio-net: send gratuitous packets when needed

2012-04-04 Thread Jason Wang
On 04/04/2012 03:49 PM, Michael S. Tsirkin wrote: On Wed, Mar 28, 2012 at 01:44:28PM +0800, Jason Wang wrote: As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packets when needed. Guest tests VIRTIO_NET_S_ANNOUNCE bit during co

[Qemu-devel] [PATCH 2/5] acpi_piix4: Only allow writes to PCI hotplug eject register

2012-04-04 Thread Alex Williamson
This is never read. We can also derive bus from the write handler, making this more inline with the other callbacks. Note that pciej_write was actually called with (PCIBus *)dev->bus, which is cast as a void* allowing us to pretend it's a BusState*. Fix this so we don't depend on the BusState lo

[Qemu-devel] [PATCH 3/5] acpi_piix4: Use pci_get/set_byte

2012-04-04 Thread Alex Williamson
Remove stray direct access Signed-off-by: Alex Williamson --- hw/acpi_piix4.c | 53 +++-- 1 files changed, 27 insertions(+), 26 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 6ee832a..c1b1532 100644 --- a/hw/acpi_piix4.c +++

[Qemu-devel] [PATCH 1/5] acpi_piix4: Disallow write to up/down PCI hotplug registers

2012-04-04 Thread Alex Williamson
These are never written, clarify spec, remove access. Split reads into two smaller functions. Signed-off-by: Alex Williamson --- docs/specs/acpi_pci_hotplug.txt |4 ++-- hw/acpi_piix4.c | 42 --- 2 files changed, 15 insertions(+), 31 de

[Qemu-devel] [PATCH 0/5] PCI hotplug fixes/cleanup

2012-04-04 Thread Alex Williamson
We've been batting this one back and forth. This series includes several of the cleanups and specification clarifications from my series awhile back. Patch 5 is my proposed alternative to Michael's PCI hotplug race fix. Since that version I added slot present tracking so we can be a little more

Re: [Qemu-devel] [PULL] s390 patch queue 2012-04-04

2012-04-04 Thread Blue Swirl
On Wed, Apr 4, 2012 at 17:19, Andreas Färber wrote: > Hello, > > This is the current patch queue for s390. Please pull. Thanks, pulled. > The following changes since commit f05f6b4adb4db3affb0cdd17383b0a7e905e66e1: > >  qdev: put all devices under /machine (2012-04-02 15:04:15 -0500) > > are ava

[Qemu-devel] [PATCH 12/14] create_config: simplify prefix=* block, remove CONFIG_QEMU_PREFIX

2012-04-04 Thread Eduardo Habkost
As now that block handles only the prefix variable, the code can be much simpler. This also removes the CONFIG_QEMU_PREFIX define as it is not used by any C code. Signed-off-by: Eduardo Habkost --- scripts/create_config |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 08/14] config-host.mak: rename docdir to qemu_docdir

2012-04-04 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Makefile |4 ++-- configure |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 795f9c4..f919fea 100644 --- a/Makefile +++ b/Makefile @@ -267,8 +267,8 @@ BLOBS= endif install-doc: $(DOCS) - $(INSTALL

Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implementation Interface type "vmxnet3" added.

2012-04-04 Thread Gerhard Wiesinger
On Wed, 4 Apr 2012, Izik Eidus wrote: What about this patch?, everything that was asked from Dmitry was accomplished... What prevent us from progressing with merging this patch? As already discussed on the list patch v5 doesn't work at least for me. Previous patches worked better but were not

Re: [Qemu-devel] [PATCH 00/13] Convert ARM GIC to sysbus device

2012-04-04 Thread Evgeny Voevodin
On 04.04.2012 19:30, Peter Maydell wrote: This patch series converts the ARM GIC to a self-contained sysbus device, rather than having it be implemented by a C file which is #included in half a dozen different other files. The motivation for this is that when we have a KVM in-kernel GIC implemen

Re: [Qemu-devel] [PATCH 04/13] arm_gic: Make the GIC its own sysbus device

2012-04-04 Thread Evgeny Voevodin
On 04.04.2012 19:30, Peter Maydell wrote: Compile arm_gic.c as a standalone C file to produce a self contained sysbus GIC device. Support the legacy usage by #include of the .c file by making those users #define LEGACY_INCLUDED_GIC, so we can convert them one by one. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 08/13] hw/exynos4210_gic.c: Convert to using sysbus GIC

2012-04-04 Thread Evgeny Voevodin
On 04.04.2012 19:30, Peter Maydell wrote: Convert the Exynos GIC code to use the standalone sysbus GIC device. Signed-off-by: Peter Maydell --- hw/exynos4210_gic.c | 32 1 files changed, 24 insertions(+), 8 deletions(-) diff --git a/hw/exynos4210_gic.c b/hw

[Qemu-devel] [PATCH 00/13] Convert ARM GIC to sysbus device

2012-04-04 Thread Peter Maydell
This patch series converts the ARM GIC to a self-contained sysbus device, rather than having it be implemented by a C file which is #included in half a dozen different other files. The motivation for this is that when we have a KVM in-kernel GIC implementation it will be easier to just drop that i

Re: [Qemu-devel] [PATCH 02/13] hw/arm_gic: Move gic_get_current_cpu into arm_gic.c

2012-04-04 Thread Evgeny Voevodin
On 04.04.2012 19:30, Peter Maydell wrote: Move the gic_get_current_cpu() function into arm_gic.c. There are only two implementations: (1) "get the index of the currently executing CPU", used by all multicore GICs, and (2) "always 0", used by all GICs instantiated with a single CPU interface (the

Re: [Qemu-devel] [PATCH 01/13] hw/arm_gic: Move NCPU definition to arm_gic.c

2012-04-04 Thread Evgeny Voevodin
On 04.04.2012 19:30, Peter Maydell wrote: hw/arm_gic.c| 13 - Reviewed-by: Evgeny Voevodin -- Kind regards, Evgeny Voevodin, Leading Software Engineer, ASWG, Moscow R&D center, Samsung Electronics e-mail: e.voevo...@samsung.com

[Qemu-devel] [PATCH 10/14] config-host.mak: reorder variables a bit

2012-04-04 Thread Eduardo Habkost
Cosmetic change. Signed-off-by: Eduardo Habkost --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index eca08bb..37f455c 100755 --- a/configure +++ b/configure @@ -2980,10 +2980,10 @@ echo "bindir=$bindir" >> $config_host_mak echo "l

[Qemu-devel] [PATCH 11/14] create_config: remove *dir block

2012-04-04 Thread Eduardo Habkost
Now only the qemu_*dir variables will become #defines. The other directory names aren't used by the C code. That means the following #defines won't be available in C code anymore: - CONFIG_QEMU_BINDIR - CONFIG_QEMU_LIBDIR - CONFIG_QEMU_INCLUDEDIR - CONFIG_QEMU_MANDIR - CONFIG_QEMU_SYSCONFDIR

[Qemu-devel] [PATCH V2 7/7] hw/apm.c: replace register_ioport*

2012-04-04 Thread Julien Grall
This patch replaces all register_ioport* by a MemorySection. It permits to use the new Memory stuff like listener. Moreover, the PCI is added as an argument for apm_init, so we can register IO inside the pci IO address space. Signed-off-by: Julien Grall --- hw/acpi_piix4.c |2 +- hw/apm.c

[Qemu-devel] [PATCH 03/14] configure: rename $confdir to $qemu_confdir

2012-04-04 Thread Eduardo Habkost
There's no "confdir" variable on Autoconf, but it's good to make it clear that it's a variable for the Qemu-specific subdirectory inside $sysconfdir. Signed-off-by: Eduardo Habkost --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure ind

[Qemu-devel] [PATCH V2 4/7] hw/serial.c: replace register_ioport*

2012-04-04 Thread Julien Grall
This patch replaces all register_ioport* with a MemoryRegion. It permits to use the new Memory stuff like listener. For more flexibility, the IO address space is passed as an argument. Signed-off-by: Julien Grall --- hw/pc.h |2 +- hw/serial.c |8 +--- 2 files changed, 6 inserti

Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implementation Interface type "vmxnet3" added.

2012-04-04 Thread Izik Eidus
Hi, What about this patch?, everything that was asked from Dmitry was accomplished... What prevent us from progressing with merging this patch? Thanks. On 18/03/2012 11:27, Dmitry Fleytman wrote: Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- Makefile.objs |

[Qemu-devel] [PATCH 01/14] configure: rename $datadir to $qemu_datadir

2012-04-04 Thread Eduardo Habkost
The variable is used for the qemu-specific directory and has a different meaning of the autoconf "datadir" variable (that's used for the $prefix/share directory, not for $prefix/share/PACKAGE). This doesn't change behavior or interfaces, it's just an internal variable rename. Signed-off-by: Eduar

[Qemu-devel] [PATCH 05/14] config-host.mak: rename datadir to qemu_datadir

2012-04-04 Thread Eduardo Habkost
Autoconf concept of "datadir" is supposed to be "$prefix/share", not "$prefix/share/PACKAGE", so using datadir for the Qemu-specific directory is confusing. The current C code that uses CONFIG_QEMU_DATADIR should be safe, as now create_config generates the same #define name (CONFIG_QEMU_DATADIR) f

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] pseries: Fix bug with reset of VIO CRQs

2012-04-04 Thread David Gibson
On Wed, Apr 04, 2012 at 06:13:36PM +0200, Andreas Färber wrote: > Am 28.03.2012 23:39, schrieb David Gibson: [snip] > However, I'm having trouble testing reset. Whether on vanilla master or > using this patch on top of ppc-next or this whole series on top of > ppc-next, using `ppc64-softmmu/qemu-sy

Re: [Qemu-devel] [PATCH 0/4] linux-user: Option parser cleanup

2012-04-04 Thread Meador Inge
Ping. Any comments on this series? On 03/27/2012 05:44 PM, Meador Inge wrote: > This series is focused at cleaning up a few issues in the > GNU/Linux usermode driver's option parsing. -h has been > fixed to exit with 0, a -help option has been added, proper > error messages have been added for u

Re: [Qemu-devel] Using load_elf

2012-04-04 Thread Brian Vandenberg
> ROM images are in form of binary blobs with no location information, > they must be loaded to a known address. For boot ROMs, the address > range would cover CPU hard reset entry vector. So, for a BIOS or boot ROM that has been stripped, the board needs to be hard-coded to not just load the imag

[Qemu-devel] [PATCH 14/14] configure: add --with-confsuffix option

2012-04-04 Thread Eduardo Habkost
This will allow the user to make Qemu use a different subdirectory name inside $datadir and $sysconfdir, instead of "/qemu". Signed-off-by: Eduardo Habkost --- configure |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 521d233..961c10e

[Qemu-devel] [PATCH 02/14] configure: rename $docdir to $qemu_docdir

2012-04-04 Thread Eduardo Habkost
The autoconf "docdir" variable is used for the program-specific subdirectory, but anyway it's better to make it clear that the variable is used for the qemu-specific subdirectory path. Signed-off-by: Eduardo Habkost --- configure |8 1 files changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] pseries: Fix bug with reset of VIO CRQs

2012-04-04 Thread David Gibson
On Wed, Apr 04, 2012 at 06:13:36PM +0200, Andreas Färber wrote: > Am 28.03.2012 23:39, schrieb David Gibson: > > PAPR specifies a Command Response Queue (CRQ) mechanism used for virtual > > IO, which we implement. However, we don't correctly clean up registered > > CRQs when we reset the system. >

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 17:38, Jan Kiszka wrote: > On 2012-04-04 17:29, Paolo Bonzini wrote: >> Il 04/04/2012 17:24, Jan Kiszka ha scritto: > For patches 3 and 4, I'd rather use an EventNotifier... >>> ...which still lacks support for non-eventfd systems. Hmm, I guess it's >>> time to consolidate both. >

[Qemu-devel] [PATCH 10/13] hw/arm_gic: Make gic_reset a sysbus reset function

2012-04-04 Thread Peter Maydell
Make gic_reset a sysbus reset function, so we actually reset the GIC on system reset rather than only at init. For the NVIC this requires us also to implement reset of the SysTick. Signed-off-by: Peter Maydell --- hw/arm_gic.c |5 +++-- hw/armv7m_nvic.c | 16 2 files c

[Qemu-devel] [PATCH V2 3/7] hw/cirrus_vga.c: replace register_ioport*

2012-04-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_*. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/cirrus_vga.c | 38 ++ 1 files changed, 22 insertions(+), 16 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirru

[Qemu-devel] [PATCH 4/5] Reorder POSIX compat AIO code

2012-04-04 Thread Jan Kiszka
Effectively no functional changes. This just moves posix_aio_notify_event up without modifying it and folds die/die2 into their only remaining user. Signed-off-by: Jan Kiszka --- posix-aio-compat.c | 44 1 files changed, 16 insertions(+), 28 deletio

[Qemu-devel] [PATCH v2 0/2] QOM'ify SPARC CPU

2012-04-04 Thread Andreas Färber
Hello Blue, This series strips down my SPARC QOM'ification patch from the qom-cpu-others.v1 RFC series to the bare minimum needed and splits off the file rename. Subclasses and properties can follow up later, specific to target-sparc then. I've picked up your idea of using different type names f

[Qemu-devel] [PATCH v2 1/2] target-sparc: Rename cpu_init.c

2012-04-04 Thread Andreas Färber
Align QOM'ified targets, with a view to simplify Makefile.target. Signed-off-by: Andreas Färber --- Makefile.target|2 +- target-sparc/{cpu_init.c => cpu.c} |0 2 files changed, 1 insertions(+), 1 deletions(-) rename target-sparc/{cpu_init.c => cpu.c} (100%) diff --

[Qemu-devel] [PATCH 09/14] config-host.mak: remove CONFIG_QEMU_SHAREDIR

2012-04-04 Thread Eduardo Habkost
There is no code using that variable according to 'git grep', so kill it. Signed-off-by: Eduardo Habkost --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index f15b714..eca08bb 100755 --- a/configure +++ b/configure @@ -2985,7 +2985,6 @

[Qemu-devel] [PULL] s390 patch queue 2012-04-04

2012-04-04 Thread Andreas Färber
Hello, This is the current patch queue for s390. Please pull. The following changes since commit f05f6b4adb4db3affb0cdd17383b0a7e905e66e1: qdev: put all devices under /machine (2012-04-02 15:04:15 -0500) are available in the git repository at: git://repo.or.cz/qemu/agraf.git s390-for-upstre

[Qemu-devel] [PATCH V2 6/7] hw/dma.c: replace register_ioport*

2012-04-04 Thread Julien Grall
This patch replaces all register_ioport* with isa_register_portio_list. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/dma.c | 55 +-- 1 files changed, 37 insertions(+), 18 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-04 Thread David Gibson
On Wed, Apr 04, 2012 at 12:58:37PM +0200, Jan Kiszka wrote: > On 2012-04-04 03:12, David Gibson wrote: > >> Also, what's about coalesced MMIO? I see that the ring definition > >> depends on [TARGET_]PAGE_SIZE. What page size does the power kernel use > >> for it, and does it make a relevant differe

[Qemu-devel] [PATCH 05/13] hw/a15mpcore: switch to using sysbus GIC

2012-04-04 Thread Peter Maydell
Switch the a15mpcore private peripheral region to using the standalone sysbus GIC device. Signed-off-by: Peter Maydell --- hw/a15mpcore.c | 35 ++- 1 files changed, 26 insertions(+), 9 deletions(-) diff --git a/hw/a15mpcore.c b/hw/a15mpcore.c index 54c0dbf..5a7

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-04 Thread Peter Crosthwaite
>> >> It may be a case though that ssi is a superclass of spi - all SPI >> devices are SSI devices but not all SSI devices are SPI? To that end >> can we make SPI a child object of SSI with the desired extra behaviors >> mentioned in this thread? This kind of stuff is the whole reason for >> QOM. >

Re: [Qemu-devel] PL353 Device model

2012-04-04 Thread Peter Crosthwaite
Thanks for you thoughts Andreas, On Thu, Apr 5, 2012 at 9:56 AM, Andreas Färber wrote: > Hello John, > > Am 05.04.2012 01:35, schrieb John Williams: >> On Fri, Mar 30, 2012 at 5:13 PM, Peter Crosthwaite >> wrote: >> >>> We currently have a somewhat hacky PL353 device model in our tree that >>> w

[Qemu-devel] [PATCH 02/13] hw/arm_gic: Move gic_get_current_cpu into arm_gic.c

2012-04-04 Thread Peter Maydell
Move the gic_get_current_cpu() function into arm_gic.c. There are only two implementations: (1) "get the index of the currently executing CPU", used by all multicore GICs, and (2) "always 0", used by all GICs instantiated with a single CPU interface (the Realview board GIC and the v7M NVIC). So we

Re: [Qemu-devel] PL353 Device model

2012-04-04 Thread Andreas Färber
Hello John, Am 05.04.2012 01:35, schrieb John Williams: > On Fri, Mar 30, 2012 at 5:13 PM, Peter Crosthwaite > wrote: > >> We currently have a somewhat hacky PL353 device model in our tree that >> we wish to refactor and ultimately push to mainline. Before I go about >> reworking it, I wish to d

Re: [Qemu-devel] [PATCH v2 0/2] Xilinx Zynq PL330 support

2012-04-04 Thread John Williams
On Fri, Mar 30, 2012 at 5:58 PM, Peter A. G. Crosthwaite wrote: > These patches add support for the Primcell PL330 DMA controller and add it to > the Xilinx Zynq machine model. Patch 1 is the device model. Patch 2 is the > machine model update. > > The Device model was originally contributed by

Re: [Qemu-devel] PL353 Device model

2012-04-04 Thread John Williams
On Fri, Mar 30, 2012 at 5:13 PM, Peter Crosthwaite wrote: > We currently have a somewhat hacky PL353 device model in our tree that > we wish to refactor and ultimately push to mainline. Before I go about > reworking it, I wish to discuss the architecture of this device model > because its non-tri

[Qemu-devel] [PATCH v2 2/2] target-sparc: QOM'ify CPU

2012-04-04 Thread Andreas Färber
Embed CPUSPARCState as first member of SPARCCPU. Drop cpu_sparc_close() in favor of object_delete() and a finalizer. Let cpu_state_reset() call cpu_reset(). Make TYPE_SPARC_CPU non-abstract for now. Distinguish between "sparc-cpu" and "sparc64-cpu". Signed-off-by: Andreas Färber --- target-spar

[Qemu-devel] [PATCH V2 1/7] isa: add isa_address_space_io

2012-04-04 Thread Julien Grall
This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall --- hw/isa-bus.c |5 + hw/isa.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Paolo Bonzini
Il 04/04/2012 17:24, Jan Kiszka ha scritto: >> > For patches 3 and 4, I'd rather use an EventNotifier... > ...which still lacks support for non-eventfd systems. Hmm, I guess it's > time to consolidate both. Perhaps you can take the relevant patches out of the thread-blocks branch at git://github.c

Re: [Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention

2012-04-04 Thread Paolo Bonzini
Il 30/03/2012 19:33, Eduardo Habkost ha scritto: > Autoconf uses --datadir for the /usr/share directory, not the > program-specific subdirectory inside /usr/share. This changes configure > to match autoconf behavior. > > Note that this will break compatibility with existing build scripts. > > Sig

Re: [Qemu-devel] Windows Virtio Issue

2012-04-04 Thread emilien
Vadim Rozenfeld redhat.com> writes: > Hi Paul, > Managed to reproduce this problem, thank you. Going to fix it in the build. > Meanwhile, instead of writeback, could you try cache=off ? > > Best regards, > Vadim. > > Any news? I have the same issue with cache=off, there isn't any fix? Best

[Qemu-devel] [PATCH 06/14] config-host.mak: rename confdir to qemu_confdir

2012-04-04 Thread Eduardo Habkost
$confdir is a confusing name, as it's not clear if it's "the system config dir" or "the Qemus-specific directory inside the config dir". $qemu_confdir makes it more clear. The current C code that uses CONFIG_QEMU_CONFDIR should be safe, as now create_config generates the same #define name (CONFIG_

[Qemu-devel] [PATCH 04/14] create_config: separate section for qemu_*dir variables (v2)

2012-04-04 Thread Eduardo Habkost
The generic *dir section will eventually go away and be replaced with qemu_* section. By now, both sections will be kept, while the variables get renamed on config-host.mak. With this patch, a XXXdir variable will become a CONFIG_QEMU_XXXDIR define, and a qemu_XXXdir variable will become CONFIG_QE

[Qemu-devel] [PATCH V2 5/7] hw/pc.c: replace register_ioport*

2012-04-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_* or isa_register_portio_list. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/pc.c | 37 +++-- 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/hw/pc.c

Re: [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

2012-04-04 Thread Peter Maydell
On 4 April 2012 21:44, Blue Swirl wrote: > On Tue, Mar 20, 2012 at 09:49, Paolo Bonzini wrote: >> On w32, glib implements g_poll using WaitForMultipleObjects >> or MsgWaitForMultipleObjects.  This means that we can simplify >> our code by switching to g_poll, and at the same time prepare for >> a

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-04 Thread Peter Maydell
On 4 April 2012 21:34, Blue Swirl wrote: > On Wed, Apr 4, 2012 at 20:11, Peter Maydell wrote: >> I'd much rather enable a #define to turn on debugging than faff about >> with tracing. It's simple and straightforward, you can do it with a >> single obvious change and recompile, and nobody has to l

Re: [Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

2012-04-04 Thread Blue Swirl
On Tue, Mar 20, 2012 at 09:49, Paolo Bonzini wrote: > On w32, glib implements g_poll using WaitForMultipleObjects > or MsgWaitForMultipleObjects.  This means that we can simplify > our code by switching to g_poll, and at the same time prepare for > adding back glib sources. Unfortunately g_poll d

Re: [Qemu-devel] [PATCH 1/2][sparc64] Fix vector interrupt handling

2012-04-04 Thread Blue Swirl
Thanks, applied both. On Tue, Apr 3, 2012 at 15:49, Artyom Tarasenko wrote: > Don't produce stray irq 5, don't overwrite ivec_data if still busy with > processing of the previous interrupt. > > Signed-off-by: Artyom Tarasenko > --- >  hw/sun4u.c |   29 - >  1 files ch

[Qemu-devel] [PATCH 13/13] hw/arm_gic.c: Remove stray hardcoded tab

2012-04-04 Thread Peter Maydell
Remove the single instance of a hardcoded tab from hw/arm_gic.c. Signed-off-by: Peter Maydell --- hw/arm_gic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index f395e4b..a2aee63 100644 --- a/hw/arm_gic.c +++ b/hw/arm_gic.c @@ -160,7 +160,

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-04 Thread Blue Swirl
On Wed, Apr 4, 2012 at 20:11, Peter Maydell wrote: > On 4 April 2012 20:18, Blue Swirl wrote: >> On Mon, Apr 2, 2012 at 04:17, David Gibson >> wrote: >>> From: Alexey Kardashevskiy >>> This adds DPRINTF() macros with the usual conventions to the spapr_pci >>> code. >> >> Please use tracepoints

[Qemu-devel] [PATCH v4 00/14] configure: --with-confsuffix option

2012-04-04 Thread Eduardo Habkost
I was going to resend only patch 14/14 with a fixed description, but then I noticed the series had to be rebased, with small conflicts on patches 04/14 and 12/14, so I am submitting the whole series again. Changes v3 -> v4: - Rebase against latest qemu.git - Changed patch 14/14 subject to match

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-04 Thread Peter Maydell
On 4 April 2012 20:18, Blue Swirl wrote: > On Mon, Apr 2, 2012 at 04:17, David Gibson > wrote: >> From: Alexey Kardashevskiy >> This adds DPRINTF() macros with the usual conventions to the spapr_pci >> code. > > Please use tracepoints instead of printf statements. Tracing is more > flexible, mo

[Qemu-devel] [PATCH 07/14] Makefile: use $(qemu_confdir) instead of $(sysconfdir)/qemu

2012-04-04 Thread Eduardo Habkost
Instead of hardcoding the directory suffix, use the qemu-specific directory variable. Signed-off-by: Eduardo Habkost --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1c9abec..795f9c4 100644 --- a/Makefile +++ b/Makefile @@ -280,8

[Qemu-devel] [PATCH 2/4] target-s390x: QOM'ify CPU reset

2012-04-04 Thread Andreas Färber
Move code from cpu_state_reset() to s390_cpu_reset(). Signed-off-by: Andreas Färber Tested-by: Christian Borntraeger --- target-s390x/cpu.c| 13 - target-s390x/helper.c | 12 ++-- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/target-s390x/cpu.c b/t

[Qemu-devel] [PATCH 04/13] arm_gic: Make the GIC its own sysbus device

2012-04-04 Thread Peter Maydell
Compile arm_gic.c as a standalone C file to produce a self contained sysbus GIC device. Support the legacy usage by #include of the .c file by making those users #define LEGACY_INCLUDED_GIC, so we can convert them one by one. Signed-off-by: Peter Maydell --- Makefile.target |1 + hw/a15m

[Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention

2012-04-04 Thread Eduardo Habkost
Autoconf uses --datadir for the /usr/share directory, not the program-specific subdirectory inside /usr/share. This changes configure to match autoconf behavior. Note that this will break compatibility with existing build scripts. Signed-off-by: Eduardo Habkost --- configure |9 + 1

Re: [Qemu-devel] Using load_elf

2012-04-04 Thread Blue Swirl
On Mon, Apr 2, 2012 at 22:57, Brian Vandenberg wrote: >  I'm attempting to familiarize myself with the APIs used to add > support for boards in qemu, and I have a few questions. > > * How does using load_elf differ from load_image_targphys? > >  As an example, many of the boards I've looked at hav

[Qemu-devel] [PATCH 3/4] target-s390x: QOM'ify CPU init

2012-04-04 Thread Andreas Färber
Move code from cpu_s390x_init() into an initfn. Signed-off-by: Andreas Färber Tested-by: Christian Borntraeger --- target-s390x/cpu.c| 25 + target-s390x/cpu.h|3 +++ target-s390x/helper.c | 21 +++-- 3 files changed, 31 insertions(+), 18

[Qemu-devel] [PATCH 07/13] hw/realview_gic: switch to sysbus GIC

2012-04-04 Thread Peter Maydell
Switch the realview_gic device to the standalone sysbus GIC. Signed-off-by: Peter Maydell --- hw/realview_gic.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/hw/realview_gic.c b/hw/realview_gic.c index a3b5a04..5bc37a7 100644 ---

Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implementation Interface type "vmxnet3" added.

2012-04-04 Thread Michael S. Tsirkin
On Wed, Apr 04, 2012 at 02:44:01PM +0300, Izik Eidus wrote: > Hi, > > What about this patch?, everything that was asked from Dmitry was > accomplished... > What prevent us from progressing with merging this patch? > > Thanks. Off the top of my head: issues with v5: polluting global namespace, mu

Re: [Qemu-devel] [PATCH 3/3] pseries: Add DPRINTF macros to spapr pci code

2012-04-04 Thread Blue Swirl
On Mon, Apr 2, 2012 at 04:17, David Gibson wrote: > From: Alexey Kardashevskiy > > This adds DPRINTF() macros with the usual conventions to the spapr_pci > code. Please use tracepoints instead of printf statements. Tracing is more flexible, more efficient and does not suffer from bitrot. > Cc:

[Qemu-devel] Switch off use of helper functions

2012-04-04 Thread Rajat Goyal
Is there any way in QEMU to switch off the use of helper functions and make it translate target code to TCG code using only TCG micro-ops and not calls to helper functions? Rajat.

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 17:29, Paolo Bonzini wrote: > Il 04/04/2012 17:24, Jan Kiszka ha scritto: For patches 3 and 4, I'd rather use an EventNotifier... >> ...which still lacks support for non-eventfd systems. Hmm, I guess it's >> time to consolidate both. > > Perhaps you can take the relevant patches

[Qemu-devel] [PATCH 08/13] hw/exynos4210_gic.c: Convert to using sysbus GIC

2012-04-04 Thread Peter Maydell
Convert the Exynos GIC code to use the standalone sysbus GIC device. Signed-off-by: Peter Maydell --- hw/exynos4210_gic.c | 32 1 files changed, 24 insertions(+), 8 deletions(-) diff --git a/hw/exynos4210_gic.c b/hw/exynos4210_gic.c index a05dab2..e1b215e 1006

[Qemu-devel] [PATCH 4/4] target-s390x: Update s390x_{tod, cpu}_timer() to use S390CPU

2012-04-04 Thread Andreas Färber
In place of CPUS390XState pass S390CPU as opaque from the new initfn. cpu_interrupt() is anticipated to take a CPUState in the future. Signed-off-by: Andreas Färber Tested-by: Christian Borntraeger --- target-s390x/cpu.c|4 ++-- target-s390x/helper.c |6 -- 2 files changed, 6 in

[Qemu-devel] [PATCH V2 2/7] hw/acpi_piix4.c: replace register_ioport*

2012-04-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_*. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/acpi_piix4.c | 76 +++ 1 files changed, 65 insertions(+), 11 deletions(-) diff --git a/hw/acpi_p

[Qemu-devel] [PATCH V2 0/7] memory: unify ioport registration

2012-04-04 Thread Julien Grall
This is the second version of patch serie (the previous patch was not split) about ioport registration. For the moment some part of QEMU use register_ioport* functions to register ioport. These functions don't permit the logging of range with Memory Listener. Modifications between V1 and V2 : -

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 18:55, Jan Kiszka wrote: > On 2012-04-04 18:39, Paolo Bonzini wrote: >> Il 04/04/2012 18:05, Jan Kiszka ha scritto: > Perhaps you can take the relevant patches out of the thread-blocks > branch at git://github.com/pbonzini/qemu.git? The iothread eventfd > could also use a

[Qemu-devel] [PATCH 06/13] hw/a9mpcore.c: Switch to using sysbus GIC

2012-04-04 Thread Peter Maydell
Switch the a9mpcore to using the sysbus GIC device rather than having the a9mp private memory region device subclass the GIC. Signed-off-by: Peter Maydell --- hw/a9mpcore.c | 60 +--- 1 files changed, 35 insertions(+), 25 deletions(-) diff -

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Dmitry Zhurikhin
On 2012-04-04 20:16, Maksim Kozlov wrote: > 04.04.2012 16:35, Dmitry Zhurikhin пишет: >> On 2012-04-04 15:55, Maksim Kozlov wrote: >>> 04.04.2012 14:08, Dmitry Zhurikhin пишет: Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry Zhurikhin --- hw/

[Qemu-devel] [PATCH 1/4] target-s390x: QOM'ify CPU

2012-04-04 Thread Andreas Färber
Embed CPUS390XState as first member of S390CPU. Since -cpu is being ignored, make TYPE_S390_CPU non-abstract. Signed-off-by: Andreas Färber Tested-by: Christian Borntraeger --- Makefile.target|1 + target-s390x/cpu-qom.h | 71 targe

[Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
Refreshed versions of some cleanups I already sent last year. See patches for details. The series also helps using different scheduling policies for QEMU threads which includes hardening internal locks. Jan Kiszka (5): Introduce qemu_cond_timedwait for POSIX Switch POSIX compat AIO to QEMU ab

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 18:39, Paolo Bonzini wrote: > Il 04/04/2012 18:05, Jan Kiszka ha scritto: Perhaps you can take the relevant patches out of the thread-blocks branch at git://github.com/pbonzini/qemu.git? The iothread eventfd could also use an EventNotifier. >> Yep, this screams for som

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-04 Thread Paul Brook
> Hi Paul, > > Regarding using ssi, theres a few things that come to mind: > > Theres no sense of it being a multi-slave bus, its just a point to > point link. SPI devices universally have the notion of the CS pin that > tristates the device of the bus. Masters connect to a number of slaves > and

[Qemu-devel] [PATCH 12/13] hw/arm_gic.c: gic_set_pending_private() is NVIC only

2012-04-04 Thread Peter Maydell
The function gic_set_pending_private() is now used by the NVIC only (for the GIC we now set PPI interrupts via gpio lines and gic_set_irq()). So make it #ifdef NVIC and remove the 'attribute unused' annotation. Signed-off-by: Peter Maydell --- hw/arm_gic.c |5 +++-- 1 files changed, 3 insert

[Qemu-devel] [PATCH 11/13] hw/arm_gic.c: Use NVIC instead of LEGACY_INCLUDED_GIC define

2012-04-04 Thread Peter Maydell
Now all the A profile cores have been switched to use the standalone sysbus GIC, the only remaining code which #includes arm_gic.c is the v7M NVIC. The coupling is much closer here so it's not so easily disentangled. For now, add a comment about how arm_gic.c is compiled, and assume that the NVIC a

Re: [Qemu-devel] [PATCH v2 0/4] QOM'ify S/390 CPU

2012-04-04 Thread Andreas Färber
Am 03.04.2012 14:38, schrieb Christian Borntraeger: > On 02/04/12 19:09, Andreas Färber wrote: >> Hello, >> >> This series breaks down my S/390 QOM'ification patch from the >> qom-cpu-others.v1 >> RFC series into better digestable pieces and reorders it next. >> s390x ignores any user-specified -c

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Paolo Bonzini
Il 04/04/2012 18:05, Jan Kiszka ha scritto: >> > Perhaps you can take the relevant patches out of the thread-blocks >> > branch at git://github.com/pbonzini/qemu.git? The iothread eventfd >> > could also use an EventNotifier. > Yep, this screams for something like QemuEvent which pleases all users

[Qemu-devel] automatic exit on memory errors

2012-04-04 Thread Frediano Ziglio
Hi, I just realized that on any out of memory conditions Qemu exit with an error. I found this thread on g_malloc http://comments.gmane.org/gmane.comp.emulators.qemu/128863 but nothing related to the exit conditions. I know that out of memory conditions is quite hard to handle but if some

Re: [Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention

2012-04-04 Thread Eduardo Habkost
On Wed, Apr 04, 2012 at 05:25:14PM +0200, Paolo Bonzini wrote: > Il 30/03/2012 19:33, Eduardo Habkost ha scritto: > > Autoconf uses --datadir for the /usr/share directory, not the > > program-specific subdirectory inside /usr/share. This changes configure > > to match autoconf behavior. > > > > No

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Maksim Kozlov
04.04.2012 16:35, Dmitry Zhurikhin пишет: On 2012-04-04 15:55, Maksim Kozlov wrote: 04.04.2012 14:08, Dmitry Zhurikhin пишет: Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry Zhurikhin --- hw/exynos4210_pmu.c | 11 +++ 1 files changed, 11 insertions(+

Re: [Qemu-devel] [PATCH V3 0/7] Make QED with live migration safe

2012-04-04 Thread Benoît Canet
> > > > I tested qed live migration as well as confirming that bs->open_flags > BDRV_O_INCOMING works correctly in gdb. > > Reviewed-by: Stefan Hajnoczi > ping. Kevin Wolf: will it be merged in your next for-anthony branch ?

Re: [Qemu-devel] [PATCH 2/3] pseries: Fix bug with reset of VIO CRQs

2012-04-04 Thread Andreas Färber
Am 28.03.2012 23:39, schrieb David Gibson: > PAPR specifies a Command Response Queue (CRQ) mechanism used for virtual > IO, which we implement. However, we don't correctly clean up registered > CRQs when we reset the system. > > This patch adds a reset handler to fix this bug. While we're at it,

Re: [Qemu-devel] [PATCH 14/14] configure: add --confsuffix option

2012-04-04 Thread Eduardo Habkost
On Wed, Apr 04, 2012 at 05:26:10PM +0200, Paolo Bonzini wrote: > Il 30/03/2012 19:33, Eduardo Habkost ha scritto: [...] > > -echo " --sysconfdir=PATHinstall config in PATH/qemu" > > +echo " --sysconfdir=PATHinstall config in PATH$confsuffix" > > +echo " --with-confsuffix=SUFFIX

Re: [Qemu-devel] [Xen-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386

2012-04-04 Thread Peter Maydell
On 4 April 2012 16:40, Peter Maydell wrote: > Having looked at configure I'm pretty sure what we want here is >  QEMU_CFLAGS="-march=i486 $QEMU_CFLAGS" > > because we're only doing this for the benefit of a particular bit > of code in hw/vhost.c and so QEMU_CFLAGS is sufficient. Also this > brings

Re: [Qemu-devel] [PATCH 14/14] configure: add --confsuffix option

2012-04-04 Thread Paolo Bonzini
Il 30/03/2012 19:33, Eduardo Habkost ha scritto: > This will allow the user to make Qemu use a different subdirectory name > inside $datadir and $sysconfdir, instead of "/qemu". > > Signed-off-by: Eduardo Habkost > --- > configure |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions

Re: [Qemu-devel] [PATCH 0/5] Spread the use of QEMU threading & locking API

2012-04-04 Thread Jan Kiszka
On 2012-04-04 17:29, Paolo Bonzini wrote: > Il 04/04/2012 17:24, Jan Kiszka ha scritto: For patches 3 and 4, I'd rather use an EventNotifier... >> ...which still lacks support for non-eventfd systems. Hmm, I guess it's >> time to consolidate both. > > Perhaps you can take the relevant patches

  1   2   >