Re: [Qemu-devel] [Spice-devel] seamless migration with spice

2012-03-12 Thread Yonit Halperin
Hi, On 03/13/2012 08:40 AM, Gerd Hoffmann wrote: On 03/12/12 19:45, Yonit Halperin wrote: Hi, On 03/12/2012 03:50 PM, Gerd Hoffmann wrote: Hi, Can you explain/exemplify, why sending data as a blob (either by (a) or (b)), that is verified only by the two ends that actually use it, is a pro

Re: [Qemu-devel] [PULL] Update seabios to 1.6.3.2

2012-03-12 Thread Gerd Hoffmann
Hi, > How extensively did you test the new seabios changes and are you able to > recreate? Given the small number of changes just a quick smoke test (boot linux guest). > gcc version 4.6.1 (Ubuntu/Linaro 4.6.1-9ubuntu3) gcc (GCC) 4.4.6 20110731 (Red Hat 4.4.6-3) GNU ld version 2.20.51.0.2-5.2

[Qemu-devel] [Bug 953754] [NEW] one of the two assigned NICs doesn’t work in SMP guest.

2012-03-12 Thread Yongjie Ren
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows): Linux(RHEL6u1) kvm.git Commit:186195928e8149b27cdd603a660dace454969f2b qemu-kvm Commit: 81bdec908fb2be0ccaff1d4ee67956c509e440ad Host Kernel Version:3.3.0-

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-12 Thread Wen Congyang
At 03/12/2012 06:33 PM, Avi Kivity Wrote: > On 03/12/2012 11:04 AM, Wen Congyang wrote: >> Do you have any other comments about this patch? >> > > Not really, but I'm not 100% convinced the patch is worthwhile. It's > likely to only be used by Linux, which has kexec facilities, and you can > put

Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events

2012-03-12 Thread Gerd Hoffmann
On 03/12/12 16:50, Alon Levy wrote: > On Mon, Mar 12, 2012 at 01:43:11PM +0200, Alon Levy wrote: >> On Mon, Mar 12, 2012 at 11:20:55AM +0100, Gerd Hoffmann wrote: >>> On 03/11/12 20:26, Alon Levy wrote: dprint is still used for qxl_init_common one time prints. >>> >>> I think we shouldn't simp

Re: [Qemu-devel] [Spice-devel] seamless migration with spice

2012-03-12 Thread Gerd Hoffmann
On 03/12/12 19:45, Yonit Halperin wrote: > Hi, > On 03/12/2012 03:50 PM, Gerd Hoffmann wrote: >>Hi, >> >>> Can you explain/exemplify, why sending data as a blob (either by (a) or >>> (b)), that is verified only by the two ends that actually use it, is a >>> problem? >> >> It tends to be not ver

Re: [Qemu-devel] [PATCH/RFC 3/7] Close socket when closing QEMUFile

2012-03-12 Thread Igor Mitsyanko
On 03/12/2012 05:11 PM, Marc-André Lureau wrote: --- migration-tcp.c |9 + migration-unix.c |9 + savevm.c |1 + 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index f567898..056867c 100644 --- a/migratio

[Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-12 Thread Amos Kong
VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(), but we don't check this bit in vmstate_save_state(). Signed-off-by: Amos Kong --- savevm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/save

Re: [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io

2012-03-12 Thread David Gibson
On Fri, Mar 09, 2012 at 11:01:16AM +0100, Paolo Bonzini wrote: > Il 09/03/2012 06:01, David Gibson ha scritto: > > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > > determine the direction of DMA it is emulating. We already have a > > DMADirection enum designed specifically to enco

[Qemu-devel] Find out the code line in QEMU to trap all DDR memory access

2012-03-12 Thread 周春华
Dear all, I got a job that should log the memory access. Fist, I should find out the code line in QEMU to trap all DDR memory access. It will take my a lot of time by myself, and I am pressed for time. So, if you know the location of the code lines or related messages, please tell me. Thank you fo

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Super Bisquit
Is there a core group/committee that handles all fixes, code, and what not? On 3/12/12, Alexander Graf wrote: > > > Am 13.03.2012 um 02:01 schrieb Andreas Färber : > >> Am 13.03.2012 01:16, schrieb Anthony Liguori: >>> On 03/12/2012 06:32 PM, Andreas Färber wrote: Take Blue's recent target

[Qemu-devel] [PATCH 6/6] Use linked lists in pmm.c and stack.c

2012-03-12 Thread Alexey Korolev
This patch simplifies a bit complicated code in pmm.c and stack.c Signed-off-by: Alexey Korolev --- src/pmm.c| 29 + src/stacks.c |8 ++-- 2 files changed, 11 insertions(+), 26 deletions(-) diff --git a/src/pmm.c b/src/pmm.c index c649fd8..996981c 10064

Re: [Qemu-devel] [PATCH 10/13] iommu: Introduce IOMMU emulation infrastructure

2012-03-12 Thread David Gibson
On Fri, Mar 09, 2012 at 11:23:01AM +0100, Paolo Bonzini wrote: > Il 09/03/2012 06:01, David Gibson ha scritto: > > This patch adds the basic infrastructure necessary to emulate an IOMMU > > visible to the guest. The DMAContext structure is extended with > > information and a callback describing th

[Qemu-devel] [PATCH 5/6] Get rid of size element of pci_bus->r structure

2012-03-12 Thread Alexey Korolev
The size element of pci_bus->r structure is no longer need as the information about bridge region size is stored in pci_region_entry structure. Signed-off-by: Alexey Korolev --- src/pciinit.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/pciini

[Qemu-devel] [PATCH 4/6] Delete array based resource assignment code.

2012-03-12 Thread Alexey Korolev
This patch deletes array based code need for resource assignment. The patches 3 and 4 are split just for better readability. Signed-off-by: Alexey Korolev --- src/pciinit.c | 109 + 1 files changed, 1 insertions(+), 108 deletions(-) diff

[Qemu-devel] [PATCH 3/6] Switch from array based approach to lists of pci_region_entries

2012-03-12 Thread Alexey Korolev
Now we use the list of pci_region_entries instead of arrays of bases. In this patch in addition to dumping resource allocations using pci_region_entry, we add actual PCI resource assignment. Note: I commented old code and split patches 3/6 and 4/6 just for better patch readability. Signed-off-by

[Qemu-devel] [PATCH 2/6] Redesign of pciinit.c (take 2)

2012-03-12 Thread Alexey Korolev
Added pci_region_entry structure and list operations to pciinit.c List is filled with entries during pci_check_devices. List is used just for printing space allocation if we were using lists. Next step will resource allocation using mapping functions. Signed-off-by: Alexey Korolev --- src/pciin

[Qemu-devel] [PATCH 1/6] Add Linked list operations to util.h

2012-03-12 Thread Alexey Korolev
This linked list implementation is partially based on kernel code. So it should be quite stable :) Signed-off-by: Alexey Korolev --- src/util.h | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/src/util.h b/src/util.h index 70d3c4c..d1002a9

[Qemu-devel] [PATCH 0/6] Redesign of pciinit.c (take 2)

2012-03-12 Thread Alexey Korolev
Hi, This patch series redesigns the existing pciinit.c code and introduces linked list operations. Changes are more about structures definitions rather than functionality. There are no more arrays of bases and counts in new implementation. The new implementation is based on dynamic allocation of p

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-12 Thread Benjamin Herrenschmidt
On Fri, 2012-03-09 at 13:46 +0100, Gerd Hoffmann wrote: > On 03/08/12 01:41, David Gibson wrote: > > From: Benjamin Herrenschmidt > > > -assert(s->csw.sig == 0x53425355); > > +assert(s->csw.sig == cpu_to_le32(0x53425355)); > > Correct but incomplete. residue is sent in host endian inste

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: Configure PCI bridge using properties

2012-03-12 Thread David Gibson
On Sat, Mar 10, 2012 at 11:40:41PM +0100, Alexander Graf wrote: > > On 08.03.2012, at 02:12, David Gibson wrote: > > > Currently, the function spapr_create_phb() uses its parameters to > > initialize the correct memory windows for the new PCI Host Bridge > > (PHB). This is not the way things are

[Qemu-devel] virtio balloon PCI class code

2012-03-12 Thread David Gibson
Currently the virtio-pci driver advertises the virtio balloon device as having the PCI class code PCI_CLASS_MEMORY_RAM. Although the balloon device is vaguely related to RAM management, it doesn't operate anything like a PCI memory device in the sense of the class code (in fact it's all about taki

Re: [Qemu-devel] 回??: [PATCH 00/21][RFC] postcopy live?migration

2012-03-12 Thread Isaku Yamahata
I fixed several issues locally, and am planning to post v2 of the patches soon. On Mon, Mar 12, 2012 at 04:36:53PM +0800, thfbjyddx wrote: > Hi > Thank you for your repley! > I've tried with -machine accel:tcg and I got this below: > > src node: > [cid] > > des node: > [cid] > and sometimes th

Re: [Qemu-devel] [PULL 00/20] Block patches

2012-03-12 Thread Anthony Liguori
On 03/12/2012 10:19 AM, Kevin Wolf wrote: The following changes since commit a348f108842fb928563865c9918642900cd0d477: Add missing const attributes for MemoryRegionOps (2012-03-11 11:40:15 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Alex Bar

Re: [Qemu-devel] [PULL 0/7] Tracing patches

2012-03-12 Thread Anthony Liguori
On 03/12/2012 07:37 AM, Stefan Hajnoczi wrote: First round of tracing patches. I should have sent these out a long time ago. Once these are out of the way I can review and handle bigger patches from Lluís and Harsh. The following changes since commit a348f108842fb928563865c9918642900cd0d477:

Re: [Qemu-devel] [PULL] Removal of cpu_register_io_memory

2012-03-12 Thread Anthony Liguori
On 03/12/2012 09:08 AM, Avi Kivity wrote: The memory core now has double indirection during dma or kvm I/O dispatch: first we lookup a MemoryRegionSection from the memory page table, then we look up the ram_addr to dispatch the I/O operation. This patchset eliminates the second lookup. To do th

Re: [Qemu-devel] [PULL 0/3]: QMP queue

2012-03-12 Thread Anthony Liguori
On 03/09/2012 02:55 PM, Luiz Capitulino wrote: A few small fixes from Alon. The changes (since dac6b1b22cbad29ca34735a1e56c9feb9586e3c0) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Alon Levy (3): qjson.h: include compiler.h for GCC_FM

Re: [Qemu-devel] [PULL] qemu-ga patch queue

2012-03-12 Thread Anthony Liguori
On 03/12/2012 03:16 PM, Michael Roth wrote: The following changes since commit a348f108842fb928563865c9918642900cd0d477: Add missing const attributes for MemoryRegionOps (2012-03-11 11:40:15 +) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-3-12-2012

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 09:04 PM, Alexander Graf wrote: Am 13.03.2012 um 02:39 schrieb Anthony Liguori: On 03/12/2012 08:23 PM, Alexander Graf wrote: Let's take a real world example from Linux here. 3.3-rc5 had a pretty nasty compile bug that made the build break on any 32 bit target when autofs wa

Re: [Qemu-devel] KVM call agenda for Tuesday 13

2012-03-12 Thread Anthony Liguori
On 03/12/2012 07:22 PM, Andreas Färber wrote: Am 12.03.2012 13:40, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. * QEMU 1.1 roadmap If we're still aiming for a release in early May that would mean a feature freeze in about four weeks. Soft freeze. H

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Alexander Graf
Am 13.03.2012 um 02:39 schrieb Anthony Liguori : > On 03/12/2012 08:23 PM, Alexander Graf wrote: >> >> >> Let's take a real world example from Linux here. 3.3-rc5 had a pretty nasty >> compile bug that made the build break on any 32 bit target when autofs was >> activated. I posted the bug p

Re: [Qemu-devel] [PATCH] initialize CPU model list after handling -readconfig options

2012-03-12 Thread Anthony Liguori
On 03/09/2012 01:19 PM, Eduardo Habkost wrote: To properly load cpudefs using -readconfig, we have to call cpudef_init() after finishing the command-line option handling. Consequently, the handling of "-cpu ?" has to be done after the command-line option handling loop, too. Without this patch,

Re: [Qemu-devel] [PATCH] implement vnc_dpy_setdata

2012-03-12 Thread Anthony Liguori
On 03/08/2012 04:19 AM, Gerd Hoffmann wrote: The comment is wrong, we have to do something in the setdata callback. Changing the framebuffer backing storage (happens when the guest pans the display) renders the whole screen content invalid. Trigger #1: cirrus vga + 32bit linux guest + vesafb wit

Re: [Qemu-devel] [PATCH] cpu-all.h: Don't accidentally sign extend in g2h()

2012-03-12 Thread Anthony Liguori
On 03/09/2012 08:33 AM, Peter Maydell wrote: Cast the argument of the g2h() macro to a target_ulong so that it isn't accidentally sign-extended if it is a signed 32 bit type and long is a 64 bit type. In particular, this fixes a bug where it would return the wrong value for 32 bit guests on 64 bi

Re: [Qemu-devel] [PATCH 0/3] Add new CPU models (v2)

2012-03-12 Thread Anthony Liguori
On 03/06/2012 12:11 PM, Eduardo Habkost wrote: This series add two new CPU models to Qemu: Intel SandyBridge and AMD Opteron_G4 (Bulldozer). Applied. Thanks. Regards, Anthony Liguori Changes v1 -> v2: Fixed the Opteron_G4 model to actually have the ffxsr bit disabled, as documented

Re: [Qemu-devel] [PATCH 0/2] Two small QOM fixes

2012-03-12 Thread Anthony Liguori
On 02/28/2012 02:54 AM, Paolo Bonzini wrote: Two fixes for bugs that were reported on the list. Applied. Thanks. Regards, Anthony Liguori Paolo Bonzini (2): qdev: accept empty string properties qom: fix device hot-unplug hw/qdev-properties.c |4 qom/object.c |

Re: [Qemu-devel] [PATCH 7/7] block: add the support to drain throttled requests

2012-03-12 Thread Zhi Yong Wu
On Tue, Mar 13, 2012 at 2:22 AM, Paolo Bonzini wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > [ Iterate until all block devices have processed all requests, >  add comments. - Paolo ] > Signed-off-by: Paolo Bonzini > --- >  block.c |   21 - >  1 files changed, 2

[Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-12 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu [ Iterate until all block devices have processed all requests, add comments. - Paolo ] Signed-off-by: Paolo Bonzini --- block.c | 24 ++-- 1 files changed, 22 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index

Re: [Qemu-devel] [PATCH 7/7] block: add the support to drain throttled requests

2012-03-12 Thread Zhi Yong Wu
On Tue, Mar 13, 2012 at 2:22 AM, Paolo Bonzini wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > [ Iterate until all block devices have processed all requests, >  add comments. - Paolo ] > Signed-off-by: Paolo Bonzini > --- >  block.c |   21 - >  1 files changed, 2

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 08:23 PM, Alexander Graf wrote: Let's take a real world example from Linux here. 3.3-rc5 had a pretty nasty compile bug that made the build break on any 32 bit target when autofs was activated. I posted the bug plus a small bugfix upstream. We have a different model than Linux

Re: [Qemu-devel] [PATCH 7/7] block: add the support to drain throttled requests

2012-03-12 Thread Zhi Yong Wu
On Tue, Mar 13, 2012 at 2:22 AM, Paolo Bonzini wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > [ Iterate until all block devices have processed all requests, >  add comments. - Paolo ] > Signed-off-by: Paolo Bonzini > --- >  block.c |   21 - >  1 files changed, 2

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Alexander Graf
Am 13.03.2012 um 02:01 schrieb Andreas Färber : > Am 13.03.2012 01:16, schrieb Anthony Liguori: >> On 03/12/2012 06:32 PM, Andreas Färber wrote: >>> Take Blue's recent target-ppc fix >>> 9d4df9c02866f39d3eef105033091f367cc7c29e for example: After applying >>> patches on day one of FOSDEM he post

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Andreas Färber
Am 13.03.2012 01:16, schrieb Anthony Liguori: > On 03/12/2012 06:32 PM, Andreas Färber wrote: >> Take Blue's recent target-ppc fix >> 9d4df9c02866f39d3eef105033091f367cc7c29e for example: After applying >> patches on day one of FOSDEM he posted a -Werror fix, it got confirmed >> by me and Alex but

Re: [Qemu-devel] tracking qemu-devel at patchwork.ozlabs.org

2012-03-12 Thread Jeremy Kerr
Hi Michael, We'd like to add Peter Maydell as an additional patchwork admin. Could you do this please? Sure thing, all done. Cheers, Jeremy

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Alexander Graf
Am 13.03.2012 um 01:16 schrieb Anthony Liguori : > On 03/12/2012 06:32 PM, Andreas Färber wrote: >> Am 12.03.2012 22:18, schrieb Anthony Liguori: >>> On 03/12/2012 04:12 PM, Stefan Weil wrote: Am 12.03.2012 21:27, schrieb Anthony Liguori: > On 03/12/2012 03:12 PM, Stefan Weil wrote: >>>

Re: [Qemu-devel] KVM call agenda for Tuesday 13

2012-03-12 Thread Andreas Färber
Am 12.03.2012 13:40, schrieb Juan Quintela: > Please send in any agenda items you are interested in covering. * QEMU 1.1 roadmap If we're still aiming for a release in early May that would mean a feature freeze in about four weeks. http://wiki.qemu.org/Planning/1.1 My stake is that I'd like to

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 06:32 PM, Andreas Färber wrote: Am 12.03.2012 22:18, schrieb Anthony Liguori: On 03/12/2012 04:12 PM, Stefan Weil wrote: Am 12.03.2012 21:27, schrieb Anthony Liguori: On 03/12/2012 03:12 PM, Stefan Weil wrote: [...] There a many examples of urgent patches (= patches which fix br

Re: [Qemu-devel] [PULL] Update seabios to 1.6.3.2

2012-03-12 Thread Kevin O'Connor
On Mon, Mar 12, 2012 at 11:25:07AM -0500, Anthony Liguori wrote: > On 03/12/2012 09:48 AM, Andreas Färber wrote: > >Hi Gerd, > > > >Am 12.03.2012 14:08, schrieb Gerd Hoffmann: > >>New seabios release on the 1.6.3 stable branch -- lets update. > >>Also add a Makefile + script to simplify seabios upd

Re: [Qemu-devel] [PATCH v2 2/4] docs: add build infrastructure for gtkdocs (v2)

2012-03-12 Thread Andreas Färber
Am 12.03.2012 21:48, schrieb Eduardo Habkost: > > I don't know if this is really the latest version of the series, but I don't > see any newer version on my qemu-devel folder, so: FWIW I have a rebased version on my qom-cpu-wip branch (no functional changes). Note that mine depends on the qom-use

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Andreas Färber
Am 12.03.2012 22:18, schrieb Anthony Liguori: > On 03/12/2012 04:12 PM, Stefan Weil wrote: >> Am 12.03.2012 21:27, schrieb Anthony Liguori: >>> On 03/12/2012 03:12 PM, Stefan Weil wrote: [...] There a many examples of urgent patches (= patches which fix broken builds) which take seve

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread Marc-André Lureau
On Mon, Mar 12, 2012 at 11:52 PM, malc wrote: > 1 << 32 = 1.0 in 64(32.32) fixed point... the type of l/r is int64_t Ok, I'll leave it as is then if it is on purpose. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 10:42 PM, malc wrote: > > nominal_volume.[lr] is int64_t... i don't get where you take this ^32 > > from. > > from where it is defined, audio/audio.c: > > const struct mixeng_volume nominal_volume = { > .mute = 0, > #if

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Anthony Liguori wrote: > On 03/12/2012 04:43 PM, malc wrote: > > On Mon, 12 Mar 2012, Anthony Liguori wrote: > > > Patch came on a Thursday and was applied on a Saturday. That's pretty > > > much > > > one business day. > > > > > > For a problem that affects very few people

[Qemu-devel] [PATCH 2/2] intel-iommu: Basic isolation group provider support

2012-03-12 Thread Alex Williamson
Signed-off-by: Alex Williamson --- drivers/iommu/intel-iommu.c | 70 +++ 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index c9c6053..2e5a709 100644 --- a/drivers/iommu/intel-iom

[Qemu-devel] [PATCH 1/2] Isolation groups

2012-03-12 Thread Alex Williamson
Signed-off-by: Alex Williamson --- drivers/base/Kconfig | 10 + drivers/base/Makefile |1 drivers/base/base.h |5 drivers/base/isolation.c | 798 + include/linux/device.h|4 include/linux/isolation.h | 138 +++

[Qemu-devel] [PATCH 0/2] RFC Isolation API

2012-03-12 Thread Alex Williamson
VFIO is completely stalled waiting on a poorly defined device isolation infrastructure to take shape. Rather than waiting any longer, I've decided to write my own. This is nowhere near ready for upstream, but attempts to hash out some of the interactions of isolation groups. To recap, an isolati

Re: [Qemu-devel] [PATCH 1/4] kvm: Comparison with ioctl number macros needs to be unsigned

2012-03-12 Thread Alexander Graf
On 08.03.2012, at 01:41, David Gibson wrote: > In kvm-all.c we store an ioctl cmd number in the irqchip_inject_ioctl field > of KVMState, which has type 'int'. This seems to make sense since the > ioctl() man page says that the cmd parameter has type int. > > However, the kernel treats ioctl nu

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 04:41 PM, Stefan Weil wrote: Am 12.03.2012 22:13, schrieb Anthony Liguori: On 03/12/2012 04:09 PM, malc wrote: On Mon, 12 Mar 2012, Anthony Liguori wrote: On 03/12/2012 03:43 PM, Peter Maydell wrote: On 12 March 2012 20:29, Anthony Liguori wrote: On 03/12/2012 03:24 PM, Peter

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 04:43 PM, malc wrote: On Mon, 12 Mar 2012, Anthony Liguori wrote: Patch came on a Thursday and was applied on a Saturday. That's pretty much one business day. For a problem that affects very few people (and hence has very few people complaining), it seems like a reasonable respon

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread Marc-André Lureau
On Mon, Mar 12, 2012 at 10:42 PM, malc wrote: > nominal_volume.[lr] is int64_t... i don't get where you take this ^32 > from. from where it is defined, audio/audio.c: const struct mixeng_volume nominal_volume = { .mute = 0, #ifdef FLOAT_MIXENG .r = 1.0, .l = 1.0, #else .r = 1ULL

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Anthony Liguori wrote: > On 03/12/2012 04:09 PM, malc wrote: > > On Mon, 12 Mar 2012, Anthony Liguori wrote: > > > > > On 03/12/2012 03:43 PM, Peter Maydell wrote: > > > > On 12 March 2012 20:29, Anthony Liguori wrote: > > > > > On 03/12/2012 03:24 PM, Peter Maydell wrote:

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 10:11 PM, malc wrote: > >> AUD_set_volume_out (SWVoiceOut *sw, int mute, uint8_t lvol..) > >> > >> sw->vol.l = nominal_volume.l * lvol / 255; > >> > >> So the range was [0..2^8-1] and then it becomes [0..2^32], which looks >

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Stefan Weil
Am 12.03.2012 22:13, schrieb Anthony Liguori: On 03/12/2012 04:09 PM, malc wrote: On Mon, 12 Mar 2012, Anthony Liguori wrote: On 03/12/2012 03:43 PM, Peter Maydell wrote: On 12 March 2012 20:29, Anthony Liguori wrote: On 03/12/2012 03:24 PM, Peter Maydell wrote: I agree that that's a spec

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread Marc-André Lureau
On Mon, Mar 12, 2012 at 10:11 PM, malc wrote: >> AUD_set_volume_out (SWVoiceOut *sw, int mute, uint8_t lvol..) >> >> sw->vol.l = nominal_volume.l * lvol / 255; >> >> So the range was [0..2^8-1] and then it becomes [0..2^32], which looks >> wrong to me. > > It actually becomes [-2^63..2^63-1] nomin

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Stefan Weil
Am 12.03.2012 21:27, schrieb Anthony Liguori: On 03/12/2012 03:12 PM, Stefan Weil wrote: We also need more resources for technical maintenance of the QEMU infrastructure. For example, the official mirror of the QEMU git repository (https://github.com/qemu/QEMU) is several months behind, http://

Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format

2012-03-12 Thread Michael Roth
On Mon, Mar 12, 2012 at 01:57:14PM -0500, Anthony Liguori wrote: > On 03/12/2012 01:56 PM, Marc-André Lureau wrote: > >On Mon, Mar 12, 2012 at 7:53 PM, Anthony Liguori > >wrote: > >>Why not just return the screendump through QMP? > > > >in base64, base85? > > I think Jan had patches for base64 b

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 04:16 PM, Peter Maydell wrote: On 12 March 2012 21:06, Anthony Liguori wrote: In all fairness, the last build breakage I see was specific to win32, was reported on Mar 1st, and a patch was committed on Mar 3rd. Commit 02021812452 (patch reported March 2nd, applied March 9th) is

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 04:12 PM, Stefan Weil wrote: Am 12.03.2012 21:27, schrieb Anthony Liguori: On 03/12/2012 03:12 PM, Stefan Weil wrote: Am 12.03.2012 18:06, schrieb Stefano Stabellini: Hi all, I don't mean to steer any controversy or start any flame wars here, but rather I want to point out a prob

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Peter Maydell
On 12 March 2012 21:06, Anthony Liguori wrote: > In all fairness, the last build breakage I see was specific to win32, was > reported on Mar 1st, and a patch was committed on Mar 3rd. Commit 02021812452 (patch reported March 2nd, applied March 9th) is more recent than that. I think a couple of d

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 04:09 PM, malc wrote: On Mon, 12 Mar 2012, Anthony Liguori wrote: On 03/12/2012 03:43 PM, Peter Maydell wrote: On 12 March 2012 20:29, Anthony Liguori wrote: On 03/12/2012 03:24 PM, Peter Maydell wrote: I agree that that's a specific area it would be nice to do better in. It

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 10:00 PM, malc wrote: > > I really do not understand your point at all, mixeng_volume fields > > are int64_t's it's irrelevant what you initialize them with, they > > are still 64bit integers, and UINT_MAX as i already said i

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Stefan Weil
Am 12.03.2012 21:27, schrieb Anthony Liguori: On 03/12/2012 03:12 PM, Stefan Weil wrote: Am 12.03.2012 18:06, schrieb Stefano Stabellini: Hi all, I don't mean to steer any controversy or start any flame wars here, but rather I want to point out a problem in the QEMU Community that is preventing

[Qemu-devel] [PATCH 2/7] qemu-ga: add guest-suspend-ram

2012-03-12 Thread Michael Roth
From: Luiz Capitulino Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- qapi-schema-guest.json | 28 qga/commands-posix.c | 10 ++ qga/commands-win32.c |5 + 3 files changed, 43 insertions(+), 0 deletions(-) diff --git a/qapi-s

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Anthony Liguori wrote: > On 03/12/2012 03:43 PM, Peter Maydell wrote: > > On 12 March 2012 20:29, Anthony Liguori wrote: > > > On 03/12/2012 03:24 PM, Peter Maydell wrote: > > > > I agree that that's a specific area it would be nice to do > > > > better in. It seems to me tha

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread Marc-André Lureau
On Mon, Mar 12, 2012 at 10:00 PM, malc wrote: > I really do not understand your point at all, mixeng_volume fields > are int64_t's it's irrelevant what you initialize them with, they > are still 64bit integers, and UINT_MAX as i already said is not even > correct, it's 1/(2**32-1) less than one in

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 03:43 PM, Peter Maydell wrote: On 12 March 2012 20:29, Anthony Liguori wrote: On 03/12/2012 03:24 PM, Peter Maydell wrote: I agree that that's a specific area it would be nice to do better in. It seems to me that the qemu-trivial process for sweeping up trivial patches has been w

Re: [Qemu-devel] [PATCH v2 0/4] GTK-DOC build integration (v2)

2012-03-12 Thread Lluís Vilanova
Anthony Liguori writes: [...] > For v2, I'm relying on a fork of gtk-doc that removes the underscore > requirements. I really hate to do this but I like it better than not having > documentation. I'm poking in the gtk+ community to see if there's an upstream > compromise possible. I don't want t

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 9:51 PM, malc wrote: > >> > >> > b. Other drivers are not affected > >> > >> I don't see yet how, but I will review other drivers ctl_{in,out} > >> implementations > > > > You don't see how they can be affected or you don't s

[Qemu-devel] [PATCH 4/7] qemu-ga: add win32 guest-suspend-disk command.

2012-03-12 Thread Michael Roth
From: Gal Hammer Implement guest-suspend-disk RPC for Windows. Functionally this should be equivalent to the posix implementation. Signed-off-by: Gal Hammer Signed-off-by: Michael Roth --- configure|2 +- qga/commands-win32.c | 132

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 9:29 PM, malc wrote: > >> So what I meant is rather G_MAXUINT32. > > > > Just leave it as is, it's perfectly fine. > > But it's not convenient to fit into a regular integer, as the number > of steps is 2^32 + 1. Why is it pr

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-12 Thread Marc-André Lureau
On Mon, Mar 12, 2012 at 9:51 PM, malc wrote: >> >> > b. Other drivers are not affected >> >> I don't see yet how, but I will review other drivers ctl_{in,out} >> implementations > > You don't see how they can be affected or you don't see how you can > figure that out? I don't see how they can be

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > Hi Vassili > > Thanks for your review! > > On Mon, Mar 12, 2012 at 8:44 PM, malc wrote: > > a. Pulse/Spice have per connection volume > > Each playback/recorde stream has it's own volume, and that's what we > control. We get the client full range

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread Marc-André Lureau
On Mon, Mar 12, 2012 at 9:29 PM, malc wrote: >> So what I meant is rather G_MAXUINT32. > > Just leave it as is, it's perfectly fine. But it's not convenient to fit into a regular integer, as the number of steps is 2^32 + 1. Why is it preferrable this way rather than a MAXUINT? I must be missing s

Re: [Qemu-devel] [PATCH v2 2/4] docs: add build infrastructure for gtkdocs (v2)

2012-03-12 Thread Eduardo Habkost
I don't know if this is really the latest version of the series, but I don't see any newer version on my qemu-devel folder, so: On Wed, Dec 14, 2011 at 02:01:12PM -0600, Anthony Liguori wrote: [...] > +html/index.html: $(DOC_SRC) > + $(GTKDOC_SCAN) --module=QEMU --source-dir=$(SRC_PATH)/inclu

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Peter Maydell
On 12 March 2012 20:29, Anthony Liguori wrote: > On 03/12/2012 03:24 PM, Peter Maydell wrote: >> I agree that that's a specific area it would be nice to do >> better in. It seems to me that the qemu-trivial process for >> sweeping up trivial patches has been working well; maybe we >> could use a s

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Michael S. Tsirkin
On Mon, Mar 12, 2012 at 08:24:47PM +, Peter Maydell wrote: > > Only two maintainers are allowed to make full use of the patchwork > > (http://patchwork.ozlabs.org/project/qemu-devel/) infrastructure. > > Why not all maintainers? > > I tried to get myself added to the maintainers list (with > a

Re: [Qemu-devel] tracking qemu-devel at patchwork.ozlabs.org

2012-03-12 Thread Michael S. Tsirkin
On Wed, Jul 29, 2009 at 09:08:08PM +1000, Jeremy Kerr wrote: > Hi Michael, > > > What would it take to track patches sent to qemu-devel mailing list > > at patchwork.ozlabs.org? > > Sure! Happy to set this up. I'll need the following: > > * The List-Id header for messages from this list (if you

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-12 Thread Marc-André Lureau
Hi Vassili Thanks for your review! On Mon, Mar 12, 2012 at 8:44 PM, malc wrote: > a. Pulse/Spice have per connection volume Each playback/recorde stream has it's own volume, and that's what we control. We get the client full range thanks to flat-volume logic (implemented by PulseAudio and Windo

[Qemu-devel] [PULL] qemu-ga patch queue

2012-03-12 Thread Michael Roth
The following changes since commit a348f108842fb928563865c9918642900cd0d477: Add missing const attributes for MemoryRegionOps (2012-03-11 11:40:15 +) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-3-12-2012 Gal Hammer (1): qemu-ga: add win32 guest

[Qemu-devel] [PATCH 6/7] qemu-ga: add guest-network-get-interfaces command

2012-03-12 Thread Michael Roth
From: Michal Privoznik This command returns an array of: [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] for each interface in the system. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik Signed-off-by: Michael Roth --- qapi-schema-guest.json | 59 +

[Qemu-devel] [PATCH 7/7] qemu-ga: add guest-sync-delimited

2012-03-12 Thread Michael Roth
guest-sync leaves it as an exercise to the user as to how to reliably obtain the response to guest-sync if the client had previously read in a partial response (due qemu-ga previously being restarted mid-"sentence" due to reboot, forced restart, etc). qemu-ga handles this situation on its end by h

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 03:24 PM, Peter Maydell wrote: On 12 March 2012 20:12, Stefan Weil wrote: I agree that more maintainers would be good, but we also need more people with commit rights. Why? There a many examples of urgent patches (= patches which fix broken builds) which take several days even whe

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 9:03 PM, malc wrote: > > How's putting UINT_MAX into int64_t more appropriate? UINT_MAX is > > even one less than one in 32.32 fixpoint... I must be missing something > > here. > > Right, the patch series used to have 2^32 -

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Anthony Liguori
On 03/12/2012 03:12 PM, Stefan Weil wrote: Am 12.03.2012 18:06, schrieb Stefano Stabellini: Hi all, I don't mean to steer any controversy or start any flame wars here, but rather I want to point out a problem in the QEMU Community that is preventing us and other people from having a good experie

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread Marc-André Lureau
On Mon, Mar 12, 2012 at 9:03 PM, malc wrote: > How's putting UINT_MAX into int64_t more appropriate? UINT_MAX is > even one less than one in 32.32 fixpoint... I must be missing something > here. Right, the patch series used to have 2^32 -1, so it can fit in a 16bits or 32bits integer. So what I

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread Peter Maydell
On 12 March 2012 20:12, Stefan Weil wrote: > I agree that more maintainers would be good, but we also need > more people with commit rights. Why? There a many examples of > urgent patches (= patches which fix broken builds) which take > several days even when they were reviewed before they finally

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-12 Thread Ayal Baron
- Original Message - > On 03/12/2012 02:12 PM, Itamar Heim wrote: > > On 03/12/2012 09:01 PM, Anthony Liguori wrote: > >> > >> It's a trade off. From a RAS perspective, it's helpful to have > >> information about the host available in the guest. > >> > >> If you're already exposing a comp

[Qemu-devel] [PATCH 3/7] qemu-ga: add guest-suspend-hybrid

2012-03-12 Thread Michael Roth
From: Luiz Capitulino Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- qapi-schema-guest.json | 23 +++ qga/commands-posix.c | 10 ++ qga/commands-win32.c |5 + 3 files changed, 38 insertions(+), 0 deletions(-) diff --git a/qapi-schema

[Qemu-devel] [PATCH 5/7] qemu-ga: add win32 guest-suspend-ram command

2012-03-12 Thread Michael Roth
S3 sleep implementation for windows. Signed-off-by: Michael Roth --- qga/commands-win32.c | 34 +- 1 files changed, 25 insertions(+), 9 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 062e519..b7600ed 100644 --- a/qga/commands-win32.

[Qemu-devel] [PATCH 1/7] qemu-ga: add guest-suspend-disk

2012-03-12 Thread Michael Roth
From: Luiz Capitulino As the command name implies, this command suspends the guest to disk. The suspend operation is implemented by two functions: bios_supports_mode() and guest_suspend(). Both functions are generic enough to be used by other suspend modes (introduced by next commits). Both fun

  1   2   3   4   >