[Qemu-devel] Parameter parsing broken

2012-02-24 Thread Gerhard Wiesinger
Hello, Finally this commmit is no longer working: commit 9ebe95fb606a8d6bebe29de3efc9b506c6428c62 Author: Gerd Hoffmann Date: Wed Feb 8 16:02:11 2012 +0100 nic: zap obsolote romloading bits from ne2k + pcnet These days one just needs to specify the romfile in PCiDeviceInfo and ev

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 11:30 PM, Eric Blake wrote: > On 02/24/2012 12:01 PM, Luiz Capitulino wrote: >> On Fri, 24 Feb 2012 16:49:04 + >> Federico Simoncelli wrote: >> >>> Signed-off-by: Federico Simoncelli >> >> How does this relate to migrate -b? Should it be deprecated? >> >> Btw, would be nice to h

[Qemu-devel] [PATCH] seabios: acpi: Add _STA for PCI hotplug slots

2012-02-24 Thread Alex Williamson
When a Status method is provided on a slot, the OSPM evaluates _STA in response to the device check notify on the slot. This allows some degree of a handshake between the platform and the OSPM that the hotplug has been acknowledged. In order to implement _STA, we need to know which slots have dev

[Qemu-devel] [PATCH] acpi_piix4: Add _STA support and use it to acknowledge hotplug

2012-02-24 Thread Alex Williamson
Our current PCI hotplug model assumes that guests are hotplug capable. Adding a device always works and we can ask for it back with device_del. This isn't always the case. If the guest doesn't support hotplug, adding a device renders the device lost until the guest is shut down. This is particu

Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly

2012-02-24 Thread Andreas Färber
Am 24.02.2012 23:18, schrieb Meador Inge: > Fixing a simple typo, s/errno/err/, that caused > the error status from GDB semihosted system calls > to be returned incorrectly. > > Signed-off-by: Meador Inge Nice catch! Reviewed-by: Andreas Färber Andreas > --- > m68k-semi.c |2 +- > 1 fil

Re: [Qemu-devel] [PATCH 2/3] Allow larger return values from get_image_size()

2012-02-24 Thread David Gibson
On Fri, Feb 24, 2012 at 10:15:51AM +0100, Andreas Färber wrote: > Am 24.02.2012 01:36, schrieb David Gibson: > > Currently get_image_size(), used to find the size of files, returns an int. > > But for modern systems, int may be only 32-bit and we can have files > > larger than that. > > > > This p

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Eric Blake
On 02/24/2012 01:26 PM, Luiz Capitulino wrote: > On Fri, 24 Feb 2012 12:40:17 -0700 > Eric Blake wrote: > >> On 02/24/2012 12:01 PM, Luiz Capitulino wrote: >> +BlockDriver *drv; +int i, j, escape; +char new_filename[2048], *filename; >>> >>> I'd use PATH_MAX for new_fil

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-24 Thread Anthony Liguori
On 02/24/2012 03:22 PM, Alon Levy wrote: This is an across the board change since I wanted to keep the existing (good imo) single graphic_console_init callback setter, instead of introducing a new cb that isn't set by it but instead by a second initialization function. Signed-off-by: Alon Levy

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Eric Blake
On 02/24/2012 12:01 PM, Luiz Capitulino wrote: > On Fri, 24 Feb 2012 16:49:04 + > Federico Simoncelli wrote: > >> Signed-off-by: Federico Simoncelli > > How does this relate to migrate -b? Should it be deprecated? > > Btw, would be nice to have a 0/2 intro email describing the feature and

[Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly

2012-02-24 Thread Meador Inge
Fixing a simple typo, s/errno/err/, that caused the error status from GDB semihosted system calls to be returned incorrectly. Signed-off-by: Meador Inge --- m68k-semi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/m68k-semi.c b/m68k-semi.c index bab01ee..6d60ced 1006

[Qemu-devel] [PATCH v6 6/7] qxl: introduce QXLCookie

2012-02-24 Thread Alon Levy
Will be used in the next patch. Signed-off-by: Alon Levy --- hw/qxl-render.c|2 +- hw/qxl.c | 61 hw/qxl.h |2 +- ui/spice-display.c | 22 -- ui/spice-display.h | 14 5 files c

[Qemu-devel] [PATCH v6 7/7] qxl: make qxl_render_update async

2012-02-24 Thread Alon Levy
RHBZ# 747011 Removes the last user of QXL_SYNC when using update drivers that use the _ASYNC io ports. The last user is qxl_render_update, it is called both by qxl_hw_update which is the vga_hw_update_ptr passed to graphic_console_init, and by qxl_hw_screen_dump. At the same time the QXLRect are

[Qemu-devel] [PATCH v6 5/7] qxl: remove flipped

2012-02-24 Thread Alon Levy
Tested on linux and windows guests. For negative stride, qxl_flip copies directly to vga->ds->surface->data, for positive it's reallocated to share qxl->guest_primary.data Signed-off-by: Alon Levy --- hw/qxl-render.c | 66 +-- hw/qxl.h

[Qemu-devel] [PATCH v6 4/7] qxl: require spice >= 0.8.2

2012-02-24 Thread Alon Levy
drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result, any check for SPICE_SERVER_VERSION that is now always satisfied, and SPICE_INTERFACE_CORE_MINOR >= 3 tests, because 0.8.2 has SPICE_INTERFACE_QXL_MINOR == 1 and SPICE_INTERFACE_CORE_MINOR == 3. Signed-off-by: Alon Levy --- configure

[Qemu-devel] [PATCH v6 2/7] sdl: remove NULL check, g_malloc0 can't fail

2012-02-24 Thread Alon Levy
Signed-off-by: Alon Levy --- ui/sdl.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 6f8091c..f6f711c 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -167,10 +167,6 @@ static PixelFormat sdl_to_qemu_pixelformat(SDL_PixelFormat *sdl_pf) static Displ

[Qemu-devel] [PATCH v6 1/7] qxl: fix spice+sdl no cursor regression

2012-02-24 Thread Alon Levy
regression introduced by 075360945860ad9bdd491921954b383bf762b0e5, v2: lock around qemu_spice_cursor_refresh_unlocked Reported-by: Fabiano Fidêncio Signed-off-by: Alon Levy --- hw/qxl.c |4 ui/spice-display.c | 23 ++- ui/spice-display.h |1 + 3 fil

[Qemu-devel] [PATCH 2/4] qjson.h: include compiler.h for GCC_FMT_ATTR

2012-02-24 Thread Alon Levy
Signed-off-by: Alon Levy --- qjson.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qjson.h b/qjson.h index 65b10ea..1190d8a 100644 --- a/qjson.h +++ b/qjson.h @@ -15,6 +15,7 @@ #define QJSON_H #include +#include "compiler.h" #include "qobject.h" #include "qstring

[Qemu-devel] [PATCH v6 3/7] qxl: drop qxl_spice_update_area_async definition

2012-02-24 Thread Alon Levy
It was never used. Introduced in 5ff4e36c804157bd84af43c139f8cd3a59722db9 qxl: async io support using new spice api But not used even then. Signed-off-by: Alon Levy --- hw/qxl.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index d062991..a615

[Qemu-devel] [PATCH] qxl-render: call ppm_save on bh

2012-02-24 Thread Alon Levy
Uses the newly introduced hw_screen_dump_async. Now that the deadlock with virt-manager is fixed we need to call ppm_save in a bh, with the new command we can notify virt-manager using the SCREEN_DUMP_COMPLETE event. Signed-off-by: Alon Levy --- This goes on top of the QEVENT_SCREEN_DUMP_ASYNC a

[Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-24 Thread Alon Levy
This is an across the board change since I wanted to keep the existing (good imo) single graphic_console_init callback setter, instead of introducing a new cb that isn't set by it but instead by a second initialization function. Signed-off-by: Alon Levy --- console.c| 25 ++

[Qemu-devel] [PATCH 3/4] monitor, console: add QEVENT_SCREEN_DUMP_COMPLETE

2012-02-24 Thread Alon Levy
Signed-off-by: Alon Levy --- QMP/qmp-events.txt | 14 ++ console.c | 18 ++ console.h |1 + monitor.c |2 ++ monitor.h |1 + 5 files changed, 36 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp

[Qemu-devel] [PATCH 1/4] qapi-schema: fix typos and explain 'spice' auth

2012-02-24 Thread Alon Levy
Signed-off-by: Alon Levy --- qapi-schema.json | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index d0b6792..72b17f1 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -616,12 +616,13 @@ # @connection-id: SPICE c

[Qemu-devel] [PATCH v6 0/7] qxl: fix hangs caused by qxl_render_update

2012-02-24 Thread Alon Levy
v5->v6: rebased dropped vga/console patches addressed checkpatch complaints Alon Levy (7): qxl: fix spice+sdl no cursor regression sdl: remove NULL check, g_malloc0 can't fail qxl: drop qxl_spice_update_area_async definition qxl: require spice >= 0.8.2 qxl: remove flipped qxl: intr

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 09:36 PM, Luiz Capitulino wrote: > > > IMO, you could require the filename arguments to be escaped already. > > > > The monitor command was introduced exactly to avoid having to worry > > about details such as escaping. JSON is already supposed to take care > > of those. > > Then t

Re: [Qemu-devel] converting the block layer from coroutines to threads

2012-02-24 Thread Anthony Liguori
On 02/24/2012 02:43 PM, Paolo Bonzini wrote: On 02/24/2012 08:22 PM, Anthony Liguori wrote: Virtio really wants each virtqueue to be processed in a separate thread. On a multicore system, there's considerable improvement doing this. I think that's where we ought to start. Well, that's where

Re: [Qemu-devel] converting the block layer from coroutines to threads

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 08:22 PM, Anthony Liguori wrote: > Virtio really wants each virtqueue to be processed in a separate > thread. On a multicore system, there's considerable improvement doing > this. I think that's where we ought to start. Well, that's where we ought to *get*. Stefan's work is awesom

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 21:32:30 +0100 Paolo Bonzini wrote: > On 02/24/2012 08:01 PM, Luiz Capitulino wrote: > > IMO, you could require the filename arguments to be escaped already. > > The monitor command was introduced exactly to avoid having to worry > about details such as escaping. JSON is alr

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 08:01 PM, Luiz Capitulino wrote: > IMO, you could require the filename arguments to be escaped already. The monitor command was introduced exactly to avoid having to worry about details such as escaping. JSON is already supposed to take care of those. That said, I think Eric is rig

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 12:40:17 -0700 Eric Blake wrote: > On 02/24/2012 12:01 PM, Luiz Capitulino wrote: > > >> +BlockDriver *drv; > >> +int i, j, escape; > >> +char new_filename[2048], *filename; > > > > I'd use PATH_MAX for new_filename's size. > > PATH_MAX need not be defined (and

Re: [Qemu-devel] [PATCH] vl.c: Avoid segfault when started with no arguments

2012-02-24 Thread Anthony Liguori
On 02/22/2012 04:40 PM, Peter Maydell wrote: Fix a bug (introduced in commit a0abe47) where a command line which specified no machine arguments (either explicitly or implicitly via -kernel&co) would result in a segfault because of a NULL pointer returned from qemu_opts_find(qemu_find_opts("machin

[Qemu-devel] [PATCH] virtio-9p-handle: define AT_EMPTY_PATH if needed

2012-02-24 Thread Serge Hallyn
If AT_EMPTY_PATH is not in one of the included files, go ahead and define it. qemu won't compile on ubuntu for me without this. (Note - alternatively we could #include to pick up the definitions there) Signed-off-by: Serge Hallyn --- hw/9pfs/virtio-9p-handle.c |9 + 1 files change

Re: [Qemu-devel] [PATCH v6 00/12] initial suspend support

2012-02-24 Thread Anthony Liguori
On 02/23/2012 06:45 AM, Gerd Hoffmann wrote: Hi, Next round, dropping the wakeup reason from the wakeup qmp event and improving monitor command description in the josn schema. cheers, Gerd The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tool

Re: [Qemu-devel] [PATCH v2] nic: zap obsolote romloading bits from ne2k + pcnet

2012-02-24 Thread Anthony Liguori
On 02/08/2012 09:02 AM, Gerd Hoffmann wrote: These days one just needs to specify the romfile in PCiDeviceInfo and everything magically works. It also allows to disable pxe rom loading via "romfile=" like it is possible for all other nics. [ v2: rebased& adapted to qom changes ] Signed-off-by

Re: [Qemu-devel] [PATCH v2 0/3] screendump fixups

2012-02-24 Thread Anthony Liguori
On 02/24/2012 05:43 AM, Gerd Hoffmann wrote: Hi, Next round, this time covering all screen dump implementations. Applied. THanks. Regards, Anthony Liguori cheers, Gerd Gerd Hoffmann (3): vga: simplify screendump Remove screendump dummy functions. optimize screendump for t

Re: [Qemu-devel] [PATCH] configure: Check whether makecontext() is a glibc stub function

2012-02-24 Thread Anthony Liguori
On 02/23/2012 10:20 AM, Peter Maydell wrote: On some systems (notably ARM Linux) glibc provides implementations of makecontext(), getcontext() and friends which are stubs which always return failure. Make the configure test for makecontext() also check for the presence of the __stub_makecontext m

Re: [Qemu-devel] [PATCH] build: allow turning off debuginfo

2012-02-24 Thread Anthony Liguori
On 02/24/2012 05:16 AM, Peter Maydell wrote: On 24 February 2012 10:39, Gerd Hoffmann wrote: On 02/08/12 13:54, Gerd Hoffmann wrote: This patch adds --{enable,disable}-debug-info switches to configure which allows to include/exclude the '-g' switch on the gcc& ld command lines. Not building

Re: [Qemu-devel] [PATCH v2 0/3] screendump fixups

2012-02-24 Thread Alon Levy
On Fri, Feb 24, 2012 at 12:43:42PM +0100, Gerd Hoffmann wrote: > Hi, > > Next round, this time covering all screen dump implementations. > Reviewed-by: Alon Levy Also compiled-by :) > cheers, > Gerd > > Gerd Hoffmann (3): > vga: simplify screendump > Remove screendump dummy functions

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Eric Blake
On 02/24/2012 12:01 PM, Luiz Capitulino wrote: >> +BlockDriver *drv; >> +int i, j, escape; >> +char new_filename[2048], *filename; > > I'd use PATH_MAX for new_filename's size. PATH_MAX need not be defined (and on Hurd, it intentionally is not defined); or might be so huge as to be u

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Eric Blake
On 02/24/2012 11:57 AM, Paolo Bonzini wrote: > On 02/24/2012 06:46 PM, Eric Blake wrote: >> I think you need to be more explicit that @new-image-file MUST have >> identical contents as the current image file, for this to be useful, and >> that qemu does not validate whether the new image met those

[Qemu-devel] [PATCH 3/3] boards: move all machine type functions to boards.c

2012-02-24 Thread Luiz Capitulino
The license text is the same as used in vl.c. Also note that it's necessary to make machine_parse() public. Signed-off-by: Luiz Capitulino --- Makefile.target |1 + hw/boards.c | 88 +++ hw/boards.h |1 + vl.c| 6

[Qemu-devel] [PATCH 1/3] boards: qemu_register_machine(): return void

2012-02-24 Thread Luiz Capitulino
It never fails. Signed-off-by: Luiz Capitulino Reviewed-by: Andreas Färber --- hw/boards.h |2 +- vl.c|3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/boards.h b/hw/boards.h index 667177d..7a9899f 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -31,7 +31,7

[Qemu-devel] [PATCH 2/3] boards: introduce machine_print_all()

2012-02-24 Thread Luiz Capitulino
It prints all registered machine types. Signed-off-by: Luiz Capitulino --- vl.c | 25 - 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/vl.c b/vl.c index 728eb36..ced7068 100644 --- a/vl.c +++ b/vl.c @@ -1198,6 +1198,20 @@ QEMUMachine *find_default_machi

[Qemu-devel] [PATCH v2 0/3]: Improve machine type functions

2012-02-24 Thread Luiz Capitulino
Actually, the major change is to move the machine type functions to boards.c. But I wanted to keep the same subject as v1. v2: o Drop function renames o Drop machine type list conversion to QTAILQ o Rebase against latest master o Other minor changes Makefile.target |1 + hw/boards.c |

Re: [Qemu-devel] [PATCH v5 8/9] qxl: introduce QXLCookie

2012-02-24 Thread Alon Levy
On Fri, Feb 24, 2012 at 12:46:05PM +0100, Gerd Hoffmann wrote: > On 02/22/12 22:09, Alon Levy wrote: > > Will be used in the next patch. > > Fails checkpatch.pl. .. back to the lab. > > cheers, > Gerd >

Re: [Qemu-devel] converting the block layer from coroutines to threads

2012-02-24 Thread Anthony Liguori
On 02/24/2012 01:02 PM, Paolo Bonzini wrote: Hi all, a few weeks ago Stefan Hajnoczi pointed me to his work on virtio-blk performance. Stefan's work had two sides. First, he captured very nice performance data of the block layer at http://www.linux-kvm.org/page/Virtio/Block/Latency; second, in

[Qemu-devel] converting the block layer from coroutines to threads

2012-02-24 Thread Paolo Bonzini
Hi all, a few weeks ago Stefan Hajnoczi pointed me to his work on virtio-blk performance. Stefan's work had two sides. First, he captured very nice performance data of the block layer at http://www.linux-kvm.org/page/Virtio/Block/Latency; second, in order to measure peak performance, he basicall

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 16:49:04 + Federico Simoncelli wrote: > Signed-off-by: Federico Simoncelli How does this relate to migrate -b? Should it be deprecated? Btw, would be nice to have a 0/2 intro email describing the feature and changelog info. > --- > blockdev.c | 107 >

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 06:46 PM, Eric Blake wrote: > I think you need to be more explicit that @new-image-file MUST have > identical contents as the current image file, for this to be useful, and > that qemu does not validate whether the new image met those conditions. > Possible ways to achieve this: Not

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 06:02 PM, Eric Blake wrote: > Is the escaping of : and \ only necessary for image1.img, or for both > image1 and image2? I need to know if the parser is consistent for both > arguments, but this wording makes it sound like it is only for the first > argument. libvirt is completely i

Re: [Qemu-devel] Compile/link errors

2012-02-24 Thread Anthony Liguori
On 02/24/2012 12:09 PM, Andreas Färber wrote: Am 24.02.2012 18:27, schrieb Anthony Liguori: On 02/24/2012 11:11 AM, Gerhard Wiesinger wrote: Hello, I'm having compile/link errors on 85f38553031b1a6e07f786c9ab0d403af7252b4f: LINK x86_64-softmmu/qemu-system-x86_64 ../libhw64/virtio-pci.o: In fun

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 16:49:03 + Federico Simoncelli wrote: > From: Marcelo Tosatti > > Mirrored writes are used by live block copy. > > Signed-off-by: Marcelo Tosatti > Signed-off-by: Federico Simoncelli > --- > Makefile.objs |2 +- > block/blkmirror.c | 247 > +++

Re: [Qemu-devel] Compile/link errors

2012-02-24 Thread Andreas Färber
Am 24.02.2012 18:27, schrieb Anthony Liguori: > On 02/24/2012 11:11 AM, Gerhard Wiesinger wrote: >> Hello, >> >> I'm having compile/link errors on >> 85f38553031b1a6e07f786c9ab0d403af7252b4f: >> LINK x86_64-softmmu/qemu-system-x86_64 >> ../libhw64/virtio-pci.o: In function `virtio_scsi_exit_pci': >

Re: [Qemu-devel] [PATCH] build: allow turning off debuginfo

2012-02-24 Thread Gerd Hoffmann
On 02/24/12 12:16, Peter Maydell wrote: > On 24 February 2012 10:39, Gerd Hoffmann wrote: >> On 02/08/12 13:54, Gerd Hoffmann wrote: >>> This patch adds --{enable,disable}-debug-info switches to configure >>> which allows to include/exclude the '-g' switch on the gcc & ld >>> command lines. Not b

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Eric Blake
On 02/24/2012 09:49 AM, Federico Simoncelli wrote: > Signed-off-by: Federico Simoncelli Pretty sparse on the commit message. > +++ b/hmp-commands.hx > @@ -886,6 +886,44 @@ Snapshot device, using snapshot file as target if > provided > ETEXI > > { > +.name = "drive_reopen",

Re: [Qemu-devel] [PATCHv3] Error out when tls-channel option is used without TLS

2012-02-24 Thread Gerd Hoffmann
On 02/24/12 18:28, Christophe Fergeau wrote: > It's currently possible to setup spice channels using TLS when > no TLS port has been specified (ie TLS is disabled). This cannot > work, so better to error out in such a situation. Patch added to spice patch queue. thanks, Gerd

[Qemu-devel] [PATCHv3] Error out when tls-channel option is used without TLS

2012-02-24 Thread Christophe Fergeau
It's currently possible to setup spice channels using TLS when no TLS port has been specified (ie TLS is disabled). This cannot work, so better to error out in such a situation. --- ui/spice-core.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ui/spice-core.c b/ui

Re: [Qemu-devel] Compile/link errors

2012-02-24 Thread Anthony Liguori
On 02/24/2012 11:11 AM, Gerhard Wiesinger wrote: Hello, I'm having compile/link errors on 85f38553031b1a6e07f786c9ab0d403af7252b4f: LINK x86_64-softmmu/qemu-system-x86_64 ../libhw64/virtio-pci.o: In function `virtio_scsi_exit_pci': /root/download/qemu/git/qemu/hw/virtio-pci.c:956: undefined refe

Re: [Qemu-devel] [PATCH v2 6/6] qdev: switch property accessors to fixed-width visitor interfaces

2012-02-24 Thread Anthony Liguori
According to git bisect and qemu-test, this breaks: qemu-system-x86_64 -kernel bin/vmlinuz-3.0 -initrd .tmp-26227/initramfs-26227.img.gz -append console=ttyS0 seed=1498 -nographic -enable-kvm -device virtio-balloon-pci,id=balloon0 -pidfile .tmp-26227/pidfile-26227.pid -qmp unix:.tmp-26227/qmps

Re: [Qemu-devel] [PATCHv2 2/2] Error out when tls-channel option is used without TLS

2012-02-24 Thread Gerd Hoffmann
On 02/24/12 18:13, Christophe Fergeau wrote: > It's currently possible to setup spice channels using TLS when > no TLS port has been specified (ie TLS is disabled). This cannot > work, so better to error out in such a situation. Applying: Error out when tls-channel option is used without TLS === c

Re: [Qemu-devel] [PATCHv2 1/2] spice: use error_report to report errors

2012-02-24 Thread Gerd Hoffmann
On 02/24/12 18:13, Christophe Fergeau wrote: > Error message reporting during spice startup wasn't consistent, it was done > with fprintf(stderr, "") but sometimes the message didn't have a trailing > \n. Using error_report make the intent of the message clearer and deal > with the final \n for us.

[Qemu-devel] New QMP event interface (was Re: [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event)

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:56 AM, Luiz Capitulino wrote: On Fri, 24 Feb 2012 10:44:11 -0600 Anthony Liguori wrote: I'm asking because the conversion of events to the qapi is not too far away, but I think that using QOM will somewhat deprecate the code you have in the glib branch (besides having to wait

[Qemu-devel] Compile/link errors

2012-02-24 Thread Gerhard Wiesinger
Hello, I'm having compile/link errors on 85f38553031b1a6e07f786c9ab0d403af7252b4f: LINK x86_64-softmmu/qemu-system-x86_64 ../libhw64/virtio-pci.o: In function `virtio_scsi_exit_pci': /root/download/qemu/git/qemu/hw/virtio-pci.c:956: undefined reference to `virtio_scsi_exit' ../libhw64/virt

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Federico Simoncelli
- Original Message - > From: "Eric Blake" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com, > arm...@redhat.com, lcapitul...@redhat.com, > pbonz...@redhat.com > Sent: Friday, February 24, 2012 6:02:36 PM > Subject: Re: [Qemu-devel] [PATCH 1/2

[Qemu-devel] [PATCHv2 2/2] Error out when tls-channel option is used without TLS

2012-02-24 Thread Christophe Fergeau
It's currently possible to setup spice channels using TLS when no TLS port has been specified (ie TLS is disabled). This cannot work, so better to error out in such a situation. --- ui/spice-core.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/ui/spice-core.c b/ui/

[Qemu-devel] [PATCHv2 1/2] spice: use error_report to report errors

2012-02-24 Thread Christophe Fergeau
Error message reporting during spice startup wasn't consistent, it was done with fprintf(stderr, "") but sometimes the message didn't have a trailing \n. Using error_report make the intent of the message clearer and deal with the final \n for us. --- ui/spice-core.c | 22 +++---

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 13:03:08 +0100 Kevin Wolf wrote: > > static void eject_device(BlockDriverState *bs, int force, Error **errp) > > { > > if (bdrv_in_use(bs)) { > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > index 573b823..ccb1f62 100644 > > --- a/hmp-commands.hx > > +++ b/hmp-com

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Eric Blake
On 02/24/2012 09:49 AM, Federico Simoncelli wrote: > From: Marcelo Tosatti > > Mirrored writes are used by live block copy. > > Signed-off-by: Marcelo Tosatti > Signed-off-by: Federico Simoncelli > --- > +++ b/block/blkmirror.c > @@ -0,0 +1,247 @@ > +/* > + * Block driver for mirrored writes.

Re: [Qemu-devel] [PATCH v2] net: add the support for -netdev socket, listen

2012-02-24 Thread Zhi Yong Wu
On Fri, Feb 24, 2012 at 11:05 PM, Anthony Liguori wrote: > On 02/18/2012 03:19 AM, zwu.ker...@gmail.com wrote: >> >> From: Zhi Yong Wu >> >> The -net socket,listen option does not work with the newer -netdev >> syntax: >> http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html >> >> Thi

Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:51 AM, Luiz Capitulino wrote: On Fri, 24 Feb 2012 10:15:52 -0600 Anthony Liguori wrote: On 02/24/2012 10:12 AM, Peter Maydell wrote: On 24 February 2012 14:13, Luiz Capitulino wrote: Perform the following renames: o qemu_register_machine() -> machine_register() o

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 10:44:11 -0600 Anthony Liguori wrote: > > I'm asking because the conversion of events to the qapi is not too far away, > > but I think that using QOM will somewhat deprecate the code you have in the > > glib branch (besides having to wait for 1.2)? > > I have some vague ideas

Re: [Qemu-devel] [PULL 0/8] qemu-ga: add support for Windows

2012-02-24 Thread Anthony Liguori
On 02/23/2012 04:10 PM, Michael Roth wrote: The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://github.com/mdroth/qemu.git qga-win32-pull-2-23-12 Pulled. Thanks. Rega

Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 10:15:52 -0600 Anthony Liguori wrote: > On 02/24/2012 10:12 AM, Peter Maydell wrote: > > On 24 February 2012 14:13, Luiz Capitulino wrote: > >> Perform the following renames: > >> > >> o qemu_register_machine() -> machine_register() > >> o find_machine() -> machine_find

Re: [Qemu-devel] [PATCH v2] net: add the support for -netdev socket, listen

2012-02-24 Thread Zhi Yong Wu
On Fri, Feb 24, 2012 at 11:05 PM, Anthony Liguori wrote: > On 02/18/2012 03:19 AM, zwu.ker...@gmail.com wrote: >> >> From: Zhi Yong Wu >> >> The -net socket,listen option does not work with the newer -netdev >> syntax: >> http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html >> >> Thi

[Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli --- blockdev.c | 107 -- hmp-commands.hx | 38 +++ hmp.c| 24 hmp.h|2 + qapi-schema.json | 54 +++ 5 files changed

[Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Federico Simoncelli
From: Marcelo Tosatti Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti Signed-off-by: Federico Simoncelli --- Makefile.objs |2 +- block/blkmirror.c | 247 docs/blkmirror.txt | 16 3 files change

Re: [Qemu-devel] [PATCH 2/2] Error out when tls-channel option is used without TLS

2012-02-24 Thread Gerd Hoffmann
On 02/24/12 11:37, Christophe Fergeau wrote: > It's currently possible to setup spice channels using TLS when > no TLS port has been specified (ie TLS is disabled). This cannot > work, so better to error out in such a situation. > --- > ui/spice-core.c |8 +++- > 1 files changed, 7 inserti

Re: [Qemu-devel] [PULL 0/3] Trivial patches for 11 to 24 February 2012

2012-02-24 Thread Anthony Liguori
On 02/24/2012 08:00 AM, Stefan Hajnoczi wrote: The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes

Re: [Qemu-devel] [PATCH 1/2] Add \n to the end of fatal spice error messages

2012-02-24 Thread Gerd Hoffmann
On 02/24/12 11:37, Christophe Fergeau wrote: > Without it the shell prompt doesn't appear on a new line after > qemu dies. > --- > ui/spice-core.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index 1308a3d..6d240a3 100644

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:39 AM, Luiz Capitulino wrote: On Fri, 24 Feb 2012 10:01:00 -0600 Anthony Liguori wrote: On 02/23/2012 08:08 AM, Markus Armbruster wrote: Luiz Capitulino writes: On Thu, 23 Feb 2012 08:50:08 +0100 Markus Armbruster wrote: Kevin Wolf writes: Am 17.02.2012 20:21, sch

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 10:01:00 -0600 Anthony Liguori wrote: > On 02/23/2012 08:08 AM, Markus Armbruster wrote: > > Luiz Capitulino writes: > > > >> On Thu, 23 Feb 2012 08:50:08 +0100 > >> Markus Armbruster wrote: > >> > >>> Kevin Wolf writes: > >>> > Am 17.02.2012 20:21, schrieb Luiz Capitu

Re: [Qemu-devel] [PULL] Zynq-7000 EPP platform model

2012-02-24 Thread Anthony Liguori
On 02/20/2012 12:25 AM, Peter Crosthwaite wrote: Pull Request for Zynq-7000 platform model initial support. The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) are available in the git

Re: [Qemu-devel] [PULL 0/5]: QMP queue

2012-02-24 Thread Anthony Liguori
On 02/23/2012 08:42 AM, Luiz Capitulino wrote: Contains only the DEVICE_TRAY_MOVED event series. The changes (since 235fe3bfd46b1104575b540d0bc3fdf584030b99) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Pulled. Thanks. Regards, Anthony Li

Re: [Qemu-devel] [PULL] Merge qemu-iotests into qemu.git

2012-02-24 Thread Anthony Liguori
On 02/23/2012 03:48 AM, Kevin Wolf wrote: The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled. Thanks. Regards, Anthony

Re: [Qemu-devel] [PULL v4 00/18] virtio-scsi driver

2012-02-24 Thread Anthony Liguori
On 02/22/2012 08:33 AM, Paolo Bonzini wrote: Anthony, the following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) are available in the git repository at: git://github.com/bonzini/qemu.git v

Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:12 AM, Peter Maydell wrote: On 24 February 2012 14:13, Luiz Capitulino wrote: Perform the following renames: o qemu_register_machine() -> machine_register() o find_machine() -> machine_find() o find_default_machine() -> machine_find_default() Signed-off-by: Luiz Cap

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:05 AM, Alexander Graf wrote: So Alex asked whether I can merge this, which made me take a look. I don't know much about what this does so just general comments on all of the code. This should come through Paolo's new SCSI tree. And while I defended this before, I now think

Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions

2012-02-24 Thread Peter Maydell
On 24 February 2012 14:13, Luiz Capitulino wrote: > Perform the following renames: > >  o qemu_register_machine() -> machine_register() >  o find_machine() -> machine_find() >  o find_default_machine()  -> machine_find_default() > > Signed-off-by: Luiz Capitulino >  52 files changed, 96 insertion

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-24 Thread Alexander Graf
On 24.02.2012, at 16:58, Anthony Liguori wrote: > On 02/23/2012 09:34 AM, Michael S. Tsirkin wrote: >> On Tue, Feb 21, 2012 at 10:36:43AM +0100, Hannes Reinecke wrote: >>> This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. >>> I've tested it to work with Linux, Windows Vista, and

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-24 Thread Anthony Liguori
On 02/23/2012 08:08 AM, Markus Armbruster wrote: Luiz Capitulino writes: On Thu, 23 Feb 2012 08:50:08 +0100 Markus Armbruster wrote: Kevin Wolf writes: Am 17.02.2012 20:21, schrieb Luiz Capitulino: It's emitted whenever the tray is moved by the guest or by HMP/QMP commands. Signed-off-

[Qemu-devel] [PATCH 2/2] Error out when tls-channel option is used without TLS

2012-02-24 Thread Christophe Fergeau
It's currently possible to setup spice channels using TLS when no TLS port has been specified (ie TLS is disabled). This cannot work, so better to error out in such a situation. --- ui/spice-core.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ui/spice-core.c b/ui

[Qemu-devel] [PATCH 1/2] Add \n to the end of fatal spice error messages

2012-02-24 Thread Christophe Fergeau
Without it the shell prompt doesn't appear on a new line after qemu dies. --- ui/spice-core.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 1308a3d..6d240a3 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -568,15 +568,

Re: [Qemu-devel] [PATCH 0/5]: Improve machine type functions

2012-02-24 Thread Anthony Liguori
On 02/24/2012 09:20 AM, Luiz Capitulino wrote: On Fri, 24 Feb 2012 08:58:55 -0600 Anthony Liguori wrote: On 02/24/2012 08:13 AM, Luiz Capitulino wrote: I was reading some related code yesterday and couldn't resist improving this. Not sure if this is aligned with any possible QOM work in this

Re: [Qemu-devel] [PATCH 4/5] boards: switch machine type list to QTAILQ

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 15:23:43 +0100 Andreas Färber wrote: > Am 24.02.2012 15:13, schrieb Luiz Capitulino: > > Signed-off-by: Luiz Capitulino > > Unless this fixes a bug, I'd rather not refactor this as in my head this > is already just object_class_foreach() / object_class_by_name(), similar > t

Re: [Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-24 Thread Anthony Liguori
On 02/22/2012 11:22 AM, alexander_barab...@mentor.com wrote: From: Alexander Barabash In the old implementation, if the new value of the property links to the same object, as the old value, that object is first unref-ed, and then ref-ed. This leads to unintended deinitialization of that object.

Re: [Qemu-devel] [PATCH] split SCSI and LSI, add myself as SCSI maintainer

2012-02-24 Thread Anthony Liguori
On 02/22/2012 08:59 AM, Paolo Bonzini wrote: This has been the de facto situation for a while now. Add a tree, too. Signed-off-by: Paolo Bonzini Applied. Thanks. Regards, Anthony Liguori --- MAINTAINERS |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/MA

Re: [Qemu-devel] [PATCH 0/7] cpu model bug fixes and definition corrections (v3)

2012-02-24 Thread Anthony Liguori
On 02/17/2012 10:41 AM, Eduardo Habkost wrote: These are patches based on a series that John Cooper sent back in May 2011, and that I resent last June. Not all changes from that series are here, but just the most obvious ones. The previous submission of this series is: Message-Id:<1307041990-261

Re: [Qemu-devel] [PATCH 0/4] target-i386: Helpers for CPUID version

2012-02-24 Thread Anthony Liguori
On 02/17/2012 10:46 AM, Andreas Färber wrote: Hello x86 gurus, This series came out of my qom-cpu work. The reasoning is that in a QOM world we will need this logic twice, once as before and once for -cpu family=x,model=y,stepping=z,model_id=foo. Note: The family=x value is not bounds-checked i

Re: [Qemu-devel] [PATCH 00/19] Fix and improve chardev open error messages

2012-02-24 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Our chardev open error messages are an embarrassment. Commit 6e1db57b tried to improve the useless "opening backend FOO failed" message in qemu_chr_open_opts(), but it is flawed: some failure modes went from an unhelpful "failed" to an outright mi

Re: [Qemu-devel] [PATCH 4/5] boards: switch machine type list to QTAILQ

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 16:21:56 +0100 Andreas Färber wrote: > Am 24.02.2012 15:56, schrieb Luiz Capitulino: > > On Fri, 24 Feb 2012 15:23:43 +0100 > > Andreas Färber wrote: > > > >> Am 24.02.2012 15:13, schrieb Luiz Capitulino: > >>> Signed-off-by: Luiz Capitulino > >> > >> Unless this fixes a bu

Re: [Qemu-devel] [PATCH 5/5] boards: move all machine type functions to boards.c

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 16:10:17 +0100 Andreas Färber wrote: > Am 24.02.2012 15:13, schrieb Luiz Capitulino: > > The license text is the same as used in vl.c. Also note that it's > > necessary to make machine_parse() public. > > > > Signed-off-by: Luiz Capitulino > > --- > > Makefile.target |3

  1   2   >