[Qemu-devel] [PATCH v3 4/4] xilinx_zynq: machine model initial version

2012-02-10 Thread Peter A. G. Crosthwaite
Xilinx zynq-7000 machine model. Also includes device model for the zynq-specific system level control register (SLCR) module. Signed-off-by: Peter A. G. Crosthwaite --- changes since v2: removed 2 compile warnings from zynq_arm_sysctl.c changes since v1: Added gem init function remowed WDT instan

[Qemu-devel] [PATCH v3 3/4] cadence_gem: initial version of device model

2012-02-10 Thread Peter A. G. Crosthwaite
Device model for cadence gem ethernet controller. Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn --- changes from v1: removed global init function marked vmsd as unmigratable cleaned up debug messages Makefile.target |1 + hw/cadence_gem.c | 1229 +

[Qemu-devel] [PATCH v3 2/4] cadence_ttc: initial version of device model

2012-02-10 Thread Peter A. G. Crosthwaite
Implemented cadence Triple Timer Counter (TCC) Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn --- changed from v2 changed ptimer to QEMUTimer (Fixed skew/drift issue in timer delays) changes from v1 refactored event driven code marked vmsd as unmigratable Makefile.target |

[Qemu-devel] [PATCH v3 1/4] cadence_uart: initial version of device model

2012-02-10 Thread Peter A. G. Crosthwaite
Implemented cadence UART serial controller Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn --- changes from v1: converted register file to array added vmsd state save/load support removed read side effects from CISR register Makefile.target |1 + hw/cadence_uart.c | 561

[Qemu-devel] [PATCH v3 0/4] Zynq-7000 EPP platform model

2012-02-10 Thread Peter A. G. Crosthwaite
This is a suite of Device models and a machine model for the Xilinx Zynq-7000 Extensible Processing Platform: http://www.xilinx.com/products/silicon-devices/epp/zynq-7000/index.htm This is an ARM based platform featuring embedded SoC peripherals. This patch series includes a minimal set of devi

Re: [Qemu-devel] [PATCH 1/3] Add support for 128-bit arithmeticRe: [PATCH 1/3] Add support for 128-bit arithmetic

2012-02-10 Thread Andreas Färber
Am 10.02.2012 10:51, schrieb Jay Foad: > On 30 Oct 2011, Avi Kivity wrote: >> The memory API supports 64-bit buses (e.g. PCI). A size on such a bus cannot >> be represented with a 64-bit data type, if both 0 and the entire address >> space size are to be represented. Futhermore, any address arith

Re: [Qemu-devel] How to follow a child process created in the guest OS?

2012-02-10 Thread malc
On Sat, 11 Feb 2012, Andreas F?rber wrote: > Am 10.02.2012 11:26, schrieb ???: > > On Fri, Feb 10, 2012 at 08:14:41AM +, Stefan Hajnoczi wrote: > >> On Thu, Feb 09, 2012 at 06:33:16PM +0800, ??? wrote: > >>> I am running a tiny OS on QEMU and debugging it with gdbstub. The tiny OS > >>> will

Re: [Qemu-devel] Memory: how to determine the max memory size of one VM?

2012-02-10 Thread Paul Brook
> Am 11.02.2012 00:25, schrieb Paul Brook: > >> ii) Some tracing of mine indicates QEMU has a highly dynamic memory > >> usage during runtime, be it due to network layer, block layer or > >> whatever exactly. > > > > We do? Significant compared to the size of guest ram? That sounds like a > > bug

Re: [Qemu-devel] How to follow a child process created in the guest OS?

2012-02-10 Thread Andreas Färber
Am 10.02.2012 11:26, schrieb 陳韋任: > On Fri, Feb 10, 2012 at 08:14:41AM +, Stefan Hajnoczi wrote: >> On Thu, Feb 09, 2012 at 06:33:16PM +0800, 陳韋任 wrote: >>> I am running a tiny OS on QEMU and debugging it with gdbstub. The tiny OS >>> will >>> fork process 1, 2, ... and so on. I want to follow

Re: [Qemu-devel] Memory: how to determine the max memory size of one VM?

2012-02-10 Thread Andreas Färber
Am 11.02.2012 00:25, schrieb Paul Brook: >> ii) Some tracing of mine indicates QEMU has a highly dynamic memory >> usage during runtime, be it due to network layer, block layer or >> whatever exactly. > > We do? Significant compared to the size of guest ram? That sounds like a bug. Attached is a

Re: [Qemu-devel] How to follow a child process created in the guest OS?

2012-02-10 Thread Paul Brook
> I am running this tiny OS on QEMU then using GDB to connect it. > > I want to follow task 1 after the forking, but it seems that GDB > stick with task 0 and cannot follow task 1 even I do `set follow-fork-mode > child`. You have exactly one CPU. That's what the qemu GDB stub exposes. Multipl

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-10 Thread Paul Brook
> +#ifdef CONFIG_SLIRP > +static inline void slirp_update_timeout(uint32_t *timeout) > +{ > +*timeout = MIN(1000, *timeout); > +} > +#else > +static inline void slirp_update_timeout(uint32_t *timeout) { } > +#endif Shouldn't we be testing whether slirp is actually in use? I doubt many people

Re: [Qemu-devel] Memory: how to determine the max memory size of one VM?

2012-02-10 Thread Paul Brook
> There's two slightly different scenarios to consider here: > > i) User specifies command line options that cannot possibly work. > => Ideally, yeah, we should just provide an understandable error message > and exit with error code. > > ii) Some tracing of mine indicates QEMU has a highly dynami

Re: [Qemu-devel] [PATCH] Merge mips64 and mipsn32

2012-02-10 Thread Paul Brook
> > Make MIPS N32 be a variant of mips64, rather than a new architecture in > > its own right. This matches how sparc/ppc work, and makes TARGET_MIPS64 > > the right thing to check for a 64-bit mips core. > > > > As side-effect of this is that linux-user/mipsn32 gets merged into > > linux-user/mi

Re: [Qemu-devel] [PATCH] fstatat size mismatch

2012-02-10 Thread Andreas Färber
A "linux-user: " prefix for the subject would be nice, but let's wait for other comments first. Am 09.02.2012 20:05, schrieb Paul Brook: > host_to_target_stat64 is used for both stat64 and newfstatat syscalls. > In the latter case we don't actually have a struct stat64. > The current TARGET_ABI_BI

Re: [Qemu-devel] [PATCH] Merge mips64 and mipsn32

2012-02-10 Thread Andreas Färber
Am 10.02.2012 12:23, schrieb Paul Brook: > Make MIPS N32 be a variant of mips64, rather than a new architecture in > its own right. This matches how sparc/ppc work, and makes TARGET_MIPS64 > the right thing to check for a 64-bit mips core. > > As side-effect of this is that linux-user/mipsn32 get

Re: [Qemu-devel] [PATCH v2] qom: Unify type registration

2012-02-10 Thread Andreas Färber
Am 09.02.2012 17:49, schrieb Peter Maydell: > On 9 February 2012 14:20, Andreas Färber wrote: >> Replace device_init() with generalized type_init(). >> >> While at it, unify naming convention: type_init([$prefix_]register_types) >> Also, type_init() is a function, so add preceding blank line where

[Qemu-devel] [PATCH] configure: Remove OpenBSD workaround for curses probe

2012-02-10 Thread Brad Smith
Remove the OpenBSD workaround for the curses probe. This has not been necessary for 5 releases now. Signed-off-by: Brad Smith diff --git a/configure b/configure index 763db24..c9729f8 100755 --- a/configure +++ b/configure @@ -1900,9 +1900,6 @@ if test "$curses" != "no" ; then curses_found=no

[Qemu-devel] [Bug 928204] Re: build failure gentoo

2012-02-10 Thread Iggy
Sounds like your compiler may be to blame. Can you try on a different system? Or maybe try rebuilding your compiler without any *CFLAGS set? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/928204 Title

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-10 Thread Paolo Bonzini
On 02/10/2012 08:39 PM, Paolo Bonzini wrote: 1. added commands blockdev-tray-open, blockdev-tray-close, blockdev-medium-insert, blockdev-medium-remove I think this slightly overengineering. eject and change work well enough, we do not need blockdev-medium-insert and blockdev-medium-remov

[Qemu-devel] [PATCH 2/6] monitor: Introduce qemu_get_fd()

2012-02-10 Thread Luiz Capitulino
Get the file-descriptor from 'cur_mon', will be used by the QAPI converted migration command. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- monitor.c |5 + monitor.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH 4/6] Error: Introduce error_copy()

2012-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- error.c | 12 error.h |5 + 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/error.c b/error.c index 990050f..d85e136 100644 --- a/error.c +++ b/error.c @@ -43,6 +43,18 @@ void error_set(Error **errp, const char *fmt, ...)

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-10 Thread Paolo Bonzini
On 02/10/2012 06:55 PM, Kevin Wolf wrote: Am 10.02.2012 18:04, schrieb Luiz Capitulino: This reminds me about an earlier try where I did the following, iirc: 1. added commands blockdev-tray-open, blockdev-tray-close, blockdev-medium-insert, blockdev-medium-remove I think this slightly o

[Qemu-devel] [PATCH 6/6] qapi: Convert migrate

2012-02-10 Thread Luiz Capitulino
The migrate command is one of those commands where HMP and QMP completely mix up together. This made the conversion to the QAPI (which separates the command into QMP and HMP parts) a bit difficult. The first important change to be noticed is that this commit completes the removal of the Monitor ob

[Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

2012-02-10 Thread Luiz Capitulino
The Monitor object is passed back and forth within the migration/savevm code so that it can print errors and progress to the user. However, that approach assumes a HMP monitor, being completely invalid in QMP. This commit drops almost every single usage of the Monitor object, all monitor_printf()

[Qemu-devel] [PATCH 3/6] QDict: Introduce qdict_copy()

2012-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- check-qdict.c | 29 + qdict.c | 18 ++ qdict.h |1 + 3 files changed, 48 insertions(+), 0 deletions(-) diff --git a/check-qdict.c b/check-qdict.c index fc0d276..12c73ab 100644 --- a/check-qdict.c +

[Qemu-devel] [PATCH 1/6] QError: Introduce new errors for the migration command

2012-02-10 Thread Luiz Capitulino
The new errors are QERR_MIGRATION_ACTIVE and QERR_MIGRATION_NOT_SUPPORTED, which are going to be used by the QAPI converted migration command. Signed-off-by: Luiz Capitulino --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/qerr

[Qemu-devel] [PATCH 0/6] qapi: Convert migrate

2012-02-10 Thread Luiz Capitulino
This is a rebase of Anthony's conversion, from his glib branch; and this is also the beginning of the conversion of complex commands to the qapi. There are two important changes that should be observed: 1. patch 5/6 purges the 'mon' object from migration code. One of the consequences is that

[Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-10 Thread Jan Kiszka
As we have thread-local cpu_single_env now and KVM uses exactly one thread per VCPU, we can drop the cpu_single_env updates from the loop and initialize this variable only once during setup. Signed-off-by: Jan Kiszka --- cpus.c|1 + kvm-all.c |5 - 2 files changed, 1 insertions(+

[Qemu-devel] [PATCH v2 2/8] Allow to use pause_all_vcpus from VCPU context

2012-02-10 Thread Jan Kiszka
In order to perform critical manipulations on the VM state in the context of a VCPU, specifically code patching, stopping and resuming of all VCPUs may be necessary. resume_all_vcpus is already compatible, now enable pause_all_vcpus for this use case by stopping the calling context before starting

[Qemu-devel] [PATCH v2 8/8] kvmvapic: Use optionrom helpers

2012-02-10 Thread Jan Kiszka
Use OPTION_ROM_START/END from the common header file, add comment to init code. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/kvmvapic.S | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/pc-bios/optionrom/kvmvapic.S b/pc-bios/optionrom/kvmvapic.S index

[Qemu-devel] [PATCH v2 3/8] target-i386: Add infrastructure for reporting TPR MMIO accesses

2012-02-10 Thread Jan Kiszka
This will allow the APIC core to file a TPR access report. Depending on the accelerator and kernel irqchip mode, it will either be delivered right away or queued for later reporting. In TCG mode, we can restart the triggering instruction and can therefore forward the event directly. KVM does not a

[Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-10 Thread Jan Kiszka
This enables acceleration for MMIO-based TPR registers accesses of 32-bit Windows guest systems. It is mostly useful with KVM enabled, either on older Intel CPUs (without flexpriority feature, can also be manually disabled for testing) or any current AMD processor. The approach introduced here is

[Qemu-devel] [PATCH v2 4/8] kvmvapic: Add option ROM

2012-02-10 Thread Jan Kiszka
This imports and builds the original VAPIC option ROM of qemu-kvm. Its interaction with QEMU is described in the commit that introduces the corresponding device model. Signed-off-by: Jan Kiszka --- .gitignore |1 + Makefile |2 +- pc-bios/optionrom/M

[Qemu-devel] [PATCH v2 6/8] kvmvapic: Simplify mp/up_set_tpr

2012-02-10 Thread Jan Kiszka
The CH registers is only written, never read. So we can remove these operations and, in case of up_set_tpr, also the ECX push/pop. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/kvmvapic.S |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/pc-bios/optionrom/kvmvapic.S

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-10 Thread Eric Blake
On 02/10/2012 07:41 AM, Daniel P. Berrange wrote: >> @@ -80,7 +80,7 @@ void *qemu_oom_check(void *ptr) >> { >> if (ptr == NULL) { >> fprintf(stderr, "Failed to allocate memory: %s\n", strerror(errno)); >> -abort(); >> +exit(EXIT_FAILURE); > > exit() will call any at

[Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum

2012-02-10 Thread Jan Kiszka
Always add a byte before the final 512-bytes alignment to reserve the space for the ROM checksum. Signed-off-by: Jan Kiszka --- pc-bios/optionrom/optionrom.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h i

[Qemu-devel] [PATCH v2 0/8] uq/master: TPR access optimization for Windows guests

2012-02-10 Thread Jan Kiszka
Here is v2 of the TPR access optimization. Changes: - plug race between patching and running VCPUs accessing the same TPR instruction by stopping VCPUs during patch process - realized forward/backward check in evaluate_tpr_instruction via a table but kept patch_instruction as is (too much v

Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers

2012-02-10 Thread Anthony Liguori
On 02/10/2012 12:08 PM, Kevin Wolf wrote: Am 10.02.2012 18:22, schrieb Anthony Liguori: On 02/10/2012 11:09 AM, Amit Shah wrote: On (Fri) 10 Feb 2012 [07:28:19], Anthony Liguori wrote: On 02/10/2012 07:19 AM, Amit Shah wrote: Instead of passing each handler in the qemu_add_handlers() function

Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers

2012-02-10 Thread Kevin Wolf
Am 10.02.2012 18:22, schrieb Anthony Liguori: > On 02/10/2012 11:09 AM, Amit Shah wrote: >> On (Fri) 10 Feb 2012 [07:28:19], Anthony Liguori wrote: >>> On 02/10/2012 07:19 AM, Amit Shah wrote: Instead of passing each handler in the qemu_add_handlers() function, create a struct of handlers

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-10 Thread Kevin Wolf
Am 10.02.2012 18:04, schrieb Luiz Capitulino: > This reminds me about an earlier try where I did the following, iirc: > > 1. added commands blockdev-tray-open, blockdev-tray-close, > blockdev-medium-insert, > blockdev-medium-remove > 2. added the events: BLOCK_TRAY_OPEN, BLOCK_TRAY_CLOSE, B

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-10 Thread Anthony Liguori
On 02/09/2012 10:02 PM, malc wrote: On Fri, 10 Feb 2012, Evgeny Voevodin wrote: On 02/09/2012 06:59 PM, Andreas F?rber wrote: Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Why audio files are such a special thing? Because they are cons

Re: [Qemu-devel] [PATCH v2] Add SPICE support to add_client monitor command

2012-02-10 Thread Luiz Capitulino
On Fri, 10 Feb 2012 12:30:21 +0100 Gerd Hoffmann wrote: > On 02/07/12 15:38, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > This is a followup to > > > > http://patchwork.ozlabs.org/patch/121004/ > > > > With the acceptance of some new APIs to libspice-server.so it > > is

Re: [Qemu-devel] [PATCH v2] Add SPICE support to add_client monitor command

2012-02-10 Thread Luiz Capitulino
On Tue, 7 Feb 2012 14:38:40 + "Daniel P. Berrange" wrote: > From: "Daniel P. Berrange" > > This is a followup to > > http://patchwork.ozlabs.org/patch/121004/ > > With the acceptance of some new APIs to libspice-server.so it > is possible to add support for SPICE to the 'add_client' >

[Qemu-devel] [PATCH 1/4] Use getaddrinfo for migration

2012-02-10 Thread Amos Kong
This allows us to use ipv4/ipv6 for migration addresses. Once there, it also uses /etc/services names (it came free). Signed-off-by: Juan Quintela Signed-off-by: Amos Kong --- migration-tcp.c | 60 --- net.c | 108

Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers

2012-02-10 Thread Anthony Liguori
On 02/10/2012 11:09 AM, Amit Shah wrote: On (Fri) 10 Feb 2012 [07:28:19], Anthony Liguori wrote: On 02/10/2012 07:19 AM, Amit Shah wrote: Instead of passing each handler in the qemu_add_handlers() function, create a struct of handlers that can be passed to the function instead. Signed-off-by:

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-10 Thread Luiz Capitulino
On Fri, 10 Feb 2012 10:27:21 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 09 Feb 2012 16:01:21 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > I've tried to implement a BLOCK_MEDIUM_EJECT event that, as we > >> > discussed[1], > >> >

[Qemu-devel] [PATCH 2/4] net/socket: allow ipv6 for net_socket_listen_init and socket_connect_init

2012-02-10 Thread Amos Kong
Remove use of parse_host_port. More SO_SOCKADDR changes. Signed-off-by: Juan Quintela Signed-off-by: Amos Kong --- net/socket.c | 60 +++--- 1 files changed, 11 insertions(+), 49 deletions(-) diff --git a/net/socket.c b/net/socket.c index d

[Qemu-devel] [PATCH 0/4] support to migrate with IPv6 address

2012-02-10 Thread Amos Kong
Those four patches make migration of IPv6 address work. Use getaddrinfo() to socket addresses infomation. --- Amos Kong (4): Use getaddrinfo for migration net/socket: allow ipv6 for net_socket_listen_init and socket_connect_init net: split hostname and service by last colon

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-10 Thread Luiz Capitulino
On Thu, 9 Feb 2012 13:26:40 -0600 Adam Litke wrote: > On Wed, Feb 08, 2012 at 06:30:40PM -0200, Luiz Capitulino wrote: > > This commit adds a QMP API for the guest provided memory statistics > > (long disabled by commit 07b0403dfc2b2ac179ae5b48105096cc2d03375a). > > > > The approach taken by the

Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers

2012-02-10 Thread Amit Shah
On (Fri) 10 Feb 2012 [07:28:19], Anthony Liguori wrote: > On 02/10/2012 07:19 AM, Amit Shah wrote: > >Instead of passing each handler in the qemu_add_handlers() function, > >create a struct of handlers that can be passed to the function instead. > > > >Signed-off-by: Amit Shah > > Why? It's a goo

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-10 Thread Luiz Capitulino
On Fri, 10 Feb 2012 10:36:06 +0100 Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 02/09/2012 04:01 PM, Markus Armbruster wrote: > >> Your GUEST_MEDIUM_EJECTED does*not* track my open<-> closed. I think > >> it's more complex than a straight open<-> closed event. Evidence: your >

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-10 Thread Stefano Stabellini
On Fri, 10 Feb 2012, Jan Kiszka wrote: > On 2012-02-10 12:18, Paolo Bonzini wrote: > > On 02/10/2012 12:19 PM, Stefano Stabellini wrote: > >> I think you are right and the right thing to do would be blocking > >> indefinitely. > >> However if slirp doesn't support it, we could have a timeout of 100

[Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-10 Thread Dongsu Park
Hi, Recently I observed performance regression regarding virtio-blk, especially different IO bandwidths between qemu-kvm 0.14.1 and 1.0. So I want to share the benchmark results, and ask you what the reason would be. 1. Test condition - On host, ramdisk-backed block device (/dev/ram0) - qemu-k

Re: [Qemu-devel] How to follow a child process created in the guest OS?

2012-02-10 Thread 陳韋任
On Fri, Feb 10, 2012 at 08:14:41AM +, Stefan Hajnoczi wrote: > On Thu, Feb 09, 2012 at 06:33:16PM +0800, 陳韋任 wrote: > > The question is not so related to QEMU itself, but I want to give it a > > try. > > I am running a tiny OS on QEMU and debugging it with gdbstub. The tiny OS > > will > >

[Qemu-devel] [PATCH 4/4] net: support to include ipv6 address by brackets

2012-02-10 Thread Amos Kong
That method of representing an IPv6 address with a port is discouraged because of its ambiguity. Referencing to RFC5952, the recommended format is: [2312::8274]:5200 test status: Successed listen side: qemu-kvm -incoming tcp:[2312::8274]:5200 client side: qemu-kvm ... (qemu

[Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon

2012-02-10 Thread Amos Kong
IPv6 address contains colons, parse will be wrong. [2312::8274]:5200 Signed-off-by: Amos Kong --- net.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index f63014c..9e1ef9e 100644 --- a/net.c +++ b/net.c @@ -84,7 +84,7 @@ static int get_str_sep(char

Re: [Qemu-devel] Memory: how to determine the max memory size of one VM?

2012-02-10 Thread Andreas Färber
Am 10.02.2012 11:36, schrieb Stefan Hajnoczi: > On Fri, Feb 10, 2012 at 10:35 AM, Stefan Hajnoczi wrote: >> On Fri, Feb 10, 2012 at 9:47 AM, Zhi Yong Wu wrote: >>> Today i tried to create one VM with the option "-m 4000", and found it >>> failed with the following errors: >>> >>> Failed to alloca

Re: [Qemu-devel] Memory: how to determine the max memory size of one VM?

2012-02-10 Thread Andreas Färber
Am 10.02.2012 12:23, schrieb Zhi Yong Wu: > On Fri, Feb 10, 2012 at 7:10 PM, Stefan Hajnoczi wrote: >> On Fri, Feb 10, 2012 at 11:00 AM, Zhi Yong Wu wrote: >>> On Fri, Feb 10, 2012 at 6:35 PM, Stefan Hajnoczi wrote: On Fri, Feb 10, 2012 at 9:47 AM, Zhi Yong Wu wrote: > Today i tried to

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-10 Thread Stefan Weil
Am 10.02.2012 16:13, schrieb Zhi Yong Wu: On Fri, Feb 10, 2012 at 10:41 PM, Daniel P. Berrange wrote: On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- oslib-posix.c |4 ++-- oslib-win32.c |4 ++-- 2 files changed, 4 inser

Re: [Qemu-devel] [PATCH 3/5] raw-posix: keep complete control of door locking if possible

2012-02-10 Thread Paolo Bonzini
On 02/10/2012 03:56 PM, Markus Armbruster wrote: Paolo Bonzini writes: On 02/10/2012 01:49 PM, Markus Armbruster wrote: With manage_door off: * cdrom_lock_medium() does nothing. Thus, guest OS operating the virtual door lock does not affect the physical door. * cdrom_eject() does nothing

[Qemu-devel] [PATCH v2] oslib: make error handling more reasonable

2012-02-10 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- oslib-posix.c |4 ++-- oslib-win32.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/oslib-posix.c b/oslib-posix.c index b6a3c7f..3b7cd9d 100644 --- a/oslib-posix.c +++ b/oslib-posix.c @@ -80,7 +80,7 @@ void *qemu_oo

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-10 Thread Zhi Yong Wu
On Fri, Feb 10, 2012 at 10:41 PM, Daniel P. Berrange wrote: > On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yong Wu wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >>  oslib-posix.c |    4 ++-- >>  oslib-win32.c |    4 ++-- >>  2 files changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 3/5] raw-posix: keep complete control of door locking if possible

2012-02-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 02/10/2012 01:49 PM, Markus Armbruster wrote: >> With manage_door off: >> >> * cdrom_lock_medium() does nothing. Thus, guest OS operating the >> virtual door lock does not affect the physical door. >> >> * cdrom_eject() does nothing. Thus, guest OS moving the virtua

[Qemu-devel] [PATCH v3 6/6] trace: [stderr] Port to generic event information and new control interface

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 26 -- trace/stderr.c | 35 +++ 2 files changed, 15 insertions(+), 46 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index 98a8ca8..a3135b8 100755 ---

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-10 Thread Daniel P. Berrange
On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > oslib-posix.c |4 ++-- > oslib-win32.c |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/oslib-posix.c b/oslib-posix.c > index b6a3c7f..f97

Re: [Qemu-devel] Memory: how to determine the max memory size of one VM?

2012-02-10 Thread Zhi Yong Wu
On Fri, Feb 10, 2012 at 10:08 PM, Stefan Hajnoczi wrote: > On Fri, Feb 10, 2012 at 11:53 AM, Zhi Yong Wu wrote: >> By the way, need we still to do one clean failure exit? > > I find the abort(3) usage odd but it's not critical to change it. > Since we printed an error message I would have expecte

Re: [Qemu-devel] Configure time selection of VGA and Ethernet

2012-02-10 Thread Paolo Bonzini
On 02/09/2012 06:54 PM, carlo.bra...@libero.it wrote: Hello, in your opinion, is it possible to add some #ifdef and two options to configure script for activating/deactivating the compilation of supported video and ethernet interfaces, in a similar manner it had been done with audio cards and "--

[Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-10 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- oslib-posix.c |4 ++-- oslib-win32.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/oslib-posix.c b/oslib-posix.c index b6a3c7f..f978d56 100644 --- a/oslib-posix.c +++ b/oslib-posix.c @@ -80,7 +80,7 @@ void *qemu_

[Qemu-devel] [PATCH v3 3/6] trace: [monitor] Use new event control interface

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- monitor.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 5e099bd..010f659 100644 --- a/monitor.c +++ b/monitor.c @@ -617,10 +617,19 @@ static void do_trace_event_set_state(Monitor *mon, const Q

[Qemu-devel] [PATCH v3 5/6] trace: [simple] Port to generic event information and new control interface

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 29 ++--- trace/simple.c | 33 ++--- trace/simple.h |6 +- trace/stderr.h | 11 --- 4 files changed, 17 insertions(+), 62 deletions(-) delete mode

[Qemu-devel] [PATCH v3 4/6] trace: [default] Use new event control interface

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace/default.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/trace/default.c b/trace/default.c index c9b27a2..12db18d 100644 --- a/trace/default.c +++ b/trace/default.c @@ -18,11 +18,10 @@ void trace_print_events(FILE *stream, fprint

[Qemu-devel] [PATCH v3 2/6] trace: Provide a detailed event control interface

2012-02-10 Thread Lluís Vilanova
This interface decouples event obtention from interaction. Event can be obtained through three different methods: * identifier * name * simple wildcard pattern Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 41 + trace/control-internal.h | 60 +++

[Qemu-devel] [PATCH v3 1/6] trace: Provide a generic tracing event descriptor

2012-02-10 Thread Lluís Vilanova
Uses tracetool to generate a backend-independent tracing event description. Signed-off-by: Lluís Vilanova --- Makefile |5 +++ Makefile.objs | 15 +++- scripts/tracetool.py | 94 trace/event-internal.h | 28 +

[Qemu-devel] [PATCH v3 0/6] trace: Generic event state description

2012-02-10 Thread Lluís Vilanova
NOTE: Applies on top of the tracetool-handling trivial changes. Provides a generic event state description and a more detailed event control and query interface. Signed-off-by: Lluís Vilanova --- Changes in v3: * Add some assertions. * Remove debugging printf's. * Improve documentation. * M

Re: [Qemu-devel] [PATCH 5/5] raw-posix: unmount CD-ROM filesystem via udisks

2012-02-10 Thread Paolo Bonzini
On 02/10/2012 01:51 PM, Markus Armbruster wrote: > We need to use O_EXCL in order to suppress event generation in the > kernel. However, O_EXCL by definition fails when the CD-ROM drive > is mounted. Automatically unmount it when it is passed through to > the guest. I'm not sure automatic unmo

Re: [Qemu-devel] [PATCH v2 00/15] SCSI s/g + SCSI migration + virtio-scsi

2012-02-10 Thread Paolo Bonzini
On 02/10/2012 03:01 PM, Stefan Hajnoczi wrote: The virtio-scsi portions look good. Thanks, I'll rebase and resubmit! Paolo

Re: [Qemu-devel] Memory: how to determine the max memory size of one VM?

2012-02-10 Thread Stefan Hajnoczi
On Fri, Feb 10, 2012 at 11:53 AM, Zhi Yong Wu wrote: > By the way, need we still to do one clean failure exit? I find the abort(3) usage odd but it's not critical to change it. Since we printed an error message I would have expected exit(EXIT_FAILURE), not abort(3) which is usually used for stran

Re: [Qemu-devel] [PATCH v2 00/15] SCSI s/g + SCSI migration + virtio-scsi

2012-02-10 Thread Stefan Hajnoczi
On Mon, Jan 16, 2012 at 4:30 PM, Paolo Bonzini wrote: > Here is v2 (three counting the RFC) of the virtio-scsi driver. > Unlike previous versions, it includes migration support. > > The only change in the spec has been s/UNDERRUN/OVERRUN/g. > > Paolo Bonzini (13): >  dma-helpers: make QEMUSGList t

Re: [Qemu-devel] [PATCH 3/5] raw-posix: keep complete control of door locking if possible

2012-02-10 Thread Paolo Bonzini
On 02/10/2012 01:49 PM, Markus Armbruster wrote: With manage_door off: * cdrom_lock_medium() does nothing. Thus, guest OS operating the virtual door lock does not affect the physical door. * cdrom_eject() does nothing. Thus, guest OS moving the virtual tray does not affect the physical tr

[Qemu-devel] [PATCH 22/28] usb: add USBBusOps->wakeup_endpoint

2012-02-10 Thread Gerd Hoffmann
Add usb bus op which is called whenever a usb endpoint becomes ready, so the host adapter emulation can react on that event. Signed-off-by: Gerd Hoffmann --- hw/usb.c |4 hw/usb.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index 0572547.

[Qemu-devel] [PATCH v3 07/11] trace: [tracetool] Rewrite event argument parsing

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 192 -- 1 files changed, 91 insertions(+), 101 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index b185724..cd1c29d 100755 --- a/scripts/tracetool.py +++ b/scripts/tr

[Qemu-devel] [PATCH 07/15] iSCSI: add configuration variables for iSCSI

2012-02-10 Thread Kevin Wolf
From: Ronnie Sahlberg This patch adds configuration variables for iSCSI to set initiator-name to use when logging in to the target, which type of header-digest to negotiate with the target and username and password for CHAP authentication. This allows specifying a initiator-name either from the

[Qemu-devel] [PATCH 07/28] usb: add usb_find_device()

2012-02-10 Thread Gerd Hoffmann
Add usb_find_device(). This function will check whenever a device with a specific address is connected to the specified port. Usually this will just check state and address of the device hooked up to the port, but in case of a hub it will ask the hub to check all hub ports for a matching device.

[Qemu-devel] [PATCH v4 09/11] trace: [tracetool] Automatically establish available backends and formats

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.objs|6 - Makefile.target |3 scripts/tracetool.py | 357 -- 3 files changed, 230 insertions(+), 136 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 2b68739..941386b 10

[Qemu-devel] [PATCH 01/28] usb-uhci: implement bandwidth management

2012-02-10 Thread Gerd Hoffmann
The OS is allowed to make the UHCI Controller run in circles. That is usually done to serve multiple connected USB devices in a robin-round fashion, so the available USB bandwidth is evenly distributed between devices. The uhci emulation handles this in a very poor way though. When it figures it

[Qemu-devel] [PATCH 17/28] usb: USBPacket: add status, rename owner -> ep

2012-02-10 Thread Gerd Hoffmann
Add enum to track the status of USBPackets, use that instead of the owner pointer to figure whenever a usb packet is currently in flight or not. Add some more packet status sanity checks. Also rename the USBEndpoint pointer from "owner" to "ep". Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c |

[Qemu-devel] [PATCH 23/28] xhci: signal low- and fullspeed support

2012-02-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-xhci.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/usb-xhci.c b/hw/usb-xhci.c index b274b80..27bdc2b 100644 --- a/hw/usb-xhci.c +++ b/hw/usb-xhci.c @@ -2672,7 +2672,10 @@ static void usb_xhci_init(XHCIState *xhci, DeviceS

[Qemu-devel] [PATCH v3 11/11] trace: [tracetool] Add error-reporting functions

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 27 +++ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index 1134544..7053a74 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -12,6 +12,

[Qemu-devel] [PATCH v3 09/11] trace: [tracetool] Automatically establish available backends and formats

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.objs|6 - Makefile.target |3 scripts/tracetool.py | 357 -- 3 files changed, 230 insertions(+), 136 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 2b68739..941386b 10

[Qemu-devel] [PATCH 28/28] xhci: handle USB_RET_NAK

2012-02-10 Thread Gerd Hoffmann
Add a field to XHCITransfer to correctly keep track of NAK'ed usb packets. Retry transfers when the endpoint is kicked again. Implement wakeup_endpoint bus op so we can kick the endpoint when needed. With this patch applied the emulated hid devices are working correctly when hooked up to xhci.

[Qemu-devel] [PATCH v4 08/11] trace: [tracetool] Make format-specific code optional and with access to event information

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 35 ++- 1 files changed, 10 insertions(+), 25 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index cd1c29d..91e7620 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -3

[Qemu-devel] [PATCH 04/15] qed: replace is_write with flags field

2012-02-10 Thread Kevin Wolf
From: Stefan Hajnoczi Per-request attributes like read/write are currently implemented as bool fields in the QEDAIOCB struct. This becomes unwiedly as the number of attributes grows. For example, the qed_aio_setup() function would have to take multiple bool arguments and at call sites it would

[Qemu-devel] [PATCH 14/15] sheepdog: fix co_recv coroutine context

2012-02-10 Thread Kevin Wolf
From: MORITA Kazutaka The co_recv coroutine has two things that will try to enter it: 1. The select(2) read callback on the sheepdog socket. 2. The aio_add_request() blocking operations, including a coroutine mutex. This patch fixes it by setting NULL to co_recv before sending data. I

[Qemu-devel] [PATCH 13/15] AHCI: Fix port reset race

2012-02-10 Thread Kevin Wolf
From: Alexander Graf bdrv_aio_cancel() can trigger bdrv_aio_flush() which makes all aio that is currently in flight finish. So what we do is: port reset detect ncq in flight cancel ncq delete ncq sg list at which point we have double freed the sg list. Instead, with this patch we do:

Re: [Qemu-devel] [PATCH 5/5] raw-posix: unmount CD-ROM filesystem via udisks

2012-02-10 Thread Markus Armbruster
Paolo Bonzini writes: > We need to use O_EXCL in order to suppress event generation in the > kernel. However, O_EXCL by definition fails when the CD-ROM drive > is mounted. Automatically unmount it when it is passed through to > the guest. I'm not sure automatic unmount is worth the trouble, a

[Qemu-devel] [PATCH 08/28] usb-hub: implement find_device

2012-02-10 Thread Gerd Hoffmann
Implement the find_device callback for the usb hub. It'll loop over all ports, calling usb_find_device for all enabled ports until it finds a matching device. Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --gi

[Qemu-devel] [PATCH v4 11/11] trace: [tracetool] Add error-reporting functions

2012-02-10 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 27 +++ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index 1134544..7053a74 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -12,6 +12,

[Qemu-devel] [PATCH 10/28] usb-uhci: switch to usb_find_device()

2012-02-10 Thread Gerd Hoffmann
Switch over UHCI to use the new usb_find_device() function for device lookup. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 45 +++-- 1 files changed, 15 insertions(+), 30 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 407e0f3..a1f597a

[Qemu-devel] [PATCH 7/9] net: remove extra spaces in help messages

2012-02-10 Thread Stefan Hajnoczi
From: Benjamin MARSILI Signed-off-by: Benjamin MARSILI Signed-off-by: Stefan Hajnoczi --- net/socket.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/socket.c b/net/socket.c index d4c2002..0bcf229 100644 --- a/net/socket.c +++ b/net/socket.c @@ -664,8 +664,

  1   2   3   >