Re: [Qemu-devel] [PATCH 09/10] memory: use a MemoryListener for core memory map updates too

2012-02-08 Thread Paolo Bonzini
On 02/08/2012 04:27 PM, Avi Kivity wrote: +static void core_log_stop(MemoryListener *listener, + MemoryRegionSection *section) +{ +} + +static void core_log_sync(MemoryListener *listener, + MemoryRegionSection *section) +{ +} + Why not wrapping

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions

2012-02-08 Thread Thomas Huth
Am Thu, 9 Feb 2012 11:26:09 +1100 schrieb David Gibson : > On Wed, Feb 08, 2012 at 02:27:35PM +0100, Thomas Huth wrote: > > Am Wed, 8 Feb 2012 21:48:40 +1100 > > schrieb David Gibson : > > > > > On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote: > > > > On Wed, 8 Feb 2012, David Gibson wrote:

Re: [Qemu-devel] spawning and killing threads in qemu

2012-02-08 Thread Paolo Bonzini
On 02/09/2012 03:40 AM, Xin Tong wrote: can you show me where these threads get created in the qemu code ? It's in posix-aio-compat.c. The code is invoked by block/raw-posix.c. Paolo

Re: [Qemu-devel] [PATCH v2 00/15] SCSI s/g + SCSI migration + virtio-scsi

2012-02-08 Thread Paolo Bonzini
On 02/09/2012 06:46 AM, Hu Tao wrote: > >I've re-tested today, with host kernel 2.6.35.6-45.fc14.x86_64, > >2.6.32-71.el6.x86_64, 3.1.0 and 3.3.0-rc1+, qemu version and guest > >configuration remain the same, including guest kernel. It apears > >that the problem appears only when the host ker

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Evgeny Voevodin
On 02/09/2012 10:18 AM, Evgeny Voevodin wrote: On 02/09/2012 10:15 AM, Peter Maydell wrote: On 9 February 2012 06:13, Evgeny Voevodin wrote: It seems that we have to rebase our exynos boards again ). So, am I right supposing that exynos will not be applied until all QOM patch sets landed? Ant

[Qemu-devel] [PATCH] hw/arm_sysctl: Drop legacy init function

2012-02-08 Thread Peter Maydell
Drop the legacy init function arm_sysctl_init(), since it has no users left any more. This allows us to drop the awkward '1' from the actual device init function. Signed-off-by: Peter Maydell --- The legacy function also had the 'set property after init' bug (in fact this is the original source f

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Evgeny Voevodin
On 02/09/2012 10:15 AM, Peter Maydell wrote: On 9 February 2012 06:13, Evgeny Voevodin wrote: It seems that we have to rebase our exynos boards again ). So, am I right supposing that exynos will not be applied until all QOM patch sets landed? Anthony claims there aren't any more QOM patchsets

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Peter Maydell
On 9 February 2012 06:13, Evgeny Voevodin wrote: > It seems that we have to rebase our exynos boards again ). So, am I right > supposing that exynos will not be applied until all QOM patch sets landed? Anthony claims there aren't any more QOM patchsets which touch all the files in the tree, so no

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Evgeny Voevodin
On 02/09/2012 10:04 AM, Peter Maydell wrote: On 9 February 2012 05:16, Evgeny Voevodin wrote: Since last QOM patch set landed into master, realview-pbx-a9, realview-eb-mpcore (suppose that other too) abort with error: qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp' fail

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Peter Maydell
On 9 February 2012 05:16, Evgeny Voevodin wrote: > Since last QOM patch set landed into master, realview-pbx-a9, > realview-eb-mpcore (suppose that other too) abort with error: > > qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp' > failed. Incidentally, this is a rather unh

[Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after

2012-02-08 Thread Peter Maydell
The ARM devboard models (vexpress-a9, realview, versatilepb, etc) were accidentally trying to set one of the arm_sysctl properties after device init. This has now become a fatal error; set the property before device init where it should be done instead. Signed-off-by: Peter Maydell --- If somebod

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Peter Maydell
On 9 February 2012 05:16, Evgeny Voevodin wrote: > Since last QOM patch set landed into master, realview-pbx-a9, > realview-eb-mpcore (suppose that other too) abort with error: > > qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp' > failed. > Aborted The realview etc board m

Re: [Qemu-devel] [PATCH v2 00/15] SCSI s/g + SCSI migration + virtio-scsi

2012-02-08 Thread Hu Tao
On Tue, Jan 31, 2012 at 01:36:04PM +0100, Paolo Bonzini wrote: > On 01/30/2012 10:33 AM, Hu Tao wrote: > >>> I cannot reproduce this with a 100G qcow2 image (created with > >>> "qemu-img create scsi.qcow2 100G" just before launching the host), > >>> with a partition starting at sector 2048 and e

[Qemu-devel] Broken realview

2012-02-08 Thread Evgeny Voevodin
Since last QOM patch set landed into master, realview-pbx-a9, realview-eb-mpcore (suppose that other too) abort with error: qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp' failed. Aborted Bisect result: 9b170e60adc6dc01564128cf09f96ec923ed6526 is the first bad commit

[Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies)

2012-02-08 Thread David Gibson
In kvm-all.c we store an ioctl cmd number in the irqchip_inject_ioctl field of KVMState, which has type 'int'. This seems to make sense since the ioctl() man page says that the cmd parameter has type int. However, the kernel treats ioctl numbers as unsigned - sys_ioctl() takes an unsigned int, an

Re: [Qemu-devel] [PATCH 1/3] Device isolation group infrastructure (v3)

2012-02-08 Thread David Gibson
On Wed, Feb 08, 2012 at 04:27:48PM +0100, Joerg Roedel wrote: > On Wed, Feb 01, 2012 at 03:46:52PM +1100, David Gibson wrote: > > In order to safely drive a device with a userspace driver, or to pass > > it through to a guest system, we must first make sure that the device > > is isolated in such a

[Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a fraction of the memory

2012-02-08 Thread Wen Congyang
Signed-off-by: Wen Congyang --- dump.c | 206 -- hmp-commands.hx |6 +- hmp.c| 13 +++- memory_mapping.c | 27 +++ memory_mapping.h |2 + qapi-schema.json |6 ++- qmp-commands.hx |4 +- 7 files ch

[Qemu-devel] [RFC][PATCH 15/16 v6] auto cancel dumping after vm state is changed to run

2012-02-08 Thread Wen Congyang
The command dump does not support to dump while vm is running. If the user resume the vm, we should auto cancel dumping and set the status to failed. Signed-off-by: Wen Congyang --- dump.c | 19 +++ vl.c |5 +++-- 2 files changed, 22 insertions(+), 2 deletions(-) diff -

[Qemu-devel] [RFC][PATCH 14/16 v6] support to query dumping status

2012-02-08 Thread Wen Congyang
Add API to allow the user to query dumping status. Signed-off-by: Wen Congyang --- dump.c | 32 hmp-commands.hx |2 ++ hmp.c| 17 + hmp.h|1 + monitor.c|7 +++ qapi-schema.json | 26

[Qemu-devel] [RFC][PATCH 13/16 v6] support to set dumping speed

2012-02-08 Thread Wen Congyang
Add API to allow the user to control dumping speed Signed-off-by: Wen Congyang --- dump.c | 12 hmp-commands.hx | 15 +++ hmp.c|6 ++ hmp.h|1 + qapi-schema.json | 15 +++ qmp-commands.hx | 22 ++

[Qemu-devel] [RFC][PATCH 12/16 v6] support to cancel the current dumping

2012-02-08 Thread Wen Congyang
Add API to allow the user to cancel the current dumping. Signed-off-by: Wen Congyang --- dump.c | 13 + hmp-commands.hx | 14 ++ hmp.c|5 + hmp.h|1 + qapi-schema.json | 13 + qmp-commands.hx | 21 +++

[Qemu-devel] [RFC][PATCH 11/16 v6] support detached dump

2012-02-08 Thread Wen Congyang
Let the user to choose whether to block other monitor command while dumping. Signed-off-by: Wen Congyang --- dump.c | 12 hmp-commands.hx |8 hmp.c|3 ++- qapi-schema.json |3 ++- qmp-commands.hx |7 --- 5 files changed, 20 inse

[Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background

2012-02-08 Thread Wen Congyang
The new monitor command dump may take long time to finish. So we need run it at the background. Signed-off-by: Wen Congyang --- dump.c | 155 1 files changed, 136 insertions(+), 19 deletions(-) diff --git a/dump.c b/dump.c index

[Qemu-devel] [RFC][PATCH 09/16 v6] introduce a new monitor command 'dump' to dump guest's memory

2012-02-08 Thread Wen Congyang
Signed-off-by: Wen Congyang --- Makefile.target |8 +- dump.c | 590 ++ dump.h |3 + hmp-commands.hx | 16 ++ hmp.c|9 + hmp.h|1 + monitor.c|3 + qapi-schema.json |

[Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-08 Thread Wen Congyang
Dump info contains: endian, class and architecture. The next patch will use these information to create vmcore. Signed-off-by: Wen Congyang --- cpu-all.h |3 +++ dump.h | 10 ++ target-i386/arch-dump.c | 34 ++ 3 file

[Qemu-devel] [RFC][PATCH 07/16 v6] target-i386: Add API to add extra memory mapping

2012-02-08 Thread Wen Congyang
Crash needs extra memory mapping to determine phys_base. Signed-off-by: Wen Congyang --- cpu-all.h |2 ++ target-i386/arch-dump.c | 43 +++ 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index efb5

[Qemu-devel] [RFC][PATCH 06/16 v6] target-i386: Add API to write elf notes to core file

2012-02-08 Thread Wen Congyang
The core file contains register's value. These APIs write registers to core file, and them will be called in the following patch. Signed-off-by: Wen Congyang --- cpu-all.h |6 + target-i386/arch-dump.c | 243 +++ 2 files changed, 249

[Qemu-devel] [RFC][PATCH 05/16 v6] Add API to get memory mapping

2012-02-08 Thread Wen Congyang
Add API to get all virtual address and physical address mapping. If there is no virtual address for some physical address, the virtual address is 0. Signed-off-by: Wen Congyang --- memory_mapping.c | 65 ++ memory_mapping.h |1 + 2 files

[Qemu-devel] [RFC][PATCH 04/16 v6] target-i386: implement cpu_get_memory_mapping()

2012-02-08 Thread Wen Congyang
Walk cpu's page table and collect all virtual address and physical address mapping. Then, add these mapping into memory mapping list. Signed-off-by: Wen Congyang --- Makefile.target |2 +- cpu-all.h |7 ++ target-i386/arch-dump.c | 254

[Qemu-devel] [RFC][PATCH 03/16 v6] Add API to check whether a physical address is I/O address

2012-02-08 Thread Wen Congyang
This API will be used in the following patch. Signed-off-by: Wen Congyang --- cpu-common.h |2 ++ exec.c | 16 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index a40c57d..d047137 100644 --- a/cpu-common.h +++ b/cpu-commo

[Qemu-devel] [RFC][PATCH 02/16 v6] Add API to create memory mapping list

2012-02-08 Thread Wen Congyang
The memory mapping list stores virtual address and physical address mapping. The folloing patch will use this information to create PT_LOAD in the vmcore. Signed-off-by: Wen Congyang --- Makefile.target |1 + memory_mapping.c | 130 ++ me

[Qemu-devel] [RFC][PATCH 01/16 v6] monitor: introduce qemu_suspend_monitor()/qemu_resume_monitor()

2012-02-08 Thread Wen Congyang
Sync command needs these two APIs to suspend/resume monitor. Signed-off-by: Wen Congyang --- monitor.c | 27 +++ monitor.h |2 ++ 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 11639b1..7e72739 100644 --- a/monitor.c +++

[Qemu-devel] [RFC][PATCH 00/16 v6] introducing a new, dedicated memory dump mechanism

2012-02-08 Thread Wen Congyang
Hi, all 'virsh dump' can not work when host pci device is used by guest. We have discussed this issue here: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html We have determined to introduce a new command dump to dump memory. The core file's format can be elf. Note: 1. The gue

Re: [Qemu-devel] spawning and killing threads in qemu

2012-02-08 Thread Xin Tong
can you show me where these threads get created in the qemu code ? Thanks Xin On Tue, Feb 7, 2012 at 5:25 AM, Stefan Hajnoczi wrote: > 2012/2/7 陳韋任 : >> Hi Stefan, >> >>  Thanks for the explanation. :) >> >>> >   Qemu 1.0 enable IO thread by default, I think that's why you can see >>> > ther

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
Alrighty, So it seems like the bootloader as a device idea has some support, just need to work out a few implementaiton details. It seems the consensus is that machine models will instantiate the device. The latest idea is the machine model will pass some of core props to the bootloader while othe

[Qemu-devel] [Bug 928204] Re: build failure gentoo

2012-02-08 Thread Iggy
Does the same happen in a release version of Qemu? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/928204 Title: build failure gentoo Status in QEMU: New Bug description: gcc 4.5.3, gentoo linu

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions

2012-02-08 Thread David Gibson
On Wed, Feb 08, 2012 at 02:27:35PM +0100, Thomas Huth wrote: > Am Wed, 8 Feb 2012 21:48:40 +1100 > schrieb David Gibson : > > > On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote: > > > On Wed, 8 Feb 2012, David Gibson wrote: > > > > > > > From: Thomas Huth > > > > > > > > These instructions

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-08 Thread Paul Brook
> +static void i8042_isa_mouse_fake_event(void *opaque, int n, int level) > { > ISADevice *dev = opaque; > KBDState *s = &(DO_UPCAST(ISAKBDState, dev, dev)->kbd); > > -ps2_mouse_fake_event(s->mouse); > +if (level) { > +ps2_mouse_fake_event(s->mouse); > +} > } >...

Re: [Qemu-devel] Support for multiboot images in elf64 (EM_X86_64) format

2012-02-08 Thread Paul Brook
> > starting your own toy kernel is a fun thing to do and there are many > > tutorials out there on how to do it. Unfortunately when one wants to > > write a kernel in 64bit it becomes much harder because one can't > > compile 64bit code as elf32 image and converting a elf64 image to > > elf32 form

Re: [Qemu-devel] [PATCH] make: Remove duplicate use of GLIB_CFLAGS

2012-02-08 Thread malc
On Wed, 8 Feb 2012, Stefan Weil wrote: > Makefile, Makefile.hw, Makefile.target and libcacard/Makefile > added GLIB_CFLAGS to QEMU_CFLAGS. > > Makefile.objs does this, too, and is included by all other > Makefiles, so GLIB_CFLAGS were added twice (reported by malc). > Thank you. If nobody obje

Re: [Qemu-devel] Help - `flush_icache_range' MacPPC

2012-02-08 Thread Alexander Graf
On 09.02.2012, at 00:54, Scott Wood wrote: > On 02/08/2012 05:42 PM, Alexander Graf wrote: >> >> On 09.02.2012, at 00:29, Scott Wood wrote: >> >>> On 02/07/2012 04:57 PM, Alexander Graf wrote: Eh, this patch: diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index f5

Re: [Qemu-devel] Help - `flush_icache_range' MacPPC

2012-02-08 Thread Scott Wood
On 02/08/2012 05:42 PM, Alexander Graf wrote: > > On 09.02.2012, at 00:29, Scott Wood wrote: > >> On 02/07/2012 04:57 PM, Alexander Graf wrote: >>> Eh, this patch: >>> >>> diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c >>> index f5d9bf3..f9793e6 100644 >>> --- a/tcg/ppc/tcg-target.c >>>

Re: [Qemu-devel] [PATCH] Change "-net tap, helper" to "-net tap, bridgehelper"

2012-02-08 Thread Paul Brook
> The purpose of the "helper" option for "-net tap" isn't obvious > based on its name. This patch changes the option name to > "bridgehelper" to make its purpose more self-documenting. > > With this patch, a typical invocation will be similar to one of the > following (where the default bridge is

Re: [Qemu-devel] Help - `flush_icache_range' MacPPC

2012-02-08 Thread Alexander Graf
On 09.02.2012, at 00:29, Scott Wood wrote: > On 02/07/2012 04:57 PM, Alexander Graf wrote: >> >> On 07.02.2012, at 23:29, Brad Smith wrote: >> >>> On 07/02/12 5:12 PM, malc wrote: On Tue, 7 Feb 2012, Alexander Graf wrote: > > On 07.02.2012, at 22:12, malc wrote: > >

Re: [Qemu-devel] Help - `flush_icache_range' MacPPC

2012-02-08 Thread Scott Wood
On 02/07/2012 04:57 PM, Alexander Graf wrote: > > On 07.02.2012, at 23:29, Brad Smith wrote: > >> On 07/02/12 5:12 PM, malc wrote: >>> On Tue, 7 Feb 2012, Alexander Graf wrote: >>> On 07.02.2012, at 22:12, malc wrote: > On Tue, 7 Feb 2012, Alexander Graf wrote: > >> >>>

Re: [Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps

2012-02-08 Thread Richard Henderson
On 02/08/2012 07:27 AM, Avi Kivity wrote: > This patchset makes the memory core (memory.c) talk to the backend (in exec.c) > via a MemoryListener instead of named functions. > > While the motivation for this is to simplify the memory core, it also enables > optimizing accelerators some more (by ha

Re: [Qemu-devel] [PATCH 1/3] Device isolation group infrastructure (v3)

2012-02-08 Thread Benjamin Herrenschmidt
On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote: > Again, device grouping is done by the IOMMU drivers, so this all > belongs > into the generic iommu-code rather than the driver core. > > I think it makes sense to introduce a device->iommu pointer which > depends on CONFIG_IOMMU_API and put

[Qemu-devel] [PATCH] make: Remove duplicate use of GLIB_CFLAGS

2012-02-08 Thread Stefan Weil
Makefile, Makefile.hw, Makefile.target and libcacard/Makefile added GLIB_CFLAGS to QEMU_CFLAGS. Makefile.objs does this, too, and is included by all other Makefiles, so GLIB_CFLAGS were added twice (reported by malc). Signed-off-by: Stefan Weil --- Makefile |2 -- Makefile.hw

Re: [Qemu-devel] [PATCH 1/3] Device isolation group infrastructure (v3)

2012-02-08 Thread Benjamin Herrenschmidt
On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote: > Again, device grouping is done by the IOMMU drivers, so this all > belongs > into the generic iommu-code rather than the driver core. Except that there isn't really a "generic iommu code"... discovery, initialization & matching of iommu vs.

[Qemu-devel] gdb testsuite with remote target of qemu in linux-user mode?

2012-02-08 Thread Greg McGary
Does anyone use gdb testsuite with remote target of qemu in linux-user mode? I see no mention of qemu as a remote simulator in dejagnu, or in gdb/testsuite. I threw together a qemu.exp to do this, and it seems to work OK everywhere except with mi-support.exp, which does not appear to have infrast

[Qemu-devel] [PATCH 4/6] balloon: Refactor kvm sync mmu check

2012-02-08 Thread Luiz Capitulino
qmp_query_balloon() and qmp_balloon() perform the same check, move it to check_kvm_sync_mmu(). Signed-off-by: Luiz Capitulino --- balloon.c | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/balloon.c b/balloon.c index b32b487..d340ae3 100644 --- a/balloon.c

[Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-08 Thread Luiz Capitulino
This commit adds a QMP API for the guest provided memory statistics (long disabled by commit 07b0403dfc2b2ac179ae5b48105096cc2d03375a). The approach taken by the original commit (625a5befc2e3200b396594f002218d235e375da5) was to extend the query-balloon command. It introduced a severe bug though: q

[Qemu-devel] [PATCH 5/6] balloon: Drop old stats interface

2012-02-08 Thread Luiz Capitulino
It has never been used and next patches will introduce a new, usable interface. Note that dropping this won't break compatibility because all fields are optional. Signed-off-by: Luiz Capitulino --- hmp.c| 25 + qapi-schema.json | 21 +

[Qemu-devel] [PATCH 3/6] balloon: Rename QEMUBalloonStatus to QEMUBalloonInfo

2012-02-08 Thread Luiz Capitulino
Next commit will introduce the QEMUBalloonStats type, it can cause confusion with QEMUBalloonStatus. Also, QEMUBalloonInfo matches better with BalloonInfo, which is the type used to return balloon information in QMP. Signed-off-by: Luiz Capitulino --- balloon.c | 18 +

[Qemu-devel] [PATCH 2/6] balloon: Drop unused include

2012-02-08 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- balloon.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/balloon.h b/balloon.h index b60fd5d..17fe300 100644 --- a/balloon.h +++ b/balloon.h @@ -14,7 +14,6 @@ #ifndef _QEMU_BALLOON_H #define _QEMU_BALLOON_H -#include "monitor.h" #i

[Qemu-devel] [PATCH 1/6] balloon: qmp_balloon(): Use error_set()

2012-02-08 Thread Luiz Capitulino
Commit d72f326431e280a619a0fd55e27d3737747f8178 converted the balloon command to the QAPI, but forgot to convert one qerror_report() usage. Fix it. Signed-off-by: Luiz Capitulino --- balloon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/balloon.c b/balloon.c index 0

[Qemu-devel] [PATCH 0/6] QMP: add balloon-get-memory-stats command

2012-02-08 Thread Luiz Capitulino
This series re-enables the balloon memory statistics feature disabled long ago by commit 11724ff. The feature has been disabled because it added a severe bug: query-balloon would hang if the guest didn't respond. This, in turn, would also cause a hang in libvirt. To avoid that bug, the solution i

[Qemu-devel] [PATCH 2/3] kvm: Implement kvm_irqchip_in_kernel like kvm_enabled

2012-02-08 Thread Marcelo Tosatti
From: Jan Kiszka To both avoid that kvm_irqchip_in_kernel always has to be paired with kvm_enabled and that the former ends up in a function call, implement it like the latter. This means keeping the state in a global variable and defining kvm_irqchip_in_kernel as a preprocessor macro. Signed-of

[Qemu-devel] [PATCH 0/3] [PULL] qemu-kvm.git uq/master queue

2012-02-08 Thread Marcelo Tosatti
The following changes since commit cf4dc461a4cfc3e056ee24edb26154f4d34a6278: Restore consistent formatting (2012-02-07 22:11:04 +0400) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Jan Kiszka (3): kvm: Allow to set shadow MMU size

[Qemu-devel] [PATCH 3/3] apic: Fix legacy vmstate loading for KVM

2012-02-08 Thread Marcelo Tosatti
From: Jan Kiszka Also in case of loading pre-vmstate machines, we also need to open-code the reading of the timer expires value and instead call the post_load callback to apply it (or not). This fixes loading of legacy states into the KVM APIC. Reported-by: Paolo Bonzini Signed-off-by: Jan Kisz

[Qemu-devel] [PATCH 1/3] kvm: Allow to set shadow MMU size

2012-02-08 Thread Marcelo Tosatti
From: Jan Kiszka Introduce the KVM-specific machine option kvm_shadow_mem. It allows to set a custom shadow MMU size for the virtual machine. This is useful for stress testing e.g. Only x86 supports this for now, but it is in principle a generic concept for all targets with shadow MMUs. Signed-

[Qemu-devel] [Bug 928204] Re: build failure gentoo

2012-02-08 Thread Peter Johnson
qemu 0.11.1 package: CCx86_64-linux-user/host-utils.o CCx86_64-linux-user/tcg/tcg.o CCx86_64-linux-user/tcg/tcg-runtime.o CCx86_64-linux-user/fpu/softfloat-native.o CCx86_64-linux-user/op_helper.o {standard input}: Assembler messages: {standard input}:3270769: Warning:

Re: [Qemu-devel] [PATCH 0/4] uq/master: Introduce KVM PIT support

2012-02-08 Thread Marcelo Tosatti
On Sun, Feb 05, 2012 at 11:46:26AM +0100, Jan Kiszka wrote: > This adds another piece of qemu-kvm to upstream: The accelerated > in-kernel model of the i8254. It does this in the same fashion as the > interrupt controllers were already introduced. And it even has one bug > less than qemu-kvm: PC sp

[Qemu-devel] [PATCH 4/5] configure: probe for dbus

2012-02-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 763db24..0f305cb 100755 --- a/configure +++ b/configure @@ -119,6 +119,7 @@ curl="" curses="" docs="" fdt="" +d

[Qemu-devel] [PATCH 5/5] raw-posix: unmount CD-ROM filesystem via udisks

2012-02-08 Thread Paolo Bonzini
We need to use O_EXCL in order to suppress event generation in the kernel. However, O_EXCL by definition fails when the CD-ROM drive is mounted. Automatically unmount it when it is passed through to the guest. Signed-off-by: Paolo Bonzini --- Makefile.objs|3 + block.c

[Qemu-devel] [PATCH 2/5] raw-posix: put Linux fd fields into a union

2012-02-08 Thread Paolo Bonzini
We will add CDROM-specific fields in the next patch, reuse the space in the struct. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 38 +- 1 files changed, 21 insertions(+), 17 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 2a5b6

[Qemu-devel] [PATCH 3/5] raw-posix: keep complete control of door locking if possible

2012-02-08 Thread Paolo Bonzini
Try to open the disk O_EXCL so that udev will not receive eject request and media change events. These will work fine with SCSI passthrough. With IDE and scsi-disk the user will need to use the monitor in order to eject the disk and put it back (respectively with the eject and change commands).

[Qemu-devel] [PATCH 1/5] raw-posix: always prefer specific devices to hdev

2012-02-08 Thread Paolo Bonzini
There is no need to try matching device names; using ioctls is more effective. So, always return a low priority from the generic hdev_probe_device and let the ioctl tests override it. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 12 +++- 1 files changed, 3 insertions(+), 9 del

[Qemu-devel] [PATCH 0/5] Fix CD-ROM door with SCSI passthrough

2012-02-08 Thread Paolo Bonzini
This series makes it possible to use CD drives reliably with scsi-block. IDE and scsi-disk require more work, because the eject button is not usable. CD drives are unmounted at VM start and opened exclusively. The locking state is saved and restored for extra kindness. However, drives are not re

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-08 Thread Alan Cox
> >register_pio_hook_ptr_r(PIO_IDE, SIZE_BYTE,&s->cmd[0]); > >for (i = 1; i< 7; i++) { > > register_pio_hook_ptr_r(PIO_IDE + i, SIZE_BYTE,&s->cmd[i]); > > register_pio_hook_ptr_w(PIO_IDE + i, SIZE_BYTE,&s->cmd[i]); > >} > > You can't easily serialize updates to that address

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-08 Thread Alan Cox
> If the fd overhead really is a problem, perhaps the fd could be retained > for setup operations, and omitted only on calls that require a vcpu to > have been already set up on the current thread? Quite frankly I'd like to have an fd because it means you've got a meaningful way of ensuring that i

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-08 Thread Scott Wood
On 02/07/2012 06:28 AM, Anthony Liguori wrote: > On 02/06/2012 01:46 PM, Scott Wood wrote: >> On 02/03/2012 04:52 PM, Anthony Liguori wrote: >>> On 02/03/2012 12:07 PM, Eric Northup wrote: How would the ability to use sys_kvm_* be regulated? >>> >>> Why should it be regulated? >>> >>> It's not

Re: [Qemu-devel] [PATCH uq/master] apic: Fix legacy vmstate loading for KVM

2012-02-08 Thread Marcelo Tosatti
On Sun, Feb 05, 2012 at 12:45:20PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Also in case of loading pre-vmstate machines, we also need to open-code > the reading of the timer expires value and instead call the post_load > callback to apply it (or not). This fixes loading of legacy states i

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Anthony Liguori
On 02/08/2012 10:15 AM, Paul Brook wrote: Ok, that sounds more workable :). So i would add my initrd_addr property to the bootloader as a qdev prop as I suggested before, then something like: qemu-system-arm -M verstailepb -property /foo/bar/arm_linux_loader.0,initrd_addr=0x1000 Yes. Ther

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Anthony Liguori
On 02/08/2012 10:03 AM, Peter Crosthwaite wrote: 2012/2/9 Paul Brook So here are some of the problems im trying to solve with the bootloader: Smp bootstrap secondary CPUs while loading an elf (currently elfs will be assumed to be not kernels). Change the kernel, initrd and dtb load address on

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Paul Brook
> Ok, that sounds more workable :). So i would add my initrd_addr property to > the bootloader as a qdev prop as I suggested before, then something like: > > qemu-system-arm -M verstailepb -property > /foo/bar/arm_linux_loader.0,initrd_addr=0x1000 Yes. There are various implementation/syntax

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
2012/2/9 Paul Brook > > So here are some of the problems im trying to solve with the bootloader: > > > > Smp bootstrap secondary CPUs while loading an elf (currently elfs will be > > assumed to be not kernels). > > Change the kernel, initrd and dtb load address on the command line. > > Use my own

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Paul Brook
> So here are some of the problems im trying to solve with the bootloader: > > Smp bootstrap secondary CPUs while loading an elf (currently elfs will be > assumed to be not kernels). > Change the kernel, initrd and dtb load address on the command line. > Use my own SMP secondary bootloop. > > My

[Qemu-devel] [PATCH 08/10] memory: don't pass ->readable attribute to cpu_register_physical_memory_log

2012-02-08 Thread Avi Kivity
It can be derived from the MemoryRegion itself (which is why it is not used there). Signed-off-by: Avi Kivity --- exec-obsolete.h |2 +- exec.c |2 +- memory.c|4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exec-obsolete.h b/exec-obsolete.h in

[Qemu-devel] [PATCH 10/10] memory: drop AddressSpaceOps

2012-02-08 Thread Avi Kivity
All functionality has been moved to various MemoryListeners. Signed-off-by: Avi Kivity --- memory.c | 56 ++-- 1 files changed, 2 insertions(+), 54 deletions(-) diff --git a/memory.c b/memory.c index 4e7a90b..4f854d4 100644 --- a/memory.c ++

[Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps

2012-02-08 Thread Avi Kivity
This patchset makes the memory core (memory.c) talk to the backend (in exec.c) via a MemoryListener instead of named functions. While the motivation for this is to simplify the memory core, it also enables optimizing accelerators some more (by having a tcg MemoryListener to do tcg specific core) a

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Anthony Liguori
On 02/08/2012 09:36 AM, Andreas Färber wrote: Am 08.02.2012 16:23, schrieb Anthony Liguori: On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Andreas Färber
Am 08.02.2012 16:23, schrieb Anthony Liguori: > On 02/08/2012 09:04 AM, malc wrote: >> On Wed, 8 Feb 2012, Andreas F?rber wrote: >> >>> Arbitrarily reformatting your files is not okay. If you want a different >>> formatting, you need to fix checkpatch.pl first to not error on that >>> formatting in

Re: [Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps

2012-02-08 Thread Avi Kivity
On 02/08/2012 05:27 PM, Avi Kivity wrote: > This patchset makes the memory core (memory.c) talk to the backend (in exec.c) > via a MemoryListener instead of named functions. > > While the motivation for this is to simplify the memory core, it also enables > optimizing accelerators some more (by hav

[Qemu-devel] [PATCH 09/10] memory: use a MemoryListener for core memory map updates too

2012-02-08 Thread Avi Kivity
This transforms memory.c into a library which can then be unit tested easily, by feeding it inputs and listening to its outputs. Signed-off-by: Avi Kivity --- exec-obsolete.h |3 ++ exec.c | 75 +++ memory.c| 27 +--

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Andreas Färber
Am 08.02.2012 16:04, schrieb malc: > On Wed, 8 Feb 2012, Andreas F?rber wrote: > >> Arbitrarily reformatting your files is not okay. If you want a different >> formatting, you need to fix checkpatch.pl first to not error on that >> formatting in your files. > > It was always formatter like this (

[Qemu-devel] [PATCH 07/10] memory: add a readonly attribute to MemoryRegionSection

2012-02-08 Thread Avi Kivity
.readonly cannot be obtained from the MemoryRegion, since it is inherited from aliases (so you can have a MemoryRegion mapped RW at one address and RO at another). Record it in a MemoryRegionSection for listeners. Signed-off-by: Avi Kivity --- memory.c |5 + memory.h |2 ++ 2 files

[Qemu-devel] [PATCH 01/10] ioport: change portio_list not to use memory_region_set_offset()

2012-02-08 Thread Avi Kivity
memory_region_set_offset() will be going away soon, so don't use it. Use an alias instead. Signed-off-by: Avi Kivity --- ioport.c | 25 +++-- ioport.h |1 + 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/ioport.c b/ioport.c index 36fa3a4..505b252 100644

[Qemu-devel] [PATCH 03/10] memory: add shorthand for invoking a callback on all listeners

2012-02-08 Thread Avi Kivity
Signed-off-by: Avi Kivity --- memory.c | 54 +++--- 1 files changed, 19 insertions(+), 35 deletions(-) diff --git a/memory.c b/memory.c index 382dded..6afe414 100644 --- a/memory.c +++ b/memory.c @@ -678,31 +678,23 @@ static void address_space_up

[Qemu-devel] [PATCH 06/10] memory: move ioeventfd ops to MemoryListener

2012-02-08 Thread Avi Kivity
This way the accelerator (kvm) can handle them directly. Signed-off-by: Avi Kivity --- hw/vhost.c | 14 ++ kvm-all.c | 78 memory.c | 74 ++--- memory.h |4 +++

[Qemu-devel] [PATCH 02/10] memory: remove memory_region_set_offset()

2012-02-08 Thread Avi Kivity
memory_region_set_offset() complicates the API, and has been deprecated since its introduction. Now that it is no longer used, remove it. Signed-off-by: Avi Kivity --- memory.c | 26 ++ memory.h |9 - 2 files changed, 10 insertions(+), 25 deletions(-) diff

[Qemu-devel] [PATCH 04/10] memory: switch memory listeners to a QTAILQ

2012-02-08 Thread Avi Kivity
This allows reverse iteration, which in turns allows consistent ordering among multiple listeners: l1->add l2->add l2->del l1->del Signed-off-by: Avi Kivity --- hw/vhost.c |1 + kvm-all.c |1 + memory.c | 70 ++-- memo

[Qemu-devel] [PATCH 05/10] memory: code motion: move MEMORY_LISTENER_CALL()

2012-02-08 Thread Avi Kivity
So it can be used in earlier code. Signed-off-by: Avi Kivity --- memory.c | 64 +++--- 1 files changed, 32 insertions(+), 32 deletions(-) diff --git a/memory.c b/memory.c index cb2b4f1..a1013bc 100644 --- a/memory.c +++ b/memory.c @@ -82

Re: [Qemu-devel] [PATCH 1/3] Device isolation group infrastructure (v3)

2012-02-08 Thread Joerg Roedel
On Wed, Feb 01, 2012 at 03:46:52PM +1100, David Gibson wrote: > In order to safely drive a device with a userspace driver, or to pass > it through to a guest system, we must first make sure that the device > is isolated in such a way that it cannot interfere with other devices > on the system. Thi

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Anthony Liguori
On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: malc, Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error on that formatting in your files. It was always formatter like this (inter

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-02-08 Thread Gerd Hoffmann
On 02/08/12 01:17, Rusty Russell wrote: > As featured on: > https://bugs.launchpad.net/qemu-linaro/+bug/928432 > > Since we compile with -Werror, the presence of spice headers breaks > compile. Yet except for x86-64, it doesn't compile, doesn't work, isn't > supported. See: http://spice-

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
So here are some of the problems im trying to solve with the bootloader: Smp bootstrap secondary CPUs while loading an elf (currently elfs will be assumed to be not kernels). Change the kernel, initrd and dtb load address on the command line. Use my own SMP secondary bootloop. My intention with t

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Stefan Hajnoczi
On Wed, Feb 8, 2012 at 2:55 PM, Paolo Bonzini wrote: > On 02/08/2012 03:39 PM, Stefan Hajnoczi wrote: >> >> >>> >  What about taking the existing Ceph/RBD driver in QEMU and changing it >>> > to >>> >  support arbitrary image formats rather than just raw?  That sounds >>> > much much >>> >  easier

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread malc
On Wed, 8 Feb 2012, Andreas F?rber wrote: > malc, > > Arbitrarily reformatting your files is not okay. If you want a different > formatting, you need to fix checkpatch.pl first to not error on that > formatting in your files. It was always formatter like this (internally consistent), then others

Re: [Qemu-devel] [RFC Patch 4/7]Qemu: Framework for reopening image files safely

2012-02-08 Thread Kevin Wolf
Am 01.02.2012 04:06, schrieb Supriya Kannery: > Struct BDRVReopenState along with three reopen related functions > introduced for handling reopening of images safely. This can be > extended by each of the block drivers to reopen respective > image files. > > Signed-off-by: Supriya Kannery > > In

  1   2   >