Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-06 Thread Michael Ellerman
On Mon, 2012-02-06 at 13:46 -0600, Scott Wood wrote: > On 02/03/2012 04:52 PM, Anthony Liguori wrote: > > On 02/03/2012 12:07 PM, Eric Northup wrote: > >> On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivity wrote: > >> [...] > >>> > >>> Moving to syscalls avoids these problems, but introduces new ones: > >

[Qemu-devel] [RFC PATCH v2 3/4] cadence_gem: initial version of device model

2012-02-06 Thread Peter A. G. Crosthwaite
Device model for cadence gem ethernet controller. Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn --- removed global init function marked vmsd as unmigratable cleaned up debug messages Makefile.target |1 + hw/cadence_gem.c | 1229 ++

[Qemu-devel] [RFC PATCH v2 4/4] xilinx_zynq: machine model initial version

2012-02-06 Thread Peter A. G. Crosthwaite
Xilinx zynq-7000 machine model. Also includes device model for the zynq-specific system level control register (SLCR) module. Signed-off-by: Peter A. G. Crosthwaite --- changes since v1: Added gem init function remowed WDT instantiation Added maintainers information removed dead sys_id and proc_i

[Qemu-devel] [RFC PATCH v2 2/4] cadence_ttc: initial version of device model

2012-02-06 Thread Peter A. G. Crosthwaite
Implemented cadence Triple Timer Counter (TCC) Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn --- changes from v1 refactored event driven code marked vmsd as unmigratable Makefile.target |1 + hw/cadence_ttc.c | 399 ++

[Qemu-devel] [RFC PATCH v2 1/4] cadence_uart: initial version of device model

2012-02-06 Thread Peter A. G. Crosthwaite
Implemented cadence UART serial controller Signed-off-by: Peter A. G. Crosthwaite Signed-off-by: John Linn --- changes from v1: converted register file to array added vmsd state save/load support removed read side effects from CISR register Makefile.target |1 + hw/cadence_uart.c | 561

[Qemu-devel] [RFC PATCH v2 0/4]Zynq-7000 EPP platform model

2012-02-06 Thread Peter A. G. Crosthwaite
This is an RFC for a suite of Device models and a machine model for the Xilinx Zynq-7000 Extensible Processing Platform: http://www.xilinx.com/products/silicon-devices/epp/zynq-7000/index.htm This is an ARM based platform featuring embedded SoC peripherals. This patch series includes a minimal

[Qemu-devel] Would this introduce a competition?

2012-02-06 Thread Richard Yang
All I am reading the code ohci_frame_boundary() and found it will get a copy of the HCCA and process the interrupt ED list and then put it back. I am afraid, during this processing period, the kernel driver(hcd) will add other request to the interrupt ED list. So after qemu put the HCCA back, t

[Qemu-devel] [PATCH] Change "-net tap, helper" to "-net tap, bridgehelper"

2012-02-06 Thread Corey Bryant
The purpose of the "helper" option for "-net tap" isn't obvious based on its name. This patch changes the option name to "bridgehelper" to make its purpose more self-documenting. With this patch, a typical invocation will be similar to one of the following (where the default bridge is br0): qe

[Qemu-devel] [PATCH v2] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
guest-sync leaves it as an exercise to the user as to how to reliably obtain the response to guest-sync if the client had previously read in a partial response (due qemu-ga previously being restarted mid-"sentence" due to reboot, forced restart, etc). qemu-ga handles this situation on its end by h

[Qemu-devel] [PATCH v2 0/1] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
Sorry for the somewhat redundant cover letter, but needed to note that: This applies on top of "[PATCH v2 0/8] qemu-ga: add support for Windows", and can also be obtained from: git://github.com/mdroth/qemu.git qga-guest-sync-delimited CHANGES SINCE v1: - removed deprecation flag for guest-sync,

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-06 Thread Alexander Graf
On 03.02.2012, at 03:09, Anthony Liguori wrote: > On 02/02/2012 10:09 AM, Avi Kivity wrote: >> The kvm api has been accumulating cruft for several years now. This is >> due to feature creep, fixing mistakes, experience gained by the >> maintainers and developers on how to do things, ports to new

Re: [Qemu-devel] [PATCH 0/1] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
On Mon, Feb 06, 2012 at 06:07:34PM -0600, Michael Roth wrote: > Sorry for the somewhat redundant cover letter, but needed to note that: > > This applies on top of "[PATCH v2 0/8] qemu-ga: add support for Windows", and > can also be obtained from: > git://github.com/mdroth/qemu.git qga-guest-sync-d

Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-06 Thread Kevin O'Connor
On Mon, Feb 06, 2012 at 01:43:42PM -0200, Luiz Capitulino wrote: > "Kevin O'Connor" wrote: > > On Fri, Feb 03, 2012 at 05:16:27PM -0200, Luiz Capitulino wrote: > > > On Fri, 03 Feb 2012 11:23:05 -0600 > > > Michael Roth wrote: > > > > I'd been tracking Gerd's QMP wakeup series as the s3 resolutio

[Qemu-devel] [PATCH] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
guest-sync leaves it as an exercise to the user as to how to reliably obtain the response to guest-sync if the client had previously read in a partial response (due qemu-ga previously being restarted mid-"sentence" due to reboot, forced restart, etc). qemu-ga handles this situation on its end by h

[Qemu-devel] [PATCH 0/1] qemu-ga: add guest-sync-delimited

2012-02-06 Thread Michael Roth
Sorry for the somewhat redundant cover letter, but needed to note that: This applies on top of "[PATCH v2 0/8] qemu-ga: add support for Windows", and can also be obtained from: git://github.com/mdroth/qemu.git qga-guest-sync-delimited As noted in the commit there's a wiki write-up with more detai

[Qemu-devel] Unsubscription Confirmation

2012-02-06 Thread RealEstateMalaysian.com
Thank you for subscribing. You have now unsubscribed and no more messages will be sent.

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Charles Arnold
>>> On 2/6/2012 at 09:51 AM, in message <4f3004fc.7070...@redhat.com>, Kevin >>> Wolf wrote: > Am 06.02.2012 17:22, schrieb Charles Arnold: > On 2/6/2012 at 08:46 AM, in message <4f2ff5b9.9090...@redhat.com>, Kevin > Wolf >> wrote: >>> >>> Somehow you lost the ret = -EFBIG here. >>> >

Re: [Qemu-devel] [PATCH RFC v3 02/21] qom: Add QOM support to user emulators

2012-02-06 Thread Andreas Färber
Am 06.02.2012 20:16, schrieb Anthony Liguori: > On 02/02/2012 08:59 PM, Andreas Färber wrote: >> Link the Object base class and the module infrastructure for class >> registration. Call QOM module init. >> >> Signed-off-by: Andreas Färber >> Cc: Anthony Liguori > > If we're going to go down this r

Re: [Qemu-devel] [PATCH RFC v3 06/21] target-arm: Prepare model-specific class_init function

2012-02-06 Thread Andreas Färber
Am 07.02.2012 00:03, schrieb Anthony Liguori: > On 02/02/2012 08:59 PM, Andreas Färber wrote: >> This allows to share initialization between CPU models. >> >> Signed-off-by: Andreas Färber >> --- >> target-arm/cpu.c |5 + >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --g

Re: [Qemu-devel] [PATCH RFC v3 05/21] target-arm: Embed CPUARMState in QOM ARMCPU

2012-02-06 Thread Andreas Färber
Am 07.02.2012 00:00, schrieb Anthony Liguori: > On 02/02/2012 08:59 PM, Andreas Färber wrote: >> +static inline Object *arm_env_get_object(CPUARMState *env) >> +{ >> +return OBJECT((void *)(env) - offsetof(ARMCPU, env)); >> +} >> + >> +#define ENV_GET_OBJECT(e) arm_env_get_object(e) > > I'd pr

Re: [Qemu-devel] [PATCH RFC v3 06/21] target-arm: Prepare model-specific class_init function

2012-02-06 Thread Anthony Liguori
On 02/02/2012 08:59 PM, Andreas Färber wrote: This allows to share initialization between CPU models. Signed-off-by: Andreas Färber --- target-arm/cpu.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index 43231c9..b794ec1 1006

Re: [Qemu-devel] [PATCH RFC v3 05/21] target-arm: Embed CPUARMState in QOM ARMCPU

2012-02-06 Thread Anthony Liguori
On 02/02/2012 08:59 PM, Andreas Färber wrote: We g_malloc0()'ed CPUARMState ourself, and exec.c's cpu_copy() runs through cpu_init() as well, so we are at liberty to supply the CPUState any way we see fit. Having CPUARMState as field in the QOM CPU allows both to access env from an ARMCPU object

[Qemu-devel] [PATCH v4 02/11] fdc: set busy bit when starting a command

2012-02-06 Thread Hervé Poussineau
This bit must be active while a command is currently executed. Signed-off-by: Hervé Poussineau --- hw/fdc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index cd479f0..34ea830 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1446,7 +1446,6 @@ static void

[Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation

2012-02-06 Thread Hervé Poussineau
Here are misc fixes done by VirtualBox team. With these patches, floppy emulation is now good enough to run Xenix. Changes v3->v4: - added pc-1.1 machine type - disable media transfer rate check on older machine types - save/restore media transfer rate when media transfer rate check enabled Chang

[Qemu-devel] [PATCH v4 03/11] fdc: most control commands do not generate interrupts

2012-02-06 Thread Hervé Poussineau
In fact, only three control commands generate an interrupt: read_id, recalibrate and seek Signed-off-by: Hervé Poussineau --- hw/fdc.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 34ea830..49b8c97 100644 --- a/hw/fdc.c +++ b/hw/fdc

[Qemu-devel] [PATCH v4 10/11] fdc: fix seek command, which shouldn't check tracks

2012-02-06 Thread Hervé Poussineau
The seek command just sends step pulses to the drive and doesn't care if there is a medium inserted of if it is banging the head against the drive. Signed-off-by: Hervé Poussineau --- hw/fdc.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c in

[Qemu-devel] [PATCH v4 04/11] fdc: handle read-only floppies (abort early on write commands)

2012-02-06 Thread Hervé Poussineau
A real floppy doesn't attempt to write to read-only media either. Signed-off-by: Hervé Poussineau --- hw/fdc.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 49b8c97..060ca84 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -300,6 +300,7 @@ e

[Qemu-devel] [PATCH v4 08/11] fdc: add a 'check media rate' property. Not used yet

2012-02-06 Thread Hervé Poussineau
Set it to true for current Qemu versions, and false for previous ones Signed-off-by: Hervé Poussineau --- hw/fdc.c |3 +++ hw/pc_piix.c | 36 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 7c675f6..af007ae

[Qemu-devel] [PATCH v4 09/11] fdc: check if media rate is correct before doing any transfer

2012-02-06 Thread Hervé Poussineau
The programmed rate has to be the same as the required rate for the floppy format ; if that's not the case, the transfer should abort. This check can be disabled by using the 'check_media_rate' property. Save media rate value only if media rate check is enabled. Signed-off-by: Hervé Poussineau -

[Qemu-devel] [PATCH v4 07/11] pc: add 1.1 machine type

2012-02-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pc_piix.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index c06f1b5..400c6b6 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -371,9 +371,17 @@ static void pc_xen_hvm_init(ram_addr_t ram_siz

[Qemu-devel] [PATCH v4 11/11] fdc: DIR (Digital Input Register) should return status of current drive...

2012-02-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/fdc.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 1928284..cc2813f 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -216,6 +216,7 @@ static void fdctrl_reset_fifo(FDCtrl *fdctrl); static int fdctrl_tra

[Qemu-devel] [PATCH v4 06/11] block: add a transfer rate for floppy types

2012-02-06 Thread Hervé Poussineau
Floppies must be read at a specific transfer rate, depending of its own format. Update floppy description table to include required transfer rate. Signed-off-by: Hervé Poussineau --- block.c | 74 - block.h | 10 +++- hw/fdc.c

[Qemu-devel] [PATCH v4 01/11] fdc: take side count into account

2012-02-06 Thread Hervé Poussineau
Floppies can be simple or double-sided. However, current code was only taking the common case into account (ie 2 sides). This repairs single-sided floppies, which where totally broken before this patch : for track > 0, wrong sector number was calculated, and data was read/written at wrong place on

[Qemu-devel] [PATCH v4 05/11] fdc: add CCR (Configuration Control Register) write register

2012-02-06 Thread Hervé Poussineau
DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only CCR register is used to change media transfer rate, which will be checked in following changes. Signed-off-by: Hervé Poussineau --- hw/fdc.c | 22 ++ 1 files changed, 22 insertions(+),

Re: [Qemu-devel] [PATCH RFC v3 03/21] qom: Introduce CPU class

2012-02-06 Thread Anthony Liguori
On 02/06/2012 02:14 PM, Andreas Färber wrote: Am 06.02.2012 20:24, schrieb Anthony Liguori: On 02/02/2012 08:59 PM, Andreas Färber wrote: +/** + * cpu_common_reset: + * @cpu: The CPU whose common state is to be reset. + * + * To be used by derived classes. + */ +void cpu_common_reset(CPU *cpu);

[Qemu-devel] [PATCH] ide: fix compilation errors when DEBUG_IDE is set

2012-02-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/ide/pci.c |2 +- hw/ide/piix.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 246dd57..88c0942 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -336,7 +336,7 @@ static uint64_t bmdma_addr_re

[Qemu-devel] [PATCH] linux-user: fix fallocate

2012-02-06 Thread Alexander Graf
Fallocate gets off_t parameters passed in, so we should also read them out accordingly. Signed-off-by: Alexander Graf --- v1 -> v2: - unbreak 64-bit guests --- linux-user/syscall.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user

Re: [Qemu-devel] [PATCH] linux-user: fix fallocate

2012-02-06 Thread Alexander Graf
On 06.02.2012, at 22:03, Peter Maydell wrote: > On 6 February 2012 20:45, Alexander Graf wrote: >> Fallocate gets off_t parameters passed in, so we should also read them out >> accordingly. >> >> Signed-off-by: Alexander Graf >> --- >> linux-user/syscall.c |3 ++- >> 1 files changed, 2 in

Re: [Qemu-devel] [PATCH] linux-user: fix fallocate

2012-02-06 Thread Peter Maydell
On 6 February 2012 20:45, Alexander Graf wrote: > Fallocate gets off_t parameters passed in, so we should also read them out > accordingly. > > Signed-off-by: Alexander Graf > --- >  linux-user/syscall.c |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/linux-user/sy

[Qemu-devel] [PATCH] linux-user: fix fallocate

2012-02-06 Thread Alexander Graf
Fallocate gets off_t parameters passed in, so we should also read them out accordingly. Signed-off-by: Alexander Graf --- linux-user/syscall.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ee8899e..ca63594 100644 ---

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-02-06 Thread Corey Bryant
On 02/04/2012 03:29 AM, Stefan Weil wrote: Am 04.02.2012 00:43, schrieb Anthony Liguori: On 02/03/2012 06:11 PM, q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems

Re: [Qemu-devel] [PATCH RFC v3 03/21] qom: Introduce CPU class

2012-02-06 Thread Andreas Färber
Am 06.02.2012 20:24, schrieb Anthony Liguori: > On 02/02/2012 08:59 PM, Andreas Färber wrote: >> +/** >> + * cpu_common_reset: >> + * @cpu: The CPU whose common state is to be reset. >> + * >> + * To be used by derived classes. >> + */ >> +void cpu_common_reset(CPU *cpu); > > Make this static, ini

Re: [Qemu-devel] [PATCH RFC v3 03/21] qom: Introduce CPU class

2012-02-06 Thread Peter Maydell
On 6 February 2012 19:24, Anthony Liguori wrote: > On 02/02/2012 08:59 PM, Andreas Färber wrote: >> +#define CPU(obj) OBJECT_CHECK(CPU, (obj), TYPE_CPU) >> +#define CPU_CLASS(class) OBJECT_CLASS_CHECK(CPUClass, (class), TYPE_CPU) >> +#define CPU_GET_CLASS(obj) OBJECT_GET_CLASS(CPUClass, (obj), TY

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-06 Thread Scott Wood
On 02/03/2012 04:52 PM, Anthony Liguori wrote: > On 02/03/2012 12:07 PM, Eric Northup wrote: >> On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivity wrote: >> [...] >>> >>> Moving to syscalls avoids these problems, but introduces new ones: >>> >>> - adding new syscalls is generally frowned upon, and kvm wil

[Qemu-devel] KVM call agenda for Tuesday 7

2012-02-06 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Cheers, Juan.

Re: [Qemu-devel] [PATCH RFC v3 03/21] qom: Introduce CPU class

2012-02-06 Thread Anthony Liguori
On 02/02/2012 08:59 PM, Andreas Färber wrote: It's abstract and derived directly from TYPE_OBJECT. Prepare a virtual reset method. Signed-off-by: Andreas Färber Cc: Anthony Liguori Cc: Peter Maydell --- include/qemu/cpu.h | 73 qom/Makefi

Re: [Qemu-devel] [PATCH RFC v3 02/21] qom: Add QOM support to user emulators

2012-02-06 Thread Anthony Liguori
On 02/02/2012 08:59 PM, Andreas Färber wrote: Link the Object base class and the module infrastructure for class registration. Call QOM module init. Signed-off-by: Andreas Färber Cc: Anthony Liguori If we're going to go down this road, then I have a hard requirement. We need to build the com

Re: [Qemu-devel] [PATCH v3 01/21] qom: Register QOM infrastructure early

2012-02-06 Thread Anthony Liguori
On 02/02/2012 08:59 PM, Andreas Färber wrote: QOM TYPE_INTERFACE was registered with device_init(), whose constructors are executed rather late in vl.c's main(). Rename the module init type from DEVICE to QOM and call it very early so that QOM can safely be used for machines and CPUs. device_in

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-06 Thread Anthony Liguori
On 02/06/2012 11:41 AM, Rob Earhart wrote: On Sun, Feb 5, 2012 at 5:14 AM, Avi Kivity wrote: On 02/03/2012 12:13 AM, Rob Earhart wrote: On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivitymailto:a...@redhat.com>> wrote: The kvm api has been accumulating cruft for several years now. This is

Re: [Qemu-devel] [PATCH] KVM: Fix compilation on non-x86

2012-02-06 Thread Marcelo Tosatti
On Wed, Jan 25, 2012 at 06:33:03PM +0100, Alexander Graf wrote: > Commit 84b058d broke compilation for KVM on non-x86 targets, which > don't have KVM_CAP_IRQ_ROUTING defined. > > Fix by not using the unavailable constant when it's not around. > > Signed-off-by: Alexander Graf Applied, thanks.

Re: [Qemu-devel] [PATCH uq/master] kvm: Allow to set shadow MMU size

2012-02-06 Thread Marcelo Tosatti
On Wed, Jan 25, 2012 at 06:14:15PM +0100, Jan Kiszka wrote: > Introduce the KVM-specific machine option kvm_shadow_mem. It allows to > set a custom shadow MMU size for the virtual machine. This is useful for > stress testing e.g. > > Only x86 supports this for now, but it is in principle a generic

Re: [Qemu-devel] Qemu atags passing in register.

2012-02-06 Thread d...@ucore.info
On Mon, Feb 6, 2012 at 6:48 PM, d...@ucore.info wrote: > In the sourcode (current release) I couldn't find any place where any > register except PC is being modified. While looking for some data to paste here, I've notice that the pointers should be set by "the smallest bootlader in the world". I

Re: [Qemu-devel] Qemu atags passing in register.

2012-02-06 Thread d...@ucore.info
On Mon, Feb 6, 2012 at 5:35 PM, Peter Maydell wrote: > No, qemu will correctly pass the atags in r2 if it is booting a linux > kernel (ie if you pass it a non ELF file via the -kernel argument). > Otherwise we wouldn't be able to boot Linux. > How are you starting qemu ? Well it's a bit complex:

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-06 Thread Rob Earhart
On Sun, Feb 5, 2012 at 5:14 AM, Avi Kivity wrote: > On 02/03/2012 12:13 AM, Rob Earhart wrote: >> On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivity > > wrote: >> >>     The kvm api has been accumulating cruft for several years now. >>      This is >>     due to feature creep, fixi

[Qemu-devel] [PATCH] s390x: fix qom-ification fall-out

2012-02-06 Thread Anthony Liguori
Tested-by: Andreas Faerber Signed-off-by: Anthony Liguori --- hw/s390-virtio-bus.c |1 + vl.c |6 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c index b66ef68..49140f8 100644 --- a/hw/s390-virtio-bus.c +++

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Kevin Wolf
Am 06.02.2012 17:22, schrieb Charles Arnold: On 2/6/2012 at 08:46 AM, in message <4f2ff5b9.9090...@redhat.com>, Kevin Wolf > wrote: >> >> Somehow you lost the ret = -EFBIG here. >> >> Otherwise the patch looks good enough for me. >> >> Kevin > > Thanks Kevin. Here is the revised patc

Re: [Qemu-devel] Qemu atags passing in register.

2012-02-06 Thread Peter Maydell
On 6 February 2012 12:19, d...@ucore.info wrote: > On PandaBoard the u-boot is always passing DTF/Atags pointer in r2 > register, and I'm kind of depending on it. I need to emulate this > behavior by -initrd qemu's argument. However it seems that > qemu-system-arm zeros the registers on the start,

Re: [Qemu-devel] [PATCH v2 26/27] omap_clk: convert to QOM

2012-02-06 Thread Peter Maydell
cc'ing Andrzej who also has some interest in the omap platforms. -- PMM On 4 February 2012 08:02, Paolo Bonzini wrote: > Make the OMAP clocks QOM objects, so that they we can put them in a branch > of the object graph and turn the pointer properties into links. > > As in the current code, the cl

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Charles Arnold
>>> On 2/6/2012 at 08:46 AM, in message <4f2ff5b9.9090...@redhat.com>, Kevin >>> Wolf wrote: > > Somehow you lost the ret = -EFBIG here. > > Otherwise the patch looks good enough for me. > > Kevin Thanks Kevin. Here is the revised patch with just this fix. - Charles The Virtual Hard Disk

Re: [Qemu-devel] [PATCH v4 2/6] block: add .bdrv_co_write_zeroes() interface

2012-02-06 Thread Stefan Hajnoczi
On Mon, Feb 6, 2012 at 4:00 PM, Kevin Wolf wrote: > Am 06.02.2012 16:50, schrieb Stefan Hajnoczi: >> On Tue, Jan 24, 2012 at 3:16 PM, Kevin Wolf wrote: +/* + * Efficiently zero a region of the disk image.  Note that this is a regular + * I/O request like read or write and sho

Re: [Qemu-devel] [PATCH] ppc: remove unused variables

2012-02-06 Thread Alexander Graf
On 06.02.2012, at 16:21, Andreas Färber wrote: > Am 04.02.2012 12:49, schrieb Blue Swirl: >> Fix this error: >> /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size': >> /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set >> but not used [-Werror=unused-but-set-v

Re: [Qemu-devel] [PATCH v4 2/6] block: add .bdrv_co_write_zeroes() interface

2012-02-06 Thread Kevin Wolf
Am 06.02.2012 16:50, schrieb Stefan Hajnoczi: > On Tue, Jan 24, 2012 at 3:16 PM, Kevin Wolf wrote: >>> +/* >>> + * Efficiently zero a region of the disk image. Note that this is a >>> regular >>> + * I/O request like read or write and should have a reasonable size. This >>> + * function is not

Re: [Qemu-devel] [PATCH v4 2/6] block: add .bdrv_co_write_zeroes() interface

2012-02-06 Thread Stefan Hajnoczi
On Tue, Jan 24, 2012 at 3:16 PM, Kevin Wolf wrote: >> +/* >> + * Efficiently zero a region of the disk image.  Note that this is a regular >> + * I/O request like read or write and should have a reasonable size.  This >> + * function is not suitable for zeroing the entire image in a single >> req

Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-06 Thread Luiz Capitulino
On Sat, 4 Feb 2012 10:34:32 -0500 "Kevin O'Connor" wrote: > On Fri, Feb 03, 2012 at 05:16:27PM -0200, Luiz Capitulino wrote: > > On Fri, 03 Feb 2012 11:23:05 -0600 > > Michael Roth wrote: > > > I'd been tracking Gerd's QMP wakeup series as the s3 resolution we need > > > for guest-suspend, is t

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Kevin Wolf
Am 03.02.2012 01:16, schrieb Charles Arnold: > Next version of the patch with fixes, cleanups, and suggestions. > - Charles > > > The Virtual Hard Disk Image Format Specification allows for three > types of hard disk formats, Fixed, Dynamic, and Differencing. Qemu > currently only supports Dyna

Re: [Qemu-devel] [PATCH v4 1/6] cutils: extract buffer_is_zero() from qemu-img.c

2012-02-06 Thread Stefan Hajnoczi
On Tue, Jan 24, 2012 at 3:03 PM, Kevin Wolf wrote: > Am 18.01.2012 15:59, schrieb Stefan Hajnoczi: >> @@ -303,6 +303,40 @@ void qemu_iovec_memset_skip(QEMUIOVector *qiov, int c, >> size_t count, >>      } >>  } >> >> +/* >> + * Checks if a buffer is all zeroes >> + * >> + * Attention! The len mus

Re: [Qemu-devel] [PATCH] ppc: remove unused variables

2012-02-06 Thread Andreas Färber
Am 04.02.2012 12:49, schrieb Blue Swirl: > Fix this error: > /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size': > /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set > but not used [-Werror=unused-but-set-variable] > > Signed-off-by: Blue Swirl Tested-by: An

Re: [Qemu-devel] [PATCH 1/4] linux-user: implement device mapper ioctls

2012-02-06 Thread Alexander Graf
On 31.01.2012, at 22:49, Alexander Graf wrote: > This patch implements all ioctls currently implemented by device mapper, > enabling us to run dmsetup and kpartx inside of linux-user. Hi Alasdair, Could you please have a quick glimpse through this wrapper and check that I handled the ioctls co

Re: [Qemu-devel] [PATCH v2 27/27] omap: remove PROP_PTR properties

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Everything is already in place to turn the clock properties into links. w00t! Reviewed-by: Anthony Liguori Regards, Anthony Liguori Cc: Peter Maydell Signed-off-by: Paolo Bonzini --- hw/omap_clk.c |2 +- hw/omap_gpio.c | 46 +

Re: [Qemu-devel] [PATCH v2 26/27] omap_clk: convert to QOM

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Make the OMAP clocks QOM objects, so that they we can put them in a branch of the object graph and turn the pointer properties into links. As in the current code, the clocks are copied into a freshly allocated memory block when they are initialized.

Re: [Qemu-devel] [PATCH v2 25/27] qdev: remove unused fields from PropertyInfo

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/qdev-addr.c |2 -- hw/qdev-properties.c | 38 +- hw/qdev.h| 21 - 3

Re: [Qemu-devel] [PATCH v2 24/27] qdev: initialize properties via QOM

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Similarly, use the object properties also to set the default values of the qdev properties. This requires reordering registration and initialization. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/q

Re: [Qemu-devel] [PATCH v2 23/27] qdev: inline qdev_prop_set into qdev_prop_set_ptr

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: qdev_prop_set is not needed anymore except for hacks, simplify it and inline it. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/qdev-properties.c | 26 +++--- 1 files changed,

Re: [Qemu-devel] [PATCH v2 22/27] qdev: access properties via QOM

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Do not poke anymore in the struct when accessing qdev properties. Instead, ask the object to set the right value. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/qdev-addr.c |5 ++- hw/qdev

Re: [Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Integer properties did not work. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/qdev-properties.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/qdev-properties.c b

Re: [Qemu-devel] [PATCH v2 20/27] qdev: let QOM free properties

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Drop the special free callback. Instead, register a "regular" release method in the non-legacy property. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/qdev-properties.c | 19 ---

Re: [Qemu-devel] [PATCH v2 19/27] qdev: remove parse/print methods for pointer properties

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Pointer properties (except for PROP_PTR of course) should not need a legacy counterpart. In the future, relative paths will ensure that QEMU will support the same syntax as now for drives etc.. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Ligu

Re: [Qemu-devel] [PATCH v2 18/27] qdev: make the non-legacy pci address property accept an integer

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: PCI addresses are set with qdev_prop_uint32. Thus we make the QOM property accept a device and function encoded in an 8-bit integer, instead of the magic dd.f hex string. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony

Re: [Qemu-devel] [PATCH v2 17/27] qdev: remove parse/print methods for mac properties

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori --- hw/qdev-properties.c | 61 ++--- 1 files changed, 42 insertions(+), 19 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-propert

Re: [Qemu-devel] [PATCH v2 16/27] qdev: remove print/parse methods from LostTickPolicy properties

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Also generalize the code so that we can have more enum properties in the future. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/qdev-properties.c | 62 +-

Re: [Qemu-devel] [PATCH v2 15/27] qdev: remove parse method for string properties

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: We need the print method to put double quotes, but parsing is not special. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/qdev-properties.c | 11 --- 1 files changed, 0 insertions(+), 11 d

Re: [Qemu-devel] [PATCH v2 14/27] qdev: allow reusing get/set for legacy property

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: In some cases, a legacy property does need a special print method but not a special parse method. In this case, we can reuse the get/set from the static (non-legacy) property. If neither parse nor print is needed, though, do not register the legacy p

Re: [Qemu-devel] [PATCH v2 13/27] qdev: remove direct calls to print/parse

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: There's no need to call into ->parse and ->print manually. The QOM legacy properties do that for us. Furthermore, in some cases legacy and static properties have exactly the same behavior, and we could drop the legacy properties right away. Add an ap

Re: [Qemu-devel] [PATCH v2 12/27] qom: add property get/set wrappers for links

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: These can set a link to any object, as long as it is included in the composition tree. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 24 qom/object.c | 25 + 2 files changed,

Re: [Qemu-devel] [PATCH v2 11/27] qom: fix canonical paths vs. interfaces

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- qom/object.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/qom/object.c b/qom/object.c index 75be582..e8418bc 100644 -

Re: [Qemu-devel] [PATCH v2 10/27] qom: use object_resolve_path_type for links

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: This allows to restrict partial matches to objects of the expected type. It will let people use bare names to reference drives even though their name might be the same as a device's (e.g. -drive id=hd0,if=none,... -device ...,drive=hd0,id=hd0). As a

Re: [Qemu-devel] [PATCH v2 09/27] qom: add object_resolve_path_type

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- include/qemu/object.h | 25 +++-- qom/object.c | 26 ++ 2 files changed, 41 insertions(+), 10 del

Re: [Qemu-devel] [PATCH v2 08/27] qom: fix off-by-one

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- qom/object.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qom/object.c b/qom/object.c index b26272f..314fc7a 100644 --- a/qom/object.c +++ b/qom/object.c @@ -871,7 +871,7 @@ static void o

Re: [Qemu-devel] [PATCH v2 07/27] qom: add property get/set wrappers for C types

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Add wrappers that let you get/set properties using normal C data types. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- include/qemu/object.h | 70 + qom/object.c

Re: [Qemu-devel] [PATCH v2 06/27] qom: add QObject-based property get/set wrappers

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Move the creation of QmpInputVisitor and QmpOutputVisitor from qmp.c to qom/object.c, since it's the only practical way to access object properties. Signed-off-by: Paolo Bonzini Reluctantly-Reviewed-by: Anthony Liguori As long as we keep this isol

Re: [Qemu-devel] [PATCH v2 05/27] qom: do not include qdev header file

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- qom/object.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index a89e9e3..c0f6d54 100644 --- a/qom/object.c +++ b/qom/object.c @@ -13,8 +13,6 @@ #include "qem

Re: [Qemu-devel] [PATCH v2 04/27] qom: avoid useless conversions from string to type

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- qom/object.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/qom/object.c b/qom/object.c index 4d21f0a..a89e9e3 100644 --- a/qom/object.c +++ b/qom/object.c @@ -368,9 +368,10 @

Re: [Qemu-devel] [PATCH v2 03/27] qom: clean up/optimize object_dynamic_cast

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: The interface loop can be performed only on the parent object. It does not need to be done on each interface. Similarly, we can simplify the code by switching early from the implementation object to the parent object. Signed-off-by: Paolo Bonzini --

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-06 Thread Avi Kivity
On 02/06/2012 04:00 PM, Anthony Liguori wrote: >> Do guests always read an unlatched counter? Doesn't seem reasonable >> since they can't get a stable count this way. > > > Perhaps. You could have the latching done by writing to persisted > scratch memory but then locking becomes an issue. Oh, y

[Qemu-devel] [PATCH v2] MAINTAINERS: Add hw/highbank.c maintainer

2012-02-06 Thread Mark Langsdorf
Signed-off-by: Mark Langsdorf --- Changes from v1 Put entry in alphabetical order Added maintainership of hw/xgmac MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 173e893..74ee059 100644 --- a/MAINTAINERS +

Re: [Qemu-devel] [PATCH v2 02/27] qom: more documentation on subclassing

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori And thank you very much for adding to the docs! Regards, Anthony Liguori --- include/qemu/object.h | 76 +++-- 1 files changed, 73 insert

Re: [Qemu-devel] [PATCH v2 01/27] qom: clean up cast macros

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- include/qemu/object.h | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/o

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-06 Thread Anthony Liguori
On 02/06/2012 07:54 AM, Avi Kivity wrote: On 02/06/2012 03:33 PM, Anthony Liguori wrote: Look at arch/x86/kvm/i8254.c:pit_ioport_read() for a counterexample. There are also interactions with other devices (for example the apic/ioapic interaction via the apic bus). Hrm, maybe I'm missing it, b

[Qemu-devel] [PATCH v2 6/6] trace: [stderr] Port to generic event information and new control interface

2012-02-06 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 26 -- trace/stderr.c | 34 ++ 2 files changed, 14 insertions(+), 46 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index 98a8ca8..a3135b8 100755 ---

[Qemu-devel] [PATCH v2 5/6] trace: [simple] Port to generic event information and new control interface

2012-02-06 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 29 ++--- trace/simple.c | 32 +--- trace/simple.h |6 +- trace/stderr.h | 11 --- 4 files changed, 16 insertions(+), 62 deletions(-) delete mode 1

  1   2   >