[Qemu-devel] [PATCH 4/6] pcnet: Preserve link state across device reset

2012-01-26 Thread Stefan Hajnoczi
From: Jan Kiszka A device reset does not affect the link state, only set_link does. Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- hw/pcnet.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/pcnet.c b/hw/pcnet.c index 306dc6e..6aa48e0d 100644 --- a/h

[Qemu-devel] [PATCH 5/6] ./configure: export xfs config via --{enable, disable}-xfsctl

2012-01-26 Thread Stefan Hajnoczi
From: Sergei Trofimovich Signed-off-by: Sergei Trofimovich Signed-off-by: Stefan Hajnoczi --- configure |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 9d5175b..69fb239 100755 --- a/configure +++ b/configure @@ -766,6 +766,10 @@ for opt d

[Qemu-devel] [PATCH 1/6] remove #if 0 code for timers

2012-01-26 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- qemu-timer.c | 29 - 1 files changed, 0 insertions(+), 29 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index cd026c6..a22f27e 100644 --- a/qemu-timer.c +++ b/qemu-timer.c

[Qemu-devel] [PATCH 3/6] e1000: Preserve link state across device reset

2012-01-26 Thread Stefan Hajnoczi
From: Jan Kiszka A device reset does not affect the link state, only set_link does. Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- hw/e1000.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 86c5416..76e736f 100644 --- a/

[Qemu-devel] [PATCH 2/6] qdev-property: Make bit property parsing stricter

2012-01-26 Thread Stefan Hajnoczi
From: Jan Kiszka By using strncasecmp, we allow for arbitrary characters after the "on"/"off" string. Fix this by switching to strcasecmp. Reviewed-by: Andreas Färber Reviewed-by: Markus Armbruster Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- hw/qdev-properties.c |4 ++--

[Qemu-devel] [PULL 0/6] Trivial patches for 20 to 27 January 2012

2012-01-26 Thread Stefan Hajnoczi
The following changes since commit 331636431af32ece373f4b1fb7c3ae9d0615e2a6: vga: compile cirrus_vga in hwlib (2012-01-25 18:32:59 +) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches Jan Kiszka (3): qdev-property: Make bit property parsing

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Gerhard Wiesinger
On Thu, 26 Jan 2012, Markus Armbruster wrote: Gerd Hoffmann writes: On 01/26/12 08:45, Markus Armbruster wrote: Gerhard Wiesinger writes: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled (or romfile=no or romfile=none) parameter. With hotplug

Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Disable vmmouse after reboot

2012-01-26 Thread Gerhard Wiesinger
On Thu, 26 Jan 2012, Andreas Färber wrote: Am 25.01.2012 21:04, schrieb Gerhard Wiesinger: Bugfix after reboot when vmmouse was enabled and another OS which uses e.g. PS/2 mouse. Details: When a guest activated the vmmouse followed by a reboot the vmmouse was still enabled and the PS/2 mouse w

Re: [Qemu-devel] [PATCH] kvm: flush the dirty log when unregistering a slot

2012-01-26 Thread Gerhard Wiesinger
On Thu, 26 Jan 2012, Avi Kivity wrote: On 01/25/2012 10:15 PM, Gerhard Wiesinger wrote: On Sun, 15 Jan 2012, Avi Kivity wrote: On 01/15/2012 04:40 PM, Gerhard Wiesinger wrote: On Sun, 15 Jan 2012, Jan Kiszka wrote: On 2012-01-15 15:17, Avi Kivity wrote: Otherwise, the dirty log informatio

Re: [Qemu-devel] [Qemu-trivial] [PATCH] keep the PID file locked for the lifetime of the process

2012-01-26 Thread Stefan Hajnoczi
On Thu, Jan 26, 2012 at 10:36:41PM +0100, Laszlo Ersek wrote: > The lockf() call in qemu_create_pidfile() aims at ensuring mutual > exclusion. We shouldn't close the pidfile on success, because that drops > the lock as well [1]: > > "File locks shall be released on first close by the locking p

Re: [Qemu-devel] [PATCH] fixup e432cef9 (aio help text): end sentences with periods

2012-01-26 Thread Stefan Hajnoczi
On Tue, Jan 24, 2012 at 09:13:28PM +0100, Laszlo Ersek wrote: > (Please keep me CC'd on any followup; I'm not subscribed. Thanks.) > > Signed-off-by: Laszlo Ersek > --- > qemu-io.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Thanks, applied to the trivial patches tree: https

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ./configure: export xfs config via --{enable, disable}-xfsctl

2012-01-26 Thread Stefan Hajnoczi
On Tue, Jan 24, 2012 at 08:42:40PM +0300, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > Signed-off-by: Sergei Trofimovich > --- > configure |4 > 1 files changed, 4 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/c

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-26 Thread Stefan Hajnoczi
On Tue, Jan 24, 2012 at 06:17:36PM +0100, Andreas Färber wrote: > From: Andreas Färber > > VMState supports the type bool but qdev instead supports bit, backed by > uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool(). > > bool by definition is either true or false. Should t

Re: [Qemu-devel] [PATCH] pcnet: Preserve link state across device reset

2012-01-26 Thread Stefan Hajnoczi
On Tue, Jan 24, 2012 at 01:47:56PM +0100, Jan Kiszka wrote: > A device reset does not affect the link state, only set_link does. > > Signed-off-by: Jan Kiszka > --- > hw/pcnet.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: https://g

Re: [Qemu-devel] [PATCH] e1000: Preserve link state across device reset

2012-01-26 Thread Stefan Hajnoczi
On Tue, Jan 24, 2012 at 01:47:46PM +0100, Jan Kiszka wrote: > A device reset does not affect the link state, only set_link does. > > Signed-off-by: Jan Kiszka > --- > hw/e1000.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches tree: https:/

Re: [Qemu-devel] [Qemu-trivial] [PATCH] optionroms: Silence intermediate file removal

2012-01-26 Thread Stefan Hajnoczi
On Mon, Jan 23, 2012 at 07:34:23PM +0100, Jan Kiszka wrote: > The build process of optionroms spits out an "rm ..." line. Moreover, it > removes all .o files that can be handy for debugging purposes. > > Disable automatic intermediate removal and only clean up the unneeded > and large .img and .ra

Re: [Qemu-devel] [Qemu-trivial] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command

2012-01-26 Thread Stefan Hajnoczi
On Tue, Jan 24, 2012 at 12:19:44PM -0500, Thomas Higdon wrote: > On Tue, Jan 24, 2012 at 08:53:03AM -0500, Kevin Wolf wrote: > > Am 23.01.2012 18:15, schrieb Thomas Higdon: > > > This prevents the emulated SCSI device from trying to DMA more bytes to > > > the > > > initiator than are expected. Wi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qdev-property: Make bit property parsing stricter

2012-01-26 Thread Stefan Hajnoczi
On Sat, Jan 21, 2012 at 02:43:07PM +0100, Jan Kiszka wrote: > By using strncasecmp, we allow for arbitrary characters after the > "on"/"off" string. Fix this by switching to strcasecmp. > > Signed-off-by: Jan Kiszka > --- > hw/qdev-properties.c |4 ++-- > 1 files changed, 2 insertions(+), 2

Re: [Qemu-devel] [Qemu-trivial] [PATCH] main-loop: For tools, initialize timers as part of qemu_init_main_loop()

2012-01-26 Thread Stefan Hajnoczi
On Sat, Jan 21, 2012 at 11:13:53AM -0600, Michael Roth wrote: > In some cases initializing the alarm timers can lead to non-negligable > overhead from programs that link against qemu-tool.o. At least, > setting a max-resolution WinMM alarm timer via mm_start_timer() (the > current default for Windo

Re: [Qemu-devel] [Qemu-trivial] [PATCH] main-loop: For tools, initialize timers as part of qemu_init_main_loop()

2012-01-26 Thread Stefan Hajnoczi
On Sat, Jan 21, 2012 at 11:13:53AM -0600, Michael Roth wrote: > In some cases initializing the alarm timers can lead to non-negligable > overhead from programs that link against qemu-tool.o. At least, > setting a max-resolution WinMM alarm timer via mm_start_timer() (the > current default for Windo

Re: [Qemu-devel] [Qemu-trivial] [PATCH] main-loop: Fix SetEvent() on uninitialized handle on win32

2012-01-26 Thread Stefan Hajnoczi
On Fri, Jan 20, 2012 at 07:08:27PM -0600, Michael Roth wrote: > diff --git a/main-loop.c b/main-loop.c > index 692381c..62d95b9 100644 > --- a/main-loop.c > +++ b/main-loop.c > @@ -164,7 +164,7 @@ static int qemu_signal_init(void) > > #else /* _WIN32 */ > > -HANDLE qemu_event_handle; > +HANDLE

Re: [Qemu-devel] [Qemu-trivial] [PATCH] remove #if 0 code for timers

2012-01-26 Thread Stefan Hajnoczi
On Fri, Jan 20, 2012 at 12:05:22PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qemu-timer.c | 29 - > 1 files changed, 0 insertions(+), 29 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivi

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Alexey Korolev
On 27/01/12 04:12, Avi Kivity wrote: > On 01/26/2012 04:36 PM, Michael S. Tsirkin wrote: >> On Thu, Jan 26, 2012 at 03:52:27PM +0200, Avi Kivity wrote: >>> On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote: On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > Hi, > In this

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Alexey Korolev
On 27/01/12 03:36, Michael S. Tsirkin wrote: > On Thu, Jan 26, 2012 at 03:52:27PM +0200, Avi Kivity wrote: >> On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote: >>> On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: Hi, In this post http://lists.gnu.org/archive/html/qemu

Re: [Qemu-devel] TB chaining in QEMU

2012-01-26 Thread Xin Tong
On Thu, Jan 26, 2012 at 3:55 PM, Peter Maydell wrote: > On 26 January 2012 19:52, Xin Tong wrote: > > It seems to me that when QEMU emits a TB to TB transition, it does not > look > > for whether the code has already been generated or not ( at least x86 on > x86 > > emulation) . it just lay down

[Qemu-devel] [PATCH v8 1/4] Add basic version of bridge helper

2012-01-26 Thread Corey Bryant
This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN which allows qemu to avoid running as root while still satisfying the majority of what users tend to want to do with tap devices

[Qemu-devel] [PATCH V2] GRLIB UART: Add RX channel

2012-01-26 Thread Fabien Chouteau
This patch implements the RX channel of GRLIB UART with a FIFO to improve data rate. Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 106 +++ trace-events |1 + 2 files changed, 90 insertions(+), 17 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH] To support scsi Virtual Adapter while creating VMDK images

2012-01-26 Thread Praveen_Paladugu
According to VMDK specification, while using virtual scsi adapter, the value of adapterType has to be set to "lsilogic" or "buslogic". When the user adds "scsi" to the list of qemu-img options (Example: qemu-img create -f vmdk foo -o scsi,size=100M) this patch will set the value of adapterType t

[Qemu-devel] Trying to add usermode support for signalfd (but failing)

2012-01-26 Thread Alex Barcelo
I was trying to add signalfd support on qemu-ppc (specifically, I'm doing a configure with "--enable-debug-tcg --enable-debug --disable-strip --disable-kvm --disable-bsd-user --disable-darwin-user --enable-profiler --target-list=ppc-linux-user --disable-curl --enable-nptl"). At first I thought tha

[Qemu-devel] [PATCH v8 2/4] Add access control support to qemu bridge helper

2012-01-26 Thread Corey Bryant
We go to great lengths to restrict ourselves to just cap_net_admin as an OS enforced security mechanism. However, we further restrict what we allow users to do to simply adding a tap device to a bridge interface by virtue of the fact that this is the only functionality we expose. This is not good

[Qemu-devel] [PATCH v8 0/4] -net bridge: rootless bridge support for qemu

2012-01-26 Thread Corey Bryant
With qemu it is possible to run a guest from an unprivileged user but if we wanted to communicate with the outside world we had to switch to root. We address this problem by introducing a new network backend and a new network option for -net tap. This is less flexible when compared to existing -n

[Qemu-devel] [PATCH v8 4/4] Add support for net bridge

2012-01-26 Thread Corey Bryant
The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap device to pass to the script. This model is great for portability and flexibility but it's incredibly difficult to eliminate the need to ru

[Qemu-devel] [PATCH V2] GRLIB UART: Add RX channel

2012-01-26 Thread Fabien Chouteau
This patch implements the RX channel of GRLIB UART with a FIFO to improve data rate. Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 106 +++ trace-events |1 + 2 files changed, 90 insertions(+), 17 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH v8 3/4] Add cap reduction support to enable use as SUID

2012-01-26 Thread Corey Bryant
The ideal way to use qemu-bridge-helper is to give it an fscap of using: setcap cap_net_admin=ep qemu-bridge-helper Unfortunately, most distros still do not have a mechanism to package files with fscaps applied. This means they'll have to SUID the qemu-bridge-helper binary. To improve security

[Qemu-devel] [PATCH V2] GRLIB UART: Add RX channel

2012-01-26 Thread Fabien Chouteau
This patch implements the RX channel of GRLIB UART with a FIFO to improve data rate. Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 106 +++ trace-events |1 + 2 files changed, 90 insertions(+), 17 deletions(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH] GRLIB UART: Add RX channel

2012-01-26 Thread Fabien Chouteau
On 26/01/2012 14:55, Avi Kivity wrote: > On 01/26/2012 03:45 PM, Fabien Chouteau wrote: >> @@ -141,18 +219,19 @@ grlib_apbuart_write(void *opaque, target_phys_addr_t >> addr, >> static bool grlib_apbuart_accepts(void *opaque, target_phys_addr_t addr, >>unsigned

[Qemu-devel] [PATCH] GRLIB UART: Add RX channel

2012-01-26 Thread Fabien Chouteau
This patch implements the RX channel of GRLIB UART with a FIFO to improve data rate. Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 99 ++- trace-events |1 + 2 files changed, 90 insertions(+), 10 deletions(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH] memory: fix return value on unassigned reads

2012-01-26 Thread Fabien Chouteau
On 26/01/2012 10:33, Avi Kivity wrote: > The memory API returns -1 on unassigned reads, different from the original > in exec.c, which returned zero. Isn't this return value platform specific? > This breaks grlib_uart; apparently some users depend on it. > > Fix by returning zero; however if rea

Re: [Qemu-devel] [Android-virt] [PATCH 02/12] arm: make the number of GIC interrupts configurable

2012-01-26 Thread Rusty Russell
On Wed, 25 Jan 2012 15:09:41 +, Peter Maydell wrote: > On 24 January 2012 08:42, Rusty Russell wrote: > > Reading through this, I see a lot of "- 32".  Trivial patch follows, > > which applies to your rebasing branch: > > (If you send patches as fresh new emails then they just apply > with

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-01-26 Thread Serge Hallyn
I can reproduce this with upstream qemu - though i must point out that to do so i had to change the definition of VGA_RAM_SIZE in hw/vga_int.h to 16*1024*1024 (as it is in qemu-kvm) in order to be able to use the default high resolution. Command line was: ./x86_64-softmmu/qemu-system-x86_64 -vga

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Michael Roth
On 01/26/2012 09:18 AM, Eric Blake wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, that you'll probably notice is this 'set-support-level' command. Basically, it tells GA what qemu version is it running on. Ideally, this should be done as soon as GA start

Re: [Qemu-devel] [PATCH 02/28] openpic: remove dead code to make a PCI device version

2012-01-26 Thread Andreas Färber
Am 24.01.2012 20:32, schrieb Anthony Liguori: > bus is always NULL so the code in this if clause is dead (and therefore > untested). > > Signed-off-by: Anthony Liguori > --- > hw/openpic.c | 30 +++--- > hw/openpic.h |2 +- > hw/ppc_newworld.c |2 +- >

[Qemu-devel] [PATCH] macio: Convert to qdev

2012-01-26 Thread Andreas Färber
From: Anthony Liguori Signed-off-by: Anthony Liguori Split macio into two PCIDevices with declarative device ID, macio-oldworld and macio-newworld. Drop is_oldworld state in favor of two separate init functions and deferred creation. Signed-off-by: Andreas Färber Cc: Alexander Graf --- Anth

[Qemu-devel] [Bug 922355] [NEW] qemu crashes when invoked on Pandaboard

2012-01-26 Thread Marietto
Public bug reported: root@omap:~# uname -a Linux omap 3.1.6-x6 #1 SMP Thu Dec 22 11:17:51 UTC 2011 armv7l armv7l armv7l GNU/Linux root@omap:~# qemu Could not initialize KVM, will disable KVM support /build/buildd/qemu-kvm-0.14.1+noroms/tcg/arm/tcg-target.c:848: tcg fatal error ** Affects: qemu

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Anthony Liguori
On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blake wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, that you'll probably notice is this 'set-support-level' command. Basically, it tells GA what qemu version is it

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Anthony Liguori
On 01/26/2012 09:18 AM, Eric Blake wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, that you'll probably notice is this 'set-support-level' command. Basically, it tells GA what qemu version is it running on. Ideally, this should be done as soon as GA start

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Michael Roth
On 01/26/2012 02:13 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 20:41:13 +0100 Michal Privoznik wrote: On 26.01.2012 20:35, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blake wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, that

[Qemu-devel] [PATCH] keep the PID file locked for the lifetime of the process

2012-01-26 Thread Laszlo Ersek
The lockf() call in qemu_create_pidfile() aims at ensuring mutual exclusion. We shouldn't close the pidfile on success, because that drops the lock as well [1]: "File locks shall be released on first close by the locking process of any file descriptor for the file." Coverity may complain

Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option

2012-01-26 Thread Eric Blake
On 01/26/2012 12:34 PM, Scott Wood wrote: > On 01/24/2012 12:23 PM, Stefan Weil wrote: >> I'd prefer a different solution. As far as I have understood, >> the dtb is only useful with a kernel, so it could be handled >> as an optional attribute to the -kernel parameter: >> >> -kernel IMAGE[,dtb=

[Qemu-devel] [PATCH v2 03/18] block: pass protocol flags up to the format

2012-01-26 Thread Paolo Bonzini
In the next patches, the protocols will modify bs->open_flags to signify that they cannot support the exact requested feature set. Pass the modified flags to the format. Signed-off-by: Paolo Bonzini --- block.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/block.c b/b

[Qemu-devel] [PATCH v2 13/18] block: allow waiting at arbitrary granularity

2012-01-26 Thread Paolo Bonzini
When emulating small logical block sizes, the only overlaps that matter are at host block size granularity, not cluster. Make wait_for_overlapping_requests more flexible in this respect, too. Signed-off-by: Paolo Bonzini --- block.c | 43 --- 1 files cha

[Qemu-devel] [PATCH v2 08/18] block: rename buffer_alignment to guest_block_size

2012-01-26 Thread Paolo Bonzini
The alignment field is now set to the value that is promised to the guest, rather than required by the host. The next patches will make QEMU aware of the host-provided values, so make this clear. Signed-off-by: Paolo Bonzini --- block.c | 10 +- block.h |2 +-

[Qemu-devel] [PATCH 16/22] block: add support for partial streaming

2012-01-26 Thread Kevin Wolf
From: Marcelo Tosatti Add support for streaming data from an intermediate section of the image chain (see patch and documentation for details). Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/stream.c | 91 ++

[Qemu-devel] [PATCH 13/15] i440fx: allocate MemoryRegion for pci memory space

2012-01-26 Thread Anthony Liguori
--- hw/piix_pci.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index b38904d..855f402 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -118,7 +118,7 @@ typedef struct I440FXState PCIHostState parent; MemoryRegion *a

[Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx

2012-01-26 Thread Anthony Liguori
--- hw/pc.c | 70 -- hw/pc.h |3 +- hw/piix_pci.c | 74 +++- sysemu.h |2 - 4 files changed, 79 insertions(+), 70 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index

[Qemu-devel] [PATCH 07/22] block: add image streaming block job

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- Makefile.objs |1 + block/stream.c | 133 block_int.h|3 + trace-events |4 ++ 4 files changed, 141 insertions(+), 0 deletions(-) cre

[Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-26 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/hpet.c| 38 +- hw/hpet_emul.h | 40 hw/mc146818rtc.c | 30 ++--- hw/mc146818rtc.h | 27 +++ hw/pc.c | 38 +-- hw/piix_pci

[Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-26 Thread Anthony Liguori
A long time ago, there was a grand plan to merge q35 chipset support. The start of that series was a refactoring of pc.c which split a bunch of the "common" functionality into a separate file that could be shared by the two. But q35 never got merged and the refactoring, in retrospect, just made t

[Qemu-devel] [PATCH v2 07/18] raw: remove the aligned_buf

2012-01-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 25 +++-- 1 files changed, 3 insertions(+), 22 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 2ee5d69..007d1d3 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -129,8 +129,6 @@ typedef stru

[Qemu-devel] [PATCH 05/22] block: make copy-on-read a per-request flag

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Previously copy-on-read could only be enabled for all requests to a block device. This means requests coming from the guest as well as QEMU's internal requests would perform copy-on-read when enabled. For image streaming we want to support finer-grained behavior than just

[Qemu-devel] [PATCH 12/15] i440fx-pmc: calculate PCI memory hole directly

2012-01-26 Thread Anthony Liguori
--- hw/piix_pci.c | 47 +-- 1 files changed, 29 insertions(+), 18 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index dddc95f..b38904d 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -52,6 +52,9 @@ #define XEN_PIIX_NUM_PIRQS 128ULL

[Qemu-devel] [PATCH v2 06/18] block: move flag bits together

2012-01-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block_int.h | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/block_int.h b/block_int.h index 0bbebe4..6f23d4a 100644 --- a/block_int.h +++ b/block_int.h @@ -222,15 +222,18 @@ struct BlockDriver { struct BlockDriverState {

[Qemu-devel] [PATCH 04/15] piix: prepare for composition

2012-01-26 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/piix_pci.c | 26 +- 1 files changed, 17 insertions(+), 9 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 9065632..ec75725 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -43,6 +43,9 @@ typedef PCIHostState I440FXStat

Re: [Qemu-devel] TB chaining in QEMU

2012-01-26 Thread Peter Maydell
On 26 January 2012 19:52, Xin Tong wrote: > It seems to me that when QEMU emits a TB to TB transition, it does not look > for whether the code has already been generated or not ( at least x86 on x86 > emulation) . it just lay down a 4 byte address, waiting to be patched later. > Am I right ? Yes,

[Qemu-devel] [PATCH 10/22] qmp: add block_job_set_speed command

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Add block_job_set_speed, which sets the maximum speed for a background block operation. Signed-off-by: Stefan Hajnoczi Acked-by: Luiz Capitulino Signed-off-by: Kevin Wolf --- blockdev.c | 25 + hmp-commands.hx | 14 ++ hmp.

[Qemu-devel] [PATCH 1/3] es1370: Drop dead code

2012-01-26 Thread Andreas Färber
Signed-off-by: Anthony Liguori Signed-off-by: Andreas Färber --- Anthony, as requested before, please pull these out of the stylistic changes. hw/es1370.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 6a3ba55..3527eb6 100644 --- a/

[Qemu-devel] [PATCH 02/15] pc: make some functions static

2012-01-26 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/pc.c | 24 hw/pc.h | 26 -- 2 files changed, 12 insertions(+), 38 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 3d40aca..4b11e44 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -101,7 +101,7 @@ static const int

[Qemu-devel] [PATCH 06/15] piix: create i8254 through composition

2012-01-26 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/i8254.c| 35 +++ hw/i8254.h| 38 ++ hw/pc.c |5 + hw/piix_pci.c | 15 ++- 4 files changed, 56 insertions(+), 37 deletions(-) create mode 100644 hw/i82

[Qemu-devel] [PATCH 03/15] piix3: make PIIX3-xen a subclass of PIIX3

2012-01-26 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/piix_pci.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 1906427..9065632 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -527,23 +527,14 @@ static TypeInfo piix3_info = { static v

[Qemu-devel] [PATCH 13/22] blockdev: make image streaming safe across hotplug

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Unplugging a storage interface like virtio-blk causes the host block device to be deleted too. Long-running operations like block migration must take a DriveInfo reference to prevent the BlockDriverState from being freed. For image streaming we can do the same thing. Note

[Qemu-devel] [PATCH 08/15] i440fx: introduce some saner naming conventions

2012-01-26 Thread Anthony Liguori
i440fx-pcihost => i440fx i440fx => i440fx-pmc It might seem like a small change, but it better reflects the fact that the PMC is contained within the i440fx which we will now reflect in composition in the next few changesets. Signed-off-by: Anthony Liguori --- hw/pc.c |2 +- hw/pc.h

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Michal Privoznik
On 26.01.2012 20:35, Luiz Capitulino wrote: > On Thu, 26 Jan 2012 08:18:03 -0700 > Eric Blake wrote: > >> [adding qemu-devel] >> >> On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, that you'll probably notice is this 'set-support-level' command. Basically, it tells GA what q

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Luiz Capitulino
On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blake wrote: > [adding qemu-devel] > > On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: > >> One thing, that you'll probably notice is this > >> 'set-support-level' command. Basically, it tells GA what qemu version > >> is it running on. Ideally, this sho

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Luiz Capitulino
On Thu, 26 Jan 2012 20:41:13 +0100 Michal Privoznik wrote: > On 26.01.2012 20:35, Luiz Capitulino wrote: > > On Thu, 26 Jan 2012 08:18:03 -0700 > > Eric Blake wrote: > > > >> [adding qemu-devel] > >> > >> On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: > One thing, that you'll probably n

[Qemu-devel] [PATCH 07/15] i440fx: eliminate i440fx_common_init

2012-01-26 Thread Anthony Liguori
--- hw/piix_pci.c | 48 1 files changed, 12 insertions(+), 36 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 4735d9c..589708e 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -263,19 +263,17 @@ static int i440fx_initfn(PCIDevice *

Re: [Qemu-devel] [RFC 00/15] Refactor PC machine to take advantage of QOM

2012-01-26 Thread Anthony Liguori
On 01/26/2012 01:57 PM, Markus Armbruster wrote: Peter Maydell writes: On 26 January 2012 19:00, Anthony Liguori wrote: We need to modeled MemoryRegions and qemu_irq in QOM too. +1 : this ought to let us get rid of SysBus... MemoryRegions shouldn't be that difficult. Our habit of pass

Re: [Qemu-devel] [RFC 00/15] Refactor PC machine to take advantage of QOM

2012-01-26 Thread Markus Armbruster
Peter Maydell writes: > On 26 January 2012 19:00, Anthony Liguori wrote: >> We need to modeled MemoryRegions and qemu_irq in QOM too. > > +1 : this ought to let us get rid of SysBus... > >>  MemoryRegions >> shouldn't be that difficult.  Our habit of passing qemu_irq's as arrays >> without >> a

[Qemu-devel] [PATCH 17/22] docs: describe live block operations

2012-01-26 Thread Kevin Wolf
From: Marcelo Tosatti Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- docs/live-block-ops.txt | 58 +++ 1 files changed, 58 insertions(+), 0 deletions(-) create mode 100644 docs/live-block-ops.txt diff

[Qemu-devel] [PATCH 09/15] i440fx: create the PMC through composition

2012-01-26 Thread Anthony Liguori
--- hw/piix_pci.c | 122 - 1 files changed, 69 insertions(+), 53 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index aca4476..fdb372f 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -47,34 +47,6 @@ * function 1.0, there is the

[Qemu-devel] [PATCH v2 04/18] block: non-raw protocols never cache

2012-01-26 Thread Paolo Bonzini
Non-raw protocols never cache their data. Make this visible by setting BDRV_O_NOCACHE in the open_flags. It will be used to prohibit block sizes smaller than the backend's block size. Signed-off-by: Paolo Bonzini --- block/curl.c |1 + block/iscsi.c|2 ++ block/nbd.c |

[Qemu-devel] TB chaining in QEMU

2012-01-26 Thread Xin Tong
It seems to me that when QEMU emits a TB to TB transition, it does not look for whether the code has already been generated or not ( at least x86 on x86 emulation) . it just lay down a 4 byte address, waiting to be patched later. Am I right ? case INDEX_op_goto_tb: if (s->tb_jmp_offset)

[Qemu-devel] [PATCH 11/22] qmp: add block_job_cancel command

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Add block_job_cancel, which stops an active block streaming operation. When the operation has been cancelled the new BLOCK_JOB_CANCELLED event is emitted. Signed-off-by: Stefan Hajnoczi Acked-by: Luiz Capitulino Signed-off-by: Kevin Wolf --- QMP/qmp-events.txt | 24 ++

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-26 Thread Anthony Liguori
On 01/26/2012 01:00 PM, Anthony Liguori wrote: A long time ago, there was a grand plan to merge q35 chipset support. The start of that series was a refactoring of pc.c which split a bunch of the "common" functionality into a separate file that could be shared by the two. But q35 never got merge

Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option

2012-01-26 Thread Peter Maydell
On 23 January 2012 07:20, Peter A. G. Crosthwaite wrote: > --- a/vl.c > +++ b/vl.c > @@ -233,6 +233,7 @@ int boot_menu; >  uint8_t *boot_splash_filedata; >  int boot_splash_filedata_size; >  uint8_t qemu_extra_params_fw[2]; > +const char *qemu_kerndtb = NULL; > >  typedef struct FWBootEntry FWBoot

[Qemu-devel] [PATCH v2 12/18] block: allow waiting only for overlapping writes

2012-01-26 Thread Paolo Bonzini
To implement mismatching block size, we will reuse the request tracking mechanism that is used for copy-on-read. However, waiting for overlapping reads is not needed to protect against "torn reads", so add a flag to wait_for_overlapping_requests. Signed-off-by: Paolo Bonzini --- block.c | 13

Re: [Qemu-devel] [RFC 00/15] Refactor PC machine to take advantage of QOM

2012-01-26 Thread Anthony Liguori
On 01/26/2012 01:12 PM, Peter Maydell wrote: On 26 January 2012 19:00, Anthony Liguori wrote: We need to modeled MemoryRegions and qemu_irq in QOM too. +1 : this ought to let us get rid of SysBus... MemoryRegions shouldn't be that difficult. Our habit of passing qemu_irq's as arrays with

Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option

2012-01-26 Thread Scott Wood
On 01/24/2012 12:23 PM, Stefan Weil wrote: > I'd prefer a different solution. As far as I have understood, > the dtb is only useful with a kernel, so it could be handled > as an optional attribute to the -kernel parameter: > > -kernel IMAGE[,dtb=DTB] > > Of course the same applies to -append,

[Qemu-devel] [PATCH 3/3] qdev: prepare source tree for code conversion

2012-01-26 Thread Andreas Färber
From: Anthony Liguori These are various small stylistic changes which help make things more consistent such that the automated conversion script can be simpler. It's not necessary to agree or disagree with these style changes because all of this code is going to be rewritten by the patch monkey

[Qemu-devel] [PATCH 11/15] i440fx-pmc: refactor to take properties for memory geometry

2012-01-26 Thread Anthony Liguori
--- hw/piix_pci.c | 128 + 1 files changed, 74 insertions(+), 54 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 52bfc7a..dddc95f 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -104,6 +104,11 @@ struct I440FXPMCState {

Re: [Qemu-devel] [libvirt] libvirt doesn't work with qemu 1.0

2012-01-26 Thread Luiz Capitulino
On Wed, 25 Jan 2012 20:55:14 -0700 Eric Blake wrote: > On 12/02/2011 01:32 PM, Anthony Liguori wrote: > >> But we already have to call 'qemu -h' for other reasons; so we might as > >> well be efficient and learn as much as possible from that result than by > >> calling both 'qemu -h' and 'qemu -q

Re: [Qemu-devel] spawning and killing threads in qemu

2012-01-26 Thread Xin Tong
what is that, can you please briefly explain ? Thanks Xin On Thu, Jan 26, 2012 at 1:35 PM, Paolo Bonzini wrote: > On 01/26/2012 07:31 PM, Xin Tong wrote: >> >> When i attach gdb to qemu running in system mode, i often get things like >> >> [Thread 0x7ffed2013700 (LWP 29499) exited] >> [New Thr

[Qemu-devel] [PATCH 10/15] i440fx: move some logic to realize and make inheritance from PCIHost explicit

2012-01-26 Thread Anthony Liguori
--- hw/pci_host.c | 11 hw/pci_host.h |3 ++ hw/piix_pci.c | 72 +++- 3 files changed, 54 insertions(+), 32 deletions(-) diff --git a/hw/pci_host.c b/hw/pci_host.c index 44c6c20..4c9fc49 100644 --- a/hw/pci_host.c +++ b/hw/pci_h

Re: [Qemu-devel] [RFC 00/15] Refactor PC machine to take advantage of QOM

2012-01-26 Thread Peter Maydell
On 26 January 2012 19:00, Anthony Liguori wrote: > We need to modeled MemoryRegions and qemu_irq in QOM too. +1 : this ought to let us get rid of SysBus... >  MemoryRegions > shouldn't be that difficult.  Our habit of passing qemu_irq's as arrays > without > an explicit size will probably requi

[Qemu-devel] [RFC 00/15] Refactor PC machine to take advantage of QOM

2012-01-26 Thread Anthony Liguori
Since I plan to commit a good chunk of QOM tomorrow, I wanted to share some more forward looking work that really starts to take advantage of the new features of QOM. This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this serie

[Qemu-devel] [PATCH v2 15/18] block: align and serialize I/O when guest_block_size < host_block_size

2012-01-26 Thread Paolo Bonzini
When the guest sees a lower alignment than the host, and O_DIRECT is in place, I/O might not span an integer number of host sectors. If this is the case, add a few sectors at the beginning and the end. When reading, copy interesting data from there to the guest buffer. When writing, merge data fro

[Qemu-devel] [PATCH 19/22] block/vdi: Zero unused parts when allocating a new block (fix #919242)

2012-01-26 Thread Kevin Wolf
From: Stefan Weil The new block was filled with zero when it was allocated by g_malloc0, but when it was reused later and only partially used, data from the previously allocated block were still present and written to the new block. This caused the problems reported by bug #919242 (https://bugs.

[Qemu-devel] [PATCH 15/15] i440fx: move ram initialization into i440fx-pmc

2012-01-26 Thread Anthony Liguori
--- hw/pc.c | 44 ++-- hw/pc.h |6 -- hw/piix_pci.c | 46 -- 3 files changed, 34 insertions(+), 62 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 4964a64..90bd638 100644 --- a/hw/pc.c ++

[Qemu-devel] [PATCH v2 09/18] block: add host_block_size

2012-01-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c |4 +++- block_int.h |3 +++ 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 2e1ebeb..af41fb3 100644 --- a/block.c +++ b/block.c @@ -591,6 +591,7 @@ static int bdrv_open_common(BlockDriverState *bs, const

[Qemu-devel] [PATCH v2 18/18] qemu-io: add blocksize argument to open

2012-01-26 Thread Paolo Bonzini
Make it possible to test the alignment code using qemu-io. Signed-off-by: Paolo Bonzini --- qemu-io.c | 33 - 1 files changed, 28 insertions(+), 5 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 7c446b6..268db89 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -

[Qemu-devel] [PATCH 12/22] qmp: add query-block-jobs

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Add query-block-jobs, which shows the progress of ongoing block device operations. Signed-off-by: Stefan Hajnoczi Acked-by: Luiz Capitulino Signed-off-by: Kevin Wolf --- blockdev.c | 33 + hmp.c| 36 +

  1   2   3   >