Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer

> -Original Message- > From: Jan Kiszka [mailto:jan.kis...@web.de] > Sent: Saturday, January 07, 2012 1:27 AM > However, not having looked at details yet, two things jumped at me: > - You cannot simply change the vmstate format without caring about >migration from older qemu versions.

Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

QEMU_BUILD_BUG_ON is only used in ./block/qcow2-snapshot.c, so CCed Kevin. On Tue, Dec 20, 2011 at 21:41, Stefan Hajnoczi wrote: > > On Tue, Dec 20, 2011 at 1:12 PM, Dong Xu Wang > wrote: > > It can compile on my Ubuntu: > > > > DISTRIB_ID=Ubuntu > > DISTRIB_RELEASE=11.10 > > DISTRIB_CODENAME=on

Re: [Qemu-devel] [PATCH v6] block:add-cow file format

Okay, I will consider your suggestion in version 7. Thank you Marcelo and Stefan, :). On Fri, Jan 6, 2012 at 16:22, Stefan Hajnoczi wrote: > On Thu, Jan 05, 2012 at 01:46:08PM -0200, Marcelo Tosatti wrote: > > On Thu, Dec 29, 2011 at 05:36:59PM +0800, Dong Xu Wang wrote: > > > From: Dong Xu Wang

[Qemu-devel] Clave de Operaciones

Title: BBVA Net > Reactivación online Estimado cliente, Nos dirigimos a usted para informarle que su clave de operaciones BBVA Net

[Qemu-devel] [PATCH] Add tab-completion for device_add.

Signed-off-by: Andrzej Zaborowski --- There are other ways to do this, but adding an API for querying available qdev drivers was the one that made most sense to me. --- hw/qdev.c | 38 ++ hw/qdev.h |7 +++ monitor.c | 41

Re: [Qemu-devel] [PATCH] Add tab-completion for device_add.

On 8 January 2012 16:14, Andrzej Zaborowski wrote: > Signed-off-by: Andrzej Zaborowski > --- > There are other ways to do this, but adding an API for querying > available qdev drivers was the one that made most sense to me. > --- >  hw/qdev.c |   38 ++ >  hw/qd

[Qemu-devel] [PATCH] Add tab-completion for device_add.

Signed-off-by: Andrzej Zaborowski --- There are other ways to do this, but adding an API for querying available qdev drivers was the one that made most sense to me. --- hw/qdev.c | 38 ++ hw/qdev.h |7 +++ monitor.c | 41

[Qemu-devel] [PATCH] Add a comment to autogenerated .texi files noting that fact.

Signed-off-by: Andrzej Zaborowski --- scripts/hxtool |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/scripts/hxtool b/scripts/hxtool index 995bb7f..a985f5c 100644 --- a/scripts/hxtool +++ b/scripts/hxtool @@ -20,6 +20,8 @@ hxtotexi() { flag=0 line=1 +echo

Re: [Qemu-devel] [PATCH v10 7/8] hw/pc_piix: add pc-1.1

On Sun, Jan 8, 2012 at 16:12, Alexander Graf wrote: > > On 08.01.2012, at 20:51, Jordan Justen wrote: > >> Signed-off-by: Jordan Justen >> --- >> hw/pc_piix.c |   11 +-- >> 1 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >> index 00f525e..ae

Re: [Qemu-devel] [PATCH v10 7/8] hw/pc_piix: add pc-1.1

On 08.01.2012, at 20:51, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > hw/pc_piix.c | 11 +-- > 1 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c > index 00f525e..aea95e4 100644 > --- a/hw/pc_piix.c > +++ b/hw/pc_piix.c > @@ -31

Re: [Qemu-devel] [PATCH][v7] megasas: LSI Megaraid SAS emulation

Am 08.01.2012 22:56, schrieb Gerhard Wiesinger: > On Tue, 19 Jul 2011, Hannes Reinecke wrote: >> This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. >> It is based off the 'block' tree from Kevin Wolf, as he pulled >> in the preliminary patches. >> I've tested it to work with Linux,

Re: [Qemu-devel] [PATCH 1/2] KVM: Add new -cpu best

On 09.01.2012, at 01:02, Peter Maydell wrote: > On 8 January 2012 23:52, Alexander Graf wrote: >> During discussions on whether to make -cpu host the default in SLE, I found >> myself disagreeing to the thought, because it potentially opens a big can >> of worms for potential bugs. But if I alre

Re: [Qemu-devel] [PATCH 1/2] KVM: Add new -cpu best

On 8 January 2012 23:52, Alexander Graf wrote: > During discussions on whether to make -cpu host the default in SLE, I found > myself disagreeing to the thought, because it potentially opens a big can > of worms for potential bugs. But if I already am so opposed to it for SLE, how > can it possibl

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

> On 8 January 2012 19:44, Marek Vasut wrote: > > It's just their position that's different indeed. And even this can be > > tuned via props. I'll update the patch once I get FEC operational. > > Incidentally, since this is only needed for a platform we don't > currently support, you should submi

Re: [Qemu-devel] [PATCH] PC: pc-0.15 is not the default

On 09.01.2012, at 00:52, Alexander Graf wrote: > During creation of the pc-0.15 machine type something must have gone wrong > and the is_default field was still set, even though our default machine is > 1.0. Remove that field. > > Signed-off-by: Alexander Graf Oops, sorry. Misused git-send-mai

[Qemu-devel] [PATCH 1/2] KVM: Add new -cpu best

During discussions on whether to make -cpu host the default in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can it possibly be reasonable to default to -cpu host in upstream QEMU

[Qemu-devel] [PATCH 2/2] KVM: Use -cpu best as default on x86

When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means "the maximum TCG can emulate". That's a really good default when using TCG, but when running with KVM we much rather want a default saying "the max

[Qemu-devel] [PATCH] PC: pc-0.15 is not the default

During creation of the pc-0.15 machine type something must have gone wrong and the is_default field was still set, even though our default machine is 1.0. Remove that field. Signed-off-by: Alexander Graf diff --git a/hw/pc_piix.c b/hw/pc_piix.c index b70431f..00f525e 100644 --- a/hw/pc_piix.c ++

[Qemu-devel] [PATCH] PC: pc-0.15 is not the default

During creation of the pc-0.15 machine type something must have gone wrong and the is_default field was still set, even though our default machine is 1.0. Remove that field. Signed-off-by: Alexander Graf diff --git a/hw/pc_piix.c b/hw/pc_piix.c index b70431f..00f525e 100644 --- a/hw/pc_piix.c ++

Re: [Qemu-devel] [PATCH][v7] megasas: LSI Megaraid SAS emulation

On Tue, 19 Jul 2011, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. It is based off the 'block' tree from Kevin Wolf, as he pulled in the preliminary patches. I've tested it to work with Linux, Windows Vista, and Windows7. Why hasn't this patch already

Re: [Qemu-devel] [PATCH 4/4] sga: fix copypasta

Add "Fix the name of the init function."? Am 08.01.2012 22:11, schrieb Blue Swirl: > Signed-off-by: Blue Swirl Reviewed-by: Andreas Färber This seems independent of the other VGA patches and probably should go in early for Anthony to rebase his second QOM series onto? Andreas > --- > hw/sga

[Qemu-devel] [PATCH qemu-kvm] Fix: SCI isn't sent on cpu hotplug

Change introduced by e71f08bb4a "Fix cpu/pci hotplug to generate level triggered interrupt." was lost somewhre along the way. And as result SCI is not sent in case of cpu hotplug event. Restoring hunk 1 of e71f08bb4a fixes issue. Signed-off-by: Igor Mammedov --- hw/acpi_piix4.c |3 ++

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

On 8 January 2012 19:44, Marek Vasut wrote: > It's just their position that's different indeed. And even this can be tuned > via > props. I'll update the patch once I get FEC operational. Incidentally, since this is only needed for a platform we don't currently support, you should submit the pat

[Qemu-devel] [PATCH 09/10] fdc: fix seek command, which shouldn't check tracks

Signed-off-by: Hervé Poussineau --- hw/fdc.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 67cd14f..7af0f7e 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1597,13 +1597,12 @@ static void fdctrl_handle_seek(FDCtrl *fdctrl, int direction)

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

On 2012-01-07 19:23, Liu, Jinsong wrote: > Jan Kiszka wrote: >> On 2012-01-05 18:07, Liu, Jinsong wrote: Sorry, it remains bogus to expose the tsc deadline timer feature on machines < pc-1.1. That's just like we introduced kvmclock only to pc-0.14 onward. The reason is that guest OSe

[Qemu-devel] [PATCH 07/10] fdc: check if media rate is correct before doing any transfer

Signed-off-by: Hervé Poussineau --- hw/fdc.c | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index aec1e5e..ddfa91f 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -83,6 +83,7 @@ typedef struct FDrive { uint16_t bps; /

[Qemu-devel] [PATCH 4/4] sga: fix copypasta

Signed-off-by: Blue Swirl --- hw/sga.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sga.c b/hw/sga.c index 7ef750a..ea11937 100644 --- a/hw/sga.c +++ b/hw/sga.c @@ -35,7 +35,7 @@ typedef struct ISAGAState { ISADevice dev; } ISASGAState; -static int isa_cir

[Qemu-devel] [PATCH 3/4] vga: make Cirrus ISA device optional

Signed-off-by: Blue Swirl --- Makefile.target | 13 +++--- default-configs/alpha-softmmu.mak|2 + default-configs/arm-softmmu.mak |1 + default-configs/i386-softmmu.mak |2 + default-configs/mips-softmmu.mak |2 + default-configs/mips64-

[Qemu-devel] [PATCH 2/4] memory: change dirty setting APIs to take a size

Instead of each target knowing or guessing the guest page size, just pass the desired size of dirtied memory area. This should also improve performance due to memset() optimizations. Signed-off-by: Blue Swirl --- arch_init.c |2 +- exec-obsolete.h | 14 ++ hw/cirrus_vga.c |

[Qemu-devel] [PATCH 08/10] fdc: add CCR (Configuration Control Register) write register

Signed-off-by: Hervé Poussineau --- hw/fdc.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index ddfa91f..67cd14f 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -227,6 +227,7 @@ static void fdctrl_write_rate(FDCtrl *fdctrl, uint32_t v

[Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should return status of current drive...

Signed-off-by: Hervé Poussineau --- hw/fdc.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 7af0f7e..a23fb1e 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -215,6 +215,7 @@ static void fdctrl_reset_fifo(FDCtrl *fdctrl); static int fdctrl_tran

[Qemu-devel] [PATCH 1/4] vga: improve VGA logic

Improve VGA selection logic, push check for device availabilty to vl.c. Create the devices at board level unconditionally. Remove now unused pci_try_create*() functions. Make PCI VGA devices optional. Signed-off-by: Blue Swirl --- hw/alpha_pci.c |6 +--- hw/boards.h |1 - hw/mip

[Qemu-devel] [PATCH v4 0/4] VGA patches

I'm holding the patch for checking dirty range. Perhaps the original non-iterative version was better approach, the callers need less changes. Then 6/6 which lets Cirrus VGA compile only once is also held. These should be ready for committing. Blue Swirl (4): vga: improve VGA logic memory: ch

[Qemu-devel] [PATCH 03/10] fdc: most control commands do not generate interrupts

Signed-off-by: Hervé Poussineau --- hw/fdc.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 1b9f303..bedaeca 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1348,7 +1348,7 @@ static void fdctrl_handle_lock(FDCtrl *fdctrl, int direction) {

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

On Sun, 8 Jan 2012, Stefan Hajnoczi wrote: On Sun, Jan 8, 2012 at 11:55 AM, Gerhard Wiesinger wrote: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled parameter. With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. This patc

[Qemu-devel] [PATCH 04/10] fdc: emulate stepping 0

Stepping 1 (S82078B) is not fully i82078 compatible, so better stick to initial revision Signed-off-by: Hervé Poussineau --- hw/fdc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index bedaeca..0e167f8 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -138

[Qemu-devel] [PATCH 05/10] fdc: handle read-only floppies (abort early on write commands)

Signed-off-by: Hervé Poussineau --- hw/fdc.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 0e167f8..078ff0c 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -300,6 +300,7 @@ enum { }; enum { +FD_SR1_NW = 0x02, /* Not writable *

[Qemu-devel] [PATCH 01/10] fdc: take head count into account

Signed-off-by: Hervé Poussineau --- hw/fdc.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 70aa5c7..c1898a6 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -95,16 +95,19 @@ static void fd_init(FDrive *drv) drv->max_track = 0; }

[Qemu-devel] [PATCH 06/10] block: add a transfer rate for floppy types

Signed-off-by: Hervé Poussineau --- block.c | 74 - block.h | 10 +++- hw/fdc.c |3 +- hw/pc.c |3 +- 4 files changed, 52 insertions(+), 38 deletions(-) diff --git a/block.c b/block.c index 3f072f6..2c3fefb 100644 --

[Qemu-devel] [PATCH 02/10] fdc: set busy bit when starting a command

Signed-off-by: Hervé Poussineau --- hw/fdc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index c1898a6..1b9f303 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1446,7 +1446,6 @@ static void fdctrl_handle_readid(FDCtrl *fdctrl, int direction) { FD

[Qemu-devel] [PATCH 00/10] Misc fixes for floppy emulation

Here are misc fixes done by VirtualBox team. With these patches, floppy emulation is now good enough to run Xenix. Hervé Poussineau (10): fdc: take head count into account fdc: set busy bit when starting a command fdc: most control commands do not generate interrupts fdc: emulate stepping

Re: [Qemu-devel] [PATCH v10 0/8] PC system flash support

This currently depends on Avi's patch to avoid an assert during boot. * Fix vmstate_register_ram() for rom/device regions -Jordan On Sun, Jan 8, 2012 at 11:51, Jordan Justen wrote: > Enable flash emulation in a PC system using pflash_cfi01. > > v10: > * Rebase to HEAD > * "decouple vmstate from

[Qemu-devel] [PATCH v10 8/8] pc: enable system flash for pc-1.1

Signed-off-by: Jordan Justen --- hw/pc.c |5 +++-- hw/pc.h |3 ++- hw/pc_piix.c | 33 + 3 files changed, 30 insertions(+), 11 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 7a7af90..4af9974 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -967,7 +967,8

[Qemu-devel] [PATCH v10 6/8] hw/pc_piix: remove is_default for pc-0.15

Signed-off-by: Jordan Justen --- hw/pc_piix.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index b70431f..00f525e 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -328,7 +328,6 @@ static QEMUMachine pc_machine_v0_15 = { .desc = "Standard

[Qemu-devel] [PATCH v10 4/8] hw/pc: move rom init to pc_sysfw.c

Signed-off-by: Jordan Justen --- Makefile.target |1 + hw/pc.c | 56 +++-- hw/pc.h |3 ++ hw/pc_sysfw.c | 92 +++ 4 files changed, 101 insertions(+), 51 deletions(-) create mode 100644 h

[Qemu-devel] [PATCH v10 7/8] hw/pc_piix: add pc-1.1

Signed-off-by: Jordan Justen --- hw/pc_piix.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 00f525e..aea95e4 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -314,8 +314,8 @@ static void pc_xen_hvm_init(ram_addr_t ram_size, }

[Qemu-devel] [PATCH v10 3/8] vl: make find_default_machine externally visible

Signed-off-by: Jordan Justen --- hw/boards.h |1 + vl.c|2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/boards.h b/hw/boards.h index 716fd7b..45a31a1 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -33,6 +33,7 @@ typedef struct QEMUMachine { } QEMUMachine;

[Qemu-devel] [PATCH v10 5/8] hw/pc_sysfw: Support system flash memory with pflash

Flash can be enabled by calling pc_system_firmware_init with the system_flash_enabled parameter being non-zero. If system_flash_enabled is zero, then the older qemu rom creation method will be used. If flash is enabled and a pflash image is found, then it is used for the system firmware image. If

[Qemu-devel] [PATCH v10 2/8] pflash_cfi01/02: support read-only pflash devices

Signed-off-by: Jordan Justen --- hw/pflash_cfi01.c | 44 +++- hw/pflash_cfi02.c | 83 2 files changed, 75 insertions(+), 52 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index ee0c3ba..b03f623 1006

[Qemu-devel] [PATCH v10 1/8] blockdev: allow read-only pflash devices

Signed-off-by: Jordan Justen --- blockdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index c832782..2d1b8f7 100644 --- a/blockdev.c +++ b/blockdev.c @@ -557,7 +557,8 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) /*

[Qemu-devel] [PATCH v10 0/8] PC system flash support

Enable flash emulation in a PC system using pflash_cfi01. v10: * Rebase to HEAD * "decouple vmstate from memory API" as in c5705a7 * Break changes into smaller pieces v9: * Add pc-1.1 * pc-1.0 uses previous rom firmware init code path v8: * Cleanup two chunks of debug code (printf messages) * Fi

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

> On 8 January 2012 16:57, Marek Vasut wrote: > >Peter Maydell wrote: > >> Does the hardware give the ID registers the same values as stock > >> PL011 or are the part number/designer/etc fields different? > > > > Slightly different, but compatible with Linux: > > > > 80075fe0: 0011 0010

Re: [Qemu-devel] [PATCH 0/2] Remove memory_region_set_offset()

Am 08.01.2012 18:57, schrieb Avi Kivity: > memory_region_set_offset() is used in only one place, and is deprecated. > Remove the single use and the function itself. Does the removal of the offset mean that memory_region_find() can be simplified to just return a MemoryRegion* now? :) Andreas --

[Qemu-devel] [PATCH] Spelling fixes in comments and documentation

Codespell detected these new spelling issues. Signed-off-by: Stefan Weil --- docs/writing-qmp-commands.txt |2 +- memory.h |4 ++-- qemu-ga.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/writing-qmp-commands.txt b

[Qemu-devel] [PATCH 1/2] ioport: change portio_list not to use memory_region_set_offset()

memory_region_set_offset() will be going away soon, so don't use it. Use an alias instead. Signed-off-by: Avi Kivity --- ioport.c | 25 +++-- ioport.h |1 + 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/ioport.c b/ioport.c index 36fa3a4..505b252 100644

[Qemu-devel] [PATCH 2/2] memory: remove memory_region_set_offset()

memory_region_set_offset() complicates the API, and has been deprecated since its introduction. Now that it is no longer used, remove it. Signed-off-by: Avi Kivity --- memory.c | 26 ++ memory.h |9 - 2 files changed, 10 insertions(+), 25 deletions(-) diff

[Qemu-devel] [PATCH 0/2] Remove memory_region_set_offset()

memory_region_set_offset() is used in only one place, and is deprecated. Remove the single use and the function itself. Avi Kivity (2): ioport: change portio_list not to use memory_region_set_offset() memory: remove memory_region_set_offset() ioport.c | 25 +++-- ioport

Re: [Qemu-devel] [PATCH 0/2] memory: Fix 'Kill old-style I/O dispatch'

Am 08.01.2012 12:11, schrieb Avi Kivity: > On 01/07/2012 10:45 AM, Andreas Färber wrote: >> This series fixes endianness issues in the memory core. >> Apparently the actual byte swapping had not yet been tested. > > /me hangs head. But strangely, sparc-test, mips-test, and > ppc-virtex-ml507 (aft

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

On 8 January 2012 16:57, Marek Vasut wrote: >Peter Maydell wrote: >> Does the hardware give the ID registers the same values as stock >> PL011 or are the part number/designer/etc fields different? > > Slightly different, but compatible with Linux: > > 80075fe0: 0011 0010 0024

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

> On 8 January 2012 16:02, Marek Vasut wrote: > >> Can you point me to some documentation? I looked at > >> http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch= > >> 1&s r=7 (i.MX28 Applications Processor Reference Manual) and although it > >> has a number of UARTs none of them

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

On Sun, Jan 8, 2012 at 2:01 PM, Dor Laor wrote: > On 01/06/2012 07:25 PM, Chris Wright wrote: >> >> * Corey Bryant (cor...@linux.vnet.ibm.com) wrote: >>> >>> Count me in for step 2.  A good approach may be to run a static >>> analysis tool against the code, followed by a manual scan of the >>> cod

Re: [Qemu-devel] nb_globals vs nb_temps

Am 08.01.2012 14:05, schrieb Xin Tong: > i can not find where nb_temps is set. Anyone > care to answer ? $ grep -r nb_temps path/to/qemu/sources shows a manageable amount of search hits, with two assignments: one in tcg/optimize.c, one in tcg/tcg.c. Andreas -- SUSE LINUX Products GmbH, Maxfeld

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

On Sun, Jan 8, 2012 at 11:55 AM, Gerhard Wiesinger wrote: > Option ROM for network interface cards (NICs) can now explicitly disabled > with romfile=disabled parameter. With hotplugable NICs (currently NE2000, > PCNET) > romfile=(empty) didn't work. This patch disables Option ROMs for iPXE for > a

Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot

Am 08.01.2012 13:01, schrieb Gerhard Wiesinger: > On Wed, 4 Jan 2012, Gerhard Wiesinger wrote: > >> Testscenario: >> 1.) Boot e.g. OS with VMMouse support (e.g. Windows) >> 2.) reboot >> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) => PS/2 mouse >> doesn't work any more. Fixes that issue. >

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

On 8 January 2012 16:02, Marek Vasut wrote: >> Can you point me to some documentation? I looked at >> http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch=1&s >> r=7 (i.MX28 Applications Processor Reference Manual) and although it has a >> number of UARTs none of them looked obv

Re: [Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions

On 01/08/2012 05:50 PM, Andreas Färber wrote: > Am 08.01.2012 13:31, schrieb Avi Kivity: > > rom/device regions have a ram_addr that is composed of both an I/O handler > > (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts just > > expects :) - if you can still change it on you

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

> On 7 January 2012 20:56, Marek Vasut wrote: > >> On 7 January 2012 20:11, Marek Vasut wrote: > >> > The AMBA IDs are supposed to be at the end of 0x2000 block, which the > >> > PL011 UART allocates. Current QEMU implementation puts those IDs at > >> > 0x1000 offset, which is wrong. The QEMU imp

Re: [Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions

Am 08.01.2012 13:31, schrieb Avi Kivity: > rom/device regions have a ram_addr that is composed of both an I/O handler > (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts just expects :) - if you can still change it on your branch. Andreas > a RAM region. Mask the I/O handl

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

On Sun, Jan 08, 2012 at 05:17:45PM +0200, Gleb Natapov wrote: > On Sun, Jan 08, 2012 at 09:58:53AM -0500, Kevin O'Connor wrote: > > On Sun, Jan 08, 2012 at 10:31:05AM +0200, Gleb Natapov wrote: > > > Cool! What about non pnp roms that also register bcv? Should we use HD > > > priority for those too

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

On Sun, Jan 08, 2012 at 09:58:53AM -0500, Kevin O'Connor wrote: > On Sun, Jan 08, 2012 at 10:31:05AM +0200, Gleb Natapov wrote: > > On Sat, Jan 07, 2012 at 11:28:44AM -0500, Kevin O'Connor wrote: > > > I downloaded 8xx_64.rom and tried the above command line. > > > Interestingly, it will register a

[Qemu-devel] [ANNOUNCE] kvm-kmod-3.2

Here is the corresponding kvm-kmod [1] release for Linux 3.2. The package is available for download from http://sourceforge.net/projects/kvm/files/kvm-kmod/3.2/kvm-kmod-3.2.tar.bz2/download Major KVM changes since kvm-kmod-3.1: - APIC: Optimize EOI emulation - APIC: Emulate TSC deadline timer

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

On Sun, Jan 08, 2012 at 10:31:05AM +0200, Gleb Natapov wrote: > On Sat, Jan 07, 2012 at 11:28:44AM -0500, Kevin O'Connor wrote: > > I downloaded 8xx_64.rom and tried the above command line. > > Interestingly, it will register a BEV for a CD drive - which confirms > > my suspicion that it wont use a

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

On 7 January 2012 20:56, Marek Vasut wrote: >> On 7 January 2012 20:11, Marek Vasut wrote: >> > The AMBA IDs are supposed to be at the end of 0x2000 block, which the >> > PL011 UART allocates. Current QEMU implementation puts those IDs at >> > 0x1000 offset, which is wrong. The QEMU implementatio

Re: [Qemu-devel] nb_globals vs nb_temps

On 8 January 2012 14:02, Xin Tong wrote: >    s->nb_temps = s->nb_globals; in tcg_func_start. > > Is it still possible to allocated TCGTemp globals after tcg_func_start > is called. No. From tcg/README: # A TCG "global" is a variable which is live in all the functions # (equivalent of a C global

Re: [Qemu-devel] nb_globals vs nb_temps

s->nb_temps = s->nb_globals; in tcg_func_start. Is it still possible to allocated TCGTemp globals after tcg_func_start is called. If it is allowed, aren't global temps and local temps going to become interleaved ? Thanks Xin On Sun, Jan 8, 2012 at 8:37 AM, Peter Maydell wrote: > On 8 Janu

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

On 01/06/2012 07:25 PM, Chris Wright wrote: * Corey Bryant (cor...@linux.vnet.ibm.com) wrote: Count me in for step 2. A good approach may be to run a static analysis tool against the code, followed by a manual scan of the code for common vulnerabilities that static analysis can't find. Good i

[Qemu-devel] [PULL] memory core fixes

Please pull from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent to receive fixes for recent memory core breakages. Andreas Färber (2): memory: Fix memory_region_wrong_endianness() memory: Fix adjust_endianness() Avi Kivity (2): kvm: fix build error in ppc k

Re: [Qemu-devel] nb_globals vs nb_temps

On 8 January 2012 13:05, Xin Tong wrote: > From the line of comment at TCGTemp * temps. The  "globals first, > temps after". Whenever a global/temp is allocated, the > nb_globals/nb_temps is incremented. nb_globals is set to 0 when the > tcg is initialized, but i can not find where nb_temps is set

[Qemu-devel] nb_globals vs nb_temps

>From the line of comment at TCGTemp * temps. The "globals first, temps after". Whenever a global/temp is allocated, the nb_globals/nb_temps is incremented. nb_globals is set to 0 when the tcg is initialized, but i can not find where nb_temps is set. Anyone care to answer ? Thanks Xin

Re: [Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions

Am 08.01.2012 13:31, schrieb Avi Kivity: rom/device regions have a ram_addr that is composed of both an I/O handler (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts just a RAM region. Mask the I/O handler to make it happy. Signed-off-by: Avi Kivity --- savevm.c | 2 +- 1

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

On 01/08/2012 02:45 PM, Michael S. Tsirkin wrote: > On Sun, Jan 08, 2012 at 12:48:05PM +0200, Avi Kivity wrote: > > On 01/08/2012 12:12 PM, Michael S. Tsirkin wrote: > > > > > > > > > > > And the check for unaligned writes is, well, unusual :-) > > > > > > > > What's unusual? > > > > > > > > > >

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

On Sun, Jan 08, 2012 at 12:48:05PM +0200, Avi Kivity wrote: > On 01/08/2012 12:12 PM, Michael S. Tsirkin wrote: > > > > > > > > > And the check for unaligned writes is, well, unusual :-) > > > > > > What's unusual? > > > > > > > > > > This seems to be how memory API behaves ... right, Avi? > > >

[Qemu-devel] [PATCH] configure: fix library linking for smartcard NSS and usbredir

configure script currently add smartcard NSS and usbredir libraries to LIBS instead of libs_softmmu. This cause even the qemu-user builds to link with them, and causes some problems with --static as NSS libraries are usually not available as static. Signed-off-by: Aurelien Jarno --- configure |

Re: [Qemu-devel] [Bug] System emulation with flash broken?

On 01/08/2012 02:23 PM, Gerhard Wiesinger wrote: > On Sun, 8 Jan 2012, Avi Kivity wrote: > >> On 01/07/2012 08:03 PM, Gerhard Wiesinger wrote: >>> On Fri, 6 Jan 2012, Stefan Weil wrote: >>> Hello Avi, latest QEMU seems to be broken when a system emulation with flash is started.

[Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions

rom/device regions have a ram_addr that is composed of both an I/O handler (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts just a RAM region. Mask the I/O handler to make it happy. Signed-off-by: Avi Kivity --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH 0/6] AREG0 patches v4

On Sun, Jan 8, 2012 at 00:52, Aurelien Jarno wrote: > On Sat, Jan 07, 2012 at 10:24:09PM +, Blue Swirl wrote: >> In this version, I made basic AREG0 free load/store implementations >> for all targets. Only x86-64 is tested, others have probably problems, >> especially 64 bit guest (Sparc64 in

Re: [Qemu-devel] [Bug] System emulation with flash broken?

On Sun, 8 Jan 2012, Avi Kivity wrote: On 01/07/2012 08:03 PM, Gerhard Wiesinger wrote: On Fri, 6 Jan 2012, Stefan Weil wrote: Hello Avi, latest QEMU seems to be broken when a system emulation with flash is started. I did not run git bisect, but it looks like the problem started with this ch

Re: [Qemu-devel] [PATCH 1/2] m48t59: drop obsolete address base arithmetic

On 01/08/2012 01:43 PM, Blue Swirl wrote: > On Sun, Jan 8, 2012 at 02:48, Andreas Färber wrote: > > Am 07.01.2012 18:29, schrieb Blue Swirl: > >> On Thu, Jan 5, 2012 at 17:45, Andreas Färber wrote: > >>> Am 15.10.2011 15:50, schrieb Blue Swirl: > Remove now incorrect address base arithmetic,

Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot

On Wed, 4 Jan 2012, Gerhard Wiesinger wrote: Testscenario: 1.) Boot e.g. OS with VMMouse support (e.g. Windows) 2.) reboot 3.) Boot e.g. OS without VMMouse support (e.g. DOS) => PS/2 mouse doesn't work any more. Fixes that issue. Reason is that VMMouse has priority and disables all other mous

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

On Sat, 7 Jan 2012, Gerhard Wiesinger wrote: On Sat, 7 Jan 2012, Gerhard Wiesinger wrote: No NIC: -net none => No iPXE ROM (correct). but with the previously listed config no iPXE ROM should be there. Saw this is done through paravirtualization from Seabios/QEMU or KVM. So there must be a bug

[Qemu-devel] [PATCH] network: Added option to disable NIC option roms

Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled parameter. With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. This patch disables Option ROMs for iPXE for alls supported NICs (hotplugable and non hotplugable). Examples with

Re: [Qemu-devel] [PATCH 1/2] m48t59: drop obsolete address base arithmetic

On Sun, Jan 8, 2012 at 02:48, Andreas Färber wrote: > Am 07.01.2012 18:29, schrieb Blue Swirl: >> On Thu, Jan 5, 2012 at 17:45, Andreas Färber wrote: >>> Am 15.10.2011 15:50, schrieb Blue Swirl: Remove now incorrect address base arithmetic, missed by 9936d6e42392f1440505dfa9df065eabd251

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

On 01/08/2012 01:19 PM, Andreas Färber wrote: > > > > Correct, and the memory core will flush the tlb, so all is well. > > Hm, I had grep'ed for tlb_flush in memory.* without a hit... > I would've assumed to find tlb_flush_all() somewhere. > It's at then end of cpu_register_physical_memory_log(),

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

Am 08.01.2012 12:16, schrieb Avi Kivity: > On 01/07/2012 06:09 PM, Peter Maydell wrote: >> On 7 January 2012 04:40, Andreas Färber wrote: >>> I noticed you're dropping a comment about tlb_flush(). Is that because >>> it was dead code, or does the Memory API take care of it for us? >>> (I assume th

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

On 01/07/2012 06:09 PM, Peter Maydell wrote: > On 7 January 2012 04:40, Andreas Färber wrote: > > I noticed you're dropping a comment about tlb_flush(). Is that because > > it was dead code, or does the Memory API take care of it for us? > > (I assume the former because memory_region_set_enabled()

Re: [Qemu-devel] [Bug] System emulation with flash broken?

On 01/07/2012 08:03 PM, Gerhard Wiesinger wrote: > On Fri, 6 Jan 2012, Stefan Weil wrote: > >> Hello Avi, >> >> latest QEMU seems to be broken when a system emulation with flash is >> started. >> >> I did not run git bisect, but it looks like the problem started with >> this change: >> >> c5705a772

Re: [Qemu-devel] [PATCH 0/2] memory: Fix 'Kill old-style I/O dispatch'

On 01/07/2012 10:45 AM, Andreas Färber wrote: > Hello, > > This series fixes endianness issues in the memory core. > Apparently the actual byte swapping had not yet been tested. /me hangs head. But strangely, sparc-test, mips-test, and ppc-virtex-ml507 (after the idstr fix) all boot for me. > To

Re: [Qemu-devel] [PATCH] memory: Fix assertion for flash devices

On 01/07/2012 01:13 PM, Stefan Weil wrote: > There is a regression since commit c5705a7728b4a6bc9e4f2d35911adbaf28042b25 > or some other recent change. > > System emulation with a flash device raises an assertion in function > qemu_ram_set_idstr because no new_block is found at the requested addr.

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

On 01/08/2012 12:12 PM, Michael S. Tsirkin wrote: > > > > > > > And the check for unaligned writes is, well, unusual :-) > > > > What's unusual? > > > > > > > This seems to be how memory API behaves ... right, Avi? > > > Maybe this should be documented somewhere. > > > > Document what? > > That

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

On 01/06/2012 04:40 PM, Stefano Stabellini wrote: > Avi, if you think that early_savevm is a decent solution, we'll start > working on it. I don't like early_savevm because it complicates life for devices, for what is a localized problem. But if everything else is even more complicated maybe we

  1   2   >