Re: [Qemu-devel] [PATCH 13/16] Direct dispatch through MemoryRegion

2012-01-06 Thread Andreas Färber
Am 02.01.2012 17:33, schrieb Avi Kivity: > Now that all mmio goes through MemoryRegions, we can convert > io_mem_opaque to be a MemoryRegion pointer, and remove the thunks > that convert from old-style CPU{Read,Write}MemoryFunc to MemoryRegionOps. > > Signed-off-by: Avi Kivity > diff --git a/mem

Re: [Qemu-devel] [PATCH 01/16] memory: move endianness compensation to memory core

2012-01-06 Thread Andreas Färber
Am 02.01.2012 17:33, schrieb Avi Kivity: > Instead of doing device endianness compensation in cpu_register_io_memory(), > do it in the memory core. > > Signed-off-by: Avi Kivity > diff --git a/exec.c b/exec.c > index 28c057c..507d37c 100644 > --- a/exec.c > +++ b/exec.c > @@ -3666,30 +3565,14 @

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-06 Thread Andreas Färber
Am 06.01.2012 19:58, schrieb Peter Maydell: > Use the new memory mutator API to simplify the flash remap code; > this allows us to drop the flash_mapped flag. > > Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber I noticed you're dropping a comment about tlb_flush(). Is that because it

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Andreas Färber
Am 07.01.2012 04:14, schrieb Peter Maydell: > On 6 January 2012 20:11, Andreas Färber wrote: >> Not sure how hardcoding the cpu_model would work with CPU features, >> would they be still included or stripped out before. Peter? > > Interesting question. It's certainly more likely to work to have >

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 21:16, Mark Langsdorf wrote: > Assuming that I'm going to need save/restore support, what's > the proper syntax for saving uint32_t *regs? All the uses I > can find seem to be for an array of structs, not an array > of ints, and I keep hoping there's a simpler way. VMSTATE_UINT3

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 20:11, Andreas Färber wrote: > Not sure how hardcoding the cpu_model would work with CPU features, > would they be still included or stripped out before. Peter? Interesting question. It's certainly more likely to work to have a board where the only tweak you made to the CPU was

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Peter Maydell
On 6 January 2012 20:42, Anthony Liguori wrote: > On 01/06/2012 02:02 PM, Andreas Färber wrote: >> i) Unless it's a build fix, I propose defining a minimum review time >> before a patch is applied to a (sub)maintainer's queue. > I disagree here.  If anything, I think we wait a bit too long for pe

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-06 Thread Kevin O'Connor
On Fri, Jan 06, 2012 at 07:27:25AM +0200, Gleb Natapov wrote: > On Thu, Jan 05, 2012 at 09:05:39PM -0500, Kevin O'Connor wrote: > > SeaBIOS could probably fall back to the harddrive priority if it finds > > a BCV without an explicit bootindex priority. > The same option rom probably will register b

[Qemu-devel] [Bug 912983] [NEW] Unable to install OS/2 Warp v3 past disk 2

2012-01-06 Thread multitude
Public bug reported: To whom it may concern, As you may (or may not) be aware, QEMU is currently unable to readily install OS/2 Warp v3 (OS2W3) when asked for Installation Diskette 2 (http://www.claunia.com/qemu/objectManager.php?sClass=version&iId=132&iTestingId=138). QEMU 0.8.2 is the last kno

Re: [Qemu-devel] [PATCH 04/30] ppc_prep: convert host bridge to qdev

2012-01-06 Thread Andreas Färber
Am 03.01.2012 15:57, schrieb Andreas Färber: > Am 03.01.2012 01:51, schrieb Anthony Liguori: >> Untested beyond compile. But it's a very simple conversion. >> >> Signed-off-by: Anthony Liguori > > Seems like we've crossed paths now. I have a more complete patch using > different naming Minimal

[Qemu-devel] [PATCH v2 2/3] prep: Add Raven PCI host SysBus device

2012-01-06 Thread Andreas Färber
For now, focus on qdev'ification and leave PIC IRQs unchanged. Signed-off-by: Andreas Färber Cc: Hervé Poussineau Cc: Michael S. Tsirkin Cc: Anthony Liguori --- hw/prep_pci.c | 41 +++-- 1 files changed, 31 insertions(+), 10 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH v2 1/3] prep: qdev'ify Raven host bridge

2012-01-06 Thread Andreas Färber
Move initialization of vendor ID, etc. to PCIDeviceInfo. Add VMState. Signed-off-by: Andreas Färber Cc: Hervé Poussineau Cc: Michael S. Tsirkin Cc: Anthony Liguori --- hw/prep_pci.c | 55 ++- 1 files changed, 46 insertions(+), 9 deletions(

[Qemu-devel] [PATCH v2 0/3] qdev'ify PReP PCI host bridge

2012-01-06 Thread Andreas Färber
Hello Anthony and Hervé, Here's my rebased qdev'ification of PReP PCI host. It is tested not to make things worse than they are already. I've split up my original patch and did some renaming to make it better readable. Please compare it to yours; it is intended to go in before the second QOM s

[Qemu-devel] [PATCH v2 3/3] MAINTAINERS: Add PCI host bridge files to PReP machine

2012-01-06 Thread Andreas Färber
Signed-off-by: Andreas Färber --- MAINTAINERS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 764c92d..6e9cd33 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -307,6 +307,7 @@ PReP M: Andreas Färber S: Odd Fixes F: hw/ppc_prep.c +F: hw/pr

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Mark Langsdorf
On 01/06/2012 10:29 AM, Peter Maydell wrote: > On 5 January 2012 20:02, Mark Langsdorf wrote: >> +static void hb_regs_write(void *opaque, target_phys_addr_t offset, >> + uint64_t value, unsigned size) >> +{ >> +uint32_t *regs = opaque; >> + >> +if (offset == 0xf00)

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-06 Thread Michael Roth
On 01/06/2012 01:04 PM, Luiz Capitulino wrote: On Thu, 05 Jan 2012 15:41:33 -0600 Michael Roth wrote: On 01/05/2012 02:25 PM, Luiz Capitulino wrote: On Thu, 05 Jan 2012 09:10:50 -0600 Michael Roth wrote: On 01/05/2012 08:42 AM, Luiz Capitulino wrote: On Thu, 5 Jan 2012 12:59:27 + "Da

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Anthony Liguori
On 01/06/2012 02:02 PM, Andreas Färber wrote: Am 06.01.2012 16:19, schrieb Anthony Liguori: I'd like to start a more formal and transparent security audit of QEMU. The way I'd imagine it working is something like this: I'd like to propose something else: We should define a more formal process

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Luiz Capitulino
On Fri, 06 Jan 2012 14:09:41 -0600 Michael Roth wrote: > On 01/06/2012 01:06 PM, Luiz Capitulino wrote: > > On Fri, 6 Jan 2012 17:05:53 + > > "Daniel P. Berrange" wrote: > > > >> On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: > >>> On 01/06/2012 04:56 AM, Daniel P. Berrange wr

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Andreas Färber
Am 06.01.2012 20:10, schrieb Igor Mitsyanko: > On 01/06/2012 10:45 PM, Peter Maydell wrote: >> On 6 January 2012 18:37, Igor Mitsyanko wrote: >>> On 01/06/2012 12:02 AM, Mark Langsdorf wrote: +if (!cpu_model) { +cpu_model = "cortex-a9"; +} >>> >>> >>> Google said the

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Michael Roth
On 01/06/2012 01:06 PM, Luiz Capitulino wrote: On Fri, 6 Jan 2012 17:05:53 + "Daniel P. Berrange" wrote: On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: On 01/05

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Andreas Färber
Am 06.01.2012 16:19, schrieb Anthony Liguori: > I'd like to start a more formal and transparent security audit of QEMU. > The way I'd imagine it working is something like this: I'd like to propose something else: We should define a more formal process for reviewing and applying patches in the fir

Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend

2012-01-06 Thread Stefan Hajnoczi
On Fri, Jan 6, 2012 at 7:16 PM, Kamil Rytarowski wrote: > ping! Looks good to me. Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [libvirt] QMP: Supporting off tree APIs

2012-01-06 Thread Luiz Capitulino
On Fri, 06 Jan 2012 09:08:19 -0600 Anthony Liguori wrote: > On 01/06/2012 06:45 AM, Luiz Capitulino wrote: > > On Fri, 6 Jan 2012 11:06:12 + > > Stefan Hajnoczi wrote: > > > >> Proper async support - if you mean the ability to have multiple QMP > >> commands pending at a time - is harder tha

Re: [Qemu-devel] Incorrect hw/omap_dss.c:chip[] index for RFBI_READ and RFBI_STATUS?

2012-01-06 Thread andrzej zaborowski
Hi, On 6 January 2012 17:55, Stefan Hajnoczi wrote: > Is the following code correct in hw/omap_dss.c: > > case 0x58:  /* RFBI_READ */ >    if ((s->rfbi.control & (1 << 2)) && s->rfbi.chip[0]) >        s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 1); >    else if ((s->rfbi.contro

[Qemu-devel] [PATCH v4 1/2] hw/integratorcp: Fix sense of REMAP bit

2012-01-06 Thread Peter Maydell
Fix the sense of the REMAP bit: 0 should mean "map flash", 1 should mean "map RAM". Signed-off-by: Peter Maydell --- hw/integratorcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index c8f3955..d9d8da3 100644 --- a/hw/integrator

[Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-06 Thread Peter Maydell
Use the new memory mutator API to simplify the flash remap code; this allows us to drop the flash_mapped flag. Signed-off-by: Peter Maydell --- hw/integratorcp.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp

Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend

2012-01-06 Thread Kamil Rytarowski
W dniu 29.11.2011 20:55, Benjamin pisze: Signed-off-by: Benjamin --- net.c |6 - net/socket.c| 73 +- qemu-options.hx |2 + 3 files changed, 78 insertions(+), 3 deletions(-) diff --git a/net.c b/net.c index cb52

Re: [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts

2012-01-06 Thread Anthony Liguori
On 01/06/2012 12:47 PM, Peter Maydell wrote: Fix a compile failure on 32 bit hosts (integer constant is too large for 'unsigned long' type) by correcting a typo where the mask used for filling in the second f_fsid word had too many 'F's in it. Also drop the 'L' suffix that allowed this typo to go

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Igor Mitsyanko
On 01/06/2012 10:45 PM, Peter Maydell wrote: On 6 January 2012 18:37, Igor Mitsyanko wrote: On 01/06/2012 12:02 AM, Mark Langsdorf wrote: +if (!cpu_model) { +cpu_model = "cortex-a9"; +} Google said there is only cortexA9-based Highbank SoC version, maybe you should just hard

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Luiz Capitulino
On Fri, 6 Jan 2012 17:05:53 + "Daniel P. Berrange" wrote: > On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: > > On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: > > >On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: > > >>On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-06 Thread Luiz Capitulino
On Thu, 05 Jan 2012 15:41:33 -0600 Michael Roth wrote: > On 01/05/2012 02:25 PM, Luiz Capitulino wrote: > > On Thu, 05 Jan 2012 09:10:50 -0600 > > Michael Roth wrote: > > > >> On 01/05/2012 08:42 AM, Luiz Capitulino wrote: > >>> On Thu, 5 Jan 2012 12:59:27 + > >>> "Daniel P. Berrange" wrot

[Qemu-devel] [PATCH v4 0/2] integratorcp: fix and simplify flash remap code

2012-01-06 Thread Peter Maydell
Simplify the flash remap code now we have an API for simple enable/disable of memory regions. Changes: v1->v2: split 'fix sense of REMAP bit' into its own patch v2->v3: minor change suggested by Avi in patch 2 (pass !(sm->cm_ctrl & 4) to set_enabled() rather than using if) v3->v4: reba

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Rob Herring
On 01/06/2012 12:37 PM, Igor Mitsyanko wrote: > On 01/06/2012 12:02 AM, Mark Langsdorf wrote: > > Hello, Mark. According to technical specification on Calxeda website, > highbank SoC has SD 3.0 host controller, are you planning to implement > it in qemu? I'm asking because I recently have submitte

[Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts

2012-01-06 Thread Peter Maydell
Fix a compile failure on 32 bit hosts (integer constant is too large for 'unsigned long' type) by correcting a typo where the mask used for filling in the second f_fsid word had too many 'F's in it. Also drop the 'L' suffix that allowed this typo to go undetected on 64 bit hosts. Signed-off-by: Pe

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 18:37, Igor Mitsyanko wrote: > On 01/06/2012 12:02 AM, Mark Langsdorf wrote: >> +    if (!cpu_model) { >> +        cpu_model = "cortex-a9"; >> +    } > > > Google said there is only cortexA9-based Highbank SoC version, maybe you > should just hardcode cpu model? This is just boi

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Igor Mitsyanko
On 01/06/2012 12:02 AM, Mark Langsdorf wrote: Hello, Mark. According to technical specification on Calxeda website, highbank SoC has SD 3.0 host controller, are you planning to implement it in qemu? I'm asking because I recently have submitted a patch implementing SD 2.0 host controller, and i

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Andreas Färber
Am 05.01.2012 21:02, schrieb Mark Langsdorf: > From: Rob Herring > > Adds support for Calxeda's Highbank SoC. > > Signed-off-by: Rob Herring > Signed-off-by: Mark Langsdorf > --- > diff --git a/hw/highbank.c b/hw/highbank.c > new file mode 100644 > index 000..73b6564 > --- /dev/null > +++

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 17:34, Mark Langsdorf wrote: > On 01/06/2012 11:04 AM, Peter Maydell wrote: >> On 6 January 2012 16:58, Mark Langsdorf wrote: > +    if (load_image_targphys("sysram.bin", 0xfff88000, 0x8000) < 0) { > +            fprintf(stderr, "Unable to load sysram.bin\n"); > +  

Re: [Qemu-devel] [PATCH 1/3]use int64 when compare two time

2012-01-06 Thread Andreas Färber
Am 06.01.2012 08:37, schrieb Zhang, Yang Z: > use int64 when compare two time > > int32 only represent only 136 years when comparing two times based on second. > It would be better to use int64. int32 and int64 are softfloat types and should not be used here. Do you have an actual use case that

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Chris Wright
* Anthony Liguori (aligu...@us.ibm.com) wrote: > 2) Two people walk through a particular piece of code and > independently flag anything that looks like a potential security > issue. Auditing is always helpful, but won't ever get full coverage. qtest + fuzz is another great way to identify proble

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Mark Langsdorf
On 01/06/2012 11:04 AM, Peter Maydell wrote: > On 6 January 2012 16:58, Mark Langsdorf wrote: >> On 01/06/2012 10:29 AM, Peter Maydell wrote: +sysram = g_new(MemoryRegion, 1); +memory_region_init_ram(sysram, "highbank.sysram", 0x8000); +memory_region_add_subregion(sysme

Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer

2012-01-06 Thread Jan Kiszka
On 2012-01-06 05:37, Zhang, Yang Z wrote: > change the RTC update logic to use host time with offset to calculate RTC > clock. > There have no need to use two periodic timers to maintain an internal > timer for RTC clock update and alarm check. Instead, we calculate the real > RTC time by

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Chris Wright
* Corey Bryant (cor...@linux.vnet.ibm.com) wrote: > Count me in for step 2. A good approach may be to run a static > analysis tool against the code, followed by a manual scan of the > code for common vulnerabilities that static analysis can't find. Good idea. Folks are already running things lik

Re: [Qemu-devel] [PATCH 05/12] usb: add audio device model.

2012-01-06 Thread Alex Bradbury
On 6 January 2012 13:58, Gerd Hoffmann wrote: > diff --git a/hw/usb-audio.c b/hw/usb-audio.c > new file mode 100644 > index 000..c14dff3 > --- /dev/null > +++ b/hw/usb-audio.c > @@ -0,0 +1,698 @@ > +/* > + * QEMU USB Net devices Presumably s/Net/Audio Alex

Re: [Qemu-devel] 回??: [PATCH 2/2] umem: chardevice for kvm?postcopy

2012-01-06 Thread Isaku Yamahata
On Fri, Jan 06, 2012 at 03:02:00PM +0800, thfbjyddx wrote: > Hi, > Can you tell me the base version of the qemu? > the postcopy patches make some conflicts on the qemu which I clone from the > git 03ecd2c80a64d030a22fe67cc7a60f24e17ff211 > Thanks! > ━━━ > To

Re: [Qemu-devel] [PATCH 0/3] remove the periodic RTC update timer

2012-01-06 Thread Andreas Färber
Next time please thread your patch series together so that they can easily be reviewed and tested. git-send-email usually ensures that. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Daniel P. Berrange
On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: > On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: > >On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: > >>On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote: > >>>Hi, all. > >>> > >>>I am trying QEMU Guest Agent and encountered

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 6 January 2012 16:58, Mark Langsdorf wrote: > On 01/06/2012 10:29 AM, Peter Maydell wrote: >>> +    /* Override default RAM size */ >>> +    if (ram_size == 0x800) { >>> +        if (sizeof(long) == 8) { >>> +            ram_size = 0xff90; >>> +        } else { >>> +            ram_size

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Michael Roth
On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote: Hi, all. I am trying QEMU Guest Agent and encountered a small bug. It is that the PIDFILE remains when daemon start fails. And maybe for

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Mark Langsdorf
On 01/06/2012 10:29 AM, Peter Maydell wrote: > On 5 January 2012 20:02, Mark Langsdorf wrote: >> From: Rob Herring >> >> Adds support for Calxeda's Highbank SoC. > > Is there a test kernel image/etc we can use to confirm that this all works? The 3.2 kernel should have all the necessary support

[Qemu-devel] [PATCH 0/2] Fix fd leak in vvfat.c and strncmp() issue in vnc.c

2012-01-06 Thread Stefan Hajnoczi
Two unrelated bugs that David Gilbert had kicking around that are easy to fix. Let's take care of them. Stefan Hajnoczi (2): vvfat: avoid leaking file descriptor in commit_one_file() vnc: fix no-lock-key-sync strncmp() length block/vvfat.c |3 +++ ui/vnc.c |2 +- 2 files changed

[Qemu-devel] [PATCH 1/2] vvfat: avoid leaking file descriptor in commit_one_file()

2012-01-06 Thread Stefan Hajnoczi
Reported-by: Dr David Alan Gilbert Signed-off-by: Stefan Hajnoczi --- block/vvfat.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index eeffc4a..9ef21dd 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2218,6 +2218,7 @@ static int comm

[Qemu-devel] [PATCH 2/2] vnc: fix no-lock-key-sync strncmp() length

2012-01-06 Thread Stefan Hajnoczi
The no-lock-key-sync option is being parsed incorrectly because of an outdated strcmp() length value. Use the correct length so that invalid option names do not match. Reported-by: Dr David Alan Gilbert Signed-off-by: Stefan Hajnoczi --- ui/vnc.c |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] Incorrect hw/omap_dss.c:chip[] index for RFBI_READ and RFBI_STATUS?

2012-01-06 Thread Stefan Hajnoczi
Is the following code correct in hw/omap_dss.c: case 0x58: /* RFBI_READ */ if ((s->rfbi.control & (1 << 2)) && s->rfbi.chip[0]) s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 1); else if ((s->rfbi.control & (1 << 3)) && s->rfbi.chip[1]) s->rfbi.rxbuf = s->r

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Jan Kiszka
On 2012-01-06 13:58, Peter Maydell wrote: > On 6 January 2012 13:30, Jan Kiszka wrote: >> The third point indicates that there is rather more generic room for >> improvements: Why should qemu reset device models before restore at all? > > Commit 5a8a49d7aa says: > # if we load from a snapshot, th

[Qemu-devel] [PATCH 8/9] Make python mandatory

2012-01-06 Thread Stefan Hajnoczi
From: Sebastian Herbszt The QEMU build depends on Python so make it an explicit requirement. Reviewed-by: Stefan Weil Signed-off-by: Sebastian Herbszt Signed-off-by: Stefan Hajnoczi --- configure | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/configure b/co

[Qemu-devel] [PATCH 7/9] net/socket.c: Fix fd leak in net_socket_listen_init() error paths

2012-01-06 Thread Stefan Hajnoczi
From: Peter Maydell Fix a leak of a file descriptor due to missing closesocket() calls in error paths in net_socket_listen_init(). Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- net/socket.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/socket.

[Qemu-devel] [PATCH 2/9] Strip trailing '\n' from error_report()'s first argument (again)

2012-01-06 Thread Stefan Hajnoczi
From: Markus Armbruster Commit 6daf194d got rid of them, but Hans and Gerd added some more lately. Tracked down with this Coccinelle semantic patch: @r@ expression fmt; position p; @@ error_report(fmt, ...)@p @script:python@ fmt << r.fmt; p << r.p; @@ if "\\n" in str(fmt):

Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank

2012-01-06 Thread Peter Maydell
On 5 January 2012 20:02, Mark Langsdorf wrote: > From: Rob Herring > > Adds support for Calxeda's Highbank SoC. Is there a test kernel image/etc we can use to confirm that this all works? > --- /dev/null > +++ b/hw/highbank.c > @@ -0,0 +1,227 @@ > +/* > + * Calxeda Highbank SoC emulation Is it

[Qemu-devel] [PATCH 6/9] gdbstub: Fix fd leak in gdbserver_open() error path

2012-01-06 Thread Stefan Hajnoczi
From: Peter Maydell Fix a leak of a file descriptor in error exit paths in gdbserver_open(). Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- gdbstub.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a5806ef..7d470b6 100644

[Qemu-devel] [PATCH 9/9] qemu-nbd: drop loop which can never loop

2012-01-06 Thread Stefan Hajnoczi
For some reason nbd_client_thread() has a do..while loop which can never loop, the condition is bogus because we would take a goto instead. Drop the loop. Reported-by: Dr David Alan Gilbert Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- qemu-nbd.c | 10 -- 1 files cha

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Corey Bryant
On 01/06/2012 10:19 AM, Anthony Liguori wrote: Hi, I had an idea I wanted to share and see what level of interest there was in participating and if anyone knows of a process that other projects follow for this. I'd like to start a more formal and transparent security audit of QEMU. The way I'

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Stefan Hajnoczi
On Fri, Jan 06, 2012 at 09:19:45AM -0600, Anthony Liguori wrote: > Would folks be interested in participating in something like this? > If so, I can start organizing it. I enjoy bug hunting and would volunteer. Stefan

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Peter Maydell
On 6 January 2012 13:30, Jan Kiszka wrote: > The third point indicates that there is rather more generic room for > improvements: Why should qemu reset device models before restore at all? Commit 5a8a49d7aa says: # if we load from a snapshot, the machine can be in any state. That can # cause trou

[Qemu-devel] [PATCH 1/9] qemu-options.hx: fix tls-channel help text

2012-01-06 Thread Stefan Hajnoczi
From: Alon Levy Remove the default compiled out tunnel channel, add the always available cursor channel. Optimally the man page would depend on compiled in options, but that's harder to do. RHBZ: 688586 Acked-by: Gerd Hoffmann Signed-off-by: Alon Levy Signed-off-by: Stefan Hajnoczi --- qemu

[Qemu-devel] [PATCH 4/9] configure: CONFIG_QEMU_INTERP_PREFIX only for user mode

2012-01-06 Thread Stefan Hajnoczi
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 640e815..af19391 100755 --- a/configure +++ b/configure @@ -3395,7 +3395,6 @@ echo "# Automatically ge

[Qemu-devel] [PATCH 3/9] scsi virtio-blk usb-msd: Clean up device init error messages

2012-01-06 Thread Stefan Hajnoczi
From: Markus Armbruster Replace error_report("DEVICE-NAME: MESSAGE"); by just error_report("MESSAGE"); in block device init functions. DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device scsi-hd and scsi-cd, "virtio-blk-pci" for virtio-blk-s390, and "usb-msd" for usb-stor

[Qemu-devel] [PATCH 5/9] configure: Fix test for supported host CPU type

2012-01-06 Thread Stefan Hajnoczi
From: Peter Maydell The test for whether the host CPU is supported had several problems: * the attempt to fall back to TCI was done as a duplicate test, very late (so "--cpu foo" would fail early but "--cpu unicore32" would fail late, differently, and after configure had already printed

[Qemu-devel] [PULL 0/9] Trivial patches for 20 December 2011 to 6 January 2012

2012-01-06 Thread Stefan Hajnoczi
My pull request from 22 December 2011 was misformatted and therefore not merged. I have included those patches again together with the latest batch of trivial patches. The following changes since commit c47f3223658119219bbe0b8d09da733d1c06e76f: Merge remote-tracking branch 'pmaydell/arm-devs.f

Re: [Qemu-devel] [PATCH v5 2/5] arm: make the number of GIC interrupts configurable

2012-01-06 Thread Peter Maydell
On 5 January 2012 20:02, Mark Langsdorf wrote: > Increase the maximum number of GIC interrupts for a9mp and a11mp to 256, > and create a configurable property for each defaulting to 96 and 64 > (respectively) so that device modelers can set the value appropriately > for their SoC. Other ARM proces

[Qemu-devel] [PATCH v4 14/15] add doc to describe live block operations

2012-01-06 Thread Stefan Hajnoczi
From: Marcelo Tosatti Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi --- docs/live-block-ops.txt | 58 +++ 1 files changed, 58 insertions(+), 0 deletions(-) create mode 100644 docs/live-block-ops.txt diff --git a/docs/live-block-op

[Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- Makefile.objs |1 + block/stream.c | 119 block_int.h|3 + trace-events |4 ++ 4 files changed, 127 insertions(+), 0 deletions(-) create mode 100644 block/stream.c diff --git a/Makefi

[Qemu-devel] [PATCH 10/12] usb/debug: add usb_ep_dump

2012-01-06 Thread Gerd Hoffmann
Add function to dump endpoint data, for debugging purposes. Signed-off-by: Gerd Hoffmann --- hw/usb.c| 40 hw/usb.h|1 + usb-linux.c |3 +++ 3 files changed, 44 insertions(+), 0 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index 6ba063

[Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-06 Thread Anthony Liguori
Hi, I had an idea I wanted to share and see what level of interest there was in participating and if anyone knows of a process that other projects follow for this. I'd like to start a more formal and transparent security audit of QEMU. The way I'd imagine it working is something like this:

[Qemu-devel] [PATCH 00/12] usb patch queue: audio, xhci

2012-01-06 Thread Gerd Hoffmann
Hi, More patches from the usb patch queue, for review, this time more entertaining than boring bug fixes. It goes in top of the bugfix pull request sent out earier today. git tree available for your convinience, see below. So, what is in there? * usb-audio emulation support. * xhci emulati

[Qemu-devel] [PATCH v4 13/15] block stream: add support for partial streaming

2012-01-06 Thread Stefan Hajnoczi
From: Marcelo Tosatti Add support for streaming data from an intermediate section of the image chain (see patch and documentation for details). Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi --- block.c| 64 blo

[Qemu-devel] [PATCH v4 12/15] add QERR_BASE_ID_NOT_FOUND

2012-01-06 Thread Stefan Hajnoczi
From: Marcelo Tosatti Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index feb3d35..42f5fc2 100644 --- a/qerror.c +++ b/qerror.c @@ -276,6 +276,10 @@

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-nbd: drop loop which can never loop

2012-01-06 Thread Stefan Hajnoczi
On Thu, Jan 05, 2012 at 01:16:07PM +, Stefan Hajnoczi wrote: > For some reason nbd_client_thread() has a do..while loop which can never > loop, the condition is bogus because we would take a goto instead. Drop > the loop. > > Reported-by: Dr David Alan Gilbert > Signed-off-by: Stefan Hajnocz

[Qemu-devel] [PATCH v4 05/15] block: rate-limit streaming operations

2012-01-06 Thread Stefan Hajnoczi
This patch implements rate-limiting for image streaming. If we've exceeded the bandwidth quota for a 100 ms time slice we sleep the coroutine until the next slice begins. Signed-off-by: Stefan Hajnoczi --- block/stream.c | 65 ++- 1 files ch

[Qemu-devel] [PATCH 09/12] usb-desc: USBEndpoint support

2012-01-06 Thread Gerd Hoffmann
Initialize USBEndpoint structs from USBDesc* data. Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index 9c38661..0768334 100644 --- a/hw/usb-desc.c +++ b/hw/usb-desc.c @@

Re: [Qemu-devel] [libvirt] QMP: Supporting off tree APIs

2012-01-06 Thread Anthony Liguori
On 01/06/2012 06:45 AM, Luiz Capitulino wrote: On Fri, 6 Jan 2012 11:06:12 + Stefan Hajnoczi wrote: Proper async support - if you mean the ability to have multiple QMP commands pending at a time - is harder than just fixing QEMU. Clients also need to start taking advantage of it. Clients

[Qemu-devel] [PATCH 05/12] usb: add audio device model.

2012-01-06 Thread Gerd Hoffmann
From: H. Peter Anvin This brings a usb audio device to qemu. Output only, fixed at 16bit stereo @ 48 Hz. Based on a patch from H. Peter Anvin Usage: add '-device usb-audio' to your qemu command line. Works sorta ok on a idle machine. Known issues: * Is *very* sensitive to latencies.

[Qemu-devel] [PATCH v4 15/15] test: add image streaming test cases

2012-01-06 Thread Stefan Hajnoczi
python test-stream.py Signed-off-by: Stefan Hajnoczi --- test-stream.py | 208 1 files changed, 208 insertions(+), 0 deletions(-) create mode 100644 test-stream.py diff --git a/test-stream.py b/test-stream.py new file mode 100644 index

[Qemu-devel] [PATCH v4 06/15] qmp: add block_stream command

2012-01-06 Thread Stefan Hajnoczi
Add the block_stream command, which starts copy backing file contents into the image file. Also add the BLOCK_JOB_COMPLETED QMP event which is emitted when image streaming completes. Later patches add control over the background copy speed, cancelation, and querying running streaming operations.

[Qemu-devel] [PATCH 11/12] usb: add max_packet_size to USBEndpoint

2012-01-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c |2 ++ hw/usb.c | 37 + hw/usb.h |4 usb-linux.c | 31 +-- 4 files changed, 44 insertions(+), 30 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c ind

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-06 Thread Stefano Stabellini
On Fri, 6 Jan 2012, Jan Kiszka wrote: > On 2012-01-06 08:50, Stefano Stabellini wrote: > > On Thu, 5 Jan 2012, Jan Kiszka wrote: > >> On 2012-01-05 15:50, Avi Kivity wrote: > Let me summarize what we have come up with so far: > > - we move the call to xen_register_framebuffer before

[Qemu-devel] [PATCH v4 10/15] blockdev: make image streaming safe across hotplug

2012-01-06 Thread Stefan Hajnoczi
Unplugging a storage interface like virtio-blk causes the host block device to be deleted too. Long-running operations like block migration must take a DriveInfo reference to prevent the BlockDriverState from being freed. For image streaming we can do the same thing. Note that it is not possible

[Qemu-devel] [PATCH 01/12] usb-host: rip out legacy procfs support

2012-01-06 Thread Gerd Hoffmann
This patch removes support for parsing /proc/bus/usb/devices for device discovery. The code lacks a few features compared to the sysfs code and is also bitrotting as everybody has sysfs these days. This implies having sysfs mounted is mandatory now to use the usb-host driver. udev isn't required

[Qemu-devel] [PATCH v4 11/15] block: add bdrv_find_backing_image

2012-01-06 Thread Stefan Hajnoczi
From: Marcelo Tosatti Add bdrv_find_backing_image: given a BlockDriverState pointer, and an id, traverse the backing image chain to locate the id. Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi --- block.c | 17 + block.h |1 + 2 files changed, 18 insertio

[Qemu-devel] [PATCH v4 08/15] qmp: add block_job_cancel command

2012-01-06 Thread Stefan Hajnoczi
Add block_job_cancel, which stops an active block streaming operation. When the operation has been cancelled the new BLOCK_JOB_CANCELLED event is emitted. Signed-off-by: Stefan Hajnoczi --- QMP/qmp-events.txt | 24 blockdev.c | 19 ++- hmp-com

[Qemu-devel] [PATCH v4 01/15] coroutine: add co_sleep_ns() coroutine sleep function

2012-01-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- Makefile.objs |1 + qemu-coroutine-sleep.c | 38 ++ qemu-coroutine.h |6 ++ 3 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 qemu-coroutine-sleep.c diff --git a/Makefile.objs

[Qemu-devel] [PATCH v4 09/15] qmp: add query-block-jobs

2012-01-06 Thread Stefan Hajnoczi
Add query-block-jobs, which shows the progress of ongoing block device operations. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 33 + hmp.c| 36 hmp.h|1 + monitor.c|7 ++

[Qemu-devel] [PATCH v4 03/15] block: add BlockJob interface for long-running operations

2012-01-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block.c | 48 block_int.h | 40 2 files changed, 88 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index daf92c2..5bfaa3a 100644 --- a/block.c +++ b/

[Qemu-devel] [PATCH v4 02/15] block: check bdrv_in_use() before blockdev operations

2012-01-06 Thread Stefan Hajnoczi
Long-running block operations like block migration and image streaming must have continual access to their block device. It is not safe to perform operations like hotplug, eject, change, resize, commit, or external snapshot while a long-running operation is in progress. This patch adds the missin

[Qemu-devel] [PATCH v4 07/15] qmp: add block_job_set_speed command

2012-01-06 Thread Stefan Hajnoczi
Add block_job_set_speed, which sets the maximum speed for a background block operation. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 25 + hmp-commands.hx | 14 ++ hmp.c| 11 +++ hmp.h|1 + qapi-schema.json |

[Qemu-devel] [PATCH v4 00/15] block: generic image streaming

2012-01-06 Thread Stefan Hajnoczi
This series adds the 'block_stream' command which copies the contents of a backing file into the image file while the VM is running. The series builds on the zero detection features which I sent out before Christmas. I suggest grabbing my git tree to try it out without merging this dependency: ht

[Qemu-devel] [PATCH 12/12] usb: link packets to endpoints not devices

2012-01-06 Thread Gerd Hoffmann
Add USBEndpoint for the control endpoint to USBDevices. Link async packets to the USBEndpoint instead of the USBDevice. Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c |3 ++- hw/usb-musb.c |3 ++- hw/usb-ohci.c |4 +++- hw/usb-uhci.c |3 ++- hw/usb.c | 12 ++-- hw

[Qemu-devel] [PATCH 07/12] usb: add USBEndpoint

2012-01-06 Thread Gerd Hoffmann
Start maintaining endpoint state at USBDevice level. Add USBEndpoint struct and some helper functions to deal with it. For now it contains the endpoint type only. Moved over some bits from usb-linux.c Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |1 + hw/usb.c | 30

[Qemu-devel] [PATCH 03/12] usb: track altsetting in USBDevice

2012-01-06 Thread Gerd Hoffmann
Also handle {GET,SET}_INTERFACE in common code (usb-desc.c). Signed-off-by: Gerd Hoffmann --- hw/usb-bt.c | 22 - hw/usb-ccid.c |8 -- hw/usb-desc.c | 71 +++ hw/usb-hid.c|7 - hw/usb-hub.c|

[Qemu-devel] [PATCH 08/12] usb: add ifnum to USBEndpoint

2012-01-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb.c| 14 ++ hw/usb.h|3 +++ usb-linux.c |1 + 3 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/usb.c b/hw/usb.c index 5d6baaf..6ba063a 100644 --- a/hw/usb.c +++ b/hw/usb.c @@ -422,6 +422,8 @@ void usb_ep_init(US

  1   2   >