[Qemu-devel] [PULL v2] virtio-serial: Fix console failure on unconnected pty

2012-01-03 Thread Amit Shah
Hi, Turns out I used the wrong repo dir which caused problems. Corrected link below. This patch fixes a frozen guest on virtio-console output before a pty is connected. Please pull. The following changes since commit f3c6a169a39d188e98c17a0a0ebfa7f85e5aafdd: Merge remote-tracking branch 'qe

Re: [Qemu-devel] [PATCH 0/2] virtio-mmio: fix 2 bugs

2012-01-03 Thread Ying-Shiuan Pan
2012/1/3 Peter Maydell : > On 3 January 2012 07:05, Ying-Shiuan Pan wrote: >> I'm not sure if it is appropriate to put patches here because >> virtio-mmio is actually not in official repository yet. >> In case that someone else wants to test virtio-mmio as I did, I decide >> to send them out. >> >

[Qemu-devel] [RFC][PATCH 14/14 v4] auto cancel dumping after vm state is changed to run

2012-01-03 Thread Wen Congyang
The command dump does not support to dump while vm is running. If the user resume the vm, we should auto cancel dumping and set the status to failed. Signed-off-by: Wen Congyang --- dump.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c

[Qemu-devel] [RFC][PATCH 13/14 v4] support to query dumping status

2012-01-03 Thread Wen Congyang
Add API to allow the user to query dumping status. Signed-off-by: Wen Congyang --- dump.c | 30 ++ hmp-commands.hx |2 ++ hmp.c| 13 + hmp.h|1 + monitor.c|7 +++ qapi-schema.json | 26 ++

Re: [Qemu-devel] [RFC PATCH 0/4] simpletrace : support var num/size of args, strings.

2012-01-03 Thread Harsh Bora
On 01/02/2012 06:20 PM, Lluís Vilanova wrote: Harsh Prateek Bora writes: Converting tracetool.sh to tracetool.py Excellent! I was thinking about switching the script language to python, but wasn't sure if python was an acceptable build dependency for the project. Thanks, Python appears t

[Qemu-devel] [RFC][PATCH 12/14 v4] support to set dumping speed

2012-01-03 Thread Wen Congyang
Add API to allow the user to control dumping speed Signed-off-by: Wen Congyang --- dump.c | 12 hmp-commands.hx | 15 +++ hmp.c|6 ++ hmp.h|1 + qapi-schema.json | 15 +++ qmp-commands.hx | 22 ++

[Qemu-devel] [RFC][PATCH 11/14 v4] support to cancel the current dumping

2012-01-03 Thread Wen Congyang
Add API to allow the user to cancel the current dumping. Signed-off-by: Wen Congyang --- dump.c | 14 ++ hmp-commands.hx | 14 ++ hmp.c|5 + hmp.h|1 + qapi-schema.json | 13 + qmp-commands.hx | 21 ++

[Qemu-devel] [RFC][PATCH 10/14 v4] support detached dump

2012-01-03 Thread Wen Congyang
Let the user to choose whether to block other monitor command while dumping. Signed-off-by: Wen Congyang --- dump.c | 24 +++- hmp-commands.hx |8 qmp-commands.hx |7 --- 3 files changed, 27 insertions(+), 12 deletions(-) diff --git a/dump.c b

[Qemu-devel] [RFC][PATCH 09/14 v4] run dump at the background

2012-01-03 Thread Wen Congyang
The new monitor command dump may take long time to finish. So we need run it at the background. Signed-off-by: Wen Congyang --- dump.c | 158 1 files changed, 139 insertions(+), 19 deletions(-) diff --git a/dump.c b/dump.c index

[Qemu-devel] [RFC][PATCH 08/14 v4] introduce a new monitor command 'dump' to dump guest's memory

2012-01-03 Thread Wen Congyang
Signed-off-by: Wen Congyang --- Makefile.target |8 +- dump.c | 588 +++ dump.h |4 + hmp-commands.hx | 16 ++ monitor.c |3 + qmp-commands.hx | 26 +++ 6 files changed, 641 insertions(+), 4 deletions(-)

[Qemu-devel] [RFC][PATCH 07/14 v4] target-i386: add API to get dump info

2012-01-03 Thread Wen Congyang
Dump info contains: endian, class and architecture. The next patch will use these information to create vmcore. Signed-off-by: Wen Congyang --- cpu-all.h |3 +++ dump.h | 10 ++ target-i386/arch-dump.c | 34 ++ 3 file

[Qemu-devel] [RFC][PATCH 06/14 v4] target-i386: Add API to add extra memory mapping

2012-01-03 Thread Wen Congyang
Crash needs extra memory mapping to determine phys_base. Signed-off-by: Wen Congyang --- cpu-all.h |2 ++ target-i386/arch-dump.c | 43 +++ 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index ffb5

[Qemu-devel] [RFC][PATCH 05/14 v4] target-i386: Add API to write elf notes to core file

2012-01-03 Thread Wen Congyang
The core file contains register's value. These APIs write registers to core file, and them will be called in the following patch. Signed-off-by: Wen Congyang --- cpu-all.h |6 + target-i386/arch-dump.c | 243 +++ 2 files changed, 249

[Qemu-devel] [RFC][PATCH 04/14 v4] Add API to get memory mapping

2012-01-03 Thread Wen Congyang
Add API to get all virtual address and physical address mapping. If there is no virtual address for some physical address, the virtual address is 0. Signed-off-by: Wen Congyang --- memory_mapping.c | 55 ++ memory_mapping.h |1 + 2 files

[Qemu-devel] [RFC][PATCH 03/14 v4] target-i386: implement cpu_get_memory_mapping()

2012-01-03 Thread Wen Congyang
Walk cpu's page table and collect all virtual address and physical address mapping. Then, add these mapping into memory mapping list. Signed-off-by: Wen Congyang --- Makefile.target |2 +- cpu-all.h |7 ++ target-i386/arch-dump.c | 254

[Qemu-devel] [RFC][PATCH 02/14 v4] Add API to check whether a physical address is I/O address

2012-01-03 Thread Wen Congyang
This API will be used in the following patch. Signed-off-by: Wen Congyang --- cpu-common.h |2 ++ exec.c | 20 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index 3fe44d2..0309137 100644 --- a/cpu-common.h +++ b/cpu-c

[Qemu-devel] [RFC][PATCH 01/14 v4] Add API to create memory mapping list

2012-01-03 Thread Wen Congyang
The memory mapping list stores virtual address and physical address mapping. The folloing patch will use this information to create PT_LOAD in the vmcore. Signed-off-by: Wen Congyang --- Makefile.target |1 + memory_mapping.c | 130 ++ me

[Qemu-devel] [RFC][PATCT 0/14 v4] dump memory when host pci device is used by guest

2012-01-03 Thread Wen Congyang
Hi, all 'virsh dump' can not work when host pci device is used by guest. We have discussed this issue here: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html We have determined to introduce a new command dump to dump memory. The core file's format can be elf. Note: 1. The gue

[Qemu-devel] Unsubscription Confirmation

2012-01-03 Thread RealEstateMalaysian.com
Thank you for subscribing. You have now unsubscribed and no more messages will be sent.

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

2012-01-03 Thread Isaku Yamahata
On Thu, Dec 29, 2011 at 04:39:52PM -0600, Anthony Liguori wrote: >> TODO >> >> - benchmark/evaluation. Especially how async page fault affects the result. > > I'll review this series next week (Mike/Juan, please also review when you > can). > > But we really need to think hard about whether t

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

2012-01-03 Thread Michael Roth
On 01/01/2012 03:52 AM, Dor Laor wrote: On 12/30/2011 12:39 AM, Anthony Liguori wrote: On 12/28/2011 07:25 PM, Isaku Yamahata wrote: Intro = This patch series implements postcopy live migration.[1] As discussed at KVM forum 2011, dedicated character device is used for distributed shared mem

Re: [Qemu-devel] [PATCH 21/21] postcopy: implement postcopy livemigration

2012-01-03 Thread Isaku Yamahata
On Thu, Dec 29, 2011 at 06:06:10PM +0200, Avi Kivity wrote: > On 12/29/2011 03:26 AM, Isaku Yamahata wrote: > > This patch implements postcopy livemigration. > > > > > > +/* RAM is allocated via umem for postcopy incoming mode */ > > +#define RAM_POSTCOPY_UMEM_MASK (1 << 1) > > + > > typedef st

Re: [Qemu-devel] [PATCH 2/3] Add a new PCI region type to supports 64 bit ranges

2012-01-03 Thread Kevin O'Connor
On Tue, Jan 03, 2012 at 04:14:58PM +0100, Gerd Hoffmann wrote: > On 12/29/11 03:56, Kevin O'Connor wrote: > > Tracking of 64bit prefmem sections separately from > > regular prefmem sections doesn't make sense, because both need to be > > allocated from the same pool when behind a bridge. > > Yea,

Re: [Qemu-devel] [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2012-01-03 Thread Isaku Yamahata
On Mon, Jan 02, 2012 at 06:05:51PM +0100, Andrea Arcangeli wrote: > On Thu, Dec 29, 2011 at 06:01:45PM +0200, Avi Kivity wrote: > > On 12/29/2011 06:00 PM, Avi Kivity wrote: > > > The NFS client has exactly the same issue, if you mount it with the intr > > > option. In fact you could use the NFS c

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-03 Thread Cao,Bing Bu
On 01/03/2012 09:12 PM, Stefan Hajnoczi wrote: On Tue, Jan 3, 2012 at 12:15 PM, Dor Laor wrote: On 01/03/2012 10:33 AM, Stefan Hajnoczi wrote: On Mon, Jan 02, 2012 at 01:09:40PM +0100, Juan Quintela wrote: Please send in any agenda items you are interested in covering. Status of virtio d

[Qemu-devel] [PATCH 5/6] s390x: add TR function for EXECUTE

2012-01-03 Thread Alexander Graf
Newer gcc versions (or glibc?) also generate code that tries to EXECUTE the TR opcode. Implement it so that we don't break valid guests. Reported-by: Andreas Faerber Signed-off-by: Alexander Graf --- target-s390x/op_helper.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --g

[Qemu-devel] [PULL 0/6] s390 patch queue 2012-01-04

2012-01-03 Thread Alexander Graf
Hi Anthony / Blue / Aurelien, This is my current patch queue for s390. Please pull. Alex The following changes since commit f3c6a169a39d188e98c17a0a0ebfa7f85e5aafdd: Anthony Liguori (1): Merge remote-tracking branch 'qemu-kvm/memory/page_desc' into staging are available in the git re

[Qemu-devel] [PATCH 3/6] Add generic drive hotplugging

2012-01-03 Thread Alexander Graf
The monitor command for hotplugging is in i386 specific code. This is just plain wrong, as S390 just learned how to do hotplugging too and needs to get drives for that. So let's add a generic copy to generic code that handles drive_add in a way that doesn't have pci dependencies. All pci specific

[Qemu-devel] [PATCH 6/6] s390: fix cpu hotplug / cpu activity on interrupts

2012-01-03 Thread Alexander Graf
From: Christian Borntraeger The add_del/running_cpu code and env->halted are tracking stopped cpus. Sleeping cpus (idle and enabled for interrupts) are waiting inside the kernel. No interrupt besides the restart can move a cpu from stopped to operational. This is already handled over there. So le

[Qemu-devel] [PATCH 1/6] [S390] Add hotplug support

2012-01-03 Thread Alexander Graf
I just submitted a few patches that enable the s390 virtio bus to receive a hotplug add event. This patch implements the qemu side of it, so that new hotplug events can be submitted to the guest. Signed-off-by: Alexander Graf --- v1 -> v2: - make s390 virtio hoplug code emulate-capable ---

[Qemu-devel] [PATCH 4/6] Expose drive_add on all architectures

2012-01-03 Thread Alexander Graf
All architectures can now use drive_add on the monitor. This of course does not mean that there is hotplug support for the specific platform, so in order to actually make use of the new drives you still need to have a hotplug capable device. Signed-off-by: Alexander Graf --- hmp-commands.hx |

[Qemu-devel] [PATCH 2/6] Compile device-hotplug on all targets

2012-01-03 Thread Alexander Graf
All guest targets could potentially implement hotplugging. With the next patches in this set I will also reflect this in the monitor interface. So let's always compile it in. It shouldn't hurt. Signed-off-by: Alexander Graf --- Makefile.target |5 - 1 files changed, 4 insertions(+), 1 d

Re: [Qemu-devel] Stalls on Live Migration of VMs with a lot of memory

2012-01-03 Thread Shu Ming
On 2012-1-4 2:04, Peter Lieven wrote: Hi all, is there any known issue when migrating VMs with a lot of (e.g. 32GB) of memory. It seems that there is some portion in the migration code which takes too much time when the number of memory pages is large. Symptoms are: Irresponsive VNC connecti

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

2012-01-03 Thread Takuya Yoshikawa
(2012/01/01 18:52), Dor Laor wrote: But we really need to think hard about whether this is the right thing to take into the tree. I worry a lot about the fact that we don't test pre-copy migration nearly enough and adding a second form just introduces more things to test. It is an issue but it

Re: [Qemu-devel] Better qemu/kvm defaults (was Re: [RFC PATCH 0/4] Gang scheduling in CFS)

2012-01-03 Thread Dor Laor
On 01/04/2012 12:45 AM, Anthony Liguori wrote: When using 'guests-pick', we initially present the most compatible network model (rtl8139, for instance). We would provide a paravirtual channel (guest-agent?) that could be used to enumerate which models were available and let guest decide which m

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Anthony Liguori
On 01/03/2012 11:38 AM, Avi Kivity wrote: On 01/03/2012 07:16 PM, Avi Kivity wrote: On 01/03/2012 07:09 PM, Avi Kivity wrote: (strange, I was 100% sure I tested Xen). Ah, we have different CONFIG_XEN_CTRL_INTERFACE_VERSIONs. Updated branch pushed - changed the signature of an empty-bodied

Re: [Qemu-devel] Better qemu/kvm defaults (was Re: [RFC PATCH 0/4] Gang scheduling in CFS)

2012-01-03 Thread Anthony Liguori
On 01/03/2012 04:31 PM, Dor Laor wrote: We can just set this for pc-1.1. I don't see any real harm in doing that. Great, it 'only' took about 3 years from the time it got developed originally by Uri... Someone just needs to send a patch. When using 'guests-pick', we initially present the mo

Re: [Qemu-devel] Better qemu/kvm defaults (was Re: [RFC PATCH 0/4] Gang scheduling in CFS)

2012-01-03 Thread Dor Laor
On 01/03/2012 05:48 PM, Anthony Liguori wrote: On 01/01/2012 04:16 AM, Dor Laor wrote: On 12/29/2011 06:16 PM, Anthony Liguori wrote: On 12/29/2011 10:07 AM, Dor Laor wrote: On 12/26/2011 11:05 AM, Avi Kivity wrote: On 12/26/2011 05:14 AM, Nikunj A Dadhania wrote: btw you can get an additio

[Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- hmp-commands.hx | 34 ++ qmp-commands.hx | 44 +--- 2 files changed, 63 insertions(+), 15 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 14838b7..952d5cd 100644 --- a

[Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Orit Wasserman
Changes from v4: 1) Rebase 2) divide patch into 9 patches 3) move memory allocation into cache_insert By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory write intensive workloads typical of large enterprise applicatio

[Qemu-devel] [PATCH v5 2/9] Add rle_encode and rle_decode functions Implement Run Length Encoding compression

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index fdda277..426b34d 100644 --- a/arch_init.c +++ b/arch_init.c @@ -139,6 +139,9 @@ typedef

[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-03 Thread Orit Wasserman
Add migration state to store XBRLE params (enablement and cache size). In the outgoing check to see if the page is cached and send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set decompress the page (by using load_xbrle functi

[Qemu-devel] [PATCH v5 9/9] Add XBRLE statistics information

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 67 +++ migration.c | 11 + migration.h |9 3 files changed, 87 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 6b839a1..037d8ba 100644 ---

[Qemu-devel] [PATCH v5 6/9] Add xbrle parameters to MigrationState

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- block-migration.c |4 +++- hw/hw.h |4 +++- migration.c | 15 +-- migration.h |3 +++ savevm.c | 11 +++ sysemu.h |4 +++- 6 files changed, 32 insertions(+), 9 deletions(-) diff --g

[Qemu-devel] [PATCH v5 3/9] Add save_block_hdr function

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/arch_init.c b/arch_init.c index 426b34d..e87dfbc 100644 --- a/arch_init.c +++ b/arch_init.c @@ -335,6 +335,17 @@ static void xor_encode(uint8_t *d

[Qemu-devel] [PATCH v5 4/9] Add host_from_stream_offset_versioned function

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 35 +-- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/arch_init.c b/arch_init.c index e87dfbc..05b8053 100644 --- a/arch_init.c +++ b/arch_init.c @@ -613,6 +613,23 @@ static inline void *host_fro

[Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-03 Thread Orit Wasserman
Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wasserman --- arch_init.c | 183 +++ 1 files changed, 183 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c ind

[Qemu-devel] [PATCH v5 7/9] Add set_cachesize to change XBRLE cache size

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- migration.c | 25 - migration.h |7 +++ 2 files changed, 31 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index ed47958..3d88cdd 100644 --- a/migration.c +++ b/migration.c @@ -380,7 +380,30 @@ void migrat

[Qemu-devel] [PATCH 1/3] PPC: Bamboo: recompile device tree

2012-01-03 Thread Alexander Graf
Recent dtc doesn't compile our dts anymore. Change all hex numbers to have 0x prefixes, indicate the old version and recompile using recent dtc. This doesn't change any semantics in the device tree. Signed-off-by: Alexander Graf --- pc-bios/bamboo.dtb | Bin 3179 -> 3211 bytes pc-bios/bamboo.d

[Qemu-devel] [PATCH 3/3] PPC: Enable 440EP CPU target

2012-01-03 Thread Alexander Graf
Now that we have 440 TLB emulation, we can also support running the 440EP CPU target in system emulation mode. Signed-off-by: Alexander Graf --- target-ppc/translate_init.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/target-ppc/translate_init.c b/targ

[Qemu-devel] [PATCH 2/3] PPC: 440: Default to 440EP CPU

2012-01-03 Thread Alexander Graf
Today we're exposing a Virtex 440 CPU to the guest despite the fact that we're telling the guest that we're running on a 440EP one in the device tree. So let's better default to a real 440EP to make things synced again. Signed-off-by: Alexander Graf --- hw/ppc440.c |2 +- 1 files changed, 1

[Qemu-devel] [PATCH 0/3] PPC: Fix bamboo part 2

2012-01-03 Thread Alexander Graf
These patches work on top of the other patch set I sent out earlier. With these patches I can successfully run user space code with -M bamboo. Alex Alexander Graf (3): PPC: Bamboo: recompile device tree PPC: 440: Default to 440EP CPU PPC: Enable 440EP CPU target hw/ppc440.c

Re: [Qemu-devel] [PATCH v5 2/9] Add rle_encode and rle_decode functions Implement Run Length Encoding compression

2012-01-03 Thread Anthony Liguori
On 01/03/2012 09:34 AM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index fdda277..426b34d 100644 --- a/arch_init

Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-03 Thread Anthony Liguori
On 01/03/2012 09:34 AM, Orit Wasserman wrote: Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wasserman --- arch_init.c | 183 +++ 1 files changed, 183 insertions(+), 0 deletio

Re: [Qemu-devel] [PATCH v3 2/2] linux-user: target_argv is placed on ts->bprm->argv and can't be freed()

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 20:38, Fabio Erculiani wrote: > TaskState contains linux_bprm struct which encapsulates argv among > other things. > argv might be used around the code and is expected to contain valid > data. Before this patch, ts->bprm->argv was NULL due to it being > freed right after loader_

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 20:38, Fabio Erculiani wrote: > With the current fake /proc/self/stat implementation `ps` is > segfaulting because it expects to read PID and argv[0] as first and > second field respectively, with the latter being enclosed between > backets. > > Reproducing is as easy as runnin

[Qemu-devel] [PATCH v3 2/2] linux-user: target_argv is placed on ts->bprm->argv and can't be freed()

2012-01-03 Thread Fabio Erculiani
TaskState contains linux_bprm struct which encapsulates argv among other things. argv might be used around the code and is expected to contain valid data. Before this patch, ts->bprm->argv was NULL due to it being freed right after loader_exec(). Signed-off-by: Fabio Erculiani --- linux-user/mai

[Qemu-devel] [PATCH v3 1/2] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
With the current fake /proc/self/stat implementation `ps` is segfaulting because it expects to read PID and argv[0] as first and second field respectively, with the latter being enclosed between backets. Reproducing is as easy as running: `ps` inside qemu-user chroot with /proc mounted. Signed-of

Re: [Qemu-devel] [PATCH] qmp: Add missing gcc format attribute and fix format string

2012-01-03 Thread Luiz Capitulino
On Fri, 30 Dec 2011 11:56:14 + Stefan Hajnoczi wrote: > On Fri, Dec 23, 2011 at 08:34:38PM +0100, Stefan Weil wrote: > > Signed-off-by: Stefan Weil > > --- > > test-qmp-input-visitor.c |7 --- > > 1 files changed, 4 insertions(+), 3 deletions(-) > > Although we're not strictly impl

Re: [Qemu-devel] [RFC 00/10]: QMP/HMP: Introduce tray handling commands

2012-01-03 Thread Luiz Capitulino
On Tue, 20 Dec 2011 14:49:47 +0800 Osier Yang wrote: > On 2011年06月04日 03:03, Luiz Capitulino wrote: > > In a recent discussion on the mailing list regarding the introduction of > > the BLOCK_TRAY_OPEN and BLOCK_TRAY_CLOSE events[1], it was mentioned that > > we need to fix the eject command and m

Re: [Qemu-devel] [PATCH v2 2/2] linux-user: target_argv is placed on ts->bprm->argv and can't be freed()

2012-01-03 Thread Alexander Graf
You're missing a patch description and signed-off-by line :) Alex On 03.01.2012, at 20:20, Fabio Erculiani wrote: > --- > linux-user/main.c |5 - > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index 788ff98..513d583 100644 > -

Re: [Qemu-devel] [PATCH v2 1/2] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 20:20, Fabio Erculiani wrote: > With the current fake /proc/self/stat implementation `ps` is > segfaulting because it expects to read PID and argv[0] as first and > second field respectively, with the latter being enclosed between > backets. > > Reproducing is as easy as runnin

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
Done, it all works now ;-) ! -- Fabio Erculiani

[Qemu-devel] [PATCH v2 2/2] linux-user: target_argv is placed on ts->bprm->argv and can't be freed()

2012-01-03 Thread Fabio Erculiani
--- linux-user/main.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 788ff98..513d583 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3492,11 +3492,6 @@ int main(int argc, char **argv, char **envp) _exit(

[Qemu-devel] [PATCH v2 1/2] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
With the current fake /proc/self/stat implementation `ps` is segfaulting because it expects to read PID and argv[0] as first and second field respectively, with the latter being enclosed between backets. Reproducing is as easy as running: `ps` inside qemu-user chroot with /proc mounted. Signed-of

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 20:11, Fabio Erculiani wrote: > Ok, I've found the reason, i guess it's a bug. > target_argv pointer is placed in bprm->argv; > But then target_argv is freed and nullified. > > loader_exec should just allocate a new char** and copy target_argv. > I tried that and it worked. >

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
Ok, I've found the reason, i guess it's a bug. target_argv pointer is placed in bprm->argv; But then target_argv is freed and nullified. loader_exec should just allocate a new char** and copy target_argv. I tried that and it worked. The problem is, where do I free() it? Am i supposed to do it or

Re: [Qemu-devel] [PATCH V2 3/5] Introduce premigrate RunState.

2012-01-03 Thread Luiz Capitulino
On Mon, 19 Dec 2011 17:27:55 + Anthony PERARD wrote: > On Thu, 15 Dec 2011, Luiz Capitulino wrote: > > > On Thu, 15 Dec 2011 09:14:00 -0600 > > Anthony Liguori wrote: > > > > > On 12/09/2011 03:54 PM, Anthony PERARD wrote: > > > > This new state will be used by Xen functions to know QEMU wi

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 19:54, Fabio Erculiani wrote: > Yeah, debugging. > > Moreover we have this scenario: > > $ /bin/cat /proc/self/stat > 32297 (cat) .. > > I guess we should use basename() anyway...? argv[0] can be an arbitrary value passed in through execve. In qemu's linux-user emulatio

Re: [Qemu-devel] [PATCH v3] qemu-ga: Add the guest-suspend command

2012-01-03 Thread Luiz Capitulino
On Thu, 15 Dec 2011 10:51:15 -0600 Michael Roth wrote: > On 12/15/2011 09:09 AM, Luiz Capitulino wrote: > > It supports three modes: "hibernate" (suspend to disk), "sleep" > > (suspend to ram) and "hybrid" (save RAM contents to disk, but > > suspend instead of powering off). > > > > The command w

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
Yeah, debugging. Moreover we have this scenario: $ /bin/cat /proc/self/stat 32297 (cat) .. I guess we should use basename() anyway...? -- Fabio Erculiani

[Qemu-devel] [PATCH] PPC: 440EP: Initialize timer

2012-01-03 Thread Alexander Graf
When using TCG with a BookE PowerPC core, we need to explicitly initialize the BookE timers with the correct frequencies. This was missing for 440EP, since that code came from KVM and was never used with TCG. Signed-off-by: Alexander Graf --- hw/ppc440.c |1 + 1 files changed, 1 insertions(

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 19:46, Fabio Erculiani wrote: > How about setting ts->bprm->argv = target_argv; ? > I'm not a qemu codebase expert, but if it's always NULL (why is it > NULL?) or can be NULL... It should already be set it loader_exec. I don't know why it's NULL there for you. I suppose some d

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
Mumble, that is what happens already... Let me see why I get NULL here... -- Fabio Erculiani

[Qemu-devel] [PATCH] PPC: 440: Ignore invalid PCI IRQs

2012-01-03 Thread Alexander Graf
When running a 440 target, we currently get invalid irq_num values (-1) which completely confuse the IRQ setting code. This is most likely due to the missing qdev conversion. While this shouldn't happen in the first place and should really rather be fixed by converting the target, I dislike segfa

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
How about setting ts->bprm->argv = target_argv; ? I'm not a qemu codebase expert, but if it's always NULL (why is it NULL?) or can be NULL... It looks like can be done easily from main.c... without making a variable global. -- Fabio Erculiani

[Qemu-devel] [PATCH] PPC: Bamboo: Set initial TLB entry

2012-01-03 Thread Alexander Graf
Back in the day when the bamboo target got introduced, the initial TLB was dictated by KVM. TCG has been missing initial TLB values ever since, rendering the target unusable for TCG usage. This patch adds linear TLB maps the way Linux expects them, making the target work. Signed-off-by: Alexander

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 19:04, Fabio Erculiani wrote: > On Tue, Jan 3, 2012 at 6:41 PM, Alexander Graf wrote: >> >> On 03.01.2012, at 17:07, Fabio Erculiani wrote: >> >>> ts->bprm->argv seems NULL here. >>> Isn't it supposed to be set? >> >> Good question. Maybe we need some other way to fetch argv

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 19:08, Fabio Erculiani wrote: > Or just using linux_binprm->filename with basename() No, that'd be wrong since argv[0] can be different from the actual file name. Also it can be the full path or not depending on what the initiator defined. Alex

[Qemu-devel] [PATCH] PPC: Bamboo: Register CPU reset

2012-01-03 Thread Alexander Graf
To be able to support CPU reset, we need to put all register initialization and initial state into a CPU reset hook instead of a function that is only called once on bootup. This is a preparation step for the initial TLB setting code and brings bamboo more in line with what e500 and virtex already

[Qemu-devel] [PATCH] PPC: Get -M bamboo work with TCG

2012-01-03 Thread Alexander Graf
The -M bamboo target got introduced by Hollis back in the day as a way to run KVM code on ppc440. Unfortunately, since then it's been bitrot quite a bit. One of the reasons for this is that nobody without a ppc440 board can actually run the code, so even if there were volunteers to improve the cod

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
Or just using linux_binprm->filename with basename() -- Fabio Erculiani

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
On Tue, Jan 3, 2012 at 6:41 PM, Alexander Graf wrote: > > On 03.01.2012, at 17:07, Fabio Erculiani wrote: > >> ts->bprm->argv seems NULL here. >> Isn't it supposed to be set? > > Good question. Maybe we need some other way to fetch argv0 then? or we could leave just an empty string for now -> "()

[Qemu-devel] Stalls on Live Migration of VMs with a lot of memory

2012-01-03 Thread Peter Lieven
Hi all, is there any known issue when migrating VMs with a lot of (e.g. 32GB) of memory. It seems that there is some portion in the migration code which takes too much time when the number of memory pages is large. Symptoms are: Irresponsive VNC connection, VM stalls and also irresponsive QE

Re: [Qemu-devel] [PATCH] linux-user: use uint64_t for getpid()

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 17:08, Fabio Erculiani wrote: > This fixes -Wformat warning introduced by > 983da8bec44fd1ab5e9730f01e719b3849aa0a35 > > Signed-off-by: Fabio Erculiani As long as your original patch isn't applied yet, please just respin it and submit v2 or v3 of your original patch :). Al

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Alexander Graf
On 03.01.2012, at 17:07, Fabio Erculiani wrote: > ts->bprm->argv seems NULL here. > Isn't it supposed to be set? Good question. Maybe we need some other way to fetch argv0 then? Alex

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:16 PM, Avi Kivity wrote: > On 01/03/2012 07:09 PM, Avi Kivity wrote: > > (strange, I was 100% sure I tested Xen). > > > > Ah, we have different CONFIG_XEN_CTRL_INTERFACE_VERSIONs. > Updated branch pushed - changed the signature of an empty-bodied function, should be safe. git:/

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:09 PM, Avi Kivity wrote: > (strange, I was 100% sure I tested Xen). > Ah, we have different CONFIG_XEN_CTRL_INTERFACE_VERSIONs. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:06 PM, Anthony Liguori wrote: > On 12/27/2011 09:38 AM, Avi Kivity wrote: >> Changes since first posting: fold a fixup patch into its parent patch, >> style fixes. >> >> I didn't get much review or testing for vhost or Xen, due to various >> issues around births separated by a larg

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Anthony Liguori
On 12/27/2011 09:38 AM, Avi Kivity wrote: Changes since first posting: fold a fixup patch into its parent patch, style fixes. I didn't get much review or testing for vhost or Xen, due to various issues around births separated by a large amount of time if not distance, but I don't want to get thi

Re: [Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Orit Wasserman
On 01/03/2012 06:32 PM, Anthony Liguori wrote: > On 01/03/2012 09:34 AM, Orit Wasserman wrote: >> Changes from v4: >> 1) Rebase >> 2) divide patch into 9 patches >> 3) move memory allocation into cache_insert >> >> By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM >> downtime

Re: [Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Anthony Liguori
On 01/03/2012 09:34 AM, Orit Wasserman wrote: Changes from v4: 1) Rebase 2) divide patch into 9 patches 3) move memory allocation into cache_insert By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory write intensive

Re: [Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 3:57 PM, Orit Wasserman wrote: > On 01/03/2012 05:47 PM, Stefan Hajnoczi wrote: >> On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman wrote: >>> +        .args_type  = "detach:-d,blk:-b,inc:-i,xbrle:-x,uri:s", >>> +        .params     = "[-d] [-b] [-i] [-x] uri", >>> +        .

[Qemu-devel] [PATCH 08/10] pseries: Populate "/chosen/linux, stdout-path" in the FDT

2012-01-03 Thread Alexander Graf
From: David Gibson There is a device tree property "/chosen/linux,stdout-path" which indicates which device should be used as stdout - ie. "the console". Currently we don't specify anything, which means both firmware and Linux choose something arbitrarily. Use the routine we added in the last pa

[Qemu-devel] [PATCH v5 9/9] Add XBRLE statistics information

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 67 +++ migration.c | 11 + migration.h |9 3 files changed, 87 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 6b839a1..037d8ba 100644 ---

[Qemu-devel] [PATCH v5 2/9] Add rle_encode and rle_decode functions Implement Run Length Encoding compression

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index fdda277..426b34d 100644 --- a/arch_init.c +++ b/arch_init.c @@ -139,6 +139,9 @@ typedef

[Qemu-devel] [PATCH v5 7/9] Add set_cachesize to change XBRLE cache size

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- migration.c | 25 - migration.h |7 +++ 2 files changed, 31 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index ed47958..3d88cdd 100644 --- a/migration.c +++ b/migration.c @@ -380,7 +380,30 @@ void migrat

[Qemu-devel] [PATCH v5 6/9] Add xbrle parameters to MigrationState

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- block-migration.c |4 +++- hw/hw.h |4 +++- migration.c | 15 +-- migration.h |3 +++ savevm.c | 11 +++ sysemu.h |4 +++- 6 files changed, 32 insertions(+), 9 deletions(-) diff --g

[Qemu-devel] [PATCH] linux-user: use uint64_t for getpid()

2012-01-03 Thread Fabio Erculiani
This fixes -Wformat warning introduced by 983da8bec44fd1ab5e9730f01e719b3849aa0a35 Signed-off-by: Fabio Erculiani --- linux-user/syscall.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index f2af5d5..e563c00 100644 --- a/li

Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.

2012-01-03 Thread Fabio Erculiani
ts->bprm->argv seems NULL here. Isn't it supposed to be set? -- Fabio Erculiani

  1   2   >