[Qemu-devel] [PATCH] net/socket.c: Fix fd leak in net_socket_listen_init() error paths

2011-12-24 Thread Peter Maydell
Fix a leak of a file descriptor due to missing closesocket() calls in error paths in net_socket_listen_init(). Signed-off-by: Peter Maydell --- Coverity again... net/socket.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index aaf9be4..c9d

[Qemu-devel] [PATCH] gdbstub: Fix fd leak in gdbserver_open() error path

2011-12-24 Thread Peter Maydell
Fix a leak of a file descriptor in error exit paths in gdbserver_open(). Signed-off-by: Peter Maydell --- Of no great consequence, but it was in the pile of coverity complaints and it's a trivial fix. gdbstub.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gdbstub.c

[Qemu-devel] [Bug 884942] Re: hw/usb.c:336: usb_packet_complete: Assertion `p->owner != ((void *)0)' failed.

2011-12-24 Thread Peter Maydell
qemu 1.0 is out now -> marking this bug as 'fix released'. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/884942 Title: hw/usb.c:336: usb_pac

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-12-24 Thread Peter Maydell
We fixed all our set-but-not-used warnings for QEMU 1.0. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/793317 Title: Large amount of write-o

[Qemu-devel] [Bug 621780] Re: 160 unused but set variables in QEMU

2011-12-24 Thread Peter Maydell
We fixed all our unused-but-set compiler warnings some time before the release of qemu 1.0, so I'm closing this bug as fixed. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. htt

[Qemu-devel] ..

2011-12-24 Thread Hugo Vanwoerkom
My dear Sir: http://rimsoffuture.com/55folderwww/yttq1ytq1.php?ityCID=76 Sat, 24 Dec 2011 21:44:05 _ "Hooper and the daughter, and retreated with the boys as hurriedly as Bill could manage his handy crutch." (c) Jody-Anne vэjimeиnэm

[Qemu-devel] [PATCH 1/2] target-arm: Don't use cpu_single_env in bank_number()

2011-12-24 Thread Peter Maydell
Avoid using cpu_single_env in bank_number() -- if we were called via the gdb stub reading or writing the CPSR then it is NULL and we will segfault if we take the cpu_abort(). Signed-off-by: Peter Maydell --- target-arm/helper.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-

[Qemu-devel] [PATCH 2/2] target-arm: Ignore attempts to set invalid modes in CPSR

2011-12-24 Thread Peter Maydell
Ignore attempts to set the CPSR mode field to an invalid value. This is UNPREDICTABLE, but we should not cpu_abort() for things a malicious guest (or a confused user on the gdbstub interface) can provoke. Signed-off-by: Peter Maydell --- target-arm/helper.c | 30 +-

[Qemu-devel] [PATCH 0/2] ARM: fix crash/abort when setting invalid mode

2011-12-24 Thread Peter Maydell
https://bugs.launchpad.net/qemu/+bug/607794 reports a problem where qemu will segfault if you try to set CPSR to an invalid mode via the gdb stub. These patches fix the segfault by not using cpu_single_env when it might not be valid, and also avoid the problem by not aborting in this situation. Ins

[Qemu-devel] [Bug 607794] Re: SEGFAULT caused by modifying the CPSR register

2011-12-24 Thread Peter Maydell
The missing detail in this bug report is that you only get the segfault if the CPSR register is being changed via the gdb stub interface. This happens because we try to use cpu_single_env as the env to pass to cpu_abort(), and if you've got to bank_number() via the gdb stub then cpu_single_env is N

[Qemu-devel] [PATCH] configure: Fix test for supported host CPU type

2011-12-24 Thread Peter Maydell
The test for whether the host CPU is supported had several problems: * the attempt to fall back to TCI was done as a duplicate test, very late (so "--cpu foo" would fail early but "--cpu unicore32" would fail late, differently, and after configure had already printed a lot of output) * a

Re: [Qemu-devel] Seem thread Competition

2011-12-24 Thread Alon Levy
On Thu, Dec 22, 2011 at 07:07:14PM +0800, ZhouPeng wrote: > On Thu, Dec 22, 2011 at 6:00 PM, Alon Levy wrote: > > On Thu, Dec 22, 2011 at 05:42:29PM +0800, ZhouPeng wrote: > >> On Thu, Dec 22, 2011 at 4:42 PM, Alon Levy wrote: > >> > On Thu, Dec 22, 2011 at 10:13:50AM +0800, ZhouPeng wrote: > >>

Re: [Qemu-devel] VMDK: footer must take precedence over header when present

2011-12-24 Thread Fam Zheng
On Thu, Dec 22, 2011 at 7:34 AM, B Gordon wrote: > VMDK: footer must take precedence over header when present > > In e.g. streamOptimized VMDKs from VSphere 4 with this flag set the > header l1_table is bogus and only the footer l1_table can be used to > correctly read extents. > > Also reverts re

Re: [Qemu-devel] [PATCH v2 2/9] arm: Set frequencies for arm_timer

2011-12-24 Thread Andreas Färber
Am 22.12.2011 19:20, schrieb Mark Langsdorf: > Use qdev properties to allow board modelers to set the frequencies > for the sp804 timer. Each of the sp804's timers can have an > individual frequency. The timers default to 1MHz. > > Signed-off-by: Mark Langsdorf > --- > Changes from v1 > Sim