Re: [Qemu-devel] [PATCH] qemu-nbd.c : fix memory leak

2011-12-01 Thread Zhi Hui Li
Thank you very much!

Re: [Qemu-devel] [RFC v2 2/6] qtest: add support for target-i386 -M pc

2011-12-01 Thread Paolo Bonzini
On 12/01/2011 07:43 PM, Anthony Liguori wrote: This involves forcing the CPU into the halted state if qtest is enabled and replacing the local APIC with the qtest interrupt controller. It should be pretty straight forward to do the same for other machine types on other architectures. Signed-off

Re: [Qemu-devel] [PATCH] qemu-nbd.c : fix memory leak

2011-12-01 Thread Paolo Bonzini
On 12/02/2011 08:42 AM, Stefan Weil wrote: -if (sharing_fds[0] == -1) +if (sharing_fds[0] == -1) { +g_free(sharing_fds); return 1; +} if (device) { int ret; Zhihui, Kernel should free all memory used by the process after it exits. So there's no m

Re: [Qemu-devel] [PATCH] qemu-nbd.c : fix memory leak

2011-12-01 Thread Stefan Weil
Am 02.12.2011 08:28, schrieb Mark Wu: On 12/02/2011 11:34 AM, Li Zhi Hui wrote: Signed-off-by: Li Zhi Hui --- qemu-nbd.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 291cba2..ab7fa6c 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -500,

Re: [Qemu-devel] [PATCH] qemu-nbd.c : fix memory leak

2011-12-01 Thread Mark Wu
On 12/02/2011 11:34 AM, Li Zhi Hui wrote: Signed-off-by: Li Zhi Hui --- qemu-nbd.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 291cba2..ab7fa6c 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -500,8 +500,10 @@ int main(int argc, char **

Re: [Qemu-devel] [ICON] Quinn the Qemu emu gazes ahead thoughtfully, considering what the future holds

2011-12-01 Thread Mulyadi Santosa
On Wed, Nov 30, 2011 at 21:41, Alex Bradbury wrote: > I lack drawing skills, so took a vectorised version of the public > domain emu drawing [1] from openclipart (currently down...). A lot of > talk has been about a new Qemu "icon" but I think that is far less > important than a logo to be used on

Re: [Qemu-devel] [PATCH] hw/smbus_eeprom.c : fix memory leak

2011-12-01 Thread Zhi Hui Li
On 2011年12月02日 11:47, Mark Wu wrote: On 12/02/2011 11:23 AM, Li Zhi Hui wrote: Signed-off-by: Li Zhi Hui --- hw/smbus_eeprom.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/smbus_eeprom.c b/hw/smbus_eeprom.c index 5d080ab..d66fbbc 100644 --- a/hw/smbus_eeprom.c +++ b/hw

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-01 Thread Alexey Kardashevskiy
On 29/11/11 16:48, Alex Williamson wrote: > On Tue, 2011-11-29 at 15:34 +1100, Alexey Kardashevskiy wrote: >> Hi! >> >> On 29/11/11 14:46, Alex Williamson wrote: >>> On Tue, 2011-11-29 at 12:52 +1100, Alexey Kardashevskiy wrote: Hi! I tried (successfully) to run it on POWER and while

[Qemu-devel] [Bug 886408] Re: Windows 64 bits install BSOD : UNSUPPORTED_PROCESSOR (only without kvm)

2011-12-01 Thread Chase
I hit this bug too. Definitely a show-stopper. Going to have to put VirtualBox on it in the meantime. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/886408 Title: Windows 64 bits install BSOD : UNSU

[Qemu-devel] [Bug 886408] Re: Windows 64 bits install BSOD : UNSUPPORTED_PROCESSOR (only without kvm)

2011-12-01 Thread Chase
Win 7 ultimate SP1 (Eng) on a poweredge 2850, xeon cpu 3.6ghz x 4 16 gigs of ram. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/886408 Title: Windows 64 bits install BSOD : UNSUPPORTED_PROCESSOR (o

Re: [Qemu-devel] [PATCH] hw/smbus_eeprom.c : fix memory leak

2011-12-01 Thread Mark Wu
On 12/02/2011 11:23 AM, Li Zhi Hui wrote: Signed-off-by: Li Zhi Hui --- hw/smbus_eeprom.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/smbus_eeprom.c b/hw/smbus_eeprom.c index 5d080ab..d66fbbc 100644 --- a/hw/smbus_eeprom.c +++ b/hw/smbus_eeprom.c @@ -142,4 +142,

[Qemu-devel] [PATCH] qemu-nbd.c : fix memory leak

2011-12-01 Thread Li Zhi Hui
Signed-off-by: Li Zhi Hui --- qemu-nbd.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 291cba2..ab7fa6c 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -500,8 +500,10 @@ int main(int argc, char **argv) sharing_fds[0] = tcp_socket_in

[Qemu-devel] [PATCH] hw/smbus_eeprom.c : fix memory leak

2011-12-01 Thread Li Zhi Hui
Signed-off-by: Li Zhi Hui --- hw/smbus_eeprom.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/smbus_eeprom.c b/hw/smbus_eeprom.c index 5d080ab..d66fbbc 100644 --- a/hw/smbus_eeprom.c +++ b/hw/smbus_eeprom.c @@ -142,4 +142,5 @@ void smbus_eeprom_init(i2c_bus *smbus, i

[Qemu-devel] [RFC v2 2/6] qtest: add support for target-i386 -M pc

2011-12-01 Thread Anthony Liguori
This involves forcing the CPU into the halted state if qtest is enabled and replacing the local APIC with the qtest interrupt controller. It should be pretty straight forward to do the same for other machine types on other architectures. Signed-off-by: Anthony Liguori --- hw/pc.c |7 ++

[Qemu-devel] [RFC v2 5/6] Add RTC test case

2011-12-01 Thread Anthony Liguori
--- rtc-test.py | 105 +++ 1 files changed, 105 insertions(+), 0 deletions(-) create mode 100644 rtc-test.py diff --git a/rtc-test.py b/rtc-test.py new file mode 100644 index 000..3159795 --- /dev/null +++ b/rtc-test.py @@ -0,0 +1,105

[Qemu-devel] [RFC v2 1/6] qtest: add test framework

2011-12-01 Thread Anthony Liguori
The idea behind qtest is pretty simple. Instead of executing a CPU via TCG or KVM, rely on an external process to send events to the device model that the CPU would normally generate. qtest presents itself as an accelerator. In addition, a new option is added to establish a qtest server (-qtest)

[Qemu-devel] [RFC v2 6/6] Add C version of rtc-test

2011-12-01 Thread Anthony Liguori
--- Makefile |4 + rtc-test.c | 201 2 files changed, 205 insertions(+), 0 deletions(-) create mode 100644 rtc-test.c diff --git a/Makefile b/Makefile index 301c75e..838cb01 100644 --- a/Makefile +++ b/Makefile @@ -215,6 +215,10

[Qemu-devel] [RFC v2 0/6] qtest unit test framework

2011-12-01 Thread Anthony Liguori
This series is still pretty rough but I wanted to get an idea of what people thought about it before polishing it. The general idea is outlined in the first test. The main advantage of this type of test framework compared to something like kvm-unit-test is that you don't need a build environment

[Qemu-devel] [RFC v2 3/6] Add core python test framework

2011-12-01 Thread Anthony Liguori
--- qtest.py | 69 ++ 1 files changed, 69 insertions(+), 0 deletions(-) create mode 100644 qtest.py diff --git a/qtest.py b/qtest.py new file mode 100644 index 000..5ac2e9b --- /dev/null +++ b/qtest.py @@ -0,0 +1,69 @@ +import soc

Re: [Qemu-devel] [PATCH 14/18] rtc: add a dynamic property for retrieving the date

2011-12-01 Thread Anthony Liguori
On 12/01/2011 09:46 AM, Gerd Hoffmann wrote: Hi, +static void rtc_get_date(DeviceState *dev, Visitor *v, void *opaque, + const char *name, Error **errp) +{ +ISADevice *isa = DO_UPCAST(ISADevice, qdev, dev); +RTCState *s = DO_UPCAST(RTCState, dev, isa); + +

[Qemu-devel] [RFC v2 4/6] Add uart test case

2011-12-01 Thread Anthony Liguori
--- serial-test.py | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 serial-test.py diff --git a/serial-test.py b/serial-test.py new file mode 100644 index 000..7aed0cb --- /dev/null +++ b/serial-test.py @@ -0,0 +1,24 @@ +from qtest import

Re: [Qemu-devel] [PATCH 01/18] qom: add new dynamic property infrastructure based on Visitors

2011-12-01 Thread Anthony Liguori
On 12/01/2011 09:52 AM, Kevin Wolf wrote: Am 30.11.2011 22:03, schrieb Anthony Liguori: qdev properties are settable only during construction and static to classes. This isn't flexible enough for QOM. This patch introduces a property interface for qdev that provides dynamic properties that are

[Qemu-devel] FELIZ NATAL

2011-12-01 Thread VENDAS
Caso não visualize esse email adequadamente VIEW_LINK http://infomaisnet1.enviodenews.com/ver_mensagem.php?id=H|2149|75609|13300584354600acesse este link[/VIEW_LINK] Se você não deseja mais receber nossos e-mails, cancele sua inscrição através do link http://infomaisnet1.enviodenews.com/admin/

Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new style properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 10:14 AM, Kevin Wolf wrote: Am 30.11.2011 22:03, schrieb Anthony Liguori: Expose all legacy properties through the new QOM property mechanism. The qdev property types are exposed through the 'legacy<>' namespace. They are always visited as strings since they do their own string p

Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new style properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 09:51 AM, Gerd Hoffmann wrote: Hi, +for (prop = dev->info->props; prop&& prop->name; prop++) { +qdev_property_add_legacy(dev, prop, NULL); +} bus properties? Hrm, okay, I can fix that. Thanks for pointing that out. +static void qdev_get_legacy_property

Re: [Qemu-devel] [PATCH] Add a .mailmap to map pre-git-conversion authors to friendly names

2011-12-01 Thread Paul Brook
> Add a .mailmap file so 'git shortlog' can map the unfriendly > pre-git-conversion author entries to real names. >+Paul Brook> pbrook > This bit looks ok to me. Paul

Re: [Qemu-devel] [Xen-devel] [PATCH V5 07/10] Introduce Xen PCI Passthrough, qdevice (1/3)

2011-12-01 Thread Konrad Rzeszutek Wilk
On Thu, Nov 24, 2011 at 05:44:36PM +, Anthony PERARD wrote: > From: Allen Kay > > A more complete history can be found here: > git://xenbits.xensource.com/qemu-xen-unstable.git > > Signed-off-by: Allen Kay > Signed-off-by: Guy Zana > Signed-off-by: Anthony PERARD > --- > Makefile.target

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Marcelo Tosatti wrote: > On Thu, Dec 01, 2011 at 06:36:17PM +0100, Jan Kiszka wrote: > > On 2011-12-01 18:22, Eric B Munson wrote: > > > On Thu, 01 Dec 2011, Jan Kiszka wrote: > > > > > >> On 2011-11-29 22:36, Eric B Munson wrote: > > >>> Often when a guest is stopped from th

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Marcelo Tosatti
On Thu, Dec 01, 2011 at 06:36:17PM +0100, Jan Kiszka wrote: > On 2011-12-01 18:22, Eric B Munson wrote: > > On Thu, 01 Dec 2011, Jan Kiszka wrote: > > > >> On 2011-11-29 22:36, Eric B Munson wrote: > >>> Often when a guest is stopped from the qemu console, it will report > >>> spurious > >>> soft

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Marcelo Tosatti
On Thu, Dec 01, 2011 at 12:19:38PM -0500, Eric B Munson wrote: > On Thu, 01 Dec 2011, Jan Kiszka wrote: > > > On 2011-11-29 22:36, Eric B Munson wrote: > > > Often when a guest is stopped from the qemu console, it will report > > > spurious > > > soft lockup warnings on resume. There are kernel

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-01 Thread Alex Williamson
On Thu, 2011-12-01 at 14:58 -0600, Stuart Yoder wrote: > >> The attributes are not intrinsic features of the domain. User space will > >> need to set them. But in thinking about it a bit more I think the > >> attributes > >> are more properties of the domain rather than a per map() operation > >

[Qemu-devel] [ANNOUNCE] QEMU 1.0 release

2011-12-01 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of QEMU 1.0! Over 8 years ago, Fabrice Bellard started QEMU as a small tool to run x86 Linux binaries on non-x86 Linux platforms. QEMU has since evolved into a cross architecture full system simulator capable of simulating

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework

2011-12-01 Thread Stuart Yoder
>> The attributes are not intrinsic features of the domain.  User space will >> need to set them.  But in thinking about it a bit more I think the attributes >> are more properties of the domain rather than a per map() operation >> characteristic.  I think a separate API might be appropriate.  Defi

[Qemu-devel] [Bug 883133] Re: qemu on ARM hosts asserts due to code buffer/libc heap conflict

2011-12-01 Thread Natalia Portillo
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/883133 Title: qemu on ARM hosts asserts due to code buffer/libc heap conflict Status

Re: [Qemu-devel] [PATCH] Add a .mailmap to map pre-git-conversion authors to friendly names

2011-12-01 Thread Peter Maydell
On 1 December 2011 19:45, Stefan Weil wrote: > I suggest keeping this list sorted (alphabetically, starting with first > column). > That makes adding new entries easier. Makes sense. Will do that in v3 (but will wait a bit to see if we get any further comments first). > New entries are useful fo

Re: [Qemu-devel] [PATCH] Add a .mailmap to map pre-git-conversion authors to friendly names

2011-12-01 Thread Stefan Weil
Am 01.12.2011 19:55, schrieb Peter Maydell: Add a .mailmap file so 'git shortlog' can map the unfriendly pre-git-conversion author entries to real names. Signed-off-by: Peter Maydell --- v1->v2: fixed Andrzej's email to match MAINTAINERS file added entries for Fabrice Bellard, Jocelyn Mayer cc'

Re: [Qemu-devel] [PATCH V3 1/4] Implement the FreeScale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the FreeScale i.MX series.

2011-12-01 Thread Peter Chubb
> "Peter" == Peter Maydell writes: Peter> On 1 December 2011 16:55, Peter Maydell Peter> wrote: >> On 30 November 2011 03:36, Peter Chubb >> wrote: >>> Signed-off-by: Hans Jang Peter> Is this email address correct? Trying to send this email got Peter> me: 550 550 ... User not known (state

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Makefile: use full path for qapi-generated directory

2011-12-01 Thread Michael Roth
On 12/01/2011 12:42 PM, Stefano Stabellini wrote: On Thu, 1 Dec 2011, Anthony Liguori wrote: On 12/01/2011 12:11 PM, Stefan Weil wrote: Am 01.12.2011 16:19, schrieb Stefano Stabellini: On Wed, 30 Nov 2011, Stefan Weil wrote: It's common to use either out-of-tree builds or in-tree builds, but

[Qemu-devel] [PATCH] Add a .mailmap to map pre-git-conversion authors to friendly names

2011-12-01 Thread Peter Maydell
Add a .mailmap file so 'git shortlog' can map the unfriendly pre-git-conversion author entries to real names. Signed-off-by: Peter Maydell --- v1->v2: fixed Andrzej's email to match MAINTAINERS file added entries for Fabrice Bellard, Jocelyn Mayer cc'd active maintainers with an entry in the m

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Makefile: use full path for qapi-generated directory

2011-12-01 Thread Stefano Stabellini
On Thu, 1 Dec 2011, Anthony Liguori wrote: > On 12/01/2011 12:11 PM, Stefan Weil wrote: > > Am 01.12.2011 16:19, schrieb Stefano Stabellini: > >> On Wed, 30 Nov 2011, Stefan Weil wrote: > >>> It's common to use either out-of-tree builds or in-tree builds, > >>> but not to mix both variants with a c

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Makefile: use full path for qapi-generated directory

2011-12-01 Thread Stefano Stabellini
On Thu, 1 Dec 2011, Stefan Weil wrote: > Am 01.12.2011 16:19, schrieb Stefano Stabellini: > > On Wed, 30 Nov 2011, Stefan Weil wrote: > >> It's common to use either out-of-tree builds or in-tree builds, > >> but not to mix both variants with a common root directory. > >> I think QEMU should explici

[Qemu-devel] [PATCH] hw/arm_gic.c: Ignore attempts to complete nonexistent IRQs

2011-12-01 Thread Peter Maydell
Ignore attempts to complete non-existent IRQs; this fixes a buffer overrun if the guest writes a bad value to the GICC_EOIR register. (This case is UNPREDICTABLE so ignoring it is a valid choice.) Note that doing nothing if the guest writes 1023 to this register is not in fact a change in behaviour

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Makefile: use full path for qapi-generated directory

2011-12-01 Thread Anthony Liguori
On 12/01/2011 12:11 PM, Stefan Weil wrote: Am 01.12.2011 16:19, schrieb Stefano Stabellini: On Wed, 30 Nov 2011, Stefan Weil wrote: It's common to use either out-of-tree builds or in-tree builds, but not to mix both variants with a common root directory. I think QEMU should explicitly forbid th

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Makefile: use full path for qapi-generated directory

2011-12-01 Thread Stefan Weil
Am 01.12.2011 16:19, schrieb Stefano Stabellini: On Wed, 30 Nov 2011, Stefan Weil wrote: It's common to use either out-of-tree builds or in-tree builds, but not to mix both variants with a common root directory. I think QEMU should explicitly forbid that mixed scenario (like other projects do).

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Arend van Spriel
On 12/01/2011 06:19 PM, Eric B Munson wrote: > On Thu, 01 Dec 2011, Jan Kiszka wrote: > >> On 2011-11-29 22:36, Eric B Munson wrote: >>> + >>> static void cpu_update_state(void *opaque, int running, RunState state) >>> { >>> CPUState *env = opaque; >>> >>> if (running) { >>>

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-12-01 Thread Dipankar Sarma
On Thu, Dec 01, 2011 at 06:36:23PM +0100, Andrea Arcangeli wrote: > On Thu, Dec 01, 2011 at 10:55:20PM +0530, Dipankar Sarma wrote: > > On Wed, Nov 30, 2011 at 06:41:13PM +0100, Andrea Arcangeli wrote: > > > On Wed, Nov 30, 2011 at 09:52:37PM +0530, Dipankar Sarma wrote: > > > > create the guest to

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-12-01 Thread Peter Zijlstra
On Wed, 2011-11-23 at 16:03 +0100, Andrea Arcangeli wrote: > Hi! > > On Mon, Nov 21, 2011 at 07:51:21PM -0600, Anthony Liguori wrote: > > Fundamentally, the entity that should be deciding what memory should be > > present > > and where it should located is the kernel. I'm fundamentally opposed

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-12-01 Thread Andrea Arcangeli
On Thu, Dec 01, 2011 at 10:55:20PM +0530, Dipankar Sarma wrote: > On Wed, Nov 30, 2011 at 06:41:13PM +0100, Andrea Arcangeli wrote: > > On Wed, Nov 30, 2011 at 09:52:37PM +0530, Dipankar Sarma wrote: > > > create the guest topology correctly and optimize for NUMA. This > > > would work for us. > >

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Jan Kiszka
On 2011-12-01 18:22, Eric B Munson wrote: > On Thu, 01 Dec 2011, Jan Kiszka wrote: > >> On 2011-11-29 22:36, Eric B Munson wrote: >>> Often when a guest is stopped from the qemu console, it will report spurious >>> soft lockup warnings on resume. There are kernel patches being discussed >>> that

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Jan Kiszka
On 2011-12-01 18:31, Arend van Spriel wrote: > On 12/01/2011 06:19 PM, Eric B Munson wrote: >> On Thu, 01 Dec 2011, Jan Kiszka wrote: >> >>> On 2011-11-29 22:36, Eric B Munson wrote: + static void cpu_update_state(void *opaque, int running, RunState state) { CPUState *env

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Jan Kiszka
On 2011-12-01 18:19, Eric B Munson wrote: > On Thu, 01 Dec 2011, Jan Kiszka wrote: > >> On 2011-11-29 22:36, Eric B Munson wrote: >>> Often when a guest is stopped from the qemu console, it will >>> report spurious soft lockup warnings on resume. There are >>> kernel patches being discussed that

[Qemu-devel] [PATCH V2] Guest stop notification

2011-12-01 Thread Eric B Munson
Often when a guest is stopped from the qemu console, it will report spurious soft lockup warnings on resume. There are kernel patches being discussed that will give the host the ability to tell the guest that it is being stopped and should ignore the soft lockup warning that generates. This patch

Re: [Qemu-devel] [PATCH V3 3/4] Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x

2011-12-01 Thread Peter Maydell
On 30 November 2011 03:36, Peter Chubb wrote: > Signed-off-by: Hans Jang > Signed-off-by: Adam Clench > Signed-off-by: Peter Chubb > --- >  Makefile.target |    2 >  hw/imx_avic.c   |  378 > >  2 files changed, 379 insertions(+), 1 delet

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-12-01 Thread Dipankar Sarma
On Wed, Nov 30, 2011 at 06:41:13PM +0100, Andrea Arcangeli wrote: > On Wed, Nov 30, 2011 at 09:52:37PM +0530, Dipankar Sarma wrote: > > create the guest topology correctly and optimize for NUMA. This > > would work for us. > > Even on the case of 1 guest that fits in one node, you're not going to

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Avi Kivity
On 12/01/2011 07:18 PM, Andreas Färber wrote: > Am 01.12.2011 11:06, schrieb Gleb Natapov: > > On Thu, Dec 01, 2011 at 11:54:33AM +0200, Avi Kivity wrote: > >> On 12/01/2011 11:47 AM, Gleb Natapov wrote: > >>> On Thu, Dec 01, 2011 at 11:41:52AM +0200, Avi Kivity wrote: > On 12/01/2011 11:37 AM

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Jan Kiszka wrote: > On 2011-11-29 22:36, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give the host the ability to tell the

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Jan Kiszka wrote: > On 2011-11-29 22:36, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give the host the ability to tell the

Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion

2011-12-01 Thread Andreas Färber
Am 01.12.2011 11:06, schrieb Gleb Natapov: > On Thu, Dec 01, 2011 at 11:54:33AM +0200, Avi Kivity wrote: >> On 12/01/2011 11:47 AM, Gleb Natapov wrote: >>> On Thu, Dec 01, 2011 at 11:41:52AM +0200, Avi Kivity wrote: On 12/01/2011 11:37 AM, Gleb Natapov wrote: >> >> Looks reasonable. S

[Qemu-devel] [PATCH] qed: add qed-tool.py image manipulation utility

2011-12-01 Thread Stefan Hajnoczi
The qed-tool.py utility can inspect and manipulate QED image files. It can be used for testing to see the state of image metadata and also to inject corruptions into the image file. It also has a scrubbing feature to copy just the metadata out of an image file, allowing users to share broken imag

[Qemu-devel] [qemu-kvm PATCH 1/1] don't try to hotplug a cpu

2011-12-01 Thread Serge Hallyn
When you do "cpu_set online" where > current number of cpus, qemu-kvm will end up crashing when qdev finds hotplug is not enabled. Let's instead gracefully refuse. See https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/878422 for the related bug report. Signed-off-by: Serge Hallyn --- hw/

Re: [Qemu-devel] [PATCH V3 2/4] Implement the timers on the FreeScale i.MX31 SoC. This is not a complete implementation, but gives enough for Linux to boot and run.

2011-12-01 Thread Peter Maydell
On 30 November 2011 03:36, Peter Chubb wrote: > > Signed-off-by: Hans Jang > Signed-off-by: Adam Clench > Signed-off-by: Peter Chubb > --- >  Makefile.target |    2 >  hw/imx_timer.c  |  460 > >  2 files changed, 461 insertions(+), 1 del

[Qemu-devel] [PATCH 0/2] ioport conversions to memory API

2011-12-01 Thread Benoît Canet
These patches convert two files ioports to memory API. Benoît Canet (2): applesmc: convert portio to memory API ppc_prep: convert ioport to memory API hw/applesmc.c | 20 - hw/ppc_prep.c | 80 - 2 files changed, 74 inser

[Qemu-devel] [PATCH 1/2] applesmc: convert portio to memory API

2011-12-01 Thread Benoît Canet
Signed-off-by: Benoît Canet --- hw/applesmc.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/applesmc.c b/hw/applesmc.c index c47b592..fb11bdf 100644 --- a/hw/applesmc.c +++ b/hw/applesmc.c @@ -165,6 +165,16 @@ static uint32_t applesmc_io_cmd_readb

[Qemu-devel] [PATCH 2/2] ppc_prep: convert ioport to memory API

2011-12-01 Thread Benoît Canet
Signed-off-by: Benoît Canet --- hw/ppc_prep.c | 80 - 1 files changed, 62 insertions(+), 18 deletions(-) diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c index f22d5b9..299305b 100644 --- a/hw/ppc_prep.c +++ b/hw/ppc_prep.c @@ -94,7 +94,8 @@ st

Re: [Qemu-devel] [PATCH V3 1/4] Implement the FreeScale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the FreeScale i.MX series.

2011-12-01 Thread Peter Maydell
On 1 December 2011 16:55, Peter Maydell wrote: > On 30 November 2011 03:36, Peter Chubb wrote: >> Signed-off-by: Hans Jang Is this email address correct? Trying to send this email got me: 550 550 ... User not known (state 17). >> Signed-off-by: Adam Clench >> Signed-off-by: Peter Chubb --

Re: [Qemu-devel] [PATCH V3 1/4] Implement the FreeScale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the FreeScale i.MX series.

2011-12-01 Thread Peter Maydell
On 30 November 2011 03:36, Peter Chubb wrote: Commit messages should be formatted with a short summary line, then a blank line, then a more detailed description. You've put everything into one extremely long summary line here, which looks odd in git log. Try: ===begin=== hw/imx_serial: Implement

Re: [Qemu-devel] [PATCH] pc: map pc ram from user-specified file

2011-12-01 Thread Peter Feiner
> Hi Hi Juan, Sorry for taking so long to reply -- my email filters apparently aren't setup correctly! > Do you have any performance number for this?  And examples on how your > are using it? The performance should depend only on the VMA backing the file, in addition to any indirect overhead ca

Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new style properties

2011-12-01 Thread Kevin Wolf
Am 30.11.2011 22:03, schrieb Anthony Liguori: > Expose all legacy properties through the new QOM property mechanism. The qdev > property types are exposed through the 'legacy<>' namespace. They are always > visited as strings since they do their own string parsing. > > Signed-off-by: Anthony Lig

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Makefile: use full path for qapi-generated directory

2011-12-01 Thread Michael Roth
On 12/01/2011 09:19 AM, Stefano Stabellini wrote: On Wed, 30 Nov 2011, Stefan Weil wrote: It's common to use either out-of-tree builds or in-tree builds, but not to mix both variants with a common root directory. I think QEMU should explicitly forbid that mixed scenario (like other projects do).

Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new style properties

2011-12-01 Thread Gerd Hoffmann
Hi, > +for (prop = dev->info->props; prop && prop->name; prop++) { > +qdev_property_add_legacy(dev, prop, NULL); > +} bus properties? > +static void qdev_get_legacy_property(DeviceState *dev, Visitor *v, void > *opaque, > + const char *name,

Re: [Qemu-devel] [PATCH 01/18] qom: add new dynamic property infrastructure based on Visitors

2011-12-01 Thread Kevin Wolf
Am 30.11.2011 22:03, schrieb Anthony Liguori: > qdev properties are settable only during construction and static to classes. > This isn't flexible enough for QOM. > > This patch introduces a property interface for qdev that provides dynamic > properties that are tied to objects, instead of classes

Re: [Qemu-devel] [PATCH 14/18] rtc: add a dynamic property for retrieving the date

2011-12-01 Thread Gerd Hoffmann
Hi, > +static void rtc_get_date(DeviceState *dev, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > +ISADevice *isa = DO_UPCAST(ISADevice, qdev, dev); > +RTCState *s = DO_UPCAST(RTCState, dev, isa); > + > +visit_start_struct(v, NULL, "struct

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Makefile: use full path for qapi-generated directory

2011-12-01 Thread Stefano Stabellini
On Wed, 30 Nov 2011, Stefan Weil wrote: > It's common to use either out-of-tree builds or in-tree builds, > but not to mix both variants with a common root directory. > I think QEMU should explicitly forbid that mixed scenario (like > other projects do). > > Even with your fix there can remain pro

Re: [Qemu-devel] [PATCH 0/4] KVM: Dirty logging optimization using rmap

2011-12-01 Thread Avi Kivity
On 11/30/2011 07:15 AM, Takuya Yoshikawa wrote: > (2011/11/30 14:02), Takuya Yoshikawa wrote: > >> IIUC, even though O(1) is O(1) at the timing of GET DIRTY LOG, it >> needs O(N) write >> protections with respect to the total number of dirty pages: >> distributed, but >> actually each page fault, w

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 09:03 AM, Gerd Hoffmann wrote: Hi, In terms of QMP client code, you just do: qom-set /path/to/usb-controller.slave /some/other/device Lacks notification. usb-controller doesn't notice that you have plugged in some usb device and thus can't raise an IRQ to notify the guest

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Avi Kivity
On 12/01/2011 05:03 PM, Gerd Hoffmann wrote: > Hi, > > > In terms of QMP client code, you just do: > > > > qom-set /path/to/usb-controller.slave /some/other/device > > Lacks notification. usb-controller doesn't notice that you have plugged > in some usb device and thus can't raise an IRQ to no

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 09:00 AM, Avi Kivity wrote: On 12/01/2011 04:53 PM, Anthony Liguori wrote: What does the client code looks like for link? I'm not sure what you mean by client code, This: but consider a device called UsbController that looks like: struct UsbController { DeviceState

[Qemu-devel] [PATCH] hw/9pfs: Use the correct file descriptor in Fsdriver Callback

2011-12-01 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Fsdriver callback that operate on file descriptor need to differentiate between directory fd and file fd. Based on the original patch from Sassan Panahinejad Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h |4 ++-- hw/9pfs/cofile.c |4

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Gerd Hoffmann
Hi, > In terms of QMP client code, you just do: > > qom-set /path/to/usb-controller.slave /some/other/device Lacks notification. usb-controller doesn't notice that you have plugged in some usb device and thus can't raise an IRQ to notify the guest ... cheers, Gerd

Re: [Qemu-devel] [PATCH 00/18] qom: dynamic properties and composition tree

2011-12-01 Thread Anthony Liguori
On 12/01/2011 08:48 AM, Avi Kivity wrote: On 12/01/2011 04:42 PM, Anthony Liguori wrote: We need good tools to allow easy review of the ABI bits hiding in patches, and to maintain ABI compatibility. Something like qemu-print-abi that dumps all properties for all devices. Patches could show

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Avi Kivity
On 12/01/2011 04:53 PM, Anthony Liguori wrote: > >> What does the client code looks like for link? > > I'm not sure what you mean by client code, This: > but consider a device called UsbController that looks like: > > struct UsbController > { > DeviceState parent; > > UsbDevice *slave; /

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 07:50 AM, Avi Kivity wrote: On 12/01/2011 03:47 PM, Anthony Liguori wrote: What if it's called with the output visitor? (warning: confusing convention). The reason there's a single Visitor type that works for both input and output visitors is to make it so you can write a single

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 08:03 AM, Avi Kivity wrote: On 12/01/2011 03:44 PM, Anthony Liguori wrote: So, links are equivalent to pointers? Yup. Once we have qom inheritance (next stage), we can have a link property and you'll be able to set it to an E1000State with the appropriate casting and error che

Re: [Qemu-devel] [PATCH 2/2] [PATCH RFC v2 2/2] hyper-v: initialize Hyper-V CPUID leaves.

2011-12-01 Thread Jan Kiszka
On 2011-10-23 17:39, Vadim Rozenfeld wrote: > --- > target-i386/kvm.c | 73 +++- > 1 files changed, 71 insertions(+), 2 deletions(-) > > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 82fec8c..c061e3b 100644 > --- a/target-i386/kvm.c >

Re: [Qemu-devel] [PATCH 1/2] [PATCH RFC v2 1/2] hyper-v: introduce Hyper-V support infrastructure.

2011-12-01 Thread Jan Kiszka
On 2011-10-23 17:39, Vadim Rozenfeld wrote: > --- > Makefile.target |2 + > target-i386/cpuid.c | 14 ++ > target-i386/hyperv.c | 65 > ++ > target-i386/hyperv.h | 37 > 4 files changed, 118 inser

Re: [Qemu-devel] [PATCH 00/18] qom: dynamic properties and composition tree

2011-12-01 Thread Avi Kivity
On 12/01/2011 04:42 PM, Anthony Liguori wrote: > >> >> We need good tools to allow easy review of the ABI bits hiding in >> patches, and to maintain ABI compatibility. Something like >> qemu-print-abi that dumps all properties for all devices. Patches could >> show the ABI changes by including a

Re: [Qemu-devel] [PATCH 00/18] qom: dynamic properties and composition tree

2011-12-01 Thread Anthony Liguori
On 12/01/2011 08:20 AM, Avi Kivity wrote: On 11/30/2011 11:03 PM, Anthony Liguori wrote: This is a follow up to my previous series to get us started in the QOM direction. A few things are different this time around. Most notably: 1) Devices no longer have names. Instead, path names are alw

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Jan Kiszka
On 2011-11-29 22:36, Eric B Munson wrote: > Often when a guest is stopped from the qemu console, it will report spurious > soft lockup warnings on resume. There are kernel patches being discussed that > will give the host the ability to tell the guest that it is being stopped and > should ignore t

Re: [Qemu-devel] [PATCH 00/18] qom: dynamic properties and composition tree

2011-12-01 Thread Avi Kivity
On 11/30/2011 11:03 PM, Anthony Liguori wrote: > This is a follow up to my previous series to get us started in the QOM > direction. A few things are different this time around. Most notably: > > 1) Devices no longer have names. Instead, path names are always used to > identify devices. > >

[Qemu-devel] Offres emplois pour vous

2011-12-01 Thread duloiscarole
Bonjour, des nouveaux offres emplois pour vous http://www.universfreeads.com/emplois.php ..

Re: [Qemu-devel] [PATCH 17/18] Add test tools

2011-12-01 Thread Stefan Hajnoczi
On Thu, Dec 1, 2011 at 1:39 PM, Anthony Liguori wrote: > On 12/01/2011 05:26 AM, Stefan Hajnoczi wrote: >> >> On Wed, Nov 30, 2011 at 03:03:47PM -0600, Anthony Liguori wrote: > Ack.  I made these changes actually but something got lost when I sent the > patches out.  I actually used git-publish fo

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Avi Kivity
On 12/01/2011 03:44 PM, Anthony Liguori wrote: >> So, links are equivalent to pointers? > > > Yup. Once we have qom inheritance (next stage), we can have a > link property and you'll be able to set it to an E1000State > with the appropriate casting and error checking taking place. I really like t

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Avi Kivity
On 12/01/2011 03:47 PM, Anthony Liguori wrote: > On 12/01/2011 06:34 AM, Avi Kivity wrote: >> On 12/01/2011 01:35 PM, Stefan Hajnoczi wrote: > > +static void qdev_get_link_property(DeviceState *dev, Visitor *v, > void *opaque, > + const char *name,

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 06:34 AM, Avi Kivity wrote: On 12/01/2011 01:35 PM, Stefan Hajnoczi wrote: +static void qdev_get_link_property(DeviceState *dev, Visitor *v, void *opaque, + const char *name, Error **errp) +{ +DeviceState **child = opaque; +gchar *path; +

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 05:21 AM, Avi Kivity wrote: On 11/30/2011 11:03 PM, Anthony Liguori wrote: Links represent an ephemeral relationship between devices. They are meant to replace the qdev concept of busses by allowing more informal relationships between devices. So, links are equivalent to pointer

[Qemu-devel] [PATCH 0/2] qemu-io tests: More fine grained control of qemu paths

2011-12-01 Thread Lucas Meneghel Rodrigues
In automated test environments, we often build and test qemu from arbitrary paths, rather than installing them on standard PATH directories. Of course, appending directories to PATH might produce the desired result, but making it possible to specify arbitrary qemu paths through environment variable

[Qemu-devel] [PATCH 1/2] check: print relevant path information

2011-12-01 Thread Lucas Meneghel Rodrigues
Print the paths of the programs under test (qemu, qemu-img and qemu-io). Signed-off-by: Lucas Meneghel Rodrigues --- check |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/check b/check index 84ef3e5..8499a04 100755 --- a/check +++ b/check @@ -158,6 +158,9 @@ FULL_HOST_

[Qemu-devel] [PATCH 2/2] common.config: Allow use of arbitrary qemu* paths

2011-12-01 Thread Lucas Meneghel Rodrigues
Since we might want to test arbitrary qemu, qemu-img and qemu-io paths, allow users to specify environment variable values for QEMU_PROG, QEMU_IMG_PROG and QEMU_IO_PROG so the testsuite will use those values rather than find them on PATH. Obviously, if such env variables are not set prior to script

Re: [Qemu-devel] [PATCH 07/18] qom: add link properties

2011-12-01 Thread Anthony Liguori
On 12/01/2011 04:55 AM, Stefan Hajnoczi wrote: On Wed, Nov 30, 2011 at 03:03:37PM -0600, Anthony Liguori wrote: +/** + * @qdev_property_add_link - Add a link property to a device + * + * Links establish relationships between devices. Links are unidirection s/unidirection/unidirectional/ Ack

Re: [Qemu-devel] [PATCH 17/18] Add test tools

2011-12-01 Thread Anthony Liguori
On 12/01/2011 05:26 AM, Stefan Hajnoczi wrote: On Wed, Nov 30, 2011 at 03:03:47PM -0600, Anthony Liguori wrote: diff --git a/QMP/qom-get b/QMP/qom-get new file mode 100755 index 000..b086bc5 --- /dev/null +++ b/QMP/qom-get @@ -0,0 +1,26 @@ +#!/usr/bin/python +## +# Virtio Support QEMU Obje

  1   2   >