[Qemu-devel] Abnormal function exit message in Qemu block drivers code

2011-10-26 Thread shu ming
Hi, After reading the block driver code in, it was found that the error exit code behaved in different ways. Here are some examples. It seems that way 3 is a better way to log the error message. In fact, It is pretty important for a administrator to know what is going on and be informed

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-26 Thread shu ming
Looks good to me. A nit, it seems that bdrv_flush is not supported anymore in upstream. bdrv_co_flush should be used instead if you update your workspace to latest one. On 2011-10-26 18:08, Robert Wang wrote: Please find version 4 in the attachment. 2011/10/23 shu ming: On 2011-10-13 0:23, D

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-10-26 Thread Roy Tam
2011/10/27 Roy Tam : > Hi, > > 2011/10/26 Jan Kiszka : >> On 2011-10-26 10:03, Roy Tam wrote: >>> Hi, >>> >>> 2011/9/15 Jan Kiszka : On 2011-09-15 15:20, Roy Tam wrote: > 2011/9/15 Jan Kiszka : >> On 2011-09-15 14:05, Roy Tam wrote: >>> Here you go. >>> >>> sb16: warning: c

[Qemu-devel] [Bug 882358] [NEW] device assignment doesn't work: "error: requires KVM support"

2011-10-26 Thread Yongjie Ren
Public bug reported: qemu.git commit:8843cf40c0f482949e6ae9d0119e45d6b96fe890 I met the following error when do device assignment with qemu in kvm host. ./x86_64-softmmu/qemu-system-x86_64 -smp 2 -m 1024 -device pci-assign,host=0e:00.0 -hda /root/jay/rhel6u1.img qemu-system-x86_64: -device pci-

[Qemu-devel] [Bug 882358] Re: device assignment doesn't work: "error: requires KVM support"

2011-10-26 Thread Yongjie Ren
** Attachment added: "qemu compiling log" https://bugs.launchpad.net/qemu/+bug/882358/+attachment/2574719/+files/make.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/882358 Title: device assi

[Qemu-devel] [Bug 882358] Re: device assignment doesn't work: "error: requires KVM support"

2011-10-26 Thread Yongjie Ren
** Attachment added: "qemu configuration log" https://bugs.launchpad.net/bugs/882358/+attachment/2574718/+files/configure.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/882358 Title: device

Re: [Qemu-devel] [virtio-spec: RFC PATCH] virtio-spec: introduce VIRTIO_NET_F_GUEST_ANNOUNCE

2011-10-26 Thread Jason Wang
On 10/27/2011 09:32 AM, Rusty Russell wrote: > On Wed, 26 Oct 2011 16:49:12 +0800, Jason Wang wrote: >> Network connections in guest need to be kept after migration. This is done by >> sending gratuitous packet and let switch learn new port of the mac >> address. As hypervisor does not have the kn

[Qemu-devel] [PATCH v2] kvm_init didn't set return value after create vm failed

2011-10-26 Thread Xu He Jie
kvm_init didn't set return value after create vm failed. And kvm_ioctl(s, KVM_CREATE_VM, 0)'s return value can be < -1, so change the check of vmfd at label 'err'. Signed-off-by: Xu He Jie --- kvm-all.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kvm-all.c b/kvm-

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-10-26 Thread Roy Tam
Hi, 2011/10/26 Jan Kiszka : > On 2011-10-26 10:03, Roy Tam wrote: >> Hi, >> >> 2011/9/15 Jan Kiszka : >>> On 2011-09-15 15:20, Roy Tam wrote: 2011/9/15 Jan Kiszka : > On 2011-09-15 14:05, Roy Tam wrote: >> Here you go. >> >> sb16: warning: command 0xf,1 is not truly understood

Re: [Qemu-devel] [PATCH 1/7] block: Remove dead code

2011-10-26 Thread Robert Wang
Reviewed-by: wdon...@linux.vnet.ibm.com 2011/10/26 Kevin Wolf : > Signed-off-by: Kevin Wolf > --- >  block.c |    6 +- >  1 files changed, 1 insertions(+), 5 deletions(-) > > diff --git a/block.c b/block.c > index 0b7bc06..86d450c 100644 > --- a/block.c > +++ b/block.c > @@ -2039,11 +2039,7 @

Re: [Qemu-devel] [virtio-spec: RFC PATCH] virtio-spec: introduce VIRTIO_NET_F_GUEST_ANNOUNCE

2011-10-26 Thread Rusty Russell
On Wed, 26 Oct 2011 16:49:12 +0800, Jason Wang wrote: > Network connections in guest need to be kept after migration. This is done by > sending gratuitous packet and let switch learn new port of the mac > address. As hypervisor does not have the knowledge of guest network > configurations such as

Re: [Qemu-devel] An opinion on copyright-notice-less qemu files

2011-10-26 Thread Richard Fontana
On Wed, Oct 26, 2011 at 06:37:19PM -0500, Anthony Liguori wrote: > >2) Because qemu has a LICENSE file (which, importantly, I am assuming > >has been in place more or less from the get-go) > > This is only sort of correct. QEMU has been around since about > 2003. There has been a LICENSE file f

[Qemu-devel] [PATCH] ppc: Correctly handle errors reading ibm, vmx and ibm, dfp properties

2011-10-26 Thread David Gibson
kvmppc_read_int_cpu_dt() returns -1 on errors. However kvmppc_host_cpu_def() assumes that it can use the return value directly for setting the corresponding instruction support bits. This will give invalid results when kvmppc_read_int_cpu_dt() returns -1 (i.e. 0x). In fact, it gets worse:

[Qemu-devel] [Bug 588955] Re: qemu segfaults when trying to install winvista64 sp2 64 bit on VM

2011-10-26 Thread Lucas Meneghel Rodrigues
This bug was opened a long time ago, and probably is no longer valid, hence, closing it as invalid. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/588

[Qemu-devel] [Bug 318824] Re: DHCP/NAT: Vista fails to get IP from DHCP engine

2011-10-26 Thread Lucas Meneghel Rodrigues
** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/318824 Title: DHCP/NAT: Vista fails to get IP from DHCP engine Status in QEMU: Invalid Bug

Re: [Qemu-devel] An opinion on copyright-notice-less qemu files

2011-10-26 Thread Anthony Liguori
Hi Richard, Thanks for posting this! On 10/26/2011 05:43 PM, Richard Fontana wrote: Hi qemu developers, WARNING: (1) I am not your lawyer; (2) this is not legal advice; (3) this is a long post which you will probably find extremely boring unless you happen to be a licensing geek, which I suspe

Re: [Qemu-devel] [PULL v2 0/8] target-arm queue

2011-10-26 Thread Peter Maydell
On 27 October 2011 00:13, andrzej zaborowski wrote: > On 20 October 2011 16:36, Peter Maydell wrote: >> Hi; these are the pending target-arm patches I'd like to get in for 1.0; >> a couple of minor ones plus the A15 insn work. Please pull. >> >> V2 of this pullreq just adds Andreas' trivial patch

Re: [Qemu-devel] [PULL v2 0/8] target-arm queue

2011-10-26 Thread andrzej zaborowski
On 20 October 2011 16:36, Peter Maydell wrote: > Hi; these are the pending target-arm patches I'd like to get in for 1.0; > a couple of minor ones plus the A15 insn work. Please pull. > > V2 of this pullreq just adds Andreas' trivial patch as 8/8, > so I haven't bothered re-emailing the identical

[Qemu-devel] An opinion on copyright-notice-less qemu files

2011-10-26 Thread Richard Fontana
Hi qemu developers, WARNING: (1) I am not your lawyer; (2) this is not legal advice; (3) this is a long post which you will probably find extremely boring unless you happen to be a licensing geek, which I suspect is not true of most if not all of you. My colleague Paolo Bonzini was discussing wit

[Qemu-devel] [PATCH 12/16] target-sparc: Implement fpack{16, 32, fix}.

2011-10-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/helper.h |3 ++ target-sparc/translate.c | 30 - target-sparc/vis_helper.c | 64 + 3 files changed, 96 insertions(+), 1 deletions(-) diff --git a/target-sparc/helper.h b

[Qemu-devel] [PATCH 02/16] target-sparc: Mark fprs dirty in store accessor.

2011-10-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 54 ++--- 1 files changed, 8 insertions(+), 46 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index da52ce6..26f7e36 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 14/16] target-sparc: Implement ALIGNADDR* inline.

2011-10-26 Thread Richard Henderson
While ALIGNADDR was implemented out-of-line, ALIGNADDRL was not implemeneted at all. However, this is a very simple operation so we're better off doing this inline. Signed-off-by: Richard Henderson --- target-sparc/helper.h |1 - target-sparc/translate.c | 24 ++--

[Qemu-devel] [PATCH 05/16] target-sparc: Make FPU/VIS helpers const when possible.

2011-10-26 Thread Richard Henderson
This also removes the unused ENV parameter from these helpers. Signed-off-by: Richard Henderson --- target-sparc/fop_helper.c |2 +- target-sparc/helper.h | 50 +++ target-sparc/translate.c | 83 ++--- target-sparc/vis_

[Qemu-devel] [PATCH 06/16] target-sparc: Extract common code for floating-point operations.

2011-10-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 835 +- 1 files changed, 381 insertions(+), 454 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 80f0058..6c13f1c 100644 --- a/target-sparc/translate.c

[Qemu-devel] [PATCH 16/16] target-sparc: Implement FALIGNDATA inline.

2011-10-26 Thread Richard Henderson
This is a relatively simple sequence of shifts. Signed-off-by: Richard Henderson --- target-sparc/helper.h |1 - target-sparc/translate.c | 32 ++-- target-sparc/vis_helper.c | 12 3 files changed, 26 insertions(+), 19 deletions(-) diff --gi

[Qemu-devel] [PATCH 13/16] target-sparc: Implement EDGE* instructions.

2011-10-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 177 +- 1 files changed, 175 insertions(+), 2 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 102c83a..d02cf06 100644 --- a/target-sparc/translate.c ++

[Qemu-devel] [PATCH 03/16] target-sparc: Add accessors for double-precision fpr access.

2011-10-26 Thread Richard Henderson
Begin using i64 quantities to manipulate double-precision values. On a 64-bit host this will, for the moment, generate less efficient code; on a 32-bit host code quality should be largely unchanged. Code quality for 64-bit will be adjusted with a subsequent patch. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH 15/16] target-sparc: Implement BMASK/BSHUFFLE.

2011-10-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/helper.h |1 + target-sparc/translate.c | 14 ++ target-sparc/vis_helper.c | 29 + 3 files changed, 40 insertions(+), 4 deletions(-) diff --git a/target-sparc/helper.h b/target-sparc/helper.h i

[Qemu-devel] [PATCH 09/16] target-sparc: Change fpr representation to doubles.

2011-10-26 Thread Richard Henderson
This allows a more efficient representation for 64-bit hosts. It should be about the same for 32-bit hosts, as we can still access the individual pieces of the double. Signed-off-by: Richard Henderson --- gdbstub.c | 35 +++--- linux-user/signal.c| 28 +

[Qemu-devel] [PATCH 01/16] target-sparc: Add accessors for single-precision fpr access.

2011-10-26 Thread Richard Henderson
Load, store, and "create destination". This version attempts to change the behaviour of the translator as little as possible. We previously used cpu_tmp32 as the temporary destination, and we continue to use that. This will eventually allow a change in representation of the fprs. Change the nam

[Qemu-devel] [PATCH 07/16] target-sparc: Extract float128 move to a function.

2011-10-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 50 - 1 files changed, 18 insertions(+), 32 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 6c13f1c..106b406 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 10/16] target-sparc: Do exceptions management fully inside the helpers.

2011-10-26 Thread Richard Henderson
This reduces the size of the individual translation blocks, since we only emit a single call for each FOP rather than three. In addition, clear_float_exceptions expands inline to a single byte store. Signed-off-by: Richard Henderson --- target-sparc/fop_helper.c | 206 +

Re: [Qemu-devel] [PATCH v2 00/16] Sparc FPU/VIS improvements

2011-10-26 Thread Richard Henderson
On 10/26/2011 02:15 PM, Richard Henderson wrote: > Changes v1->v2: > * sparc-linux-user and unrelated tcg patches removed, > * fabsd env/constification folded into patch 5 > * always_inline hack and fallout in patch 6 mitigated by marking all > of the helper functions inline as well. >

[Qemu-devel] [PATCH 08/16] target-sparc: Undo cpu_fpr rename.

2011-10-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 56 +++--- 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 106b406..0b95b64 100644 --- a/target-sparc/translate.c ++

[Qemu-devel] [PATCH 11/16] target-sparc: Implement PDIST.

2011-10-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/helper.h |1 + target-sparc/translate.c | 21 +++-- target-sparc/vis_helper.c | 21 + 3 files changed, 41 insertions(+), 2 deletions(-) diff --git a/target-sparc/helper.h b/target-sparc/helper.h in

[Qemu-devel] [PATCH v2 00/16] Sparc FPU/VIS improvements

2011-10-26 Thread Richard Henderson
Changes v1->v2: * sparc-linux-user and unrelated tcg patches removed, * fabsd env/constification folded into patch 5 * always_inline hack and fallout in patch 6 mitigated by marking all of the helper functions inline as well. * some coding-style issues cleaned up * rebased vs mainline

Re: [Qemu-devel] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-26 Thread Eric Sunshine
On Oct 26, 2011, at 4:24 PM, Stefan Weil wrote: Thank you for this extension. I have several remarks - see below. Am 26.10.2011 21:51, schrieb Eric Sunshine: An entry in the VDI block map will hold an offset to the actual block if the block is allocated, or one of two specially-interpreted va

[Qemu-devel] [PATCH 17/28] vmstate: make incompatible change for sparc

2011-10-26 Thread Juan Quintela
With this change, we sent arrays as arrays, making state description much simpler. The change is incompatible, but as far as I know, sparc don't care about migration compatibility beteween versions. Signed-off-by: Juan Quintela --- target-sparc/machine.c | 172 +++--

Re: [Qemu-devel] [PATCH 0/4] add "make check"

2011-10-26 Thread Anthony Liguori
On 10/25/2011 10:22 AM, Kevin Wolf wrote: Am 25.10.2011 17:03, schrieb Eduardo Habkost: I think qemu-iotests could be considered an instance of B) C) Functional tests that just need to run a small binary with no OS installed in the guest, but running a fully-feature qemu process. - The

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-26 Thread Anthony Liguori
On 10/25/2011 10:32 AM, Kevin Wolf wrote: Am 25.10.2011 16:06, schrieb Anthony Liguori: On 10/25/2011 08:56 AM, Kevin Wolf wrote: Am 25.10.2011 15:05, schrieb Anthony Liguori: On 10/25/2011 07:35 AM, Kevin Wolf wrote: Am 24.10.2011 13:35, schrieb Paolo Bonzini: On 10/24/2011 01:04 PM, Juan Q

Re: [Qemu-devel] [RFC] Introduce qemu_abort? (was: Fix compiler warning (always return a value))

2011-10-26 Thread Peter Maydell
On 26 October 2011 19:34, Stefan Weil wrote: > Adding the infrastructure (macros / implementation) could be done > faster. I suggest these interfaces in qemu-common.h: > > qemu_abort() - abort QEMU with a message containing function name, > file name and line (macro, see message text in my previou

[Qemu-devel] [PATCH 28/28] vmstate: rename machine.c to vmstate.c

2011-10-26 Thread Juan Quintela
They only contain vmstate cpu sections nowadays. Change name to reflect the case. Signed-off-by: Juan Quintela --- Makefile.target|2 +- target-alpha/{machine.c => vmstate.c} |0 target-arm/{machine.c => vmstate.c}|0 target-cris/{machine.c

[Qemu-devel] [PATCH 27/28] vmstate: remove unneeded includes from target-*/machine.c

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-alpha/machine.c |1 - target-arm/machine.c |1 - target-cris/machine.c |1 - target-i386/machine.c |6 -- target-lm32/machine.c |1 - target-mips/machine.c |3 --- target-ppc/machine.c |2 -- target-sparc/machine.c |

[Qemu-devel] [PATCH 26/28] vmstate: fix vmstate formating for i386

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-i386/machine.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target-i386/machine.c b/target-i386/machine.c index 0ecbfe9..612e7de 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -11,7 +11,7 @@ stat

[Qemu-devel] [PATCH 25/28] vmstate: all cpus converted

2011-10-26 Thread Juan Quintela
We don't have any more CPU_SAVEVM_VERSION users, neither cpu_save/load() ones. Signed-off-by: Juan Quintela --- exec.c|5 - qemu-common.h |4 2 files changed, 0 insertions(+), 9 deletions(-) diff --git a/exec.c b/exec.c index 09f3f01..cc84378 100644 --- a/exec.c +++ b/e

[Qemu-devel] [PATCH 24/28] vmstate: port arm cpu

2011-10-26 Thread Juan Quintela
Use one subsection for each feature. This means that we don't need to bump the version field each time that a new feature gets introduced. Introduce cpsr_vmstate field, as I am not sure if I can "use" uncached_cpsr for saving state. Signed-off-by: Juan Quintela --- target-arm/cpu.h |5

[Qemu-devel] [PATCH 23/28] arm: save always 32 fpu registers

2011-10-26 Thread Juan Quintela
This way, we fix a bug (we were overwritten the 16 first registers on load), and we don't need to check for ARM_FEATUR_VPF3, we always send the 32 registers. Signed-off-by: Juan Quintela --- target-arm/cpu.h |2 +- target-arm/machine.c | 22 ++ 2 files changed, 3 in

[Qemu-devel] [PATCH 22/28] vmstate: port mips cpu

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-mips/cpu.h |5 +- target-mips/machine.c | 465 +++-- 2 files changed, 182 insertions(+), 288 deletions(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index 7810924..af9c384 100644 --- a/target-mip

[Qemu-devel] [PATCH 21/28] mips: bump migration version to 4

2011-10-26 Thread Juan Quintela
bcond state was stored as int32, but it is target_ulong. Change migration state to reflect that. Signed-off-by: Juan Quintela --- target-mips/cpu.h |2 +- target-mips/machine.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/target-mips/cpu.h b/target-m

[Qemu-devel] [PATCH 20/28] mips: make tlb an embedded struct instead of a pointer

2011-10-26 Thread Juan Quintela
Adjust all callers. Signed-off-by: Juan Quintela --- hw/mips_timer.c |2 +- target-mips/cpu.h|2 +- target-mips/helper.c | 30 +- target-mips/machine.c| 56 +- target-mips/op_helper.c

[Qemu-devel] [PATCH 19/28] mips: make mvp an embedded struct instead of pointer

2011-10-26 Thread Juan Quintela
Adjust all callers. Signed-off-by: Juan Quintela --- hw/mips_malta.c |4 ++-- target-mips/cpu.h|4 ++-- target-mips/machine.c| 12 ++-- target-mips/op_helper.c | 30 +- target-mips/translate.c |6 +++--

[Qemu-devel] [PATCH 18/28] mips_fulong2e: cpu vmstate already registered in cpu_exec_init

2011-10-26 Thread Juan Quintela
This is the second place that register cpu migration code, it is done in general in cpu_exec_init(), just remove this call. Signed-off-by: Juan Quintela --- hw/mips_fulong2e.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c index 0

[Qemu-devel] [PATCH 16/28] vmstate: port sparc cpu

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/sun4u.c | 20 -- target-sparc/cpu.h |9 +- target-sparc/machine.c | 482 3 files changed, 283 insertions(+), 228 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index eaaefe3..b0f671d 10

[Qemu-devel] [PATCH 15/28] vmstate: define vmstate_info_uinttls

2011-10-26 Thread Juan Quintela
We are going to define arrays of this type, so we need the integer type. Signed-off-by: Juan Quintela --- hw/hw.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index ab17bb6..5d4383c 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -947,11 +947,13 @@ extern con

[Qemu-devel] [PATCH 14/28] vmstate: introduce VMSTATE_VARRAY_MULTIPLY

2011-10-26 Thread Juan Quintela
This allows to sent a partial array where the size is another structure field multiplied by a constant. Signed-off-by: Juan Quintela --- hw/hw.h | 35 +++ savevm.c |6 ++ 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/hw/hw.h b/hw/hw.h

[Qemu-devel] [PATCH 13/28] vmstate: port ppc cpu

2011-10-26 Thread Juan Quintela
Added sdr1_vmstate because storing the value requires calling ppc_store_sdr1(). The position when the function is called also changes (I think it is save). Signed-off-by: Juan Quintela --- target-ppc/cpu.h |5 +- target-ppc/machine.c | 245 ++-

[Qemu-devel] [PATCH 12/28] vmstate: Introduce VMSTATE_STRUCT_VARRAY_INT32_TEST

2011-10-26 Thread Juan Quintela
We have an array of structs whose size is an int32 in the same struct that depends on a test value to know if it is there or not. Signed-off-by: Juan Quintela --- hw/hw.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 3044cec..798732f 1

Re: [Qemu-devel] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-26 Thread Stefan Weil
Thank you for this extension. I have several remarks - see below. Am 26.10.2011 21:51, schrieb Eric Sunshine: An entry in the VDI block map will hold an offset to the actual block if the block is allocated, or one of two specially-interpreted values if not allocated. Using VirtualBox terminology

[Qemu-devel] [PATCH 11/28] vmstate: introduce float64 arrays

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/hw.h |4 savevm.c | 30 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 014cdc1..3044cec 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -355,6 +355,7 @@ extern const VMStateInfo vmstate_i

[Qemu-devel] [PATCH 10/28] vmstate: introduce float32 arrays

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/hw.h |5 + savevm.c | 30 ++ 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 0f0200a..014cdc1 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -354,6 +354,8 @@ extern const VMStateInfo vmstate_

[Qemu-devel] [PATCH 09/28] vmstate: machine.c is only compiled for !CONFIG_USER_ONLY

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-ppc/machine.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/target-ppc/machine.c b/target-ppc/machine.c index 1c40d43..226b4a5 100644 --- a/target-ppc/machine.c +++ b/target-ppc/machine.c @@ -32,7 +32,6 @@ void cpu_save(QEM

[Qemu-devel] [PATCH 08/28] vmstate: port cris cpu to vmstate

2011-10-26 Thread Juan Quintela
Have to define TLBSet struct. Multidimensional arrays in C are a mess, just unroll them. Signed-off-by: Juan Quintela --- target-cris/cpu.h | 13 ++--- target-cris/machine.c | 138 +++-- 2 files changed, 60 insertions(+), 91 deletions(-) diff -

[Qemu-devel] [PATCH 07/28] vmstate: make microblaze cpus not migrateable

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-microblaze/cpu.h |2 -- target-microblaze/machine.c | 26 ++ 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index 3530286..fc5c098 100644 --- a/target-micr

[Qemu-devel] [PATCH 06/28] vmstate: use new style for lm32 cpus

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-lm32/cpu.h |2 -- target-lm32/machine.c | 14 ++ 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h index 037ef52..bd37af8 100644 --- a/target-lm32/cpu.h +++ b/target-lm32/cpu.h @@ -20

[Qemu-devel] [PATCH 05/28] vmstate: use new cpu style for x86

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-i386/cpu.h |2 -- target-i386/machine.c | 12 +--- 2 files changed, 1 insertions(+), 13 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index a973f2e..ef6f9f4 100644 --- a/target-i386/cpu.h +++ b/target-i386/cpu.h @@ -949,

[Qemu-devel] [PATCH 04/28] vmstate: unicore32 don't support cpu migration

2011-10-26 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-unicore32/cpu.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h index b4e72cf..5632272 100644 --- a/target-unicore32/cpu.h +++ b/target-unicore32/cpu.h @@ -132,8 +132,6 @@ int uc32_cp

[Qemu-devel] [PATCH 03/28] vmstate: make all architectures export a way to migrate cpu's

2011-10-26 Thread Juan Quintela
This makes several changes: - exports VMStateDescription vmstate_cpu non-static. - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined - for the architecture that had nothing, it just register the cpu as unmigratable. - Depending on CPU_SAVE_VERSION we register old/new migration s

[Qemu-devel] [PATCH 02/28] vmstate: Simplify test for CPU_SAVE_VERSION

2011-10-26 Thread Juan Quintela
Some cpu's definitions define CPU_SAVE_VERSION, others not, but they have defined cpu_save/load. Signed-off-by: Juan Quintela --- exec.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 9dc4edb..165cfe8 100644 --- a/exec.c +++ b/exec.c @@ -591,7

[Qemu-devel] [PATCH 01/28] vmstate: Fix VMSTATE_VARRAY_UINT32

2011-10-26 Thread Juan Quintela
We didn't saved elemnts with that size (brown paper bag for me). Signed-off-by: Juan Quintela --- savevm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index f01838f..557eba4 100644 --- a/savevm.c +++ b/savevm.c @@ -1457,6 +1457,8 @@ void vmstate_

[Qemu-devel] [PATCH v2 00/28] VMState port of all cpus

2011-10-26 Thread Juan Quintela
Hi [v2] Changes since v1 - preserve arm comment that was missing (pbrook) - add copyright notice to the files that were empty - new patches: * fix formating for i386 * remove unneeded includes * rename machine.c to vmstate.c Later, Juan. [v1] This series port all cpus to use vmstate. - 1

[Qemu-devel] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-26 Thread Eric Sunshine
An entry in the VDI block map will hold an offset to the actual block if the block is allocated, or one of two specially-interpreted values if not allocated. Using VirtualBox terminology, value VDI_IMAGE_BLOCK_FREE (0x) represents a never-allocated block (semantically arbitrary content). V

Re: [Qemu-devel] [QEMU : VVFAT] vvfat.c - help required for understanding/modification

2011-10-26 Thread Pintu Kumar
Dear Mr. Johannes, I am sorry but I think you took me wrong. I never asked you to do things for me. I just wanted few clarifications to proceed further as I was stuck after performing few experiments as below: For scanning only top-level directory I used the following approach. You can refer to t

Re: [Qemu-devel] [RFC] Introduce qemu_abort? (was: Fix compiler warning (always return a value))

2011-10-26 Thread Blue Swirl
On Wed, Oct 26, 2011 at 18:34, Stefan Weil wrote: > Am 26.10.2011 19:49, schrieb Blue Swirl: >> >> On Wed, Oct 26, 2011 at 16:35, Stefan Weil wrote: >>> >>> ... >>> I personally don't like abort() because it does not show the >>> reason for the failure. >>> >>> Most users don't know how to get a

[Qemu-devel] [RFC] Introduce qemu_abort? (was: Fix compiler warning (always return a value))

2011-10-26 Thread Stefan Weil
Am 26.10.2011 19:49, schrieb Blue Swirl: On Wed, Oct 26, 2011 at 16:35, Stefan Weil wrote: ... I personally don't like abort() because it does not show the reason for the failure. Most users don't know how to get a core dump or how to use gdb. And even for those who know, a crash caused by an

Re: [Qemu-devel] New Memory API Question

2011-10-26 Thread John Baboval
So I've figured out the answer to my own question... I was, in fact, missing something. The destructor for the subregion is not overwritten. It's the parent region's destructor that is written. On 10/26/2011 09:52 AM, John Baboval wrote: Sorry for coming late to the party on this... I only re

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

2011-10-26 Thread Blue Swirl
On Wed, Oct 26, 2011 at 16:35, Stefan Weil wrote: > Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: >> >> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >>> >>> For compilations with -DNDEBUG, the default case did not return >>> a value which caused a compiler warning. >>> >>> Signed-o

Re: [Qemu-devel] [PATCH 1/2] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-26 Thread Peter Maydell
On 26 October 2011 18:08, Paolo Bonzini wrote: > On 10/26/2011 06:07 PM, Peter Maydell wrote: >> >> + * Authors: >> + *  Paolo Bonzini > > Wrong email address, Rats, I talked to you about this and then must have failed to actually make the edit! Oh well, fixed for next version. -- PMM

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-26 Thread Cleber Rosa
On 10/26/2011 12:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author: Ric

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-26 Thread Cleber Rosa
On 10/26/2011 12:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author: Ric

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-26 Thread Lucas Meneghel Rodrigues
On 10/26/2011 01:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author: Ric

[Qemu-devel] [RFC] Add a .mailmap to map pre-git-conversion authors to friendly names

2011-10-26 Thread Peter Maydell
Add a .mailmap file so 'git shortlog' can map the unfriendly pre-git-conversion author entries to real names. Signed-off-by: Peter Maydell --- I've had this kicking around in my working tree for a while, but it seems like it's more generally useful. Opinions? .mailmap | 20 +++

Re: [Qemu-devel] [PATCH 2/9] Sparc: avoid AREG0 for softint op helpers and Leon cache control

2011-10-26 Thread Blue Swirl
On Tue, Oct 25, 2011 at 21:40, Richard Henderson wrote: > On 10/25/2011 02:14 PM, Blue Swirl wrote: >> Make softint op helpers and Leon cache irq manager take a parameter >> for CPUState instead of relying on global env. Move the functions >> to int{32,64}_helper.c. >> >> Signed-off-by: Blue Swirl

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-10-26 Thread Peter Maydell
On 25 October 2011 12:09, Benoît Canet wrote: > +static const VMStateDescription vmstate_integratorcm = { > +    .name = "integratorcm", > +    .version_id = 1, > +    .minimum_version_id = 1, > +    .minimum_version_id_old = 1, > +    .fields = (VMStateField[]) { > +        VMSTATE_UINT32(memsz,

Re: [Qemu-devel] [PATCH 1/2] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-26 Thread Paolo Bonzini
On 10/26/2011 06:07 PM, Peter Maydell wrote: + * Authors: + * Paolo Bonzini Wrong email address, + * Peter Maydell otherwise looks fine. Paolo

[Qemu-devel] [PATCH 2/2] ppc64-linux-user: Fix syscall return type.

2011-10-26 Thread Richard Henderson
Use target_ulong instead of hard-coded uint32_t. Remove the disabled printf's that are redundant with -strace. Signed-off-by: Richard Henderson --- linux-user/main.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index

[Qemu-devel] [PATCH 1/2] ppc64-linux-user: Properly interpret the entry function descriptor.

2011-10-26 Thread Richard Henderson
Don't confuse the load address with the load bias. They're equal for ET_DYN objects (i.e. ld.so) but different for ET_EXEC objects (i.e. statically linked). Signed-off-by: Richard Henderson --- linux-user/elfload.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/

[Qemu-devel] [PATCH 0/2] Fix ppc64-linux-user

2011-10-26 Thread Richard Henderson
At the moment, no ppc64-linux-user tests work at all. With these two patches, I can at least run the linux-user-test-0.3 binary and a statically linked empty program (int main() { return 0; }). Given that linux-user-test-0.3 is in fact busybox, this is rather more comprehensive testing than it wo

Re: [Qemu-devel] [PATCH 2/2] Make cpu_single_env thread-local

2011-10-26 Thread Peter Maydell
On 26 October 2011 17:20, Andreas Färber wrote: >> +DECLARE_TLS(CPUState *,tls_cpu_single_env); > > So this effectively becomes tls__tls_cpu_single_env iiuc. > For compile-checking for missed conversions, > > DECLARE_TLS(CPUState *,cpu_single_env); > > should do, no? Yes. (That does impose the si

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value), introduce qemu_abort?

2011-10-26 Thread Stefan Weil
Am 26.10.2011 14:54, schrieb Stefan Hajnoczi: On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: For compilations with -DNDEBUG, the default case did not return a value which caused a compiler warning. Signed-off-by: Stefan Weil --- hw/ppce500_spin.c | 11 --- 1 files changed,

[Qemu-devel] [PATCH 0/2] TLS abstraction layer for thread-local cpu_single_env on Linux

2011-10-26 Thread Peter Maydell
These patches add enough of the TLS abstraction layer to allow us to make cpu_single_env thread-local on Linux systems. This fixes the regression described in bug 823902 for the 1.0 release; we can add the Win32 and POSIX implementations later. I haven't included Paolo's "Prepare Windows

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

2011-10-26 Thread Jan Kiszka
On 2011-10-26 18:27, Andreas Färber wrote: > Am 26.10.2011 18:02, schrieb Jan Kiszka: >> On 2011-10-26 17:18, Peter Maydell wrote: >>> On 26 October 2011 16:13, Jan Kiszka wrote: My point is that it is fine to use for per-vcpu variables because: - they are single-threaded in TCG mode >>

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

2011-10-26 Thread Andreas Färber
Am 26.10.2011 18:02, schrieb Jan Kiszka: > On 2011-10-26 17:18, Peter Maydell wrote: >> On 26 October 2011 16:13, Jan Kiszka wrote: >>> My point is that it is fine to use for per-vcpu variables because: >>> - they are single-threaded in TCG mode >>> - they are multi-threaded in KVM mode, but tha

[Qemu-devel] Correct syntax for named snapshots

2011-10-26 Thread Ottavio
According to the latest doc file you create a named snapshot like this: qemu-img snapshot [-l | -a snapshot | -c snapshot | -d snapshot] base-image.img Is this other following syntax still supported or deprecated: "qemu-img create -f qcow2 -b base-image.img snapshot.img" ? The latter is on the

Re: [Qemu-devel] [PATCH 2/2] Make cpu_single_env thread-local

2011-10-26 Thread Andreas Färber
Am 26.10.2011 18:07, schrieb Peter Maydell: > From: Paolo Bonzini > > Make cpu_single_env thread-local. This fixes a regression > in handling of multi-threaded programs in linux-user mode > (bug 823902). > > Signed-off-by: Paolo Bonzini > --- > cpu-all.h |4 +++- > darwin-user/mai

[Qemu-devel] [PATCH 1/2] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-26 Thread Peter Maydell
Add an abstraction layer for defining and using thread-local variables. For the moment this is implemented only for Linux, which means they can only be used in restricted circumstances. The abstraction layer allows us to add POSIX and Win32 support later. Signed-off-by: Peter Maydell --- qemu-tl

[Qemu-devel] [PATCH 2/2] Make cpu_single_env thread-local

2011-10-26 Thread Peter Maydell
From: Paolo Bonzini Make cpu_single_env thread-local. This fixes a regression in handling of multi-threaded programs in linux-user mode (bug 823902). Signed-off-by: Paolo Bonzini --- cpu-all.h |4 +++- darwin-user/main.c |2 -- exec.c |2 +- 3 files changed, 4

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

2011-10-26 Thread Jan Kiszka
On 2011-10-26 17:18, Peter Maydell wrote: > On 26 October 2011 16:13, Jan Kiszka wrote: >> My point is that it is fine to use for per-vcpu variables because: >> - they are single-threaded in TCG mode >> - they are multi-threaded in KVM mode, but that's only affecting Linux >> hosts for which t

[Qemu-devel] [PATCH 02/10] vmdk: remove unneeded variable assignment

2011-10-26 Thread Stefan Hajnoczi
From: Pavel Borzenkov Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi --- block/vmdk.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5d16ec4..3969131 100644 --- a/block/vmdk.c +++ b/block/vmdk

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-26 Thread Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: > Hi folks: > > We've captured a regression with floppy disk on recent qemu (and > qemu-kvm, after a code merge). We bisected it to be caused by: > > commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 > Author: Richard Henderson > Date: Mon

[Qemu-devel] [PATCH 06/10] pxa2xx_keypad: convert to memory API

2011-10-26 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/pxa2xx_keypad.c | 30 +- 1 files changed, 13 insertions(+), 17 deletions(-) diff --git a/hw/pxa2xx_keypad.c b/hw/pxa2xx_keypad.c index e33959d..de0a6c7 100644 --- a/hw/pxa2xx_keypad.c +++ b/hw/pxa2xx_keypad.c @@ -11,6 +11,7 @@ #in

  1   2   >