[Qemu-devel] [PATCH 2/2] hw/onenand: reject read-only drives

2011-10-18 Thread juha . riihimaki
From: Juha Riihimäki Signed-off-by: Juha Riihimäki --- hw/onenand.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/onenand.c b/hw/onenand.c index 6f68f70..7898da9 100644 --- a/hw/onenand.c +++ b/hw/onenand.c @@ -26,6 +26,7 @@ #include "memory.h" #include "exec

[Qemu-devel] [PATCH 0/2] nand/onenand: reject read-only drives

2011-10-18 Thread juha . riihimaki
From: Juha Riihimäki Make NAND and OneNAND device models reject read-only drives. Test for example by running $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=foo -device nand,drive=foo,chip_id=0x59 -kernel /dev/null or $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=fo

[Qemu-devel] [PATCH 1/2] hw/nand: reject read-only drives

2011-10-18 Thread juha . riihimaki
From: Juha Riihimäki Signed-off-by: Juha Riihimäki --- hw/nand.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/nand.c b/hw/nand.c index c27783e..da6529d 100644 --- a/hw/nand.c +++ b/hw/nand.c @@ -19,6 +19,7 @@ # include "flash.h" # include

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Jan Kiszka
On 2011-10-19 02:56, Michael S. Tsirkin wrote: > On Wed, Oct 19, 2011 at 12:13:49AM +0200, Jan Kiszka wrote: >> On 2011-10-18 23:40, Michael S. Tsirkin wrote: >>> On Tue, Oct 18, 2011 at 09:37:14PM +0200, Jan Kiszka wrote: On 2011-10-18 20:40, Michael S. Tsirkin wrote: > On Tue, Oct 18, 20

Re: [Qemu-devel] hw/nand hw/onenand and read-only

2011-10-18 Thread Juha.Riihimaki
On 18.10.11 16:38 , "ext Markus Armbruster" wrote: >$ qemu-system-arm -drive if=none,file=tmp.qcow2,readonly,id=foo >-device nand,drive=foo -kernel /dev/null >qemu: hardware error: nand_device_init: Unsupported NAND block size. >[...] > >Note that I didn't bother supplying a drive wit

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-18 Thread Lai Jiangshan
On 10/19/2011 03:41 AM, Jan Kiszka wrote: > On 2011-10-17 18:00, Lai Jiangshan wrote: >> On 10/17/2011 05:49 PM, Avi Kivity wrote: >>> On 10/17/2011 11:40 AM, Lai Jiangshan wrote: >> > > LINT1 may have been programmed as a level -triggered interrupt instead > of edge triggered (NMI

Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-18 Thread Paolo Bonzini
On 10/18/2011 09:26 PM, Richard Henderson wrote: > > F15 has them, and they install also on older Fedoras if you pick them from Koji. > > Acked-by: Paolo Bonzini Really? Under what name? Uhm, _F16_ has them, and they install also on older Fedoras if you pick them from Koji. Paolo

Re: [Qemu-devel] [PATCH 2/2] qcow2: Fix bdrv_write_compressed error handling

2011-10-18 Thread Dong Xu Wang
On Tue, Oct 18, 2011 at 11:47 PM, Kevin Wolf wrote: > If during allocation of compressed clusters the cluster was already allocated > uncompressed, fail and properly release the l2_table (the latter avoids a > failed assertion). > > While at it, make it return some real error numbers instead of

Re: [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event

2011-10-18 Thread canquan.shen
Hi ping fan, Your patch is similar with my patch, my patch name is "acpi: Fix CPU hot removal problem". Thanks. Canquan.Shen 2011-10-19 On 2011/10/19 10:53, pingf...@linux.vnet.ibm.com wrote: From: Liu Ping Fan Call the remove handler for ACPI_NOTIFY_EJECT_REQUEST Signed-off-by: Liu Ping

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-18 Thread Rusty Russell
On Tue, 18 Oct 2011 12:46:50 +1100, David Gibson wrote: > On Sun, Oct 16, 2011 at 03:15:53PM +0200, Avi Kivity wrote: > > On 10/14/2011 04:14 AM, David Gibson wrote: > > > > Virtio is a very, very special case. virtio requires coherent RAM > > > > access. > > > > > > Right. Virtio's access to m

[Qemu-devel] [PATCH 0/1] ACPI: Call ACPI remove handler when handling ACPI eject

2011-10-18 Thread pingfank
From: Liu Ping Fan When I tried to enable cpu hotplug feature for qemu-kvm, I found that the ACPI device eject event just skipped by kernel. static void acpi_bus_notify(acpi_handle handle, u32 type, void *data) { case ACPI_NOTIFY_EJECT_REQUEST: /* TBD */---> skipped fro

[Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event

2011-10-18 Thread pingfank
From: Liu Ping Fan Call the remove handler for ACPI_NOTIFY_EJECT_REQUEST Signed-off-by: Liu Ping Fan --- drivers/acpi/bus.c |2 +- drivers/acpi/scan.c |2 +- include/acpi/acpi_bus.h |2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/bus.c b/

[Qemu-devel] [PATCH 0/1] ACPI: Call ACPI remove handler when handling ACPI eject

2011-10-18 Thread pingfank
From: Liu Ping Fan When I tried to enable cpu hotplug feature for qemu-kvm, I found that the ACPI device eject event just skipped by kernel. static void acpi_bus_notify(acpi_handle handle, u32 type, void *data) { case ACPI_NOTIFY_EJECT_REQUEST: /* TBD */---> skipped fro

[Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event

2011-10-18 Thread pingfank
From: Liu Ping Fan Call the remove handler for ACPI_NOTIFY_EJECT_REQUEST Signed-off-by: Liu Ping Fan --- drivers/acpi/bus.c |2 +- drivers/acpi/scan.c |2 +- include/acpi/acpi_bus.h |2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/bus.c b/

Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-18 Thread Alexander Graf
On 18.10.2011, at 11:30, Blue Swirl wrote: > On Tue, Oct 18, 2011 at 9:02 AM, Alexander Graf wrote: >> >> Am 18.10.2011 um 10:55 schrieb Andreas Färber : >> >>> Am 18.10.2011 02:18, schrieb Alexander Graf: We have several targets in the PPC tree now that basically require libfdt to f

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-18 Thread KAMEZAWA Hiroyuki
On Tue, 18 Oct 2011 10:31:10 +0200 Jan Kiszka wrote: > On 2011-10-18 10:31, Wen Congyang wrote: > > At 10/18/2011 04:26 PM, Jan Kiszka Write: > >> On 2011-10-18 10:25, Wen Congyang wrote: > >>> At 10/18/2011 04:19 PM, Jan Kiszka Write: > On 2011-10-18 09:58, Wen Congyang wrote: > > At 10

[Qemu-devel] [PATCH 1/1] Introduce a new bus "ICC" to connect APIC

2011-10-18 Thread pingfank
From: Liu Ping Fan Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead of sysbus. So we can support APIC hot-plug feature. Signed-off-by: liu ping fan --- Makefile.target |1 + hw/apic.c | 25

Re: [Qemu-devel] [V2 PATCH] rtl8139: check the buffer availiability

2011-10-18 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 10:55:57AM +0800, Jason Wang wrote: > Reduce spurious packet drops on RX ring empty when in c+ mode by verifying > that > we have at least 1 buffer ahead of the time. > > Change from v1: > Fix style comments from Stefan. > > Signed-off-by: Jason Wang > --- > hw/rtl8139.

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-18 Thread Wen Congyang
At 10/18/2011 11:27 PM, Jan Kiszka Write: > On 2011-10-18 17:04, Wen Congyang wrote: >> On 10/18/2011 10:21 PM, Jan Kiszka wrote: >>> On 2011-10-18 16:17, Wen Congyang wrote: >>> >>> I was talking about information you need in the crash dump file that is >>> not contained in those files crash proce

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-18 Thread Michael S. Tsirkin
On Tue, Oct 18, 2011 at 12:46:50PM +1100, David Gibson wrote: > On Sun, Oct 16, 2011 at 03:15:53PM +0200, Avi Kivity wrote: > > On 10/14/2011 04:14 AM, David Gibson wrote: > > > > Virtio is a very, very special case. virtio requires coherent RAM > > > > access. > > > > > > Right. Virtio's access

Re: [Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-18 Thread Stuart Brady
On Tue, Oct 18, 2011 at 06:18:11PM +, Blue Swirl wrote: > Cool. Please include the spatch with the commit message. Thanks, will do! FWIW, it results in: 51 files changed, 99 insertions(+), 136 deletions(-) I wonder if that needs splitting up at all? > IIRC I had also problems with identi

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Michael S. Tsirkin
On Wed, Oct 19, 2011 at 12:13:49AM +0200, Jan Kiszka wrote: > On 2011-10-18 23:40, Michael S. Tsirkin wrote: > > On Tue, Oct 18, 2011 at 09:37:14PM +0200, Jan Kiszka wrote: > >> On 2011-10-18 20:40, Michael S. Tsirkin wrote: > >>> On Tue, Oct 18, 2011 at 08:24:39PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 2/5] runstate: Print state transition when invalid

2011-10-18 Thread Wen Congyang
At 10/15/2011 01:26 AM, Luiz Capitulino Write: > Makes it easier to debug. > > Signed-off-by: Luiz Capitulino > --- > vl.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/vl.c b/vl.c > index dbf7778..6645720 100644 > --- a/vl.c > +++ b/vl.c > @@ -397,7 +397,9 @@

Re: [Qemu-devel] [PATCH v3 22/23] monitor: Restrict pic/irq_info to supporting targets

2011-10-18 Thread Andreas Färber
Am 16.10.2011 11:53, schrieb Jan Kiszka: > From: Jan Kiszka > > This allows to drop various stubs and move the i8359 into hwlib. > > Signed-off-by: Jan Kiszka Nice, this simplifies adding new targets. Minor nit: It doesn't show up when filtering for i8259. ;) Cheers, Andreas

Re: [Qemu-devel] [PATCH 12/21] sparc-linux-user: Handle SIGILL.

2011-10-18 Thread Richard Henderson
On 10/18/2011 01:32 PM, Blue Swirl wrote: >> > +info.si_signo = SIGILL; > TARGET_SIGILL > Doh. r~

Re: [Qemu-devel] [PATCH 10/21] tcg: Optimize some forms of deposit.

2011-10-18 Thread Richard Henderson
On 10/18/2011 01:30 PM, Blue Swirl wrote: > On Tue, Oct 18, 2011 at 6:50 PM, Richard Henderson wrote: >> If the deposit replaces the entire word, optimize to a move. >> >> If we're inserting to the top of the word, avoid the mask of arg2 >> as we'll be shifting out all of the garbage and shifting

Re: [Qemu-devel] [PATCH 06/21] target-sparc: Extract common code for floating-point operations.

2011-10-18 Thread Richard Henderson
On 10/18/2011 01:24 PM, Blue Swirl wrote: >> #ifdef TARGET_SPARC64 >> -float64 helper_fabsd(CPUState *env, float64 src) >> +float64 helper_fabsd(float64 src) > > This probably should go to previous patch. Sure. >> +/* Turn off the stupid always-inline hack in osdep.h. This gets in the >> + w

Re: [Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation to doubles.

2011-10-18 Thread Richard Henderson
On 10/18/2011 01:28 PM, Blue Swirl wrote: >> > +static const char * const fregnames[32] = { >> > +"f0", "f2", "f4", "f6", "f8", "f10", "f12", "f14", >> > +"f16", "f18", "f20", "f22", "f24", "f26", "f28", "f30", >> > +"f32", "f34", "f36", "f38", "f40", "f42", "f44", "f46"

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Jan Kiszka
On 2011-10-18 23:40, Michael S. Tsirkin wrote: > On Tue, Oct 18, 2011 at 09:37:14PM +0200, Jan Kiszka wrote: >> On 2011-10-18 20:40, Michael S. Tsirkin wrote: >>> On Tue, Oct 18, 2011 at 08:24:39PM +0200, Jan Kiszka wrote: On 2011-10-18 19:06, Michael S. Tsirkin wrote: > On Tue, Oct 18, 20

[Qemu-devel] [PATCH V5] Add AACI audio playback support to the ARM Versatile/PB platform

2011-10-18 Thread Mathieu Sonet
This driver emulates the ARM AACI interface (PL041) connected to a LM4549 codec. It enables audio playback for the Versatile/PB platform. Limitations: - Supports only a playback on one channel (Versatile/Vexpress) - Supports only one TX FIFO in compact-mode or non-compact mode. - Supports playbac

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Michael S. Tsirkin
On Tue, Oct 18, 2011 at 09:37:14PM +0200, Jan Kiszka wrote: > On 2011-10-18 20:40, Michael S. Tsirkin wrote: > > On Tue, Oct 18, 2011 at 08:24:39PM +0200, Jan Kiszka wrote: > >> On 2011-10-18 19:06, Michael S. Tsirkin wrote: > >>> On Tue, Oct 18, 2011 at 05:55:54PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 3/4] loader: Add rom_add_file_buf for adding roms from a buffer

2011-10-18 Thread Jordan Justen
On Tue, Oct 18, 2011 at 11:05, Blue Swirl wrote: > On Mon, Oct 17, 2011 at 7:16 PM, Jordan Justen > wrote: >> rom_add_file_buf is similar to rom_add_file, except the rom's >> contents are provided in a buffer. >> >> rom_add_file is modified to call rom_add_file_buf after >> reading the rom's cont

[Qemu-devel] [Bug 241119] Re: usb_add of a Creative ZEN unrecognized in guest

2011-10-18 Thread Leonardo Montecchi
Hi, unfortunately my Creative ZEN (for which I initially issued the bug) broke, so I am not able to verify if it is an issue anymore, I'm sorry. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/241119 T

Re: [Qemu-devel] [PATCH 17/21] target-sparc: Implement BMASK/BSHUFFLE.

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 6:50 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- >  target-sparc/helper.h     |    1 + >  target-sparc/translate.c  |   28 >  target-sparc/vis_helper.c |   29 + >  3 files changed, 54 insert

Re: [Qemu-devel] [PATCH 12/21] sparc-linux-user: Handle SIGILL.

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 6:50 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > Cc: Riku Voipio > --- >  linux-user/main.c |    9 + >  1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index 186358b..686f6f6 100644 >

Re: [Qemu-devel] [PATCH 10/21] tcg: Optimize some forms of deposit.

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 6:50 PM, Richard Henderson wrote: > If the deposit replaces the entire word, optimize to a move. > > If we're inserting to the top of the word, avoid the mask of arg2 > as we'll be shifting out all of the garbage and shifting in zeros. > > If the host is 32-bit, reduce a 64

Re: [Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation to doubles.

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 6:50 PM, Richard Henderson wrote: > This allows a more efficient representation for 64-bit hosts. > It should be about the same for 32-bit hosts, as we can still > access the individual pieces of the double. > > Signed-off-by: Richard Henderson > --- >  gdbstub.c          

[Qemu-devel] [PATCH v2] gdbstub: Fix memory leak

2011-10-18 Thread Stefan Weil
cppcheck report: gdbstub.c:1781: error: Memory leak: s Rearranging of the code avoids the leak. v2: Replace the g_malloc0() by g_new0() (suggested by Stuart Brady). Signed-off-by: Stefan Weil --- gdbstub.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/

[Qemu-devel] [PATCH 20/21] sparc-linux-user: Add some missing syscall numbers

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson Cc: Riku Voipio --- linux-user/sparc/syscall_nr.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/linux-user/sparc/syscall_nr.h b/linux-user/sparc/syscall_nr.h index be503f2..f201f9f 100644 --- a/linux-user/sparc/syscall_nr.h +++ b/linu

Re: [Qemu-devel] [PATCH 00/21] Sparc FPU/VIS improvements

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 8:03 PM, Richard Henderson wrote: > On 10/18/2011 12:50 PM, Blue Swirl wrote: >> Thanks. Unfortunately I'm not sure I'll be able to fix and push my >> series before the freeze, because other than x86_64, none of the TCG >> targets implement AREG0 free mode. > > Oh, I see, y

[Qemu-devel] [PATCH 01/21] target-sparc: Add accessors for single-precision fpr access.

2011-10-18 Thread Richard Henderson
Load, store, and "create destination". This version attempts to change the behaviour of the translator as little as possible. We previously used cpu_tmp32 as the temporary destination, and we continue to use that. This will eventually allow a change in representation of the fprs. Change the nam

[Qemu-devel] [PATCH 05/21] target-sparc: Make VIS helpers const when possible.

2011-10-18 Thread Richard Henderson
This also removes the unused ENV parameter from these helpers. Signed-off-by: Richard Henderson --- target-sparc/helper.h | 42 +-- target-sparc/translate.c | 81 ++--- target-sparc/vis_helper.c | 35 +-- 3 fi

[Qemu-devel] [PATCH 03/21] target-sparc: Add accessors for double-precision fpr access.

2011-10-18 Thread Richard Henderson
Begin using i64 quantities to manipulate double-precision values. On a 64-bit host this will, for the moment, generate less efficient code; on a 32-bit host code quality should be largely unchanged. Code quality for 64-bit will be adjusted with a subsequent patch. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH 12/21] sparc-linux-user: Handle SIGILL.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson Cc: Riku Voipio --- linux-user/main.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 186358b..686f6f6 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -1191,6 +1191,15 @@ void

[Qemu-devel] [PATCH 16/21] target-sparc: Implement ALIGNADDR* inline.

2011-10-18 Thread Richard Henderson
While ALIGNADDR was implemented out-of-line, ALIGNADDRL was not implemeneted at all. However, this is a very simple operation so we're better off doing this inline. Signed-off-by: Richard Henderson --- target-sparc/helper.h |1 - target-sparc/translate.c | 24 ++--

[Qemu-devel] [PATCH 06/21] target-sparc: Extract common code for floating-point operations.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/fop_helper.c |2 +- target-sparc/helper.h |4 +- target-sparc/translate.c | 840 + 3 files changed, 389 insertions(+), 457 deletions(-) diff --git a/target-sparc/fop_helper.c b/target-spar

Re: [Qemu-devel] [PATCH 04/21] target-sparc: Pass float64 parameters instead of dt0/1 temporaries.

2011-10-18 Thread Richard Henderson
On 10/18/2011 01:04 PM, Blue Swirl wrote: >> > -F_HELPER(name, d) \ >> > +float64 helper_f ## name ## d (CPUState * env, float64 src1,\ >> > + float64 src2)\ >> > {

[Qemu-devel] [PATCH 15/21] target-sparc: Implement EDGE* instructions.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 177 +- 1 files changed, 175 insertions(+), 2 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 1edf255..df82ecc 100644 --- a/target-sparc/translate.c ++

[Qemu-devel] [PATCH 17/21] target-sparc: Implement BMASK/BSHUFFLE.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/helper.h |1 + target-sparc/translate.c | 28 target-sparc/vis_helper.c | 29 + 3 files changed, 54 insertions(+), 4 deletions(-) diff --git a/target-sparc/helper.h b/target-sp

Re: [Qemu-devel] [PATCH 00/21] Sparc FPU/VIS improvements

2011-10-18 Thread Richard Henderson
On 10/18/2011 12:50 PM, Blue Swirl wrote: > Thanks. Unfortunately I'm not sure I'll be able to fix and push my > series before the freeze, because other than x86_64, none of the TCG > targets implement AREG0 free mode. Oh, I see, you've not actually left the "normal" load/store helpers in op_helpe

[Qemu-devel] [PATCH 19/21] target-sparc: Implement FALIGNDATA inline.

2011-10-18 Thread Richard Henderson
This is a relatively simple sequence of shifts. Signed-off-by: Richard Henderson --- target-sparc/helper.h |1 - target-sparc/translate.c | 32 ++-- target-sparc/vis_helper.c | 12 3 files changed, 26 insertions(+), 19 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 7:40 PM, Avi Kivity wrote: > On 10/18/2011 08:08 PM, Blue Swirl wrote: >> >> > What would the API look like?  accept a range, return true if any of the >> > pages in the range are dirty? >> >> That would be 1:1 conversion but maybe better approach would be to >> return the

[Qemu-devel] [PATCH 08/21] target-sparc: Undo cpu_fpr rename.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 56 +++--- 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index f37dbb1..f8d3bf2 100644 --- a/target-sparc/translate.c ++

Re: [Qemu-devel] [PATCH 00/21] Sparc FPU/VIS improvements

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 6:50 PM, Richard Henderson wrote: > This started out to be simply flushing out the VIS2 instruction set. > But when I got a look a the DT0/1 "calling convention" I choked, and > thought we could really do better than that. > > The end result (op_opt,out_asm) looks significa

Re: [Qemu-devel] [PATCH 1/2] Move graphic-related coalesced MMIO flushes to affected device models

2011-10-18 Thread Jan Kiszka
On 2011-10-18 19:34, Avi Kivity wrote: > On 10/18/2011 06:49 PM, Jan Kiszka wrote: >> On 2011-10-18 18:40, Avi Kivity wrote: >>> On 10/18/2011 04:30 PM, Avi Kivity wrote: This takes a while to reproduce, let me talk to gdb for a bit. >>> >>> a vcpu exit causes kvm_flush_coalesced_mmio_buf

[Qemu-devel] [PATCH 10/21] tcg: Optimize some forms of deposit.

2011-10-18 Thread Richard Henderson
If the deposit replaces the entire word, optimize to a move. If we're inserting to the top of the word, avoid the mask of arg2 as we'll be shifting out all of the garbage and shifting in zeros. If the host is 32-bit, reduce a 64-bit deposit to a 32-bit deposit when possible. Signed-off-by: Richa

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-18 Thread Jan Kiszka
On 2011-10-17 18:00, Lai Jiangshan wrote: > On 10/17/2011 05:49 PM, Avi Kivity wrote: >> On 10/17/2011 11:40 AM, Lai Jiangshan wrote: > LINT1 may have been programmed as a level -triggered interrupt instead of edge triggered (NMI or interrupt). We can use the ioctl argument for

Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API

2011-10-18 Thread Avi Kivity
On 10/18/2011 08:08 PM, Blue Swirl wrote: > > > What would the API look like? accept a range, return true if any of the > > pages in the range are dirty? > > That would be 1:1 conversion but maybe better approach would be to > return the first dirty address (or zero if not found), then various > b

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Jan Kiszka
On 2011-10-18 20:40, Michael S. Tsirkin wrote: > On Tue, Oct 18, 2011 at 08:24:39PM +0200, Jan Kiszka wrote: >> On 2011-10-18 19:06, Michael S. Tsirkin wrote: >>> On Tue, Oct 18, 2011 at 05:55:54PM +0200, Jan Kiszka wrote: On 2011-10-18 17:22, Jan Kiszka wrote: > What KVM has to do is just

[Qemu-devel] [PATCH 21/21] sparc-linux-user: Enable NPTL

2011-10-18 Thread Richard Henderson
??? This doesn't work yet. The new thread crashes more or less immediately in the translated code, and then TCG aborts. Perhaps some of that cpu_reset is really required? The problem with it is that it zeros pc/npc, which also sends us off into nevernever land. Perhaps cpu_clone_regs should tak

[Qemu-devel] [PATCH 07/21] target-sparc: Extract float128 move to a function.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 50 - 1 files changed, 18 insertions(+), 32 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index c47a035..f37dbb1 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 18/21] target-sparc: Tidy fpack32.

2011-10-18 Thread Richard Henderson
Use the new gen_gsr_fop_DDD helper. Signed-off-by: Richard Henderson --- target-sparc/translate.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 66107ee..267ac71 100644 --- a/target-sparc/translate.c +++ b/

[Qemu-devel] [PATCH 13/21] target-sparc: Implement PDIST.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/helper.h |1 + target-sparc/translate.c | 21 +++-- target-sparc/vis_helper.c | 21 + 3 files changed, 41 insertions(+), 2 deletions(-) diff --git a/target-sparc/helper.h b/target-sparc/helper.h in

Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-18 Thread Richard Henderson
On 10/17/2011 11:45 PM, Paolo Bonzini wrote: > On 10/18/2011 02:18 AM, Alexander Graf wrote: >> We have several targets in the PPC tree now that basically require libfdt >> to function properly, namely the pseries and the e500 targets. This >> dependency >> will rather increase than decrease in th

[Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation to doubles.

2011-10-18 Thread Richard Henderson
This allows a more efficient representation for 64-bit hosts. It should be about the same for 32-bit hosts, as we can still access the individual pieces of the double. Signed-off-by: Richard Henderson --- gdbstub.c | 35 +++--- linux-user/signal.c| 28 +

[Qemu-devel] [PATCH 11/21] target-sparc: Do exceptions management fully inside the helpers.

2011-10-18 Thread Richard Henderson
This reduces the size of the individual translation blocks, since we only emit a single call for each FOP rather than three. In addition, clear_float_exceptions expands inline to a single byte store. Signed-off-by: Richard Henderson --- target-sparc/fop_helper.c | 206 +

[Qemu-devel] [PATCH 14/21] target-sparc: Implement fpack{16, 32, fix}.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/helper.h |3 ++ target-sparc/translate.c | 21 ++- target-sparc/vis_helper.c | 64 + 3 files changed, 87 insertions(+), 1 deletions(-) diff --git a/target-sparc/helper.h b/targe

[Qemu-devel] [PATCH 02/21] target-sparc: Mark fprs dirty in store accessor.

2011-10-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 54 ++--- 1 files changed, 8 insertions(+), 46 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 19f41b7..3dd72ab 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 00/21] Sparc FPU/VIS improvements

2011-10-18 Thread Richard Henderson
This started out to be simply flushing out the VIS2 instruction set. But when I got a look a the DT0/1 "calling convention" I choked, and thought we could really do better than that. The end result (op_opt,out_asm) looks significantly cleaner for a 64-bit host. It looks about the same for a 32-bi

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 4:37 PM, Paolo Bonzini wrote: > On 10/18/2011 06:01 PM, Anthony Liguori wrote: >> >> Unless we split linux-user off into a separate repository.  The only >> real code sharing is TCG.   I can imagine a world where TCG lived in a >> separate repo along with qemu-system and li

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Michael S. Tsirkin
On Tue, Oct 18, 2011 at 08:24:39PM +0200, Jan Kiszka wrote: > On 2011-10-18 19:06, Michael S. Tsirkin wrote: > > On Tue, Oct 18, 2011 at 05:55:54PM +0200, Jan Kiszka wrote: > >> On 2011-10-18 17:22, Jan Kiszka wrote: > >>> What KVM has to do is just mapping an arbitrary MSI message > >>> (theoretic

Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 9:02 AM, Alexander Graf wrote: > > Am 18.10.2011 um 10:55 schrieb Andreas Färber : > >> Am 18.10.2011 02:18, schrieb Alexander Graf: >>> We have several targets in the PPC tree now that basically require libfdt >>> to function properly, namely the pseries and the e500 targe

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Jan Kiszka
On 2011-10-18 19:06, Michael S. Tsirkin wrote: > On Tue, Oct 18, 2011 at 05:55:54PM +0200, Jan Kiszka wrote: >> On 2011-10-18 17:22, Jan Kiszka wrote: >>> What KVM has to do is just mapping an arbitrary MSI message >>> (theoretically 64+32 bits, in practice it's much of course much less) to >> >> (

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Jan Kiszka
On 2011-10-18 19:06, Michael S. Tsirkin wrote: > On Tue, Oct 18, 2011 at 05:55:54PM +0200, Jan Kiszka wrote: >> On 2011-10-18 17:22, Jan Kiszka wrote: >>> What KVM has to do is just mapping an arbitrary MSI message >>> (theoretically 64+32 bits, in practice it's much of course much less) to >> >> (

Re: [Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-18 Thread Blue Swirl
On Tue, Oct 18, 2011 at 1:13 AM, Stuart Brady wrote: > On Mon, Oct 17, 2011 at 10:01:25PM +0200, Stefan Weil wrote: >> >> The patch also slightly cleans the g_malloc0 statement which was >> touched by that change (no type cast, easier code review). > [...] >> -    s = (GDBRegisterState *)g_malloc0

Re: [Qemu-devel] [PATCH 1/2] Move graphic-related coalesced MMIO flushes to affected device models

2011-10-18 Thread Alon Levy
On Tue, Oct 18, 2011 at 06:49:57PM +0200, Jan Kiszka wrote: > On 2011-10-18 18:40, Avi Kivity wrote: > > On 10/18/2011 04:30 PM, Avi Kivity wrote: > >> This takes a while to reproduce, let me talk to gdb for a bit. > >> > > > > a vcpu exit causes kvm_flush_coalesced_mmio_buffer() to run, which doe

Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API

2011-10-18 Thread Blue Swirl
On Mon, Oct 17, 2011 at 8:48 PM, Avi Kivity wrote: > On 10/17/2011 09:13 PM, Blue Swirl wrote: >> > >> > -    ret = cpu_physical_memory_get_dirty(page, VGA_DIRTY_FLAG); >> > +    ret = memory_region_get_dirty(&s->vram_mem, page, DIRTY_MEMORY_VGA); >> >     for (off = 0; off < TARGET_PAGE_SIZE * 4;

Re: [Qemu-devel] [PATCH 3/4] loader: Add rom_add_file_buf for adding roms from a buffer

2011-10-18 Thread Blue Swirl
On Mon, Oct 17, 2011 at 7:16 PM, Jordan Justen wrote: > rom_add_file_buf is similar to rom_add_file, except the rom's > contents are provided in a buffer. > > rom_add_file is modified to call rom_add_file_buf after > reading the rom's contents from the file. > > Signed-off-by: Jordan Justen > ---

Re: [Qemu-devel] [PATCH] qxl: fix guest cursor tracking

2011-10-18 Thread Alon Levy
On Tue, Oct 18, 2011 at 06:58:54PM +0200, Yonit Halperin wrote: > (1) If the guest cursor command is empty, don't reload it after migration. > (2) Cleaning the guest cursor when it is released by > the spice server. In addition, explicitly reset the > cursor in spice upon destroying the pri

[Qemu-devel] [PATCH] kvm: avoid reentring kvm_flush_coalesced_mmio_buffer()

2011-10-18 Thread Avi Kivity
mmio callbacks invoked by kvm_flush_coalesced_mmio_buffer() may themselves indirectly call kvm_flush_coalesced_mmio_buffer(). Prevent reentering the function by checking a flag that indicates we're processing coalesced mmio requests. Signed-off-by: Avi Kivity --- kvm-all.c | 10 ++ 1 f

Re: [Qemu-devel] [PATCH 1/2] Move graphic-related coalesced MMIO flushes to affected device models

2011-10-18 Thread Avi Kivity
On 10/18/2011 06:49 PM, Jan Kiszka wrote: > On 2011-10-18 18:40, Avi Kivity wrote: > > On 10/18/2011 04:30 PM, Avi Kivity wrote: > >> This takes a while to reproduce, let me talk to gdb for a bit. > >> > > > > a vcpu exit causes kvm_flush_coalesced_mmio_buffer() to run, which does > > a bitblt, wh

Re: [Qemu-devel] [PATCH] fw_cfg: check return value of fread()

2011-10-18 Thread Peter Maydell
On 18 October 2011 18:16, Pavel Borzenkov wrote: > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- >  hw/fw_cfg.c |    7 +++ >  1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c > index 8df265c..1125e7d 100644 > --- a/hw/fw_cfg.c >

[Qemu-devel] [PATCH] vmdk: vmdk_read_cid returns garbage if p_name is NULL

2011-10-18 Thread Pavel Borzenkov
Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3969131..a75dcc2 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -207,7 +207,7 @@ static void vmdk_free_last_exten

[Qemu-devel] [PATCH] vmdk: remove unneeded variable assignment

2011-10-18 Thread Pavel Borzenkov
Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov --- block/vmdk.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5d16ec4..3969131 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1387,7 +1387,6 @@ static int vmdk_create(const ch

[Qemu-devel] [PATCH] qed: remove unneeded variable assignment

2011-10-18 Thread Pavel Borzenkov
'ret' is unconditionally overwitten by qed_read_l1_table_sync() Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov --- block/qed.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/qed.c b/block/qed.c index e87dc4d..c3e45af 100644 --- a/block/qed.c +++ b/block

[Qemu-devel] [PATCH] qed: don't pass NULL to memcpy

2011-10-18 Thread Pavel Borzenkov
Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov --- block/qed.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/block/qed.c b/block/qed.c index c3e45af..e6720db 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1424,8 +1424,10 @@ static int bdrv_qed_change_bac

[Qemu-devel] [PATCH] fw_cfg: check return value of fread()

2011-10-18 Thread Pavel Borzenkov
Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov --- hw/fw_cfg.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 8df265c..1125e7d 100644 --- a/hw/fw_cfg.c +++ b/hw/fw_cfg.c @@ -113,6 +113,13 @@ static FILE *probe_splashfile(c

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Michael S. Tsirkin
On Tue, Oct 18, 2011 at 05:55:54PM +0200, Jan Kiszka wrote: > On 2011-10-18 17:22, Jan Kiszka wrote: > > What KVM has to do is just mapping an arbitrary MSI message > > (theoretically 64+32 bits, in practice it's much of course much less) to > > ( There are 24 distinguishing bits in an MSI message

[Qemu-devel] [PATCH] qxl: fix guest cursor tracking

2011-10-18 Thread Yonit Halperin
(1) If the guest cursor command is empty, don't reload it after migration. (2) Cleaning the guest cursor when it is released by the spice server. In addition, explicitly reset the cursor in spice upon destroying the primary surface (was done by spice-server implicitly). This will preven

Re: [Qemu-devel] [PATCH 1/2] Move graphic-related coalesced MMIO flushes to affected device models

2011-10-18 Thread Jan Kiszka
On 2011-10-18 18:40, Avi Kivity wrote: > On 10/18/2011 04:30 PM, Avi Kivity wrote: >> This takes a while to reproduce, let me talk to gdb for a bit. >> > > a vcpu exit causes kvm_flush_coalesced_mmio_buffer() to run, which does > a bitblt, which is cirrus_do_copy(), which goes to vga_hw_update, wh

Re: [Qemu-devel] [PATCH 1/2] Move graphic-related coalesced MMIO flushes to affected device models

2011-10-18 Thread Avi Kivity
On 10/18/2011 04:30 PM, Avi Kivity wrote: > This takes a while to reproduce, let me talk to gdb for a bit. > a vcpu exit causes kvm_flush_coalesced_mmio_buffer() to run, which does a bitblt, which is cirrus_do_copy(), which goes to vga_hw_update, which does vga_update_display(), which calls qemu_f

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Paolo Bonzini
On 10/18/2011 06:01 PM, Anthony Liguori wrote: Unless we split linux-user off into a separate repository. The only real code sharing is TCG. I can imagine a world where TCG lived in a separate repo along with qemu-system and linux-user. Both repos could pull in TCG as a submodule. Nah, the

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Peter Maydell
On 18 October 2011 17:30, Anthony Liguori wrote: > > TCG can have a debug mode that makes it GPLv3 (using the binutils code). >  You wouldn't be able to consume this debug mode with linux-user. > > Probably safest thing is to put disas only in qemu-system.  linux-user would > have to log hex. Yuc

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Anthony Liguori
On 10/18/2011 11:15 AM, Peter Maydell wrote: On 18 October 2011 17:01, Anthony Liguori wrote: Ah, linux-user... hadn't thought about that. Perhaps it's a lost cause. Unless we split linux-user off into a separate repository. The only real code sharing is TCG. ...and the binutils disassembl

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Avi Kivity
On 10/18/2011 06:15 PM, Peter Maydell wrote: > On 18 October 2011 17:01, Anthony Liguori wrote: > > Ah, linux-user... hadn't thought about that. Perhaps it's a lost cause. > > > > Unless we split linux-user off into a separate repository. The only real > > code sharing is TCG. > > ...and the bin

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Anthony Liguori
On 10/18/2011 10:31 AM, Paolo Bonzini wrote: On 10/18/2011 05:19 PM, Peter Maydell wrote: On 18 October 2011 14:03, Anthony Liguori wrote: Okay, let's get serious about it. I set up the following wiki page for coordination: http://wiki.qemu.org/Relicensing This says: use the following git co

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Peter Maydell
On 18 October 2011 17:01, Anthony Liguori wrote: > Ah, linux-user... hadn't thought about that.  Perhaps it's a lost cause. > > Unless we split linux-user off into a separate repository.  The only real > code sharing is TCG. ...and the binutils disassembly code, which is the reason we wanted to m

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Peter Maydell
On 18 October 2011 16:56, Anthony Liguori wrote: > On 10/18/2011 10:19 AM, Peter Maydell wrote: >> which (apart from having a typo) only lists the people who were >> the git commit authors. This isn't the same as everybody who might >> have copyright on the change. There are certainly commits in t

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-18 Thread Jan Kiszka
On 2011-10-18 17:56, Michael S. Tsirkin wrote: >> What would probably help us long-term out of your concerns regarding >> lazy routing is to bypass that redundant GSI translation for dynamic >> messages, i.e. those that are not associated with an irqfd number or an >> assigned device irq. Something

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread Anthony Liguori
On 10/18/2011 10:19 AM, Peter Maydell wrote: On 18 October 2011 14:03, Anthony Liguori wrote: Okay, let's get serious about it. I set up the following wiki page for coordination: http://wiki.qemu.org/Relicensing This says: use the following git command to get a list of authors: git log --f

  1   2   3   >