Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-17 Thread Paolo Bonzini
On 10/18/2011 02:18 AM, Alexander Graf wrote: We have several targets in the PPC tree now that basically require libfdt to function properly, namely the pseries and the e500 targets. This dependency will rather increase than decrease in the future, so I want to make sure that people building shin

Re: [Qemu-devel] [PATCH] hw/9pfs: Fix missing parentheses

2011-10-17 Thread Aneesh Kumar K.V
On Mon, 17 Oct 2011 21:20:59 +0200, Stefan Weil wrote: > cppcheck report: > hw/9pfs/virtio-9p.c:2385: > style: Boolean result is used in bitwise operation. > Clarify expression with parentheses > hw/9pfs/virtio-9p.c:2531: > style: Boolean result is used in bitwise operation. > Clarify expressi

Re: [Qemu-devel] [PATCH] correctly null terminate the process name

2011-10-17 Thread malc
On Tue, 18 Oct 2011, Stefan Weil wrote: > Am 18.10.2011 04:06, schrieb Trevor Saunders: > > strncpy() doesn't garentee the copied string will be null terminated if > > the original is longer than the length to copy. > > > > Signed-off-by: Trevor Saunders > > --- > > os-posix.c |2 +- > > 1

Re: [Qemu-devel] [PATCH] virtio-9p: fix QEMU build break

2011-10-17 Thread Aneesh Kumar K.V
On Tue, 18 Oct 2011 14:46:25 +1100, David Gibson wrote: > On Mon, Oct 10, 2011 at 10:19:31PM +0530, Aneesh Kumar K.V wrote: > > On Mon, 10 Oct 2011 22:05:21 +0530, "Aneesh Kumar K.V" > > wrote: > > > On Mon, 10 Oct 2011 18:30:28 +0800, Zhi Yong Wu > > > wrote: > > > > qemu build break due to t

[Qemu-devel] [PATCH] RUN_STATE_POSTMIGRATE can be transited from RUN_STATE_PAUSED

2011-10-17 Thread Wen Congyang
The user can run command stop before migration. So the guest's RUN_STATE can be transisted from RUN_STATE_PAUSED to RUN_STATE_POSTMIGRATE. Signed-off-by: Wen Congyang --- vl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 2dce3ae..efae19c 100644 ---

[Qemu-devel] how to build RootFS for linux kernel(i386)

2011-10-17 Thread ravikiran borse
Hi All I need your help to learn linux kernel using QEMU. I know that there is linux-0.02 Image on your website to download. It is working fine on my PC. Can u just post me how to make such image from scratch so that I can use it with GDB. But I have downloaded my own linux kernel and build it. Bu

Re: [Qemu-devel] [PATCH] correctly null terminate the process name

2011-10-17 Thread Stefan Weil
Am 18.10.2011 04:06, schrieb Trevor Saunders: strncpy() doesn't garentee the copied string will be null terminated if the original is longer than the length to copy. Signed-off-by: Trevor Saunders --- os-posix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/os-posi

[Qemu-devel] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-17 Thread David Gibson
Currently, when KVM is enabled, the pseries machine checks if the host CPU supports VMX, VSX and/or DFP instructions and advertises accordingly in the guest device tree. It does this regardless of what CPU is selected on the command line. On the other hand, when in TCG mode, it never advertises a

[Qemu-devel] buildbot failure in qemu on trivial-patches_i386_debian_6_0

2011-10-17 Thread qemu
The Buildbot has detected a new failure on builder trivial-patches_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/trivial-patches_i386_debian_6_0/builds/64 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Bui

Re: [Qemu-devel] [PATCH] virtio-9p: fix QEMU build break

2011-10-17 Thread David Gibson
On Mon, Oct 10, 2011 at 10:19:31PM +0530, Aneesh Kumar K.V wrote: > On Mon, 10 Oct 2011 22:05:21 +0530, "Aneesh Kumar K.V" > wrote: > > On Mon, 10 Oct 2011 18:30:28 +0800, Zhi Yong Wu > > wrote: > > > qemu build break due to the redefinition of struct file_handle. My > > > qemu.git/HEAD is 8ac

[Qemu-devel] buildbot failure in qemu on qmp_x86_64_debian_6_0

2011-10-17 Thread qemu
The Buildbot has detected a new failure on builder qmp_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_x86_64_debian_6_0/builds/64 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

Re: [Qemu-devel] Your confirmation is required to leave the Qemu-devel mailing list

2011-10-17 Thread Zhi Yong Wu
confirm c8e639a4a4f5217083c36b0d7184949fb3c420c7 On Mon, Oct 17, 2011 at 10:35:09PM -0400, qemu-devel-confirm+c8e639a4a4f5217083c36b0d7184949fb3c42...@nongnu.org wrote: >Return-Path: >Received: from imap.linux.ibm.com ([unix socket]) by imap.linux.ibm.com > (Cyrus v2.3.16-Fedora-RPM-2.3.16-6.el6

[Qemu-devel] Solution and question: fix for OSX Lion build

2011-10-17 Thread Juan Pineda
Solution: Qemu 0.15 won't run under OS-X Lion because Apple switched to gcc LLVM. Actually it will build, but throws a segment fault when run. The cure is to build using gcc-4.2 (which is included under Lion.) Additionally darwin-user and bsd-user fail to compile. I gather these have been broken

[Qemu-devel] [PATCH] correctly null terminate the process name

2011-10-17 Thread Trevor Saunders
strncpy() doesn't garentee the copied string will be null terminated if the original is longer than the length to copy. Signed-off-by: Trevor Saunders --- os-posix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/os-posix.c b/os-posix.c index dbf3b24..92dcc97 100644 --

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-17 Thread David Gibson
On Sun, Oct 16, 2011 at 03:15:53PM +0200, Avi Kivity wrote: > On 10/14/2011 04:14 AM, David Gibson wrote: > > > Virtio is a very, very special case. virtio requires coherent RAM access. > > > > Right. Virtio's access to memory is *not* emulated PCI DMA, it's > > god-like hypervisor access to gues

Re: [Qemu-devel] [PATCH] Memory API bugfix - abolish addrrrange_end()

2011-10-17 Thread David Gibson
On Mon, Oct 17, 2011 at 12:34:19PM +0200, Avi Kivity wrote: > On 10/17/2011 07:31 AM, David Gibson wrote: > > > > > > In terms of how the code looks, it's seriously more ugly (see the > > > patches I sent out). Conceptually it's cleaner, since we're not dodging > > > the issue that we need to dea

Re: [Qemu-devel] [PATCH 22/36] migration: Introduce MIG_STATE_SETUP

2011-10-17 Thread Juan Quintela
Anthony Liguori wrote: > On 10/11/2011 05:00 AM, Juan Quintela wrote: > CODING_STYLE. > > Regards, > > Anthony Liguori Attached v2 of this patch. Only change is s/enum migration_state/enum/ >From 990ccd38f0ff916ada859d28831b2be63983c309 Mon Sep 17 00:00:00 2001 Message-Id: <990ccd38f0ff916ada8

[Qemu-devel] KVM call agenda for October 18

2011-10-17 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

[Qemu-devel] Patch for ui/cocoa.m

2011-10-17 Thread Juan Pineda
Hello, This is my first time submitting a patch, so please let me know if I'm not following the correct protocol. Under OSX Lion the boot volume dialog is not closed and it permanently obscures the emulator window since under Lion the dialog cannot be repositioned. The fix adds only to add a s

Re: [Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-17 Thread Stuart Brady
On Mon, Oct 17, 2011 at 10:01:25PM +0200, Stefan Weil wrote: > > The patch also slightly cleans the g_malloc0 statement which was > touched by that change (no type cast, easier code review). [...] > -s = (GDBRegisterState *)g_malloc0(sizeof(GDBRegisterState)); [...] > +s = g_malloc0(sizeof

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Jan Kiszka
On 2011-10-17 14:14, Avi Kivity wrote: > Can you post a git tree? It will be easier for me to understand the > whole thing this way. Pushed current state to git://git.kiszka.org/qemu-kvm.git queues/msi Jan signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Jan Kiszka
On 2011-10-17 14:50, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 02:07:10PM +0200, Jan Kiszka wrote: >> On 2011-10-17 13:57, Michael S. Tsirkin wrote: >>> On Mon, Oct 17, 2011 at 01:23:46PM +0200, Jan Kiszka wrote: On 2011-10-17 13:10, Michael S. Tsirkin wrote: > On Mon, Oct 17, 20

[Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-17 Thread Alexander Graf
We have several targets in the PPC tree now that basically require libfdt to function properly, namely the pseries and the e500 targets. This dependency will rather increase than decrease in the future, so I want to make sure that people building shiny new 1.0 actually have libfdt installed to get

[Qemu-devel] [PATCH] PPC: Disable non-440 CPUs for ppcemb target

2011-10-17 Thread Alexander Graf
The sole reason we have the ppcemb target is to support MMUs that have less than the usual 4k possible page size. There are very few of these chips and I don't want to add additional QA and testing burden to everyone to ensure that code still works when TARGET_PAGE_SIZE is not 4k. So this patch di

[Qemu-devel] [PATCH] PPC: Bump qemu-system-ppc to 64-bit physical address space

2011-10-17 Thread Alexander Graf
Some 32-bit PPC CPUs can use up to 36 bit of physicall address space. Treat them accordingly in the qemu-system-ppc binary type. Signed-off-by: Alexander Graf --- configure|2 +- target-ppc/cpu.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/co

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Jan Kiszka
On 2011-10-17 15:43, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:27:45AM +0200, Jan Kiszka wrote: >> diff --git a/hw/msi.c b/hw/msi.c >> index 3c7ebc3..9055155 100644 >> --- a/hw/msi.c >> +++ b/hw/msi.c >> @@ -40,6 +40,14 @@ >> /* Flag for interrupt controller to declare MSI/MSI-X suppo

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-17 Thread Kai Tietz
2011/10/18 Bob Breuer : > Kai Tietz wrote: >> 2011/10/17 Bob Breuer : >>> Richard Henderson wrote: On 10/17/2011 07:09 AM, Bob Breuer wrote: > I don't think this is a free/g_free issue.  If I use the following > patch, then I at least get the openbios messages: > > diff --git a

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-17 Thread Bob Breuer
Kai Tietz wrote: > 2011/10/17 Bob Breuer : >> Richard Henderson wrote: >>> On 10/17/2011 07:09 AM, Bob Breuer wrote: I don't think this is a free/g_free issue. If I use the following patch, then I at least get the openbios messages: diff --git a/cpu-exec.c b/cpu-exec.c ind

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-17 Thread Peter Maydell
> 0.15.0 fails for me. Hmm. Works for me: pm215@canth:/tmp$ wget http://wiki.qemu.org/download/qemu-0.15.0.tar.gz [...] pm215@canth:/tmp$ tar xzf qemu-0.15.0.tar.gz pm215@canth:/tmp$ cd qemu-0.15.0/ pm215@canth:/tmp/qemu-0.15.0$ ./configure --target-list=arm-linux-user && make -j4 [...] pm215@c

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-17 Thread Kai Tietz
2011/10/17 Bob Breuer : > Richard Henderson wrote: >> On 10/17/2011 07:09 AM, Bob Breuer wrote: >>> I don't think this is a free/g_free issue.  If I use the following >>> patch, then I at least get the openbios messages: >>> >>> diff --git a/cpu-exec.c b/cpu-exec.c >>> index a9fa608..dfbd6ea 100644

Re: [Qemu-devel] [PATCH 4/4] qapi-types.py: Drop unused variable

2011-10-17 Thread Michael Roth
Reviewed-by: Michael Roth On Mon, 17 Oct 2011 13:29:37 -0200, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > scripts/qapi-types.py |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py > index 4a2ddc4..28d

Re: [Qemu-devel] [PATCH 3/4] qapi-types.py: Fail gracefully if out dir is not specified

2011-10-17 Thread Michael Roth
On Mon, 17 Oct 2011 13:29:36 -0200, Luiz Capitulino wrote: > Otherwise we get: > > Traceback (most recent call last): > File "./scripts/qapi-types.py", line 183, in > os.makedirs(output_dir) > File "/usr/lib64/python2.7/os.py", line 157, in makedirs > mkdir(nam

Re: [Qemu-devel] [PATCH 2/4] qapi-types.py: Don't build paths by hand

2011-10-17 Thread Michael Roth
Reviewed-by: Michael Roth On Mon, 17 Oct 2011 13:29:35 -0200, Luiz Capitulino wrote: > Use os.path.join() instead. > > Signed-off-by: Luiz Capitulino > --- > scripts/qapi-types.py |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/qapi-types.py b/scri

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-17 Thread Bob Breuer
Richard Henderson wrote: > On 10/17/2011 07:09 AM, Bob Breuer wrote: >> I don't think this is a free/g_free issue. If I use the following >> patch, then I at least get the openbios messages: >> >> diff --git a/cpu-exec.c b/cpu-exec.c >> index a9fa608..dfbd6ea 100644 >> --- a/cpu-exec.c >> +++ b/cp

Re: [Qemu-devel] [PATCH 1/4] qapi-types.py: Add a main() like function

2011-10-17 Thread Michael Roth
Reviewed-by: Michael Roth On Mon, 17 Oct 2011 13:29:34 -0200, Luiz Capitulino wrote: > Makes it easier to read the code. > > Signed-off-by: Luiz Capitulino > --- > scripts/qapi-types.py | 230 > 1 files changed, 115 insertions(+), 115 deletio

Re: [Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

2011-10-17 Thread Jan Kiszka
On 2011-10-17 14:39, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 01:45:04PM +0200, Jan Kiszka wrote: >> On 2011-10-17 13:40, Michael S. Tsirkin wrote: >>> On Mon, Oct 17, 2011 at 11:27:57AM +0200, Jan Kiszka wrote: MSI config notifiers are supposed to be triggered on every relevant >>>

Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API

2011-10-17 Thread Avi Kivity
On 10/17/2011 09:13 PM, Blue Swirl wrote: > > > > -ret = cpu_physical_memory_get_dirty(page, VGA_DIRTY_FLAG); > > +ret = memory_region_get_dirty(&s->vram_mem, page, DIRTY_MEMORY_VGA); > > for (off = 0; off < TARGET_PAGE_SIZE * 4; off += TARGET_PAGE_SIZE) { > > -ret |= cpu_physic

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Avi Kivity
On 10/17/2011 07:46 PM, Stefan Weil wrote: > > So let's start. For any of my contributions, I agree to GPL v2 or later. > Later generations should have the possibility to replace GPL v2 by > something which matches future requirements. I expect Red Hat contributions can be relicensed to v2+ as wel

Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main loop

2011-10-17 Thread Paolo Bonzini
On 10/17/2011 10:11 PM, Anthony Liguori wrote: Leftover from RFC. Right now, this is just a chainsaw cleanup. However, Kevin has plans to use the main loop everywhere (making qemu-io and qemu-img one huge coroutine). Can you add something to docs that explains how to use the new main loop? Ye

Re: [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-17 Thread Alexey Starikovskiy
0.15.0 fails for me. On Mon, Oct 17, 2011 at 10:06 PM, Peter Maydell wrote: > Current git master works for me on that test program without your patch: > cam-vm-266:maverick:qemu$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe > cam-vm-266:maverick:qemu$ echo $? > 0 > > (I tested on qemu-0.14 ju

[Qemu-devel] [PATCH] device_tree: Fix potential memory leak

2011-10-17 Thread Stefan Weil
cppcheck error report: device_tree.c:156: error: Memory leak: dupname Signed-off-by: Stefan Weil --- device_tree.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/device_tree.c b/device_tree.c index dc69232..86a694c 100644 --- a/device_tree.c +++ b/device_tree.c @@ -153

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-17 Thread Richard Henderson
On 10/17/2011 12:14 PM, Blue Swirl wrote: > IIRC buggy versions of alloca() could also fail without a frame pointer. (1) GCC always uses a frame pointer for alloca, (2) Unless you do -fno-builtin-alloca, we always implement it inline. r~

Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main loop

2011-10-17 Thread Anthony Liguori
On 10/17/2011 03:09 PM, Paolo Bonzini wrote: On 10/17/2011 09:56 PM, Anthony Liguori wrote: The series already starts using the refactored main loop in qemu-nbd. What patch does this? I don't see any changes to qemu-nbd in this series. Leftover from RFC. Right now, this is just a chainsaw cl

Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main loop

2011-10-17 Thread Paolo Bonzini
On 10/17/2011 09:56 PM, Anthony Liguori wrote: The series already starts using the refactored main loop in qemu-nbd. What patch does this? I don't see any changes to qemu-nbd in this series. Leftover from RFC. Right now, this is just a chainsaw cleanup. However, Kevin has plans to use the

[Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-17 Thread Stefan Weil
cppcheck report: gdbstub.c:1781: error: Memory leak: s Rearranging of the code avoids the leak. The patch also slightly cleans the g_malloc0 statement which was touched by that change (no type cast, easier code review). Signed-off-by: Stefan Weil --- gdbstub.c | 14 -- 1 files

Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main loop

2011-10-17 Thread Anthony Liguori
On 10/11/2011 06:35 AM, Paolo Bonzini wrote: This patch series makes the QEMU main loop usable out of the executable, and especially in tools and possibly unit tests. The series already starts using the refactored main loop in qemu-nbd. What patch does this? I don't see any changes to qemu-nb

Re: [Qemu-devel] [PATCH 04/13] qemu-timer: more clock functions

2011-10-17 Thread Anthony Liguori
On 10/11/2011 06:35 AM, Paolo Bonzini wrote: These will be used when moving icount accounting to cpus.c. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- qemu-timer.c | 25 + qemu-timer.h |3 +++ 2 files changed, 28 i

Re: [Qemu-devel] [PATCH 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-17 Thread Anthony Liguori
On 10/11/2011 06:35 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- qemu-timer.c | 129 -- 1 files changed, 53 insertions(+), 76 deletions(-) diff --git a/qemu-timer

Re: [Qemu-devel] [PATCH 02/13] qemu-timer: remove active_timers array

2011-10-17 Thread Anthony Liguori
On 10/11/2011 06:35 AM, Paolo Bonzini wrote: Embed the list in the QEMUClock instead. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- qemu-timer.c | 59 +++-- 1 files changed, 28 insertions(+),

Re: [Qemu-devel] [PATCH 01/13] remove unused function

2011-10-17 Thread Anthony Liguori
On 10/11/2011 06:35 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/mac_dbdma.c |5 - hw/mac_dbdma.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c index

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Blue Swirl
On Mon, Oct 17, 2011 at 4:51 PM, Anthony Liguori wrote: > On 10/17/2011 11:47 AM, Peter Maydell wrote: >> >> On 17 October 2011 17:39, Andreas Färber  wrote: >>> >>> Am 17.10.2011 13:10, schrieb Paolo Bonzini: Making a list of GPLv2 files would be a start, though. >>> >>> grep -r version

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 09:11:29PM +0200, Jan Kiszka wrote: > On 2011-10-17 14:50, Michael S. Tsirkin wrote: > > On Mon, Oct 17, 2011 at 02:07:10PM +0200, Jan Kiszka wrote: > >> On 2011-10-17 13:57, Michael S. Tsirkin wrote: > >>> On Mon, Oct 17, 2011 at 01:23:46PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Blue Swirl
On Mon, Oct 17, 2011 at 6:29 PM, Anthony Liguori wrote: > On 10/17/2011 01:20 PM, Stefan Weil wrote: >> >> Am 17.10.2011 20:16, schrieb Anthony Liguori: >>> >>> On 10/17/2011 12:58 PM, Andreas Färber wrote: Am 17.10.2011 18:51, schrieb Anthony Liguori: > > Including binutils code

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Blue Swirl
On Mon, Oct 17, 2011 at 5:46 PM, Stefan Weil wrote: > Am 17.10.2011 18:47, schrieb Anthony Liguori: >> >> On 10/17/2011 11:30 AM, Andreas Färber wrote: >>> >>> Am 17.10.2011 16:17, schrieb Anthony Liguori: On 10/17/2011 07:50 AM, Paolo Bonzini wrote: > > On 10/17/2011 02:38 PM, A

Re: [Qemu-devel] [PATCH 2/4] pc: Support system flash memory with pflash

2011-10-17 Thread Jordan Justen
On Mon, Oct 17, 2011 at 12:16, Jordan Justen wrote: > If a pflash image is found, then it is used for the system > firmware image. > > If a pflash image is not initially found, then a read-only > pflash device is created using the -bios filename. > > Signed-off-by: Jordan Justen > Cc: Anthony Lig

[Qemu-devel] [PATCH] hw/9pfs: Fix missing parentheses

2011-10-17 Thread Stefan Weil
cppcheck report: hw/9pfs/virtio-9p.c:2385: style: Boolean result is used in bitwise operation. Clarify expression with parentheses hw/9pfs/virtio-9p.c:2531: style: Boolean result is used in bitwise operation. Clarify expression with parentheses Cc: Aneesh Kumar K.V Signed-off-by: Stefan Weil

[Qemu-devel] [PATCH 4/4] pcflash: Add pc flash to qemu roms

2011-10-17 Thread Jordan Justen
The pflash image is added to the roms using the memory region buffer and rom_add_file_buf_fixed. Signed-off-by: Jordan Justen --- hw/pcflash.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/pcflash.c b/hw/pcflash.c index eece7ec..e28bdb0 100644 --- a/

[Qemu-devel] [PATCH 3/4] loader: Add rom_add_file_buf for adding roms from a buffer

2011-10-17 Thread Jordan Justen
rom_add_file_buf is similar to rom_add_file, except the rom's contents are provided in a buffer. rom_add_file is modified to call rom_add_file_buf after reading the rom's contents from the file. Signed-off-by: Jordan Justen --- hw/loader.c | 71 +++-

[Qemu-devel] [PATCH 2/4] pc: Support system flash memory with pflash

2011-10-17 Thread Jordan Justen
If a pflash image is found, then it is used for the system firmware image. If a pflash image is not initially found, then a read-only pflash device is created using the -bios filename. Signed-off-by: Jordan Justen Cc: Anthony Liguori --- Makefile.target|1 + default-con

[Qemu-devel] [PATCH 1/4] pflash: Support read-only mode

2011-10-17 Thread Jordan Justen
Read-only mode is indicated by bdrv_is_read_only When read-only mode is enabled, no changes will be made to the flash image in memory, and no bdrv_write calls will be made. For pflash_cfi01 (Intel), if the flash is in read-only mode then the status register will signal block erase error or progra

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-17 Thread Blue Swirl
On Mon, Oct 17, 2011 at 5:22 PM, Richard Henderson wrote: > On 10/17/2011 07:09 AM, Bob Breuer wrote: >> I don't think this is a free/g_free issue.  If I use the following >> patch, then I at least get the openbios messages: >> >> diff --git a/cpu-exec.c b/cpu-exec.c >> index a9fa608..dfbd6ea 1006

Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API

2011-10-17 Thread Blue Swirl
On Mon, Oct 17, 2011 at 2:02 PM, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- >  hw/tcx.c |  152 ++--- >  1 files changed, 85 insertions(+), 67 deletions(-) > > diff --git a/hw/tcx.c b/hw/tcx.c > index 309600d..cd24100 100644 > --- a/

Re: [Qemu-devel] [PATCH v3 1/4] vga: make PCI devices optional

2011-10-17 Thread Blue Swirl
On Mon, Oct 17, 2011 at 7:17 AM, Jan Kiszka wrote: > On 2011-10-16 23:21, Blue Swirl wrote: >> Improve VGA selection logic, push check for device availabilty to vl.c. >> Make PCI VGA devices optional. >> >> Signed-off-by: Blue Swirl >> --- >>  hw/cirrus_vga.c |    5 - >>  hw/pc.c         |  

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Anthony Liguori
On 10/17/2011 01:34 PM, Peter Maydell wrote: On 17 October 2011 19:29, Anthony Liguori wrote: Likewise, we could add tracing to translate.c to achieve the same affect as in_asm. Having the code you're trying to debug be also doing the printing out of the disassembly seems like a recipe for co

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Peter Maydell
On 17 October 2011 19:29, Anthony Liguori wrote: > Likewise, we could add tracing to translate.c to achieve the same affect as > in_asm. Having the code you're trying to debug be also doing the printing out of the disassembly seems like a recipe for confusing yourself (because you lose the indepe

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Anthony Liguori
On 10/17/2011 01:20 PM, Stefan Weil wrote: Am 17.10.2011 20:16, schrieb Anthony Liguori: On 10/17/2011 12:58 PM, Andreas Färber wrote: Am 17.10.2011 18:51, schrieb Anthony Liguori: Including binutils code is just a bad idea. Do you see a real alternative? Would it be possible to pipe machine

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-17 Thread Peter Maydell
Current git master works for me on that test program without your patch: cam-vm-266:maverick:qemu$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe cam-vm-266:maverick:qemu$ echo $? 0 (I tested on qemu-0.14 just to confirm that I'm running the test program correctly, and that indeed fails as I wo

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Stefan Weil
Am 17.10.2011 20:16, schrieb Anthony Liguori: On 10/17/2011 12:58 PM, Andreas Färber wrote: Am 17.10.2011 18:51, schrieb Anthony Liguori: Including binutils code is just a bad idea. Do you see a real alternative? Would it be possible to pipe machine code from QEMU into an external disassemble

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Peter Maydell
On 17 October 2011 19:16, Anthony Liguori wrote: > On 10/17/2011 12:58 PM, Andreas Färber wrote: >> Do you see a real alternative? Would it be possible to pipe machine code >> from QEMU into an external disassembler? > > Sure.  This is only used in the monitor for interactive debugging, right? Al

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Anthony Liguori
On 10/17/2011 12:58 PM, Andreas Färber wrote: Am 17.10.2011 18:51, schrieb Anthony Liguori: Including binutils code is just a bad idea. Do you see a real alternative? Would it be possible to pipe machine code from QEMU into an external disassembler? Sure. This is only used in the monitor fo

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Andreas Färber
Am 17.10.2011 18:51, schrieb Anthony Liguori: > Including binutils code is just a bad idea. Do you see a real alternative? Would it be possible to pipe machine code from QEMU into an external disassembler? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Andreas Färber
Am 17.10.2011 18:47, schrieb Anthony Liguori: > It's not something that any one person can really change. It would > require a very large effort. To give you an idea of the scope, I ran > the following command: > > $ grep GPL *.c hw/*.c | grep -v 'or later' | cut -f1 -d: | sort -u | > while rea

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Stefan Weil
Am 17.10.2011 18:47, schrieb Anthony Liguori: On 10/17/2011 11:30 AM, Andreas Färber wrote: Am 17.10.2011 16:17, schrieb Anthony Liguori: On 10/17/2011 07:50 AM, Paolo Bonzini wrote: On 10/17/2011 02:38 PM, Anthony Liguori wrote: Could we please draft some policy on this? This is not a GDB is

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-17 Thread Alexey Starikovskiy
MVNS with immediate fails in attached test program at 0x82c0 location. My patch fixes that. ** Attachment added: "failed test for MVNS.IMM opcode" https://bugs.launchpad.net/qemu/+bug/874038/+attachment/2554573/+files/mvns_imm.exe -- You received this bug notification because you are a membe

Re: [Qemu-devel] [SeaBIOS] [PATCH 0/5] More pci init simplifications

2011-10-17 Thread Isaku Yamahata
On Mon, Oct 17, 2011 at 11:57:09AM +0200, Gerd Hoffmann wrote: > On 10/15/11 18:25, Kevin O'Connor wrote: >> This main patch in this series is patch 2 - replacement of the >> recursive scan with a linear scan. The other patches are just >> cosmetic changes. > > Looks sane at a quick glance. > >> G

[Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-17 Thread Richard Henderson
On 10/17/2011 07:09 AM, Bob Breuer wrote: > I don't think this is a free/g_free issue. If I use the following > patch, then I at least get the openbios messages: > > diff --git a/cpu-exec.c b/cpu-exec.c > index a9fa608..dfbd6ea 100644 > --- a/cpu-exec.c > +++ b/cpu-exec.c > @@ -180,6 +180,7 @@ st

Re: [Qemu-devel] [PATCH 09/36] migration: don't "write" when migration is not active

2011-10-17 Thread Juan Quintela
Anthony Liguori wrote: > On 10/11/2011 05:00 AM, Juan Quintela wrote: >> If migration is not active, just ignore writes. >> >> Signed-off-by: Juan Quintela >> --- >> migration.c |4 >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/migration.c b/migration.c >> inde

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Andreas Färber
Am 17.10.2011 18:47, schrieb Peter Maydell: > On 17 October 2011 17:39, Andreas Färber wrote: >> Am 17.10.2011 13:10, schrieb Paolo Bonzini: >>> Making a list of GPLv2 files would be a start, though. >> >> grep -r version *.c comes up with these: > > Your rune needs tweaking -- it isn't looking i

Re: [Qemu-devel] [PATCH 06/36] migration: If there is one error, it makes no sense to continue

2011-10-17 Thread Juan Quintela
Anthony Liguori wrote: > On 10/11/2011 05:00 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > The original intention of returning zero was to force a quick finish > of the migration. > > I think this code makes things more brittle because now if you're not > doing error checking in the

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Anthony Liguori
On 10/17/2011 11:47 AM, Peter Maydell wrote: On 17 October 2011 17:39, Andreas Färber wrote: Am 17.10.2011 13:10, schrieb Paolo Bonzini: Making a list of GPLv2 files would be a start, though. grep -r version *.c comes up with these: Your rune needs tweaking -- it isn't looking inside any s

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Peter Maydell
On 17 October 2011 17:39, Andreas Färber wrote: > Am 17.10.2011 13:10, schrieb Paolo Bonzini: >> Making a list of GPLv2 files would be a start, though. > > grep -r version *.c comes up with these: Your rune needs tweaking -- it isn't looking inside any subdirectories. -- PMM

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Andreas Färber
Am 17.10.2011 13:10, schrieb Paolo Bonzini: > Making a list of GPLv2 files would be a start, though. grep -r version *.c comes up with these: v2 only: aio.c block-migration.c buffered_file.c compatfd.c error.c iov.c kvm-all.c memory.c migration.c migration-exec.c migration-fd.c migration-tcp.c mi

[Qemu-devel] [PATCH 03/18] pxa2xx: convert to memory API (part I)

2011-10-17 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pxa.h|1 + hw/pxa2xx.c | 116 -- 2 files changed, 49 insertions(+), 68 deletions(-) diff --git a/hw/pxa.h b/hw/pxa.h index 1204165..3fb070f 100644 --- a/hw/pxa.h +++ b/hw/pxa.h @@ -151,6 +151,7 @@ t

[Qemu-devel] [RFC 2/6] block: add bdrv_set_copy_on_read()

2011-10-17 Thread Stefan Hajnoczi
The bdrv_set_copy_on_read() function can be used to programmatically enable or disable copy-on-read for a block device. Later patches add the actual copy-on-read logic. Signed-off-by: Stefan Hajnoczi --- block.c | 17 + block.h |3 +++ block_int.h |1 + 3 files

[Qemu-devel] [PATCH 15/18] sun4u: convert to memory API

2011-10-17 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/sun4u.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index 96fc3d0..eaaefe3 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -574,6 +574,11 @@ static void pci_ebus_register(void) device_init(p

[Qemu-devel] [PATCH 4/7] stellaris: convert sys to memory API

2011-10-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/stellaris.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 2bf1c23..6f9146a 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -327,6 +327,7 @@ static int stellaris_gpt

[Qemu-devel] [PATCH 5/7] stellaris: convert i2c to memory API

2011-10-17 Thread Benoît Canet
Signed-off-by: Benoit Canet Reviewed-by: Peter Maydell --- hw/stellaris.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 6f9146a..f55b1f3 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -687,6 +687,7

[Qemu-devel] [RFC 4/6] block: request overlap detection

2011-10-17 Thread Stefan Hajnoczi
Detect overlapping requests and remember to align to cluster boundaries if the image format uses them. This assumes that allocating I/O is performed in cluster granularity - which is true for qcow2, qed, etc. Signed-off-by: Stefan Hajnoczi --- block.c | 39

Re: [Qemu-devel] GPLv3 troubles

2011-10-17 Thread Andreas Färber
Am 17.10.2011 16:17, schrieb Anthony Liguori: > On 10/17/2011 07:50 AM, Paolo Bonzini wrote: >> On 10/17/2011 02:38 PM, Anthony Liguori wrote: Could we please draft some policy on this? This is not a GDB issue, it's very general. Whether we like it or not, there is GPLv3-licensed cod

[Qemu-devel] [PATCH 6/7] stellaris: convert adc to memory API

2011-10-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/stellaris.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index f55b1f3..533d9c1 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -892,6 +892,7 @@ static int stellaris_i

[Qemu-devel] [RFC 1/6] block: add request tracking

2011-10-17 Thread Stefan Hajnoczi
The block layer does not know about pending requests. This information is necessary for copy-on-read since overlapping requests must be serialized to prevent races that corrupt the image. Add a simple mechanism to enable/disable request tracking. By default request tracking is disabled. The Blo

[Qemu-devel] [PATCH 3/7] integratorcp: convert control to memory API

2011-10-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/integratorcp.c | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index c7d6596..7f79560 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -392,7 +392,9 @@ static

[Qemu-devel] [PATCH 2/7] integratorcp: convert icp pic to memory API

2011-10-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hw/integratorcp.c | 27 ++- 1 files changed, 10 insertions(+), 17 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 0dc84c4..c7d6596 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@ -279,6 +279,7 @@ static int

[Qemu-devel] [RFC 0/6] block: generic copy-on-read

2011-10-17 Thread Stefan Hajnoczi
The new -drive copy-on-read=on|off feature populates the image file with data from the backing file on read. This is useful when accessing images backed over a slow medium (e.g. http over internet). All read data will be stored in the local image file so it does not need to be fetched again in th

[Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-17 Thread Lai Jiangshan
On 10/17/2011 05:49 PM, Avi Kivity wrote: > On 10/17/2011 11:40 AM, Lai Jiangshan wrote: >>> >>> LINT1 may have been programmed as a level -triggered interrupt instead >>> of edge triggered (NMI or interrupt). We can use the ioctl argument for >>> the level (and pressing the NMI button needs

Re: [Qemu-devel] [RFC][PATCH 00/45] qemu-kvm: MSI layer rework for in-kernel irqchip support

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 11:27:34AM +0200, Jan Kiszka wrote: > As previously indicated, I was working for quite a while on a major > refactoring of the MSI "additions" we have in qemu-kvm to support > in-kernel irqchip, vhost and device assignment. This is now the outcome. > > I'm quite happy with

[Qemu-devel] [PATCH 7/7] stellaris: convert gptm to memory API

2011-10-17 Thread Benoît Canet
Signed-off-by: Benoit Canet Reviewed-by: Peter Maydell --- hw/stellaris.c | 29 - 1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 533d9c1..2ab7ec7 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -45,6 +45,7

Re: [Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

2011-10-17 Thread Stefan Hajnoczi
On Mon, Oct 17, 2011 at 11:26 AM, Kevin Wolf wrote: > Am 26.09.2011 09:24, schrieb Zhi Yong Wu: >> On Sat, Sep 24, 2011 at 12:19 AM, Kevin Wolf wrote: >>> Am 08.09.2011 12:11, schrieb Zhi Yong Wu: Note:      1.) When bps/iops limits are specified to a small value such as 511 bytes

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 11:28:02AM +0200, Jan Kiszka wrote: > This optimization was only required to keep KVM route usage low. Now > that we solve that problem via lazy updates, we can drop the field. We > still need interfaces to clear pending vectors, though (and we have to > make use of them mor

[Qemu-devel] [RFC 6/6] block: add -drive copy-on-read=on|off

2011-10-17 Thread Stefan Hajnoczi
This patch adds the -drive copy-on-read=on|off command-line option: copy-on-read=on|off copy-on-read is "on" or "off" and enables whether to copy read backing file sectors into the image file. Copy-on-read avoids accessing the same backing file sectors repeatedly and is useful when the ba

  1   2   3   4   >