Sufficiently recent PAPR specifications define properties "ibm,vmx"
and "ibm,dfp" on the CPU node which advertise whether the VMX vector
extensions (or the later VSX version) and/or the Decimal Floating
Point operations from IBM's recent POWER CPUs are available.
Currently we do not put these in t
From: Jan Kiszka
This prevents lockups when trying to allocate PCI resources on an
ISA-only system like QEMU can emulate.
Signed-off-by: Jan Kiszka
---
src/pci.c | 14 +-
src/pci.h |3 ++-
src/pciinit.c |7 +--
3 files changed, 20 insertions(+), 4 deletions(-)
On Wed, Sep 21, 2011 at 11:14 AM, Zhi Yong Wu wrote:
> On Tue, Sep 20, 2011 at 8:34 PM, Marcelo Tosatti wrote:
>> On Mon, Sep 19, 2011 at 05:55:41PM +0800, Zhi Yong Wu wrote:
>>> On Wed, Sep 14, 2011 at 6:50 PM, Marcelo Tosatti
>>> wrote:
>>> > On Tue, Sep 13, 2011 at 11:09:46AM +0800, Zhi Yong
I am still not able to compile this with these changes.
On Tue, Sep 20, 2011 at 8:34 PM, Marcelo Tosatti wrote:
> On Mon, Sep 19, 2011 at 05:55:41PM +0800, Zhi Yong Wu wrote:
>> On Wed, Sep 14, 2011 at 6:50 PM, Marcelo Tosatti wrote:
>> > On Tue, Sep 13, 2011 at 11:09:46AM +0800, Zhi Yong Wu wrote:
>> >> On Fri, Sep 9, 2011 at 10:44 PM, Marcelo Tosatt
Allow to resize images that reside on host devices up to the available
space. This allows to grow images after resizing the device manually or
vice versa.
Signed-off-by: Christoph Hellwig
Index: qemu/block/raw-posix.c
===
--- qemu.
On Tue, Sep 20, 2011 at 03:36:24PM -0700, Richard Henderson wrote:
> This reverts commit 46f08792bb4a69ab8aab897c174d82b006026140.
>
> This was not supposed to be applied to mainline.
Yes, I've applied it thanks.
Cheers
The Buildbot has detected a new failure on builder default_mingw32 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/31
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: kraxel_rhel61
Build Reason:
The Buildbot has detected a new failure on builder default_openbsd_current
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/builds/37
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: brad_openbsd_
The Buildbot has detected a new failure on builder default_openbsd_4.9 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_openbsd_4.9/builds/31
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: kraxel_openbsd49
Bui
This reverts commit 46f08792bb4a69ab8aab897c174d82b006026140.
This was not supposed to be applied to mainline.
Signed-off-by: Richard Henderson
---
configure |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index ad924c4..414317a 100755
--- a/config
> > Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> > guest implementation (target-arm) and the ARM dev boards (integratorcp,
> > realview, stellaris, versatilepb).
> >
> > Signed-off-by: Peter Maydell
>
> Acked-by: Anthony Liguori
>
> Paul, speak now or forever hold your pea
Jan Kiszka a écrit :
On 2011-09-19 20:49, Hervé Poussineau wrote:
Jan Kiszka a écrit :
On 2011-09-18 18:04, Hervé Poussineau wrote:
Signed-off-by: Hervé Poussineau
---
hw/pc_piix.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index da6
On 09/20/2011 11:40 AM, Michael S. Tsirkin wrote:
Pull from the temp tree at github.
The following changes since commit 530889ff95659d8fea81eb556e5706387fdddfa7:
sun4u: don't set up isa_mem_base (2011-09-18 12:00:19 +)
Pulled. Thanks.
Regards,
Anthony Liguori
are available in the
On 09/20/2011 06:11 AM, Kevin Wolf wrote:
The following changes since commit 530889ff95659d8fea81eb556e5706387fdddfa7:
sun4u: don't set up isa_mem_base (2011-09-18 12:00:19 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Pulled. Thanks.
Regar
On 09/15/2011 05:21 PM, Jan Kiszka wrote:
The following changes since commit 44520db10b1b92f272348ab7028e7afc68ac3edf:
Gdbstub: Fix back-trace on SPARC32 (2011-09-10 18:12:35 +)
are available in the git repository at:
git://git.kiszka.org/qemu.git queues/slirp
Pulled. Thanks.
Rega
On 09/15/2011 03:05 PM, Luiz Capitulino wrote:
Anthony,
This is my latest pull of the RunState series with a build problem fixed
and yet another rebase (solved automatically by git).
The changes (since ef4f97cba2a354656b00eb8659bf61ab2321fa4e) are available
in the following repository:
Pulled
On 09/20/2011 02:03 PM, Eric Blake wrote:
On 09/20/2011 12:52 PM, Anthony Liguori wrote:
On 09/20/2011 01:01 PM, Eric Blake wrote:
On 09/20/2011 11:39 AM, Jiri Denemark wrote:
The commit that prevents disk corruption on domain shutdown
(96fc4784177ecb70357518fa863442455e45ad0e) causes regressi
On 09/20/2011 12:19 PM, Alan Amaral wrote:
> QEMU emulator version 0.14.50, Copyright (c) 2003-2008 Fabrice Bellard
> You are correct, it's not hardcoded to 4. However, when it's allocated the
> number of elements IS 4. Also,
> there's a comment just above pci_set_irq which says:
>
> /* 0 <= i
On 2011-09-20 21:19, Alan Amaral wrote:
> QEMU emulator version 0.14.50, Copyright (c) 2003-2008 Fabrice Bellard
(That's an ambitious development version.)
>
> You are correct, it's not hardcoded to 4. However, when it's allocated the
> number of elements IS 4. Also,
> there's a comment just
QEMU emulator version 0.14.50, Copyright (c) 2003-2008 Fabrice Bellard
You are correct, it's not hardcoded to 4. However, when it's allocated the
number of elements IS 4. Also,
there's a comment just above pci_set_irq which says:
/* 0 <= irq_num <= 3. level must be 0 or 1 */
static void pci_se
Signals the reset of the state a vCPU (CPUState structure).
Signed-off-by: Lluís Vilanova
---
target-arm/helper.c |3 +++
target-cris/translate.c |3 +++
target-i386/helper.c |3 +++
target-lm32/helper.c |3 +++
target-m68k/helper.c |
Signals the creation of a new vCPU (CPUState structure).
Signed-off-by: Lluís Vilanova
---
cpus.c|1 +
qemu-common.h |4 +++-
trace-events |7 +++
3 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/cpus.c b/cpus.c
index 54c188c..ab699bb 100644
--- a/cpus.c
+
The events 'qemu_malloc' and 'qemu_free' used in the examples no longer exist,
so use 'qemu_vmalloc' and 'qemu_vfree' instead.
Signed-off-by: Lluís Vilanova
---
docs/tracing.txt | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/docs/tracing.txt b/docs/tracin
On 09/20/2011 12:52 PM, Anthony Liguori wrote:
On 09/20/2011 01:01 PM, Eric Blake wrote:
On 09/20/2011 11:39 AM, Jiri Denemark wrote:
The commit that prevents disk corruption on domain shutdown
(96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU
0.14.* and 0.15.* because of a
On 2011-09-20 20:22, Paolo Bonzini wrote:
> On 09/20/2011 06:53 PM, Jan Kiszka wrote:
>> First user will be posix compat aio.
>>
>> Signed-off-by: Jan Kiszka
>
> I'm pretty sure the win32 version is not thread-safe,
Yeah, I would even say it's completely broken. Was a naive hack.
> but posix com
On 09/20/2011 10:24 AM, Alan Amaral wrote:
> I'm not on this mailing list, so please CC me on any replies. Thanks.
>
> I ran qemu with valgrind last night and found an error in the pci emulation
> code, which may,
> or may not, be biting us. So far the effects seem benign, although there
> ex
On 09/20/2011 01:01 PM, Eric Blake wrote:
On 09/20/2011 11:39 AM, Jiri Denemark wrote:
The commit that prevents disk corruption on domain shutdown
(96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU
0.14.* and 0.15.* because of a regression bug in QEMU that was fixed
only rece
On 09/20/2011 11:39 AM, Jiri Denemark wrote:
The commit that prevents disk corruption on domain shutdown
(96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU
0.14.* and 0.15.* because of a regression bug in QEMU that was fixed
only recently in QEMU git. With affected QEMU binari
Peter Maydell wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell
Acked-by: Juan Quintela
I'm not on this mailing list, so please CC me on any replies. Thanks.
I ran qemu with valgrind last night and found an error in the pci emulation code, which may,
or may not, be biting us. So far the effects seem benign, although there exists the possibility
of trashing random memory.
In
On 09/20/2011 06:53 PM, Jan Kiszka wrote:
First user will be posix compat aio.
Signed-off-by: Jan Kiszka
I'm pretty sure the win32 version is not thread-safe, but posix compat
aio is currently POSIX only. Just leave it out.
Paolo
On 09/20/2011 12:06 PM, Dave Allan wrote:
On Tue, Sep 20, 2011 at 07:39:15PM +0200, Jiri Denemark wrote:
The commit that prevents disk corruption on domain shutdown
(96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU
0.14.* and 0.15.* because of a regression bug in QEMU that w
On Mon, Sep 19, 2011 at 03:05:47PM +0100, Stefan Hajnoczi wrote:
> On Mon, Sep 19, 2011 at 12:54 PM, Frediano Ziglio wrote:
> > @@ -547,7 +549,7 @@ static int posix_aio_flush(void *opaque)
> >
> > ?static PosixAioState *posix_aio_state;
> >
> > -static void aio_signal_handler(int signum)
> > +stat
Using the error management of QemuMutex allows to simplify the code.
CC: malc
CC: Andreas Färber
Signed-off-by: Jan Kiszka
---
audio/coreaudio.c | 56 +++-
1 files changed, 8 insertions(+), 48 deletions(-)
diff --git a/audio/coreaudio.c b/audi
Fix a bug in X86_64 dynamic translation in push_T1() -- emits a push
for the wrong temporary.
Signed-off-by: Ivan Ganev
---
diff -Naur qemu-0.15.0-org/target-i386/translate.c
qemu-0.15.0-mod/target-i386/translate.c
--- qemu-0.15.0-org/target-i386/translate.c 2011-08-08
11:28:42.0 -070
On 09/20/2011 10:18 AM, Peter Maydell wrote:
Add myself as co-maintainer alongside Paul Brook for the TCG ARM
guest implementation (target-arm) and the ARM dev boards (integratorcp,
realview, stellaris, versatilepb).
Signed-off-by: Peter Maydell
Acked-by: Anthony Liguori
Paul, speak now or f
Although there is nothing to wrap for non-POSIX here, redirecting thread
and synchronization services to our core simplifies managements jobs
like scheduling parameter adjustment. It also frees compat AIO from some
duplicate code (/wrt qemu-thread).
CC: Kevin Wolf
Signed-off-by: Jan Kiszka
---
This adds two missing features to our QEMU threading and locking
abstractions, qemu_thread_join and qemu_cond_timedwait, and then
converts compat AIO, compatfd, and several audio subsystems. This not
only saves a few lines of code, it also allows to apply certain thread
and lock parameters centrall
First user will be posix compat aio.
Signed-off-by: Jan Kiszka
---
qemu-thread-posix.c | 22 ++
qemu-thread-win32.c | 16 +++-
qemu-thread.h |2 ++
3 files changed, 39 insertions(+), 1 deletions(-)
diff --git a/qemu-thread-posix.c b/qemu-thread-posi
On 20 September 2011 17:47, Peter Maydell wrote:
> On 18 September 2011 15:15, Avi Kivity wrote:
>> Batch 7 has some issues due to the ISA conversion, so I reordered some
>> patches and am posting this for your review and testing. It should be
>> straightforward but this stuff never is.
>>
>> Al
This both simplifies error handling and enables central management of
threads and locks.
CC: malc
Signed-off-by: Jan Kiszka
---
audio/audio_pt_int.c | 167 ++---
audio/audio_pt_int.h | 45 ++
audio/esdaudio.c | 92
Allow to control if a QEMU thread is created joinable or not. Make it
not joinable by default to avoid that we keep the associated resources
around when terminating a thread without joining it (what we couldn't do
so far for obvious reasons).
The audio subsystem will need the join feature when con
qemu_thread_create already does signal blocking and detaching for us.
Signed-off-by: Jan Kiszka
---
compatfd.c | 16 +++-
1 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/compatfd.c b/compatfd.c
index 31654c6..5431e4b 100644
--- a/compatfd.c
+++ b/compatfd.c
@@ -12,1
On Tue, Sep 20, 2011 at 04:18:46PM +0100, Peter Maydell wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell
Acked-by: Edgar E. Igl
On Tue, Sep 20, 2011 at 11:22:06AM +0100, Peter Maydell wrote:
> Signed-off-by: Peter Maydell
> ---
> (1) I've put this in the 'Devices' part of the MAINTAINERS file
> because OMAP isn't a specific machine; seemed the best fit
> (2) I'll put together a pullreq with this and the other omap
> patche
On 18 September 2011 15:15, Avi Kivity wrote:
> Batch 7 has some issues due to the ISA conversion, so I reordered some
> patches and am posting this for your review and testing. It should be
> straightforward but this stuff never is.
>
> Also available on git://github.com/avikivity/qemu.git memor
Pull from the temp tree at github.
The following changes since commit 530889ff95659d8fea81eb556e5706387fdddfa7:
sun4u: don't set up isa_mem_base (2011-09-18 12:00:19 +)
are available in the git repository at:
git://github.com/mstsirkin/qemu.git for_anthony
Jan Kiszka (2):
pci: Rem
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> 2011/9/20 Mathieu Desnoyers :
> > * Lluís Vilanova (vilan...@ac.upc.edu) wrote:
> >> Stefan Hajnoczi writes:
> >>
> >> > On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> >> >> Signed-off-by: Lluís Vilanova
> >> >> ---
> >> >> trace-e
* Lluís Vilanova (vilan...@ac.upc.edu) wrote:
>
> I don't know about the portability requirements in UST, but if supporting only
> gcc is an option, you can simply use this line in the macro:
>
> void *__tp_cb_data __attribute__((unused));
>
Done. See commit 34dca3cc6e0b230c98
A small refactoring of the MODE SENSE implementation in scsi-disk.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c | 25 +
1 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 624996b..0c47a39 100644
--- a/hw/scsi-disk.c
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 48abe49..534baa2 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -230,6 +230,9 @@ static int scsi_handle_rw_error(SCSIDiskReq *r, in
The page is not anymore in MMC, but at least keep the values sane.
Signed-off-by: Paolo Bonzini
---
hw/ide/atapi.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 347c38d..10f161f 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@
As a complement to the previous patch, move definitions for GET EVENT
STATUS NOTIFICATION from the two functions to scsi-defs.h.
The NCR_* constants are just bit values corresponding to the ENC_*
values, with no offsets even, so keep just one copy.
Signed-off-by: Paolo Bonzini
---
hw/ide/atapi.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c | 50 ++
1 files changed, 42 insertions(+), 8 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 33bab8c..d6b5bfe 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -562,6 +562,19 @@ s
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c | 101 +++-
1 files changed, 100 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index d6b5bfe..778332e 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -575,10 +575
Signed-off-by: Juan Quintela
---
migration-exec.c | 10 +-
migration-fd.c | 10 +-
migration-tcp.c | 10 +-
migration-unix.c | 10 +-
migration.c | 14 ++
migration.h | 23 +--
6 files changed, 31 insertions(
The definitions in ide/internal.h are duplicates, since ATAPI commands
actually come from SCSI. Use the ones in scsi-defs.h and move the
missing ones there. Two exceptions:
- MODE_PAGE_WRITE_PARMS conflicts with the "flexible disk geometry"
page in scsi-disk.c. It is unused, so pick the latter.
Reporting media change events via unit attention sense codes requires
a small state machine: first report "NO MEDIUM", then report "MEDIUM MAY
HAVE CHANGED". Unfortunately there is no good hooking point for the
device to notice that its pending unit attention condition has been
reported. This pat
This patch adds a few stub implementations for MMC commands to
scsi-disk, to be filled in later in the series. It also adds to
scsi-defs.h constants for commands implemented by ide/atapi.c,
when missing.
Signed-off-by: Paolo Bonzini
---
hw/scsi-defs.h |3 ++
hw/scsi-disk.c | 63 ++
This adds support for media change notification via the GET EVENT STATUS
NOTIFICATION command, used by Linux versions 2.6.38 and newer.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c | 57 ---
1 files changed, 53 insertions(+), 4 deletions(-
On 09/20/2011 03:24 PM, Juan Quintela wrote:
diff --git a/migration.c b/migration.c
index c56d29c..7f8928a 100644
--- a/migration.c
+++ b/migration.c
@@ -312,6 +312,9 @@ void migrate_fd_put_notify(void *opaque)
qemu_set_fd_handler2(s->fd, NULL, NULL, NULL, NULL);
qemu_file_put_notif
On 09/20/2011 03:24 PM, Juan Quintela wrote:
If we have one error while migrating, and then we issuse a
"migrate_cancel" command, guest hang. Fix it for flushing only when
migration is in MIG_STATE_ACTIVE. In case of error of cancellation,
don't flush.
We had an infinite loop at buffered_close
This patch adds to scsi-disk the missing mode page 0x01 for both disk
and CD-ROM drives, and mode page 0x0e for CD drives only.
A few offsets were wrong in atapi.c. Also change the 2Ah mode page to
expose DVD media read capabilities in the IDE cdrom. This lets you run
dvd+rw-mediainfo on the vir
This means we can remove the two forward declarations.
Signed-off-by: Juan Quintela
---
migration.c | 188 --
1 files changed, 91 insertions(+), 97 deletions(-)
diff --git a/migration.c b/migration.c
index 306ac4e..642fee1 100644
--- a/mi
This function is a bit different of the others that change the state,
in the sense that if migrate_fd_cleanup() returns an error, it set the
status to error, not completed.
Signed-off-by: Juan Quintela
---
migration.c | 18 --
1 files changed, 12 insertions(+), 6 deletions(-)
On 09/20/11 17:21, Jan Kiszka wrote:
This was only a best-effort attempt, by far not guaranteed to have an
effect. Drop it so that also no direct pthread usage remain in the
device model.
Signed-off-by: Jan Kiszka
All three patches are fine.
I'll go queue it up in the spice queue when I'm bac
Building on the previous patch, this one adds a media change callback
to scsi-disk.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |5 +
hw/scsi-disk.c | 29 -
hw/scsi.h |2 ++
3 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/hw/scsi
unix and tcp outgoing migration have error values, but didn't returned
it. Make them return the error. Notice that EINPROGRESS & EWOULDBLOCK
are not considered errors as callwill be retry later.
Signed-off-by: Juan Quintela
---
migration-tcp.c | 20 +++-
migration-unix.c |
Signed-off-by: Juan Quintela
---
migration-exec.c | 10 +-
migration-fd.c | 10 +-
migration-tcp.c | 12 ++--
migration-unix.c | 12 ++--
migration.c | 34 +-
migration.h | 38 +++-
Signed-off-by: Juan Quintela
---
migration-exec.c |4 ++--
migration-fd.c |4 ++--
migration-tcp.c |4 ++--
migration-unix.c |4 ++--
migration.c |4 ++--
migration.h |8
6 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/migration-exec.
This series brings scsi-disk and ide/atapi almost on feature parity.
After this series, the only missing feature in scsi-disk is the READ
CD command. The main addition is media change support, both via
unit attention and via GET EVENT STATUS NOTIFICATION.
I originally planned to work on this afte
This was only a best-effort attempt, by far not guaranteed to have an
effect. Drop it so that also no direct pthread usage remain in the
device model.
Signed-off-by: Jan Kiszka
---
Depends on the previous qxl patch I just sent.
hw/qxl.c |6 --
1 files changed, 0 insertions(+), 6 deleti
Add myself as co-maintainer alongside Paul Brook for the TCG ARM
guest implementation (target-arm) and the ARM dev boards (integratorcp,
realview, stellaris, versatilepb).
Signed-off-by: Peter Maydell
---
MAINTAINERS |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/MA
Files are almost identical in functionality, just remove the
differences that make no sense.
Signed-off-by: Juan Quintela
---
migration-tcp.c | 15 ++-
migration-unix.c | 46 +-
2 files changed, 35 insertions(+), 26 deletions(-)
diff
Signed-off-by: Juan Quintela
---
migration-tcp.c |4 ++--
migration-unix.c |6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/migration-tcp.c b/migration-tcp.c
index 1ca48fa..c259b8d 100644
--- a/migration-tcp.c
+++ b/migration-tcp.c
@@ -58,7 +58,7 @@ static void
Use QEMU thread API instead of pthread directly. We still need to get
rid of pthread_yield, though, to drop pthread.h inclusion.
Signed-off-by: Jan Kiszka
---
hw/qxl.c |4 ++--
hw/qxl.h |3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index a282d
On 09/20/11 17:00, Jan Kiszka wrote:
On 2011-09-20 16:48, Gerd Hoffmann wrote:
On 09/20/11 16:27, Jan Kiszka wrote:
Hi Gerd,
can you (or anyone familiar with those bits) comment on pthread_yield()
in ioport_write() of hw/qxl.c? Which threads are supposed to run this
way?
spice server thread
No need to use pthread directly, we have proper abstractions for
identity checking.
Signed-off-by: Jan Kiszka
---
ui/spice-core.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3cbc721..afdf82e 100644
--- a/ui/spice-core.c
Stefan Hajnoczi writes:
> AFAICT the only problem with libust is the __tp_cb_data set but not
> used warning that gcc 4.6 emits, see my test program:
Here's a prettified version of the failing (pre-processed) code:
static inline
void
trace_ust_g_malloc(size_t size, void* ptr)
{
do
Signed-off-by: Jan Kiszka
---
hw/xen_nic.c |1 -
hw/xics.c |2 --
ui/spice-display.c |2 --
3 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/hw/xen_nic.c b/hw/xen_nic.c
index aeca8da..ef2a2d6 100644
--- a/hw/xen_nic.c
+++ b/hw/xen_nic.c
@@ -25,7 +25,6 @@
Once there, remove all parameters that don't need to be passed to
*start_outgoing_migration() functions
Signed-off-by: Juan Quintela
---
migration-exec.c | 19 +--
migration-fd.c | 22 ++
migration-tcp.c | 22 +++---
migration-unix.c |
Signed-off-by: Juan Quintela
---
migration.c |8
migration.h |8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/migration.c b/migration.c
index fb95e14..1e88230 100644
--- a/migration.c
+++ b/migration.c
@@ -31,6 +31,14 @@
do { } while (0)
#endif
Signed-off-by: Juan Quintela
---
migration.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/migration.c b/migration.c
index 1ab26fb..f405d3c 100644
--- a/migration.c
+++ b/migration.c
@@ -136,9 +136,8 @@ void do_info_migrate(Monitor *mon, QObject **ret_data)
QDic
It is used only in one place
Signed-off-by: Juan Quintela
---
migration.c |9 -
migration.h |1 -
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index d63150e..306ac4e 100644
--- a/migration.c
+++ b/migration.c
@@ -132,12 +132,12 @@ free_
Signed-off-by: Juan Quintela
---
migration.c | 34 --
migration.h | 16
2 files changed, 24 insertions(+), 26 deletions(-)
diff --git a/migration.c b/migration.c
index 1a5e25f..007b162 100644
--- a/migration.c
+++ b/migration.c
@@ -34,7 +34,7
On 2011-09-20 16:48, Gerd Hoffmann wrote:
> On 09/20/11 16:27, Jan Kiszka wrote:
>> Hi Gerd,
>>
>> can you (or anyone familiar with those bits) comment on pthread_yield()
>> in ioport_write() of hw/qxl.c? Which threads are supposed to run this
>> way?
>
> spice server thread.
>
>> Can't this rel
It is only used inside migration.c, and fields on that struct are
accessed all around the place on that file.
Signed-off-by: Juan Quintela
---
migration.c | 16 +---
migration.h |1 -
2 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/migration.c b/migration.c
inde
Signed-off-by: Juan Quintela
---
migration.c | 19 +--
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/migration.c b/migration.c
index 59e8f06..9d877a0 100644
--- a/migration.c
+++ b/migration.c
@@ -368,22 +368,21 @@ static void migrate_fd_put_ready(void *opaque
On 09/20/11 16:27, Jan Kiszka wrote:
Hi Gerd,
can you (or anyone familiar with those bits) comment on pthread_yield()
in ioport_write() of hw/qxl.c? Which threads are supposed to run this
way?
spice server thread.
Can't this relation be expressed explicitly?
The thread is created by libsp
"Daniel P. Berrange" wrote:
> On Tue, Sep 20, 2011 at 03:24:41PM +0200, Juan Quintela wrote:
>> If we have one error while migrating, and then we issuse a
>> "migrate_cancel" command, guest hang. Fix it for flushing only when
>> migration is in MIG_STATE_ACTIVE. In case of error of cancellation,
We called it from a single place, and always with state !=
MIG_STATE_ACTIVE. Just remove the whole callback. For users of the
notifier, notice that this is exactly the case where they don't care,
we are just freeing the state from previous failed migration (it can't
be a sucessful one, otherwise
2011/9/20 Mathieu Desnoyers :
> * Lluís Vilanova (vilan...@ac.upc.edu) wrote:
>> Stefan Hajnoczi writes:
>>
>> > On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
>> >> Signed-off-by: Lluís Vilanova
>> >> ---
>> >> trace-events | 4 ++--
>> >> 1 files changed, 2 insertions(+), 2 de
Use MIG_STATE_ACTIVE only when migration has really started
Signed-off-by: Juan Quintela
---
migration.c |6 +-
migration.h | 11 +++
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/migration.c b/migration.c
index 1d7a488..59e8f06 100644
--- a/migration.c
+++ b/
Signed-off-by: Juan Quintela
---
migration-exec.c | 16 +---
migration-fd.c | 16 +---
migration-tcp.c | 15 +--
migration-unix.c | 15 +--
migration.c | 29 +
migration.h | 11 +++
6 file
* Lluís Vilanova (vilan...@ac.upc.edu) wrote:
> Stefan Hajnoczi writes:
>
> > On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> >> Signed-off-by: Lluís Vilanova
> >> ---
> >> trace-events |4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/tra
Hi Gerd,
can you (or anyone familiar with those bits) comment on pthread_yield()
in ioport_write() of hw/qxl.c? Which threads are supposed to run this
way? Can't this relation be expressed explicitly? If not, can we use a
sleep here (how long?)?
The background is that yielding easily breaks into
On Tue, Sep 20, 2011 at 03:24:41PM +0200, Juan Quintela wrote:
> If we have one error while migrating, and then we issuse a
> "migrate_cancel" command, guest hang. Fix it for flushing only when
> migration is in MIG_STATE_ACTIVE. In case of error of cancellation,
> don't flush.
>
> We had an inf
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> > Signed-off-by: Lluís Vilanova
> > ---
> > trace-events |4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/trace-events b/trace-events
> > index
This will allows us to hide the status values.
Signed-off-by: Juan Quintela
---
migration.c |4 ++--
migration.h |2 +-
ui/spice-core.c |4 +---
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index b8632e5..fb95e14 100644
--- a/migrat
1 - 100 of 184 matches
Mail list logo
