Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-05 Thread Paolo Bonzini
On 09/06/2011 05:12 AM, David Gibson wrote: I'm not "fixing ppc". I'm fixing a fundamental flaw in the protocol implementation._So far_ I've only observed the effects on ppc, but that doesn't mean they don't exist. Actually Michael is right. The implementation is correct on x86, though wron

Re: [Qemu-devel] How can I understand iotlb (IOMMU)

2011-09-05 Thread 陳韋任
> > I can't understand CPUState's iotlb field , Why we need iotlb ? I guess he want to know why there are tlb and iotlb in the CPUState, not just one. Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-278

[Qemu-devel] How QEMU manages guest machine's memory?

2011-09-05 Thread 陳韋任
Hi, all I am trying to figure out how QEMU manages the guest machine's memory. If I understand correctly, QEMU uses RAMBlock as a unit when it allocates guest machine's memory. All RAMBlocks are maintained in RAMList. Guest machine needs to call qemu_ram_alloc first to get a RAMBlock, then call

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-05 Thread David Gibson
On Mon, Sep 05, 2011 at 12:19:46PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 05, 2011 at 02:43:16PM +1000, David Gibson wrote: > > On Sun, Sep 04, 2011 at 12:16:43PM +0300, Michael S. Tsirkin wrote: > > > On Sun, Sep 04, 2011 at 12:46:35AM +1000, David Gibson wrote: > > > > On Fri, Sep 02, 201

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-05 Thread Wen Congyang
At 09/04/2011 04:25 PM, Avi Kivity Write: > On 09/02/2011 05:56 AM, Wen Congyang wrote: >> > >> > You could use something like kvm-unit-tests.git to write a simple test >> > that sets up a BAR (say from hw/ivshmem.c), writes and reads to see >> that >> > it is visible, programs the bridge to fil

[Qemu-devel] [Bug 842290] [NEW] MIPS Malta mini-bootloader print function has bad jump instruction

2011-09-05 Thread Andrew Drake
Public bug reported: One of the hardcoded bootloader library instructions in the MIPS Malta mini-bootloader's print function is: stl_raw(p++, 0x08000205); /* j 814 */ Since this function is loaded at 0xbfc00808, this jump jumps to the middle of nowhere. The pr

[Qemu-devel] [Bug 842290] Re: MIPS Malta mini-bootloader print function has bad jump instruction

2011-09-05 Thread Andrew Drake
** Patch added: "Patch to mips_malta.c" https://bugs.launchpad.net/bugs/842290/+attachment/2359348/+files/malta.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/842290 Title: MIPS Malta mini-

[Qemu-devel] [PATCH v5 19/33] target-xtensa: implement windowed registers

2011-09-05 Thread Max Filippov
See ISA, 4.7.1 for details. Physical registers and currently visible window are separate fields in CPUEnv. Only current window is accessible to TCG. On operations that change window base helpers copy current window to and from physical registers. Window overflow check described in 4.7.1.3 is in s

[Qemu-devel] [PATCH v5 26/33] target-xtensa: implement CPENABLE and PRID SRs

2011-09-05 Thread Max Filippov
Signed-off-by: Max Filippov --- hw/xtensa_sample.c|1 + target-xtensa/cpu.h |2 ++ target-xtensa/translate.c |7 +++ 3 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/xtensa_sample.c b/hw/xtensa_sample.c index 0aeb7c8..31a6f70 100644 --- a/hw/xtensa_

[Qemu-devel] [PATCH v5 31/33] target-xtensa: add dc232b core and board

2011-09-05 Thread Max Filippov
This is Diamond 232L Standard Core Rev.B (LE). Signed-off-by: Max Filippov --- Makefile.target |1 + hw/xtensa_dc232b.c| 116 target-xtensa/gdb-config-dc232b.c | 261 + target-xtensa/helper.c

[Qemu-devel] [PATCH v5 24/33] target-xtensa: implement interrupt option

2011-09-05 Thread Max Filippov
See ISA, 4.4.6 (interrupt option), 4.4.7 (high priority interrupt option) and 4.4.8 (timer interrupt option) for details. Signed-off-by: Max Filippov --- hw/xtensa_pic.c | 96 target-xtensa/cpu.h | 45 +- target-xtensa/helper.c|

[Qemu-devel] [PATCH v5 00/32] target-xtensa: new target architecture

2011-09-05 Thread Max Filippov
This series adds support for Tensilica Xtensa target. Port status: Linux for DC232B works in the qemu. Not implemented xtensa options: MAC16, floating point coprocessor, cache option, debug option. v4 -> v5 changes: - implement boolean option; - fix v4 stylistical issues (underscores, comparis

[Qemu-devel] [PATCH v5 02/33] target-xtensa: add target to the configure script

2011-09-05 Thread Max Filippov
Signed-off-by: Max Filippov --- configure| 12 +++- default-configs/xtensa-softmmu.mak |1 + default-configs/xtensaeb-softmmu.mak |1 + 3 files changed, 13 insertions(+), 1 deletions(-) create mode 100644 default-configs/xtensa-softmmu.mak create

[Qemu-devel] [PATCH v5 28/33] target-xtensa: add gdb support

2011-09-05 Thread Max Filippov
Specific xtensa processor overlay for GDB contains register map in the gdb/xtensa-config.c. This description is used by the GDB to e.g. parse 'g' response packets and it may be reused in the qemu's gdbstub (only XTREG definitions for non-pseudoregisters are needed). Currently mainline GDB does not

[Qemu-devel] [PATCH v5 06/33] target-xtensa: add sample board

2011-09-05 Thread Max Filippov
Sample board and sample CPU core are used for debug and may be used for development of custom SoC emulators. This board has two fixed size memory regions for DTCM and ITCM and variable length SRAM region. Signed-off-by: Max Filippov --- Makefile.target|1 + hw/xtensa_sample.c | 106 +++

[Qemu-devel] [PATCH v5 20/33] target-xtensa: implement loop option

2011-09-05 Thread Max Filippov
See ISA, 4.3.2 for details. Operations that change LEND SR value invalidate TBs at the old and at the new LEND. LEND value at TB compilation time is considered constant and loop instruction is generated based on this value. Invalidation may be avoided for the TB at the old LEND address, since loo

[Qemu-devel] [PATCH v5 04/33] target-xtensa: implement narrow instructions

2011-09-05 Thread Max Filippov
Instructions with op0 >= 8 are 2 bytes long, others are 3 bytes long. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 54 + 1 files changed, 54 insertions(+), 0 deletions(-) diff --git a/target-xtensa/translate.c b/target-xtensa/translat

[Qemu-devel] [PATCH v5 10/33] target-xtensa: implement RST3 group

2011-09-05 Thread Max Filippov
- access to Special Registers (wsr, rsr); - access to User Registers (wur, rur); - misc. operations option (value clamp, sign extension, min, max); - conditional moves. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 161 + 1 files changed

[Qemu-devel] [PATCH v5 08/33] target-xtensa: implement JX/RET0/CALLX

2011-09-05 Thread Max Filippov
Group SNM0 (indirect jumps and calls). Signed-off-by: Max Filippov --- target-xtensa/translate.c | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c index 9e26a65..78fffc5 100644

[Qemu-devel] [PATCH v5 12/33] target-xtensa: implement LSAI group

2011-09-05 Thread Max Filippov
- base + offset load/store operations for 1/2/4 byte values; - cache operations (not implemented); - multiprocessor synchronization operations. Signed-off-by: Max Filippov --- target-xtensa/cpu.h |1 + target-xtensa/translate.c | 89 + 2 fi

[Qemu-devel] [PATCH v5 01/33] target-xtensa: add target stubs

2011-09-05 Thread Max Filippov
Signed-off-by: Max Filippov --- Makefile.target |2 + arch_init.c |2 + arch_init.h |1 + cpu-exec.c|2 + elf.h |2 + hw/xtensa_pic.c | 38 ++ target-xtensa/cpu.h | 95

[Qemu-devel] [PATCH v5 11/33] target-xtensa: implement shifts (ST1 and RST1 groups)

2011-09-05 Thread Max Filippov
- ST1: SAR (shift amount special register) manipulation, NSA(U); - RST1: shifts, 16-bit multiplication. Signed-off-by: Max Filippov --- target-xtensa/cpu.h |4 + target-xtensa/helpers.h |2 + target-xtensa/op_helper.c | 14 +++ target-xtensa/translate.c | 242 +

[Qemu-devel] [PATCH v5 13/33] target-xtensa: mark reserved and TBD opcodes

2011-09-05 Thread Max Filippov
Reserved opcodes must generate illegal instruction exception. Usually they signal emulation quality problems. Not implemented opcodes are good to see. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 110 - 1 files changed, 109 insertions(+

[Qemu-devel] [PATCH v5 05/33] target-xtensa: implement RT0 group

2011-09-05 Thread Max Filippov
NEG and ABS are the only members of RT0 group. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c index 4dfca2b..92547d2 100644 --- a/target-xt

[Qemu-devel] [PATCH v5 32/33] MAINTAINERS: add xtensa maintainer

2011-09-05 Thread Max Filippov
Add myself as target-xtensa and DC232B maintainer. Signed-off-by: Max Filippov --- MAINTAINERS | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 508ea1e..72b2099 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -115,6 +115,12 @@ M:

[Qemu-devel] [PATCH v5 15/33] target-xtensa: implement CACHE group

2011-09-05 Thread Max Filippov
All operations in this group are no-ops, because cache ought to be transparent to applications. However cache may be abused, then we'll need to actually implement these opcodes. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 95 - 1 file

[Qemu-devel] [PATCH v5 03/33] target-xtensa: implement disas_xtensa_insn

2011-09-05 Thread Max Filippov
Set up disas_xtensa_insn switch structure, mark required options on high level groups. Implement arithmetic/bit logic/jump/call0. Implement code generation loop with single step/breakpoint checking. Signed-off-by: Max Filippov --- target-xtensa/cpu.h | 67 +++ target-xtensa/helper.c

[Qemu-devel] [PATCH v5 22/33] target-xtensa: implement unaligned exception option

2011-09-05 Thread Max Filippov
See ISA, 4.4.4 for details. Correct (aligned as per ISA) address for unaligned access is generated in case this option is not enabled. Signed-off-by: Max Filippov --- target-xtensa/helper.c|4 ++- target-xtensa/op_helper.c | 26 target-xtensa/translate.c | 4

[Qemu-devel] [PATCH v5 09/33] target-xtensa: add special and user registers

2011-09-05 Thread Max Filippov
Special Registers hold the majority of the state added to the processor by the options. See ISA, 5.3 for details. User Registers hold state added in support of designer's TIE and in some cases of options that Tensilica provides. See ISA, 5.4 for details. Only registers mapped in sregnames or ureg

[Qemu-devel] [PATCH v5 07/33] target-xtensa: implement conditional jumps

2011-09-05 Thread Max Filippov
- BZ (comparison to zero); - BI0 (comparison to signed immediate); - BI1 (comparison to unsigned immediate); - B (two registers comparison, bit sets comparison); - BEQZ.N/BNEZ.N (narrow comparison to zero). Signed-off-by: Max Filippov --- target-xtensa/translate.c | 164

[Qemu-devel] [PATCH v5 14/33] target-xtensa: implement SYNC group

2011-09-05 Thread Max Filippov
All operations in this group are no-ops, because there are no delayed side effects. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/target-xtensa/translate.c b/target-xtensa/translat

[Qemu-devel] [PATCH v5 23/33] target-xtensa: implement SIMCALL

2011-09-05 Thread Max Filippov
Tensilica iss provides support for applications running in freestanding environment through SIMCALL command. It is used by Tensilica libc to access argc/argv, for file I/O, etc. Note that simcalls that accept buffer addresses expect virtual addresses. Signed-off-by: Max Filippov --- Makefile.ta

[Qemu-devel] [PATCH v5 27/33] target-xtensa: implement relocatable vectors

2011-09-05 Thread Max Filippov
See ISA, 4.4.3 for details. Vector addresses recorded in core configuration are absolute values that correspond to default VECBASE value. Signed-off-by: Max Filippov --- target-xtensa/cpu.h |2 ++ target-xtensa/helper.c| 18 -- target-xtensa/translate.c |1 +

[Qemu-devel] [PATCH v5 18/33] target-xtensa: implement RST2 group (32 bit mul/div/rem)

2011-09-05 Thread Max Filippov
Signed-off-by: Max Filippov --- target-xtensa/translate.c | 77 - 1 files changed, 76 insertions(+), 1 deletions(-) diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c index dccd453..bc04a10 100644 --- a/target-xtensa/translate.c +++ b

[Qemu-devel] [PATCH v5 21/33] target-xtensa: implement extended L32R

2011-09-05 Thread Max Filippov
See ISA, 4.3.3 for details. TB flag XTENSA_TBFLAG_LITBASE is used to track enable bit of LITBASE SR. Signed-off-by: Max Filippov --- target-xtensa/cpu.h |6 ++ target-xtensa/helper.c|1 + target-xtensa/translate.c | 37 + 3 files chang

[Qemu-devel] [PATCH v5 25/33] target-xtensa: implement accurate window check

2011-09-05 Thread Max Filippov
See ISA, 4.7.1.3 for details. Window check is inserted before commands that push "used register watermark" beyond its current level. Used register watermark is reset on instructions that change WINDOW_BASE/WINDOW_START SRs. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 110 ++

[Qemu-devel] [PATCH v5 30/33] target-xtensa: implement boolean option

2011-09-05 Thread Max Filippov
See ISA, 4.3.9 Signed-off-by: Max Filippov --- target-xtensa/cpu.h |1 + target-xtensa/translate.c | 109 +++-- 2 files changed, 86 insertions(+), 24 deletions(-) diff --git a/target-xtensa/cpu.h b/target-xtensa/cpu.h index 14d62fa..339075d 100

[Qemu-devel] [PATCH v5 16/33] target-xtensa: add PS register and access control

2011-09-05 Thread Max Filippov
Signed-off-by: Max Filippov --- target-xtensa/cpu.h | 53 - target-xtensa/helper.c|1 + target-xtensa/translate.c | 29 3 files changed, 77 insertions(+), 6 deletions(-) diff --git a/target-xtensa/cpu.h b/targ

[Qemu-devel] [PATCH v5 29/33] target-xtensa: implement memory protection options

2011-09-05 Thread Max Filippov
- TLB opcode group; - region protection option (ISA, 4.6.3); - region translation option (ISA, 4.6.4); - MMU option (ISA, 4.6.5). Cache control attribute bits are not used by this implementation. Signed-off-by: Max Filippov --- target-xtensa/cpu.h | 56 - target-xtensa/helper.c

[Qemu-devel] [PATCH v5 17/33] target-xtensa: implement exceptions

2011-09-05 Thread Max Filippov
- mark privileged opcodes with ring check; - make debug exception on exception handler entry. Signed-off-by: Max Filippov --- cpu-exec.c|6 +++ target-xtensa/cpu.h | 67 target-xtensa/helper.c| 37 +++- target-xtensa/help

[Qemu-devel] buildbot failure in qemu on default_ppc

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder default_ppc while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/144 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: qemu-ppc.opensuse.org Build Reason:

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel5

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel5 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel5/builds/0 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel5 Build

[Qemu-devel] buildbot failure in qemu on default_x86_64_fedora16

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_fedora16 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_fedora16/builds/16 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_fedora

Re: [Qemu-devel] Now, what's left to non-developers? (Qemu forum down again, No such list qemu-users)

2011-09-05 Thread Stefan Weil
Am 19.08.2011 21:49, schrieb Anthony Liguori: On 08/19/2011 11:28 AM, Stefan Hajnoczi wrote: On Fri, Aug 19, 2011 at 2:26 PM, Ottavio wrote: On 19 August 2011 11:08, 陳韋任 wrote: Hi, Ottavio 2) The qemu-user mailing list is not active: http://lists.nongnu.org/mailman/listinfo/qemu-users

Re: [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments

2011-09-05 Thread Jan Kiszka
On 2011-09-05 21:45, Blue Swirl wrote: > On Mon, Sep 5, 2011 at 3:37 PM, Stefan Hajnoczi > wrote: >> String arguments are useful for producing human-readable traces without >> post-processing (e.g. stderr backend). Although the simple backend >> cannot handles strings all others can. Strings sho

Re: [Qemu-devel] [PATCH] g364fb: compile in hwlib

2011-09-05 Thread Hervé Poussineau
Blue Swirl a écrit : Compile g364fb in hwlib. Two compilations less for the full build. Signed-off-by: Blue Swirl --- Makefile.objs|1 + Makefile.target |2 +- default-configs/mips-softmmu.mak |1 + default-configs/mips64-softmmu.mak

Re: [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments

2011-09-05 Thread Blue Swirl
On Mon, Sep 5, 2011 at 3:37 PM, Stefan Hajnoczi wrote: > String arguments are useful for producing human-readable traces without > post-processing (e.g. stderr backend).  Although the simple backend > cannot handles strings all others can.  Strings should be allowed and > the simple backend can be

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Blue Swirl
On Mon, Sep 5, 2011 at 8:38 AM, Edgar E. Iglesias wrote: > On Sat, Sep 03, 2011 at 02:53:31PM -0500, Anthony Liguori wrote: >> On 08/31/2011 11:59 AM, Blue Swirl wrote: >> > On Wed, Aug 31, 2011 at 8:28 AM, Avi Kivity  wrote: >> >> On 08/30/2011 10:19 PM, Blue Swirl wrote: >> >>> >> >>  

Re: [Qemu-devel] [PATCH] [SPARC] Gdbstub: Fix back-trace on SPARC32

2011-09-05 Thread Blue Swirl
On Mon, Sep 5, 2011 at 9:33 AM, Fabien Chouteau wrote: > On 03/09/2011 11:25, Blue Swirl wrote: >> On Thu, Sep 1, 2011 at 2:17 PM, Fabien Chouteau wrote: >>> Gdb expects all registers windows to be flushed in ram, which is not the >>> case >>> in Qemu. Therefore the back-trace generation doesn't

Re: [Qemu-devel] [PATCH 7/9] openpic: avoid a warning from clang analyzer

2011-09-05 Thread Blue Swirl
On Mon, Sep 5, 2011 at 6:48 AM, Paolo Bonzini wrote: > On 09/04/2011 05:52 PM, Blue Swirl wrote: >> >> Avoid this warning by clang analyzer by defining a default case: >> /src/qemu/hw/openpic.c:477:5: warning: Undefined or garbage value >> returned to caller >>     return retval; >> >> Signed-off-

Re: [Qemu-devel] qemu segfaults at start

2011-09-05 Thread Mulyadi Santosa
On 05/09/2011, octane indice wrote: > then: > qemu disk.img > Segmentation fault how about invoking it as: qemu -hda disk.img ? does that make any difference? perhaps adding -S too so we could find out whether it reach the very initial point. -- regards, Mulyadi Santosa Freelance Linux tra

Re: [Qemu-devel] [PATCH V12 01/15] Implement qemu_read_full

2011-09-05 Thread malc
On Mon, 5 Sep 2011, M. Mohan Kumar wrote: > Signed-off-by: M. Mohan Kumar > --- > osdep.c | 32 > qemu-common.h |2 ++ > 2 files changed, 34 insertions(+), 0 deletions(-) > > diff --git a/osdep.c b/osdep.c > index 56e6963..5a4d670 100644 > --- a/osde

[Qemu-devel] [PATCH V12 14/15] hw/9pfs: readlink in chroot environment

2011-09-05 Thread M. Mohan Kumar
Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-worker.c | 17 ++--- hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c | 14 -- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git a/hw/9pfs/virtio-9p-chroot-worker.c b/

[Qemu-devel] [PATCH V12 15/15] hw/9pfs: Chroot environment for other functions

2011-09-05 Thread M. Mohan Kumar
Add chroot functionality for system calls that can operate on a file using relative directory file descriptor. Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-local.c | 41 +++-- 1 files changed, 39 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/vir

[Qemu-devel] [PATCH V12 09/15] hw/9pfs: Rename in chroot environment

2011-09-05 Thread M. Mohan Kumar
Support renaming a file or directory in chroot envirnoment. Add interfaces for renaming in chroot worker and qemu side. Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-worker.c | 17 + hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c |

[Qemu-devel] [PATCH V12 01/15] Implement qemu_read_full

2011-09-05 Thread M. Mohan Kumar
Signed-off-by: M. Mohan Kumar --- osdep.c | 32 qemu-common.h |2 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index 56e6963..5a4d670 100644 --- a/osdep.c +++ b/osdep.c @@ -126,6 +126,38 @@ ssize_t qemu_write_ful

[Qemu-devel] [PATCH V12 08/15] hw/9pfs: Removing file or directory in chroot environment

2011-09-05 Thread M. Mohan Kumar
Support for removing file or directory in chroot environment. Add interfaces to remove file/directory in chroot worker and qemu side. Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++ hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local

[Qemu-devel] [PATCH V12 07/15] hw/9pfs: Creating special files in chroot environment

2011-09-05 Thread M. Mohan Kumar
Add both chroot worker and qemu side interfaces to create special files (directory, device nodes, links and symbolic links) Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-worker.c | 52 + hw/9pfs/virtio-9p-chroot.h|5 +++ hw/9pfs/virt

[Qemu-devel] [PATCH V12 00/15] virtio-9p: chroot environment for passthrough security model

2011-09-05 Thread M. Mohan Kumar
In passthrough security model, following symbolic links in the server side could result in TOCTTOU vulnerabilities. (http://en.wikipedia.org/wiki/Time-of-check-to-time-of-use) This patchset resolves this issue by creating a dedicated process which chroots into the share path and all file object ac

[Qemu-devel] [PATCH V12 06/15] hw/9pfs: Create support in chroot environment

2011-09-05 Thread M. Mohan Kumar
Add both chroot worker & qemu side interfaces to create regular files in chroot environment Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-worker.c | 36 hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c |5 +++--

[Qemu-devel] [PATCH 1/2] ptimer: move declarations to ptimer.h

2011-09-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/arm_timer.c|1 + hw/etraxfs_timer.c|1 + hw/grlib_apbuart.c|1 + hw/grlib_gptimer.c|1 + hw/lan9118.c |1 + hw/leon3.c|1 + hw/lm32_timer.c |1 + hw/mcf5206.c |1 + hw/mcf52

[Qemu-devel] [PATCH V12 03/15] hw/9pfs: Provide chroot worker side interfaces

2011-09-05 Thread M. Mohan Kumar
Implement chroot worker side interfaces like sending the file descriptor to qemu process, reading the object request from socket etc. Also add chroot main function and other helper routines. Signed-off-by: M. Mohan Kumar [mala...@us.ibm.com: Do not send fd as part of data, instead a special value

[Qemu-devel] [PATCH V12 02/15] hw/9pfs: Enable CONFIG_THREAD if CONFIG_VIRTFS is enabled

2011-09-05 Thread M. Mohan Kumar
9p Chroot environment needs APIs defined in qemu-thread.c, so enable CONFIG_THREAD if virtfs is enabled Signed-off-by: M. Mohan Kumar --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 1340c33..ad59fcc 100755 --- a/configure +++ b/c

[Qemu-devel] [PATCH V12 04/15] hw/9pfs: qemu interfaces for chroot environment

2011-09-05 Thread M. Mohan Kumar
QEMU side interfaces to communicate with chroot worker process. Signed-off-by: M. Mohan Kumar [mala...@us.ibm.com: Handle when qemu process can not receive fd because it already reached max fds] --- Makefile.objs |2 +- hw/9pfs/virtio-9p-chroot.c | 103 +

[Qemu-devel] [PATCH V12 05/15] hw/9pfs: Support for opening a file in chroot environment

2011-09-05 Thread M. Mohan Kumar
This patch adds both chroot worker and qemu side support to open a file/ directory in the chroot environment Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot.c | 29 hw/9pfs/virtio-9p-chroot.h |2 +- hw/9pfs/virtio-9p-local.c | 79 +

[Qemu-devel] [PATCH V12 11/15] hw/9pfs: chmod in chroot environment

2011-09-05 Thread M. Mohan Kumar
Add support to do chmod operation in chroot process. Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++ hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c |5 +++-- 3 files changed, 22 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH V12 13/15] hw/9pfs: stat in chroot environment

2011-09-05 Thread M. Mohan Kumar
Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-worker.c | 52 - hw/9pfs/virtio-9p-chroot.c| 59 - hw/9pfs/virtio-9p-chroot.h|3 ++ hw/9pfs/virtio-9p-local.c | 30 +++

[Qemu-devel] [PATCH V12 10/15] hw/9pfs: Move file post creation changes to none security model

2011-09-05 Thread M. Mohan Kumar
After creating a file object, its permission and ownership details are updated as per 9p client's request for both passthrough and none security model. But with chrooted environment its not required for passthrough security model. Move all post file creation changes to none security model. Signed-

[Qemu-devel] [PATCH V12 12/15] hw/9pfs: chown in chroot environment

2011-09-05 Thread M. Mohan Kumar
Add support to do chown in chroot process Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++ hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c |9 + 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a

[Qemu-devel] [PATCH] qemu-options: Improve help texts for options which depend on configure

2011-09-05 Thread Stefan Weil
* Replace "available only" by the more common "only available". * Tracing options depend on the configuration of the QEMU executable, so clarify the help text for both options. Cc: Stefan Hajnoczi Signed-off-by: Stefan Weil --- qemu-options.hx | 10 +- 1 files changed, 5 insertions

[Qemu-devel] [PATCH] scsi: fix accounting of writes

2011-09-05 Thread Paolo Bonzini
Writes go through scsi_write_complete at least twice, the first time to get some data without having actually written anything. Because of this, the first time scsi_write_complete is called it will call bdrv_acct_done and account a read incorrectly. Fix this by looking at the aiocb. I am doing t

[Qemu-devel] [PATCH 2/2] MAINTAINERS: add tracing subsystem

2011-09-05 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 508ea1e..ce189a4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -446,6 +446,12 @@ S: Maintained F: slirp/ T: git://git.kiszka.org/qemu.git

[Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments

2011-09-05 Thread Stefan Hajnoczi
String arguments are useful for producing human-readable traces without post-processing (e.g. stderr backend). Although the simple backend cannot handles strings all others can. Strings should be allowed and the simple backend can be extended to support them. Signed-off-by: Stefan Hajnoczi ---

Re: [Qemu-devel] [PATCH 5/5] tcg/ppc64: Only one call output register needed for 64 bit hosts

2011-09-05 Thread malc
On Mon, 5 Sep 2011, Stefan Weil wrote: > The second register is only needed for 32 bit hosts. > > Cc: Vassili Karpov > Signed-off-by: Stefan Weil > --- > tcg/ppc64/tcg-target.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tc

Re: [Qemu-devel] [RFC PATCH 0/5] Add configure flag to disable TCG

2011-09-05 Thread Stefano Stabellini
On Fri, 2 Sep 2011, Anthony Liguori wrote: > Hi, > > There have been a few attempts in the past to allow TCG to be disabled > at build time. Recently, Alex made the suggestion that we could do it by > using > the same trick that we used to introduce kvm support. That involves > introducing > a

[Qemu-devel] [PATCH] spice: set qxl->ssd.running=true before telling spice to start, RHBZ #733993

2011-09-05 Thread Yonit Halperin
If qxl->ssd.running=true is set after telling spice to start, the spice server thread can call qxl_send_events while qxl->ssd.running is still false. This leads to assert(d->ssd.running). Signed-off-by: Yonit Halperin --- Since it looks like the purpose of the assert in qxl_send_event is prevent

[Qemu-devel] required glib version? Re: [PATCH 2/6] Add base64 encoder/decoder

2011-09-05 Thread Gerd Hoffmann
On 08/26/11 17:47, Jan Kiszka wrote: On 2011-08-26 17:23, Jan Kiszka wrote: [ using glib base64 decoder ] Requires glib>= 2.12, we are currently at>= 2.0, right? Would it be OK to raise the entry barrier? In master it currently is >= 2.20 due to v9fs_init_worker_threads using g_thread_get

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote: > Hi, > > >I verified it still calls reds_stream_free from the worker thread, only > >now the call itself is done in red_channel.c (via red_channel_disconnect > >or something like that), which is called from red_worker.c > > Where t

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote: > Hi, > > >I verified it still calls reds_stream_free from the worker thread, only > >now the call itself is done in red_channel.c (via red_channel_disconnect > >or something like that), which is called from red_worker.c > > Where t

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Gerd Hoffmann
Hi, I verified it still calls reds_stream_free from the worker thread, only now the call itself is done in red_channel.c (via red_channel_disconnect or something like that), which is called from red_worker.c Where the code in red_channel.c is now shared for all channel types? Hmm. That mak

Re: [Qemu-devel] [PATCH] qemu-coroutine: Add simple work queue support

2011-09-05 Thread Kevin Wolf
Am 24.08.2011 09:57, schrieb Peter A. G. Crosthwaite: > Add a function co_queue_yield_to_next() which will immediately transfer > control to the coroutine at the head of a co queue. This can be used for > implementing simple work queues where the manager of a co-queue only > needs to restart queued

Re: [Qemu-devel] [PATCH] ehci: avoid string arguments in trace events

2011-09-05 Thread Gerd Hoffmann
Hi, Let's drop this patch. I will update the tracing documentation. Great. thanks, Gerd

Re: [Qemu-devel] [PATCH] ehci: avoid string arguments in trace events

2011-09-05 Thread Stefan Hajnoczi
On Mon, Sep 5, 2011 at 9:38 AM, Gerd Hoffmann wrote: > On 09/03/11 17:22, Stefan Hajnoczi wrote: >> >> String arguments are not supported by all trace backends.  This patch >> replaces existing string arguments in hw/usb-ehci.c either with >> individual trace events that remain human-friendly or b

[Qemu-devel] [PATCH] ppc405: use RAM_ADDR_FMT instead of %08lx

2011-09-05 Thread Stefan Hajnoczi
The RAM_ADDR_FMT macro hides the type of ram_addr_t so that format strings can be safely used. Make sure to use RAM_ADDR_FMT so that the build works on 32-bit hosts with Xen enabled. Whether Xen should affect ppc TCG targets is questionable but a separate issue. Signed-off-by: Stefan Hajnoczi -

Re: [Qemu-devel] QEMU online guest disk resize wrt host block devices

2011-09-05 Thread Kevin Wolf
Am 01.09.2011 17:56, schrieb Christoph Hellwig: > On Thu, Sep 01, 2011 at 03:27:35PM +0100, Daniel P. Berrange wrote: >> One other question too, when creating a qcow2 image via 'qemu-img create' >> you can specify a 'prealloc' option to require metadata to be allocated >> at time of creation. >> >>

Re: [Qemu-devel] qemu segfaults at start

2011-09-05 Thread Stefan Hajnoczi
On Mon, Sep 5, 2011 at 10:04 AM, octane indice wrote: > qemu disk.img > Segmentation fault Please post the backtrace as well as your host operating system version (e.g. Fedora 15): gdb --args qemu disk.img (gdb) r ...runs and crashes... (gdb) bt Stefan

[Qemu-devel] KVM call agenda for September 6

2011-09-05 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] [PATCH v2] Display logical disk size in 'info block' output

2011-09-05 Thread Kevin Wolf
Am 02.09.2011 18:38, schrieb Daniel P. Berrange: > From: "Daniel P. Berrange" > > To aid in knowing whether a 'block_resize' was succesful, display > the logical disk size in bytes, in the 'info block' output > > In v2: > - Replace sectors with bytes > > Signed-off-by: Daniel P. Berrange > -

Re: [Qemu-devel] [PATCH v4 00/32] target-xtensa: new target architecture

2011-09-05 Thread Max Filippov
> I just had a very quick look and it Looks good to me too. Would be awesome > if Max could provide something to test with in binary form. Maybe we could > put it on the wiki's download page. Tarball of my current kernel and rootfs is available at http://jcmvbkbc.spb.ru/~dumb/ws/osll/qemu-xtensa/2

Re: [Qemu-devel] [PATCH v3] rbd: fix leak in qemu_rbd_open failure paths

2011-09-05 Thread Kevin Wolf
Am 04.09.2011 18:19, schrieb Sage Weil: > Fix leak of s->snap in failure path. Simplify error paths for the whole > function. > > Reported-by: Stefan Hajnoczi > Signed-off-by: Sage Weil This depends on "[PATCH v2] rbd: allow client id to be specified in config string", which doesn't seem to ap

Re: [Qemu-devel] Where to log xen_platform_log data

2011-09-05 Thread Stefano Stabellini
On Sat, 3 Sep 2011, Stefan Hajnoczi wrote: > Hi Steven, > The Xen platform PCI device has a logging feature that is currently > implemented using trace_xen_platform_log(s->log_buffer). String > arguments may not be supported by all trace backends so they should be > avoided. For example, the simp

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-05 Thread Michael S. Tsirkin
On Mon, Sep 05, 2011 at 11:53:11AM +0200, Gerd Hoffmann wrote: > Hi, > > >>Looking... qdev_device_help() shows only device properties, not bus > >>properties. I'd call that a bug. > > > >Hmm, but is "bus" a bus property? > > It isn't. bus= is handled by qdev core (id= too). addr= actually >

Re: [Qemu-devel] [PATCH v4 00/32] target-xtensa: new target architecture

2011-09-05 Thread Edgar E. Iglesias
On Sun, Sep 04, 2011 at 06:35:10PM +, Blue Swirl wrote: > On Thu, Sep 1, 2011 at 8:45 PM, Max Filippov wrote: > > This series adds support for Tensilica Xtensa target. > > Port status: Linux for DC232B works in the qemu. > >  Not implemented xtensa options: MAC16, floating point coprocessor, >

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 11:02:43AM +0200, Gerd Hoffmann wrote: > Hi, > > >Hi, > >RED_WORKER_MESSAGE_DISPLAY_DISCONNECT is not the only place that > >triggers red_disconnect_channel (and as a result, > >reds_stream_free(dispatcher->stream)). red_disconnect_channel is called > >also when there is

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Edgar E. Iglesias
On Mon, Sep 05, 2011 at 12:28:50PM +0300, Avi Kivity wrote: ... > Query is needed when a line is masked internally, or when a device is > hot-plugged. > > We can work around masking by caching the level in the device even > though the line is masked, and querying the cache when the line is >

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Edgar E. Iglesias
On Sun, Sep 04, 2011 at 08:57:31AM -0500, Anthony Liguori wrote: > On 09/04/2011 08:49 AM, Jan Kiszka wrote: > > On 2011-09-04 15:41, Anthony Liguori wrote: > >> On 09/04/2011 08:36 AM, Jan Kiszka wrote: > >>> On 2011-09-04 15:32, Anthony Liguori wrote: > I prefer to not think of IRQs as speci

Re: [Qemu-devel] [PATCH] qemu_vmalloc: align properly for transparent hugepages and KVM

2011-09-05 Thread Avi Kivity
On 09/05/2011 01:10 PM, Jan Kiszka wrote: On 2011-09-05 10:07, Avi Kivity wrote: > To make good use of transparent hugepages, KVM requires that guest-physical > and host-virtual addresses share the low 21 bits (as opposed to just the low > 12 bits normally required). > > Adjust qemu_vmalloc()

Re: [Qemu-devel] [PATCH] qemu_vmalloc: align properly for transparent hugepages and KVM

2011-09-05 Thread Jan Kiszka
On 2011-09-05 10:07, Avi Kivity wrote: > To make good use of transparent hugepages, KVM requires that guest-physical > and host-virtual addresses share the low 21 bits (as opposed to just the low > 12 bits normally required). > > Adjust qemu_vmalloc() to honor that requirement. Ignore it for smal

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-05 Thread Gerd Hoffmann
Hi, Looking... qdev_device_help() shows only device properties, not bus properties. I'd call that a bug. Hmm, but is "bus" a bus property? It isn't. bus= is handled by qdev core (id= too). addr= actually is a (pci) bus property. cheers, Gerd

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-09-05 Thread Avi Kivity
On 09/04/2011 05:03 PM, Avi Kivity wrote: On 08/22/2011 04:12 PM, Anthony Liguori wrote: This patch changes qemu_set_fd_handler to be implemented in terms of g_io_add_watch(). The semantics are a bit different so some glue is required. qemu_set_fd_handler2 is much harder to convert because o

  1   2   >