Blue Swirl writes:
> On Thu, Aug 25, 2011 at 7:02 PM, Anthony Liguori
> wrote:
>> On 08/25/2011 01:58 PM, Blue Swirl wrote:
>>>
>>> On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias
>>> wrote:
[...]
Guys, please start testing before applying these patches. It's not hard,
there are
On 08/30/2011 09:31 PM, Blue Swirl wrote:
>>
>> Since KVM can handle MMIO, I think it should also be able to handle
>> watchpoints.
>>
>
> Not on RAM areas.
But isn't it possible to unmap one page of RAM and replace that by
MMIO page on KVM, is this because of the memory slots?
It is possib
On Mon, Aug 29, 2011 at 6:20 AM, Paolo Bonzini wrote:
> On 08/27/2011 08:09 PM, Umesh Deshpande wrote:
>
>> Following patch series deals with VCPU and iothread starvation during the
>> migration of a guest. Currently the iothread is responsible for performing
>> the
>> guest migration. It holds q
On 08/30/2011 08:30 PM, malc wrote:
On Tue, 30 Aug 2011, Anthony Liguori wrote:
This won't even come close to passing checkpatch.pl
Have you actually tried?
Sigh. I was hoping checkpatch.pl was more useful than it appears to be.
At any rate, the patch doesn't follow CODING_STYLE.
Regards
On Tue, 30 Aug 2011, Anthony Liguori wrote:
> This won't even come close to passing checkpatch.pl
Have you actually tried?
>
> Regards,
>
> Anthony Liguori
>
> On 08/30/2011 08:05 PM, bifferos wrote:
> >
> > Signed-off-by: Mark Kelly
> > diff --git a/Makefile.objs b/Makefile.objs
> > index 6
This won't even come close to passing checkpatch.pl
Regards,
Anthony Liguori
On 08/30/2011 08:05 PM, bifferos wrote:
Signed-off-by: Mark Kelly
diff --git a/Makefile.objs b/Makefile.objs
index 6991a9f..7d87503 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -240,6 +240,7 @@ hw-obj-$(CONFIG_P
Signed-off-by: Mark Kelly
diff --git a/Makefile.objs b/Makefile.objs
index 6991a9f..7d87503 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -240,6 +240,7 @@ hw-obj-$(CONFIG_PCNET_PCI) += pcnet-pci.o
hw-obj-$(CONFIG_PCNET_COMMON) += pcnet.o
hw-obj-$(CONFIG_E1000_PCI) += e1000.o
hw-obj-$(CONFI
An updated diff taking Blue's comments into consideration.
Allow overriding the location of Samba's smbd.
Pretty much every OS I look at has some means of
changing this path (patching) so lets just make
it easier for OS developers creating packages
and/or end users to override the location.
Sig
Blue Swirl writes:
> On Tue, Aug 30, 2011 at 7:36 PM, Lluís wrote:
>> Blue Swirl writes:
>>
>>> Even better, taking the instrumentation approach, could the test
>>> device be left out completely, just use guest invisible methods (like
>>> watchpoints) to interact with the guest?
>>
>> I don't g
Am 30.08.2011 20:29, schrieb Paolo Bonzini:
On 08/30/2011 07:57 PM, Blue Swirl wrote:
>
> +#if defined(_WIN32)
> +# define QEMU_PACKED __attribute__((gcc_struct, packed))
Maybe we could also use gcc_struct also for non-win32?
> +#else
> +# define QEMU_PACKED __attribute__((packed))
> +#e
On Tue, Aug 30, 2011 at 6:29 PM, Alexander Graf wrote:
>
> On 30.08.2011, at 19:25, Stefan Weil wrote:
>
>> Am 30.08.2011 09:44, schrieb Kevin Wolf:
>>> Am 29.08.2011 21:55, schrieb Stefan Weil:
Am 29.08.2011 10:34, schrieb TeLeMan:
> On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote:
>>>
On Tue, Aug 30, 2011 at 7:36 PM, Lluís wrote:
> Blue Swirl writes:
>
>> Even better, taking the instrumentation approach, could the test
>> device be left out completely, just use guest invisible methods (like
>> watchpoints) to interact with the guest?
>
> I don't get it. Sorry but I've not been
On Tue, Aug 30, 2011 at 7:28 PM, Jan Kiszka wrote:
> On 2011-08-30 21:19, Blue Swirl wrote:
>> On Mon, Aug 29, 2011 at 9:13 PM, Avi Kivity wrote:
>>> On 08/30/2011 12:06 AM, Jan Kiszka wrote:
>
> Does this need to be save/restored for migration?
Nope, but we need some othe
Lluís writes:
> Michael Roth writes:
>> Hmm, looking again I'm confused why we need to do this in the first
>> place...the
>> rule is:
>> LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o
>> $@ $(1) $(LIBS)," LINK $(TARGET_DIR)$@")
>> %$(EXESUF): %.o
>> $(call LINK,$^
On Tue, Aug 30, 2011 at 9:22 AM, Stefan Hajnoczi wrote:
> On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth
> wrote:
>> @@ -380,7 +381,6 @@ else
>> trace-obj-y = trace.o
>> ifeq ($(TRACE_BACKEND),simple)
>> trace-obj-y += simpletrace.o
>> -user-obj-y += qemu-timer-common.o
>> endif
>> endif
>
>
Blue Swirl writes:
> Even better, taking the instrumentation approach, could the test
> device be left out completely, just use guest invisible methods (like
> watchpoints) to interact with the guest?
I don't get it. Sorry but I've not been closely following the thread,
and a quick look at it gav
On 08/30/2011 01:45 PM, Andreas Färber wrote:
Am 30.08.2011 um 00:42 schrieb Jan Kiszka:
What about making --enable-io-thread default as an intermediate step?
That would leave --disable-io-thread as temporary workaround until all
issues are fixed. The latter could generate a big fat warning tha
On 2011-08-30 21:19, Blue Swirl wrote:
> On Mon, Aug 29, 2011 at 9:13 PM, Avi Kivity wrote:
>> On 08/30/2011 12:06 AM, Jan Kiszka wrote:
>>>
Does this need to be save/restored for migration?
>>>
>>> Nope, but we need some other measure. I thought to remember the pic was
>>> refreshing t
On Mon, Aug 29, 2011 at 2:55 PM, Anthony Liguori wrote:
> This has been discussed before in the past. The special casing really makes
> no
> sense anymore. This seems like a good change to make for 1.0.
>
> Signed-off-by: Anthony Liguori
> ---
> Makefile | 5 ++---
> Makefile.target
On Mon, Aug 29, 2011 at 9:13 PM, Avi Kivity wrote:
> On 08/30/2011 12:06 AM, Jan Kiszka wrote:
>>
>> >
>> > Does this need to be save/restored for migration?
>>
>> Nope, but we need some other measure. I thought to remember the pic was
>> refreshing this after load, but I do not find any traces o
On Mon, Aug 29, 2011 at 5:57 AM, Avi Kivity wrote:
> On 08/27/2011 07:22 PM, Blue Swirl wrote:
>>
>> > +
>> > +static void test_device_irq_line(void *opaque, uint32_t addr, uint32_t
>> > data)
>> > +{
>> > + qemu_set_irq(isa_get_irq(addr - 0x2000), !!data);
>>
>> Where does 0x2000 come from
On Mon, Aug 29, 2011 at 12:51 PM, Lluís wrote:
> Stefan Hajnoczi writes:
>
>> The ability to trace from the guest can be handy, so I think we should
>> have this feature. Please add documentation on how to hook it up
>> (e.g. how people would use this for other firmware/guest code and/or
>> other
Am 30.08.2011 um 00:42 schrieb Jan Kiszka:
On 2011-08-29 23:25, Anthony Liguori wrote:
On 08/29/2011 04:23 PM, Andreas Färber wrote:
Am 29.08.2011 um 22:24 schrieb Anthony Liguori:
On 08/29/2011 03:21 PM, Andreas Färber wrote:
Am 29.08.2011 um 20:03 schrieb Anthony Liguori:
On 08/22/2011
On Wed, 10 Aug 2011 11:20:09 +0300
Alon Levy wrote:
> The following triggers a call to monitor_control_read before
> monitor_control_event has been called. This patch is misplaced but
> fixes the problem by moving the json_message_parser_init call before
> setting the chardev handlers.
>
> (echo
On Mon, Aug 29, 2011 at 12:17 PM, Stefan Hajnoczi wrote:
> On Fri, Aug 26, 2011 at 8:06 PM, Blue Swirl wrote:
>> Let guests inject tracepoint data via fw_cfg device.
>>
>> Signed-off-by: Blue Swirl
>> ---
>> The patch is used like this:
>> ../configure --with-guest-trace-file=/src/openbios-devel
Michael Roth writes:
> Hmm, looking again I'm confused why we need to do this in the first
> place...the
> rule is:
> LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o
> $@ $(1) $(LIBS)," LINK $(TARGET_DIR)$@")
> %$(EXESUF): %.o
> $(call LINK,$^)
> According to the
2011/8/29 Avi Kivity :
> On 08/26/2011 08:34 PM, Blue Swirl wrote:
>>
>> > Indeed, it isn't. It's impossible with KVM (due to lacking hardware
>> > support) but would be feasible with TCG if you extend (or ad-hoc hack)
>> > QEMU code accordingly.
>>
>> Why impossible? The existing watchpoints re
On 30.08.2011, at 19:25, Stefan Weil wrote:
> Am 30.08.2011 09:44, schrieb Kevin Wolf:
>> Am 29.08.2011 21:55, schrieb Stefan Weil:
>>> Am 29.08.2011 10:34, schrieb TeLeMan:
On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote:
> Am 28.08.2011 23:43, schrieb Blue Swirl:
>>
>> On Su
On 08/30/2011 07:57 PM, Blue Swirl wrote:
>
> +#if defined(_WIN32)
> +# define QEMU_PACKED __attribute__((gcc_struct, packed))
Maybe we could also use gcc_struct also for non-win32?
> +#else
> +# define QEMU_PACKED __attribute__((packed))
> +#endif
Indeed.
Paolo
On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote:
> A packed struct needs different gcc attributes for compilations
> with MinGW compilers because glib-2.0 adds compiler flag
> -mms-bitfields which modifies the packing algorithm.
>
> Attribute gcc_struct reverses the negative effects of -mms-bit
On Mon, Aug 29, 2011 at 4:49 AM, Brad wrote:
> Allow overriding the location of Samba's smbd.
>
> Pretty much every OS I look at has some means of
> changing this path (patching) so lets just make
> it easier for OS developers creating packages
> and/or end users to override the location.
>
> Sign
On Thu, Aug 25, 2011 at 7:29 AM, Sasha Levin wrote:
> Hello,
>
> I am looking to implement an ivshmem device for KVM tools, the purpose
> is to provide same functionality as QEMU and interoperability with QEMU.
>
> Going through the spec (I found here:
> https://gitorious.org/nahanni/guest-code/bl
Convert the tusb6010 to qdev.
Signed-off-by: Juha Riihimäki
[Riku Voipio: Fixes and restructuring patchset]
Signed-off-by: Riku Voipio
[Peter Maydell: More fixes and cleanups for upstream submission]
Signed-off-by: Peter Maydell
---
The point of this patch (apart from qdevification being a gen
Am 30.08.2011 09:44, schrieb Kevin Wolf:
Am 29.08.2011 21:55, schrieb Stefan Weil:
Am 29.08.2011 10:34, schrieb TeLeMan:
On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote:
Am 28.08.2011 23:43, schrieb Blue Swirl:
On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil
wrote:
These patches fix the pa
I use Qemu 0.15.0 (via a FreeBSD qemu-devel-0.15.0 port) and observe the
following
problem with the screendump command.
Environment:
- qemu started with a standard vga adapter emulation (not sure if this
important)
- SDL interface is used (not sure if this important)
- guest operating system us
On 08/29/2011 11:55 PM, Alex Williamson wrote:
> Thanks for the example. Is it always the case that you need a path and
> an index? If so, why are they separate sub-regions instead of combined
> into a DT_INFO sub-region?
You'll always need both. DTPATH was put into a separate subrecord
because
On Sun, Aug 28, 2011 at 05:04:32PM +0300, Avi Kivity wrote:
> On 08/28/2011 04:56 PM, Joerg Roedel wrote:
>> This can't be secured by a lock, because it introduces potential
>> A->B<-->B->A lock problem when two processes try to take each others mm.
>> It could probably be solved by a task->real_m
On Fri, Aug 26, 2011 at 12:04:22PM -0600, Alex Williamson wrote:
> On Thu, 2011-08-25 at 20:05 +0200, Joerg Roedel wrote:
> > If we really expect segment numbers that need the full 16 bit then this
> > would be the way to go. Otherwise I would prefer returning the group-id
> > directly and partiti
On 08/30/2011 10:41 AM, Peter Maydell wrote:
On 29 August 2011 15:55, Anthony Liguori wrote:
This has been discussed before in the past. The special casing really makes no
sense anymore. This seems like a good change to make for 1.0.
No issues here. Obviously it would need to be flagged up
This patch converts mpic to the new memory API (through old mmio).
Signed-off-by: Fabien Chouteau
---
hw/openpic.c | 207 ++--
hw/openpic.h |4 +-
hw/ppce500_mpc8544ds.c |2 +-
3 files changed, 114 insertions(+), 99 deletio
This patch converts mpic to the new memory API (through old mmio).
Signed-off-by: Fabien Chouteau
---
hw/openpic.c | 207 ++--
hw/openpic.h |4 +-
hw/ppce500_mpc8544ds.c |2 +-
3 files changed, 114 insertions(+), 99 deletio
On 29 August 2011 15:55, Anthony Liguori wrote:
> This has been discussed before in the past. The special casing really makes
> no
> sense anymore. This seems like a good change to make for 1.0.
No issues here. Obviously it would need to be flagged up to users,
which suggests a thought: should
Anthony Liguori wrote:
> This has been discussed before in the past. The special casing really makes
> no
> sense anymore. This seems like a good change to make for 1.0.
>
> Signed-off-by: Anthony Liguori
Acked-by: Juan Quintela
/me never liked it in the 1st place
On 08/30/2011 07:02 AM, Lluís wrote:
Stefan Hajnoczi writes:
On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth wrote:
@@ -380,7 +381,6 @@ else
trace-obj-y = trace.o
ifeq ($(TRACE_BACKEND),simple)
trace-obj-y += simpletrace.o
-user-obj-y += qemu-timer-common.o
endif
endif
Now that we
On Tue, 2011-08-30 at 17:48 +1000, David Gibson wrote:
> On Mon, Aug 29, 2011 at 10:24:43PM -0600, Alex Williamson wrote:
> > On Tue, 2011-08-30 at 13:04 +1000, David Gibson wrote:
> > > On Fri, Aug 26, 2011 at 11:05:23AM -0600, Alex Williamson wrote:
> > > >
> > > > I don't think too much has cha
On 08/30/2011 04:22 AM, Stefan Hajnoczi wrote:
On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth wrote:
@@ -380,7 +381,6 @@ else
trace-obj-y = trace.o
ifeq ($(TRACE_BACKEND),simple)
trace-obj-y += simpletrace.o
-user-obj-y += qemu-timer-common.o
endif
endif
Now that we have a concrete p
On Tue, Aug 30, 2011 at 10:28:09AM +0100, Stefan Hajnoczi wrote:
> On Tue, Aug 30, 2011 at 4:19 AM, Zhi Yong Wu wrote:
> > On Tue, Aug 23, 2011 at 8:58 PM, Stefan Hajnoczi
> > wrote:
> >> These patches put in place the image streaming QMP/HMP commands and
> >> documentation. Image streaming itse
On 08/30/2011 04:46 PM, Fabien Chouteau wrote:
Is it OK to use MemoryRegionOps.old_mmio in this case or should we avoid this
deprecated
interface?
old_mmio is fine, esp. for the initial conversion.
--
error compiling committee.c: too many arguments to function
On 30/08/2011 14:20, Avi Kivity wrote:
> On 08/29/2011 07:19 PM, Fabien Chouteau wrote:
>> This patch converts mpic to the new memory API.
>>
>> -static CPUReadMemoryFunc * const mpic_int_read[] = {
>> -&openpic_buggy_read,
>> -&openpic_buggy_read,
>> -&mpic_src_int_read,
>> -};
>> +switch (siz
Juan Quintela wrote:
> Hi
>
> Please send in any agenda items you are interested in covering.
>
> Later, Juan.
As there is no topics for agenda, today call gets cancelled.
Happy hacking, Juan.
On Tue, Aug 30, 2011 at 10:48:11AM +0200, Paolo Bonzini wrote:
> On 08/29/2011 08:49 PM, Marcelo Tosatti wrote:
> >>> -static void buffered_rate_tick(void *opaque)
> >>> +static void *migrate_vm(void *opaque)
> >>>{
> >
> >buffered_file.c was generic code that has now become migration specifi
On 08/29/2011 07:19 PM, Fabien Chouteau wrote:
This patch converts mpic to the new memory API.
-static CPUReadMemoryFunc * const mpic_int_read[] = {
-&openpic_buggy_read,
-&openpic_buggy_read,
-&mpic_src_int_read,
-};
+switch (size) {
+case 4:
+default:
+DPRINTF("Invalid
Stefan Hajnoczi writes:
> On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth
> wrote:
>> @@ -380,7 +381,6 @@ else
>> trace-obj-y = trace.o
>> ifeq ($(TRACE_BACKEND),simple)
>> trace-obj-y += simpletrace.o
>> -user-obj-y += qemu-timer-common.o
>> endif
>> endif
> Now that we have a concrete patc
On 2011-08-30 10:21, Avi Kivity wrote:
> On 08/30/2011 01:38 AM, Jan Kiszka wrote:
>> On 2011-08-29 23:15, Avi Kivity wrote:
>> > On 08/29/2011 10:14 PM, Anthony Liguori wrote:
>> >>> OK, that was simple: It's still "pflash_cfi01/pflash_cfi02:
>> convert to
>> >>> memory API".
>> >>
>> >>
>> >>
On 30 August 2011 08:00, Boris Figovsky
wrote:
> The second if statement should consider the original al register value,
> and not the new one.
Reviewed-by: Peter Maydell
(It took me some time to convince myself that the line
CF <- old_CF or (Carry from AL <- AL + 6)
in the Intel architectur
On Tue, Aug 23, 2011 at 11:33:25AM -0500, Adam Litke wrote:
> Under libvirt, I get the following error when trying to start a block
> stream:
>
> qerror: bad call in function 'do_block_stream':
> qerror: -> error format '{ 'class': 'NotSupported', 'data': {} }' not found
> qerror: call at blockdev
On Tue, Aug 30, 2011 at 4:19 AM, Zhi Yong Wu wrote:
> On Tue, Aug 23, 2011 at 8:58 PM, Stefan Hajnoczi
> wrote:
>> These patches put in place the image streaming QMP/HMP commands and
>> documentation. Image streaming itself is not implemented by this patch
>> series
>> but the HMP/QMP commands
On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth wrote:
> @@ -380,7 +381,6 @@ else
> trace-obj-y = trace.o
> ifeq ($(TRACE_BACKEND),simple)
> trace-obj-y += simpletrace.o
> -user-obj-y += qemu-timer-common.o
> endif
> endif
Now that we have a concrete patch to look at I think this approach is
p
On Tue, Aug 30, 2011 at 4:20 PM, Zhi Yong Wu wrote:
> HI, guys,
>
> Please excuse my writing mail to you. Can i consult you with several
> problems about usb-host?
>
> qemu -M pc ${otheroptions} \
> -usb \
> -devic
On 08/29/2011 08:49 PM, Marcelo Tosatti wrote:
> -static void buffered_rate_tick(void *opaque)
> +static void *migrate_vm(void *opaque)
>{
buffered_file.c was generic code that has now become migration specific
(although migration was the only user). So it should either stop
pretending to
On 08/29/2011 06:56 PM, Marcelo Tosatti wrote:
> diff --git a/cpus.c b/cpus.c
> index de70e02..f35f683 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -122,8 +122,8 @@ static void do_vm_stop(int reason)
>{
>if (vm_running) {
>cpu_disable_ticks();
> -vm_running = 0;
On Tue, Aug 30, 2011 at 4:31 PM, shu ming wrote:
> Zhi Yong Wu:
>>
>> On Tue, Aug 30, 2011 at 3:18 PM, shu ming
>> wrote:
>>>
>>> See commens below.
>>> Zhi Yong Wu:
HI, folks,
I am trying to enable block I/O throttling function in libvirt. But
currently i met some design
Zhi Yong Wu:
On Tue, Aug 30, 2011 at 3:18 PM, shu ming wrote:
See commens below.
Zhi Yong Wu:
HI, folks,
I am trying to enable block I/O throttling function in libvirt. But
currently i met some design questions, and don't make sure if we
should extend blkiotune to support block I/O throttling
Please pull from:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/core
To get a fix for rom_device memory regions:
Jan Kiszka (1):
memory: Fix memory_region_get_ram_ptr for ROM devices
memory.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
error compiling c
On 08/30/2011 01:38 AM, Jan Kiszka wrote:
On 2011-08-29 23:15, Avi Kivity wrote:
> On 08/29/2011 10:14 PM, Anthony Liguori wrote:
>>> OK, that was simple: It's still "pflash_cfi01/pflash_cfi02: convert to
>>> memory API".
>>
>>
>> Hrm, okay. Avi, maybe drop that patch and submit a v3?
>>
>
>
HI, guys,
Please excuse my writing mail to you. Can i consult you with several
problems about usb-host?
qemu -M pc ${otheroptions} \
-usb \
-device usb-ehci,id=ehci \
-device usb-
On Tue, Aug 30, 2011 at 3:18 PM, shu ming wrote:
> See commens below.
> Zhi Yong Wu:
>>
>> HI, folks,
>>
>> I am trying to enable block I/O throttling function in libvirt. But
>> currently i met some design questions, and don't make sure if we
>> should extend blkiotune to support block I/O thrott
On Mon, Aug 29, 2011 at 10:24:43PM -0600, Alex Williamson wrote:
> On Tue, 2011-08-30 at 13:04 +1000, David Gibson wrote:
> > On Fri, Aug 26, 2011 at 11:05:23AM -0600, Alex Williamson wrote:
> > >
> > > I don't think too much has changed since the previous email went out,
> > > but it seems like a
Am 30.08.2011 09:46, schrieb Frediano Ziglio:
> Add some notes about Linux AIO explaining why we don't use AIO in
> some situations.
>
> Signed-off-by: Frediano Ziglio
Thanks, applied to the block branch.
Kevin
Add some notes about Linux AIO explaining why we don't use AIO in
some situations.
Signed-off-by: Frediano Ziglio
---
block/raw-posix.c |4
linux-aio.c |1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index c5c9944..bcf
Am 29.08.2011 21:55, schrieb Stefan Weil:
> Am 29.08.2011 10:34, schrieb TeLeMan:
>> On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote:
>>> Am 28.08.2011 23:43, schrieb Blue Swirl:
On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil
wrote:
>
> These patches fix the packing of stru
See commens below.
Zhi Yong Wu:
HI, folks,
I am trying to enable block I/O throttling function in libvirt. But
currently i met some design questions, and don't make sure if we
should extend blkiotune to support block I/O throttling or introduce
one new libvirt command "blkiothrottle" to cover it
The second if statement should consider the original al register value,
and not the new one.
Signed-off-by: Boris Figovsky
---
target-i386/op_helper.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index 1bbc3b5..1f
73 matches
Mail list logo
