Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-11 Thread Zhi Yong Wu
On Fri, Aug 12, 2011 at 1:47 PM, Stefan Hajnoczi wrote: > On Fri, Aug 12, 2011 at 6:35 AM, Zhi Yong Wu wrote: >> On Tue, Aug 9, 2011 at 4:57 PM, Ram Pai wrote: >>> On Tue, Aug 09, 2011 at 12:17:51PM +0800, Zhi Yong Wu wrote: Note:       1.) When bps/iops limits are specified to a small

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting

2011-08-11 Thread Stefan Hajnoczi
On Fri, Aug 12, 2011 at 6:14 AM, Stefan Hajnoczi wrote: > This change requires that callers manage the accounting cookie.  I > think this belongs in block.c to make the life of callers easier. > > Today block.c doesn't track requests and pretty much lets the > BlockDriver control the BlockDriverAI

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-11 Thread Stefan Hajnoczi
On Fri, Aug 12, 2011 at 6:35 AM, Zhi Yong Wu wrote: > On Tue, Aug 9, 2011 at 4:57 PM, Ram Pai wrote: >> On Tue, Aug 09, 2011 at 12:17:51PM +0800, Zhi Yong Wu wrote: >>> Note: >>>       1.) When bps/iops limits are specified to a small value such as 511 >>> bytes/s, this VM will hang up. We are c

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-11 Thread Zhi Yong Wu
On Tue, Aug 9, 2011 at 4:57 PM, Ram Pai wrote: > On Tue, Aug 09, 2011 at 12:17:51PM +0800, Zhi Yong Wu wrote: >> Note: >>       1.) When bps/iops limits are specified to a small value such as 511 >> bytes/s, this VM will hang up. We are considering how to handle this senario. >>       2.) When "d

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-11 Thread Zhi Yong Wu
On Fri, Aug 12, 2011 at 1:06 PM, Stefan Hajnoczi wrote: > On Fri, Aug 12, 2011 at 6:00 AM, Zhi Yong Wu wrote: >> On Wed, Aug 10, 2011 at 7:00 PM, Stefan Hajnoczi wrote: >>> On Wed, Aug 10, 2011 at 7:57 AM, Zhi Yong Wu wrote: On Tue, Aug 9, 2011 at 11:19 PM, Stefan Hajnoczi wrote: >>

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting

2011-08-11 Thread Stefan Hajnoczi
This change requires that callers manage the accounting cookie. I think this belongs in block.c to make the life of callers easier. Today block.c doesn't track requests and pretty much lets the BlockDriver control the BlockDriverAIOCB. But the request metadata (timestamp, operation type, number

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-11 Thread Stefan Hajnoczi
On Fri, Aug 12, 2011 at 6:00 AM, Zhi Yong Wu wrote: > On Wed, Aug 10, 2011 at 7:00 PM, Stefan Hajnoczi wrote: >> On Wed, Aug 10, 2011 at 7:57 AM, Zhi Yong Wu wrote: >>> On Tue, Aug 9, 2011 at 11:19 PM, Stefan Hajnoczi wrote: On Tue, Aug 9, 2011 at 5:17 AM, Zhi Yong Wu wrote: > N

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-11 Thread Zhi Yong Wu
On Wed, Aug 10, 2011 at 7:00 PM, Stefan Hajnoczi wrote: > On Wed, Aug 10, 2011 at 7:57 AM, Zhi Yong Wu wrote: >> On Tue, Aug 9, 2011 at 11:19 PM, Stefan Hajnoczi wrote: >>> On Tue, Aug 9, 2011 at 5:17 AM, Zhi Yong Wu >>> wrote: Note:      1.) When bps/iops limits are specified to a s

Re: [Qemu-devel] [PATCH v5 2/4] block: add the block queue support

2011-08-11 Thread Stefan Hajnoczi
On Fri, Aug 12, 2011 at 5:40 AM, Zhi Yong Wu wrote: > On Wed, Aug 10, 2011 at 5:37 PM, Stefan Hajnoczi > wrote: >> On Wed, Aug 10, 2011 at 01:54:33PM +0800, Zhi Yong Wu wrote: >>> On Tue, Aug 9, 2011 at 8:49 PM, Stefan Hajnoczi wrote: >>> > On Tue, Aug 9, 2011 at 5:17 AM, Zhi Yong Wu >>> > wro

Re: [Qemu-devel] [PATCH v5 2/4] block: add the block queue support

2011-08-11 Thread Zhi Yong Wu
On Wed, Aug 10, 2011 at 5:37 PM, Stefan Hajnoczi wrote: > On Wed, Aug 10, 2011 at 01:54:33PM +0800, Zhi Yong Wu wrote: >> On Tue, Aug 9, 2011 at 8:49 PM, Stefan Hajnoczi wrote: >> > On Tue, Aug 9, 2011 at 5:17 AM, Zhi Yong Wu >> > wrote: >> >> +BlockDriverAIOCB *qemu_block_queue_enqueue(BlockQu

Re: [Qemu-devel] Fix refcounting in hugetlbfs quota handling

2011-08-11 Thread Minchan Kim
On Fri, Aug 12, 2011 at 9:48 AM, Linus Torvalds wrote: > On Wed, Aug 10, 2011 at 11:40 PM, David Gibson > wrote: >> >> This patch, therefore, stores a pointer to the inode instead of the >> address_space in the page private data for hugepages.  More >> importantly it correctly adjusts the referen

Re: [Qemu-devel] [PATCH] qdev: Remove some non-run codes in qdev_walk_children().

2011-08-11 Thread Zhi Yong Wu
On Fri, Aug 12, 2011 at 3:40 AM, Anthony Liguori wrote: > On 08/07/2011 11:15 PM, Zhi Yong Wu wrote: >> >> As you have known, qdev_reset_one() forever return a ZERO value to its >> caller, so some branches can not be forever covered in qdev_walk_children(). >> >> I thought that the return value fo

[Qemu-devel] [net-next RFC PATCH 0/7] multiqueue support for tun/tap

2011-08-11 Thread Jason Wang
Jason Wang writes: > As multi-queue nics were commonly used for high-end servers, > current single queue based tap can not satisfy the > requirement of scaling guest network performance as the > numbers of vcpus increase. So the following series > implements multiple queue support in tun/tap.

[Qemu-devel] [net-next RFC PATCH 5/7] tuntap: add ioctls to attach or detach a file form tap device

2011-08-11 Thread Jason Wang
This patch adds userspace interface for multi-queue based tap device. Two new ioctls were added. The first is TUNATTACHQUEUE which is used to attach an opened file descriptor to an existed tap device. Another is TUNDETACHQUEUE which is used to detach an file from an existed tap device, and this fil

[Qemu-devel] [net-next RFC PATCH 7/7] virtio-net changes

2011-08-11 Thread Jason Wang
From: Krishna Kumar Implement mq virtio-net driver. Though struct virtio_net_config changes, it works with the old qemu since the last element is not accessed unless qemu sets VIRTIO_NET_F_MULTIQUEUE. Signed-off-by: Krishna Kumar Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 57

[Qemu-devel] [net-next RFC PATCH 6/7] Change virtqueue structure

2011-08-11 Thread Jason Wang
From: Krishna Kumar Move queue_index from virtio_pci_vq_info to virtqueue. This allows callback handlers to figure out the queue number for the vq that needs attention. Signed-off-by: Krishna Kumar --- drivers/virtio/virtio_pci.c | 10 +++--- include/linux/virtio.h |1 + 2 file

[Qemu-devel] [net-next RFC PATCH 4/7] tuntap: multiqueue support

2011-08-11 Thread Jason Wang
With the abstraction that each socket were a backend of a queue for userspace, this patch adds multiqueue support for tap device by allowing multiple sockets to be attached to a tap device. Then we could parallize the transmission by put them into different socket. As queue related information wer

[Qemu-devel] [net-next RFC PATCH 3/7] tuntap: introduce multiqueue related flags

2011-08-11 Thread Jason Wang
Signed-off-by: Jason Wang --- include/linux/if_tun.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/if_tun.h b/include/linux/if_tun.h index 06b1829..c92a291 100644 --- a/include/linux/if_tun.h +++ b/include/linux/if_tun.h @@ -34,6 +34,7 @@ #define TUN_ONE

[Qemu-devel] [net-next RFC PATCH 2/7] tuntap: categorize ioctl

2011-08-11 Thread Jason Wang
As we've moved socket related structure to file->private_data, we can separate system calls that only touch tfile from others as they don't need hold rtnl lock. Signed-off-by: Jason Wang --- drivers/net/tun.c | 52 ++-- 1 files changed, 34 insert

[Qemu-devel] [net-next RFC PATCH 1/7] tuntap: move socket/sock related structures to tun_file

2011-08-11 Thread Jason Wang
In order to let tap can transmit packets to multiple sockets, the first step is to move all socket/sock related structures to tun_file. The reference between tap device and socket was setup during TUNSETIFF as usual. After this we can move towards the multi-queue support by allowing multiple files

[Qemu-devel] [net-next RFC PATCH 0/7] multiqueue support for tun/tap

2011-08-11 Thread Jason Wang
As multi-queue nics were commonly used for high-end servers, current single queue based tap can not satisfy the requirement of scaling guest network performance as the numbers of vcpus increase. So the following series implements multiple queue support in tun/tap. In order to take advantages of th

Re: [Qemu-devel] Fix refcounting in hugetlbfs quota handling

2011-08-11 Thread Linus Torvalds
On Wed, Aug 10, 2011 at 11:40 PM, David Gibson wrote: > > This patch, therefore, stores a pointer to the inode instead of the > address_space in the page private data for hugepages.  More > importantly it correctly adjusts the reference count on the inodes > when they're added to the page private

[Qemu-devel] [PATCH 3/3] block: latency accounting

2011-08-11 Thread Christoph Hellwig
Account the total latency for read/write/flush requests. This allows management tools to average it based on a snapshot of the nr ops counters and allow checking for SLAs or provide statistics. Signed-off-by: Christoph Hellwig Index: qemu/block.c

[Qemu-devel] [PATCH 2/3] block: explicit I/O accounting

2011-08-11 Thread Christoph Hellwig
Decouple the I/O accounting from bdrv_aio_readv/writev/flush and make the hardware models call directly into the accounting helpers. This means: - we do not count internal requests from image formats in addition to guest originating I/O - we do not double count I/O ops if the device model han

[Qemu-devel] [PATCH 1/3] block: include flush requests in info blockstats

2011-08-11 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2011-08-11 12:32:35.842658196 +0200 +++ qemu/block.c2011-08-11 16:04:48.302061893 +0200 @@ -1888,11 +1888,13 @@ static void bdrv_stats_iter(QObj

[Qemu-devel] [PATCH 0/3] better I/O accounting

2011-08-11 Thread Christoph Hellwig

[Qemu-devel] [PATCH 6/9] ppc440: Pass in address_space_mem to ppc440ep_init.

2011-08-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ppc440.c| 11 +-- hw/ppc440.h|6 +++--- hw/ppc440_bamboo.c |3 ++- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/ppc440.c b/hw/ppc440.c index 71e85ab..11933d9 100644 --- a/hw/ppc440.c +++ b/hw/ppc440.c

[Qemu-devel] [PATCH 4/9] serial: Add MemoryRegion parameter to serial_mm_init.

2011-08-11 Thread Richard Henderson
Remove the get_system_memory() call from serial_mm_init, pushing it back into the callers. In many cases we already have the system memory region available. Signed-off-by: Richard Henderson --- hw/mips_jazz.c |8 hw/mips_malta.c |4 ++-- hw/musicpal.c

[Qemu-devel] [PATCH 3/9] serial: Remove ioregister parameter from serial_mm_init.

2011-08-11 Thread Richard Henderson
All callers passed 1. Signed-off-by: Richard Henderson --- hw/mips_jazz.c |4 ++-- hw/mips_malta.c |2 +- hw/musicpal.c|4 ++-- hw/omap_uart.c |4 ++-- hw/pc.h |3 +-- hw/petalogix_ml605_mmu.c |2 +- hw/ppc405_uc.c

Re: [Qemu-devel] [PATCH] Check for presence of compiler -pthread flag

2011-08-11 Thread Brad
On Sun, Aug 07, 2011 at 08:02:11PM -0400, Brad wrote: > Check for presence of compiler -pthread flag. > > OpenBSD / FreeBSD and some other OS's require the use of > cc -pthread to link threaded programs so have QEMU's > configure script check for the presence of the flag > and use it if so. > > S

Re: [Qemu-devel] [PATCH 1/9] serial: Convert serial_mm_init to MemoryRegion.

2011-08-11 Thread Richard Henderson
>From 04288b36c9fae976e976c455e9f26ff2d7d9ada7 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Thu, 11 Aug 2011 11:39:50 -0700 Subject: [PATCH 1/9] serial: Convert serial_mm_init to MemoryRegion. Signed-off-by: Richard Henderson --- hw/serial.c | 145 +---

[Qemu-devel] [PATCH 5/9] ppc405: Pass in address_space_mem to ppc405{cr, ep}_init.

2011-08-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ppc405.h| 22 -- hw/ppc405_boards.c |8 hw/ppc405_uc.c | 30 -- 3 files changed, 32 insertions(+), 28 deletions(-) diff --git a/hw/ppc405.h b/hw/ppc405.h index f0e81a6..d8fdf09 10

[Qemu-devel] [PATCH 8/9] sm501: Pass address_space_mem to sm501_init.

2011-08-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/devices.h |6 +- hw/r2d.c |3 ++- hw/sm501.c |7 +++ 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/devices.h b/hw/devices.h index 07fda83..36c21e7 100644 --- a/hw/devices.h +++ b/hw/devices.h @@ -1,6 +1,9 @@ #

[Qemu-devel] [PATCH 7/9] pxa: Pass in address_space to pxa{255, 270}_init.

2011-08-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/gumstix.c |4 ++-- hw/mainstone.c |2 +- hw/pxa.h |7 +-- hw/pxa2xx.c| 10 +- hw/spitz.c |2 +- hw/tosa.c |2 +- hw/z2.c|2 +- 7 files changed, 16 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] [PATCH 9/9] sun4u: Pass address_space_mem to sun4uv_init.

2011-08-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/sun4u.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index 346d6d9..6739ba2 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -38,7 +38,6 @@ #include "loader.h" #include "elf.h" #include "blockdev.

[Qemu-devel] [PATCH 2/9] serial: Use enum device_endian in serial_mm_init parameter.

2011-08-11 Thread Richard Henderson
The use of DEVICE_NATIVE_ENDIAN cleans up lots of ifdefs in many of the callers. Signed-off-by: Richard Henderson --- hw/mips_jazz.c | 14 -- hw/mips_malta.c |7 ++- hw/musicpal.c| 14 ++ hw/omap_uart.c | 17 ++---

[Qemu-devel] [PATCH 0/9] Convert serial_mm_init to MemoryRegion

2011-08-11 Thread Richard Henderson
The last patch set converted the serial i/o path; this patch set converts the serial mmio path. Intermediate patches increase the use of get_system_memory(), and later patches reduce those uses again. In all but one case in the end we use the address_space_mem parameter from the original board in

[Qemu-devel] [PATCH 1/9] serial: Convert serial_mm_init to MemoryRegion.

2011-08-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/serial.c | 145 +-- 1 files changed, 31 insertions(+), 114 deletions(-) diff --git a/hw/serial.c b/hw/serial.c index 466de21..1fb9e9c 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -28,6 +28,7 @@ #in

Re: [Qemu-devel] [RFC] Planning for 1.0 (and freezing the master branch)

2011-08-11 Thread Gerd Hoffmann
Hi, In general the idea is OK. Especially soft freeze could solve problems like those qemu-ga inclusion had. Two weeks for soft freeze would be close to OK but I think a month of hard freeze is too long. With the previous releases, the problems in stable were ironed out within a week or two.

Re: [Qemu-devel] [PATCH v1.1 18/24] versatile_pci: convert to memory API

2011-08-11 Thread Peter Maydell
On 11 August 2011 17:29, Avi Kivity wrote: > -static uint32_t pci_vpb_config_readl (void *opaque, target_phys_addr_t addr) > +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr, > +                                    unsigned size) >  { >     uint32_t val; > -    val = pci_d

[Qemu-devel] Qemu aborts when emulating HelenOS/ppc

2011-08-11 Thread Jakub Jermar
Hi, When emulating HelenOS/ppc with Qemu 0.15, I get the following abort while booting the kernel: jermar@hexatonsil:~/software/HelenOS.mainline$ qemu-system-ppc -cdrom image.iso -boot d qemu: fatal: Trying to execute code outside RAM or ROM at 0x7ff97ff8 NIP 7ff97ff8 LR 00029434 CTR 7ff97ff9

[Qemu-devel] [PATCH] qcow: initialize coroutine mutex

2011-08-11 Thread Scott Wood
commit 52b8eb60132b27ad53476490e9d7579003390cfa added a mutex, but never initialized it. This caused a segfault. Reported-by: Alexander Graf Signed-off-by: Scott Wood --- block/qcow.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 64

[Qemu-devel] [PATCH 2/2] guest agent: remove uneeded dependencies

2011-08-11 Thread Michael Roth
This patch tries to cull any uneeded library dependencies from the guest agent to improve portability across various distros. We do so by being as explicit as possible about in-tree dependencies rather than relying on existing *-obj-y targets, and by manually setting LIBS for the qemu-ga target to

[Qemu-devel] [PATCH 1/2] guest agent: remove g_strcmp0 usage

2011-08-11 Thread Michael Roth
g_strcmp0 isn't in all version of glib 2.0, so don't use it to avoid build breakage on older distros. Signed-off-by: Michael Roth --- qemu-ga.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index 869ee37..e6ccc21 100644 --- a/qemu-ga.c +++ b/qemu

[Qemu-devel] [PATCH] qapi: fix build issue due to missing newline in generated header

2011-08-11 Thread Michael Roth
Fixes a build issue on RHEL5, and potentially other distros, where gcc will generate an error due to us not writing a trailing "\n" when generating *qmp-commands.h Signed-off-by: Michael Roth --- scripts/qapi-commands.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/s

Re: [Qemu-devel] [PATCH] monitor: fix build breakage for !CONFIG_VNC

2011-08-11 Thread Luiz Capitulino
On Wed, 10 Aug 2011 15:18:42 +0100 Jamie Iles wrote: > Commit c62f6d1 (monitor: fix build breakage with --disable-vnc) > conditionalised some VNC setup code but left an unused variable. Move > the variable into the conditional code to fix the build breakage. > > Cc: Luiz Capitulino > Cc: Marku

[Qemu-devel] difference between 'preallocation=metadata' and 'preallocation=full'

2011-08-11 Thread Kashyap Chamarthy
Hi, Is there a difference between the below two invocations of 'qemu-img' -- I/O performance wise for QCOW2 disk image? 1/ qemu-img create -f qcow2 -o preallocation=metadata /var/lib/libvirt/images/fedora15.qcow2 8G 2/ qemu-img create -f qcow2 -o preallocation=full /var/lib/libvirt/images/fedo

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Stefan Hajnoczi
On Thu, Aug 11, 2011 at 4:27 PM, Paolo Bonzini wrote: > On 08/11/2011 05:12 PM, Kevin Wolf wrote: >>> >>> >  Another possibility is always completing DMA in a bottom half.  This >>> >  ensures that the callback can access the AIOCB, but it exposes an >>> >  implementation detail to the caller, so

Re: [Qemu-devel] [PATCH] qdev: Remove some non-run codes in qdev_walk_children().

2011-08-11 Thread Anthony Liguori
On 08/07/2011 11:15 PM, Zhi Yong Wu wrote: As you have known, qdev_reset_one() forever return a ZERO value to its caller, so some branches can not be forever covered in qdev_walk_children(). I thought that the return value for dev->info->reset(dev) can be returned, but dev->info->reset(dev) is

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
On Thu, 11 Aug 2011, Avi Kivity wrote: Or maybe it's just -O2 screwing up debug information. Please change ./configure to set -O1 and redo. Please print *r.memory as well. ./configure --target-list=x86_64-softmmu,i386-softmmu --enable-debug Rest below. Ciao, Gerhard -- http://www.wiesinger

[Qemu-devel] [Bug 824716] [NEW] linux-user broken for targets with TARGET_ABI32 (i.e. qemu-sparc32plus)

2011-08-11 Thread Matthias Braun
Public bug reported: I just debugged a problem I had with linux-user for qemu-sparc32plus. Turns out that sparc32plus is defined as a 64bit target with TARGET_ABI32 set. This correctly leads to abi_ulong (and others) being defined as uint32_t. However most of the code (in syscall.c) uses tswapl fo

Re: [Qemu-devel] [RFC] Planning for 1.0 (and freezing the master branch)

2011-08-11 Thread Anthony Liguori
On 08/11/2011 12:30 PM, Blue Swirl wrote: On Thu, Aug 11, 2011 at 1:46 PM, Anthony Liguori wrote: Hi, I've posted an initial proposal for the 1.0 release on the wiki[1]. The release would be targeted for December 1st. Unlike previous releases, I'm proposing that instead of forking master int

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Richard Henderson
On 08/11/2011 09:38 AM, Blue Swirl wrote: > On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity wrote: >> On 08/11/2011 03:36 PM, Alexander Graf wrote: >>> Or to have automatic generation of the optionals based on the primitives, if the optionals are not present. >>> >>> That's what's hap

[Qemu-devel] [PATCH v1.1 18/24] versatile_pci: convert to memory API

2011-08-11 Thread Avi Kivity
Signed-off-by: Avi Kivity --- v1.1: fix bogus 'return size', thanks to Peter Maydell hw/versatile_pci.c | 92 --- 1 files changed, 43 insertions(+), 49 deletions(-) diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c index e1d5c0b..98e56f1 100

Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:20 PM, Peter Maydell wrote: On 8 August 2011 18:07, Avi Kivity wrote: > -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr) > +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr, > +unsigned

Re: [Qemu-devel] [PATCH 1/2] pflash: Support read-only mode

2011-08-11 Thread Jordan Justen
On Thu, Jul 28, 2011 at 14:05, Jordan Justen wrote: > On Thu, Jul 28, 2011 at 11:26, Jan Kiszka wrote: >> On 2011-07-27 17:38, Jordan Justen wrote: >>> On Wed, Jul 27, 2011 at 02:30, Jan Kiszka wrote: On 2011-07-25 23:34, Jordan Justen wrote: > Read-only mode is indicated by bdrv_is_rea

Re: [Qemu-devel] [RFC] Planning for 1.0 (and freezing the master branch)

2011-08-11 Thread Blue Swirl
On Thu, Aug 11, 2011 at 1:46 PM, Anthony Liguori wrote: > Hi, > > I've posted an initial proposal for the 1.0 release on the wiki[1]. > > The release would be targeted for December 1st.  Unlike previous releases, > I'm proposing that instead of forking master into a stable branch and > releasing f

Re: [Qemu-devel] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-11 Thread Eric Blake
On 08/11/2011 08:11 AM, Kevin Wolf wrote: I agree with you. It feels a bit backwards for snapshots, but it's really the only reasonable thing to do if you're using external snapshots. That you can't rename block devices is actually a very point point, too. There's one more point to consider: If

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-11 Thread Andrea Arcangeli
Hello everyone, so basically this is a tradeoff between not having a long latency for the migration to succeed and reducing the total network traffic (and CPU load) in the migration source and destination and reducing the memory footprint a bit, by adding an initial latency to the memory accesses

[Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-08-11 Thread Nigel Horne
Public bug reported: The latest git version of qemu (commit 8cc7c3952d4d0a681d8d4c3ac89a206a5bfd7f00) crashes after a few minutes. All was fine up to a few days ago. This is wth both x86 and sparc emulation, on an x86_64 host. e.g. qemu-system-sparc -drive file=netbsd5.0.2-sparc,index=0,media=di

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Blue Swirl
On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity wrote: > On 08/11/2011 03:36 PM, Alexander Graf wrote: >> >> > >> >  Or to have automatic generation of the optionals based on the >> > primitives, if the optionals are not present. >> >> That's what's happening in the background already, no? The line i

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-08-11 Thread Corey Bryant
On 07/26/2011 08:51 AM, Corey Bryant wrote: > +static int raw_open_fd(BlockDriverState *bs, const char *filename, int flags) > +{ > +BDRVRawState *s = bs->opaque; > +const char *fd_str; > +int fd; > + > +/* extract the file descriptor - fail if it's not fd: */ > +if (!strs

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:20 PM, Avi Kivity wrote: On 08/11/2011 07:08 PM, Gerhard Wiesinger wrote: (gdb) frame 4 #4 0x0041eb9b in pci_update_mappings (d=0x1a90bc0) at /root/download/qemu/git/qemu-kvm-test/hw/pci.c:1134 1134memory_region_del_subregion(r->address_space, r->m

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-11 Thread Blue Swirl
On Thu, Aug 11, 2011 at 7:37 AM, Kevin Wolf wrote: > Am 10.08.2011 19:20, schrieb Blue Swirl: >> On Wed, Aug 10, 2011 at 7:58 AM, Kevin Wolf wrote: >>> Am 09.08.2011 21:39, schrieb Blue Swirl: On Tue, Aug 9, 2011 at 12:24 PM, Kevin Wolf wrote: > Am 09.08.2011 14:00, schrieb Stefan Hajno

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:08 PM, Gerhard Wiesinger wrote: (gdb) frame 4 #4 0x0041eb9b in pci_update_mappings (d=0x1a90bc0) at /root/download/qemu/git/qemu-kvm-test/hw/pci.c:1134 1134memory_region_del_subregion(r->address_space, r->memory); (gdb) print i $1 = (gdb) print *r

Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API

2011-08-11 Thread Peter Maydell
On 8 August 2011 18:07, Avi Kivity wrote: > -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr) > +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr, > +                                    unsigned size) >  { >     uint32_t val; > -    val = pci_da

[Qemu-devel] [PULL] [PATCHSET 1] VirtFS coroutine changes

2011-08-11 Thread Aneesh Kumar K.V
On Mon, 8 Aug 2011 22:33:48 +0530, "Aneesh Kumar K.V" wrote: > Full patchset is available at > > git://repo.or.cz/qemu/v9fs.git for-upstream-1 > > -aneesh Here is the updated pull request. I folded few patches based on the review. But there are no code changes. The following changes since c

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:11 PM, Gerhard Wiesinger wrote: On Thu, 11 Aug 2011, Avi Kivity wrote: This should be faster today with really new kernels (the problem is not in qemu) but I'm not sure if it's fast enough. What's a "really new" kernel? In which version were performance optimizations done? (C

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
On Thu, 11 Aug 2011, Avi Kivity wrote: This should be faster today with really new kernels (the problem is not in qemu) but I'm not sure if it's fast enough. What's a "really new" kernel? In which version were performance optimizations done? (Currently I'm using 2.6.34.7, hadn't time yet to u

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
On Thu, 11 Aug 2011, Avi Kivity wrote: On 08/11/2011 12:01 PM, Gerhard Wiesinger wrote: Hello Avi, #0 0x003a060328f5 in raise () from /lib64/libc.so.6 #1 0x003a060340d5 in abort () from /lib64/libc.so.6 #2 0x003a0602b8b5 in __assert_fail () from /lib64/libc.so.6 #3 0x00

[Qemu-devel] sparc32_dma: correctly initialize ledma base address

2011-08-11 Thread Bob Breuer
The ledma base address defaults to 0xff00 on reset. This fixes a bug with Solaris and SS-20 OBP when boot net is skipped. Signed-off-by: Bob Breuer --- diff --git a/hw/sparc32_dma.c b/hw/sparc32_dma.c index e75694b..61812fb 100644 --- a/hw/sparc32_dma.c +++ b/hw/sparc32_dma.c @@ -252,6 +252

Re: [Qemu-devel] [PATCHSET 2] VirtFS coroutine changes

2011-08-11 Thread Aneesh Kumar K.V
On Mon, 8 Aug 2011 22:36:27 +0530, "Aneesh Kumar K.V" wrote: > Full patchset is available at > > git://repo.or.cz/qemu/v9fs.git for-upstream-1 > > -aneesh > > Any update on this. I updated the for-upstream-1 branch with changes to fold few patches. But there are no code changes. -aneesh

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 05:12 PM, Kevin Wolf wrote: > Another possibility is always completing DMA in a bottom half. This > ensures that the callback can access the AIOCB, but it exposes an > implementation detail to the caller, so I don't like it. At least in the block layer, AIO callbacks may never

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Avi Kivity
On 08/11/2011 05:58 PM, Richard Henderson wrote: On 08/11/2011 12:48 AM, Avi Kivity wrote: > If we're going to work on this in parallel, we'd better coordinate. > Right now I'm going though all files the contain qemu_ram_alloc > alphabetically and converting them (now in 'O'). If anyone wants

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Kevin Wolf
Am 11.08.2011 17:05, schrieb Paolo Bonzini: > On 08/11/2011 04:37 PM, Kevin Wolf wrote: >>> Right, I would rather update BlockDriverCompletionFunc to pass the AIOCB >>> as a third parameter, and store the residual bytes in the DMAAIOCB (with >>> a getter that the completion function can use). >>

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 04:37 PM, Kevin Wolf wrote: > Right, I would rather update BlockDriverCompletionFunc to pass the AIOCB > as a third parameter, and store the residual bytes in the DMAAIOCB (with > a getter that the completion function can use). Isn't the DMAAIOCB already passed as opaque to the

Re: [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA

2011-08-11 Thread Richard Henderson
On 08/11/2011 12:48 AM, Avi Kivity wrote: > If we're going to work on this in parallel, we'd better coordinate. > Right now I'm going though all files the contain qemu_ram_alloc > alphabetically and converting them (now in 'O'). If anyone wants a > letter, let me know. I've been looking at files

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Kevin Wolf
Am 11.08.2011 16:24, schrieb Paolo Bonzini: > On 08/11/2011 03:29 PM, Stefan Hajnoczi wrote: What do you think about passing the residual bytes for short transfers? Should I look into updating BlockDriverCompletionFunc, or is the approach of patch 2 okay? If I have a

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 04:24 PM, Peter Maydell wrote: I cannot think off-hand of a reason why thread-local cpu_single_env should not work for iothread under Unix, BTW. Since cpu_single_env is only set/used by a thread at a time (under the global lock), its users cannot distinguish between a thread-local

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Peter Maydell
On 11 August 2011 15:10, Paolo Bonzini wrote: > On 08/11/2011 03:31 PM, Peter Maydell wrote: Then it's a compiler bug, not smartness.  Making env volatile (or making a volatile copy if there is a performance impact) should still be enough to work around it. >> >> Yes. (It would

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 03:29 PM, Stefan Hajnoczi wrote: > > What do you think about passing the residual bytes for short transfers? >Should I look into updating BlockDriverCompletionFunc, or is the approach > of patch 2 okay? If I have an excuse to learn more about Coccinelle, that > can be fun.:)

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread David Gilbert
On 11 August 2011 15:10, Paolo Bonzini wrote: > I'm not sure about what to read from there: > >> If I make cpu_single_env thread local with __thread and leave >> 0d101... in, then again it works reliably on 32bit Lucid, and is >> flaky on 64 bit Oneiric (5/10 2 hangs, 3 segs) >> >> I've also trie

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 03:31 PM, Peter Maydell wrote: Then it's a compiler bug, not smartness. Making env volatile (or making a volatile copy if there is a performance impact) should still be enough to work around it. Yes. (It would have to be a volatile copy, I think, env is a function parameter and I

Re: [Qemu-devel] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-11 Thread Kevin Wolf
[ CCed qemu-devel, just in case someone's interested ] Am 11.08.2011 15:23, schrieb Eric Blake: >> [ Okay, some of it is handled later in this document, but I think it's >> still useful to leave this summary in my mail. External VM state is >> something that you don't seem to have covered yet - ca

[Qemu-devel] [RFC] Planning for 1.0 (and freezing the master branch)

2011-08-11 Thread Anthony Liguori
Hi, I've posted an initial proposal for the 1.0 release on the wiki[1]. The release would be targeted for December 1st. Unlike previous releases, I'm proposing that instead of forking master into a stable branch and releasing from there, we stop taking features into master and all work on st

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Peter Maydell
On 11 August 2011 14:13, Paolo Bonzini wrote: > On 08/11/2011 02:40 PM, Peter Maydell wrote: >> We don't change env between the setjmp and longjmp so the compiler >> should not trash it. (Indeed according to Jan in >> http://lists.gnu.org/archive/html/qemu-devel/2011-07/msg00144.html >> -Wclobbere

Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

2011-08-11 Thread Stefan Hajnoczi
On Thu, Aug 11, 2011 at 1:10 PM, Paolo Bonzini wrote: > On 08/11/2011 09:58 AM, Stefan Hajnoczi wrote: >> >> On Thu, Aug 04, 2011 at 07:14:43PM +0200, Paolo Bonzini wrote: >>> >>> These helpers do a full transfer from an in-memory buffer to >>> target memory, with full support for MMIO areas.  It

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 02:40 PM, Peter Maydell wrote: "All accessible objects have values [...] as of the time the longjmp function was called, except that the values of objects of automatic storage duration that are local to the function containing the invocation of the corresponding setjmp macro that do

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Anthony Liguori
On 08/11/2011 03:17 AM, Avi Kivity wrote: 3) a management tool should be able to query the source and destination, and then enable xzbrle if both sides support it. You can argue that (3) could be static. A command could be added to toggle it dynamically through the monitor. But no matter what,

[Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2011-08-11 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/521994 Title: Windows 98 doesn't detect mouse on qemu and SeaBIOS. Statu

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-11 Thread Anthony Liguori
On 08/11/2011 03:03 AM, Shribman, Aidan wrote: From: Anthony Liguori [mailto:anth...@codemonkey.ws] Sent: Wednesday, August 10, 2011 10:28 PM To: Avi Kivity Cc: Blue Swirl; Stefan Hajnoczi; Shribman, Aidan; qemu-devel Developers; libvir-l...@redhat.com Subject: Re: [Qemu-devel] [PATCH v4] XBZRLE

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Avi Kivity
On 08/11/2011 03:36 PM, Alexander Graf wrote: > > Or to have automatic generation of the optionals based on the primitives, if the optionals are not present. That's what's happening in the background already, no? The line is towards tcg users though, not it tcg internal code. Yes, and it d

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-08-11 Thread Peter Maydell
On 11 August 2011 13:16, Paolo Bonzini wrote: > On 08/11/2011 01:30 PM, Peter Maydell wrote: >> Can you give more details of what compiler/platform this was >> a problem for? My reading of the C standard is that the compiler >> isn't allowed to trash env across this longjmp, because it's >> a vari

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Alexander Graf
On 11.08.2011, at 14:28, Avi Kivity wrote: > On 08/11/2011 02:40 PM, Alexander Graf wrote: >> On 11.08.2011, at 13:24, malc wrote: >> >> > On Thu, 11 Aug 2011, Alexander Graf wrote: >> > >> >> While compiling current HEAD on a ppc64 box, I was confronted with the >> >> following compile error

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Avi Kivity
On 08/11/2011 02:40 PM, Alexander Graf wrote: On 11.08.2011, at 13:24, malc wrote: > On Thu, 11 Aug 2011, Alexander Graf wrote: > >> While compiling current HEAD on a ppc64 box, I was confronted with the >> following compile errors: >> >> tcg/optimize.c: In function ?tcg_constant_folding?:

[Qemu-devel] [PATCH 3/5] usb-redir: Call qemu_chr_guest_open/close

2011-08-11 Thread Hans de Goede
To let the chardev now we're ready start receiving data. This is necessary with the spicevmc chardev to get it registered with the spice-server. Signed-off-by: Hans de Goede --- usb-redir.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/usb-redir.c b/usb-redir.c index

[Qemu-devel] [PATCH 4/5] usb-redir: Device disconnect + re-connect robustness fixes

2011-08-11 Thread Hans de Goede
These fixes mainly target the other side sending some (error status) packets after a disconnect packet. In some cases these would get queued up and then reported to the controller when a new device gets connected. * Fully reset device state on disconnect * Don't allow a connect message when alread

[Qemu-devel] [PATCH 5/5] usb-redir: Don't try to write to the chardev after a close event

2011-08-11 Thread Hans de Goede
Sicne we handle close async in a bh, do_write and thus write can get called after receiving a close event. This patch adds a check to the usb-redir write callback to not do a qemu_chr_write on a closed chardev. Signed-off-by: Hans de Goede --- usb-redir.c |2 +- 1 files changed, 1 insertions

[Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public

2011-08-11 Thread Hans de Goede
Make qemu_chr_event public so that it can be used by chardev code which lives outside of qemu-char.c Signed-off-by: Hans de Goede --- qemu-char.c |2 +- qemu-char.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 8d39500..5d5a6d5 10064

[Qemu-devel] [PATCH 2/5] spice-qemu-char: Generate chardev open/close events

2011-08-11 Thread Hans de Goede
Define a state callback and make that generate chardev open/close events when called by the spice-server. Note that for all but the newest spice-server versions (which have a fix for this) the code ignores these events for a spicevmc with a subtype of vdagent, this subtype specific knowledge is un

  1   2   >