Re: [Qemu-devel] [PATCH] xen: fix xen-mapcache build on non-Xen capable targets

2011-07-22 Thread Blue Swirl
On Sat, Jul 23, 2011 at 3:07 AM, Alexander Graf wrote: > Great. Thanks. Instead of just pulling my xen-next tree which had an > outstanding pull request for days now you apply Avi's patch which obviously > conflicts with my current queue, so I have to rebase it again. Your patch carried the tre

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-22 Thread Clint Byrum
Jeff thanks for the testing! I'll take that as verification.. marking verification-done. It just needs to wait 7 days to clear -proposed in case it causes any unintended regressions. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification beca

Re: [Qemu-devel] [PATCH] guest-agent: fix build with OpenBSD

2011-07-22 Thread Blue Swirl
On Fri, Jul 22, 2011 at 10:15 PM, Anthony Liguori wrote: > FS-Freeze only works with Linux. > > Signed-off-by: Anthony Liguori ACK except for the unrelated stuff. It's strange how the messages arrive several hours out of order. > --- >  Makefile                   |    2 + >  hw/pc.c          

[Qemu-devel] [PATCH] add QEMU_LD_PREFIX environment variable

2011-07-22 Thread josch
From: Johannes Schauer Hi, qemu allows to specify the elf interpreter prefix with the -L option. When using qemu user mode emulation through the binfmt mechanism, it is not possible to pass any commandline arguments to qemu. Having qemu evaluate an environment variable makes it possible to still

[Qemu-devel] [PATCH] add QEMU_LD_PREFIX environment variable

2011-07-22 Thread josch
From: Johannes Schauer Signed-off-by: Johannes Schauer --- linux-user/main.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 289054b..b590aa7 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -2891,6 +2891,11 @@ i

[Qemu-devel] [PATCH] .gitignore: ignore qemu-ga and qapi-generated

2011-07-22 Thread Alexandre Raymond
Add a new binary and generation directory to the gitignore file Signed-off-by: Alexandre Raymond --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 08013fc..54835bc 100644 --- a/.gitignore +++ b/.gitignore @@ -15,6 +15,7 @@ libd

Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup & fixes

2011-07-22 Thread Amit Shah
On (Wed) 20 Jul 2011 [18:23:34], Markus Armbruster wrote: > This patch series looks bigger than it is. All the patches are small > and hopefully easy to review. > > Objectives: > > * Push BlockDriverState members locked, tray_open, media_changed into > device models, where they belong. > > *

Re: [Qemu-devel] [PATCH 5/7] balloon: Separate out stat and balloon handling

2011-07-22 Thread Amit Shah
On (Fri) 22 Jul 2011 [16:45:55], Markus Armbruster wrote: > Amit Shah writes: > > > Passing on '0' as ballooning target to indicate retrieval of stats is > > bad API. It also makes 'balloon 0' in the monitor cause a segfault. > > Have two different functions handle the different functionality in

[Qemu-devel] [PATCH 2/2] SPARC64: implement %fprs dirty bits

2011-07-22 Thread Tsuneo Saito
Implement %fprs.DU/DL bits. The FPU sets %fprs.DL and %fprs.DU when values are assigned to %f0-31 and %f32-63 respectively. Signed-off-by: Tsuneo Saito --- target-sparc/translate.c | 116 ++ 1 files changed, 116 insertions(+), 0 deletions(-) diff --g

[Qemu-devel] [PATCH 1/2] SPARC64: fix fnor* and fnand*

2011-07-22 Thread Tsuneo Saito
Fix the problem that result values are not assigned to the destination registers. Signed-off-by: Tsuneo Saito --- target-sparc/translate.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 15967c5..f68b

[Qemu-devel] [PATCH 0/2] SPARC64: implement %fprs register dirty bits

2011-07-22 Thread Tsuneo Saito
Implement %fprs.DU/DL bits. The FPU sets %fprs.DL and %fprs.DU when values are assigned to %f0-31 and %f32-63 respectively. The first patch fixes problems that are found when adding the lines for fprs and would be better to be fixed before adding the fprs thing. Tsuneo Saito (2): SPARC64: fix fn

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-22 Thread Jeff Snider
Tested 0.12.3+noroms-0ubuntu9.14 on Lucid amd64 with all available updates. Save speed is now approx 3 seconds for a 256Mb guest. Tested virsh with start, stop, save, restore, suspend, resume, shutdown, destroy. Tested guest with smp, virtio disk, virtio net, vnc display. Everything worked as ex

Re: [Qemu-devel] [PATCH] xen: fix xen-mapcache build on non-Xen capable targets

2011-07-22 Thread Alexander Graf
Great. Thanks. Instead of just pulling my xen-next tree which had an outstanding pull request for days now you apply Avi's patch which obviously conflicts with my current queue, so I have to rebase it again. Not everyone is as privileged as you. Some of us have to wait for Anthony or someone el

Re: [Qemu-devel] [PATCH] Let users select their pythons

2011-07-22 Thread Brad
On 22/07/11 5:10 PM, Blue Swirl wrote: Add configure check for python, exit if not found. Add switches for specifying the path to python, use the path in Makefile. Signed-off-by: Blue Swirl Thanks. This does the trick. -- This message has been scanned for viruses and dangerous content by Mail

[Qemu-devel] [PATCH] guest-agent: fix build with OpenBSD

2011-07-22 Thread Anthony Liguori
FS-Freeze only works with Linux. Signed-off-by: Anthony Liguori --- Makefile |2 + hw/pc.c|3 +- qemu-char.c| 36 + qemu-config.c |6 qga/guest-agent-commands.c | 63 ++

[Qemu-devel] qemu 0.12 monitor command syntax and interface

2011-07-22 Thread Vinay Venkataraghavan
Hi all, I am implementing a generic interface that supports qemu versions 0.9 to 0.12. As a result I have been trying to get the syntax for the monitor commands for various qemu versions. I have scrounged all over but have not been able to find the syntax for the device_add interface which is

Re: [Qemu-devel] [PATCH] darwin-user: Remove two unused variables

2011-07-22 Thread Stefan Weil
Am 22.07.2011 22:48, schrieb Andreas Färber: Hi Stefan W., Am 20.07.2011 um 21:40 schrieb Stefan Weil: cppcheck report: darwin-user/signal.c:322: style: Unused variable: i darwin-user/signal.c:322: style: Variable 'err' is assigned a value that is never used Does this really bug you? I'm a

[Qemu-devel] [PATCH] guest agent: use QERR_UNSUPPORTED for disabled RPCs

2011-07-22 Thread Michael Roth
--- qga/guest-agent-commands.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qga/guest-agent-commands.c b/qga/guest-agent-commands.c index e215bd3..624972e 100644 --- a/qga/guest-agent-commands.c +++ b/qga/guest-agent-commands.c @@ -521,7 +521,7 @@ static void guest

Re: [Qemu-devel] [PATCH] qga: fsfreeze is only supported on Linux

2011-07-22 Thread Blue Swirl
On Fri, Jul 22, 2011 at 10:18 PM, Anthony Liguori wrote: > On 07/22/2011 01:56 PM, Blue Swirl wrote: >> >> Fix build breakage on non-Linux hosts. >> >> Signed-off-by: Blue Swirl > > The patch I sent was similar but QAPI commands don't use in-band error > reporting so it set the out-of-band error.

[Qemu-devel] [PATCH] Let users select their pythons

2011-07-22 Thread Blue Swirl
Add configure check for python, exit if not found. Add switches for specifying the path to python, use the path in Makefile. Signed-off-by: Blue Swirl --- Makefile | 12 ++-- configure | 13 + 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/Makefile b/Mak

Re: [Qemu-devel] qemu-user[armel/mips] and debian-rootfs

2011-07-22 Thread Lisandro Damián Nicanor Pérez Meyer
On Mar 12 Jul 2011 11:23:40 riku voipio escribió: > Hi Wesley [snip] > For whatever reason I was unable to apply your patches directly, so I > had to recreate them. > > I've rolled your patches to: > > http://git.linaro.org/gitweb?p=people/rikuvoipio/qemu.git;a=shortlog;h=refs > /heads/linux-use

Re: [Qemu-devel] [PATCH] darwin-user: Remove two unused variables

2011-07-22 Thread Andreas Färber
Hi Stefan W., Am 20.07.2011 um 21:40 schrieb Stefan Weil: cppcheck report: darwin-user/signal.c:322: style: Unused variable: i darwin-user/signal.c:322: style: Variable 'err' is assigned a value that is never used Does this really bug you? I'm a bit skeptical towards trying to fix warnings

Re: [Qemu-devel] [PATCH] m68k: Add uc5282 machine

2011-07-22 Thread Andreas Färber
Hello, Am 20.07.2011 um 19:10 schrieb Joel Sherrill: From: Till Straumann Add m68k machine support for Arcturus Networks Inc. uC5282 board. Also include a fix for the FEC ethernet controller. Please submit this as a series of patches, with independent issues addressed in separate patc

[Qemu-devel] [RFC PATCH 2/2] separate thread for VM migration

2011-07-22 Thread Umesh Deshapnde
From: Umesh Deshpande This patch creates a separate thread for the guest migration on the source side. The migration routine is called from the migration clock. Signed-off-by: Umesh Deshpande --- arch_init.c | 14 ++-- buffered_file.c | 12 ++ exec.c |4

[Qemu-devel] [RFC PATCH 1/2] new clock for migration routine

2011-07-22 Thread Umesh Deshapnde
From: Umesh Deshpande This patch implements a migration clock, whose implementation is similar to the existing rt_clock. This allows the migration timer to run in parallel to other timers in the rt_clock. In the next patch, this clock is used to create a new timer from the migration thread that c

[Qemu-devel] [RFC PATCH 0/2] A separate thread for VM migration

2011-07-22 Thread Umesh Deshapnde
From: Umesh Deshpande Following patch deals with VCPU and iothread starvation during the migration of a guest. Currently the iothread is responsible for performing the guest migration. It holds qemu_mutex during the migration and doesn't allow VCPU to enter the qemu mode and delays its return to

Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup

2011-07-22 Thread Frediano Ziglio
Il giorno ven, 22/07/2011 alle 12.10 +0200, Kevin Wolf ha scritto: > Am 22.07.2011 11:26, schrieb Frediano Ziglio: > > 2011/7/22 Kevin Wolf : > >> Am 20.07.2011 15:56, schrieb Frediano Ziglio: > >>> These patches mostly cleanup some AIO code using coroutines. > >>> These patches apply to Kevin's r

Re: [Qemu-devel] [PATCH] guest-agent: fix build with OpenBSD

2011-07-22 Thread Anthony Liguori
On 07/22/2011 02:42 PM, Anthony Liguori wrote: On 07/22/2011 02:15 PM, Anthony Liguori wrote: FS-Freeze only works with Linux. Signed-off-by: Anthony Liguori --- Makefile | 2 + hw/pc.c | 3 +- qemu-char.c | 36 + qemu-config.c | 6 qga/guest-agent-commands.c | 63 +

Re: [Qemu-devel] [PATCH] guest-agent: fix build with OpenBSD

2011-07-22 Thread Anthony Liguori
On 07/22/2011 02:15 PM, Anthony Liguori wrote: FS-Freeze only works with Linux. Signed-off-by: Anthony Liguori --- Makefile |2 + hw/pc.c|3 +- qemu-char.c| 36 + qemu-config.c |6

Re: [Qemu-devel] [PATCH] qga: fsfreeze is only supported on Linux

2011-07-22 Thread Anthony Liguori
On 07/22/2011 01:56 PM, Blue Swirl wrote: Fix build breakage on non-Linux hosts. Signed-off-by: Blue Swirl The patch I sent was similar but QAPI commands don't use in-band error reporting so it set the out-of-band error. I'll push my version if you can confirm it addresses the build issue.

Re: [Qemu-devel] [PATCH] qga: fsfreeze is only supported on Linux

2011-07-22 Thread Luiz Capitulino
On Fri, 22 Jul 2011 21:56:39 +0300 Blue Swirl wrote: > Fix build breakage on non-Linux hosts. > > Signed-off-by: Blue Swirl Looks good to me. This will return a command not found error, maybe unsupported is better, but can be done later. > --- > qga/guest-agent-commands.c | 25 +++

Re: [Qemu-devel] Guest agent does not build on OpenBSD

2011-07-22 Thread Anthony Liguori
On 07/22/2011 02:00 PM, Brad wrote: On 22/07/11 2:28 PM, Blue Swirl wrote: I get these errors on OpenBSD: CC qga/guest-agent-commands.o /src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such file or directory /src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No suc

Re: [Qemu-devel] Guest agent does not build on OpenBSD

2011-07-22 Thread Brad
On 22/07/11 2:28 PM, Blue Swirl wrote: I get these errors on OpenBSD: CCqga/guest-agent-commands.o /src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such file or directory /src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No such file or directory In file inc

[Qemu-devel] [PATCH] qga: fsfreeze is only supported on Linux

2011-07-22 Thread Blue Swirl
Fix build breakage on non-Linux hosts. Signed-off-by: Blue Swirl --- qga/guest-agent-commands.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/qga/guest-agent-commands.c b/qga/guest-agent-commands.c index 8c0d67e..918aaa2 100644 --- a/qga/guest-

Re: [Qemu-devel] [PATCH] xen: fix xen-mapcache build on non-Xen capable targets

2011-07-22 Thread Blue Swirl
Thanks, applied. On Wed, Jul 20, 2011 at 12:14 PM, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- >  xen-mapcache.h |   32 >  1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/xen-mapcache.h b/xen-mapcache.h > index 606b8af..da874ca 100644 >

[Qemu-devel] Guest agent does not build on OpenBSD

2011-07-22 Thread Blue Swirl
I get these errors on OpenBSD: CCqga/guest-agent-commands.o /src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such file or directory /src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No such file or directory In file included from /src/qemu/qga/guest-agent-comma

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-22 Thread Clint Byrum
Hello Chris, or anyone else affected, Accepted qemu-kvm into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Re: [Qemu-devel] [RFC] qcow2: 2 way to improve performance updating refcount

2011-07-22 Thread Stefan Hajnoczi
On Fri, Jul 22, 2011 at 3:21 PM, Frediano Ziglio wrote: > 2011/7/22 Stefan Hajnoczi : >> On Fri, Jul 22, 2011 at 10:13 AM, Frediano Ziglio wrote: >>> 2011/7/22 Kevin Wolf : Am 21.07.2011 18:17, schrieb Frediano Ziglio: > Hi, >   after a snapshot is taken currently many write operatio

Re: [Qemu-devel] [PATCH 06/23] PPC: Fix IPI support in MPIC

2011-07-22 Thread Scott Wood
On Fri, 22 Jul 2011 17:01:11 +0200 Alexander Graf wrote: > On 22.07.2011, at 16:08, Elie Richa wrote: > > > > #if MAX_IPI > 0 > > > case 0x40: /* IDE */ > > > case 0x50: > > > idx = (addr - 0x40) >> 4; > > > retval = read_IRQreg(opp, opp->irq_ipi0 + idx, IRQ_IDE); > > >

[Qemu-devel] [PATCH 1/3] hw/pl110: Model the PL111 CLCD controller

2011-07-22 Thread Peter Maydell
Model the PL111 CLCD controller. This is a minor variation on the PL110; the major programmer visible differences are support for hardware cursor (unimplemented) and two new pixel formats. Since syborg_fb.c borrows the pl11x pixel drawing routines, we also update it to cope with the new slightly l

[Qemu-devel] [PATCH 3/3] vexpress, realview: Use pl111, not pl110

2011-07-22 Thread Peter Maydell
The Versatile Express, Realview EB, PBX A9 and PB A8 boards all use a PL111 for their graphics, not a PL110. Now we model the PL111, use it on these board models. Signed-off-by: Peter Maydell --- hw/realview.c |2 +- hw/vexpress.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 0/3] Add PL111, implement PL110 BGR mode

2011-07-22 Thread Peter Maydell
This patch series improves the emulation of the PL11x CLCD controllers used by the various ARM dev boards. vexpress-a9, realview-eb, realview-eb-mpcore, realview-pb-a8 and realview-pbx-a9 should all have a PL111, not a PL110; the PL111 implements two extra pixel formats. (I haven't implemented the

Re: [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Blue Swirl
On Fri, Jul 22, 2011 at 11:11 AM, Kevin Wolf wrote: > Am 22.07.2011 09:36, schrieb Avi Kivity: >> On 07/20/2011 04:51 PM, Kevin Wolf wrote:  The problem is that QEMU will find backing file file names inside the  images which it will be unable to open. How do you suggest we get aroun

Re: [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Blue Swirl
On Fri, Jul 22, 2011 at 12:11 PM, Stefan Hajnoczi wrote: > On Fri, Jul 22, 2011 at 8:22 AM, Kevin Wolf wrote: >> Am 21.07.2011 17:01, schrieb Stefan Hajnoczi: >>> On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake wrote: Thank you for persisting - you've found another hole that needs to be pl

[Qemu-devel] [PATCH] PPC: Fix sync instructions problem in SMP

2011-07-22 Thread Elie Richa
In the current emulation of the load-and-reserve (lwarx) and store-conditional (stwcx.) instructions, the internal reservation mechanism is taken into account, however each CPU has its own reservation information and this information is not synchronized between CPUs to perform proper synchronizatio

[Qemu-devel] [PATCH 2/3] versatilepb: Implement SYS_CLCD mux control register bits

2011-07-22 Thread Peter Maydell
On the Versatile PB, PL110 graphics adaptor only natively supports 5551 pixel format; an external mux swaps bits around to allow RGB565 and BGR565, under the control of bits [1:0] in the SYS_CLCD system register. Implement these SYS_CLCD register bits, and use a gpio line to feed them out of the s

Re: [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Blue Swirl
On Fri, Jul 22, 2011 at 8:06 AM, Stefan Hajnoczi wrote: > On Thu, Jul 21, 2011 at 8:42 PM, Blue Swirl wrote: >> On Thu, Jul 21, 2011 at 6:01 PM, Stefan Hajnoczi wrote: >>> On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake wrote: Thank you for persisting - you've found another hole that needs to

Re: [Qemu-devel] [PATCH] target-sparc: Fix compiler errors (format strings)

2011-07-22 Thread Blue Swirl
Thanks, applied. I also didn't notice the build breakage but it looks like I also ran my tests with some old version, sorry. On Fri, Jul 22, 2011 at 8:44 AM, Stefan Weil wrote: > This change is needed because commit 06e12b65 > now uses an unsigned long long value > (uint64_t && unsigned long lon

Re: [Qemu-devel] [PATCH 09/55] block: Don't let locked flag prevent medium load

2011-07-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 20.07.2011 18:23, schrieb Markus Armbruster: >> Commit aea2a33c made bdrv_eject() obey the locked flag. Correct for >> medium eject (eject_flag set), incorrect for medium load (eject_flag >> clear). See MMC-5 Table 341 "Actions for Lock/Unlock/Eject". >> >> Signed-off-b

[Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 104 +++- 1 files changed, 103 insertions(+), 1 deletions(-) diff --git a/hw/scs

[Qemu-devel] [PULL] libcacard AFE support and bug fixes

2011-07-22 Thread Alon Levy
Hi, Please pull fixes for AFE smart cards, cleanup and missing frees by Robert Relyea and Christophe Fergeau. Thanks. The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06: SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +)

[Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-22 Thread Hannes Reinecke
Instead of using its own definitions scsi-disk should be using the device type of the parent device. Signed-off-by: Hannes Reinecke --- hw/scsi-defs.h |6 +- hw/scsi-disk.c | 48 2 files changed, 29 insertions(+), 25 deletions(-) diff -

Re: [Qemu-devel] [PATCH 08/55] block: Make BlockDriver method bdrv_eject() return void

2011-07-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 20.07.2011 18:23, schrieb Markus Armbruster: >> Callees always return 0, except for FreeBSD's cdrom_eject(), which >> returns -ENOTSUP when the device is in a terminally wedged state. >> >> The only caller is bdrv_eject(), and it maps -ENOTSUP to 0 since >> commit 4be9762

Re: [Qemu-devel] [PATCH 08/23] PPC: Bump MPIC up to 32 supported CPUs

2011-07-22 Thread Alexander Graf
On 22.07.2011, at 16:10, Elie Richa wrote: > > On 07/21/2011 03:27 AM, Alexander Graf wrote: >> @@ -1288,7 +1288,7 @@ static void mpic_reset (void *opaque) >> >> mpp->glbc = 0x8000; >> /* Initialise controller registers */ >> -mpp->frep = 0x004f0002; >> +mpp->frep = 0x004f

Re: [Qemu-devel] [PATCH 06/23] PPC: Fix IPI support in MPIC

2011-07-22 Thread Alexander Graf
Hi :) On 22.07.2011, at 16:08, Elie Richa wrote: > Hello. > > I have been working on SMP support for the MPC8641D processor, so I have also > worked on completing the SMP implementation of MPIC. I've been meaning to > post a patch, but you beat me to it :) Ah, very nice! It's great to see mor

[Qemu-devel] [PATCH 2/6] scsi: Remove references to SET_WINDOW

2011-07-22 Thread Hannes Reinecke
SET_WINDOW command is vendor-specific only. So we shouldn't try to emulate it. Signed-off-by: Hannes Reinecke --- hw/scsi-bus.c |2 -- hw/scsi-defs.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 8b1a412..facc98d 100644 --- a/hw

[Qemu-devel] [PATCH 4/6] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
Sanitize SCSI command definitions. Add _10 suffix to READ_CAPACITY, WRITE_VERIFY, VERIFY, READ_LONG, WRITE_LONG, and WRITE_SAME. Add new command definitions for LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT, COMPARE_AND_WR

[Qemu-devel] [PATCH 3/6] scsi: Remove REZERO_UNIT emulation

2011-07-22 Thread Hannes Reinecke
REZERO_UNIT command is obsolete. Remove support for it. Signed-off-by: Hannes Reinecke --- hw/scsi-bus.c |3 --- hw/scsi-defs.h |1 - hw/scsi-disk.c |7 --- 3 files changed, 0 insertions(+), 11 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index facc98d..52a6784 10064

[Qemu-devel] [PATCH 1/6] scsi-disk: Codingstyle fixes

2011-07-22 Thread Hannes Reinecke
Replace tabs with spaces. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 05d14ab..910d3b5 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -526,7 +526,7 @@ static i

[Qemu-devel] [PATCH 0/6][v2] Check for supported SCSI commands

2011-07-22 Thread Hannes Reinecke
Markus Armbruster pointed out that not every SCSI command is supported for a given device type. Based on his patch and suggestiongs this series cleans up the SCSI device type and adds a check for supported commands. Hannes Reinecke (6): scsi-disk: Codingstyle fixes scsi: Remove references to S

Re: [Qemu-devel] [PATCH 09/55] block: Don't let locked flag prevent medium load

2011-07-22 Thread Kevin Wolf
Am 20.07.2011 18:23, schrieb Markus Armbruster: > Commit aea2a33c made bdrv_eject() obey the locked flag. Correct for > medium eject (eject_flag set), incorrect for medium load (eject_flag > clear). See MMC-5 Table 341 "Actions for Lock/Unlock/Eject". > > Signed-off-by: Markus Armbruster SCSI

Re: [Qemu-devel] [PATCH 5/7] balloon: Separate out stat and balloon handling

2011-07-22 Thread Markus Armbruster
Amit Shah writes: > Passing on '0' as ballooning target to indicate retrieval of stats is > bad API. It also makes 'balloon 0' in the monitor cause a segfault. > Have two different functions handle the different functionality instead. > > Reported-by: Mike Cao > Signed-off-by: Amit Shah Can y

Re: [Qemu-devel] [PATCH 08/55] block: Make BlockDriver method bdrv_eject() return void

2011-07-22 Thread Kevin Wolf
Am 20.07.2011 18:23, schrieb Markus Armbruster: > Callees always return 0, except for FreeBSD's cdrom_eject(), which > returns -ENOTSUP when the device is in a terminally wedged state. > > The only caller is bdrv_eject(), and it maps -ENOTSUP to 0 since > commit 4be9762a. > > Signed-off-by: Marku

Re: [Qemu-devel] [PATCH 07/55] block: Make BlockDriver method bdrv_set_locked() return void

2011-07-22 Thread Kevin Wolf
Am 21.07.2011 17:07, schrieb Markus Armbruster: > Luiz Capitulino writes: > >> On Wed, 20 Jul 2011 18:23:41 +0200 >> Markus Armbruster wrote: >> >>> The only caller is bdrv_set_locked(), and it ignores the value. >>> >>> Callees always return 0, except for FreeBSD's cdrom_set_locked(), >>> which

Re: [Qemu-devel] [PULL] non-migratable devices

2011-07-22 Thread Gerd Hoffmann
Hi, vmstate: complain about devices without vmstate I appreciate the sentiment of this patch but this cannot go into 0.15. Peter Maydell noted that too, thats why there already is a migration.2 branch with this patch dropped which you can pull instead. I'm not really sure this is total

Re: [Qemu-devel] [PATCH 00/10] [RESEND] Various net and slirp fixes & enhancements

2011-07-22 Thread Markus Armbruster
Jan Kiszka writes: > Almost just a reposting of the previously sent series. No patch > modified, but a nifty (IMO) new one: ping forwarding for slirp using > the unprivileged ICMP sockets of Linux 3.0. See commit log for a simple > how-to. My positive review of the previous version of 07-10 (pos

Re: [Qemu-devel] [PULL] non-migratable devices

2011-07-22 Thread Anthony Liguori
On 07/20/2011 05:09 AM, Gerd Hoffmann wrote: Hi, This patch series adds an easy way to tag devices as non-migratable and puts it into use for ahci, ehci and a number of usb devices. cheers, Gerd The following changes since commit 03ff09580ef6cbc4a893b6e3e6bbff33180ec70a: Merge remote

Re: [Qemu-devel] [RFC] qcow2: 2 way to improve performance updating refcount

2011-07-22 Thread Frediano Ziglio
2011/7/22 Stefan Hajnoczi : > On Fri, Jul 22, 2011 at 10:13 AM, Frediano Ziglio wrote: >> 2011/7/22 Kevin Wolf : >>> Am 21.07.2011 18:17, schrieb Frediano Ziglio: Hi,   after a snapshot is taken currently many write operations are quite slow due to - refcount updates (decrement

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
On 07/22/2011 04:09 PM, Markus Armbruster wrote: Hannes Reinecke writes: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke Commit message says "patch adds", patch only deletes. Looks like something w

Re: [Qemu-devel] [PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
On 07/22/2011 04:07 PM, Markus Armbruster wrote: Hannes Reinecke writes: Adding some missing command definitions and update the existing ones. No functional change. Add: LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT

Re: [Qemu-devel] [PATCH 08/23] PPC: Bump MPIC up to 32 supported CPUs

2011-07-22 Thread Elie Richa
On 07/21/2011 03:27 AM, Alexander Graf wrote: @@ -1288,7 +1288,7 @@ static void mpic_reset (void *opaque) mpp->glbc = 0x8000; /* Initialise controller registers */ -mpp->frep = 0x004f0002; +mpp->frep = 0x004f0002 | ((MAX_CPU - 1)<< 8); Should we really report the maxi

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Markus Armbruster
Hannes Reinecke writes: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke Commit message says "patch adds", patch only deletes. Looks like something wrent wrong with 2/3 and 3/3.

Re: [Qemu-devel] [PATCH 06/23] PPC: Fix IPI support in MPIC

2011-07-22 Thread Elie Richa
Hello. I have been working on SMP support for the MPC8641D processor, so I have also worked on completing the SMP implementation of MPIC. I've been meaning to post a patch, but you beat me to it :) I compared your implementation to mine, and it boils down to the same, except that I had overloo

Re: [Qemu-devel] [PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Markus Armbruster
Hannes Reinecke writes: > Adding some missing command definitions and update the existing ones. > No functional change. Add: LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT, COMPARE_AND_WRITE, VERIFY_16, SYNCHRONIZE_CACHE

Re: [Qemu-devel] [RFC] QEMU Object Model

2011-07-22 Thread Anthony Liguori
On 07/22/2011 08:15 AM, Kevin Wolf wrote: Am 22.07.2011 14:40, schrieb Anthony Liguori: On 07/22/2011 02:46 AM, Kevin Wolf wrote: Am 21.07.2011 18:32, schrieb Anthony Liguori: Just as we're now realizing that we need to do dramatic things in the block layer to make -blockdev work, I'm sure we'

Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup

2011-07-22 Thread Gerd Hoffmann
Hi, git send-email --to='maintainer@domain' --cc='qemu-devel@nongnu.org' outgoing/* It is a good idea to make the last argument "outgoing/0*.patch", otherwise you risk to send out the "-cover-letter.patch~" editor backup file ... Otherwise the procedure looks fine. cheers, Gerd

Re: [Qemu-devel] [PATCH V3] e1000: Handle IO Port.

2011-07-22 Thread Anthony PERARD
On Tue, Jul 19, 2011 at 14:41, Juan Quintela wrote: > Anthony PERARD wrote: >> This patch introduces the two IOPorts on e1000, IOADDR and IODATA. The >> IOADDR is used to specify which register we want to access when we read >> or write on IODATA. >> >> This patch fixes some weird behavior that I

Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup

2011-07-22 Thread Kevin Wolf
Am 22.07.2011 15:24, schrieb Frediano Ziglio: > 2011/7/22 Stefan Hajnoczi : >> On Fri, Jul 22, 2011 at 11:10 AM, Kevin Wolf wrote: >>> Am 22.07.2011 11:26, schrieb Frediano Ziglio: - you can use scripts/checkpatch.pl to check your patches before send >> >> I updated the SubmitAPatch wiki earl

Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup

2011-07-22 Thread Frediano Ziglio
2011/7/22 Stefan Hajnoczi : > On Fri, Jul 22, 2011 at 11:10 AM, Kevin Wolf wrote: >> Am 22.07.2011 11:26, schrieb Frediano Ziglio: >>> - you can use scripts/checkpatch.pl to check your patches before send > > I updated the SubmitAPatch wiki earlier this week. > > Stefan > Good, now wiki is workin

Re: [Qemu-devel] [RFC] QEMU Object Model

2011-07-22 Thread Kevin Wolf
Am 22.07.2011 14:40, schrieb Anthony Liguori: > On 07/22/2011 02:46 AM, Kevin Wolf wrote: >> Am 21.07.2011 18:32, schrieb Anthony Liguori: >>> Just as we're now realizing that we need to do dramatic things in the >>> block layer to make -blockdev work, I'm sure we're going to realize that >>> we wa

Re: [Qemu-devel] [RFC] QEMU Object Model

2011-07-22 Thread Anthony Liguori
On 07/22/2011 02:46 AM, Kevin Wolf wrote: Am 21.07.2011 18:32, schrieb Anthony Liguori: Just as we're now realizing that we need to do dramatic things in the block layer to make -blockdev work, I'm sure we're going to realize that we want to do PCI hotplug of virtio-serial and therefore we need

Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3)

2011-07-22 Thread Gerd Hoffmann
ACK. Another option would be to not call the state callback for the vdagent subtype from spice-server, because like you say it ignores the continued communication between the agent and the server. Then you could remove the subtype check. We can even #ifdef the check using SPICE_SERVER_VERSION o

[Qemu-devel] [PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 102 1 files changed, 0 insertions(+), 102 deletions(-) diff --git a/hw/scs

[Qemu-devel] [PATCH 2/3] scsi-disk: Remove drive_kind

2011-07-22 Thread Hannes Reinecke
Instead of using our own type structure we can be using the SCSI type from the parent device. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 156 ++-- 1 files changed, 129 insertions(+), 27 deletions(-) diff --git a/hw/scsi-disk.c b/hw/s

[Qemu-devel] [PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
Adding some missing command definitions and update the existing ones. No functional change. Signed-off-by: Hannes Reinecke --- hw/scsi-bus.c | 71 ++-- hw/scsi-defs.h| 60 hw/scsi-disk.c|

[Qemu-devel] [PATCH 0/3] Check for supported SCSI commands

2011-07-22 Thread Hannes Reinecke
Markus Armbruster pointed out that not every SCSI command is supported for a given device type. Based on his patch this series cleans up the SCSI device type and adds a check for supported commands. Hannes Reinecke (3): scsi: Sanitize command definitions scsi-disk: Remove drive_kind scsi-dis

[Qemu-devel] [PATCH 4/4] USB: add usb network redirection support

2011-07-22 Thread Gerd Hoffmann
From: Hans de Goede This patch adds support for a usb-redir device, which takes a chardev as a communication channel to an actual usbdevice using the usbredir protocol. Compiling the usb-redir device requires usbredir-0.3 to be installed for the usbredir protocol parser, usbredir-0.3 also contai

Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3)

2011-07-22 Thread Alon Levy
On Fri, Jul 22, 2011 at 11:40:55AM +0200, Hans de Goede wrote: > Define a state callback and make that generate chardev open/close events when > called by the spice-server. Note the code ignores these events for a spicevmc > with a subtypem of vdagent, this subtype specific knowledge is undesirable

[Qemu-devel] [PULL v2] usb patch queue for 0.15

2011-07-22 Thread Gerd Hoffmann
Hi, Here comes the updated usb patch queue for 0.15. It is rebased to latest master, gained one more bugfix and usb network redirection support, so it is now four patches instead of two. Adding usb network redirection support doesn't fall into bugfixing, but as it just adds a new driver and th

[Qemu-devel] [PATCH 2/4] usb-uhci: fix irq handling on error.

2011-07-22 Thread Gerd Hoffmann
Spec on UHCI_STS_USBERR: "If the TD on which the error interrupt occurred also had its IOC bit set, both this bit and Bit 0 are set." Make UHCI emulation do that. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-

Re: [Qemu-devel] [PATCHv4 0/4] libcacard fixes

2011-07-22 Thread Alon Levy
On Fri, Jul 22, 2011 at 01:42:16PM +0200, Christophe Fergeau wrote: > Hi, > I'll add all of these to the pull request, thanks. > This is a resend of my series of libcacard fixes, with the correct patches > this > time. > > Changes since v3: > - the series now includes the intended patches >

[Qemu-devel] [PATCH 3/4] usb-ehci: trace: rename "next" to "nxt".

2011-07-22 Thread Gerd Hoffmann
"next" is reserved in systemtap thus using this as a trace parameter name causes trouble when trying to trace with systemtap. Signed-off-by: Gerd Hoffmann --- trace-events |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/trace-events b/trace-events index 99a4a2b..713

[Qemu-devel] [PATCH 1/4] usb-hid: fixup changed tracking.

2011-07-22 Thread Gerd Hoffmann
Remove leftover calls to usb_hid_changed(). Take care to update the changed flag after delivering a event via GET_REPORT like we do when sending events via interrupt endpoint. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH] libcacard: don't leak vcard_emul_alloc_arrays mem

2011-07-22 Thread Alon Levy
On Fri, Jul 22, 2011 at 01:30:49PM +0200, Christophe Fergeau wrote: > Ping? > I'll pick it up in my pull request. > On Mon, Jul 04, 2011 at 06:10:43PM +0200, Christophe Fergeau wrote: > > vcard_emul_mirror_card and vcard_emul_init use > > vcard_emul_alloc_arrays to allocate memory for temporary

Re: [Qemu-devel] [PATCHv3 0/4] libcacard fixes

2011-07-22 Thread Christophe Fergeau
On Fri, Jul 22, 2011 at 01:33:26PM +0200, Christophe Fergeau wrote: > This is a resend of my series of libcacard fixes, no change since last > version apart from the added "Reviewed-by" tag. Scratch that, I put the wrong patches in the series (which strongly indicates that I should merge libcacard

[Qemu-devel] [PATCHv4 1/4] libcacard: s/strip(args++)/strip(args+1)

2011-07-22 Thread Christophe Fergeau
vcard_emul_options used args = strip(args++) a few times, which was not returning the expected result since the rest of the code expected args to be increased by at least 1, which is not the case if *args is not a blank space when this function is called. Replace these calls by "strip(args+1)" whic

[Qemu-devel] [PATCHv4 2/4] libcacard: fix soft=... parsing in vcard_emul_options

2011-07-22 Thread Christophe Fergeau
The previous parser had copy and paste errors when computing vname_length and type_params_length, "name" was used instead of respectively vname and type_params. This led to length that could be bigger than the input string, and to access out of the array bounds when trying to copy these strings. va

[Qemu-devel] [PATCHv4 4/4] libcacard: replace copy_string with strndup

2011-07-22 Thread Christophe Fergeau
copy_string reimplements strndup, this commit removes it and replaces all copy_string uses with strndup. Signed-off-by: Christophe Fergeau Reviewed-by: Alon Levy --- libcacard/vcard_emul_nss.c | 23 ++- 1 files changed, 6 insertions(+), 17 deletions(-) diff --git a/libcac

[Qemu-devel] [PATCHv4 3/4] libcacard: introduce NEXT_TOKEN macro

2011-07-22 Thread Christophe Fergeau
vcard_emul_options now has repetitive code to read the current token and advance to the next. After the previous changes, this repetitive code can be moved in a NEXT_TOKEN macro to avoid having this code duplicated. Signed-off-by: Christophe Fergeau Reviewed-by: Alon Levy --- libcacard/vcard_em

[Qemu-devel] [PATCHv4 0/4] libcacard fixes

2011-07-22 Thread Christophe Fergeau
Hi, This is a resend of my series of libcacard fixes, with the correct patches this time. Changes since v3: - the series now includes the intended patches Changes since v2: - added Reviewed-by: Alon Levy to the 4 patches Changes since v1: - split first patch into 3 patches, v1 2/2 is unchanged

  1   2   >