Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread tsnsaito
Hi, At Wed, 13 Jul 2011 19:34:10 +0300, Blue Swirl wrote: > On Wed, Jul 13, 2011 at 3:48 PM, wrote: > > At Wed, 13 Jul 2011 13:09:28 +0100, > > Mark Cave-Ayland wrote: > >> >> Nice series! > >> >> May I ask what have you used as a test case to discover the problem? > >> > > >> > I found the prob

Re: [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6

2011-07-13 Thread Zhi Yong Wu
HI, Michael, On Tue, Jul 5, 2011 at 9:21 PM, Michael Roth wrote: > This is Set 3/3 of the QAPI+QGA patchsets. > > These patches apply on top of qapi-backport-set2-v5, and can also be obtained > from: > git://repo.or.cz/qemu/mdroth.git qapi-backport-set3-v6 > > (Set1+2 are a backport of some of t

[Qemu-devel] [RFC] New thread for the VM migration

2011-07-13 Thread Umesh Deshpande
Following patch is implemented to deal with the VCPU and iothread starvation during the migration of a guest. Currently iothread is responsible for performing the migration. It holds the qemu_mutex during the migration and doesn't allow VCPU to enter the qemu mode and delays its return to the gu

Re: [Qemu-devel] [PATCH 1/4] SPARC64: Implement ldfa/lddfa/ldqfa instructions properly

2011-07-13 Thread tsnsaito
Hi, At Wed, 13 Jul 2011 21:19:16 +0300, Blue Swirl wrote: > On Wed, Jul 13, 2011 at 9:02 PM, Artyom Tarasenko wrote: > > On Wed, Jul 13, 2011 at 6:27 PM, Blue Swirl wrote: > >> On Wed, Jul 13, 2011 at 6:30 AM, Tsuneo Saito wrote: > >>So you should perform some arithmetic with > >> the ASI numbe

Re: [Qemu-devel] [PATCH v2] usb-hid: Fix 0/0 position for Windows in tablet mode

2011-07-13 Thread Andreas Färber
Am 12.07.2011 um 09:47 schrieb Jan Kiszka: On 2011-07-04 20:15, andrzej zaborowski wrote: On 26 June 2011 11:11, Jan Kiszka wrote: On 2011-06-25 15:10, Andreas Färber wrote: Am 25.06.2011 um 14:55 schrieb Jan Kiszka: On 2011-06-25 14:37, Andreas Färber wrote: Am 24.06.2011 um 16:27 schrie

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Stefan Weil
Am 13.07.2011 18:27, schrieb Luiz Capitulino: On Wed, 13 Jul 2011 16:04:52 +0100 Peter Maydell wrote: On 13 July 2011 15:23, Luiz Capitulino wrote: diff --git a/compiler.h b/compiler.h new file mode 100644 index 000..2dfc2c6 --- /dev/null +++ b/compiler.h @@ -0,0 +1,31 @@ +#ifndef COMPIL

[Qemu-devel] [PATCH v2] Fix unassigned memory access handling

2011-07-13 Thread Blue Swirl
cea5f9a28faa528b6b1b117c9ab2d8828f473fef exposed bugs in unassigned memory access handling. Fix them by always passing CPUState to the handlers. Reported-by: Hervé Poussineau Signed-off-by: Blue Swirl --- v2: don't try to restore env since all targets eventually always call cpu_loop_exit() which

Re: [Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v6

2011-07-13 Thread Michael Roth
On 07/13/2011 01:52 PM, Luiz Capitulino wrote: On Tue, 12 Jul 2011 18:39:26 -0500 Michael Roth wrote: This is Set 2/3 of the QAPI+QGA patchsets. These patches apply on top of master (set1 merged), and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qapi-backport-set2-v6 This loo

Re: [Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v6

2011-07-13 Thread Luiz Capitulino
On Tue, 12 Jul 2011 18:39:26 -0500 Michael Roth wrote: > This is Set 2/3 of the QAPI+QGA patchsets. > > These patches apply on top of master (set1 merged), and can also be obtained > from: > git://repo.or.cz/qemu/mdroth.git qapi-backport-set2-v6 This looks good to me and I've queued it. But I d

Re: [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6

2011-07-13 Thread Michael Roth
On 07/13/2011 08:14 AM, Daniel P. Berrange wrote: On Tue, Jul 05, 2011 at 08:21:36AM -0500, Michael Roth wrote: BUILD/USAGE build: ./configure --target-list=x86_64-softmmu make make qemu-ga #should be built on|for target guest start guest: qemu \ -drive file=/home/mdroth/vm/rhel

Re: [Qemu-devel] [PATCH 1/4] SPARC64: Implement ldfa/lddfa/ldqfa instructions properly

2011-07-13 Thread Blue Swirl
On Wed, Jul 13, 2011 at 9:02 PM, Artyom Tarasenko wrote: > On Wed, Jul 13, 2011 at 6:27 PM, Blue Swirl wrote: >> On Wed, Jul 13, 2011 at 6:30 AM, Tsuneo Saito wrote: >>> This patch implements sparcv9 ldfa/lddfa/ldqfa instructions >>> with non block-load ASIs. >>> >>> Signed-off-by: Tsuneo Saito

Re: [Qemu-devel] [PATCH 1/4] SPARC64: Implement ldfa/lddfa/ldqfa instructions properly

2011-07-13 Thread Artyom Tarasenko
On Wed, Jul 13, 2011 at 6:27 PM, Blue Swirl wrote: > On Wed, Jul 13, 2011 at 6:30 AM, Tsuneo Saito wrote: >> This patch implements sparcv9 ldfa/lddfa/ldqfa instructions >> with non block-load ASIs. >> >> Signed-off-by: Tsuneo Saito >> --- >>  target-sparc/op_helper.c |   16 +++- >>  

Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread Blue Swirl
On Wed, Jul 13, 2011 at 3:48 PM, wrote: > Hi, > > At Wed, 13 Jul 2011 13:09:28 +0100, > Mark Cave-Ayland wrote: >> >> Nice series! >> >> May I ask what have you used as a test case to discover the problem? >> > >> > I found the problem when I was trying to run the linux/sparc64 kernel. >> > It se

Re: [Qemu-devel] [PATCH 1/4] SPARC64: Implement ldfa/lddfa/ldqfa instructions properly

2011-07-13 Thread Blue Swirl
On Wed, Jul 13, 2011 at 6:30 AM, Tsuneo Saito wrote: > This patch implements sparcv9 ldfa/lddfa/ldqfa instructions > with non block-load ASIs. > > Signed-off-by: Tsuneo Saito > --- >  target-sparc/op_helper.c |   16 +++- >  1 files changed, 11 insertions(+), 5 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 16:04:52 +0100 Peter Maydell wrote: > On 13 July 2011 15:23, Luiz Capitulino wrote: > > diff --git a/compiler.h b/compiler.h > > new file mode 100644 > > index 000..2dfc2c6 > > --- /dev/null > > +++ b/compiler.h > > @@ -0,0 +1,31 @@ > > +#ifndef COMPILER_H > > +#define CO

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 18:37:31 +0400 (MSD) malc wrote: > On Wed, 13 Jul 2011, Luiz Capitulino wrote: > > > From: Luiz Capitulino > > > > This moves compiler related macros from qemu-common.h to compiler.h. > > > > The reason for this change is that there are simple header files that > > depend

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread malc
On Wed, 13 Jul 2011, Luiz Capitulino wrote: > On Wed, 13 Jul 2011 18:37:31 +0400 (MSD) > malc wrote: > > > On Wed, 13 Jul 2011, Luiz Capitulino wrote: > > > > > From: Luiz Capitulino > > > > > > This moves compiler related macros from qemu-common.h to compiler.h. > > > > > > The reason for t

[Qemu-devel] [PATCHv4 10/11] qxl: only disallow specific io's in vga mode

2011-07-13 Thread Alon Levy
Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. Signed-off-by: Alon Levy --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b34e8d0..5ea4c76 100644 --- a/hw/qxl.c +++ b/hw

[Qemu-devel] [PATCHv4 11/11] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support

2011-07-13 Thread Alon Levy
Add two new IOs. QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change (windows driver implementation is such that this is done on each of those occasions). QXL_IO_FLUSH_RELEASE - used to ensure

[Qemu-devel] [PATCHv4 03/11] qxl: remove qxl_destroy_primary()

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann We'll have to move qemu_spice_destroy_primary_surface() out of qxl_destroy_primary(). That makes the function pretty pointless, so zap it and open code the two lines instead. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c|4 +- hw/qxl.c | 95 +

[Qemu-devel] [PATCHv4 00/11] async + suspend reworked

2011-07-13 Thread Alon Levy
v3->v4 changes: * drop all qxl-render changes, it will still use sync update_area. This means: 1. running with vnc and spice together can still trigger lockup with libvirt due to [vcpu block on pipe; worker wait for pipe release; iothread blocked because vcpu holding mutex] and client side

[Qemu-devel] [PATCHv4 07/11] qxl: make qxl_guest_bug take variable arguments

2011-07-13 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 19 --- hw/qxl.h |2 +- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3d1f108..34a5f78 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -124,11 +124,15 @@ static void qxl_reset_memslots(PCIQXLDevice *

[Qemu-devel] [PATCHv4 01/11] spice: add worker wrapper functions.

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann Add wrapper functions for all spice worker calls. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c|4 +- hw/qxl.c | 32 +- ui/spice-display.c | 95 --- ui/spice-display.h | 22 ++

[Qemu-devel] [PATCHv4 09/11] qxl: use QXL_REVISION_*

2011-07-13 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 252 +++- hw/qxl.h | 15 +++- ui/spice-display.c | 46 -- ui/spice-display.h | 25 +- 4 files changed, 282 insertions(+), 56 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.

[Qemu-devel] [PATCHv4 04/11] qxl: fix surface tracking & locking

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann Surface tracking needs proper locking since it is used from vcpu and spice worker threads, add it. Also reset the surface counter when zapping all surfaces. Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 13 - hw/qxl.h |2 ++ 2 files changed, 14 insertions(+

[Qemu-devel] [PATCH 11/15] mips: rlimit incorrectly converts values

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra Byte swap was applied in the wrong order with testing for RLIM_INFINITY. On mips bigendian from an amd64 system this results in infinity being misinterpretted as 2^31-1. This is a serious bug because it causes setrlimit stack size to kill all child processes. This means

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Peter Maydell
On 13 July 2011 15:23, Luiz Capitulino wrote: > diff --git a/compiler.h b/compiler.h > new file mode 100644 > index 000..2dfc2c6 > --- /dev/null > +++ b/compiler.h > @@ -0,0 +1,31 @@ > +#ifndef COMPILER_H > +#define COMPILER_H If we don't have a rule that says that all new source files should

[Qemu-devel] [PATCHv4 06/11] qxl: error handling fixes and cleanups.

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann Add qxl_guest_bug() function which is supposed to be called in case sanity checks of guest requests fail. It raises an error IRQ and logs a message in case guest debugging is enabled. Make PANIC_ON() abort instead of exit. That macro should be used for qemu bugs only, any g

[Qemu-devel] [PATCHv4 02/11] spice: add qemu_spice_display_init_common

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann Factor out SimpleSpiceDisplay initialization into qemu_spice_display_init_common() and call it from both qxl.c (for vga mode) and spice-display.c Signed-off-by: Gerd Hoffmann --- hw/qxl.c |7 +-- ui/spice-display.c | 17 +++-- ui/spice-displa

[Qemu-devel] [PATCH 05/15] linux-user: Add syscall numbers from kernel 2.6.39.2

2011-07-13 Thread riku . voipio
From: Peter Maydell Add syscall numbers for new syscall numbers; this brings us into line with Linux 2.6.39.2. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/alpha/syscall_nr.h | 23 ++- linux-user/arm/syscall_nr.h| 13 +

[Qemu-devel] [PATCHv4 05/11] qxl: add io_port_to_string

2011-07-13 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 61 - 1 files changed, 60 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e41f8cc..2ecc932 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -408,6 +408,64 @@ static const char *qxl_m

[Qemu-devel] [PATCH 12/15] mips: rlimit codes are not the same

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra The codes for get/setrlimit differ between linux target platforms. This patch adds conversion. This is important else programs (rsyslog, python, ...) can go into a near infinite loop trying to close all the file descriptors from 0 to -1. Signed-off-by: Wesley W. Terpstra

[Qemu-devel] [PATCHv4 08/11] qxl: bump pci rev

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann Inform guest drivers about the new features I/O commands we have now (async commands, S3 support) if building with newer spice, i.e. if SPICE_INTERFACE_QXL_MINOR >= 1. Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 25 ++--- hw/qxl.h |6 ++ 2 file

[Qemu-devel] [PATCH 04/15] linux-user: Add support for even more FB ioctls

2011-07-13 Thread riku . voipio
From: Cédric VINCENT This patch was validated with programs from DirectFB-1.0 and WebKit/DirectFB. Signed-off-by: Cédric VINCENT Cc: Riku Voipio Signed-off-by: Riku Voipio --- linux-user/ioctls.h|5 + linux-user/syscall_defs.h |5 + linux-user/syscall_types.h | 13

[Qemu-devel] [PATCH 14/15] linux-user: make MIPS and ARM eabi use same argument reordering

2011-07-13 Thread riku . voipio
From: Riku Voipio MIPS uses similar calling convention than ARM eabi, where when using 64-bit values some registers are skipped. This patch makes MIPS and ARM eabi share the argument reordering code. This affects ftruncate64, creating insane sized fails (or just failing). Cc: Wesley W. Terpstra

[Qemu-devel] [PATCH 10/15] mips: null pointer deref should segfault

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra Dereferencing a null pointer causes an exception 0xC (EXCP_AdEL) instead of EXCP_TLBL. This should also trigger a segfault. Signed-off-by: Wesley W. Terpstra Signed-off-by: Riku Voipio --- linux-user/main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 15/15] linux-user/signal.c: Rename s390 target_ucontext fields to fix ia64

2011-07-13 Thread riku . voipio
From: Peter Maydell The ia64 sys/ucontext.h defines macros 'uc_link', 'uc_sigmask' and 'uc_stack'. Rename the s390 target_ucontext struct members to tuc_*, bringing them into line with the other targets and fixing a compile failure on ia64 hosts caused by this clash. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 03/15] linux-user: Add support for more VT ioctls

2011-07-13 Thread riku . voipio
From: Cédric VINCENT DirectFB-1.0 uses at least two of the four added ioctls, and the two others were added for completeness. This patch was validated with the program "vlock -all/-new". Signed-off-by: Cédric VINCENT Cc: Riku Voipio Signed-off-by: Riku Voipio --- linux-user/ioctls.h

[Qemu-devel] [PATCH 13/15] linux-user: correct syscall 123 on sh4

2011-07-13 Thread riku . voipio
From: Riku Voipio As reported by Cédric VINCENT: The syscall #123 on SH4 should be "TARGET_NR_cacheflush" instead of "TARGET_NR_modify_ldt" [1]. The only consequence of this misnaming is that many "Unsupported syscall" warnings are issued when emulating JIT compilers. Reported-by: Cédric VINCE

[Qemu-devel] [PATCH 09/15] mips: missing syscall returns wrong errno

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra Return -TARGET_ENOSYS instead of -ENOSYS from linux-user/main.c * Caused strange 'Level 2 synchronization messages' instead of correctly reporting the syscall was missing. * Made glibc simply fail instead of using older syscalls Signed-off-by: Riku Voipio Signed-o

[Qemu-devel] [PATCH 07/15] linux-user/syscall.c: Enforce pselect6 sigset size restrictions

2011-07-13 Thread riku . voipio
From: Peter Maydell Enforce the same restriction on the size of the sigset passed to pselect6 as the Linux kernel does. This is both correct and silences a gcc 4.6 warning about a write-only variable. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c |5

[Qemu-devel] [PATCH 08/15] mips: sigaltstack args

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra The syscall sigaltstack takes two parameters, not zero. This patch should have no impact as only values above 4 influence the runtime behaviour. Nevertheless, it is wrong. Signed-off-by: Wesley W. Terpstra Signed-off-by: Riku Voipio --- linux-user/main.c |2 +- 1

[Qemu-devel] [PATCH 06/15] linux-user: Implement prlimit64 syscall

2011-07-13 Thread riku . voipio
From: Peter Maydell Implement the prlimit64 syscall. Slightly modified to apply upstream -Riku Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 43 +++ linux-user/syscall_defs.h |4 2 files changed, 47

[Qemu-devel] [PATCH 02/15] linux-user: Add support for KD...LED ioctls

2011-07-13 Thread riku . voipio
From: Cédric VINCENT DirectFB-1.0 uses at least one of the four added ioctls, and the three others were added for completeness. This patch was validated with the program "setleds" and the following Makefile: SETLEDS_INIT = setleds -v -num -caps -scroll SETLEDS_TESTS = sh -c ' \

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread malc
On Wed, 13 Jul 2011, Luiz Capitulino wrote: > From: Luiz Capitulino > > This moves compiler related macros from qemu-common.h to compiler.h. > > The reason for this change is that there are simple header files that > depend only on the compiler macros, so including qemu-common.h is overkill. >

[Qemu-devel] [PATCH 00/15] v2: pending linux-user patches

2011-07-13 Thread riku . voipio
From: Riku Voipio This time including Wesleys patches I missed last time, replacing his "mips: eabi syscall support for 64-bit args" patch with a my version, and fixing cacheflush syscall as requested bt Cédric. Patches also available in the git repository at: git://git.linaro.org/people/rikuv

[Qemu-devel] [Bug 809912] [NEW] qemu-kvm -m bigger 4096 aborts with 'Bad ram offset'

2011-07-13 Thread Lutz Vieweg
Public bug reported: When I try to start a virtual machine (x86_64 guest on a x86_64 host that has 32GB memory, using kvm_amd module, both host and guest running linux-2.6.39 kernels) with "qemu-system-x86_64 -cpu host -smp 2 -m 4096 ...", shortly after the guest kernel starts, qemu aborts with a

[Qemu-devel] [PATCH 01/15] arm-semi: Provide access to CLI arguments passed through the "-append" option

2011-07-13 Thread riku . voipio
From: Cédric VINCENT This patch basically adapts the new semi-hosting command-line support -- introduced by Wolfgang Schildbach in the commit 2e8785ac -- for use in system-mode. Note that the "arm_cmdline_len" and "host_cmdline_len" variables were renamed respectively "input_size" and "output_si

[Qemu-devel] [PATCH 4/4] Expose drive_add on all architectures

2011-07-13 Thread Alexander Graf
All architectures can now use drive_add on the monitor. This of course does not mean that there is hotplug support for the specific platform, so in order to actually make use of the new drives you still need to have a hotplug capable device. Signed-off-by: Alexander Graf --- hmp-commands.hx |

[Qemu-devel] [PATCH 2/4] Compile device-hotplug on all targets

2011-07-13 Thread Alexander Graf
All guest targets could potentially implement hotplugging. With the next patches in this set I will also reflect this in the monitor interface. So let's always compile it in. It shouldn't hurt. Signed-off-by: Alexander Graf --- Makefile.target |5 - 1 files changed, 4 insertions(+), 1 d

[Qemu-devel] [PATCH 1/4] [S390] Add hotplug support

2011-07-13 Thread Alexander Graf
I just submitted a few patches that enable the s390 virtio bus to receive a hotplug add event. This patch implements the qemu side of it, so that new hotplug events can be submitted to the guest. Signed-off-by: Alexander Graf --- v1 -> v2: - make s390 virtio hoplug code emulate-capable ---

[Qemu-devel] [PATCH v2 0/3]: Fix build issue with error.h

2011-07-13 Thread Luiz Capitulino
A .c file including error.h and not including qemu-common.h will break the build, because error.h uses a macro defined in qemu-common.h. The simple and obvious fix would be to change error.h to include qemu-common.h. But this is overkill, so this series does some splitting in qemu-common.h and cha

[Qemu-devel] [PATCH 0/4] S390 virtio hotplug v2

2011-07-13 Thread Alexander Graf
Hey guys, this patch set adds support for hotplug add on S390. Apparently it's the first non-x86 platform receiving so much love in Qemu, so I've stumbled over some very basic #if defined(TARGET_I386) cases that just shouldn't be there. It's trying to make things as generic as possible. I've talk

[Qemu-devel] [PATCH 2/2] Error: Fix build when qemu-common.h is not included

2011-07-13 Thread Luiz Capitulino
From: Luiz Capitulino Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of the macro GCC_FMT_ATTR to error.h, however compiler.h is not included by error.h This will cause a build error when files including error.h don't include qemu-common.h (or compiler.h). Not an issue today becau

[Qemu-devel] [PATCH 3/4] Add generic drive hotplugging

2011-07-13 Thread Alexander Graf
The monitor command for hotplugging is in i386 specific code. This is just plain wrong, as S390 just learned how to do hotplugging too and needs to get drives for that. So let's add a generic copy to generic code that handles drive_add in a way that doesn't have pci dependencies. All pci specific

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
Hi, Hmm. Alon, is it an option to just leave the whole qxl-render stuff in sync mode for now and convert it later? Or will that have bad interactions with QXL_IO_UPDATE_AREA_ASYNC being used by the guest? It's not a problem. I do have a working version using async monitor command, but I wi

[Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Luiz Capitulino
From: Luiz Capitulino This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple header files that depend only on the compiler macros, so including qemu-common.h is overkill. Besides, qemu-common.h is bloated and will benefit from so

Re: [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command

2011-07-13 Thread Paolo Bonzini
On 07/13/2011 03:06 PM, Michal Novotny wrote: +uint64_t time_get(const char *name, int stage); +void time_set(const char *name, int stage, uint64_t tv); +void time_add(const char *name, int stage, uint64_t tv); +void time_add2(const char *name, int stage, uint64_t time1, uint64_t time2); +uint64_

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 03:45:16PM +0200, Gerd Hoffmann wrote: > On 07/13/11 14:32, Luiz Capitulino wrote: > >>Not sure. Luiz, do we have async monitor commands meanwhile? > > > >Not yet, this is a QAPI feature that should land soon, but it's not > >available yet. > > Hmm. Alon, is it an option

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
On 07/13/11 14:32, Luiz Capitulino wrote: Not sure. Luiz, do we have async monitor commands meanwhile? Not yet, this is a QAPI feature that should land soon, but it's not available yet. Hmm. Alon, is it an option to just leave the whole qxl-render stuff in sync mode for now and convert it

Re: [Qemu-devel] PCI with Xilinx virtex-ml507 board

2011-07-13 Thread Lê Đức Tài
On Jul 13, 2011 14:09, "Edgar E. Iglesias" wrote: > Hi, > Hi the ethlite driver is this one: > http://lxr.linux.no/linux+v2.6.39/drivers/net/xilinx_emaclite.c > The easy way is probably to look at the petalogix s3adsp board dtb >distributed with qemu. Iirc, the command to make readable is

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 15:56:55 +0300 Alon Levy wrote: > On Wed, Jul 13, 2011 at 09:33:26AM -0300, Luiz Capitulino wrote: > > On Wed, 13 Jul 2011 14:29:16 +0300 > > Alon Levy wrote: > > > > > On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > > > > On 07/13/11 11:29, Alon Levy wrote:

[Qemu-devel] [PATCH v3 5/6] block: add bdrv_map()

2011-07-13 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block.c | 14 ++ block.h |2 ++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index cda600b..86a4752 100644 --- a/block.c +++ b/block.c @@ -3091,3 +3091,17 @@ int bdrv_get_mapping(BlockDriverState *bs, uint64

[Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command

2011-07-13 Thread Michal Novotny
Hi, this is the implementation of the "info migrate-times" command I did to get the times for the migration to get times for each migration stage. Based on the fact migration itself is just the vmsave on the source host and vmload on destination host this function can be also useful to get the save

Re: [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6

2011-07-13 Thread Daniel P. Berrange
On Tue, Jul 05, 2011 at 08:21:36AM -0500, Michael Roth wrote: > BUILD/USAGE > > build: > ./configure --target-list=x86_64-softmmu > make > make qemu-ga #should be built on|for target guest > > start guest: > qemu \ > -drive file=/home/mdroth/vm/rhel6_64_base.raw,snapshot=off,if=virtio \

[Qemu-devel] [PATCH v3 4/6] block: add bdrv_get_mapping()

2011-07-13 Thread Devin Nakamura
Conflicts: block.h Signed-off-by: Devin Nakamura --- block.c | 29 + block.h |2 ++ 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 7d3bc67..cda600b 100644 --- a/block.c +++ b/block.c @@ -3062,3 +3062,32 @@ int bd

[Qemu-devel] [PATCH v3 3/6] block: add bdrv_open_conversion_target()

2011-07-13 Thread Devin Nakamura
Conflicts: block.h Signed-off-by: Devin Nakamura --- block.c | 31 +++ block.h |3 +++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 5c0ba2d..7d3bc67 100644 --- a/block.c +++ b/block.c @@ -3019,6 +3019,37 @@ out

[Qemu-devel] [PATCH v3 1/6] block: add basic conversion api

2011-07-13 Thread Devin Nakamura
add functions to block driver interface to support inplace image conversion Signed-off-by: Devin Nakamura --- block_int.h | 70 +++ 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/block_int.h b/block_int.h index 1e265d2..0

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:33:26AM -0300, Luiz Capitulino wrote: > On Wed, 13 Jul 2011 14:29:16 +0300 > Alon Levy wrote: > > > On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > > > On 07/13/11 11:29, Alon Levy wrote: > > > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wr

[Qemu-devel] [PATCH v3 6/6] block: add bdrv_copy_header()

2011-07-13 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block.c | 12 block.h |2 ++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 86a4752..0f38aff 100644 --- a/block.c +++ b/block.c @@ -3105,3 +3105,15 @@ int bdrv_map(BlockDriverState *bs, uint64_t *guest

[Qemu-devel] [PATCH v3 2/6] block: add bdrv_get_conversion_options()

2011-07-13 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block.c | 13 + block.h |2 ++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 24a25d5..5c0ba2d 100644 --- a/block.c +++ b/block.c @@ -3018,3 +3018,16 @@ out: return ret; } + +int bdrv_get_convers

Re: [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: Command "block_set" for dynamic block params change

2011-07-13 Thread Supriya Kannery
Updated "block_set" command to accept multiple -drive parameters. Also, added code for re-opening of device file with original flags, incase opening file using changed hostcache setting fails. -- New command "block_set" added for

Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread tsnsaito
Hi, At Wed, 13 Jul 2011 13:09:28 +0100, Mark Cave-Ayland wrote: > >> Nice series! > >> May I ask what have you used as a test case to discover the problem? > > > > I found the problem when I was trying to run the linux/sparc64 kernel. > > It seemed that copy_to_user() did not work as expected. >

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 14:29:16 +0300 Alon Levy wrote: > On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > > On 07/13/11 11:29, Alon Levy wrote: > > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > > >>On 07/12/11 15:55, Alon Levy wrote: > > >>>Later the save will hap

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 13:46:50 +0200 Gerd Hoffmann wrote: >Hi, > > > I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's > > becoming pretty > > ugly. Also I guess what Daniel described is possible, but it changes the > > usage of screendump > > even more. Is turning do_s

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 12:41:48 +0200 Gerd Hoffmann wrote: > On 07/13/11 11:29, Alon Levy wrote: > > On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > >> On 07/12/11 15:55, Alon Levy wrote: > >>> Later the save will happen asynchronously on surface_updated callback. > >> > >> Hmm. I

Re: [Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 10:01:49 +0200 Kevin Wolf wrote: > Am 12.07.2011 22:35, schrieb Luiz Capitulino: > > Please, see individual patches for details. > > > > v2 > > > > o Correct man-page text > > o Document -drive options in qemu-config.c > > > > qemu-config.c |6 ++ > > qemu-opti

Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread Mark Cave-Ayland
On 13/07/11 12:06, tsnsa...@gmail.com wrote: Nice series! May I ask what have you used as a test case to discover the problem? I found the problem when I was trying to run the linux/sparc64 kernel. It seemed that copy_to_user() did not work as expected. That's good to hear. How far have you

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
Hi, I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's becoming pretty ugly. Also I guess what Daniel described is possible, but it changes the usage of screendump even more. Is turning do_screen_dump to async viable? I think I'll work on it. Daniel's suggestion is a n

Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 12:45:24PM +0200, Gerd Hoffmann wrote: > On 07/13/11 10:51, Alon Levy wrote: > >On Wed, Jul 13, 2011 at 08:43:57AM +0200, Gerd Hoffmann wrote: > >>On 07/12/11 15:55, Alon Levy wrote: > >>>v2->v3: > >>> builds correctly with older and newer spice, and runs with older and >

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > On 07/13/11 11:29, Alon Levy wrote: > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > >>On 07/12/11 15:55, Alon Levy wrote: > >>>Later the save will happen asynchronously on surface_updated callback. > >> > >>Hmm. I

Re: [Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Stefan Hajnoczi
On Wed, Jul 13, 2011 at 11:50 AM, Andrew Griffiths <807...@bugs.launchpad.net> wrote: > I was explaining the threads / uids per thread issue, in case it wasn't > obvious of what the impact was, or how to exploit that issue (in case > someone was wondering about that). It was not directed at Chris i

Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread tsnsaito
Hi, At Wed, 13 Jul 2011 10:57:19 +0200, Artyom Tarasenko wrote: > On Wed, Jul 13, 2011 at 5:30 AM, Tsuneo Saito wrote: > > Hi, > > > > This patch series implements sparcv9 stfa/ldfa instructions with > > non block-transfer ASIs that implementations seem to be left unfinished. > > This patch also

Re: [Qemu-devel] [PATCH] tcg/README: Expand advice on number of TCG ops per target insn

2011-07-13 Thread Peter Maydell
Ping? On 22 June 2011 15:40, Peter Maydell wrote: > Expand the note on the number of TCG ops generated per target insn, > to be clearer about the range of applicability of the 20 op rule > of thumb. Also add a note about the hard MAX_OP_PER_INSTR limit. > > Signed-off-by: Peter Maydell > --- > T

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Andrew Griffiths
Hello Stefan, I was explaining the threads / uids per thread issue, in case it wasn't obvious of what the impact was, or how to exploit that issue (in case someone was wondering about that). It was not directed at Chris in any shape or form, nor was it about libvirt. -- You received this bug not

Re: [Qemu-devel] [PULL 0/8] ARM patch queue

2011-07-13 Thread Peter Maydell
Ping^2 ? -- PMM On 30 June 2011 10:24, Peter Maydell wrote: > Ping? > > thanks > -- PMM > > On 22 June 2011 18:33, Peter Maydell wrote: >> This is a pull request for various ARM related patches which >> have been on the list for a while (mostly but not entirely mine). >> >> The performance coun

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Daniel P. Berrange
On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > On 07/12/11 15:55, Alon Levy wrote: > >Later the save will happen asynchronously on surface_updated callback. > > Hmm. I can see why you are doing that. It makes the file being > written *after* the monitor command finishes though,

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Daniel P. Berrange
On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: > On 07/13/11 11:29, Alon Levy wrote: > >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > >>On 07/12/11 15:55, Alon Levy wrote: > >>>Later the save will happen asynchronously on surface_updated callback. > >> > >>Hmm. I

Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-13 Thread Gerd Hoffmann
On 07/13/11 10:51, Alon Levy wrote: On Wed, Jul 13, 2011 at 08:43:57AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2->v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-re

Re: [Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Stefan Hajnoczi
On Wed, Jul 13, 2011 at 11:12 AM, Andrew Griffiths <807...@bugs.launchpad.net> wrote: > Once you have code execution in the process, you can modify the others > threads execution (if required) to execute your own code. With full > capabilities, it would be trivial to escape from a chroot on a norma

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
On 07/13/11 11:29, Alon Levy wrote: On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why you are doing that. It makes the file being written *after* the mo

Re: [Qemu-devel] [PATCH v2 3/5] block: add bdrv_get_mapping()

2011-07-13 Thread Kevin Wolf
Am 11.07.2011 21:55, schrieb Devin Nakamura: > Signed-off-by: Devin Nakamura > --- > block.c | 14 ++ > block.h |2 ++ > 2 files changed, 16 insertions(+), 0 deletions(-) I only received patches 3-5 for v2, the first two seem to be missing. Kevin

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Andrew Griffiths
Once you have code execution in the process, you can modify the others threads execution (if required) to execute your own code. With full capabilities, it would be trivial to escape from a chroot on a normal Linux kernel (grsecurity with appropriate kernel chroot restrictions enabled would reduce

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Andrew Griffiths
correction: s/other distro's/other operating systems/g -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/807893 Title: qemu privilege escalation Status in QEMU: Confirmed Bug description: If qemu

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Andrew Griffiths
# ps axwu ... qemu00 29957 0.5 9.8 480568 405228 ? Sl Jul12 7:41 /usr/bin/qemu-system-x86_64 -runas ... ... # ps axwu -L ... qemu00 29957 29957 0.23 9.8 480568 405228 ? Sl Jul12 2:49 /usr/bin/qemu-system-x86_64 -runas ... root 29957 29959 0.33 9.8 480568

Re: [Qemu-devel] live block copy/stream/snapshot discussion

2011-07-13 Thread Stefan Hajnoczi
On Tue, Jul 12, 2011 at 5:10 PM, Kevin Wolf wrote: > Am 12.07.2011 17:45, schrieb Stefan Hajnoczi: > The command synopses are as follows: > > block_stream > > > Copy data from a backing file into a block device. > > If the optional 'all' argument is tru

Re: [Qemu-devel] [PATCHv3] qxl: QXL_IO_UPDATE_AREA: pass ram->update_area directly to update_area

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 08:56:27AM +0200, Gerd Hoffmann wrote: > Hi, > > >-QXLRect update = d->ram->update_area; > > qxl_spice_update_area(d, d->ram->update_surface, > >-&update, NULL, 0, 0); > >+&d->ram->update_area, NULL, 0, 1); > > No, -ESECURITY. > > With this in place the

Re: [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_area_complete

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:51:14AM +0200, Gerd Hoffmann wrote: > Hi, > > >+void qxl_render_primary_updated(PCIQXLDevice *qxl, QXLRect *dirty, > >+uint32_t num_dirty); > > >@@ -65,6 +65,10 @@ struct SimpleSpiceDisplay { > > int notify; > > int running; >

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: > On 07/12/11 15:55, Alon Levy wrote: > >Later the save will happen asynchronously on surface_updated callback. > > Hmm. I can see why you are doing that. It makes the file being > written *after* the monitor command finishes though,

Re: [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort)

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:54:55AM +0200, Gerd Hoffmann wrote: > Hi, > > >The "solution" of ignoring the request is bad, but better then aborting > >and a real solution would probably be in spice to not call get_command > >in the first place. > > Isn't the plan to fix spice-server this way? I

  1   2   >