Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-04 Thread Markus Armbruster
Typo in subject: "unsed". The warning is spelled "unused-but-set-variable", the option "-Wunused-but-set-variable". Raghavendra D Prabhu writes: > In a few cases, variable attributed 'unused' has been added, in other cases > unused variable has been either removed or commented out. > > Signed-o

Re: [Qemu-devel] buildbot failure in qemu on pci_x86_64_debian_5_0

2011-07-04 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 3:04 AM, wrote: > The Buildbot has detected a new failure on builder pci_x86_64_debian_5_0 > while building qemu. > Full details are available at: >  http://buildbot.b1-systems.de/qemu/builders/pci_x86_64_debian_5_0/builds/24 > > Buildbot URL: http://buildbot.b1-systems.de

[Qemu-devel] [Bug 591666] Re: broken "pci_add auto storage"

2011-07-04 Thread Pierce Liu
Hi Eran, Could you lauch "lspci" command on guestOS to see whether there is a new pci device hot-plug in? On the other hand, the guestOS need to be configured with "CONFIG_VIRTIO_PCI", otherwise it can not contain the driver to monitor the virtio-pci device. Thanks -- You received this bug n

Re: [Qemu-devel] [PATCH 2/3] Add fno-strict-overflow

2011-07-04 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 11:38 PM, Peter Maydell wrote: > On 4 July 2011 23:00, Raghavendra D Prabhu wrote: >> This is to avoid gcc optimizating out the comparison in assert, >> due to assumption of signed overflow being undefined by default >> (-Werror=strict-overflow). > >>--- a/Makefile.hw >>++

[Qemu-devel] buildbot failure in qemu on ppc-next_i386_debian_5_0

2011-07-04 Thread qemu
The Buildbot has detected a new failure on builder ppc-next_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/ppc-next_i386_debian_5_0/builds/24 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Bui

[Qemu-devel] buildbot failure in qemu on ppc-next_x86_64_debian_5_0

2011-07-04 Thread qemu
The Buildbot has detected a new failure on builder ppc-next_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/ppc-next_x86_64_debian_5_0/builds/24 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] [PATCH 3/5] block: add bdrv_get_mapping()

2011-07-04 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block.c | 12 block.h |2 ++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index e7699a6..302b0d5 100644 --- a/block.c +++ b/block.c @@ -3037,3 +3037,15 @@ int bdrv_open_conversion_target(BlockDriverState **

[Qemu-devel] [PATCH 1/5] block_int: add basic conversion api

2011-07-04 Thread Devin Nakamura
add functions to block driver interface to support inplace image conversion Signed-off-by: Devin Nakamura --- block_int.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/block_int.h b/block_int.h index 1e265d2..ef311c7 100644 --- a/block_int.h +++ b/block_int.h

[Qemu-devel] [PATCH 4/5] block: add bdrv_map()

2011-07-04 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block.c | 12 block.h |2 ++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 302b0d5..c9ea201 100644 --- a/block.c +++ b/block.c @@ -3049,3 +3049,15 @@ int bdrv_get_mapping(BlockDriverState *bs, uint64_t

[Qemu-devel] [PATCH 2/5] block: add bdrv_open_conversion_target

2011-07-04 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block.c | 19 +++ block.h |2 ++ 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 24a25d5..e7699a6 100644 --- a/block.c +++ b/block.c @@ -3018,3 +3018,22 @@ out: return ret; } + + +int bdrv_ope

[Qemu-devel] [PATCH 5/5] block: add bdrv_copy_header()

2011-07-04 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block.c | 10 ++ block.h |2 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index c9ea201..c6c36e7 100644 --- a/block.c +++ b/block.c @@ -3061,3 +3061,13 @@ int bdrv_map(BlockDriverState *bs, uint64_t *guest_o

[Qemu-devel] buildbot failure in qemu on trivial-patches_i386_debian_5_0

2011-07-04 Thread qemu
The Buildbot has detected a new failure on builder trivial-patches_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/trivial-patches_i386_debian_5_0/builds/24 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Bui

Re: [Qemu-devel] [PATCH v5] showing a splash picture when start, seabios image for test

2011-07-04 Thread Wayne Xia
于 2011-7-5 2:31, Paul Brook 写道: jpeg decoder have its limitation, it only accept jpg file with width=16*M, height=16*N. bmp decoder only accept 24bpp file, with a resolution that a video mode could support. Recommended is 640x480(mostly used). Doing image decoding in the bios seems

Re: [Qemu-devel] [PATCH v5] showing a splash picture when start, seabios image for test

2011-07-04 Thread Wayne Xia
于 2011-7-5 2:31, Paul Brook 写道: jpeg decoder have its limitation, it only accept jpg file with width=16*M, height=16*N. bmp decoder only accept 24bpp file, with a resolution that a video mode could support. Recommended is 640x480(mostly used). Doing image decoding in the bios seems

[Qemu-devel] buildbot failure in qemu on pci_x86_64_debian_5_0

2011-07-04 Thread qemu
The Buildbot has detected a new failure on builder pci_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/pci_x86_64_debian_5_0/builds/24 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: b1_qemu_1 Build

[Qemu-devel] [Bug 568614] Re: x86_64 host curses interface: spacing/garbling

2011-07-04 Thread Andrzej Zaborowski
If I remember correctly, the type is unsigned long because it needs to match "chtype" as declared in curses.h. On some implementations of curses it may be declared differently, we really should use the "chtype" type directly but console.h is also used when the use of curses was disabled in qemu co

[Qemu-devel] buildbot failure in qemu on default_x86_64_out_of_tree

2011-07-04 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_out_of_tree/builds/145 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: b1_qe

Re: [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-07-04 Thread andrzej zaborowski
Hi, On 29 June 2011 20:53, Peter Maydell wrote: > From: Juha Riihimäki > > Convert the OMAP GPIO module to qdev. > > Signed-off-by: Juha Riihimäki > [Riku Voipio: Fixes and restructuring patchset] > Signed-off-by: Riku Voipio > [Peter Maydell: More fixes and cleanups for upstream submission] >

Re: [Qemu-devel] [PATCH 2/3] Add fno-strict-overflow

2011-07-04 Thread Peter Maydell
On 4 July 2011 23:00, Raghavendra D Prabhu wrote: > This is to avoid gcc optimizating out the comparison in assert, > due to assumption of signed overflow being undefined by default > (-Werror=strict-overflow). >--- a/Makefile.hw >+++ b/Makefile.hw >@@ -9,7 +9,7 @@ include $(SRC_PATH)/rules.mak

Re: [Qemu-devel] qemu crashes on Mac OS X

2011-07-04 Thread Damjan Marion
On Jul 4, 2011, at 6:59 PM, Alexandre Raymond wrote: > Hi Damjan, > > > Can you try applying the following two patches and see if it solves > your problem? > > http://patchwork.ozlabs.org/patch/100348/ > http://patchwork.ozlabs.org/patch/100477/ > Unfortunately same thing happens: segmentati

[Qemu-devel] [PATCH 2/3] Add fno-strict-overflow

2011-07-04 Thread Raghavendra D Prabhu
This is to avoid gcc optimizating out the comparison in assert, due to assumption of signed overflow being undefined by default (-Werror=strict-overflow). Signed-off-by: Raghavendra D Prabhu --- Makefile.hw |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.hw b/

[Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-04 Thread Raghavendra D Prabhu
In a few cases, variable attributed 'unused' has been added, in other cases unused variable has been either removed or commented out. Signed-off-by: Raghavendra D Prabhu --- hw/device-assignment.c |6 +++--- simpletrace.c |2 +- xen-mapcache.c |7 ++- 3 files cha

Re: [Qemu-devel] [PATCH] Build fixes

2011-07-04 Thread Raghavendra D Prabhu
* On Sat, Jul 02, 2011 at 03:58:34PM +0100, Stefan Hajnoczi wrote: On Sat, Jul 2, 2011 at 3:06 PM, Raghavendra D Prabhu wrote:    With default configure, the qemu-kvm client build was failing for me    since Werror is enabled by default in configure.    Deprecations (gnutls), gcc signed-overf

[Qemu-devel] [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions.

2011-07-04 Thread Raghavendra D Prabhu
The gnutls_*_set_priority family of functions has been marked deprecated in 2.12.x. These functions have been superceded by gnutls_priority_set_direct(). Signed-off-by: Raghavendra D Prabhu --- ui/vnc-tls.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions(-) diff --gi

[Qemu-devel] [PATCH 0/3] Build fixes

2011-07-04 Thread Raghavendra D Prabhu
Hi, With default configure, the qemu-kvm client build was failing for me since Werror is enabled by default in configure. Deprecations (gnutls), gcc signed-overflow optimization (Werror=strict-overflows) and few unused-but-set variables were causing it. I have attached the patch

[Qemu-devel] [PATCH] xen_console: fall back to qemu serial device

2011-07-04 Thread Alexander Graf
The new xen_console protocol changed the default xen_console output device from whatever Qemu chose to whatever xenstore choses and "pty" as fallback. This is not how Qemu works. It has its own serial redirection semantics. So it xenstore doesn't contain information on what to do, Qemu is the plac

Re: [Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include

2011-07-04 Thread Alexander Graf
On 04.07.2011, at 23:02, Peter Maydell wrote: > Remove the include of setjmp.h from the cpu.h of target-alpha > and target-ppc. This is unnecessary because cpu-defs.h already > includes this header; this change brings these two targets > into line with all the rest. > > Signed-off-by: Peter Mayd

[Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include

2011-07-04 Thread Peter Maydell
Remove the include of setjmp.h from the cpu.h of target-alpha and target-ppc. This is unnecessary because cpu-defs.h already includes this header; this change brings these two targets into line with all the rest. Signed-off-by: Peter Maydell --- target-alpha/cpu.h |2 -- target-ppc/cpu.h |

Re: [Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation on Debian "lenny")

2011-07-04 Thread Peter Maydell
On 4 July 2011 19:52, Stefan Weil wrote: > Some versions of png.h cannot be included after setjmp.h, > even when PNG_SKIP_SETJMP_CHECK was defined. > > setjmp.h was included from qemu-common.h and is not needed there. > Removing the include statement fixes compilation of ui/vnc-enc-tight.c > with

Re: [Qemu-devel] [PATCH] arm: Add const attribute to some arm_boot_info pointers

2011-07-04 Thread andrzej zaborowski
On 23 June 2011 17:53, Stefan Weil wrote: > Parameter 'info' is const, so add the missing attribute. > > v2: > Add 'const' to the local variable info in do_cpu_reset() and to > the boot_info field in CPUARMState (suggested by Peter Maydell). I pushed this version, thanks. Cheers

Re: [Qemu-devel] [PATCH v4 1/2] pxa2xx_lcd: add proper rotation support

2011-07-04 Thread andrzej zaborowski
On 17 June 2011 12:04, Vasily Khoruzhick wrote: > Until now, pxa2xx_lcd only supported 90deg rotation, but > some machines (for example Zipit Z2) needs 270deg rotation. > > Signed-off-by: Vasily Khoruzhick > --- > v2: codestyle fixes > v3: fix dpy_update calls for 180 and 360 deg. rotation. > v4:

Re: [Qemu-devel] [PATCH][uq/master] kvm: Drop obsolete KVM_IOEVENTFD #ifdefs

2011-07-04 Thread Marcelo Tosatti
On Thu, Jun 23, 2011 at 10:26:27AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka > --- > kvm-all.c |8 > 1 files changed, 0 insertions(+), 8 deletions(-) Applied, thanks.

Re: [Qemu-devel] [PATCH][uq/master] kvmclock: Fix feature detection

2011-07-04 Thread Marcelo Tosatti
On Thu, Jun 23, 2011 at 10:23:10AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Bit-wise or the feature flags and drop the obsolete #ifdef. > > Signed-off-by: Jan Kiszka > --- > hw/kvmclock.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) Applied, thanks.

[Qemu-devel] Fwd: Benchmarking activities

2011-07-04 Thread Andreas Färber
[Somehow qemu-devel got lost...] Anfang der weitergeleiteten E-Mail: Von: Andreas Färber Datum: 2. Juli 2011 19:21:07 MESZ An: Ben Vogler Kopie: Hans de Goede , Alon Levy > Betreff: Re: [Qemu-devel] Benchmarking activities Hi Ben, Am 27.06.2011 um 01:02 schrieb Ben Vogler: - I ha

[Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation on Debian "lenny")

2011-07-04 Thread Stefan Weil
Some versions of png.h cannot be included after setjmp.h, even when PNG_SKIP_SETJMP_CHECK was defined. setjmp.h was included from qemu-common.h and is not needed there. Removing the include statement fixes compilation of ui/vnc-enc-tight.c with CONFIG_VNC_PNG defined. Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH] Remove unneeded setjmp.h (fix compilation with on Debian "lenny")

2011-07-04 Thread Stefan Weil
Am 04.07.2011 20:44, schrieb Stefan Weil: Some versions of png.h cannot be included after setjmp.h, even when PNG_SKIP_SETJMP_CHECK was defined. setjmp.h was included from qemu-common.h and is not needed there. Removing the include statement fixes compilation of ui/vnc-enc-tight.c with CONFIG_VN

[Qemu-devel] [PATCH] Remove unneeded setjmp.h (fix compilation with on Debian "lenny")

2011-07-04 Thread Stefan Weil
Some versions of png.h cannot be included after setjmp.h, even when PNG_SKIP_SETJMP_CHECK was defined. setjmp.h was included from qemu-common.h and is not needed there. Removing the include statement fixes compilation of ui/vnc-enc-tight.c with CONFIG_VNC_PNG defined. Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH v5] showing a splash picture when start, seabios image for test

2011-07-04 Thread Paul Brook
> jpeg decoder have its limitation, it only accept jpg file with > width=16*M, height=16*N. > bmp decoder only accept 24bpp file, with a resolution that a video > mode could support. Recommended is 640x480(mostly used). Doing image decoding in the bios seems particularly pointless. Why

Re: [Qemu-devel] [PATCH] usb-hid: Fix 0/0 position for Windows in tablet mode

2011-07-04 Thread andrzej zaborowski
On 26 June 2011 11:11, Jan Kiszka wrote: > On 2011-06-25 15:10, Andreas Färber wrote: >> Am 25.06.2011 um 14:55 schrieb Jan Kiszka: >> >>> On 2011-06-25 14:37, Andreas Färber wrote: Am 24.06.2011 um 16:27 schrieb Jan Kiszka: > For unknown reasons, Windows drivers (tested with XP and

Re: [Qemu-devel] [PATCH v5] xen_console: support the new extended xenstore protocol

2011-07-04 Thread Stefano Stabellini
On Mon, 4 Jul 2011, Alexander Graf wrote: > > On 30.06.2011, at 19:26, > wrote: > > > From: Stefano Stabellini > > > > Since CS 21994 on xen-unstable.hg and CS > > 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few > > changes have been introduced to the PV console xensto

[Qemu-devel] [PULL] pci, vhost

2011-07-04 Thread Michael S. Tsirkin
The following changes since commit 1dfdcaa83f9ce34aded8bc0669e81753d94f1b7d: user: Fix -d debug logging for usermode emulation (2011-06-28 20:57:09 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Anthony PERARD (1):

Re: [Qemu-devel] [PATCH 1/1] usb_register_port(): do not set port->opaque and port->index twice

2011-07-04 Thread Gerd Hoffmann
port->opaque = opaque; port->index = index; -port->opaque = opaque; -port->index = index; Added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] qemu crashes on Mac OS X

2011-07-04 Thread Alexandre Raymond
Hi Damjan, On Fri, Jul 1, 2011 at 10:56 AM, Damjan Marion wrote: > > On Jul 1, 2011, at 11:17 AM, Damjan Marion (damarion) wrote: > >> >> Hi, >> >> I have an issue when I try to run qemu-system-arm on Mac OS X. >> Sometime between 1 and 15 secs after qemu is started it crashes >> as shown bellow.

Re: [Qemu-devel] KVM call agenda for July 5

2011-07-04 Thread Paolo Bonzini
On 07/04/2011 09:52 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. SCSI without bounce buffers: talk now, or forever hold your peace. Paolo

[Qemu-devel] [PATCH 2/2] ide: Initialise buffers with zeros

2011-07-04 Thread Kevin Wolf
Just in case there's still a way how a guest can read out buffers when it's not supposed to, let's zero the buffers during initialisation so that we don't leak information to the guest. Signed-off-by: Kevin Wolf --- hw/ide/core.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) d

Re: [Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_debian_5_0

2011-07-04 Thread Stefan Weil
Am 04.07.2011 11:21, schrieb Alexander Graf: On 04.07.2011, at 07:51, Stefan Weil wrote: Am 04.07.2011 06:23, schrieb Stefan Hajnoczi: On Mon, Jul 4, 2011 at 12:47 AM, Alexander Graf wrote: On 04.07.2011, at 02:04, q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure

[Qemu-devel] [PATCH] libcacard: don't leak vcard_emul_alloc_arrays mem

2011-07-04 Thread Christophe Fergeau
vcard_emul_mirror_card and vcard_emul_init use vcard_emul_alloc_arrays to allocate memory for temporary arrays which will contain elements that in the end will be used one by one in cac_card_init. The arrays themselves are never stored anywhere, they are only used as temporary containers. Hence the

Re: [Qemu-devel] [PATCH2] ppc: provide PIR register on all book-S CPUs

2011-07-04 Thread Alexander Graf
On 12.06.2011, at 17:50, Nathan Whitehorn wrote: > The PIR register is architecturally specified on all PowerPC non-embedded > CPUs, but currently is only available on the 604, 620, and G4. Add it to all > 601-derived CPUs. Looking through the respective specs, I found the following matrix on

Re: [Qemu-devel] PCI: how handle multifunction / compound devices best?

2011-07-04 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi folks, > > I'm still looking for a sane way to handle multifunction pci devices, > specifically a EHCI USB controller with UHCI companion controllers. > > Here comes a small (incomplete[1]) two patch series to make the issue > more clear. The first patch adds a funct

Re: [Qemu-devel] PCI: how handle multifunction / compound devices best?

2011-07-04 Thread Markus Armbruster
Anthony Liguori writes: > On 07/01/2011 06:27 AM, Gerd Hoffmann wrote: >>Hi folks, >> >> I'm still looking for a sane way to handle multifunction pci devices, >> specifically a EHCI USB controller with UHCI companion controllers. >> >> Here comes a small (incomplete[1]) two patch series to ma

Re: [Qemu-devel] [PATCH2] ppc: provide PIR register on all book-S CPUs

2011-07-04 Thread Alexander Graf
On 04.07.2011, at 17:43, Nathan Whitehorn wrote: > On 07/04/11 10:21, Alexander Graf wrote: >> On 12.06.2011, at 17:50, Nathan Whitehorn wrote: >> >>> The PIR register is architecturally specified on all PowerPC non-embedded >>> CPUs, but currently is only available on the 604, 620, and G4. Add

[Qemu-devel] [PATCH 1/1] usb_register_port(): do not set port->opaque and port->index twice

2011-07-04 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- hw/usb-bus.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 2abce12..6e082ab 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -145,8 +145,6 @@ void usb_register_port(USBBus *bus, USBPo

[Qemu-devel] [PATCH 1/2] ide: Ignore reads during PIO in and writes during PIO out

2011-07-04 Thread Kevin Wolf
This fixes https://bugs.launchpad.net/qemu/+bug/786209: When the DRQ_STAT bit is set, the IDE core permits both data reads and data writes, regardless of whether the current transfer was initiated as a read or write. This potentially leaks uninitialized host memory into the guest,

[Qemu-devel] [PATCH 1/9] qxl: device id fixup

2011-07-04 Thread Gerd Hoffmann
Move device ID to PCIDeviceInfo. Remove support for the unused unstable device ID. Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 16316f2..e95d6f7 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1207

[Qemu-devel] [PATCH 6/9] qxl: add dev id to guest prints

2011-07-04 Thread Gerd Hoffmann
From: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3722f55..d55b68d 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -985,7 +985,8 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_

[Qemu-devel] [PATCH 7/9] qxl: make sure primary surface is saved on migration

2011-07-04 Thread Gerd Hoffmann
From: Yonit Halperin Signed-off-by: Gerd Hoffmann --- hw/qxl.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index d55b68d..5e49536 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1184,11 +1184,14 @@ static void qxl_vm_change_state_handler(void *o

[Qemu-devel] [PATCH 8/9] qxl: put QXL_IO_UPDATE_IRQ into vgamode whitelist

2011-07-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/qxl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 5e49536..848c90f 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -942,6 +942,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) case QXL

[Qemu-devel] [PATCH 9/9] qxl: allow QXL_IO_LOG also in vga

2011-07-04 Thread Gerd Hoffmann
From: Alon Levy The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. Signed-off-by: Gerd Hoffmann --- hw/qxl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 848c90f..0b9a4c7 100644 --- a/hw/qxl.c ++

[Qemu-devel] [PATCH 2/9] spice: catch spice server initialization failures.

2011-07-04 Thread Gerd Hoffmann
When the spice server initialization fails report this and exit instead of ignoring the error. Signed-off-by: Gerd Hoffmann --- ui/spice-core.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index dd9905b..e142452 100644 --- a/ui/sp

[Qemu-devel] [PATCH 4/9] qxl: interface_get_command: fix reported mode

2011-07-04 Thread Gerd Hoffmann
From: Alon Levy report correct mode when in undefined mode. introduces qxl_mode_to_string(), and uses it in other places too. Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 25 + 1 files changed, 21 insertions(+), 4 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e9

[Qemu-devel] [PATCH 5/9] qxl-logger: add timestamp to command log

2011-07-04 Thread Gerd Hoffmann
From: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl-logger.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl-logger.c b/hw/qxl-logger.c index 76f43e6..74cadba 100644 --- a/hw/qxl-logger.c +++ b/hw/qxl-logger.c @@ -19,6 +19,7 @@ * along with this program;

[Qemu-devel] [PULL] spice patch queue

2011-07-04 Thread Gerd Hoffmann
Hi, Here is the spice patch queue with a bunch of small fixes and improvements collected over time. No major changes. please pull, Gerd Alon Levy (5): qxl: set mm_time in vga update qxl: interface_get_command: fix reported mode qxl-logger: add timestamp to command log qxl: add dev i

[Qemu-devel] [PATCH 3/9] qxl: set mm_time in vga update

2011-07-04 Thread Gerd Hoffmann
From: Alon Levy This fixes a problem where on windows 7 startup phase, before the qxl driver is loaded, the drawables are sufficiently large and video like to trigger a stream, but the lack of a filled mm time field triggers a warning in spice-gtk. Signed-off-by: Gerd Hoffmann --- ui/spice-dis

Re: [Qemu-devel] [PATCH V2] [PowerPC][RFC] booke timers

2011-07-04 Thread Fabien Chouteau
On 01/07/2011 22:22, Scott Wood wrote: > On Fri, 1 Jul 2011 16:13:41 +0200 > Fabien Chouteau wrote: >> +static void booke_update_fixed_timer(CPUState *env, >> + uint8_t target_bit, >> + uint64_t *nex

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-07-04 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 2:38 PM, Hai Dong,Li wrote: > So if I understand correctly, virtio-scsi looks like an SCSI tranport > protocol, > such as iSCSI, FCP and SRP which use tcp/ip, FC and Infiniband RDMA > respectively as the transfer media while virtio-scsi uses virtio, an virtual > IO > channel

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-07-04 Thread Hai Dong,Li
On 07/01/2011 09:14 AM, Hannes Reinecke wrote: Actually, the kernel does _not_ do a LUN remapping. Not the kernel, the in-kernel target. The in-kernel target can and will map hardware LUNs (target_lun in drivers/target/*) to arbitrary LUNs (mapped_lun). Put in another way: the virtio-scsi de

Re: [Qemu-devel] [PATCHv3] qxl: make sure primary surface is saved on migration

2011-07-04 Thread Gerd Hoffmann
On 07/04/11 14:08, Yonit Halperin wrote: --- hw/qxl.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) Added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [V4 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-04 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 11:43 AM, Supriya Kannery wrote: > +int bdrv_reopen(BlockDriverState *bs, int bdrv_flags) > +{ > +    BlockDriver *drv = bs->drv; > +    int ret = 0; > + > +    /* Quiesce IO for the given block device */ > +    qemu_aio_flush(); > +    if (bdrv_flush(bs)) { > +        qerro

Re: [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-04 Thread Paolo Bonzini
On 07/04/2011 02:52 PM, Hannes Reinecke wrote: However, I probably will see to fixup the megasas emulation with the current infrastructure, get that in, and then move over to the iovec infrastructure. Makes sense also for ease of review. But if you promise to merge the iovec infrastructure I'

Re: [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-04 Thread Hannes Reinecke
On 07/04/2011 12:29 PM, Paolo Bonzini wrote: On 07/04/2011 09:26 AM, Hannes Reinecke wrote: Cool. Exactly what I need. FWIW, feel free to add my 'Acked-by' to it. Any chance of getting them included? I'm not very tied to pvscsi; I just needed an HBA that is not a joke by modern standards :

Re: [Qemu-devel] Benchmarking activities

2011-07-04 Thread Lluís
Andreas Färber writes: > Am 02.07.2011 um 10:32 schrieb Stefan Hajnoczi: >> On Fri, Jul 1, 2011 at 8:32 PM, Blue Swirl wrote: >>> 2011/6/27 Ben Vogler : - Are there any inbuilt data tracing features? For example, hardware signal tracing, register monitoring etc. >>> >>> Traci

Re: [Qemu-devel] [PATCH v2 0/2]: block: Small drive_init() improvements

2011-07-04 Thread Kevin Wolf
Am 01.07.2011 15:46, schrieb Luiz Capitulino: > Please, see individual patches for details. > > v1 -> v2: > - > > o Drop indentation patch > o Use error message suggested by Markus > > blockdev.c | 14 +- > 1 files changed, 5 insertions(+), 9 deletions(-) Thanks, applied

Re: [Qemu-devel] [V4 Patch 4/4]Qemu: Add commandline -drive option 'hostcache'

2011-07-04 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 11:43 AM, Supriya Kannery wrote: > @@ -324,7 +325,23 @@ DriveInfo *drive_init(QemuOpts *opts, in >        } >     } > > +    if ((buf = qemu_opt_get(opts, "hostcache")) != NULL) { > +        if (!strcmp(buf, "off")) { Please use qemu_opt_get_bool(). Stefan

[Qemu-devel] [PATCHv3] qxl: make sure primary surface is saved on migration

2011-07-04 Thread Yonit Halperin
--- hw/qxl.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 2bb36c6..b3a3507 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1165,11 +1165,14 @@ static void qxl_vm_change_state_handler(void *opaque, int running, int reason) qemu_spice_vm_c

Re: [Qemu-devel] [V4 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-04 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 11:43 AM, Supriya Kannery wrote: > +/* > + * Handle changes to block device settings, like hostcache, > + * while guest is running. > +*/ > +int do_block_set(Monitor *mon, const QDict *qdict, QObject **ret_data) > +{ > +    const char *device = qdict_get_str(qdict, "device")

Re: [Qemu-devel] [PATCH] virtio-blk: Turn drive serial into a qdev property

2011-07-04 Thread Kevin Wolf
Am 04.07.2011 13:29, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 20.06.2011 11:35, schrieb Markus Armbruster: >>> It needs to be a qdev property, because it belongs to the drive's >>> guest part. Precedence: commit a0fef654 and 6ced55a5. >>> >>> Bonus: info qtree now shows the serial

Re: [Qemu-devel] [V4 Patch 1/4]Qemu: Enhance "info block" to display host cache setting

2011-07-04 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 11:42 AM, Supriya Kannery wrote: > Enhance "info block" to display hostcache setting for each > block device. > > Example: > (qemu) info block > ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 > encrypted=0 > > Enhanced to display "hostcache" setting: > (

Re: [Qemu-devel] [PATCHv2] qxl: make sure primary surface is saved on migration

2011-07-04 Thread Gerd Hoffmann
Hi, +qxl_set_dirty(devram_addr, devram_addr + qxl->rom->surface0_area_size); s/rom/shadow_rom/, then it is perfect. rom points directly to guest memory, better don't trust that. cheers, Gerd

Re: [Qemu-devel] [PATCH v2 0/2]: block: Small drive_init() improvements

2011-07-04 Thread Markus Armbruster
Luiz Capitulino writes: > Please, see individual patches for details. > > v1 -> v2: > - > > o Drop indentation patch > o Use error message suggested by Markus > > blockdev.c | 14 +- > 1 files changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] virtio-blk: Turn drive serial into a qdev property

2011-07-04 Thread Markus Armbruster
Kevin Wolf writes: > Am 20.06.2011 11:35, schrieb Markus Armbruster: >> It needs to be a qdev property, because it belongs to the drive's >> guest part. Precedence: commit a0fef654 and 6ced55a5. >> >> Bonus: info qtree now shows the serial number. >> >> Signed-off-by: Markus Armbruster >> ---

[Qemu-devel] [PATCHv2] qxl: make sure primary surface is saved on migration

2011-07-04 Thread Yonit Halperin
--- hw/qxl.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 2bb36c6..cff95a4 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1165,11 +1165,14 @@ static void qxl_vm_change_state_handler(void *opaque, int running, int reason) qemu_spice_vm_c

Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration

2011-07-04 Thread Gerd Hoffmann
Hi, +qxl_set_dirty(devram_addr, devram_addr + qxl->vga.vram_size); It is enougth to dirty the surface0 area. Otherwise the patch looks fine. cheers, Gerd

[Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration

2011-07-04 Thread Yonit Halperin
--- hw/qxl.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 2bb36c6..9fdeffb 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1165,11 +1165,14 @@ static void qxl_vm_change_state_handler(void *opaque, int running, int reason) qemu_spice_vm_c

[Qemu-devel] [V4 Patch 4/4]Qemu: Add commandline -drive option 'hostcache'

2011-07-04 Thread Supriya Kannery
qemu command option 'hostcache' added to -drive for block devices. While starting a VM from qemu commandline, this option can be used for setting host cache usage for block data access. It is not allowed to specify both 'hostcache' and 'cache' options in the same commandline. User has to specify

[Qemu-devel] [V4 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-04 Thread Supriya Kannery
New command "block_set" added for dynamically changing any of the block device parameters. For now, dynamic setting of hostcache params using this command is implemented. Other block device parameters, can be integrated in similar lines. Signed-off-by: Supriya Kannery --- block.c | 52

[Qemu-devel] [V4 Patch 0/4]Qemu: Hostcache setting from cmdline and monitor

2011-07-04 Thread Supriya Kannery
Currently cache setting of a block device cannot be changed without restarting a running VM. Following patchset is for enabling dynamic change of cache setting for block devices through qemu monitor. Code changes are based on patches from Christoph Hellwig and Prerna Saxena. This patchset

Re: [Qemu-devel] [PATCH v7 03/12] VMDK: probe for monolithicFlat images

2011-07-04 Thread Kevin Wolf
Am 03.07.2011 17:06, schrieb Fam Zheng: > Probe as the same behavior as VMware does. > Recognize image as monolithicFlat descriptor file when the file is text > and the first effective line (not '#' leaded comment or space line) is > either 'version=1' or 'version=2'. No space or upper case charact

[Qemu-devel] [V4 Patch 2/4]Qemu: Error classes for file reopen and data sync failure

2011-07-04 Thread Supriya Kannery
New error classes defined for cases where device not inserted and file reopen failed. Signed-off-by: Supriya Kannery --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+) Index: qemu/qerror.c ===

[Qemu-devel] [V4 Patch 1/4]Qemu: Enhance "info block" to display host cache setting

2011-07-04 Thread Supriya Kannery
Enhance "info block" to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Enhanced to display "hostcache" setting: (qemu) info block ide0-hd0: type=hd removable=0 hostcache=true file=../rhel6

Re: [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-04 Thread Paolo Bonzini
On 07/04/2011 09:26 AM, Hannes Reinecke wrote: Cool. Exactly what I need. FWIW, feel free to add my 'Acked-by' to it. Any chance of getting them included? I'm not very tied to pvscsi; I just needed an HBA that is not a joke by modern standards :) to play with the SCSI layer. There may be

[Qemu-devel] [PATCH] pci: add standard bridge device

2011-07-04 Thread Michael S. Tsirkin
This adds support for a standard pci to pci bridge, enabling support for more than 32 PCI devices in the system. To use, specify the device id as a 'bus' option. Example: -device pci-bridge,id=bridge1 \ -netdev user,id=u \ -device ne2k_pci,id=net2,bus=bridge1,netdev=u TODO:

Re: [Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_debian_5_0

2011-07-04 Thread Alexander Graf
On 04.07.2011, at 07:51, Stefan Weil wrote: > Am 04.07.2011 06:23, schrieb Stefan Hajnoczi: >> On Mon, Jul 4, 2011 at 12:47 AM, Alexander Graf wrote: >>> >>> On 04.07.2011, at 02:04, q...@buildbot.b1-systems.de wrote: >>> The Buildbot has detected a new failure on builder disable_kv

Re: [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-04 Thread Hannes Reinecke
On 07/02/2011 06:14 PM, Stefan Hajnoczi wrote: On Fri, Jul 1, 2011 at 4:35 PM, Hannes Reinecke wrote: +static void megasas_mmio_writel(void *opaque, target_phys_addr_t addr, +uint32_t val) +{ +MPTState *s = opaque; +target_phys_addr_t frame_addr; +uin

Re: [Qemu-devel] Wiki spam

2011-07-04 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 8:27 AM, Brad Hards wrote: > On Mon, 4 Jul 2011 03:15:06 PM Stefan Hajnoczi wrote: >> Thanks.  I have a regular wiki account so I checked the Recent Changes >> page and undid the spam changes that I saw: >> >> http://wiki.qemu.org/Special:RecentChanges > Is there a way to co

[Qemu-devel] KVM call agenda for July 5

2011-07-04 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] Wiki spam

2011-07-04 Thread Brad Hards
On Mon, 4 Jul 2011 03:15:06 PM Stefan Hajnoczi wrote: > Thanks. I have a regular wiki account so I checked the Recent Changes > page and undid the spam changes that I saw: > > http://wiki.qemu.org/Special:RecentChanges Is there a way to completely remove it? There is still spam on the wiki showi

Re: [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-04 Thread Hannes Reinecke
On 07/04/2011 08:34 AM, Paolo Bonzini wrote: On 07/04/2011 08:13 AM, Hannes Reinecke wrote: On 07/03/2011 04:36 PM, Paolo Bonzini wrote: On 07/02/2011 03:50 PM, Hannes Reinecke wrote: (And no, I will not getting into another dog-fight with Paul B. here. Virtio can do without bounce buffers. AH