Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits

2011-06-24 Thread Hans de Goede
Hi, On 06/25/2011 02:15 AM, Brad Hards wrote: 5/11 does this: -#define PORTSC_RO_MASK 0x007021c5 +#define PORTSC_RO_MASK 0x007021c4 before 8/11 does this: -#define PORTSC_RO_MASK 0x007021c4 +#define PORTSC_RO_MASK 0x007021c0 You could push those together if there was

[Qemu-devel] GSoC Intro - Intel Itanium (IA64) processor emulation

2011-06-24 Thread Prashant Vaibhav
Hello! My name is Prashant Vaibhav and I am working this summer on a Google Summer of Code project to implement software emulation of the Intel Itanium (IA64) architecture. The project is being mentored by Alexander Graf. I am a student studying at Jacobs University in Germany (staying in India fo

Re: [Qemu-devel] QEMU timing requirements

2011-06-24 Thread Mulyadi Santosa
On Sat, Jun 25, 2011 at 09:34, felix.matenaar@rwth-aachen wrote: > Hello, > > I am currently implementing some heuristics using a patched qemu > (i386-softmmu). Two of them take some time for each vm memory access. If I > run them both, suddenly qemu segfaults while executing a BBL. Using just one

[Qemu-devel] QEMU timing requirements

2011-06-24 Thread felix.matenaar@rwth-aachen
Hello, I am currently implementing some heuristics using a patched qemu (i386-softmmu). Two of them take some time for each vm memory access. If I run them both, suddenly qemu segfaults while executing a BBL. Using just one of them never triggers this problem. Are there any known timing issue

Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits

2011-06-24 Thread Brad Hards
5/11 does this: -#define PORTSC_RO_MASK 0x007021c5 +#define PORTSC_RO_MASK 0x007021c4 before 8/11 does this: > -#define PORTSC_RO_MASK 0x007021c4 > +#define PORTSC_RO_MASK 0x007021c0 You could push those together if there was a v2. I don't think its important though. Eve

[Qemu-devel] [PATCH 10/11] usb-uhci: Add support for being a companion controller

2011-06-24 Thread Hans de Goede
To use as a companion controller set the masterbus property. Signed-off-by: Hans de Goede --- hw/usb-uhci.c | 48 ++-- 1 files changed, 42 insertions(+), 6 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index b081b45..a7ab4a1 100644 --- a/h

[Qemu-devel] [PATCH 09/11] usb-ehci: Add support for registering companion controllers

2011-06-24 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb-ehci.c | 174 +++-- 1 files changed, 144 insertions(+), 30 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 0e8b3d1..ae39940 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -20,9 +20,6 @@

[Qemu-devel] [PATCH 06/11] usb-ehci: cleanup port reset handling

2011-06-24 Thread Hans de Goede
Doing a usb_attach when dev is NULL will just result in the port detach op getting called even though nothing was connected in the first place. Signed-off-by: Hans de Goede --- hw/usb-ehci.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehc

Re: [Qemu-devel] [BREAKAGE] KVM pulls break MinGW builds

2011-06-24 Thread Jonathan A. Kollasch
On Thu, Jun 23, 2011 at 08:41:15AM +0800, Roy Tam wrote: > The pulls makes KVM enabled by default, which is not available in > MinGW(Win32) environment. Even through I put --disable-kvm switch in > ./configure, I still can't get QEMU compiled: > Similar issues on NetBSD. Jonathan Kollasc

[Qemu-devel] [PATCH 8/8] vga: Fix type of lfb/map_addr/end.

2011-06-24 Thread Richard Henderson
These addresses have been passed through pci_to_cpu_addr, and thus need to be full target_phys_addr_t. Signed-off-by: Richard Henderson --- hw/vga_int.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vga_int.h b/hw/vga_int.h index d2811bd..eee91a8 100644 ---

[Qemu-devel] [PATCH 7/8] target-alpha: Add high-resolution access to wall clock and an alarm.

2011-06-24 Thread Richard Henderson
The alarm is a fully general one-shot time comparator, which will be usable under Linux as a hrtimer source. It's much more flexible than the RTC source available on real hardware. The wall clock allows the guest access to the host timekeeping. Much like the KVM wall clock source for other guest

[Qemu-devel] [PATCH 6/8] target-alpha: Implement HALT IPR.

2011-06-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-alpha/helper.h|1 + target-alpha/op_helper.c | 10 ++ target-alpha/translate.c |5 + 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/target-alpha/helper.h b/target-alpha/helper.h index 2dec57e..c352c24 100644 --

[Qemu-devel] [PATCH 2/8] pci: Export pci_to_cpu_addr.

2011-06-24 Thread Richard Henderson
This is, more or less, the read accessor to pci_bus_set_mem_base as a write accessor. It will be needed for implementing sparse memory spaces for Alpha. Signed-off-by: Richard Henderson --- hw/pci.c |3 +-- hw/pci.h |1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 11/11] usb-ohci: Add support for being a companion controller

2011-06-24 Thread Hans de Goede
To use as a companion controller, use pci-ohci as device and set the masterbus and num-ports properties, ie: -device usb-ehci,addr=0b.1,multifunction=on,id=ehci0 -device pci-ohci,addr=0b.0,multifunction=on,masterbus=ehci0.0,num-ports=4 Signed-off-by: Hans de Goede --- hw/usb-ohci.c | 59 +

[Qemu-devel] [PATCH 3/8] target-alpha: Add custom PALcode image for CLIPPER emulation.

2011-06-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- .gitmodules |3 +++ Makefile|3 ++- configure |8 +++- pc-bios/README |3 +++ pc-bios/palcode-clipper | Bin 0 -> 185703 bytes roms/qemu-palcode |1 + 6 files changed, 16 inserti

[Qemu-devel] [PATCH 05/11] usb-ehci: Connect Status bit is read only, don't allow changing it by the guest

2011-06-24 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb-ehci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 158e147..0b1cdaf 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -103,10 +103,10 @@ #define PORTSC_BEGIN PORTSC #define PORTSC

[Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits

2011-06-24 Thread Hans de Goede
The PED bit should only be set for highspeed devices and the PEDC bit should not be set on "normal" PED bit changes, only on io errors. Signed-off-by: Hans de Goede --- hw/usb-ehci.c | 24 +++- 1 files changed, 11 insertions(+), 13 deletions(-) diff --git a/hw/usb-ehci.c b

[Qemu-devel] [PATCH 4/8] target-alpha: Add CLIPPER emulation.

2011-06-24 Thread Richard Henderson
This is a DP264 variant, SMP capable, no unusual hardware present. The emulation does not currently include any PCI IOMMU code. Hopefully the generic support for that can be merged to HEAD soon. Signed-off-by: Richard Henderson --- Makefile.target |1 + default-configs/alp

[Qemu-devel] [PATCH 02/11] usb: Make port wakeup and complete ops take a USBPort instead of a Device

2011-06-24 Thread Hans de Goede
This makes them consistent with the attach and detach ops, and in general it makes sense to make portops take a port as argument. This also makes adding support for a companion controller easier / cleaner. Signed-off-by: Hans de Goede --- hw/usb-ehci.c |2 +- hw/usb-hub.c | 10 +-

[Qemu-devel] [PATCH 07/11] usb: assert on calling usb_attach(port, NULL) on a port without a dev

2011-06-24 Thread Hans de Goede
with the "usb-ehci: cleanup port reset handling" patch in place no callers are calling usb_attach(port, NULL) for a port where port->dev is NULL. Doing that makes no sense as that causes the port detach op to get called for a port with nothing attached. Add an assert that port->dev != NULL when de

[Qemu-devel] [PATCH 5/8] target-alpha: Implement WAIT IPR.

2011-06-24 Thread Richard Henderson
--- target-alpha/translate.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 936760c..e13ac30 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -1618,9 +1618,10

[Qemu-devel] [PATCH 01/11] usb: Add a register_companion USB bus op.

2011-06-24 Thread Hans de Goede
This is a preparation patch for adding support for USB companion controllers. Signed-off-by: Hans de Goede --- hw/usb-bus.c | 25 + hw/usb.h |4 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 2abce12..052fa

[Qemu-devel] [PATCH 04/11] usb-ehci: drop unused num-ports state member

2011-06-24 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb-ehci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index f42648c..158e147 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -373,7 +373,6 @@ struct EHCIState { qemu_irq irq; target_phys_ad

[Qemu-devel] [PATCH 1/8] Export the unassigned_mem read/write functions.

2011-06-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- cpu-common.h |7 +++ exec.c | 12 ++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index b027e43..0654d95 100644 --- a/cpu-common.h +++ b/cpu-common.h @@ -56,6 +56,13 @@ static inline void

[Qemu-devel] [PATCH 03/11] usb: Replace device_destroy bus op with a child_detach port op

2011-06-24 Thread Hans de Goede
Note this fixes 2 things in one go, first of all the device_destroy bus op should be a device_detach bus op, as pending async packets from the device should be cancelled on detach not on destroy. Secondly having this as a bus op won't work with companion controllers, since then there will be 1 bus

[Qemu-devel] RFC/PULL: usb: add support for companion controllers

2011-06-24 Thread Hans de Goede
Hi Gerd et all, These patches add support for adding an emulated uhci or ohci companion controller to our emulated ehci controller. Usage examples: -device usb-ehci,addr=0b.1,multifunction=on,id=ehci0 -device pci-ohci,addr=0b.0,multifunction=on,masterbus=ehci0.0,num-ports=4 -device usb-ehci,addr

[Qemu-devel] [PATCH 0/8] Alpha system emulation, v6

2011-06-24 Thread Richard Henderson
Changes v5->v6 * Rebase against master, which now includes most of the target-alpha/ changes from v5. * VGA now works, with the PALcode initializing text mode. There are still problems with interrupts getting lost, somehow. It doesn't seem to happen with the ISA or clock devices, but onl

[Qemu-devel] [PATCH 13/13] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Stefan Hajnoczi
From: Marc-Antoine Perennou pulse/simple.h does not include stdlib.h We cannot use NULL since it may not be defined Use 0 instead Signed-off-by: Marc-Antoine Perennou Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- configure |2 +- 1 files changed, 1 insertions(+), 1 deleti

[Qemu-devel] [PATCH 12/13] exec: last_first_tb was only used in !ONLY_USER case

2011-06-24 Thread Stefan Hajnoczi
From: Juan Quintela Once there, use a better variable name. Signed-off-by: Juan Quintela Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- exec.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index b03b5be..7236281 100644 --- a/

[Qemu-devel] [PATCH 11/13] w32: Remove redundant definitions of PRI*64

2011-06-24 Thread Stefan Hajnoczi
From: Stefan Weil The PRI*64 macros are defined in MinGW's inttypes.h since 2002, so they are not needed in qemu-common.h (which includes inttypes.h). Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- qemu-common.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) di

[Qemu-devel] [PATCH 09/13] Fix comment typos in hw/armv7m.c

2011-06-24 Thread Stefan Hajnoczi
From: Matthew Fernandez Fix a couple of typos in comments. Signed-off-by: Matthew Fernandez Acked-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- hw/armv7m.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/armv7m.c b/hw/armv7m.c index 72d010a..83f3393 100644

[Qemu-devel] [PATCH 08/13] MAINTAINERS: Fix typo in email address

2011-06-24 Thread Stefan Hajnoczi
From: Peter Maydell Fix a typo in one of the copies of Aurelien Jarno's email address. Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 35d4496..6115e4e 100644

[Qemu-devel] [PATCH 06/13] Spell "unkown" correctly in error_report() arguments

2011-06-24 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- hw/lm32_sys.c |2 +- hw/lm32_timer.c|4 ++-- hw/lm32_uart.c |4 ++-- hw/milkymist-ac97.c|4 ++-- hw/milkymist-memcard.c |4 ++-- hw/milkymist-sysctl.c |

[Qemu-devel] [PATCH 05/13] qemu-img: Don't prepend qemu-img to error messages twice.

2011-06-24 Thread Stefan Hajnoczi
From: Markus Armbruster error_report() prepends the location already. Example: $ qemu-img convert -6 qemu-img: qemu-img: option -6 is deprecated, please use '-o compat6' instead! Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- qemu-img.c |8 1 files changed,

[Qemu-devel] [PATCH 01/13] configure: Don't create symlinks to nonexistent targets

2011-06-24 Thread Stefan Hajnoczi
From: Peter Maydell When we create the symlinks to source tree files, don't create them if the file is not actually present in the source tree; this will happen if the file is in a git submodule that wasn't checked out. This also avoids the odd effect where an in-source-tree configure will end u

Re: [Qemu-devel] [PATCH 1/2] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-24 Thread Alon Levy
On Fri, Jun 24, 2011 at 04:37:39PM +0200, Christophe Fergeau wrote: > The previous parser had copy and paste errors when computing > vname_length and type_params_length, "name" was used instead > of respectively vname and type_params. This led to length that could > be bigger than the input string,

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Max Filippov
> Here are my rules of thumb for generating code where the code > generated might change based on some bit of CPU state: > > When you are generating code, if the code you generate will > change based on the contents of something in the CPUState struct, > then the bit of CPUState you are looking at

Re: [Qemu-devel] [PATCH v4 2/2] Add support for Zipit Z2 machine

2011-06-24 Thread Peter Maydell
On 24 June 2011 18:06, Vasily Khoruzhick wrote: > On Friday 24 June 2011 17:45:06 Peter Maydell wrote: >> Have you tried vmload/vmsave, by the way? (I don't know if all the >> devices the pxa2xx uses have save/load support implemented, it >> would be interesting to check if you haven't already.) >

[Qemu-devel] [PATCH 04/13] Strip trailing '\n' from error_report()'s first argument

2011-06-24 Thread Stefan Hajnoczi
From: Markus Armbruster error_report() prepends location, and appends a newline. The message constructed from the arguments should not contain a newline. Fix the obvious offenders. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- block-migration.c |2 +- block/q

Re: [Qemu-devel] [PATCH v4 2/2] Add support for Zipit Z2 machine

2011-06-24 Thread Vasily Khoruzhick
On Friday 24 June 2011 17:45:06 Peter Maydell wrote: > On 17 June 2011 11:04, Vasily Khoruzhick wrote: > > Zipit Z2 is small PXA270 based handheld. > > > > Signed-off-by: Vasily Khoruzhick > > These patches are affected by the bug in current qemu master > which breaks cpu_physical_memory_map()

Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-24 Thread Peter Maydell
On 24 June 2011 12:08, wrote: > From: Stefano Stabellini > > qemu_ram_ptr_length should take ram_addr_t as argument rather than > target_phys_addr_t because is doing comparisons with RAMBlock addresses. > > cpu_physical_memory_map should create a ram_addr_t address to pass to > qemu_ram_ptr_leng

[Qemu-devel] [PATCH 02/13] Align dummy display to fixed-size active console

2011-06-24 Thread Stefan Hajnoczi
From: Jan Kiszka This fixes e.g. '-vga none -monitor vc:120Cx50C'. Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- console.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index 9c6addf..acd8ca1 100644 --- a/console.c +++ b/

[Qemu-devel] [PATCH 03/13] sheepdog: qemu_bh_new() can't return null pointer, drop check

2011-06-24 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0392ca8..2180299 100644 --- a/block/sheepdog.c +++ b/block/sheepd

[Qemu-devel] [PATCH v2 2/2] xen: add vkbd support for PV on HVM guests

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini Register the vkbd backend even when running as device emulator for HVM guests: it is useful because it doesn't need a frequent timer like usb. Check whether the XenInput DisplayState has been set in the initialise state, rather than the input state. In case the DisplaySt

[Qemu-devel] [PATCH 10/13] Do not include compatfd for WIN32

2011-06-24 Thread Stefan Hajnoczi
From: Jan Kiszka sigset_t, used by that header, is not available in mingw32 environments. Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- cpus.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index 0699f37..ded2100 100644 --- a/cpus.c +

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 2:31 PM, Marc-Antoine Perennou wrote: > On 10 June 2011 09:14, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 9 June 2011 18:44, Andreas Färber wrote: Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: > Manually including stddef.h or replacing N

[Qemu-devel] [PULL 00/13] Trivial patches for June 16 to June 24 2011

2011-06-24 Thread Stefan Hajnoczi
(I currently do not have access to my email address.) The following changes since commit 744d3644181ddb16ef5944a0f9217e46961c8c84: coreaudio: Fix OSStatus format specifier (2011-06-23 18:56:58 +0400) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-

[Qemu-devel] [PATCH 07/13] blockdev: Put space after comma in error message

2011-06-24 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- blockdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 1502575..7d579d6 100644 --- a/blockdev.c +++ b/blockdev.c @@ -293,7 +293,7 @@ DriveInfo

[Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params" node

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini When disk is a cdrom and the drive is empty the "params" node in xenstore might be missing completely: cope with it instead of segfaulting. Updated in v2: - actually removed the strchr(blkdev->params, ':') that caused the segfault; - free all the allocated strings fro

Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore "params" node

2011-06-24 Thread Stefano Stabellini
On Fri, 24 Jun 2011, Peter Maydell wrote: > On 24 June 2011 15:50, wrote: > >     /* read xenstore entries */ > >     if (blkdev->params == NULL) { > >         blkdev->params = xenstore_read_be_str(&blkdev->xendev, "params"); > > +        if (blkdev->params != NULL) > > +            h = strchr(bl

Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests

2011-06-24 Thread Stefano Stabellini
On Fri, 24 Jun 2011, Peter Maydell wrote: > On 24 June 2011 15:54, wrote: > > > +    if (!in->c.ds) { > > +        char *vfb = xenstore_read_str(NULL, "device/vfb"); > > +        if (vfb == NULL) { > > +            /* there is no vfb, run vkbd on its own */ > > +            in->c.ds = get_displa

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Stefan Hajnoczi
On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: > pulse/simple.h does not include stdlib.h > We cannot use NULL since it may not be defined > Use 0 instead > > Signed-off-by: Marc-Antoine Perennou > --- > configure |2 +- > 1 files changed, 1 insertions(+), 1 deletions

[Qemu-devel] [PATCH] xen_console: fix memory leak

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini con_init leaks the string "type", fix it. Signed-off-by: Stefano Stabellini --- hw/xen_console.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/xen_console.c b/hw/xen_console.c index e88714f..519d5f5 100644 --- a/hw/xen_console.c +++

[Qemu-devel] [PATCH 1/2] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-24 Thread Christophe Fergeau
The previous parser had copy and paste errors when computing vname_length and type_params_length, "name" was used instead of respectively vname and type_params. This led to length that could be bigger than the input string, and to access out of the array bounds when trying to copy these strings. va

Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests

2011-06-24 Thread Peter Maydell
On 24 June 2011 15:54, wrote: > +    if (!in->c.ds) { > +        char *vfb = xenstore_read_str(NULL, "device/vfb"); > +        if (vfb == NULL) { > +            /* there is no vfb, run vkbd on its own */ > +            in->c.ds = get_displaystate(); > +        } else { > +            free(vfb);

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Marc-Antoine Perennou
On 10 June 2011 09:14, Markus Armbruster wrote: > Peter Maydell writes: > >> On 9 June 2011 18:44, Andreas Färber wrote: >>> Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: Manually including stddef.h or replacing NULL by 0 or (void*)0 makes it work. >>> >>> Then please submit a

Re: [Qemu-devel] [PATCH v4 2/2] Add support for Zipit Z2 machine

2011-06-24 Thread Peter Maydell
On 17 June 2011 11:04, Vasily Khoruzhick wrote: > Zipit Z2 is small PXA270 based handheld. > > Signed-off-by: Vasily Khoruzhick These patches are affected by the bug in current qemu master which breaks cpu_physical_memory_map() so I haven't tested them yet. Some minor nitpicks (nearly there now)

Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore "params" node

2011-06-24 Thread Peter Maydell
On 24 June 2011 15:50, wrote: >     /* read xenstore entries */ >     if (blkdev->params == NULL) { >         blkdev->params = xenstore_read_be_str(&blkdev->xendev, "params"); > +        if (blkdev->params != NULL) > +            h = strchr(blkdev->params, ':'); >         h = strchr(blkdev->param

Re: [Qemu-devel] [PATCH 2/2] libcacard: replace copy_string with strndup

2011-06-24 Thread Alon Levy
On Fri, Jun 24, 2011 at 04:37:40PM +0200, Christophe Fergeau wrote: > copy_string reimplements strndup, this commit removes it and > replaces all copy_string uses with strndup. > Reviewed-by: Alon Levy > Signed-off-by: Christophe Fergeau > --- > libcacard/vcard_emul_nss.c | 23 ++---

[Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini Register the vkbd backend even when running as device emulator for HVM guests: it is useful because it doesn't need a frequent timer like usb. Check whether the XenInput DisplayState has been set in the initialise state, rather than the input state. In case the DisplaySt

[Qemu-devel] [PATCH 1/2] xen: enable console and disk backend in HVM mode

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini Initialize the Xen console backend and the Xen disk backend even when running in HVM mode so that PV on HVM drivers can connect to them. Signed-off-by: Stefano Stabellini --- xen-all.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xen-

[Qemu-devel] [PATCH 0/2] xen: enable PV backends for HVM guests

2011-06-24 Thread Stefano Stabellini
Hi all, this small patch series enables console, disk and kbd backends for HVM guests, for the benefit of Linux and Windows PV on HVM drivers. Stefano Stabellini (2): xen: enable console and disk backend in HVM mode xen: add vkbd support for PV on HVM guests hw/xenfb.c | 19 +++

[Qemu-devel] [PATCH v2] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support

2011-06-24 Thread Alon Levy
Add two new IOs. QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change (windows driver implementation is such that this is done on each of those occasions). QXL_IO_FLUSH_RELEASE - used to ensure

Re: [Qemu-devel] [PATCH 09/14] exec: last_first_tb was only used in !ONLY_USER case

2011-06-24 Thread Stefan Hajnoczi
On Thu, Jun 02, 2011 at 01:53:44PM +0200, Juan Quintela wrote: > Once there, use a better variable name. > > Signed-off-by: Juan Quintela > --- > exec.c | 10 +++--- > 1 files changed, 7 insertions(+), 3 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/st

[Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw"

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini Sometimes the toolstack uses "aio" without an additional format identifier, in such cases use "raw". Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 801da5

[Qemu-devel] [PATCH] xen_disk: cope with missing xenstore "params" node

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini When disk is a cdrom and the drive is empty the "params" node in xenstore might be missing completely: cope with it instead of segfaulting. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) d

[Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-24 Thread Alon Levy
Currently we define the following relation between modes and primary surface existance: QXL_MODE_COMPAT QXL_MODE_NATIVE primary exists QXL_MODE_UNDEFINED QXL_MODE_VGA primary doesn't exist This, coupled with disallowing various IO's when not in QXL_MODE_NATIVE or COMPAT means that the S

[Qemu-devel] [PATCH 2/2] libcacard: replace copy_string with strndup

2011-06-24 Thread Christophe Fergeau
copy_string reimplements strndup, this commit removes it and replaces all copy_string uses with strndup. Signed-off-by: Christophe Fergeau --- libcacard/vcard_emul_nss.c | 23 ++- 1 files changed, 6 insertions(+), 17 deletions(-) diff --git a/libcacard/vcard_emul_nss.c b/l

[Qemu-devel] [PATCH v2] qxl: add dev id to guest prints

2011-06-24 Thread Alon Levy
--- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 865e985..3d5c823 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1055,7 +1055,8 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) break; case QXL_IO_LOG:

[Qemu-devel] [PATCH] usb-hid: Fix 0/0 position for Windows in tablet mode

2011-06-24 Thread Jan Kiszka
For unknown reasons, Windows drivers (tested with XP and Win7) ignore usb-tablet events that move the pointer to 0/0. So always set bit 0 of the coordinates. Signed-off-by: Jan Kiszka --- hw/usb-hid.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb-hid.c b/hw

[Qemu-devel] [PATCH v2] S3&S4 support

2011-06-24 Thread Alon Levy
This is a rewrite of v1, doesn't use any new api, reuses stop+start+destroy_surfaces instead of the previously introduced update_mem spice server function. stop does a flush of all commands, updating all the surfaces, and with destroy surfaces the result is the same - everything has been pushed e

[Qemu-devel] [PATCH v2] qxl: add mode to debugprint on destroy primary

2011-06-24 Thread Alon Levy
--- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e2b07dd..5266707 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1088,7 +1088,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) } case QXL_IO_DESTROY_PRIMARY:

[Qemu-devel] [PATCH v2] qxl: update revision to QXL_REVISION_STABLE_V10

2011-06-24 Thread Alon Levy
also errors if provided revision is wrong. 0 is reserved for experimental revision, the other valid values are as before: 1 - V04 2 - V06 And the new 3 - V10 --- hw/qxl.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b4bc376..96

[Qemu-devel] [PATCH v2] qxl: update and add debug prints

2011-06-24 Thread Alon Levy
--- hw/qxl.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 96f9c55..865e985 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -361,7 +361,7 @@ static int interface_get_command(QXLInstance *sin, struct QXLCommandExt *ext) switch (qxl->mode

[Qemu-devel] [PATCH v2] qxl: abort on panic instead of exit

2011-06-24 Thread Alon Levy
--- hw/qxl.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index 6dd38e6..584f02b 100644 --- a/hw/qxl.h +++ b/hw/qxl.h @@ -87,7 +87,7 @@ typedef struct PCIQXLDevice { #define PANIC_ON(x) if ((x)) { \ printf("%s: PANIC

[Qemu-devel] [PATCH v2] qxl: add io_port_to_string

2011-06-24 Thread Alon Levy
--- hw/qxl.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3d5c823..b4bc376 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -350,6 +350,67 @@ static const char *qxl_mode_to_string(int mode)

Re: [Qemu-devel] [PULL] usb patch queue

2011-06-24 Thread Hans de Goede
Hi, Entire series looks good to me, including my own patches ;) Ack series. Regards, Hans On 06/24/2011 12:59 PM, Gerd Hoffmann wrote: Hi, Here comes the USB patch queue. Nothing major, just a bunch of little fixes and improvements. please pull, Gerd The following changes since co

[Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga

2011-06-24 Thread Alon Levy
The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. --- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 5266707..96f9c55 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1001,9 +1001,9 @@ static void i

[Qemu-devel] [PATCH v2] qxl-logger: add timestamp to command log

2011-06-24 Thread Alon Levy
--- hw/qxl-logger.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl-logger.c b/hw/qxl-logger.c index 76f43e6..74cadba 100644 --- a/hw/qxl-logger.c +++ b/hw/qxl-logger.c @@ -19,6 +19,7 @@ * along with this program; if not, see . *

[Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini qemu_ram_ptr_length should take ram_addr_t as argument rather than target_phys_addr_t because is doing comparisons with RAMBlock addresses. cpu_physical_memory_map should create a ram_addr_t address to pass to qemu_ram_ptr_length from PhysPageDesc phys_offset. Remove co

[Qemu-devel] [PATCH v2] qxl: interface_get_command: fix reported mode

2011-06-24 Thread Alon Levy
report correct mode when in undefined mode. introduces qxl_mode_to_string, and uses it in another place that looks helpful (qxl_post_load) --- hw/qxl.c | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e45f33a..e2b07dd 100644

[Qemu-devel] [PATCH v2] qxl: set mm_time in vga update

2011-06-24 Thread Alon Levy
This fixes a problem where on windows 7 startup phase, before the qxl driver is loaded, the drawables are sufficiently large and video like to trigger a stream, but the lack of a filled mm time field triggers a warning in spice-gtk. --- ui/spice-display.c |5 + 1 files changed, 5 insertion

[Qemu-devel] [PATCH 12/13] usb-storage: Turn drive serial into a qdev property usb-storage.serial

2011-06-24 Thread Gerd Hoffmann
From: Markus Armbruster It needs to be a qdev property, because it belongs to the drive's guest part. Precedence: commit a0fef654 and 6ced55a5. Bonus: info qtree now shows the serial number. Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c | 14 +++---

Re: [Qemu-devel] [PATCH 06/11] exec.c: refactor cpu_physical_memory_map

2011-06-24 Thread Stefano Stabellini
On Thu, 23 Jun 2011, Peter Maydell wrote: > On 23 June 2011 18:56, Stefano Stabellini > wrote: > > Thanks for the detailed explanation of the problem, I think I understand > > what I have to do to fix. > > However I would like to have a repro of the bug before sending any > > patches, so that I am

[Qemu-devel] [PATCH 11/13] hw/usb-ohci.c: Fix handling of remote wakeup corner cases

2011-06-24 Thread Gerd Hoffmann
From: Peter Maydell Correct a number of minor errors in the OHCI wakeup implementation: * when the port is suspended but the controller is not, raise RHSC * when the controller is suspended but the port is not, raise RD * when the controller is suspended, move it to resume state These fix som

[Qemu-devel] [PATCH 05/13] ehci: switch to nanoseconds

2011-06-24 Thread Gerd Hoffmann
Make ehci use nanoseconds everywhere. Simplifies time calculations. Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c | 29 +++-- 1 files changed, 11 insertions(+), 18 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index fa9792e..91fb7de 100644 --- a/hw/usb-ehci.

[Qemu-devel] [PATCH 09/13] usb-linux: allow "compatible" high speed devices to connect at fullspeed

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede Some usb2 highspeed devices, like usb-msd devices, work fine when redirected to a usb1 virtual controller. Allow this to avoid the new speedhecks causing regressions for users who do not enable the new experimental ehci code. Signed-off-by: Gerd Hoffmann --- usb-linux.c |

[Qemu-devel] [PATCH 06/13] usb-bus: Don't allow attaching a device to a bus with no free ports

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 480956d..0a49921 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -181,6 +181,11 @@ static void do_attach(USBDevice *de

[Qemu-devel] [PATCH 04/13] ehci: add freq + maxframes properties

2011-06-24 Thread Gerd Hoffmann
Add properties for the wakeup rate and the max number of frames ehci will process at once. The wakeup rate defaults to 1000 which equals the usb frame rate. This can be reduced to make qemu wake up less often when ehci is active. In case the wakeup rate is reduced or the ehci timer is delayed du

Re: [Qemu-devel] unix domain socket communication with guests

2011-06-24 Thread Joel Uckelman
On Fri, Jun 24, 2011 at 4:54 AM, Amit Shah wrote: >> >> I guess this means I need to get networking running on the guest so >> that it has a port visible to the host on which my server can listen. >> Is there a guide somewhere for doing that? I've not had any success in >> an afternoon of searchin

[Qemu-devel] [PULL] usb patch queue

2011-06-24 Thread Gerd Hoffmann
Hi, Here comes the USB patch queue. Nothing major, just a bunch of little fixes and improvements. please pull, Gerd The following changes since commit 48e2faf222cbf4abab7c8e4b3f44229ec98eae7f: net: Warn about "-net nic" options which were ignored (2011-06-22 07:18:39 -0500) are availab

Re: [Qemu-devel] [Qemu-trivial] [PATCH] w32: Remove redundant definitions of PRI*64

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 12:15:49PM +0200, Stefan Weil wrote: > The PRI*64 macros are defined in MinGW's inttypes.h since 2002, > so they are not needed in qemu-common.h (which includes inttypes.h). > > Signed-off-by: Stefan Weil > --- > qemu-common.h |5 - > 1 files changed, 0 insertions

Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users

2011-06-24 Thread Markus Armbruster
Ping? Markus Armbruster writes: > Markus Armbruster (4): > usb-ccid: Drop unused CCIDCardInfo callback print() > virtio-serial: Clean up virtser_bus_dev_print() output > virtio-serial: Turn props any virtio-serial-bus device must have into > bus props > ide: Turn properties any IDE d

Re: [Qemu-devel] [PATCH v2 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 9:18 AM, wrote: > From: Fam Zheng > > Parse vmdk decriptor file and open mono flat image. > Read/write the flat extent. > > Signed-off-by: Fam Zheng > --- >  block/vmdk.c |  190 > ++ >  1 files changed, 177 inserti

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Peter Maydell
On 24 June 2011 11:08, Max Filippov wrote: >> Here are my rules of thumb for generating code where the code >> generated might change based on some bit of CPU state: >> >> When you are generating code, if the code you generate will >> change based on the contents of something in the CPUState struc

[Qemu-devel] [PATCH 10/13] usb-bus: Don't allow speed mismatch while attaching devices

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index fc72018..2abce12 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -200,6 +200,11 @@ static int do_attach(USBDevice *dev

[Qemu-devel] [PATCH 13/13] usb: ignore USB_DT_DEBUG

2011-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c |4 hw/usb.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index 0b9d351..bc6858f 100644 --- a/hw/usb-desc.c +++ b/hw/usb-desc.c @@ -385,6 +385,10 @@ int usb_desc_get_descriptor(U

[Qemu-devel] [PATCH 07/13] usb: Proper error propagation for usb_device_attach errors

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c | 25 + hw/usb-msd.c |5 +++-- usb-linux.c |6 +- 3 files changed, 21 insertions(+), 15 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 0a49921..fc72018 100644 --- a/hw/usb-bus.

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Max Filippov
> That should be the last block matching the address in the > log output if you run *under gdb* with -d out_asm. This is the case. > BTW you say this is a clean build, but as far as I could see > it looks like your emulated target is not part of standard > QEMU;  it seems to have a register named

[Qemu-devel] [PATCH] w32: Remove redundant definitions of PRI*64

2011-06-24 Thread Stefan Weil
The PRI*64 macros are defined in MinGW's inttypes.h since 2002, so they are not needed in qemu-common.h (which includes inttypes.h). Signed-off-by: Stefan Weil --- qemu-common.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/qemu-common.h b/qemu-common.h index 10949

  1   2   >