[Qemu-devel] [PATCH] ac97: Remove unused local variables

2011-05-07 Thread Stefan Weil
cppcheck report: hw/ac97.c:1004: style: Variable 'written' is assigned a value that is never used hw/ac97.c:1072: style: Variable 'written' is assigned a value that is never used Signed-off-by: Stefan Weil --- hw/ac97.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --gi

[Qemu-devel] [ANNOUNCE] QEMU 0.14.1.tar.gz is available

2011-05-07 Thread Justin M. Forbes
The QEMU team is pleased to announce the availability of the 0.14.1 stable release. Download instructions are available at http://wiki.qemu.org/Download A detailed change log is available at http://wiki.qemu.org/Changelog/0.14 On behalf of the QEMU team, I'd like to thank everyone who contribute

[Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci

2011-05-07 Thread Alexander Graf
The e500 PCI controller isn't qdev'ified yet. This leads to severe issues when running with -drive. To be able to use a virtio disk with an e500 VM, let's convert the PCI controller over to qdev. Signed-off-by: Alexander Graf --- v2 -> v3: - rebase to current code base - fix endian issue

Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci

2011-05-07 Thread Alexander Graf
On 08.05.2011, at 01:48, Paul Brook wrote: >> @@ -250,7 +254,6 @@ static const VMStateDescription vmstate_ppce500_pci = { >> >> .minimum_version_id = 1, >> .minimum_version_id_old = 1, >> .fields = (VMStateField[]) { >> >> -VMSTATE_PCI_DEVICE_POINTER(pci_dev, PPCE500PCI

Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci

2011-05-07 Thread Paul Brook
> @@ -250,7 +254,6 @@ static const VMStateDescription vmstate_ppce500_pci = { > > .minimum_version_id = 1, > .minimum_version_id_old = 1, > .fields = (VMStateField[]) { > > -VMSTATE_PCI_DEVICE_POINTER(pci_dev, PPCE500PCIState), Doesn't this require incrementing versio

[Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU

2011-05-07 Thread Alexander Graf
Most of the code to support e500 style MMUs is already in place, but we're missing on some of the special TLB0-TLB1 handling code and slightly different TLB modification. This patch adds support for the FSL style MMU. Signed-off-by: Alexander Graf --- v1 -> v2: - fix linux-user build - op

[Qemu-devel] [PATCH 4/7] PPC: Add another 64 bits to instruction feature mask

2011-05-07 Thread Alexander Graf
To enable quick runtime detection of instruction groups to the currently selected CPU emulation, we have a feature mask of what exactly the respective instruction supports. This feature mask is 64 bits long and we just successfully exceeded those 64 bits. To add more features, we need to think of

[Qemu-devel] [PATCH 3/7] PPC: Add GS MSR definition

2011-05-07 Thread Alexander Graf
The BookE specification defines MSR bit 28 as Guest State. Add it to the list of MSR macros. Signed-off-by: Alexander Graf --- target-ppc/cpu.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 303f8ce..c6b2255 100644 --- a/target

[Qemu-devel] [PATCH 6/7] PPC MPC7544DS: Use new TLB helper function

2011-05-07 Thread Alexander Graf
Now that we have some nice helpers that can find us a TLB entry, let's use that on the machine initialization code, so we don't need to know about the internals of the TLB array. Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v5

2011-05-07 Thread Alexander Graf
In a global effort to get rid of KVM-only targets, this is the next important piece of the puzzle: e500 emulation :). We had support for running an e500 KVM guest for a while now, but the code could not be tested without a real e500 machine, because it required KVM to work. This patchset adds emul

[Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci

2011-05-07 Thread Alexander Graf
The e500 PCI controller isn't qdev'ified yet. This leads to severe issues when running with -drive. To be able to use a virtio disk with an e500 VM, let's convert the PCI controller over to qdev. Signed-off-by: Alexander Graf --- v2 -> v3: - rebase to current code base - fix endian issue

[Qemu-devel] [PATCH 1/7] PPC: Make MPC8544DS obey -cpu switch

2011-05-07 Thread Alexander Graf
The MPC8544DS board emulation code ignored the user defined -cpu switch. This patch enables it to only provide a sane default, not force an e500v2 CPU inside. Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 2/7] PPC: Make MPC8544DS emulation work w/o KVM

2011-05-07 Thread Alexander Graf
The MPC8544DS board emulation was only used with KVM so far, so some parts of the code didn't provide proper values for non-KVM execution. This patch makes the machine work without KVM enabled. To actually use this, you also need proper e500v2 MMU emulation. Signed-off-by: Alexander Graf --- v

[Qemu-devel] [PATCH] USB: Fix build breakage in musb

2011-05-07 Thread Alexander Graf
Today's git failed building for me. It looks like a mismatching function prototype definition. This patch fixes compilation of arm-softmmu for me. Signed-off-by: Alexander Graf --- hw/usb-musb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-musb.c b/hw/usb-mus

Re: [Qemu-devel] [PATCH] linux-user: Set uninitialized local variable and disable unused code

2011-05-07 Thread Peter Maydell
On 7 May 2011 21:44, Stefan Weil wrote: > cppcheck report: > linux-user/signal.c:2057: error: Uninitialized variable: err > > cppcheck is correct. Setting err = 0 is a workaround to avoid > random results and the cppcheck warning. > > Function restore_fpu_state is currently unused, so I disabled t

Re: [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU

2011-05-07 Thread Alexander Graf
On 07.05.2011, at 00:25, Scott Wood wrote: > On Fri, 6 May 2011 14:00:35 +0200 > Alexander Graf wrote: > >> +static inline void booke206_flush_tlb_one(ppc_tlb_t *tlb, int num) >> +{ >> +int i; >> + >> +for (i = 0; i < num; i++) { >> +if ((tlb[i].tlbe.prot & PAGE_VALID) && >> +

Re: [Qemu-devel] [PATCH] set $SDL_VIDEODRIVER=x11 on Linux to prevent sudo kvm from fighting for video card

2011-05-07 Thread Alexander Graf
On 07.05.2011, at 23:18, Michael Tokarev wrote: > Signed-off-by: Michael Tokarev This has been haunting users ever since I know of qemu. Thanks a lot for writing up the patch! Acked-by: Alexander Graf Alex

[Qemu-devel] [PATCH] set $SDL_VIDEODRIVER=x11 on Linux to prevent sudo kvm from fighting for video card

2011-05-07 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- ui/sdl.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index dc5c3a1..14a62d9 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -831,6 +831,18 @@ void sdl_display_init(DisplayState *ds, int full_screen, int no_fr

[Qemu-devel] [PATCH] target-lm32: Remove unused local variables

2011-05-07 Thread Stefan Weil
cppcheck report: target-lm32/translate.c:587: style: Variable 't0' is assigned a value that is never used target-lm32/translate.c:588: style: Variable 'l1' is assigned a value that is never used Remove both variables. Please check whether that is the correct solution. Cc: Michael Walle C

[Qemu-devel] [PATCH] linux-user: Set uninitialized local variable and disable unused code

2011-05-07 Thread Stefan Weil
cppcheck report: linux-user/signal.c:2057: error: Uninitialized variable: err cppcheck is correct. Setting err = 0 is a workaround to avoid random results and the cppcheck warning. Function restore_fpu_state is currently unused, so I disabled the code. Signed-off-by: Stefan Weil --- linux-user

[Qemu-devel] [PATCH] linux-user: Replace deprecated function

2011-05-07 Thread Stefan Weil
Function bzero is deprecated, so replace it by function memset. Signed-off-by: Stefan Weil --- linux-user/syscall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 279cef3..6e7d88e 100644 --- a/linux-user/syscall.c +++ b

Re: [Qemu-devel] [PATCH] virtio-9p: Fix a memory leak

2011-05-07 Thread Pedro Scarapicchia Junior
Hi Stefan, Thanks for the comment. I believe that it is possible to release the memory at v9fs_walk. However v9fs_walk_complete() is called from two another functions: v9fs_walk_post_newfid_lstat() and v9fs_walk_post_oldfid_lstat(). Placing qemu_free at end of v9fs_walk_complete() solve memory

[Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck)

2011-05-07 Thread Stefan Weil
cppcheck report: virtio-9p.c:197: warning: Redundant assignment of "flags" to itself Cc: Venkateswararao Jujjuri Signed-off-by: Stefan Weil --- hw/9pfs/virtio-9p.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index ac5a1d0..d

[Qemu-devel] [PATCH] Fix spelling in comments (intruction -> instruction)

2011-05-07 Thread Stefan Weil
Signed-off-by: Stefan Weil --- bsd-user/main.c |2 +- linux-user/main.c |2 +- tests/test-i386.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 6b12f8b..0c3fca1 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -237,

[Qemu-devel] [PATCH] block/rbd: Remove unused local variable

2011-05-07 Thread Stefan Weil
cppcheck report: rbd.c:246: style: Variable 'snap' is assigned a value that is never used Remove snap and the related code. Cc: Christian Brunner Cc: Kevin Wolf Signed-off-by: Stefan Weil --- block/rbd.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/block/rbd.c b

[Qemu-devel] [PATCH] usb-linux: Add missing break statement

2011-05-07 Thread Stefan Weil
cppcheck report: usb-linux.c:661: warning: Redundant assignment of "len" in switch Please check whether adding a break statement is the correct solution for this warning. Cc: Hans de Goede Cc: Gerd Hoffmann Signed-off-by: Stefan Weil --- usb-linux.c |1 + 1 files changed, 1 insertions(+),

[Qemu-devel] [Bug 779151] Re: qemu-nbd crash during using with chroot

2011-05-07 Thread Guillaume Smaha
Ok i try to get the informations -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/779151 Title: qemu-nbd crash during using with chroot Status in QEMU: New Bug description: I use qemu-nbd to mou

[Qemu-devel] [Bug 779151] Re: qemu-nbd crash during using with chroot

2011-05-07 Thread Michael Tokarev
Please provide some gdb backtrace from the failing qemu-nbd process, ie, show the root cause of the problem instead of showing multiple symptoms. Run qemu-nbd under gdb and when it crashes, run "bt" command. Before doing so, ensure you've debugging symbols for your qemu-nbd binary. And the most

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-07 Thread Boris Derzhavets
It's done now as PPA :- https://launchpad.net/~bderzhavets/+archive/spice2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/723871 Title: qemu-kvm-0.14.0 Aborts with -vga qxl Status in QEMU: Confir

[Qemu-devel] [Bug 779151] Re: qemu-nbd crash during using with chroot

2011-05-07 Thread Guillaume Smaha
After reboot and mount the image, qemu-nbd crashes directly. ** Attachment added: "dmesg command" https://bugs.launchpad.net/qemu/+bug/779151/+attachment/2118652/+files/dmesg2.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

[Qemu-devel] [Bug 779151] Re: qemu-nbd crash during using with chroot

2011-05-07 Thread Guillaume Smaha
** Attachment added: "dmesg command" https://bugs.launchpad.net/bugs/779151/+attachment/2118648/+files/dmesg.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/779151 Title: qemu-nbd crash during

[Qemu-devel] [Bug 779151] [NEW] qemu-nbd crash during using with chroot

2011-05-07 Thread Guillaume Smaha
Public bug reported: I use qemu-nbd to mount my image. And after some times, qemu-nbd crashes and so the chroot freeze. ps aux | grep qemu : root 2223 0.0 0.0 9776 548 ?Ss 18:03 0:00 qemu-nbd --connect=/dev/nbd0 /chroots/test/virtual.img root 2224 0.0 0.0 10800 5

[Qemu-devel] Binary translation (of code)

2011-05-07 Thread Tarmo Pikaro
Hi ! I've analyzed quite a lot of emulators source code, including qemu as well. But I somehow would like to completely get rid of emulators, and simply convert application from one cpu/board to another cpu/board. On wiki pages this is called "binary translation". - Do you know some open source

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-07 Thread Boris Derzhavets
Similar issues mentioned here :- https://answers.launchpad.net/launchpad/+question/152715 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/723871 Title: qemu-kvm-0.14.0 Aborts with -vga qxl Status in

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-07 Thread Boris Derzhavets
I cannot upload packages to PPA :- root@boris-System-P5Q3:~/KVMQEMU14# dput ppa:bderzhavets/spice2 qemu-kvm_0.14.0+noroms-0ubuntu7_amd64.changes Checking signature on .changes gpg: Signature made Sat 07 May 2011 02:27:25 PM MSD using RSA key ID 930900E6 gpg: Good signature from "Boris Derzhavets

Re: [Qemu-devel] Add option to disable Cocoa on Mac OS X

2011-05-07 Thread Alexander Graf
On 07.05.2011, at 12:12, Andreas Färber wrote: > Hi, > > Am 06.05.2011 um 14:01 schrieb Alexander Graf: > >> On 06.05.2011, at 12:46, Tristan Gingold wrote: >> >>> On May 6, 2011, at 11:48 AM, Ben Leslie wrote: >>> Are there any objections to adding a --disable-cocoa configure option? >>

Re: [Qemu-devel] Add option to disable Cocoa on Mac OS X

2011-05-07 Thread Andreas Färber
Hi, Am 06.05.2011 um 14:01 schrieb Alexander Graf: On 06.05.2011, at 12:46, Tristan Gingold wrote: On May 6, 2011, at 11:48 AM, Ben Leslie wrote: Are there any objections to adding a --disable-cocoa configure option? For simulating ARM microcontrollers I have no desire or need for graphi

Re: [Qemu-devel] [PATCH] virtio-9p: Fix a memory leak

2011-05-07 Thread Stefan Weil
Am 07.05.2011 10:34, schrieb Stefan Hajnoczi: On Fri, May 6, 2011 at 8:05 PM, Pedro Scarapicchia Junior wrote: At v9fs_walk_complete(), the memory allocated at v9fs_walk() is not being released leading system to crash due out of memory. This patch releases structure V9fsWalkState after v9fs_wa

Re: [Qemu-devel] [PATCH] virtio-9p: Fix a memory leak

2011-05-07 Thread Stefan Hajnoczi
On Fri, May 6, 2011 at 8:05 PM, Pedro Scarapicchia Junior wrote: > At v9fs_walk_complete(), the memory allocated at v9fs_walk() is not being > released leading system to crash due out of memory. > > This patch releases structure V9fsWalkState after v9fs_walk is complete. > > Signed-off-by: Pedro S