[Qemu-devel] Re: [PATCH] petalogix_ml605_mmu: remove unused variable

2011-03-19 Thread Edgar E. Iglesias
On Sat, Mar 19, 2011 at 10:45:34AM +0200, Blue Swirl wrote: > Remove a write-only variable, spotted by GCC 4.6.0: > /src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init': > /src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial' > set but not used [-Werror=unused-but-se

[Qemu-devel] [PATCH master, stable] virtio-pci: fix bus master work around on load

2011-03-19 Thread Michael S. Tsirkin
Commit c81131db15dd1844d0db1d51f3cd7a105cfd2cf3 detects old guests by comparing virtio and PCI status. It attempts to do this on load, as well, but load_config callback in a binding is invoked too early and so the virtio status isn't set yet. We could add yet another callback to the binding, to in

Re: [Qemu-devel] Does any version of QEMU support EFI?

2011-03-19 Thread Anthony Liguori
On 03/19/2011 02:50 PM, Jordan Justen wrote: On Sat, Mar 19, 2011 at 08:36, Bei Guan wrote: Does QEMU have the plan to ship with EFI firmware? Hi. I work on the OVMF project which Stefan mentioned. I definitely can't speak for the qemu/kvm project, but I'll give my impressions from my OVMF p

Re: [Qemu-devel] Does any version of QEMU support EFI?

2011-03-19 Thread Jordan Justen
On Sat, Mar 19, 2011 at 08:36, Bei Guan wrote: > Does QEMU have the plan to ship with EFI firmware? Hi. I work on the OVMF project which Stefan mentioned. I definitely can't speak for the qemu/kvm project, but I'll give my impressions from my OVMF perspective. I think qemu/kvm has some interes

[Qemu-devel] Re: git commit c832e3de chokes gcc-4.5.2 (out of memory error)

2011-03-19 Thread walt
On 03/18/2011 03:44 PM, Peter Maydell wrote: On 18 March 2011 23:31, walt wrote: The following commit has a strange side-effect on gcc-4.5.2: The new code in 'target-i386/translate.c' compiles just fine with gcc-4.4.4, using less than 1GB of RAM, but gcc-4.5.2 uses the whole GB and then fills u

Re: [Qemu-devel] Does any version of QEMU support EFI?

2011-03-19 Thread Bei Guan
Does QEMU have the plan to ship with EFI firmware? Xen community will probably have a project for GSoC2011 to write an EFI firmware for Xen VMs. And the EFI firmware need to be acceptable to QEMU code, which is in the Xen source code. This project is "EFI in HVM guests + Xen on EFI Hardware" at ht

Re: [Qemu-devel] Re: vcpu hotplug status

2011-03-19 Thread Gleb Natapov
On Sat, Mar 19, 2011 at 12:25:38PM +0100, William Dauchy wrote: > On Wed, Mar 16, 2011 at 11:17 AM, William Dauchy wrote: > > I wanted to test vcpu hotplug. When adding a cpu I'm getting > > "qdev_create_from_info: Assertion `bus->allow_hotplug' failed." > > I went through a discussion about the s

Re: [Qemu-devel] Does any version of QEMU support EFI?

2011-03-19 Thread Stefan Hajnoczi
On Sat, Mar 19, 2011 at 9:53 AM, Bei Guan wrote: > I want to know which version of QEMU support EFI? > I don't find any code to do with the EFI in the QEMU source code. So, is it > that QEMU doesn't support EFI? QEMU does not ship with EFI firmware. Here is a project which provides a UEFI implem

Re: [Qemu-devel] [PATCH] cocoa: do not create a spurious window for -version

2011-03-19 Thread Andreas Färber
Hello Tristan, Am 15.03.2011 um 14:18 schrieb Tristan Gingold: When invoked with -version, qemu will exit just after displaying the version, so there is no need to create a window. Also handles --XXX options. Signed-off-by: Tristan Gingold Looks good to me except for the qemu_main() inden

[Qemu-devel] [PATCH v3 1/3] pci: add accessor function to get irq levels

2011-03-19 Thread Isaku Yamahata
Introduce accessor function to know INTx levels. It will be used later by q35. Although piix_pci tracks the intx line levels, it can be eliminated by this helper function. Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- hw/pci.c |7 +++ hw/pci.h |1 + 2 files changed, 8 ins

[Qemu-devel] [PATCH v3 0/3] piix_pci: optimize irq data path

2011-03-19 Thread Isaku Yamahata
This patch series optimizes irq data path of piix_pci. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing, but data path is on slow path. Given that irq routing is rarely changed

[Qemu-devel] [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-19 Thread Isaku Yamahata
optimize irq routing in piix_pic.c which has been a TODO. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing, but data path is on slow path. Given that irq routing is rarely chang

[Qemu-devel] [PATCH v3 2/3] piix_pci: eliminate PIIX3State::pci_irq_levels

2011-03-19 Thread Isaku Yamahata
PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. Cc: Juan Quintela Cc: Michael S. Tsirkin Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - rename member s/dummy_for_save_load_compat/pci_irq_levels_vmstate/g --- hw/piix_pci.c | 33

[Qemu-devel] Re: vcpu hotplug status

2011-03-19 Thread William Dauchy
On Wed, Mar 16, 2011 at 11:17 AM, William Dauchy wrote: > I wanted to test vcpu hotplug. When adding a cpu I'm getting > "qdev_create_from_info: Assertion `bus->allow_hotplug' failed." > I went through a discussion about the subject here > http://lists.nongnu.org/archive/html/qemu-devel/2010-08/ms

[Qemu-devel] Does any version of QEMU support EFI?

2011-03-19 Thread Bei Guan
Hi, I want to know which version of QEMU support EFI? I don't find any code to do with the EFI in the QEMU source code. So, is it that QEMU doesn't support EFI? Any help will be appreciated. Thank you. Yours Sincerely, Bei Guan

[Qemu-devel] Re: [PATCH 1/3] alleviate time drift with HPET periodic timers

2011-03-19 Thread Jan Kiszka
On 2011-03-18 16:54, Ulrich Obergfell wrote: > > Part 1 of the patch implements the following QEMU command line option. > > -hpet [device=none|present][,driftfix=none|slew] Just define driftfix as property of the hpet device. That way it can be controlled both globally (-global hpet.driftfix=...

[Qemu-devel] Re: [PATCH 3/3] alleviate time drift with HPET periodic timers

2011-03-19 Thread Jan Kiszka
On 2011-03-18 16:55, Ulrich Obergfell wrote: > > Part 3 of the patch implements the following options for the 'configure' > script. > > --disable-hpet-driftfix > --enable-hpet-driftfix I see no benefit in this configurability. Just make the driftfix unconditionally available, runtime-disabled b

[Qemu-devel] [PATCH] petalogix_ml605_mmu: remove unused variable

2011-03-19 Thread Blue Swirl
Remove a write-only variable, spotted by GCC 4.6.0: /src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init': /src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Blue Swirl --- hw/petalogix_ml605_mmu.

Re: [Qemu-devel] OSX build issues

2011-03-19 Thread Blue Swirl
On Tue, Mar 15, 2011 at 11:03 PM, Blue Swirl wrote: > On Mon, Mar 14, 2011 at 11:21 PM, François Revol wrote: >> The OSX build has been broken for some time now... >> >> * qemu-thread-posix.c: >> both qemu_mutex_timedlock and qemu_cond_timedwait make use of >> clock_gettime() and CLOCK_REALTIME,

[Qemu-devel] Re: [PATCH] w32: Add missing functions qemu_mutex_destroy, qemu_cond_destroy

2011-03-19 Thread Blue Swirl
Thanks, applied. On Sat, Mar 19, 2011 at 12:39 AM, Stefan Weil wrote: > Am 13.03.2011 19:00, schrieb Stefan Weil: >> >> These functions were missing in commit >> 9257d46d55f1fe4e8209be9a6870e339ac3266fe. >> >> Both functions are needed for compilations with >> configuration --enable-vnc-thread. >

[Qemu-devel] Re: [PATCH] i8254: Fix migration from older versions

2011-03-19 Thread Blue Swirl
Thanks, applied. On Fri, Mar 18, 2011 at 12:48 PM, Jan Kiszka wrote: > On 2011-03-06 16:09, Jan Kiszka wrote: >> From: Jan Kiszka >> >> qdev conversion broke migration as the previous version used vmstate >> instance IDs derived from the iobase. Fix it by registering a legacy >> alias. >> >> Sig

Re: [Qemu-devel] [PATCH 2/4] block: add a helper to change writeback mode on the fly

2011-03-19 Thread Blue Swirl
On Thu, Mar 17, 2011 at 6:44 PM, Stefan Hajnoczi wrote: > On Thu, Mar 17, 2011 at 3:11 PM, Kevin Wolf wrote: >> Am 17.03.2011 15:44, schrieb Daniel P. Berrange: >>> On Tue, Mar 15, 2011 at 03:11:32PM +0100, Christoph Hellwig wrote: Add a new bdrv_change_cache that can set/clear the writeback

Re: [Qemu-devel] [PATCH 22/26] acpi, acpi_piix: factor out PM1a EVT logic

2011-03-19 Thread Blue Swirl
On Wed, Mar 16, 2011 at 11:29 AM, Isaku Yamahata wrote: > factor out ACPI PM1a EVT logic. > Later this will be used by ich9 acpi. Also this logic is duplicated in vt82c686.c.

Re: [Qemu-devel] [PATCH 21/26] acpi, acpi_piix: factor out PM_TMR logic

2011-03-19 Thread Blue Swirl
On Wed, Mar 16, 2011 at 11:29 AM, Isaku Yamahata wrote: > factor out PM_TMR logic. Later This will be used by ich9 acpi. Please also refactor vt82c686.c.

Re: [Qemu-devel] [PATCH 13/26] usb/uhci: add ich9 usb uhci id's device

2011-03-19 Thread Blue Swirl
On Wed, Mar 16, 2011 at 11:29 AM, Isaku Yamahata wrote: > add uhci device which has ich9 device id. > > Signed-off-by: Isaku Yamahata > --- >  hw/pci_ids.h  |    2 ++ >  hw/usb-uhci.c |    8 >  2 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/hw/pci_ids.h b/hw/pci_ids.h

[Qemu-devel] Re: [PATCH 08/26] apb_pci: simplify apb_pci.c by using pci_p2pbr

2011-03-19 Thread Blue Swirl
On Wed, Mar 16, 2011 at 11:29 AM, Isaku Yamahata wrote: > apply pci_p2pbr for apb_pci.c. > > Cc: Michael S. Tsirkin > Cc: Blue Swirl > Signed-off-by: Isaku Yamahata > --- >  hw/apb_pci.c |   63 - >  1 files changed, 27 insertions(+), 36 de

[Qemu-devel] Re: [PATCH 09/26] dec_pci: simplify dec_pci.c by using pci_p2pbr

2011-03-19 Thread Blue Swirl
On Wed, Mar 16, 2011 at 11:29 AM, Isaku Yamahata wrote: > apply pci_p2pbr for dec_pci.c. > > Cc: Michael S. Tsirkin > Cc: Blue Swirl > Signed-off-by: Isaku Yamahata > --- >  hw/dec_pci.c |   49 ++--- >  1 files changed, 14 insertions(+), 35 deletions(