Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 05:51:32PM +0100, Jan Kiszka wrote: > >> Just did so, and I can no longer reproduce the problem. Hmm... > >> > > If there is no problem in the logic of this commit (and I do not see > > one yet) then we somewhere miss kicking vcpu when interrupt, that >

[Qemu-devel] [PATCH master/0.14] virtio-serial: Disallow generic ports at id 0

2011-02-02 Thread Amit Shah
It was found libvirt was using port 0 for generic ports. It has been fixed in libvirt commit 8e28c5d40200b4c5d483bd585d237b9d870372e5. Port 0 is reserved for virtconsole devices for backward compatibility with the old -virtioconsole (from qemu 0.12) device type. Ensure we don't allow instantiati

[Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-02 Thread Riku Voipio
On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: > [PATCH] linux-user: Fix possible realloc memory leak > (http://patchwork.ozlabs.org/patch/79217/) Looks ok for me. Riku

[Qemu-devel] [PATCH master/0.14 2/2] virtio-serial: Add older machine compat property for flow control

2011-02-02 Thread Amit Shah
Add a compat property for older machine types. When this is used (via -M pc-0.13, for example), the new flow control mechanisms will not be used. This is done to keep migration from a machine started with older type on a pc-0.14+ qemu to an older machine working. The property is named 'flow_cont

[Qemu-devel] [PATCH master/0.14 1/2] virtio-serial: Use a struct to pass config information from proxy

2011-02-02 Thread Amit Shah
Instead of using a single variable to pass to the virtio_serial_init function, use a struct so that expanding the number of variables to be passed on later is easier. Signed-off-by: Amit Shah --- hw/virtio-pci.c| 12 ++-- hw/virtio-serial-bus.c | 16 hw/virti

Re: [Qemu-devel] Re: [0.14] Queue of 0.14 patches/pull?

2011-02-02 Thread Yoshiaki Tamura
2011/2/2 Paolo Bonzini : > On 01/28/2011 03:21 PM, Yoshiaki Tamura wrote: >> >> >  http://permalink.gmane.org/gmane.comp.emulators.qemu/91096  should be >> > applied >> >  in any case, as it is a regression from 0.12. >> >> Oops, I forgot to list it:)   Thanks for catching. > > This one is still mi

[Qemu-devel] [PATCH 0.14] savevm: fix corruption in vmstate_subsection_load().

2011-02-02 Thread Yoshiaki Tamura
Although it's rare to happen in live migration, when the head of a byte stream contains 0x05 which is the marker of subsection, the loader gets corrupted because vmstate_subsection_load() continues even the device doesn't require it. This patch adds a checker whether subsection is needed, and skip

[Qemu-devel] [ANNOUNCE] QEMU 0.14.0-rc0.tar.gz is available

2011-02-02 Thread Anthony Liguori
The QEMU team is pleased to announce the availability of the 0.14.0-rc0 release. This is the first release candidate for the 0.14.0 release. Download instructions are available at http://wiki.qemu.org/Download You can help test this release by signing up on the new Testing wiki page at http:

[Qemu-devel] RE: RFC: New API for PPC for vcpu mmu access

2011-02-02 Thread Yoder Stuart-B08248
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Wednesday, February 02, 2011 3:34 PM > To: Yoder Stuart-B08248 > Cc: kvm-...@vger.kernel.org; k...@vger.kernel.org; qemu-devel@nongnu.org > Subject: Re: RFC: New API for PPC for vcpu mmu access > > > On 02.02.201

[Qemu-devel] [PATCH 14/20] ccid-card-emulated: use PROP_TYPE_ENUM for backend

2011-02-02 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/ccid-card-emulated.c | 33 ++--- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git a/hw/ccid-card-emulated.c b/hw/ccid-card-emulated.c index 5531ce1..3c5bf6c 100644 --- a/hw/ccid-card-emulated.c +++ b/hw/ccid-card-emulated

[Qemu-devel] [PATCH] x86: Fix MCA broadcast parameters for TCG case

2011-02-02 Thread Jan Kiszka
On 2011-02-02 20:05, Blue Swirl wrote: > Signed-off-by: Blue Swirl > --- > target-i386/helper.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 1217452..4bbf9b1 100644 > --- a/target-i386/helper.c > +++ b/target-i

[Qemu-devel] [PATCH 12/20] libcacard: fixes from review (v15->v16)

2011-02-02 Thread Alon Levy
Build: * don't erase self with distclean * fix make clean after make distclean * Makefile: make vscclient link quiet Behavioral: * vcard_emul_nss: load coolkey in more situations * vscclient: * use hton,ntoh * send init on connect, only start vevent thread on response * read payload aft

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-02 Thread Scott Wood
On Wed, 2 Feb 2011 22:33:41 +0100 Alexander Graf wrote: > > On 02.02.2011, at 21:33, Yoder Stuart-B08248 wrote: > > > Below is a proposal for a new API for PPC to allow KVM clients > > to set MMU state in a vcpu. > > > > BookE processors have one or more software managed TLBs and > > currently

[Qemu-devel] [PATCH 01/20] qdev: add print_options callback

2011-02-02 Thread Alon Levy
another callback added to PropertyInfo, for later use by PROP_TYPE_ENUM. Allows printing of runtime computed options when doing: qemu -device foo,? --- hw/qdev.c | 10 +- hw/qdev.h |1 + 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index c7fe

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-02 Thread Alexander Graf
On 02.02.2011, at 21:33, Yoder Stuart-B08248 wrote: > Below is a proposal for a new API for PPC to allow KVM clients > to set MMU state in a vcpu. > > BookE processors have one or more software managed TLBs and > currently there is no mechanism for Qemu to initialize > or access them. This is n

[Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-02 Thread Michael S. Tsirkin
On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: > [PATCH 1/3] pci: Fix memory leak (http://patchwork.ozlabs.org/patch/79996/) Looks good. Pls cc me on patches next time to make sure I do not miss a patch.

[Qemu-devel] [PATCH 16/20] ccid: add docs

2011-02-02 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. Signed-off-by: Alon Levy --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-) create mode 100

[Qemu-devel] [PATCH 19/20] smartcard, configure: add --enable-smartcard-nss, report only nss

2011-02-02 Thread Alon Levy
Signed-off-by: Alon Levy --- configure | 28 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 8b86c9a..27e5488 100755 --- a/configure +++ b/configure @@ -174,8 +174,8 @@ trace_backend="nop" trace_file="trace" spice="" rb

[Qemu-devel] [PATCH 17/20] ccid: configure: add --enable/disable and nss only disable

2011-02-02 Thread Alon Levy
add --enable-smartcard and --disable-smartcard flags, and let the nss check only disable building the ccid-card-emulated device, since both the usb-ccid and ccid-card-passthru don't depend on it. Signed-off-by: Alon Levy --- Makefile.objs |3 ++- Makefile.target |2 +- configure

[Qemu-devel] RFC: New API for PPC for vcpu mmu access

2011-02-02 Thread Yoder Stuart-B08248
Below is a proposal for a new API for PPC to allow KVM clients to set MMU state in a vcpu. BookE processors have one or more software managed TLBs and currently there is no mechanism for Qemu to initialize or access them. This is needed for normal initialization as well as debug. There are 4 API

[Qemu-devel] [PATCH 10/20] ccid-card-passthru: review fixes (v15->v16)

2011-02-02 Thread Alon Levy
For review I hope presenting this as a separate patch (and the same for the rest of the files) will be easier. For the final round I'll send it folded into the introducing commit. There are a few bug fixes here that are not directly from the review. Behavioral changes: * return correct size * r

[Qemu-devel] [PATCH 20/20] smartcard,configure: report only nss

2011-02-02 Thread Alon Levy
Signed-off-by: Alon Levy --- configure |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 27e5488..2cd73b4 100755 --- a/configure +++ b/configure @@ -2510,8 +2510,7 @@ echo "Trace output file $trace_file-" echo "spice support $spice" echo

[Qemu-devel] [PATCH 05/20] usb-ccid: add CCID bus

2011-02-02 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] [PATCH 13/20] ccid: add ccid-card-emulated device (v2)

2011-02-02 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and certificates

[Qemu-devel] [PATCH 15/20] ccid-card-emulated: review fixes (v15->v16)

2011-02-02 Thread Alon Levy
* fix error reporting in initfn * bump copyright year * update copyright license Signed-off-by: Alon Levy --- hw/ccid-card-emulated.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/ccid-card-emulated.c b/hw/ccid-card-emulated.c index 3c5bf6c..09

[Qemu-devel] [PATCH 07/20] introduce libcacard/vscard_common.h

2011-02-02 Thread Alon Levy
Signed-off-by: Alon Levy --- libcacard/vscard_common.h | 130 + 1 files changed, 130 insertions(+), 0 deletions(-) create mode 100644 libcacard/vscard_common.h diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h new file mode 100644 in

[Qemu-devel] [PATCH 18/20] ccid: add qdev description strings

2011-02-02 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/ccid-card-emulated.c |1 + hw/ccid-card-passthru.c |1 + hw/usb-ccid.c |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ccid-card-emulated.c b/hw/ccid-card-emulated.c index 09ce770..2e25daa 100644 --- a/hw/ccid-card-emul

[Qemu-devel] RFC: New API for PPC for vcpu mmu access

2011-02-02 Thread Yoder Stuart-B08248
Below is a proposal for a new API for PPC to allow KVM clients to set MMU state in a vcpu. BookE processors have one or more software managed TLBs and currently there is no mechanism for Qemu to initialize or access them. This is needed for normal initialization as well as debug. There a

[Qemu-devel] [PATCH 03/20] qdev-properties: add PROP_TYPE_ENUM

2011-02-02 Thread Alon Levy
Example usage: EnumTable foo_enum_table[] = { {"bar", 1}, {"buz", 2}, {NULL, 0}, }; DEFINE_PROP_ENUM("foo", State, foo, 1, foo_enum_table) When using qemu -device foodev,? it will appear as: foodev.foo=bar/buz --- hw/qdev-properties.c | 60

[Qemu-devel] [PATCH 06/20] usb-ccid: review fixes (v15-v16)

2011-02-02 Thread Alon Levy
I'll fold it before submitting the version to be applied, but I hope keeping it as a separate patch will make reviewing easier. Behavioral changes: * fix abort on client answer after card remove * enable migration * remove side affect code from asserts * return consistent self-powered state *

[Qemu-devel] [PATCH 04/20] qdev-properties: parse_enum: don't cast a void*

2011-02-02 Thread Alon Levy
--- hw/qdev-properties.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 3157721..9108f18 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -75,7 +75,7 @@ DEFINE_PROP_ENUM("foo", State, foo, 1, foo_enum_table

[Qemu-devel] [PATCH 01/20] qdev: add print_options callback

2011-02-02 Thread Alon Levy
another callback added to PropertyInfo, for later use by PROP_TYPE_ENUM. Allows printing of runtime computed options when doing: qemu -device foo,? --- hw/qdev.c | 10 +- hw/qdev.h |1 + 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index c7fe

[Qemu-devel] [PATCH 08/20] libcacard/vscard_common.h update (v15->v16)

2011-02-02 Thread Alon Levy
Protocol change: * VSCMsgInit capabilities and magic * removed ReaderResponse, will use Error instead with code==VSC_SUCCESS. * adaded Flush and FlushComplete, remove Reconnect. * define VSCARD_MAGIC * added error code VSC_SUCCESS. Fixes: * update VSCMsgInit comment * fix message type enum

[Qemu-devel] [PATCH 09/20] ccid: add passthru card device

2011-02-02 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy --- Makefile.objs

[Qemu-devel] [PATCH 00/20] usb-ccid (v16)

2011-02-02 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 02/20] qdev: add data pointer to Property

2011-02-02 Thread Alon Levy
For later use by PROP_TYPE_ENUM, will store enumeration name/value table there. --- hw/qdev.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index fa3221b..3d9acd7 100644 --- a/hw/qdev.h +++ b/hw/qdev.h @@ -83,6 +83,7 @@ struct Property { int

Re: [Qemu-devel] [PATCH 1/4] Add config-devices.h again

2011-02-02 Thread Eduardo Habkost
On Tue, Feb 01, 2011 at 07:14:00PM +0100, Stefan Weil wrote: > >+ > > #include "config-host.h" > > #include "config-target.h" > >+ > >+/* We want to include different config files for specific targets > >+ And for the common library. They need a different name because > >+ we don't want to r

[Qemu-devel] Re: [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-02 Thread Eduardo Habkost
On Wed, Feb 02, 2011 at 05:16:23PM +, Blue Swirl wrote: > On Wed, Feb 2, 2011 at 7:55 AM, Paolo Bonzini wrote: > > On 02/01/2011 07:10 PM, Blue Swirl wrote: > >> > >> One way to solve this which would preserve the device model would be > >> to add stub devices. For example, hw/vmmouse-stub.c w

[Qemu-devel] [PATCH 0.14] Fix build on 32 bit hosts

2011-02-02 Thread Blue Swirl
Signed-off-by: Blue Swirl --- target-i386/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 1217452..4bbf9b1 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -1148,7 +1148,7 @@ void cpu_inject_x86_mc

[Qemu-devel] [PATCH 2/4] qdev: add creation function that may fail

2011-02-02 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/qdev.c | 14 +- hw/qdev.h |1 + 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index c7fec44..1aa1ea0 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -106,6 +106,18 @@ static DeviceState *qdev_create_from_info(Bus

[Qemu-devel] [PATCH 1/4] vmware_vga: refactor device creation

2011-02-02 Thread Blue Swirl
Turn vmsvga_init into an inline function. Signed-off-by: Blue Swirl --- hw/vmware_vga.c |5 - hw/vmware_vga.h |5 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 6c59053..4656767 100644 --- a/hw/vmware_vga.c +++ b/hw/vmware

[Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-02 Thread Stefan Weil
Hello, these are some patches which I found on my stack of open patches. All of them should go into 0.14, and at least some of them could also be applied to 0.13. [PATCH] hw/fmopl: Fix buffer access out-of-bounds errors (http://patchwork.ozlabs.org/patch/79054/) [PATCH] linux-user: Fix possi

[Qemu-devel] Re: [PATCH 3/7] Add support for glib based threading and convert qemu thread to use it

2011-02-02 Thread Paolo Bonzini
On 01/24/2011 10:00 PM, Anthony Liguori wrote: int qemu_mutex_trylock(QemuMutex *mutex) { -return pthread_mutex_trylock(&mutex->lock); +return g_static_mutex_trylock(&mutex->lock); This is missing a ! Paolo

Re: [Qemu-devel] Fosdem

2011-02-02 Thread Alon Levy
On Wed, Feb 02, 2011 at 08:06:40PM +0100, Andreas Färber wrote: > Hi Alex, > > Am 30.01.2011 um 16:26 schrieb Alexander Graf: > > >Is anyone else going to Fosdem? We could try to set up an > >unofficial qemu meeting if there are enough people around. So far > >the list of people active in Qemu de

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Jan Kiszka
On 2011-02-02 17:29, Gleb Natapov wrote: > On Wed, Feb 02, 2011 at 04:52:11PM +0100, Jan Kiszka wrote: >> On 2011-02-02 16:46, Gleb Natapov wrote: >>> On Wed, Feb 02, 2011 at 04:35:25PM +0100, Jan Kiszka wrote: On 2011-02-02 16:09, Avi Kivity wrote: > On 02/02/2011 04:52 PM, Jan Kiszka wro

[Qemu-devel] Re: [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-02 Thread Blue Swirl
On Wed, Feb 2, 2011 at 5:37 PM, Eduardo Habkost wrote: > On Wed, Feb 02, 2011 at 05:16:23PM +, Blue Swirl wrote: >> On Wed, Feb 2, 2011 at 7:55 AM, Paolo Bonzini wrote: >> > On 02/01/2011 07:10 PM, Blue Swirl wrote: >> >> >> >> One way to solve this which would preserve the device model would

Re: [Qemu-devel] Fosdem

2011-02-02 Thread Andreas Färber
Hi Alex, Am 30.01.2011 um 16:26 schrieb Alexander Graf: Is anyone else going to Fosdem? We could try to set up an unofficial qemu meeting if there are enough people around. So far the list of people active in Qemu development and there I'm aware of are: - Alexander Graf - Hans de Goede Pl

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 04:35:25PM +0100, Jan Kiszka wrote: > On 2011-02-02 16:09, Avi Kivity wrote: > > On 02/02/2011 04:52 PM, Jan Kiszka wrote: > >> On 2011-02-02 15:43, Jan Kiszka wrote: > >>> On 2011-02-02 15:35, Avi Kivity wrote: > On 02/02/2011 04:30 PM, Jan Kiszka wrote: > > On

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Jan Kiszka
On 2011-02-02 16:09, Avi Kivity wrote: > On 02/02/2011 04:52 PM, Jan Kiszka wrote: >> On 2011-02-02 15:43, Jan Kiszka wrote: >>> On 2011-02-02 15:35, Avi Kivity wrote: On 02/02/2011 04:30 PM, Jan Kiszka wrote: > On 2011-02-02 14:05, Avi Kivity wrote: >> On 02/02/2011 02:50 PM, Jan

Re: [Qemu-devel] [PATCHv8 12/16] Add bootindex parameter to net/block/fd device

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 04:08:07PM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > If bootindex is specified on command line a string that describes device > > in firmware readable way is added into sorted list. Later this list will > > be passed into firmware to control boot order.

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Avi Kivity
On 02/02/2011 04:52 PM, Jan Kiszka wrote: On 2011-02-02 15:43, Jan Kiszka wrote: > On 2011-02-02 15:35, Avi Kivity wrote: >> On 02/02/2011 04:30 PM, Jan Kiszka wrote: >>> On 2011-02-02 14:05, Avi Kivity wrote: On 02/02/2011 02:50 PM, Jan Kiszka wrote: >>> >>Opps, -smp 1. Wit

[Qemu-devel] [PATCH 4/4] x86,MIPS: make vmware_vga optional

2011-02-02 Thread Blue Swirl
Allow failure with vmware_vga device creation and use standard VGA instead. Signed-off-by: Blue Swirl --- hw/mips_malta.c |6 +- hw/pc.c | 11 --- hw/vmware_vga.h | 11 +-- 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/hw/mips_malta.c b/hw/mi

[Qemu-devel] [PATCH 0/4] Make vmware_vga optional

2011-02-02 Thread Blue Swirl
Handle device creation failure for vmware_vga at board level. Use standard VGA instead. Blue Swirl (4): vmware_vga: refactor device creation qdev: add creation function that may fail pci: add creation functions that may fail x86,MIPS: make vmware_vga optional hw/mips_malta.c |6 +

[Qemu-devel] [PATCH 3/4] pci: add creation functions that may fail

2011-02-02 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/pci.c | 20 hw/pci.h |4 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index d5bbba9..5e6e216 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1708,6 +1708,21 @@ PCIDevice *pci_create_multifunction(PCIB

[Qemu-devel] [PATCH V10 06/15] xen: Add the Xen platform pci device

2011-02-02 Thread anthony . perard
From: Steven Smith Introduce a new emulated PCI device, specific to fully virtualized Xen guests. The device is necessary for PV on HVM drivers to work. Signed-off-by: Steven Smith Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- Makefile.target |1 + hw/hw.h

Re: [Qemu-devel] [PATCHv8 12/16] Add bootindex parameter to net/block/fd device

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 05:10:04PM +0200, Gleb Natapov wrote: > On Wed, Feb 02, 2011 at 04:08:07PM +0100, Markus Armbruster wrote: > > Gleb Natapov writes: > > > > > If bootindex is specified on command line a string that describes device > > > in firmware readable way is added into sorted list.

[Qemu-devel] [PATCH V10 14/15] xen: Set running state in xenstore.

2011-02-02 Thread anthony . perard
From: Anthony PERARD This tells to the xen management tool that the machine can begin run. Signed-off-by: Anthony PERARD Acked-by: Alexander Graf --- xen-all.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 592bcaf..

[Qemu-devel] [PATCH V10 03/15] xen: Support new libxc calls from xen unstable.

2011-02-02 Thread anthony . perard
From: Anthony PERARD This patch adds a generic layer for xc calls, allowing us to choose between the xenner and xen implementations at runtime. It also update the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build against new versions of the library. We

[Qemu-devel] [PATCH 2/3] usb-linux: use usb_generic_handle_packet()

2011-02-02 Thread Hans de Goede
Make the linux usb host passthrough code use the usb_generic_handle_packet() function, rather then the curent DYI code. This removes 200 lines of almost identical code. Signed-off-by: Hans de Goede --- hw/usb.c| 41 +- hw/usb.h|1 + usb-linux.c | 269 ++

[Qemu-devel] [PATCH 1/3] usb: Pass the packet to the device's handle_control callback

2011-02-02 Thread Hans de Goede
This allows using the generic usb_generic_handle_packet function from device code which does ASYNC control requests (such as the linux host pass through code). Signed-off-by: Hans de Goede --- hw/bt-hid.c |6 +++--- hw/usb-bt.c |6 +++--- hw/usb-desc.c |4 ++-- hw/usb-desc.

[Qemu-devel] [PATCH 3/3] usb: control buffer fixes

2011-02-02 Thread Hans de Goede
Windows allows control transfers to pass up to 4k of data, so raise our control buffer size to 4k. For control out transfers the usb core code copies the control request data to a buffer before calling the device's handle_control callback. Add a check for overflowing the buffer before copying the d

[Qemu-devel] [PATCH V10 15/15] xen: Add Xen hypercall for sleep state in the cmos_s3 callback.

2011-02-02 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/pc_piix.c |6 +- hw/xen.h |1 + xen-all.c|9 + xen-stub.c |4 4 files changed, 19 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 27d9030..f86873d 100644 --- a/hw/p

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Jan Kiszka
On 2011-02-02 13:35, Gleb Natapov wrote: > On Wed, Feb 02, 2011 at 12:58:47PM +0100, Jan Kiszka wrote: >> On 2011-02-02 12:55, Gleb Natapov wrote: >>> On Tue, Feb 01, 2011 at 07:02:03PM +0100, Jan Kiszka wrote: Hi, testing my KVM patches, I noticed that none of the 64-bit Windows >>>

[Qemu-devel] Re: [PATCH 3/7] Add support for glib based threading and convert qemu thread to use it

2011-02-02 Thread Anthony Liguori
On 02/02/2011 11:32 AM, Paolo Bonzini wrote: On 01/24/2011 10:00 PM, Anthony Liguori wrote: int qemu_mutex_trylock(QemuMutex *mutex) { -return pthread_mutex_trylock(&mutex->lock); +return g_static_mutex_trylock(&mutex->lock); This is missing a ! Good catch. Regards, Anthony Lig

[Qemu-devel] [PATCH V10 11/15] Introduce qemu_put_ram_ptr

2011-02-02 Thread anthony . perard
From: Anthony PERARD This function allows to unlock a ram_ptr give by qemu_get_ram_ptr. After a call to qemu_put_ram_ptr, the pointer may be unmap from QEMU when used with Xen. Signed-off-by: Anthony PERARD Acked-by: Alexander Graf --- cpu-common.h |1 + exec.c | 10 ++

[Qemu-devel] [PATCH V10 12/15] vl.c: Introduce getter for shutdown_requested and reset_requested.

2011-02-02 Thread anthony . perard
From: Anthony PERARD Introduce two functions qemu_shutdown_requested_get and qemu_reset_requested_get to get the value of shutdown/reset_requested without reset it. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini Acked-by: Alexander Graf --- sysemu.h |2 ++ vl.c | 1

[Qemu-devel] Re: [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-02 Thread Blue Swirl
On Wed, Feb 2, 2011 at 7:55 AM, Paolo Bonzini wrote: > On 02/01/2011 07:10 PM, Blue Swirl wrote: >> >> One way to solve this which would preserve the device model would be >> to add stub devices. For example, hw/vmmouse-stub.c would be: >> void *vmmouse_init(void *m) >> { >>     return NULL; >> }

[Qemu-devel] [PATCH V10 07/15] piix_pci: Introduces Xen specific call for irq.

2011-02-02 Thread anthony . perard
From: Anthony PERARD This patch introduces Xen specific call in piix_pci. The specific part for Xen is in write_config, set_irq and get_pirq. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini Acked-by: Alexander Graf --- hw/piix_pci.c | 28 ++-- hw/xe

[Qemu-devel] [PATCH V10 00/15] Xen device model support

2011-02-02 Thread anthony . perard
From: Anthony PERARD Hi, There is a lot of change since the V9 of the Xen device model. One of theme is to use the 'pc' machine for Xen instead of duplicate this machine in another file. Here is the change since the last version: - typedef of qemu_xc_interface, qemu_xc_gnttab and qemu_xc_evtc

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-02 Thread Jes Sorensen
On 02/02/11 08:57, Stefan Hajnoczi wrote: > On Tue, Feb 1, 2011 at 10:58 AM, wrote: >> From: Jes Sorensen >> >> Implement freeze/thaw support in the guest, allowing the host to >> request the guest freezes all it's file systems before a live snapshot >> is performed. >> - fsfreeze(): Walk the l

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Jan Kiszka
On 2011-02-02 16:46, Gleb Natapov wrote: > On Wed, Feb 02, 2011 at 04:35:25PM +0100, Jan Kiszka wrote: >> On 2011-02-02 16:09, Avi Kivity wrote: >>> On 02/02/2011 04:52 PM, Jan Kiszka wrote: On 2011-02-02 15:43, Jan Kiszka wrote: > On 2011-02-02 15:35, Avi Kivity wrote: >> On 02/02/2

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 12:58:47PM +0100, Jan Kiszka wrote: > On 2011-02-02 12:55, Gleb Natapov wrote: > > On Tue, Feb 01, 2011 at 07:02:03PM +0100, Jan Kiszka wrote: > >> Hi, > >> > >> testing my KVM patches, I noticed that none of the 64-bit Windows > >> versions I have around (early Win7 & 2003

Re: [Qemu-devel] [PATCH] do not pass NULL to strdup.

2011-02-02 Thread Markus Armbruster
Gleb Natapov writes: > Also use qemu_strdup() instead of strdup() in bootindex code. > > Signed-off-by: Gleb Natapov > --- > > Should go to stable too. Yes, please! By the way, putting 0.14 in the subject should help with that.

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Avi Kivity
On 02/02/2011 05:35 PM, Jan Kiszka wrote: > > And yet, both are synchronized via qemu_mutex. So we're still missing > something in this picture. > >> Run apic_set_irq on the vcpu? > > static void apic_set_irq(APICState *s, int vector_num, int trigger_mode) > { > apic_irq_delivered +=

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Jan Kiszka
On 2011-02-02 15:35, Avi Kivity wrote: > On 02/02/2011 04:30 PM, Jan Kiszka wrote: >> On 2011-02-02 14:05, Avi Kivity wrote: >>> On 02/02/2011 02:50 PM, Jan Kiszka wrote: >> > Opps, -smp 1. With -smp 2 it boot almost completely and then hangs. Ah, good (or not good). With Wind

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 05:36:53PM +0100, Jan Kiszka wrote: > On 2011-02-02 17:29, Gleb Natapov wrote: > > On Wed, Feb 02, 2011 at 04:52:11PM +0100, Jan Kiszka wrote: > >> On 2011-02-02 16:46, Gleb Natapov wrote: > >>> On Wed, Feb 02, 2011 at 04:35:25PM +0100, Jan Kiszka wrote: > On 2011-02-02

[Qemu-devel] [0.14+master][PATCH 2/3] qemu-timer: Introduce warp callback

2011-02-02 Thread Jan Kiszka
QEMU_CLOCK_HOST is based on the system time which may jump backward in case the admin or NTP adjusts it. RTC emulations and other device models can suffer in this case as timers will stall for the period the clock was tuned back. This adds a detection mechanism that checks on every host clock read

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 04:52:11PM +0100, Jan Kiszka wrote: > On 2011-02-02 16:46, Gleb Natapov wrote: > > On Wed, Feb 02, 2011 at 04:35:25PM +0100, Jan Kiszka wrote: > >> On 2011-02-02 16:09, Avi Kivity wrote: > >>> On 02/02/2011 04:52 PM, Jan Kiszka wrote: > On 2011-02-02 15:43, Jan Kiszka w

[Qemu-devel] [0.14+master][PATCH 1/3] qemu-timer: Consolidate qemu_get_clock and qemu_get_clock_ns

2011-02-02 Thread Jan Kiszka
Both functions have a lot in common, push those bits into a shared helper. Signed-off-by: Jan Kiszka --- qemu-timer.c | 27 +-- 1 files changed, 13 insertions(+), 14 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index db1ec49..94c1073 100644 --- a/qemu-timer.c

[Qemu-devel] [Bug 606658] Re: system_powerdown broken

2011-02-02 Thread Aurelien Jarno
** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/606658 Title: system_powerdown broken Status in QEMU: Fix Committed Bug description:

[Qemu-devel] [0.14+master][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-02-02 Thread Jan Kiszka
By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). This works fine if only the frequency of the host clock is tuned (e.g. by NTP) or if it is set to a future time. However, if the host is tuned backward, e.g. because NTP obtained the correct time after the guest was already st

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-02 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 10:58 AM, wrote: > From: Jes Sorensen > > Implement freeze/thaw support in the guest, allowing the host to > request the guest freezes all it's file systems before a live snapshot > is performed. >  - fsfreeze(): Walk the list of mounted local real file systems, >        

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Jan Kiszka
On 2011-02-02 17:39, Gleb Natapov wrote: > On Wed, Feb 02, 2011 at 05:36:53PM +0100, Jan Kiszka wrote: >> On 2011-02-02 17:29, Gleb Natapov wrote: >>> On Wed, Feb 02, 2011 at 04:52:11PM +0100, Jan Kiszka wrote: On 2011-02-02 16:46, Gleb Natapov wrote: > On Wed, Feb 02, 2011 at 04:35:25PM +

[Qemu-devel] Re: [PATCH 1/3] use nanoseconds everywhere for timeout computation

2011-02-02 Thread Paolo Bonzini
On 02/01/2011 07:47 PM, Aurelien Jarno wrote: qemu_get_clock() which can return different unit depending on what you ask (and in my opinion should simply disappear because it's the best way to have bugs), Agreed. Paolo

Re: [Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-02 Thread Jan Kiszka
On 2011-02-02 15:43, Jan Kiszka wrote: > On 2011-02-02 15:35, Avi Kivity wrote: >> On 02/02/2011 04:30 PM, Jan Kiszka wrote: >>> On 2011-02-02 14:05, Avi Kivity wrote: On 02/02/2011 02:50 PM, Jan Kiszka wrote: >>> >> Opps, -smp 1. With -smp 2 it boot almost completely and then hangs

[Qemu-devel] [PATCH V10 04/15] xen: Add initialisation of Xen

2011-02-02 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD Acked-by: Alexander Graf --- Makefile.target |3 +++ hw/xen.h| 13 + vl.c|2 ++ xen-all.c | 29 + xen-stub.c | 17 + 5 files changed, 64 inser

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-02 Thread Alexander Graf
Kevin Wolf wrote: > Am 01.02.2011 21:10, schrieb Alexander Graf: > >> On 01.02.2011, at 20:58, Aurelien Jarno wrote: >> >> >>> On Tue, Feb 01, 2011 at 07:35:01PM +0100, Alexander Graf wrote: >>> When using level based interrupts, the interrupt is treated the same as an edge

[Qemu-devel] [PATCH V10 05/15] xen: Add xenfv machine

2011-02-02 Thread anthony . perard
From: Anthony PERARD Introduce the Xen FV (Fully Virtualized) machine to Qemu, some more Xen specific call will be added in further patches. Signed-off-by: Anthony PERARD --- hw/pc.c | 19 +-- hw/pc_piix.c | 21 - hw/xen.h |4 3 files c

[Qemu-devel] [PATCH] do not pass NULL to strdup.

2011-02-02 Thread Gleb Natapov
Also use qemu_strdup() instead of strdup() in bootindex code. Signed-off-by: Gleb Natapov --- Should go to stable too. diff --git a/vl.c b/vl.c index 655617f..ed2cdfa 100644 --- a/vl.c +++ b/vl.c @@ -738,7 +738,7 @@ void add_boot_device_path(int32_t bootindex, DeviceState *dev, node = q

[Qemu-devel] [PATCH v2 0/2] virtagent - fsfreeze support

2011-02-02 Thread Jes . Sorensen
From: Jes Sorensen Hi This is a first attempt to add fsfreeze support to virtagent. The idea is for the guest agent to walk the list of locally mounted file systems in the guest, and issuing an ioctl to freeze them. The host can then do a live snapshot of the guest, obtaining stable file systems

[Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-02 Thread Alexander Graf
When using level based interrupts, the interrupt is treated the same as an edge triggered one: leaving the line up does not retrigger the interrupt. In fact, when not lowering the line, we won't ever get a new interrupt inside the guest. So let's always retrigger an interrupt as soon as the OS ack

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-02 Thread Kevin Wolf
Am 01.02.2011 21:10, schrieb Alexander Graf: > > On 01.02.2011, at 20:58, Aurelien Jarno wrote: > >> On Tue, Feb 01, 2011 at 07:35:01PM +0100, Alexander Graf wrote: >>> When using level based interrupts, the interrupt is treated the same as an >>> edge triggered one: leaving the line up does not

Re: [Qemu-devel] [PATCHv8 12/16] Add bootindex parameter to net/block/fd device

2011-02-02 Thread Markus Armbruster
Gleb Natapov writes: > If bootindex is specified on command line a string that describes device > in firmware readable way is added into sorted list. Later this list will > be passed into firmware to control boot order. > > Signed-off-by: Gleb Natapov Just noticed something that slipped through

[Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-02 Thread Paolo Bonzini
On 02/01/2011 07:21 PM, Yoshiaki Tamura wrote: Paolo, I refactored the savevm functions. Could you give me your comments? I didn't review it thoroughly, but the abstractions seem okay. Paolo

[Qemu-devel] Re: [0.14] Queue of 0.14 patches/pull?

2011-02-02 Thread Paolo Bonzini
On 01/28/2011 03:21 PM, Yoshiaki Tamura wrote: > http://permalink.gmane.org/gmane.comp.emulators.qemu/91096 should be applied > in any case, as it is a regression from 0.12. Oops, I forgot to list it:) Thanks for catching. This one is still missing in 0.14. Paolo

[Qemu-devel] Re: [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-02 Thread Paolo Bonzini
On 02/01/2011 07:10 PM, Blue Swirl wrote: One way to solve this which would preserve the device model would be to add stub devices. For example, hw/vmmouse-stub.c would be: void *vmmouse_init(void *m) { return NULL; } This is the wrong direction, unless you can somehow automatically gener

[Qemu-devel] [PATCH V10 10/15] configure: Always use 64bits target physical addresses with xen enabled.

2011-02-02 Thread anthony . perard
From: Anthony PERARD With MapCache, we can handle a 64b target, even with a 32b host/qemu. So, we need to have target_phys_addr_t to 64bits. Signed-off-by: Anthony PERARD Acked-by: Alexander Graf --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure

[Qemu-devel] [0.14+master][PATCH 3/3] mc146818rtc: Handle host clock warps

2011-02-02 Thread Jan Kiszka
Make use of the new warp notifier to update the RTC whenever rtc_clock is the host clock and that happens to jump backward. This avoids that the RTC stalls for the period the host clock was set back. Signed-off-by: Jan Kiszka --- hw/mc146818rtc.c | 17 + 1 files changed, 17 ins

[Qemu-devel] [PATCH V10 08/15] xen: Introduce Xen Interrupt Controller

2011-02-02 Thread anthony . perard
From: Anthony PERARD Every set_irq call makes a Xen hypercall. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/pc_piix.c |8 ++-- hw/xen.h |2 ++ xen-all.c| 12 xen-stub.c |5 + 4 files changed, 25 insertions(+), 2 deletions(

[Qemu-devel] Re: stable-0.14 is now open

2011-02-02 Thread Paolo Bonzini
On 02/02/2011 03:17 AM, Anthony Liguori wrote: Please start sending patches and pull requests specifically against this branch. The 0.14.0-rc0 will be officially announced tomorrow once the mirrors propagate. I would like the alarm timer fixes in 0.14. Paolo

  1   2   >