[Qemu-devel] Re: [PATCH] softfloat: fix floatx80_is_{quiet, signaling}_nan()

2011-01-12 Thread Aurelien Jarno
On Wed, Jan 12, 2011 at 03:05:10PM -0600, Peter Maydell wrote: > On 12 January 2011 13:59, Aurelien Jarno wrote: > > > @@ -494,7 +495,8 @@ int floatx80_is_quiet_nan( floatx80 a ) > >  int floatx80_is_signaling_nan( floatx80 a ) > >  { > >  #if SNAN_BIT_IS_ONE > > -    return ( ( a.high & 0x7FFF )

[Qemu-devel] [PATCH 1/8] fix 'no such file' error from make_device_config.sh

2011-01-12 Thread David Ahern
make_device_config currently emits an error: make config-all-devices.mak GEN x86_64-softmmu/config-devices.mak /home/dsa/kvm/releases/qemu.git/make_device_config.sh: line 21: /home/dsa/kvm/releases/qemu.git/default-configs/pci.mak : No such file or directory /bin/sh does not like the file r

[Qemu-devel] [PATCH 4/8] remove unused parallel_* variables from pc.c

2011-01-12 Thread David Ahern
Signed-off-by: David Ahern --- hw/pc.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 18ec0df..6a55d2f 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -826,9 +826,6 @@ static const int ne2000_io[NE2000_NB_MAX] = { 0x300, 0x320, 0x340, 0x360,

[Qemu-devel] [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n

2011-01-12 Thread David Ahern
Signed-off-by: David Ahern --- hw/pc.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 11b570f..71750f5 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -189,6 +189,7 @@ static void pic_irq_request(void *opaque, int irq, int level) /* PC cmos mappi

[Qemu-devel] [PATCH 7/8] x86_64 config: fix compile for CONFIG_IDE_ISA=n

2011-01-12 Thread David Ahern
Signed-off-by: David Ahern --- hw/pc_piix.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 5046947..e794a82 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -38,9 +38,11 @@ #define MAX_IDE_BUS 2 +#ifdef CONFIG_IDE_ISA static

[Qemu-devel] [PATCH 6/8] x86_64 config: fix compile for CONFIG_VGA_ISA=n

2011-01-12 Thread David Ahern
Signed-off-by: David Ahern --- hw/pc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index e7514fd..11b570f 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -1087,8 +1087,10 @@ void pc_vga_init(PCIBus *pci_bus) } else if (std_vga_enabled) { if (pci

[Qemu-devel] [PATCH 5/8] x86_64 config: fix compile for CONFIG_NE2000_ISA=n

2011-01-12 Thread David Ahern
Signed-off-by: David Ahern --- hw/pc.c |4 hw/pc_piix.c |2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 6a55d2f..e7514fd 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -822,9 +822,11 @@ static void load_linux(void *fw_cfg, #define NE2000_N

[Qemu-devel] [PATCH 3/8] x86_64 config: fix compile for CONFIG_PARALLEL=n

2011-01-12 Thread David Ahern
Signed-off-by: David Ahern --- hw/pc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 50795e8..18ec0df 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -1138,11 +1138,13 @@ void pc_basic_device_init(qemu_irq *isa_irq, } } +#ifdef CONFIG_PARA

[Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings

2011-01-12 Thread David Ahern
David Ahern (8): fix 'no such file' error from make_device_config.sh x86_64 config: fix compile for CONFIG_VMWARE_VGA=n x86_64 config: fix compile for CONFIG_PARALLEL=n remove unused parallel_* variables from pc.c x86_64 config: fix compile for CONFIG_NE2000_ISA=n x86_64 config: fix com

[Qemu-devel] [PATCH 2/8] x86_64 config: fix compile for CONFIG_VMWARE_VGA=n

2011-01-12 Thread David Ahern
Signed-off-by: David Ahern --- hw/pc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index fface7d..50795e8 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -1069,11 +1069,13 @@ void pc_vga_init(PCIBus *pci_bus) } else { isa_cirrus_vga_init

Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers

2011-01-12 Thread Amit Shah
On (Wed) Jan 12 2011 [19:03:58], Blue Swirl wrote: > +static QemuChrHandlers null_handlers = { > +    /* All handlers are initialised to NULL */ > +}; > + >  void qemu_chr_add_handlers(CharDriverState *s, > -                           IOCanReadHandler *fd_can_read, > >

[Qemu-devel] tcg shift ops and magnitudes larger than register size

2011-01-12 Thread Mike Frysinger
are there any rules with the tcg sar/shl/shr ops and their magnitudes ? such as "magnitudes cannot be larger than the register size" ? i have a 32bit register with the value of 0x1230002 and when i attempt to do a sari with a value >=32, it gives me 0x918001 (a single shift right has been done).

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 17:15, Mateusz Loskot wrote: > On 12/01/11 16:48, Michal Suchanek wrote: >> On 12 January 2011 16:21, Mateusz Loskot wrote: >>> >>> Thinking of future, could anyone estimate when it will be possible to >>> boot Solaris 10 installation from ISO disks, if at all? >>> To summary, what OS

[Qemu-devel] Fedora Virt status

2011-01-12 Thread Justin M. Forbes
Fedora 14 - We have 79 open bugs, 9 of which have fixes in awaiting updates. - 1 bug has been closed in the last week - Virt-preview has been opened for Fedora 14, more details below Fedora 15 - Upcoming Deadlines: 2011-01-25 Feature Submission Deadline (2 Weeks!) 2011-02-08 Feature Freeze--

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Stefan Weil
Am 12.01.2011 22:37, schrieb Michal Suchanek: On 12 January 2011 20:17, Stefan Weil wrote: Am 12.01.2011 20:05, schrieb Stefan Weil: Hi, this is a regression in current QEMU: it cannot create disk images larger than 2^31 B (2 GiB). It's discussed at http://lists.nongnu.org/archive/h

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Michal Suchanek
On 12 January 2011 20:17, Stefan Weil wrote: > Am 12.01.2011 20:05, schrieb Stefan Weil: >> >> Hi, >> >> this is a regression in current QEMU: it cannot create disk images larger >> than 2^31 B (2 GiB). >> It's discussed at >> http://lists.nongnu.org/archive/html/qemu-devel/2011-01/msg00357.html.

[Qemu-devel] Re: [PATCH] softfloat: fix floatx80_is_{quiet, signaling}_nan()

2011-01-12 Thread Peter Maydell
On 12 January 2011 13:59, Aurelien Jarno wrote: > @@ -494,7 +495,8 @@ int floatx80_is_quiet_nan( floatx80 a ) >  int floatx80_is_signaling_nan( floatx80 a ) >  { >  #if SNAN_BIT_IS_ONE > -    return ( ( a.high & 0x7FFF ) == 0x7FFF ) && (bits64) ( a.low<<1 ); > +    return ( ( a.high & 0x7FFF ) ==

[Qemu-devel] [PATCH] softfloat: fix floatx80_is_{quiet, signaling}_nan()

2011-01-12 Thread Aurelien Jarno
floatx80_is_{quiet,signaling}_nan() functions are incorrectly detecting the type of NaN, depending on SNAN_BIT_IS_ONE, one of the two is returning the correct value, and the other true for any kind of NaN. This patch fixes that by applying the same kind of comparison as for other float formats, bu

Re: [Spice-devel] [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Anthony Liguori
On 01/12/2011 01:28 PM, Alon Levy wrote: Regarding wire protocol this would of course be very wasteful. If it's used between the guest and host except for the translation overhead, which is minimal I think (except for a copy-paste of a large amount of data - I'm not familiar enough with XML-RPC

Re: [Spice-devel] [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Anthony Liguori
On 01/12/2011 12:59 PM, Hans de Goede wrote: Hi, On 01/12/2011 06:40 PM, Anthony Liguori wrote: On 01/12/2011 10:12 AM, Gerd Hoffmann wrote: Hi folks, Looks like the spicevmc patch kicked the guest qagent discussion, so lets start with this, although it isn't related much to the agent issue

Re: [Spice-devel] [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Alon Levy
On Wed, Jan 12, 2011 at 07:59:40PM +0100, Hans de Goede wrote: > Hi, > > On 01/12/2011 06:40 PM, Anthony Liguori wrote: > >On 01/12/2011 10:12 AM, Gerd Hoffmann wrote: > >> > >>Hi folks, > >> > >>Looks like the spicevmc patch kicked the guest qagent discussion, so lets > >>start with this, althou

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Stefan Weil
Am 12.01.2011 20:05, schrieb Stefan Weil: Hi, this is a regression in current QEMU: it cannot create disk images larger than 2^31 B (2 GiB). It's discussed at http://lists.nongnu.org/archive/html/qemu-devel/2011-01/msg00357.html. A new version for MinGW now includes a patch which should fix

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Stefan Weil
Am 12.01.2011 13:30, schrieb Mateusz Loskot: On 12/01/11 11:38, Mateusz Loskot wrote: On 10/01/11 22:18, Stefan Weil wrote: Am 10.01.2011 18:59, schrieb Mateusz Loskot: >>> I quickly tried your binaries and it looks I have to run them from within MSYS environment, isn't it? I'm getting runtim

Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers

2011-01-12 Thread Blue Swirl
On Wed, Jan 12, 2011 at 6:01 PM, Michael Roth wrote: > On 01/12/2011 12:07 AM, Amit Shah wrote: >> >> On (Tue) Jan 11 2011 [17:13:15], Blue Swirl wrote: +static QemuChrHandlers gdb_handlers = { +    .fd_can_read = gdb_chr_can_receive, +    .fd_read = gdb_chr_receive, +    

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Blue Swirl
On Wed, Jan 12, 2011 at 5:15 PM, Mateusz Loskot wrote: > On 12/01/11 16:48, Michal Suchanek wrote: >> >> On 12 January 2011 16:21, Mateusz Loskot  wrote: >>> >>> Thinking of future, could anyone estimate when it will be possible to >>> boot Solaris 10 installation from ISO disks, if at all? >>> To

Re: [Spice-devel] [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Hans de Goede
Hi, On 01/12/2011 06:40 PM, Anthony Liguori wrote: On 01/12/2011 10:12 AM, Gerd Hoffmann wrote: Hi folks, Looks like the spicevmc patch kicked the guest qagent discussion, so lets start with this, although it isn't related much to the agent issue itself ... The spicevmc chardev just pipes

[Qemu-devel] [PATCH v2 1/2] target-ppc: fix sNaN propagation

2011-01-12 Thread Aurelien Jarno
The current FPU code returns 0.0 if one of the operand is a signaling NaN and the VXSNAN exception is disabled. fload_invalid_op_excp() doesn't return a qNaN in case of a VXSNAN exception as the operand should be propagated instead of a new qNaN to be generated. Fix that by calling fload_invalid_o

[Qemu-devel] [PATCH 2/2] target-ppc: fix wrong NaN tests

2011-01-12 Thread Aurelien Jarno
Some tests in FPU emulation code were wrongly using float64_is_nan() before commit 185698715dfb18c82ad2a5dbc169908602d43e81, and wrongly using float64_is_quiet_nan() after. Fix them by using float64_is_any_nan() instead. Cc: Alexander Graf Cc: Peter Maydell Cc: Nathan Froyd Signed-off-by: Aurel

[Qemu-devel] [PATCH 1/3] block: Rename bdrv_mon_event()

2011-01-12 Thread Luiz Capitulino
It's too generic and next commits will add a new event, rename it to bdrv_error_mon_event() then. Signed-off-by: Luiz Capitulino --- block.c |4 ++-- block.h |4 ++-- hw/ide/core.c |6 +++--- hw/scsi-disk.c |6 +++--- hw/virtio-blk.c |6 +++--- 5 files chan

[Qemu-devel] [RFC 0/3]: QMP: Introduce BLOCK_MEDIA_EJECT event

2011-01-12 Thread Luiz Capitulino
Not very well tested, but I'm sending for early review. Please, check individual patches for details. The event spec can be found in patch 0/2. QMP/qmp-events.txt | 15 +++ block.c| 16 ++-- block.h|5 +++-- blockdev.c |5 +

[Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-01-12 Thread Luiz Capitulino
Conforms to the event specification defined in the QMP/qmp-events.txt file. Please, note the following (very important) details: o The event should be emitted only by devices which support the eject operation, which (afaik) are: CDROMs (IDE and SCSI) and floppies o Human monitor commands

[Qemu-devel] [PATCH 2/3] QMP: Documentation for the BLOCK_MEDIA_EJECT event

2011-01-12 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- QMP/qmp-events.txt | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 0ce5d4e..d13b17a 100644 --- a/QMP/qmp-events.txt +++ b/QMP/qmp-events.txt @@ -1,6 +1,21 @@

Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers

2011-01-12 Thread Michael Roth
On 01/12/2011 12:07 AM, Amit Shah wrote: On (Tue) Jan 11 2011 [17:13:15], Blue Swirl wrote: +static QemuChrHandlers gdb_handlers = { +.fd_can_read = gdb_chr_can_receive, +.fd_read = gdb_chr_receive, +.fd_event = gdb_chr_event, +}; These structures should be const. Hm, I had that

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2011-01-12 Thread Serge Hallyn
Patch is said to be in maverick-next. I'd like to hear confirmation (or denial) from original bug reporter as to whether the patch fixed the problem. (I'm unconvinced that this is actually a dup of the Meego bug) ** Changed in: linux (Ubuntu) Status: In Progress => Fix Committed ** Chang

[Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2011-01-12 Thread Michael S. Tsirkin
On Wed, Jan 12, 2011 at 06:26:55PM +0100, Dragos Tatulea wrote: > Hi, > > Trying to stir up a year old conversation [1] about mac filtering. > The patch below is Alex Williamson's work updated for the current qemu > taking into account some comments. An extra check for multiple nics on > the same

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 16:48, Michal Suchanek wrote: On 12 January 2011 16:21, Mateusz Loskot wrote: Thinking of future, could anyone estimate when it will be possible to boot Solaris 10 installation from ISO disks, if at all? To summary, what OS alternative for SPARC we have got apart from Debian which

Re: [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Anthony Liguori
On 01/12/2011 10:12 AM, Gerd Hoffmann wrote: Hi folks, Looks like the spicevmc patch kicked the guest qagent discussion, so lets start with this, although it isn't related much to the agent issue itself ... The spicevmc chardev just pipes data from a chardev user within qemu to libspice a

[Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2011-01-12 Thread Michael S. Tsirkin
On Wed, Jan 12, 2011 at 06:26:55PM +0100, Dragos Tatulea wrote: > Hi, > > Trying to stir up a year old conversation [1] about mac filtering. > The patch below is Alex Williamson's work updated for the current qemu > taking into account some comments. An extra check for multiple nics on > the same

[Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2011-01-12 Thread Dragos Tatulea
Hi, Trying to stir up a year old conversation [1] about mac filtering. The patch below is Alex Williamson's work updated for the current qemu taking into account some comments. An extra check for multiple nics on the same vlan has been added as well. Now, I know it's not ideal but I'm looking for

[Qemu-devel] Re: [Xen-devel] [PATCH 2/2] xen: Introduce VGA sync dirty bitmap support

2011-01-12 Thread Anthony PERARD
On Wed, 12 Jan 2011, Stefano Stabellini wrote: > On Tue, 11 Jan 2011, anthony.per...@citrix.com wrote: > > From: Anthony PERARD > > > > This patch introduces phys memory client for Xen. > > > > Only sync dirty_bitmap and set_memory are actually implemented. > > migration_log will stay empty for t

Re: [Qemu-devel] forking with x86_64

2011-01-12 Thread Mulyadi Santosa
On Wed, Jan 12, 2011 at 17:17, maheen butt wrote: > > hi > why qemu does not provide NPTL support for x86 in user mode? is there any > big hindrance behind it? IMHO, your experiment works since it simply fork(). What qemu wanna do here is complete NPTL handling...and afaik that means clone(), pt

[Qemu-devel] Re: [PATCH 2/2] xen: Introduce VGA sync dirty bitmap support

2011-01-12 Thread Anthony PERARD
On Wed, 12 Jan 2011, Jan Kiszka wrote: > Am 11.01.2011 16:37, anthony.per...@citrix.com wrote: > > From: Anthony PERARD > > > > This patch introduces phys memory client for Xen. > > > > Only sync dirty_bitmap and set_memory are actually implemented. > > migration_log will stay empty for the momen

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Michal Suchanek
On 12 January 2011 16:21, Mateusz Loskot wrote: > On 12/01/11 14:40, Artyom Tarasenko wrote: >> >> On Wed, Jan 12, 2011 at 3:28 PM, Mateusz Loskot >>  wrote: >>> >>> On 12/01/11 12:32, Mateusz Loskot wrote: On 12/01/11 11:57, Artyom Tarasenko wrote: > > On Wed, Jan 12, 2011 at 12

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Gerd Hoffmann
Hi, I left the "changed" member in USBHIDState, rather than moving it to the keyboard, because it is useful to handle the idle period (in USB_TOKEN_IN) in a device-independent way. Without it the code became more messy. This leaves the same information recorded in the driver in two places an

[Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-12 Thread Gerd Hoffmann
Hi folks, Looks like the spicevmc patch kicked the guest qagent discussion, so lets start with this, although it isn't related much to the agent issue itself ... The spicevmc chardev just pipes data from a chardev user within qemu to libspice and adds a "type" tag to it so libspice knows n

[Qemu-devel] Re: [PATCH] audio: split sample conversion and volume mixing

2011-01-12 Thread malc
On Wed, 5 Jan 2011, Michael Walle wrote: > Refactor the volume mixing, so it can be reused for capturing devices. > Additionally, it removes superfluous multiplications with the nominal > volume within the hardware voice code path. Thanks, applied. [..snip..] -- mailto:av1...@comtv.ru

[Qemu-devel] Re: [PATCH][RESEND] virtio-serial-bus: Bump up control vq descriptors to min. required

2011-01-12 Thread Michael S. Tsirkin
On Tue, Jan 11, 2011 at 09:47:44PM +0530, Amit Shah wrote: > The current default of 16 buffers for the control vq is too small for > the default max_nr_ports of 32. We can get more entries in there, > example when asking the guest to add max. allowed ports. > > Default to using the minimum requir

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 14:40, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 3:28 PM, Mateusz Loskot wrote: On 12/01/11 12:32, Mateusz Loskot wrote: On 12/01/11 11:57, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskot wrote: On 10/01/11 21:04, Artyom Tarasenko wrote: On Mon

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Artyom Tarasenko
On Wed, Jan 12, 2011 at 3:28 PM, Mateusz Loskot wrote: > On 12/01/11 12:32, Mateusz Loskot wrote: >> >> On 12/01/11 11:57, Artyom Tarasenko wrote: >>> >>> On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskot >>> wrote: On 10/01/11 21:04, Artyom Tarasenko wrote: > > On Mon, Jan 10, 20

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 12:32, Mateusz Loskot wrote: On 12/01/11 11:57, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskot wrote: On 10/01/11 21:04, Artyom Tarasenko wrote: On Mon, Jan 10, 2011 at 6:59 PM, Mateusz Loskot wrote: I suggest using QEMU git master. You could try the bi

Re: [Qemu-devel] [PATCH] arm-dis: Include opcode hex when doing disassembly

2011-01-12 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 11:09:28AM -0600, Peter Maydell wrote: > On 10 January 2011 10:49, Aurelien Jarno wrote: > > Strangely on arm host, the opcode hex is already included, as shown > > below: > > > > | OUT: [size=308] > > | 0x01001ec0:  e5974004  ldr      r4, [r7, #4] > > | 0x01001ec4:  e1a048

[Qemu-devel] [PATCHv1] slirp: Use strcasecmp() to check tftp mode, tsize

2011-01-12 Thread Sergei Gavrikov
From: Sergei Gavrikov According to RFC 1350 (TFTP Revision 2) the mode field can contain any combination of upper and lower case; also RFC 2349 propagates that the transfer size option ("tsize") is case in-sensitive too. Current implementation of embedded TFTP server missed that what does mess s

Re: [Qemu-devel] [RESEND PATCH 1/2] qdev: Track runtime machine modifications

2011-01-12 Thread Alex Williamson
On Wed, 2011-01-12 at 13:09 +0100, Markus Armbruster wrote: > Alex Williamson writes: > > > Create a trivial interface to track whether the machine has been > > modified since boot. Adding or removing devices will trigger this > > to return true. An example usage scenario for such an interface

[Qemu-devel] [PATCH v4 32/32] usb: zap pdev from usbport

2011-01-12 Thread Gerd Hoffmann
It isn't needed any more. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |3 +-- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +- hw/usb.h |3 +-- 6 files changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-

Re: [Qemu-devel] [PATCH] Avoid divide by zero when there is no block device to migrate

2011-01-12 Thread Kevin Wolf
Am 12.01.2011 12:01, schrieb Pierre Riteau: > On 11 janv. 2011, at 12:54, Kevin Wolf wrote: > >> Am 25.12.2010 21:52, schrieb Pierre Riteau: >>> When block migration is requested and no read-write block device is >>> present, a divide by zero exception is triggered because >>> total_sector_sum equ

[Qemu-devel] [PATCH v2] Avoid divide by zero when there is no block device to migrate

2011-01-12 Thread Pierre Riteau
When block migration is requested and no read-write block device is present, a divide by zero exception is triggered because total_sector_sum equals zero. Signed-off-by: Pierre Riteau --- This v2 fixes a line that was going beyond 80 characters. block-migration.c |7 ++- 1 files change

Re: [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-01-12 Thread Gleb Natapov
On Wed, Jan 12, 2011 at 12:26:25PM +0100, Jan Kiszka wrote: > Am 23.12.2010 21:45, Zachary Amsden wrote: > > On 12/17/2010 04:58 AM, Jan Kiszka wrote: > >> By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). > >> This works fine if only the frequency of the host clock is tuned

[Qemu-devel] [PATCH v4 22/32] usb: add speed mask to ports

2011-01-12 Thread Gerd Hoffmann
Add a field to usb ports indicating the speed(s) they are able to handle. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |3 ++- hw/usb-hub.c |3 ++- hw/usb-musb.c |3 ++- hw/usb-ohci.c |3 ++- hw/usb-uhci.c |3 ++- hw/usb.h |9 - 6 files changed, 18 inserti

Re: [Qemu-devel] [RESEND PATCH 1/2] qdev: Track runtime machine modifications

2011-01-12 Thread Markus Armbruster
Alex Williamson writes: > Create a trivial interface to track whether the machine has been > modified since boot. Adding or removing devices will trigger this > to return true. An example usage scenario for such an interface is > the rtl8139 driver which includes a cpu_register_io_memory() valu

Re: [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-01-12 Thread Jan Kiszka
Am 12.01.2011 14:05, Jan Kiszka wrote: > Am 12.01.2011 13:27, Gleb Natapov wrote: >> On Wed, Jan 12, 2011 at 12:26:25PM +0100, Jan Kiszka wrote: >>> Am 23.12.2010 21:45, Zachary Amsden wrote: On 12/17/2010 04:58 AM, Jan Kiszka wrote: > By default, we base the mc146818 RTC on the host clock

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 10/01/11 22:18, Stefan Weil wrote: Am 10.01.2011 18:59, schrieb Mateusz Loskot: On 10/01/11 17:08, Stefan Weil wrote: Am 10.01.2011 12:19, schrieb Mateusz Loskot: On 07/01/11 18:15, Stefan Weil wrote: There are no precompiled windows binaries of current qemu, so you will have to compile th

[Qemu-devel] [PATCH v4 19/32] usb: hub: remote wakeup support.

2011-01-12 Thread Gerd Hoffmann
This patch makes the usb hub handle remote wakeup requests from devices properly by updating the port status register and forwarding the wakeup to the upstream port. Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a

[Qemu-devel] [PATCH v4 11/32] usb network: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb network driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann --- hw/usb-net.c | 453 +++--- 1 files changed, 209 insertions(+), 244 deletions(-) diff --git a/hw/usb-net.c b/hw/usb-net.c index 8492455..

[Qemu-devel] [PATCH v4 21/32] usb: hid: change serial number to "42".

2011-01-12 Thread Gerd Hoffmann
It would be nice to have some way to signal our hid devices support remote wakeup. There is a descriptor bit for that of course. Problem with using is one is that older qemu versions used to set the bit even though they did *not* support remote wakeup. Bummer. This patch changes the serial numb

[Qemu-devel] [PATCH v4 16/32] usb: rework attach/detach workflow

2011-01-12 Thread Gerd Hoffmann
Add separate detach callback to USBPortOps, split uhci/ohci/musb/usbhub attach functions into two. Move common code to the usb_attach() function, only the hardware-specific bits remain in the attach/detach callbacks. Keep track of the port it is attached to for each usb device. [ v3: fix tyops i

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Ian Jackson
Paolo Bonzini writes ("Re: [PATCH v2] add event queueing to USB HID"): > It's all pretty academic as in practice it worked well. The queue-full > code would never trigger in usb_pointer_event, and instead the queue > would be instantly emptied when a 17th event arrived. This is lucky > actuall

Re: [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-01-12 Thread Jan Kiszka
Am 12.01.2011 13:27, Gleb Natapov wrote: > On Wed, Jan 12, 2011 at 12:26:25PM +0100, Jan Kiszka wrote: >> Am 23.12.2010 21:45, Zachary Amsden wrote: >>> On 12/17/2010 04:58 AM, Jan Kiszka wrote: By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). This works fine if on

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Paolo Bonzini
On 01/12/2011 01:34 PM, Ian Jackson wrote: Paolo Bonzini writes ("[PATCH v2] add event queueing to USB HID"): For v2 I changed the head/tail implementation of the FIFO buffer (which was buggy when the queue became full) to head/count. I then removed "have_data", which

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 12/01/11 11:57, Artyom Tarasenko wrote: On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskot wrote: On 10/01/11 21:04, Artyom Tarasenko wrote: On Mon, Jan 10, 2011 at 6:59 PM, Mateusz Loskot wrote: I suggest using QEMU git master. You could try the binaries from my website: http://www.weil

Re: [Qemu-devel] [PATCH v4 18/32] usb: uhci: remote wakeup support.

2011-01-12 Thread Stefan Hajnoczi
On Wed, Jan 12, 2011 at 11:20 AM, Gerd Hoffmann wrote: > Add support for remote wakeup to the UHCI adapter. It would be nice to document the guest configuration steps for users so they can take advantage of this. Perhaps on the qemu.org wiki? Or http://www.linux-kvm.org/page/Usb_related? Stefa

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Sergei Gavrikov
On Wed, 12 Jan 2011, Stefan Hajnoczi wrote: > On Wed, Jan 12, 2011 at 10:22 AM, Sergei Gavrikov > wrote: > > It was good to know. If you mean the below I "merge" that in one. Thank > > you for review. > > > > Sergei > > > > Signed-off-by: Sergei Gavrikov > > Acked-by: Stefan Hajnoczi > > You

Re: [Qemu-devel] [PATCH 0/8] Add save/restore support to ARM versatilepb devices

2011-01-12 Thread Peter Maydell
On 23 December 2010 11:19, Peter Maydell wrote: > This patchset adds save/restore support to the devices used by the ARM > versatilepb board which didn't already support it. > > I did this in line with docs/migration.txt, and it seems to work OK. I'd > appreciate some review from somebody with a b

[Qemu-devel] [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Paolo Bonzini
The polling nature of the USB HID device makes it very hard to double click or drag while on a high-latency VNC connection. This patch, based on work done in the Xen qemu-dm tree by Ian Jackson, fixes this bug by adding an event queue to the device. The event queue associates each movement with t

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Ian Jackson
Paolo Bonzini writes ("[PATCH v2] add event queueing to USB HID"): > For v2 I changed the head/tail implementation of the FIFO buffer > (which was buggy when the queue became full) to head/count. > I then removed "have_data", which is the same as count>0 > for pointe

Re: [Qemu-devel] [PATCH v2 2/4] piix: tag as not hotpluggable.

2011-01-12 Thread Markus Armbruster
Gerd Hoffmann writes: > This patch tags all pci devices which belong to the piix3/4 chipsets as > not hotpluggable (Host bridge, ISA bridge, IDE controller, ACPI bridge). > > Signed-off-by: Gerd Hoffmann > --- > hw/acpi_piix4.c |2 ++ > hw/ide/piix.c |2 ++ > hw/piix4.c |1 +

[Qemu-devel] [PATCH v4 13/32] usb: move USB_REQ_{GET, SET}_CONFIGURATION handling to common code

2011-01-12 Thread Gerd Hoffmann
This patch adds fields to the USBDevice struct for the current speed (hard-wired to full speed for now) and current device configuration. Also a init function is added which inializes these fields. This allows USB_REQ_{GET,SET}_CONFIGURATION handling to be moved to common code. For most drivers

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Artyom Tarasenko
On Wed, Jan 12, 2011 at 12:47 PM, Mateusz Loskot wrote: > On 10/01/11 21:04, Artyom Tarasenko wrote: >> >> On Mon, Jan 10, 2011 at 6:59 PM, Mateusz Loskot >>  wrote: I suggest using QEMU git master. You could try the binaries from my website: http://www.weilnetz.de/qemu/ >>> >>> Ste

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-12 Thread Markus Armbruster
Avi Kivity writes: > On 01/11/2011 03:54 PM, Anthony Liguori wrote: >> >> Right, we should introduce a KVMBus that KVM devices are created on. >> The devices can get at KVMState through the BusState. > > There is no kvm bus in a PC (I looked). We're bending the device > model here because a devi

[Qemu-devel] [PATCH v4 30/32] usb: add port property.

2011-01-12 Thread Gerd Hoffmann
This allows to explictily set the physical port where you want to plug the usb device. Example: -device usb-tablet,bus=usb.0,port=2 With explicit port addressing qemu can and will not automagically add USB Hubs. This means that: (a) You can plug two devices of your choice into the two uhci

Re: [Qemu-devel] [PATCH v2 1/4] pci: allow devices being tagged as not hotpluggable.

2011-01-12 Thread Markus Armbruster
Gerd Hoffmann writes: > This patch adds a field to PCIDeviceInfo to tag devices as being > not hotpluggable. Any attempt to plug-in or -out such a device > will throw an error. > > Signed-off-by: Gerd Hoffmann > --- > hw/pci.c | 10 ++ > hw/pci.h |3 +++ > qerror.c |4 >

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-12 Thread Mateusz Loskot
On 10/01/11 21:04, Artyom Tarasenko wrote: On Mon, Jan 10, 2011 at 6:59 PM, Mateusz Loskot wrote: I suggest using QEMU git master. You could try the binaries from my website: http://www.weilnetz.de/qemu/ Stefan, Thank you very much! So far, I have tried to use versions of QEMU from Qemu Mana

[Qemu-devel] [PATCH v4 28/32] usb storage: handle long responses

2011-01-12 Thread Gerd Hoffmann
The scsi layer may return us more data than the guests wants to have. Handle this by just ignoring the extra bytes and calling the {read,write}_data callback to finish the request. Seen happening in real life with some extended inquiry command. With this patch applied the linux kernel stops reseti

Re: [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately

2011-01-12 Thread Jan Kiszka
Am 23.12.2010 21:45, Zachary Amsden wrote: > On 12/17/2010 04:58 AM, Jan Kiszka wrote: >> By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME). >> This works fine if only the frequency of the host clock is tuned (e.g. >> by NTP) or if it is set to a future time. However, if the h

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Stefan Hajnoczi
On Wed, Jan 12, 2011 at 10:22 AM, Sergei Gavrikov wrote: > It was good to know. If you mean the below I "merge" that in one. Thank > you for review. > > Sergei > > Signed-off-by: Sergei Gavrikov > Acked-by: Stefan Hajnoczi Your new patch looks fine. I prefer: Reviewed-by: Stefan Hajnoczi Ste

[Qemu-devel] [PATCH v4 24/32] usb: add usb_desc_attach

2011-01-12 Thread Gerd Hoffmann
Add usb_desc_attach() which sets up the device according to the speed the usb port is able to handle. This function can be hooked into the handle_attach callback. Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c | 36 +--- hw/usb-desc.h |1 + 2 files changed,

[Qemu-devel] [PATCH v4 25/32] usb: add device qualifier support

2011-01-12 Thread Gerd Hoffmann
Add support for device_qualifier and other_speed_config descriptors. These are used to query the "other speed" configuration of usb 2.0 devices, i.e. in high-speed mode they return the full-speed configuration and visa versa. Signed-off-by: Gerd Hoffmann --- hw/usb-desc.c | 46

[Qemu-devel] [PATCH v4 29/32] usb: keep track of physical port address.

2011-01-12 Thread Gerd Hoffmann
Add a path string to USBPort. Add usb_port_location() function to set the physical location of the usb port. Update all drivers implementing usb ports to call it. Update the monitor commands to print it. Wind it up in qdev. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c | 26 ++

[Qemu-devel] [PATCH v4 20/32] usb: hid: remote wakeup support.

2011-01-12 Thread Gerd Hoffmann
Add usb_wakeup() call to the hid driver so remote wakeup actually works. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index 1c35960..60fa57f 100644 --- a/hw/usb-hid.c +++ b/hw/usb-hid.c @@ -429

[Qemu-devel] [PATCH v4 23/32] usb: add attach callback

2011-01-12 Thread Gerd Hoffmann
Add handle_attach() callback to USBDeviceInfo which is called by the generic package handler when the device is attached to the usb bus (i.e. plugged into a port). Signed-off-by: Gerd Hoffmann --- hw/usb.c |7 ++- hw/usb.h |5 + 2 files changed, 11 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH v4 31/32] usb: rewrite fw path, fix numbering

2011-01-12 Thread Gerd Hoffmann
This patch rewrites the firmware path code to use the physical port location tracking just added to the qemu usb core. It also fixes the port numbering to start with "1" in the firmware path. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c | 68 ++

[Qemu-devel] [PATCH v4 27/32] usb storage: fix status reporting

2011-01-12 Thread Gerd Hoffmann
Change usb_msd_send_status() to take a pointer to the status packet instead of writing the status to s->usb_buf which might not point to the correct location. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/usb

[Qemu-devel] [PATCH v4 15/32] usb: create USBPortOps, move attach there.

2011-01-12 Thread Gerd Hoffmann
Create USBPortOps struct, move the attach function to that struct. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |6 -- hw/usb-hub.c |6 +- hw/usb-musb.c |6 +- hw/usb-ohci.c |6 +- hw/usb-uhci.c |6 +- hw/usb.c |2 +- hw/usb.h |8 +

[Qemu-devel] [PATCH v4 08/32] usb hub: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb hub driver over to the new descriptor infrastructure. It also removes the nr_ports variable and MAX_PORTS define and introduces a NUM_PORTS define instead. The numver of ports was (and still is) fixed at 8 anyway. Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c | 141

[Qemu-devel] [PATCH v4 03/32] usb hid: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb hid drivers (keyboard, mouse, tablet) over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann --- hw/usb-hid.c | 448 +++--- 1 files changed, 205 insertions(+), 243 deletions(-) diff --git a/hw/usb-hid.c b/hw/us

[Qemu-devel] [PATCH v4 07/32] usb bluetooth: use new descriptor infrastructure.

2011-01-12 Thread Gerd Hoffmann
Switch the usb bluetooth driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann --- hw/usb-bt.c | 473 +-- 1 files changed, 202 insertions(+), 271 deletions(-) diff --git a/hw/usb-bt.c b/hw/usb-bt.c index 56d1a6c..

[Qemu-devel] [PATCH v4 10/32] usb storage: serial number support

2011-01-12 Thread Gerd Hoffmann
If a serial number is present for the drive fill it into the usb serialnumber string descriptor. Signed-off-by: Gerd Hoffmann --- hw/usb-msd.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index 20ab886..9aa 100644 --- a/hw/usb-msd.

[Qemu-devel] [PATCH v4 17/32] usb: add usb_wakeup() + wakeup callback to port ops

2011-01-12 Thread Gerd Hoffmann
Add wakeup callback to port ops for remote wakeup handling. Also add a usb_wakeup() function for devices which want trigger a remote wakeup. Signed-off-by: Gerd Hoffmann --- hw/usb.c |7 +++ hw/usb.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/usb.c b/hw/

[Qemu-devel] [PATCH v4 26/32] usb storage: high speed support

2011-01-12 Thread Gerd Hoffmann
Add high speed support to the usb mass storage device. With this patch applied the linux kernel recognises the usb storage device as highspeed capable device and suggests to connect it to a highspeed port instead of the uhci. Tested with both uhci and (not-yet submitted) ehci. Signed-off-by: Ger

[Qemu-devel] [PATCH v4 09/32] usb descriptors: add settable strings.

2011-01-12 Thread Gerd Hoffmann
This patch allows to set usb descriptor strings per device instance. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c |1 + hw/usb-desc.c | 52 hw/usb-desc.h |4 +++- hw/usb.h |9 + 4 files changed, 57 insertions(+), 9

[Qemu-devel] [PATCH v4 18/32] usb: uhci: remote wakeup support.

2011-01-12 Thread Gerd Hoffmann
Add support for remote wakeup to the UHCI adapter. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 5e2e34a..2d2a9e7 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@

  1   2   >