[Qemu-devel] [PATCH] qbus: register reset handler for qbus whose parent is NULL

2010-12-18 Thread Isaku Yamahata
Stefan Weil reported the regression caused by ec990eb622ad46df5ddcb1e94c418c271894d416 as follows > The second regression also occurs with MIPS malta. > Networking no longer works with the default pcnet nic. > > This is caused because the reset function for pcnet is no > longer called during syste

Re: [Qemu-devel] Re: [PATCH] sparc32: ledma extra registers

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 19:53 schrieb Blue Swirl: On Sat, Dec 18, 2010 at 5:09 PM, Bob Breuer wrote: ledma has 0x20 bytes of registers according to OBP, and at least Solaris9 reads the 5th register which is beyond what we've mapped. So let's setup a flag (inspired by a previous patch from Blue Sw

[Qemu-devel] Re: [PATCH v3 3/7] target-i386: Don't use SoftFloat uint64 type

2010-12-18 Thread Juan Quintela
Andreas Färber wrote: > softfloat.h's uint64 type has least-width semantics, > which seems unintended here since uint64_t is used in helpers. > > v3: > * Split off. Acked-by: Juan Quintela Some days I feel the urgency of removing all the typealiases of softfloat.h :( > Cc: Huang Ying > Cc: J

[Qemu-devel] Re: [PATCH 2/2] ahci: delete write-only variables (v2)

2010-12-18 Thread Alexander Graf
On 18.12.2010, at 21:00, Blue Swirl wrote: > Avoid these warnings with GCC 4.6.0: > /src/qemu/hw/ide/ahci.c: In function 'ahci_reset_port': > /src/qemu/hw/ide/ahci.c:810:14: error: variable 'tfd' set but not used > [-Werror=unused-but-set-variable] > /src/qemu/hw/ide/ahci.c: In function 'handle_c

[Qemu-devel] [PATCH 2/2] ahci: delete write-only variables (v2)

2010-12-18 Thread Blue Swirl
Avoid these warnings with GCC 4.6.0: /src/qemu/hw/ide/ahci.c: In function 'ahci_reset_port': /src/qemu/hw/ide/ahci.c:810:14: error: variable 'tfd' set but not used [-Werror=unused-but-set-variable] /src/qemu/hw/ide/ahci.c: In function 'handle_cmd': /src/qemu/hw/ide/ahci.c:1103:19: error: variable '

[Qemu-devel] [PATCH 1/2] block: delete a write-only variable

2010-12-18 Thread Blue Swirl
Avoid a warning with GCC 4.6.0: /src/qemu/block.c: In function 'bdrv_img_create': /src/qemu/block.c:2862:25: error: variable 'fmt' set but not used [-Werror=unused-but-set-variable] CC: Kevin Wolf Signed-off-by: Blue Swirl --- block.c |5 - 1 files changed, 0 insertions(+), 5 deletions(

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Blue Swirl
Thanks, applied. On Sat, Dec 18, 2010 at 5:09 PM, Andreas Färber wrote: > Am 18.12.2010 um 17:34 schrieb Stefan Weil: > >> QEMU source code with CRLF line endings >> which is quite common on windows hosts >> fails with current make_device_config.sh. >> >> The awk script gets the name of the inclu

[Qemu-devel] Re: [OpenBIOS] [RFT] ppc64 OpenBIOS

2010-12-18 Thread Blue Swirl
On Sat, Dec 18, 2010 at 4:54 PM, Andreas Färber wrote: > Am 18.12.2010 um 17:33 schrieb Blue Swirl: > >> On Sat, Dec 18, 2010 at 2:30 AM, Andreas Färber >> wrote: >>> >>> Hello, >>> >>> Except for some fs/iso9660/ issues, ppc64 guests are booting for me with >>> the >>> last five OpenBIOS patches

[Qemu-devel] Re: [PATCH] sparc32: ledma extra registers

2010-12-18 Thread Blue Swirl
Thanks, applied. On Sat, Dec 18, 2010 at 5:09 PM, Bob Breuer wrote: > ledma has 0x20 bytes of registers according to OBP, and at least Solaris9 > reads the 5th register which is beyond what we've mapped.  So let's setup > a flag (inspired by a previous patch from Blue Swirl) to identify ledma > f

Re: [Qemu-devel] [PATCH v2 2/6] qdev: reset qdev along with qdev tree

2010-12-18 Thread Stefan Weil
Am 17.12.2010 05:47, schrieb Isaku Yamahata: On Fri, Dec 17, 2010 at 01:29:42PM +0900, Isaku Yamahata wrote: On Thu, Dec 16, 2010 at 08:31:21PM +0100, Stefan Weil wrote: The second regression also occurs with MIPS malta. Networking no longer works with the default pcnet nic. This is caused bec

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread malc
On Sat, 18 Dec 2010, Andreas F?rber wrote: > Am 18.12.2010 um 11:39 schrieb Peter Maydell: > > > On 18 December 2010 02:30, Nathan Froyd wrote: > > > I wouldn't be too worried: > > > > > > typedef uint8_t flag; > > > typedef uint8_t uint8; > > > typedef int8_t int8; > > > typedef int uint16; >

[Qemu-devel] Problems executing qemu-ppc

2010-12-18 Thread Stefano Bonifazi
Hi all! May someone help me running qemu-ppc? Executing: > qemu-ppc hello with hello a PPC binary, I get: /lib/ld.so.1: No such file or directory executing qemu-ppc without argument I get this: [...] -L path set the elf interpreter prefix (default=/usr/gnemul/qemu-ppc) [...] but /u

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 17:34 schrieb Stefan Weil: QEMU source code with CRLF line endings which is quite common on windows hosts fails with current make_device_config.sh. The awk script gets the name of the included file with \r, so instead of pci.mak it will search for pci.mak\r which of course does

[Qemu-devel] [PATCH] sparc32: ledma extra registers

2010-12-18 Thread Bob Breuer
ledma has 0x20 bytes of registers according to OBP, and at least Solaris9 reads the 5th register which is beyond what we've mapped. So let's setup a flag (inspired by a previous patch from Blue Swirl) to identify ledma from espdma, and map another 16 bytes of registers which return 0. Signed-off-

[Qemu-devel] Re: [OpenBIOS] [RFT] ppc64 OpenBIOS

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 17:33 schrieb Blue Swirl: On Sat, Dec 18, 2010 at 2:30 AM, Andreas Färber > wrote: Hello, Except for some fs/iso9660/ issues, ppc64 guests are booting for me with the last five OpenBIOS patches posted. What are the issues? It still hangs after the "Trying" line, as repor

[Qemu-devel] [PATCH v3 6/7] softfloat: Drop [u]int16 types in favor of [u]int_fast16_t

2010-12-18 Thread Andreas Färber
AIX already didn't use our definition, so let's start ripping out this one: As pointed out by Peter Maydell, int16 is currently int on most supported platforms, so let's replace it with int_fast16_t, allowing the system to use a wider type if appropriate. Note that Darwin uses [u]int16_t now, wher

[Qemu-devel] Re: [PATCH v3 2/7] wdt_ib700: Don't use SoftFloat int64 type

2010-12-18 Thread Richard W.M. Jones
On Sat, Dec 18, 2010 at 05:25:26PM +0100, Andreas Färber wrote: > softfloat.h's int64 type has least-width semantics, > but this doesn't seem intended here, so use plain int64_t. > > v3: > * Split off. > > Cc: Richard W.M. Jones > Signed-off-by: Andreas Färber > --- > hw/wdt_ib700.c |2 +-

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 13:31 schrieb Andreas Färber: Am 18.12.2010 um 13:15 schrieb Peter Maydell: On 18 December 2010 11:49, Andreas Färber wrote: IMO a lot of code in QEMU is cryptic because someone thinks that someone else must've thought something particular when doing it that way and is t

[Qemu-devel] Re: [RFT] ppc64 OpenBIOS

2010-12-18 Thread Blue Swirl
On Sat, Dec 18, 2010 at 2:30 AM, Andreas Färber wrote: > Hello, > > Except for some fs/iso9660/ issues, ppc64 guests are booting for me with the > last five OpenBIOS patches posted. What are the issues? > > You can find them together with the config change to use fs/grubfs/ here: > >  git://repo

[Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Stefan Weil
QEMU source code with CRLF line endings which is quite common on windows hosts fails with current make_device_config.sh. The awk script gets the name of the included file with \r, so instead of pci.mak it will search for pci.mak\r which of course does not work. Fix this by removing any \r. v2:

[Qemu-devel] [PATCH v3 7/7] softfloat: Make float{32, 64}_to_uint16_round_to_zero() use uint_fast16_t

2010-12-18 Thread Andreas Färber
v3: * Split off. Use uint_fast16_t rather than uint16_t. v2: * Initial. Cc: Peter Maydell Cc: Nathan Froyd Signed-off-by: Andreas Färber --- fpu/softfloat.c |8 fpu/softfloat.h |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softf

[Qemu-devel] [PATCH v3 4/7] softfloat: Resolve type mismatches between declaration and implementation

2010-12-18 Thread Andreas Färber
The original SoftFloat 2.0b library avoided the use of custom integer types in its public headers. This requires the definitions of int{8,16,32,64} to match the assumptions in the declarations. This breaks on BeOS R5 and Haiku/x86, where int32 is defined in {be,os}/support/SupportDefs.h in terms of

[Qemu-devel] [PATCH v3 2/7] wdt_ib700: Don't use SoftFloat int64 type

2010-12-18 Thread Andreas Färber
softfloat.h's int64 type has least-width semantics, but this doesn't seem intended here, so use plain int64_t. v3: * Split off. Cc: Richard W.M. Jones Signed-off-by: Andreas Färber --- hw/wdt_ib700.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/wdt_ib700.c b/hw/

[Qemu-devel] [PATCH v3 3/7] target-i386: Don't use SoftFloat uint64 type

2010-12-18 Thread Andreas Färber
softfloat.h's uint64 type has least-width semantics, which seems unintended here since uint64_t is used in helpers. v3: * Split off. Cc: Huang Ying Cc: Juan Quintela Signed-off-by: Andreas Färber --- target-i386/cpu.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PATCH v3 1/7] apic: Don't use SoftFloat uint32 type

2010-12-18 Thread Andreas Färber
softfloat.h's uint32 type has least-width semantics, whereas surrounding code uses uint32_t, so use uint32_t too. v3: * Split off. Signed-off-by: Andreas Färber --- hw/apic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index a5a53fb..ff581f0 1

Re: [Qemu-devel] Re: [Spice-devel] RFC; usb redirection protocol

2010-12-18 Thread Hans de Goede
Hi, On 12/15/2010 01:20 PM, Frédéric Grelot wrote: Do you know whenever certain low-level usb ops can work with this? I expect most usb devices to work with this, I don't know about really weird ones. Specifically iphone firmware flashing was mentioned on the list. I think that should wo

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Stefan Weil
Am 18.12.2010 13:02, schrieb Andreas Färber: Am 18.12.2010 um 11:19 schrieb Stefan Weil: Am 18.12.2010 00:24, schrieb Paolo Bonzini: On 12/17/2010 11:17 PM, Andreas Färber wrote: Example (needs bash's echo -e): # create line with crlf ending: echo -e 'include xy\r' >file # returns xy\r: awk

[Qemu-devel] Re: [PATCH] Fix build failure in assigned_device_pci_cap_init ()

2010-12-18 Thread Alex Williamson
On Sat, 2010-12-18 at 18:31 +0530, Kamalesh Babulal wrote: > Hi, > > cb1983b880 build fails with > > CCx86_64-softmmu/device-assignment.o > /other/srcs/qemu-kvm/hw/device-assignment.c: In function > 'assigned_device_pci_cap_init': > /other/srcs/qemu-kvm/hw/device-assignment.c:1463: err

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Nathan Froyd
On Sat, Dec 18, 2010 at 10:39:05AM +, Peter Maydell wrote: > On 18 December 2010 02:30, Nathan Froyd wrote: > > So adding _t suffixes in appropriate places should be a no-op, except > > for uint16/int16--and those types are never used. > > Eh? If you comment out the int16 typedef you'll find

[Qemu-devel] [PATCH] Fix build failure in assigned_device_pci_cap_init ()

2010-12-18 Thread Kamalesh Babulal
Hi, cb1983b880 build fails with CCx86_64-softmmu/device-assignment.o /other/srcs/qemu-kvm/hw/device-assignment.c: In function 'assigned_device_pci_cap_init': /other/srcs/qemu-kvm/hw/device-assignment.c:1463: error: 'PCI_PM_CTRL_NO_SOFT_RST' undeclared (first use in this function) /o

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 13:15 schrieb Peter Maydell: On 18 December 2010 11:49, Andreas Färber wrote: IMO a lot of code in QEMU is cryptic because someone thinks that someone else must've thought something particular when doing it that way and is thus reluctant to touch it... For a fact, [u]i

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Peter Maydell
On 18 December 2010 11:49, Andreas Färber wrote: > IMO a lot of code in QEMU is cryptic because someone thinks that someone > else must've thought something particular when doing it that way and is thus > reluctant to touch it... > For a fact, [u]int8 und [u]int64 remain unchanged width-wise. > F

Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 11:19 schrieb Stefan Weil: Am 18.12.2010 00:24, schrieb Paolo Bonzini: On 12/17/2010 11:17 PM, Andreas Färber wrote: Example (needs bash's echo -e): # create line with crlf ending: echo -e 'include xy\r' >file # returns xy\r: awk '/^include / {ORS=" "; print $2}' file | od

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 11:39 schrieb Peter Maydell: On 18 December 2010 02:30, Nathan Froyd wrote: I wouldn't be too worried: typedef uint8_t flag; typedef uint8_t uint8; typedef int8_t int8; typedef int uint16; typedef int int16; typedef unsigned int uint32; typedef signed int int32; typedef uint

Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-18 Thread Peter Maydell
On 18 December 2010 02:30, Nathan Froyd wrote: > I wouldn't be too worried: > > typedef uint8_t flag; > typedef uint8_t uint8; > typedef int8_t int8; > typedef int uint16; > typedef int int16; > typedef unsigned int uint32; > typedef signed int int32; > typedef uint64_t uint64; > typedef int64_t i

[Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Stefan Weil
Am 18.12.2010 00:24, schrieb Paolo Bonzini: On 12/17/2010 11:17 PM, Andreas Färber wrote: Example (needs bash's echo -e): # create line with crlf ending: echo -e 'include xy\r' >file # returns xy\r: awk '/^include / {ORS=" "; print $2}' file | od 000 074570 020015 004 # should retu

Re: [Qemu-devel] [PATCH 1/2] ide: Fix build for cmd646.c

2010-12-18 Thread Stefan Hajnoczi
On Fri, Dec 17, 2010 at 7:39 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > Acked-by: Andreas Färber > --- >  hw/ide/cmd646.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) Sorry, I should have rebuilt all targets before sending f25497613134e3d1e82e216075ebe1f550e78124. S

[Qemu-devel] Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-12-18 Thread Stefan Hajnoczi
On Fri, Dec 17, 2010 at 4:19 PM, Yoshiaki Tamura wrote: > 2010/12/17 Stefan Hajnoczi : >> On Thu, Dec 16, 2010 at 9:50 AM, Yoshiaki Tamura >> wrote: >>> 2010/12/16 Michael S. Tsirkin : On Thu, Dec 16, 2010 at 04:37:41PM +0900, Yoshiaki Tamura wrote: > 2010/11/28 Yoshiaki Tamura : > >