[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 09:52:19PM -0500, Kevin O'Connor wrote: > On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: > > On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: > > > On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > > > > On Sun, Nov 14, 2010 at 10:

[Qemu-devel] [PATCH 3/4] virtio-net: Convert fprintf() to error_report()

Signed-off-by: Stefan Hajnoczi --- hw/virtio-net.c | 41 - 1 files changed, 20 insertions(+), 21 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 7e1688c..1d61f19 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -120,8 +120,8 @@ sta

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: > On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: > > On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > > > On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > > > > Why not just return a newli

[Qemu-devel] [PATCH 4/4] virtio-pci: Convert fprintf() to error_report()

Signed-off-by: Stefan Hajnoczi --- hw/virtio-pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 729917d..b9d0349 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -254,8 +254,8 @@ static void virtio_ioport_write(void *opaq

[Qemu-devel] [RFC][PATCH v3 21/21] virtproxy: Makefile/configure changes to build qemu-vp

Signed-off-by: Michael Roth --- .gitignore |1 + Makefile |4 +++- configure |1 + 3 files changed, 5 insertions(+), 1 deletions(-) diff --git a/.gitignore b/.gitignore index a43e4d1..da307d2 100644 --- a/.gitignore +++ b/.gitignore @@ -31,6 +31,7 @@ qemu-img-cmds.texi qemu-img-

Re: [Qemu-devel] How to detect a stopped guest os?

On Tue, Nov 16, 2010 at 02:54, Wilhelm wrote: > Hello, > > I know, this is not the right place to ask, but I wasn't abled to find a > users mailing list. > > The question: is there any qemu (monitor) command to detect if the guest > os has stopped / poweroff? have you checked "info status"? --

[Qemu-devel] [RFC][PATCH v3 15/21] virtproxy: add read handler for proxied connections

reads data from client/server connections as they become readable, then sends the data over the channel Signed-off-by: Michael Roth --- virtproxy.c | 114 +++ virtproxy.h |1 + 2 files changed, 115 insertions(+), 0 deletions(-) diff -

[Qemu-devel] [RFC][PATCH v3 08/21] virtproxy: add vp_new() VPDriver constructor

Signed-off-by: Michael Roth --- virtproxy.c | 40 virtproxy.h |6 ++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 091a223..401d51c 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -359,3 +359,43 @@

[Qemu-devel] [RFC][PATCH v3 05/21] virtproxy, add vp_channel_send_all

This handles sending of data to channel fd (qemu-vp in guest) or the device associated with the virtproxy chardev for the host depending on the context. vp_chr_read() wraps qemu_chr_read(), it'll be defined later in virtproxy-builtin.c, and noop'd in the guest agent via qemu-vp.c. Signed-off-by: M

[Qemu-devel] [RFC][PATCH v3 18/21] virtproxy: qemu integration, add virtproxy chardev

This allows us to create a virtproxy instance via a chardev. It can now be created with something like: qemu -chardev virtproxy,id=vp1 \ -device virtio-serial \ -device virtserialport,chardev=vp1 In the future the ability to add oforwards/iforwards in the command-line invocation and the

[Qemu-devel] [RFC][PATCH v3 17/21] virtproxy: add virtproxy-builtin.c for compat defs

Virtproxy relies on routines defined within qemu-vp which mirror various i/o related operations in qemu to provide similar functionality for the guest daemon. When building virtproxy as part of qemu rather than qemu-vp we need these definitions to provide those functions in terms of the original qe

[Qemu-devel] [RFC][PATCH v3 20/21] virtproxy: qemu-vp, main logic

Signed-off-by: Michael Roth --- qemu-vp.c | 368 ++- virtproxy.c | 24 2 files changed, 367 insertions(+), 25 deletions(-) diff --git a/qemu-vp.c b/qemu-vp.c index 5075cdc..cfd2a69 100644 --- a/qemu-vp.c +++ b/qemu-vp.c @@ -9,10

[Qemu-devel] [RFC][PATCH v3 16/21] virtproxy: add option parser helper vp_parse()

This routine will parse iforward/oforward options for both qemu-vp and the virtproxy chardev Signed-off-by: Michael Roth --- virtproxy.c | 77 +++ virtproxy.h |1 + 2 files changed, 78 insertions(+), 0 deletions(-) diff --git a/virtp

[Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for control packet

Process control packets coming in over the channel. This entails setting up/tearing down connections to local services initiated from the other end of the channel. Signed-off-by: Michael Roth --- virtproxy.c | 154 +++ 1 files changed, 154

[Qemu-devel] [RFC][PATCH v3 19/21] virtproxy: qemu integration, add virtproxy to Makefile.targets

Signed-off-by: Michael Roth --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index 91e6e74..f08c435 100644 --- a/Makefile.target +++ b/Makefile.target @@ -164,7 +164,7 @@ endif #CONFIG_BSD_USER # System emulator targ

[Qemu-devel] [RFC][PATCH v3 07/21] virtproxy: add read handler for communication channel

Handle data coming in over the channel as VPPackets: Process control messages and forward data from remote client/server connections to the appropriate server/client FD on our end. We also provide here a helper function to process a stream of packets from the channel. Signed-off-by: Michael Roth

[Qemu-devel] [RFC][PATCH v3 14/21] virtproxy: use new option list in virtproxy.c

Signed-off-by: Michael Roth --- virtproxy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index b683ee6..9e1745f 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -764,7 +764,7 @@ int vp_set_iforward(VPDriver *drv, const char *service_id, const

[Qemu-devel] [RFC][PATCH v3 06/21] virtproxy: add accept handler for communication channel

This accept()'s connections to the socket we told virtproxy to listen for the channel connection on and sets the appropriate read handler for the resulting FD. This is only used only for network-based channels and will most likely be dropped with the introduction of the virtproxy chardev. Signed-o

[Qemu-devel] [RFC][PATCH v3 12/21] virtproxy: add vp_handle_packet()

Signed-off-by: Michael Roth --- virtproxy.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 0cc8950..01a36c2 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -464,6 +464,29 @@ static int vp_handle_data_packet(void *drv,

[Qemu-devel] [RFC][PATCH v3 13/21] virtproxy: interfaces to set/remove VPIForwards

Signed-off-by: Michael Roth --- virtproxy.c | 59 +++ virtproxy.h |2 ++ 2 files changed, 61 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 01a36c2..b683ee6 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -7

[Qemu-devel] [RFC][PATCH v3 02/21] virtproxy: qemu-vp, standalone daemon skeleton

Daemon to be run in guest, or on host in standalone mode. (re-)implements some qemu utility functions used by core virtproxy.c code via wrapper functions. For built-in virtproxy code we will define these wrapper functions in terms of qemu's built-in implementations. Main logic will come in a later

[Qemu-devel] [RFC][PATCH v3 10/21] virtproxy: add handler for data packets

Process VPPackets coming in from channel and send them to the appropriate server/client connections. Signed-off-by: Michael Roth --- virtproxy.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index f189

[Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

Signed-off-by: Michael Roth --- virtproxy.c | 136 +++ virtproxy.h | 34 +++ 2 files changed, 170 insertions(+), 0 deletions(-) create mode 100644 virtproxy.c create mode 100644 virtproxy.h diff --git a/virtproxy.c b/virtp

[Qemu-devel] [RFC][PATCH v3 03/21] virtproxy: add debug functions for virtproxy core

Signed-off-by: Michael Roth --- virtproxy.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 8f18d83..3686c77 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -13,6 +13,23 @@ #include "virtproxy.h" +#define DEBUG_VP + +#i

[Qemu-devel] [RFC][PATCH v3 09/21] virtproxy: interfaces to set/remove/handle VPOForwards

Functions to add listener FDs (oforwards) which set up proxied connections to associated service, and the corresponding handler function to process to new connections to said FDs and initialize new client connections to the associated remote server over the channel Signed-off-by: Michael Roth ---

[Qemu-devel] [RFC][PATCH v3 04/21] virtproxy: list look-up functions conns/oforwards/iforwards

Signed-off-by: Michael Roth --- virtproxy.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 3686c77..2cfd905 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -151,3 +151,47 @@ static QemuOptsList vp

[Qemu-devel] [RFC][PATCH v3 00/21] virtproxy: host/guest communication layer

OVERVIEW: Virtproxy proxies and multiplexes network/unix socket streams over a data channel between a host and a guest (currently network connections, emulated serial, or virtio-serial channels are supported). This allows for services such as guest data collection agents, host/guest file transf

[Qemu-devel] [PATCH 1/4] virtio-blk: Convert fprintf() to error_report()

Errors should be logged using error_report() so they go to the appropriate monitor. Signed-off-by: Stefan Hajnoczi --- hw/virtio-blk.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 49528a9..e5f9b27 100644 --- a/hw/virtio-blk.c

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On 11/15/2010 04:44 PM, Michael S. Tsirkin wrote: So I'm not sure I understand what is proposed here. Care posting a patch? I *think* just adding: if (vm_running == 0) { return qemu_net_queue_append(queue, sender, flags, data, size, NULL); } To qemu_net_queue_send() along with a state

[Qemu-devel] Re: [PATCH] device-assignment: register a reset function

[Wrong list, it's not upstream yet. I'm migrating the thread to kvm.] Am 15.11.2010 12:33, Bernhard Kohl wrote: > This is necessary because during reboot of a VM the assigned devices > continue DMA transfers which causes memory corruption. > > Signed-off-by: Thomas Ostler > Signed-off-by: Bernha

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On Mon, Nov 15, 2010 at 03:05:39PM -0600, Anthony Liguori wrote: > On 11/15/2010 02:53 PM, Stefan Hajnoczi wrote: > > > >vhost has a solution for this: register a VMChangeStateHandler > >function that stops ioeventfd while vm_stop(0) is in effect. Then > >poll to see if there is work pending. > >

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

Le 15 nov. 2010 à 20:30, Anthony Liguori a écrit : >> I'll see if I can buffer a bit more in the twolame code and if it helps, >> then I'll try to merge with the failed attempts I have around at using >> external progs. >> > > Okay, but my thinking was that we'd do something like: > > audi

[Qemu-devel] [PATCH] slirp: Remove unused code for bad sprintf

Neither DECLARE_SPRINTF nor BAD_SPRINTF are needed for QEMU. QEMU won't support systems with missing or bad declarations for sprintf. The unused code was detected while looking for functions with missing format checking. Instead of adding GCC_FMT_ATTR, the unused code was removed. Cc: Blue Swirl

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

On Mon, Nov 15, 2010 at 03:07:51PM -0600, Anthony Liguori wrote: > Thanks. Second question is how portable is SIOCGIFADDR? I suspect > that's very Linux-centric.. It ostensibly exists in FreeBSD, but I can't get master to compile under 7.3-RELEASE or 8.1-STABLE. Given that it is unavailable

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

Am 15.11.2010 22:07, schrieb Anthony Liguori: On 11/15/2010 01:52 PM, Mike Ryan wrote: I'll clarify/elaborate a bit: When using a multicast socket, the OS chooses a default physical interface to send packets. The patch I've supplied allows the user to select the interface. Suppose you have a s

Re: [Qemu-devel] virtio-blk broken after system reset

On 11/13/2010 04:09 AM, Jan Kiszka wrote: There is also real hw out there that goes into an error state if it's misprogrammed. I think we have to remove all those premature exits. They also prevent handing the device inside the guest to an untrusted driver (relevant once we have IOMMU emulation

[Qemu-devel] KVM call agenda for Nov 16

Please send in any agenda items you are interested in covering. thanks, -chris

[Qemu-devel] Re: [PATCH] configure: Add compiler option -Wmissing-format-attribute

Am 15.11.2010 21:22, schrieb Stefan Weil: With the previous patches, hopefully all functions with printf like arguments use gcc's format checking. This was tested with default build configuration on linux and windows hosts (including some cross compilations), so chances are good that there remai

[Qemu-devel] [PATCH] trace: Use fprintf_function (format checking)

fprintf_function adds format checking with GCC_FMT_ATTR. Cc: Blue Swirl Signed-off-by: Stefan Weil --- simpletrace.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/simpletrace.h b/simpletrace.h index 72614ec..2f44ed3 100644 --- a/simpletrace.h +++ b/simpletrace.h

Re: [Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking)

Am 15.11.2010 21:01, schrieb Andreas Färber: Am 15.11.2010 um 19:39 schrieb Stefan Weil: This patch adds more printf format checking. Additional modifications were needed for this code change: * alpha-dis.c: The local definition of MAX conflicts with a previous definition from osdep.h, so ad

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010/11/15 Gleb Natapov : > On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote: >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.c |   14 ++ >> >  hw/fw_cfg.h |    4 +++- >> >  sysemu.h    |    1 + >> >  vl.

[Qemu-devel] [PATCH] configure: Add compiler option -Wmissing-format-attribute

With the previous patches, hopefully all functions with printf like arguments use gcc's format checking. This was tested with default build configuration on linux and windows hosts (including some cross compilations), so chances are good that there remain few (if any) functions without format chec

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On Mon, Nov 15, 2010 at 4:09 PM, Anthony Liguori wrote: > On 11/15/2010 09:18 AM, Michael S. Tsirkin wrote: >> >> On Mon, Nov 15, 2010 at 08:55:07AM -0600, Anthony Liguori wrote: >> >>> >>> On 11/15/2010 08:52 AM, Juan Quintela wrote: >>> "Michael S. Tsirkin"   wrote: > > Th

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On Mon, Nov 15, 2010 at 10:09:29AM -0600, Anthony Liguori wrote: > On 11/15/2010 09:18 AM, Michael S. Tsirkin wrote: > >On Mon, Nov 15, 2010 at 08:55:07AM -0600, Anthony Liguori wrote: > >>On 11/15/2010 08:52 AM, Juan Quintela wrote: > >>>"Michael S. Tsirkin" wrote: > There's no reason for ta

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

On 11/15/2010 01:52 PM, Mike Ryan wrote: I'll clarify/elaborate a bit: When using a multicast socket, the OS chooses a default physical interface to send packets. The patch I've supplied allows the user to select the interface. Suppose you have a setup like so: BoxA --- BoxB --- BoxC You wish

Re: [Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

On 11/15/2010 11:53 AM, Arun R Bharadwaj wrote: From: Gautham R Shenoy This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The patch creates a global queue on-to which subsystems can queue their tasks to be executed asynchronously. The patch also provides

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On 11/15/2010 02:53 PM, Stefan Hajnoczi wrote: vhost has a solution for this: register a VMChangeStateHandler function that stops ioeventfd while vm_stop(0) is in effect. Then poll to see if there is work pending. I will add equivalent functionality to virtio-ioeventfd. I still think tha

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On 11/15/2010 02:26 PM, Michael S. Tsirkin wrote: Are there any system ones? There's one in qemu-char.c. Not sure it's easy to just say for the future that there can't be BHs that get delivered during vmstop. Can we just stop processing them? We ran into a lot of problems trying

[Qemu-devel] [PATCH 0/4] virtio: Convert fprintf() to error_report()

The virtio hardware emulation code uses fprintf(stderr, ...) error messages. Improve things slightly by moving to error_report() so error messages will be printed to the monitor, if present. We want to handle device error states properly instead of bailing out with exit(1) but this series does not

[Qemu-devel] [PATCH 2/4] virtio: Convert fprintf() to error_report()

Signed-off-by: Stefan Hajnoczi --- hw/virtio.c | 35 ++- 1 files changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index a2a657e..849a60f 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -14,6 +14,7 @@ #include #include "trace.h

[Qemu-devel] Re: [PATCH RESENT] msix: allow byte and word reading from mmio

On Mon, Nov 15, 2010 at 05:40:30PM +0100, Bernhard Kohl wrote: > Am 15.11.2010 11:42, schrieb ext Michael S. Tsirkin: > >On Thu, Aug 19, 2010 at 02:56:51PM +0200, Bernhard Kohl wrote: > >>It's legal that the guest reads a single byte or word from mmio. > >Interesting. The spec seems to say this: >

[Qemu-devel] [PATCH] darwin-user: Use GCC_FMT_ATTR (format checking)

The redundant forward declaration of qerror in machload.c is removed because it should be taken from qemu.h. Please note that this patch is untested because I have no matching environment to compile it. Cc: Blue Swirl Signed-off-by: Stefan Weil --- darwin-user/machload.c |2 +- darwin-user

Re: [Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking)

Am 15.11.2010 um 19:39 schrieb Stefan Weil: This patch adds more printf format checking. Additional modifications were needed for this code change: * alpha-dis.c: The local definition of MAX conflicts with a previous definition from osdep.h, so add an #undef. * dis-asm.h: Add include for fpr

Re: [Qemu-devel] [PATCH] make trace options use autoconfy names

Am 15.11.2010 um 16:48 schrieb Paolo Bonzini: On 11/15/2010 03:17 PM, Stefan Hajnoczi wrote: On Sun, Nov 14, 2010 at 1:52 PM, Paolo Bonzini wrote: On 11/14/2010 02:38 PM, Andreas Färber wrote: - --trace-file=*) trace_file="$optarg" + --enable-trace-file=*) trace_file="$optarg" ;; but thi

[Qemu-devel] [PATCH] audio: Use GCC_FMT_ATTR (format checking)

Cc: Blue Swirl Signed-off-by: Stefan Weil --- audio/audio_pt_int.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/audio/audio_pt_int.c b/audio/audio_pt_int.c index f15cc70..908c569 100644 --- a/audio/audio_pt_int.c +++ b/audio/audio_pt_int.c @@ -8,7 +8,8 @@ #includ

[Qemu-devel] How to detect a stopped guest os?

Hello, I know, this is not the right place to ask, but I wasn't abled to find a users mailing list. The question: is there any qemu (monitor) command to detect if the guest os has stopped / poweroff? -- Wilhelm

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

I'll clarify/elaborate a bit: When using a multicast socket, the OS chooses a default physical interface to send packets. The patch I've supplied allows the user to select the interface. Suppose you have a setup like so: BoxA --- BoxB --- BoxC You wish to run virtual machines on BoxB and BoxC a

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

On 11/15/2010 12:54 PM, Mike Ryan wrote: Anyone care to comment? I must admit, I don't understand the use-case well enough to really give an appropriate amount of review as to whether this is the best solution to the problem. Michael, do you have any thoughts? Regards, Anthony Liguori

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

On 11/12/2010 10:54 AM, François Revol wrote: Le 12 nov. 2010 à 15:32, Anthony Liguori a écrit : I did try years ago, but at least the current wav driver really didn't like fifos back then. I recall trying for hours to get it pipe to ffmpeg or others without much luck. Also, this poses s

[Qemu-devel] [PATCH] target-sparc: Use fprintf_function (format checking)

This change was missing in commit 9a78eead0c74333a394c0f7bbfc4423ac746fcd5. Cc: Blue Swirl Signed-off-by: Stefan Weil --- target-sparc/cpu.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 7e0d17c..eb5d9c1 100644 --- a/ta

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

Anyone care to comment? On Wed, Nov 10, 2010 at 05:47:35PM -0800, Mike Ryan wrote: > Add an option to specify the host interface to send multicast packets on > when using a multicast socket for networking. The option takes the name > of a host interface (e.g., eth0) and sets the IP_MULTICAST_IF so

[Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking)

This patch adds more printf format checking. Additional modifications were needed for this code change: * alpha-dis.c: The local definition of MAX conflicts with a previous definition from osdep.h, so add an #undef. * dis-asm.h: Add include for fprintf_function (qemu-common.h). The standard

[Qemu-devel] [PATCH 3/3] Add helper functions to enable virtio-9p make use of the threadlets

From: Gautham R Shenoy infrastructure for offloading blocking tasks such as making posix calls on to the helper threads and handle the post_posix_operations() from the context of the iothread. This frees the vcpu thread to process any other guest operations while the processing of v9fs_io is in p

[Qemu-devel] [PATCH 2/3] Move threadlets infrastructure to qemu-threadlets.c

The reason for creating this generic infrastructure is so that other subsystems, such as virtio-9p could make use of it for offloading tasks that could block. Signed-off-by: Arun R Bharadwaj Signed-off-by: Aneesh Kumar K.V Signed-off-by: Gautham R Shenoy Signed-off-by: Sripathi Kodi Acked-by:

[Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

From: Gautham R Shenoy This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The patch creates a global queue on-to which subsystems can queue their tasks to be executed asynchronously. The patch also provides API's that allow a subsystem to create a private

[Qemu-devel] [PATCH 0/3] v11: Threadlets: A generic task offloading framework

Hi, This is the v11 of the refactored patch-series to have a generic asynchronous task offloading framework (called threadlets) within qemu. I have run KVM autotest suite with this patch. This test suite ran successfully for the following tests: -connecthon -ebizzy -dbench

[Qemu-devel] Re: [PATCH] pci: allow hotplug removal of cold-plugged devices

On Sun, Nov 14, 2010 at 7:18 AM, Michael S. Tsirkin wrote: > This patch fixes 5beb8ad503c88a76f2b8106c3b74b4ce485a60e1 > which broke hotplug removal of cold plugged devices: > > - pass addition/removal state to hotplug callbacks > - use that in piix and pcie > > This also fixes an assert on hotplu

[Qemu-devel] [Bug 241119] Re: usb_add of a Creative ZEN unrecognized in guest

Hi. I have a similar problem, with a simple JetFlash usb drive. After adding it with usb_add, "info usb" shows nothing and I start getting the following message in the console: husb: config #1 need -1 husb: 1 interfaces claimed for configuration 1 husb: grabbed usb device 1.3 usb_linux_update_end

[Qemu-devel] [Bug 611142] Re: seabios should have native scsi support

(Clearly this must be done upstream first, so marking Triaged for the Ubuntu task) ** Changed in: qemu-kvm (Ubuntu) Status: New => Triaged -- seabios should have native scsi support https://bugs.launchpad.net/bugs/611142 You received this bug notification because you are a member of qemu-

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)

On Mon, Nov 15, 2010 at 9:04 AM, Christian Brunner wrote: > Hi Stefan, > > thanks for your feedback. Yehuda and Sage have already committed some > pathes to our git repository. > > What I'm not sure about is the rados_(de)initialization for multiple > rbd images. I suspect that _deinitialize shoul

[Qemu-devel] Re: [PATCH] make-release: fix mtime for a wider range of git versions

Am 15.11.2010 12:48, schrieb Bernhard Kohl: With the latest git versions, e.g. 1.7.2.3, git still prints out the tag info in addition to the requested format. So let's simply fetch the first line from the output. In addition I use the --pretty option instead of --format which is not recognized i

[Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?

Am 25.10.2010 18:54, schrieb Michael S. Tsirkin: On Mon, Oct 25, 2010 at 06:23:24PM +0200, Stefan Weil wrote: Am 25.10.2010 14:11, schrieb Markus Armbruster: Stefan Weil writes: Am 13.10.2010 09:13, schrieb Markus Armbruster: Stefan Weil writes: [..

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)

Hi Stefan, thanks for your feedback. Yehuda and Sage have already committed some pathes to our git repository. What I'm not sure about is the rados_(de)initialization for multiple rbd images. I suspect that _deinitialize should only be called for the last rbd image. Yehuda and Sage know librados

Re: [Qemu-devel] [PATCH] Introduce -accel command option.

On 11/15/2010 09:45 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD This option gives the ability to switch one "accelerator" like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a comma. QEMU will try each one and use the first whose works

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: Use chroot to safely access files in passthrough model

On Mon, Nov 15, 2010 at 2:52 PM, M. Mohan Kumar wrote: > In passthrough security model, following symbolic links in the server > side could result in accessing files outside guest's export path.This > could happen under two conditions: > 1) If a modified guest kernel is sending symbolic link as pa

[Qemu-devel] Re: [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

> This patch introduce a fallback mechanism for old systems that do not > support utimensat(). This fix build failure with following warnings: > > hw/virtio-9p-local.c: In function 'local_utimensat': > hw/virtio-9p-local.c:479: warning: implicit declaration of function > 'utimensat' hw/virtio-9p-

[Qemu-devel] Re: [PATCH RESENT] msix: allow byte and word reading from mmio

Am 15.11.2010 11:42, schrieb ext Michael S. Tsirkin: On Thu, Aug 19, 2010 at 02:56:51PM +0200, Bernhard Kohl wrote: It's legal that the guest reads a single byte or word from mmio. Interesting. The spec seems to say this: For all accesses to MSI-X Table and MSI-X PBA fields,

Re: [Qemu-devel] Re: [PATCH] pc: disable the BOCHS BIOS panic port

Am 15.11.2010 11:09, schrieb ext Alexander Graf: On 15.11.2010, at 10:53, Bernhard Kohl wrote: Am 01.09.2010 16:44, schrieb Bernhard Kohl: We have an OS which writes to port 0x400 when probing for special hardware. This causes an exit of the VM. With SeaBIOS this port isn't used anyw

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On 11/15/2010 09:18 AM, Michael S. Tsirkin wrote: On Mon, Nov 15, 2010 at 08:55:07AM -0600, Anthony Liguori wrote: On 11/15/2010 08:52 AM, Juan Quintela wrote: "Michael S. Tsirkin" wrote: There's no reason for tap to run when VM is stopped. If we let it, it confuses the bri

Re: [Qemu-devel] [PATCH] make trace options use autoconfy names

On 11/15/2010 03:17 PM, Stefan Hajnoczi wrote: On Sun, Nov 14, 2010 at 1:52 PM, Paolo Bonzini wrote: On 11/14/2010 02:38 PM, Andreas Färber wrote: - --trace-file=*) trace_file="$optarg" + --enable-trace-file=*) trace_file="$optarg" ;; but this should be --with-trace-file=... please. It is n

[Qemu-devel] [PATCH] Introduce -accel command option.

From: Anthony PERARD This option gives the ability to switch one "accelerator" like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a comma. QEMU will try each one and use the first whose works. So, -accel xen,kvm,tcg which would try Xen support fi

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On Mon, Nov 15, 2010 at 03:52:54PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > There's no reason for tap to run when VM is stopped. > > If we let it, it confuses the bridge on TX > > and corrupts DMA memory on RX. > > > > Signed-off-by: Michael S. Tsirkin > > once here, what ha

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On Mon, Nov 15, 2010 at 08:55:07AM -0600, Anthony Liguori wrote: > On 11/15/2010 08:52 AM, Juan Quintela wrote: > >"Michael S. Tsirkin" wrote: > >>There's no reason for tap to run when VM is stopped. > >>If we let it, it confuses the bridge on TX > >>and corrupts DMA memory on RX. > >> > >>Signed-

[Qemu-devel] [PATCH 2/2] virtio-9p: Use chroot interface in passthrough model

Make use of chroot interfaces for passthrough security model to fix the vulnerability in following symbolic links. Signed-off-by: M. Mohan Kumar --- hw/virtio-9p-local.c | 284 ++ 1 files changed, 218 insertions(+), 66 deletions(-) diff --git a/h

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

On 11/15/2010 08:52 AM, Juan Quintela wrote: "Michael S. Tsirkin" wrote: There's no reason for tap to run when VM is stopped. If we let it, it confuses the bridge on TX and corrupts DMA memory on RX. Signed-off-by: Michael S. Tsirkin once here, what handlers make sense to run while

[Qemu-devel] [PATCH 1/2] virtio-9p: Use chroot to safely access files in passthrough model

In passthrough security model, following symbolic links in the server side could result in accessing files outside guest's export path.This could happen under two conditions: 1) If a modified guest kernel is sending symbolic link as part of the file path and when resolving that symbolic link at ser

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

"Michael S. Tsirkin" wrote: > There's no reason for tap to run when VM is stopped. > If we let it, it confuses the bridge on TX > and corrupts DMA memory on RX. > > Signed-off-by: Michael S. Tsirkin once here, what handlers make sense to run while stopped? /me can think of the normal console, no

Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.

On Mon, 15 Nov 2010, Anthony PERARD wrote: > On Mon, 15 Nov 2010, Alexander Graf wrote: > > > > > On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: > > > > > From: Anthony PERARD > > > > > > This option gives the ability to switch one "accelerator" like kvm, xen > > > or the default one t

Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.

On 15.11.2010, at 15:47, Anthony PERARD wrote: > On Mon, 15 Nov 2010, Anthony PERARD wrote: > >> On Mon, 15 Nov 2010, Alexander Graf wrote: >> >>> >>> On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: >>> From: Anthony PERARD This option gives the ability to switch on

[Qemu-devel] [PATCHv5 14/15] Add notifier that will be called when machine is fully created.

Action that depends on fully initialized device model should register with this notifier chain. Signed-off-by: Gleb Natapov --- sysemu.h |2 ++ vl.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index 48f8eee..c42f33a 100644 -

[Qemu-devel] [PATCHv5 11/15] Add bootindex parameter to net/block/fd device

If bootindex is specified on command line a string that describes device in firmware readable way is added into sorted list. Later this list will be passed into firmware to control boot order. Signed-off-by: Gleb Natapov --- block_int.h |4 +++- hw/e1000.c |4 hw/eepro100.c

[Qemu-devel] [PATCHv5 09/15] Record which USBDevice USBPort belongs too.

Ports on root hub will have NULL here. This is needed to reconstruct path from device to its root hub to build device path. Signed-off-by: Gleb Natapov --- hw/usb-bus.c |3 ++- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +- hw/usb.h

[Qemu-devel] [PATCHv5 05/15] Store IDE bus id in IDEBus structure for easy access.

Signed-off-by: Gleb Natapov --- hw/ide/cmd646.c |4 ++-- hw/ide/internal.h |3 ++- hw/ide/isa.c |2 +- hw/ide/piix.c |4 ++-- hw/ide/qdev.c |3 ++- hw/ide/via.c |4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/ide/cmd646.c b/

[Qemu-devel] [PATCHv5 03/15] Keep track of ISA ports ISA device is using in qdev.

Store all io ports used by device in ISADevice structure. Signed-off-by: Gleb Natapov --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 25 + hw/isa.h |4 hw/m48t59.c

[Qemu-devel] [PATCHv5 08/15] Add get_fw_dev_path callback for pci bus.

Signed-off-by: Gleb Natapov --- hw/pci.c | 108 - 1 files changed, 85 insertions(+), 23 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 962886e..114b435 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -43,12 +43,14 @@ static void pcibu

[Qemu-devel] [PATCHv5 00/15] boot order specification

I am using open firmware naming scheme to specify device path names. In this version: fixed compilation problem, changed how device list is passed into firmware. Names look like this on pci machine: /p...@i0cf8/i...@1,1/dr...@1/d...@0 /p...@i0cf8/i...@1/f...@03f1/flo...@1 /p...@i0cf8/i...@1/f...@0

[Qemu-devel] [PATCHv5 15/15] Pass boot device list to firmware.

Signed-off-by: Gleb Natapov --- hw/fw_cfg.c | 15 +++ hw/fw_cfg.h |5 - sysemu.h|1 + vl.c| 49 + 4 files changed, 69 insertions(+), 1 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 7b9434f..4eea3

[Qemu-devel] [PATCHv5 12/15] Change fw_cfg_add_file() to get full file path as a parameter.

Change fw_cfg_add_file() to get full file path as a parameter instead of building one internally. Two reasons for that. First caller may need to know how file is named. Second this moves policy of file naming out from fw_cfg. Platform may want to use more then two levels of directories for instance

[Qemu-devel] [PATCHv5 02/15] Introduce new BusInfo callback get_fw_dev_path.

New get_fw_dev_path callback will be used for build device path usable by firmware in contrast to qdev qemu internal device path. Signed-off-by: Gleb Natapov --- hw/qdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index 9f90efe..dc669b3 10064

[Qemu-devel] [PATCHv5 10/15] Add get_dev_path callback for usb bus.

Signed-off-by: Gleb Natapov --- hw/usb-bus.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 256b881..8b4583c 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -5,11 +5,13 @@ #include "monitor.h"

  1   2   >