[Qemu-devel] Re: Cannot not unplug cold-plugged devices

2010-11-11 Thread Isaku Yamahata
On Thu, Nov 11, 2010 at 11:29:39PM -0700, Cam Macdonell wrote: > Hi, > > I was trying to do a "device_del" on my ivshmem device and it won't > work unless the device is added via hotplug. If the device is > coldplugged (added at startup) then nothing happens. I think I > tracked this behaviour t

Re: [Qemu-devel] [Bug 671831] Re: Sparc guest assert error

2010-11-11 Thread Stefan Hajnoczi
On Thu, Nov 11, 2010 at 10:45 PM, Nigel Horne <671...@bugs.launchpad.net> wrote: > Stefan, > >> Try: >> git clone -b scsi_assert_moved git://repo.or.cz/qemu/stefanha.git >> > > I have tried that branch.  I get no assertion failure with it. Great, thank you. I will submit the patch for qemu.git.

[Qemu-devel] Re: [RFC PATCH 8/8] device-assignment: pass through and stub more PCI caps

2010-11-11 Thread Alex Williamson
On Fri, 2010-11-12 at 07:36 +0200, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2010 at 07:56:46PM -0700, Alex Williamson wrote: > > Some drivers depend on finding capabilities like power management, > > PCI express/X, vital product data, or vendor specific fields. Now > > that we have better capab

[Qemu-devel] Cannot not unplug cold-plugged devices

2010-11-11 Thread Cam Macdonell
Hi, I was trying to do a "device_del" on my ivshmem device and it won't work unless the device is added via hotplug. If the device is coldplugged (added at startup) then nothing happens. I think I tracked this behaviour to the patch below. Is not allowing coldplugged devices to be unplugged the

Re: [Qemu-devel] No Virtual Console

2010-11-11 Thread Mulyadi Santosa
Hi... On Fri, Nov 12, 2010 at 03:30, Russell Morris wrote: > Hi, > > > > Yes, I am in runlevel 5. I have to admit, I did check /etc/inittab, but I'm > not sure what I'm looking for ... :-(. A bit lost here as to what you're > saying, sorry! Can you clarify a bit? i mean, do you something like be

[Qemu-devel] Re: [PATCH 4/8] pci: Replace used bitmap with capability byte map

2010-11-11 Thread Alex Williamson
On Fri, 2010-11-12 at 07:40 +0200, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2010 at 07:55:43PM -0700, Alex Williamson wrote: > > Capabilities are allocated in bytes, so we can track both whether > > a byte is used and by what capability in the same structure. > > > > Remove pci_reserve_capabili

[Qemu-devel] Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-11 Thread Alex Williamson
On Fri, 2010-11-12 at 07:22 +0200, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2010 at 07:55:01PM -0700, Alex Williamson wrote: > > Make use of wmask, just like the rest of config space. > > > > Signed-off-by: Alex Williamson > > --- > > > > hw/pci.c | 19 --- > > 1 files chan

[Qemu-devel] Re: [PATCH 4/8] pci: Replace used bitmap with capability byte map

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 07:55:43PM -0700, Alex Williamson wrote: > Capabilities are allocated in bytes, so we can track both whether > a byte is used and by what capability in the same structure. > > Remove pci_reserve_capability() as there are no users. > > Signed-off-by: Alex Williamson I act

[Qemu-devel] Re: [PATCH 0/8] PCI capability and device assignment improvements

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 07:54:49PM -0700, Alex Williamson wrote: > This series attempts to clean up capability support between common > code and device assignment. In doing so, we can move existing MSI & > MSI-X capabilities to offsets matching real hardware, and further > enable more capabilities

[Qemu-devel] Re: [RFC PATCH 8/8] device-assignment: pass through and stub more PCI caps

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 07:56:46PM -0700, Alex Williamson wrote: > Some drivers depend on finding capabilities like power management, > PCI express/X, vital product data, or vendor specific fields. Now > that we have better capability support, we can pass more of these > tables through to the gues

[Qemu-devel] Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 07:55:01PM -0700, Alex Williamson wrote: > Make use of wmask, just like the rest of config space. > > Signed-off-by: Alex Williamson > --- > > hw/pci.c | 19 --- > 1 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c >

Re: [Qemu-devel] Log Console Output to File

2010-11-11 Thread qemu
Hi, Yes, this works, as does adding in "-vnc :0" (and then connection to this via VNC) ... but in both cases I am not able to collect the console output that exists during the boot. Any thoughts on that? Thanks! On Thu, Nov 11, 2010 03:17 PM, Stefan Weil wrote: > Am 11.11.2010 21:37, schri

Re: [Qemu-devel] Log Console Output to File

2010-11-11 Thread qemu
Here you go ... qemu-system-arm -serial stdio -nographic -M versatilepb -kernel zImage-2.6.34-r4-qemuarm.bin -hda minimal-console-image-eglibc-ipk-dev-snapshot-20101110-qemuarm.rootfs.ext3 -append "root=/dev/sda" And the output ... chardev: opening backend "stdio" failed qemu: could not open s

[Qemu-devel] [PATCH 6/8] device-assignment: Move PCI capabilities to match physical hardware

2010-11-11 Thread Alex Williamson
Now that common PCI code doesn't have a hangup on capabilities being contiguous, move assigned device capabilities to match their offset on physical hardware. This helps for drivers that assume a capability configuration and don't bother searching. We can also remove several calls to assigned_dev

[Qemu-devel] [PATCH 2/8] pci: Remove pci_enable_capability_support()

2010-11-11 Thread Alex Williamson
This interface doesn't make much sense, adding a capability can take care of everything, just provide a means to register capability read/write handlers. Device assignment does it's own thing, so requires a couple ugly hacks that will be cleaned by subsequent patches. Signed-off-by: Alex Williams

[Qemu-devel] [RFC PATCH 8/8] device-assignment: pass through and stub more PCI caps

2010-11-11 Thread Alex Williamson
Some drivers depend on finding capabilities like power management, PCI express/X, vital product data, or vendor specific fields. Now that we have better capability support, we can pass more of these tables through to the guest. Note that VPD and VNDR are direct pass through capabilies, the rest a

[Qemu-devel] [PATCH 5/8] pci: Remove cap.length, cap.start, cap.supported

2010-11-11 Thread Alex Williamson
Capabilities aren't required to be contiguous, so cap.length never really made much sense. Likewise, cap.start is mostly meaningless too. Both of these are better served by the capability map. We can also get rid of cap.supported, since it's really now unused and redundant with flag in the statu

[Qemu-devel] [PATCH 3/8] device-assignment: Use PCI capabilities support

2010-11-11 Thread Alex Williamson
Convert to use common pci_add_capabilities() rather than creating our own mess. Signed-off-by: Alex Williamson --- hw/device-assignment.c | 112 +++- 1 files changed, 63 insertions(+), 49 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-

[Qemu-devel] [PATCH 7/8] pci: Pass ID for capability read/write handlers

2010-11-11 Thread Alex Williamson
Any handlers that actually want to interact with specific capabilities are going to want to know the capability ID being accessed. With the capability map, this is readily available, so we can save handlers the trouble of figuring it out. Signed-off-by: Alex Williamson --- hw/device-assignment

[Qemu-devel] [PATCH 4/8] pci: Replace used bitmap with capability byte map

2010-11-11 Thread Alex Williamson
Capabilities are allocated in bytes, so we can track both whether a byte is used and by what capability in the same structure. Remove pci_reserve_capability() as there are no users. Signed-off-by: Alex Williamson --- hw/pci.c | 16 +--- hw/pci.h |6 ++ 2 files changed, 7

[Qemu-devel] [PATCH 0/8] PCI capability and device assignment improvements

2010-11-11 Thread Alex Williamson
This series attempts to clean up capability support between common code and device assignment. In doing so, we can move existing MSI & MSI-X capabilities to offsets matching real hardware, and further enable more capabilities to be exposed. The last patch is only for RFC, I'd like some input on w

[Qemu-devel] [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-11 Thread Alex Williamson
Make use of wmask, just like the rest of config space. Signed-off-by: Alex Williamson --- hw/pci.c | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 92aaa85..12c47ac 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1175,13 +1175,14 @@

[Qemu-devel] [Bug 510612] Re: sound broken in qemu 0.12.x

2010-11-11 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Unknown => Fix Committed -- sound broken in qemu 0.12.x https://bugs.launchpad.net/bugs/510612 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Status in “qemu” package

[Qemu-devel] [Bug 510612] Re: sound broken in qemu 0.12.x

2010-11-11 Thread Michael Tokarev
More information about this. The mentioned commit fixes just the messages apparently, but not the actual problem which is elsewhere. The complete fix consists of 3 patches: the above in comment#7, and also 22d948a2d97434192018bdabaf0a50cda7f994be and 38cc9b607f85017b095793cab6c129bc9844f441 from

[Qemu-devel] SMM jmp weirdness

2010-11-11 Thread Stefan Reinauer
Hi, I'm looking at the following piece of code running under QEMU 0x38000:     66 bd 90 f8 27 3f       mov    $0x3f27f890,%ebp ; target address for jmp    0x38006:     66 2e 2b 2e f8 fe       sub    %cs:0xfef8,%ebp; subtract SMBASE    0x3800c:     66 ff e5                 jmpl   *%ebp

[Qemu-devel] [Bug 643430] Re: system_powerdown is working in qemu-kvm with KVM enabled for FreeBSD guests

2010-11-11 Thread Michael Tokarev
** Bug watch added: Debian Bug tracker #603223 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603223 ** Also affects: qemu-kvm (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603223 Importance: Unknown Status: Unknown ** Package changed: qemu-kvm (Debian) => debian

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-11-11 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Unknown => Confirmed -- KVM segmentation fault, using SCSI+writeback and linux 2.4 guest https://bugs.launchpad.net/bugs/595438 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in Ke

[Qemu-devel] [Bug 643430] Re: system_powerdown is working in qemu-kvm with KVM enabled for FreeBSD guests

2010-11-11 Thread Michael Tokarev
This is fixed upstream (in seabios actually) by commit 6d5a2172f2b76900572107868ec080400c4f615d -- see http://git.linuxtogo.org/?p=kevin/seabios.git;a=commit;h=6d5a2172f2b76900572107868ec080400c4f615d . I added this patch to Debian releases of qemu-kvm, both for squeeze and experimental. -- syst

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-11-11 Thread Michael Tokarev
** Bug watch added: Debian Bug tracker #603223 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603223 ** Also affects: qemu-kvm (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603223 Importance: Unknown Status: Unknown -- KVM segmentation fault, using SCSI+writebac

Re: [Qemu-devel] [Bug 671831] Re: Sparc guest assert error

2010-11-11 Thread Nigel Horne
Stefan, > Try: > git clone -b scsi_assert_moved git://repo.or.cz/qemu/stefanha.git > I have tried that branch. I get no assertion failure with it. Thanks, -Nigel Horne -- Sparc guest assert error https://bugs.launchpad.net/bugs/671831 You received this bug notification because you are a

Re: [Qemu-devel] Log Console Output to File

2010-11-11 Thread David S. Ahern
On 11/11/10 14:17, Stefan Weil wrote: > Am 11.11.2010 21:37, schrieb Russell Morris: >> Hi, >> >> Thanks for the pointer! I tried this, but I get an error message, as >> follows ... >> *chardev: opening backent "stdio" failed* >> *qemu: could not open serial device 'stdio': Inappropriate ioctl fo

Re: [Qemu-devel] [PATCH v2 11/15] bitmap: add a generic bitmap and bitops library

2010-11-11 Thread Corentin Chary
On Thu, Nov 11, 2010 at 8:07 PM, Blue Swirl wrote: > Please don't use identifiers starting with underscore. Ok, I think __bitmap_* could become slow__bitmap_* (because they are the slow path) > We already have ffs() in qemu-common.h and oslib-win32.c. Please use > the same method. > This is no

Re: [Qemu-devel] [Bug 671831] Re: Sparc guest assert error

2010-11-11 Thread Stefan Hajnoczi
On Thu, Nov 11, 2010 at 5:00 PM, Nigel Horne <671...@bugs.launchpad.net> wrote: > On 11/11/2010 09:17 AM, Stefan Hajnoczi wrote: >> Thanks for providing the kernel and initrd.  Unfortunately I wasn't >> able to get them far enough to trigger the assert.  More on that at >> the bottom of this messag

Re: [Qemu-devel] Log Console Output to File

2010-11-11 Thread Stefan Weil
Am 11.11.2010 21:37, schrieb Russell Morris: Hi, Thanks for the pointer! I tried this, but I get an error message, as follows ... *chardev: opening backent "stdio" failed* *qemu: could not open serial device 'stdio': Inappropriate ioctl for device.* Thoughts? Hi, I assume that you tried

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)

2010-11-11 Thread Stefan Hajnoczi
On Fri, Oct 15, 2010 at 8:54 PM, Christian Brunner wrote: > Hi, > > once again, Yehuda committed fixes for all the suggestions made on the > list (and more). Here is the next update for the ceph/rbd block driver. > > Please let us know if there are any pending issues. > > For those who didn't foll

Re: [Qemu-devel] Log Console Output to File

2010-11-11 Thread David S. Ahern
On 11/11/10 13:37, Russell Morris wrote: > Hi, > > > > Thanks for the pointer! I tried this, but I get an error message, as > follows ... > > *chardev: opening backent "stdio" failed* > > *qemu: could not open serial device 'stdio': Inappropriate ioctl for > device.* qemu command line? Da

Re: [Qemu-devel] Log Console Output to File

2010-11-11 Thread Russell Morris
Hi, Thanks for the pointer! I tried this, but I get an error message, as follows ... chardev: opening backent "stdio" failed qemu: could not open serial device 'stdio': Inappropriate ioctl for device. Thoughts? Thanks again! On Thu, Nov 11, 2010 11:22 AM, "David S. Ahern" wrote:

Re: [Qemu-devel] No Virtual Console

2010-11-11 Thread Russell Morris
Hi, Yes, I am in runlevel 5. I have to admit, I did check /etc/inittab, but I'm not sure what I'm looking for ... :-(. A bit lost here as to what you're saying, sorry! Can you clarify a bit? Yes, VNC works - I was trying to say that, just not very clearly. What I'm after though is to hav

[Qemu-devel] [PATCH 3/3] QMP/qmp-shell: Introduce HMP mode

2010-11-11 Thread Luiz Capitulino
In which qmp-shell will exclusively use the HMP passthrough feature, this is useful for testing. Example: # ./qmp-shell -H qmp-sock Welcome to the HMP shell! Connected to QEMU 0.13.50 (QEMU) info network VLAN 0 devices: user.0: net=10.0.2.0, restricted=n e1000.0

[Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-11 Thread Luiz Capitulino
This driver handles in-memory chardev operations. That's, all writes to this driver are stored in an internal buffer and it doesn't talk to the external world in any way. Right now it's very simple: it supports only writes. But it can be easily extended to support more operations. This is going t

[Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino --- monitor.c | 38 ++ qmp-comman

[Qemu-devel] [PATCH v3 0/3]: QMP: Human Monitor passthrough

2010-11-11 Thread Luiz Capitulino
Simple example: -> { "execute": "human-monitor-command", "arguments": { "command-line": "print /i 10+25" } } <- { "return": "35\r\n" } Please, check individual patches for details. Also note that this series depends on the script improvements one. Also, Markus suggestion of having an assert() i

Re: [Qemu-devel] [PATCH 4/8] ARM: Return correct result for float-to-integer conversion of NaN

2010-11-11 Thread Nathan Froyd
On Thu, Nov 11, 2010 at 06:23:58PM +, Peter Maydell wrote: > The ARM architecture mandates that converting a NaN value to > integer gives zero. This isn't the behaviour of the SoftFloat > library, so NaNs must be special-cased. This is correct, but it's really only correct if FP traps are disa

Re: [Qemu-devel] [PATCH v2 11/15] bitmap: add a generic bitmap and bitops library

2010-11-11 Thread Blue Swirl
On Thu, Nov 11, 2010 at 4:57 PM, Corentin Chary wrote: > Add most used bitmap and bitops functions into bitmap.c and bitops.c. > Theses functions are mostly copied from Linux kernel source. > > Some of these functions are already redefined in the VNC server. Some > of them could be used for some b

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 11 Nov 2010 16:47:41 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Wed, 10 Nov 2010 14:20:12 +0100 >> > Markus Armbruster wrote: >> > >> >> Luiz Capitulino writes: >> [...] >> >> > diff --git a/qmp-commands.hx b/qmp-commands.hx >>

Re: [Qemu-devel] [PATCH v2 03/15] vnc: refresh lossy rect after a given timeout

2010-11-11 Thread Blue Swirl
On Thu, Nov 11, 2010 at 4:56 PM, Corentin Chary wrote: > If an adaptive encoding has choosen to send a lossy update > based on the result of vnc_update_freq(), then it should advertise > it with vnc_sent_lossy_rect(). This will allow to automatically refresh > this rect once it's static again. > >

Re: [Qemu-devel] [PATCH 0/2] msi support for virtfs

2010-11-11 Thread Gerd Hoffmann
On 11/11/10 16:37, Aneesh Kumar K. V wrote: On Thu, 11 Nov 2010 12:59:24 +0100, Gerd Hoffmann wrote: Hi, This tiny patch series adds msi support for virtfs. It's two patches only because we need a compat property to stay compatible with -stable and we don't have a pc-0.14 machine type yet,

Re: [Qemu-devel] [Bug 671831] Re: Sparc guest assert error

2010-11-11 Thread Nigel Horne
On 11/11/2010 09:17 AM, Stefan Hajnoczi wrote: > Thanks for providing the kernel and initrd. Unfortunately I wasn't > able to get them far enough to trigger the assert. More on that at > the bottom of this message but in the meantime I looked over the > relevant commits and spotted an issue with

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 17:32:06 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 11 Nov 2010 16:30:26 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > This driver handles in-memory chardev operations. That's, all writes > >> > to this driver

[Qemu-devel] Re: [PATCHv3 00/14] boot order specification

2010-11-11 Thread Blue Swirl
On Thu, Nov 11, 2010 at 10:21 AM, Gerd Hoffmann wrote: > On 11/10/10 18:14, Gleb Natapov wrote: >> >> This is current sate of the patch series for people to comment on. >> I am using open firmware naming scheme to specify device path names. >> >> Names look like this on pci machine: >> /p...@i0cf8

[Qemu-devel] Re: [PATCH v2 0/3] virtio: Use ioeventfd for virtqueue notify

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 01:47:19PM +, Stefan Hajnoczi wrote: > This is a rewrite of the virtio-ioeventfd patchset to work at the virtio-pci.c > level instead of virtio.c. This results in better integration with the > host/guest notifier code and makes the code simpler (no more state machine).

[Qemu-devel] [PATCH 3/8] ARM: Fix sense of to_integer bit in Neon VCVT float/int conversion

2010-11-11 Thread Peter Maydell
Signed-off-by: Peter Maydell --- target-arm/translate.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 696abf6..afb3872 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -5664,16 +5664,16 @@ s

[Qemu-devel] [PATCH 2/8] ARM: Fix decoding of Neon forms of VCVT between float and fixed point

2010-11-11 Thread Peter Maydell
Fix errors in the decoding of the Neon forms of fixed-point VCVT: * fixed-point VCVT is op 14 and 15, not 15 and 16 * the fbits immediate field was being misinterpreted * the sense of the to_fixed bit was inverted Signed-off-by: Peter Maydell --- target-arm/translate.c |8 ++-- 1 file

[Qemu-devel] [PATCH 5/8] ARM: Return correct result for single<->double conversion of NaN

2010-11-11 Thread Peter Maydell
The ARM ARM defines that if the input to a single<->double conversion is a NaN then the output is always forced to be a quiet NaN by setting the most significant bit of the fraction part. Signed-off-by: Peter Maydell --- target-arm/helper.c | 20 ++-- 1 files changed, 18 insert

[Qemu-devel] [PATCH 8/8] ARM: Implement VCVT to 16 bit integer using new softfloat routines

2010-11-11 Thread Peter Maydell
Use the softfloat conversion routines for conversion to 16 bit integers, because just casting to a 16 bit type truncates the value rather than saturating it at 16-bit MAXINT/MININT. Signed-off-by: Peter Maydell --- target-arm/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 6/8] ARM: Ignore top 16 bits when doing VCVT from 16 bit fixed point

2010-11-11 Thread Peter Maydell
VCVT of 16 bit fixed point to float should ignore the top 16 bits of the source register. Cast to int16_t and friends rather than int16 -- the former is guaranteed exactly 16 bits wide where the latter is merely at least 16 bits wide (and so is usually 32 bits). Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 0/8] ARM: fix VCVT instructions

2010-11-11 Thread Peter Maydell
This patch series corrects a number of errors in the decoding and implementation of various forms of the ARM VCVT instruction. The resulting qemu has been tested by execution of 100,000 random variants of these instruction patterns with register values cross-checked against the results given by Cor

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 06:07:53PM +0200, Gleb Natapov wrote: > On Thu, Nov 11, 2010 at 05:05:11PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > > > On 11/10/10 18:34, Michael S. Tsirkin wrote: > > > >On Wed, Nov 10, 2010 at 07:14:15PM +0200,

[Qemu-devel] [PATCH 4/8] ARM: Return correct result for float-to-integer conversion of NaN

2010-11-11 Thread Peter Maydell
The ARM architecture mandates that converting a NaN value to integer gives zero. This isn't the behaviour of the SoftFloat library, so NaNs must be special-cased. Signed-off-by: Peter Maydell --- target-arm/helper.c | 44 1 files changed, 44 inserti

[Qemu-devel] [PATCH 7/8] softfloat: Add float/double to 16 bit integer conversion functions

2010-11-11 Thread Peter Maydell
The ARM architecture needs float/double to 16 bit integer conversions. (The 32 bit versions aren't sufficient because of the requirement to saturate at 16 bit MAXINT/MININT and to get the exception bits right.) Signed-off-by: Peter Maydell --- fpu/softfloat.c | 136 +

[Qemu-devel] [PATCH 1/8] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed

2010-11-11 Thread Peter Maydell
Correct the decoding of source and destination registers for the VFP forms of the VCVT instructions which convert between floating point and integer or fixed-point. Signed-off-by: Peter Maydell --- target-arm/translate.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(

[Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 06:59:29PM +0200, Avi Kivity wrote: > On 11/11/2010 03:47 PM, Stefan Hajnoczi wrote: > >Some virtio devices are known to have guest drivers which expect a notify to > >be > >processed synchronously and spin waiting for completion. Only enable > >ioeventfd > >for virtio-bl

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 16:47:52 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > This command allows QMP clients to execute HMP commands. > > > > Please, check the documentation added to the qmp-commands.hx file > > for additional details about the interface and its limitations. > >

[Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-11 Thread Gleb Natapov
On Thu, Nov 11, 2010 at 07:12:40PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2010 at 06:59:29PM +0200, Avi Kivity wrote: > > On 11/11/2010 03:47 PM, Stefan Hajnoczi wrote: > > >Some virtio devices are known to have guest drivers which expect a notify > > >to be > > >processed synchronousl

[Qemu-devel] [PATCH v2 11/15] bitmap: add a generic bitmap and bitops library

2010-11-11 Thread Corentin Chary
Add most used bitmap and bitops functions into bitmap.c and bitops.c. Theses functions are mostly copied from Linux kernel source. Some of these functions are already redefined in the VNC server. Some of them could be used for some block stuff. The yet yo be submitted NUMA work also need bitmaps.

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-11 Thread Alon Levy
On Thu, Nov 11, 2010 at 04:03:14PM +0100, Markus Armbruster wrote: [snip] > Agree. > > Summary so far: > > 1. usb_{attach,detach} looks like yet another special-purpose command >where a general command would make sense, namely >device_{attach,detach}. We have a few of those, e.g. usb_add

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Anthony Liguori
On 11/11/2010 10:39 AM, Daniel P. Berrange wrote: IIUC, the FDs sent/received via struct cmsghdr are in a strictly ordered array, so why not just define a placeholder syntax for the commands that maps to the array indexes. eg netdev_add tap,fd=$0,vhost_fd=$1,id=hostnet0 The '$' sign is not v

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Anthony Liguori
On 11/11/2010 10:55 AM, Luiz Capitulino wrote: On Thu, 11 Nov 2010 16:47:41 +0100 Markus Armbruster wrote: Luiz Capitulino writes: On Wed, 10 Nov 2010 14:20:12 +0100 Markus Armbruster wrote: Luiz Capitulino writes: [...] diff --git a/qmp-commands.hx b

[Qemu-devel] [PATCH v2 09/15] vnc: fix uint8_t comparisons with negative values

2010-11-11 Thread Corentin Chary
Signed-off-by: Corentin Chary --- ui/vnc-enc-tight.c |4 ++-- ui/vnc-enc-zrle.c |3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index ad9a9a8..81024d5 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -1546,7 +1546,

[Qemu-devel] [PATCH v2 15/15] vnc: add a non-adaptive option

2010-11-11 Thread Corentin Chary
This option allow to disable adaptive behaviors in some encodings. Signed-off-by: Corentin Chary --- qemu-options.hx|9 + ui/vnc-enc-tight.c |2 +- ui/vnc.c | 13 + ui/vnc.h |1 + 4 files changed, 20 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [PATCH v2 06/15] vnc: palette: add palette_init calls

2010-11-11 Thread Corentin Chary
This allow to use palette on the stack instead of always allocating them. Signed-off-by: Corentin Chary --- ui/vnc-palette.c |8 +++- ui/vnc-palette.h |1 + 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c index c47420b..f93250b 10064

Re: [Qemu-devel] No Virtual Console

2010-11-11 Thread Mulyadi Santosa
On Thu, Nov 11, 2010 at 12:49, wrote: > Hi, My apologies up front for the dumb question, but ... I am running qemu > (actually, qemu-system-arm), and when I launch it I do not get a new virtual > console to open. I have had this in the past (older Linux install), but > inside OpenSuSE 11.3, with

Re: [Qemu-devel] Log Console Output to File

2010-11-11 Thread David S. Ahern
On 11/11/10 09:57, Mulyadi Santosa wrote: > On Thu, Nov 11, 2010 at 12:50, wrote: >> Hi, >> >> Is there a way to log / copy the console output (like the Linux boot info, >> if booting QEMU to Linux) to a file? > > I think you could consider booting Linux in serial console...then > start Qemu

[Qemu-devel] Re: [PATCH v2 00/15] vnc: adapative tight, zrle, zywrle, and bitmap module

2010-11-11 Thread Alexander Graf
Corentin Chary wrote: > Hi, > > I rebased the series against current master, it contains: > > - Adaptive Tight Encoding: send lossy or lossless updates depending on the > update frequency of the screen region. If a lossy update is forced, then > it will be refreshed with a lossless update as soo

[Qemu-devel] [PATCH v2 13/15] vnc: don't try to send bigger updates that client height

2010-11-11 Thread Corentin Chary
Respect client size if it doesn't not support desktop resizing. Signed-off-by: Corentin Chary --- ui/vnc.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 600ea75..9189014 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -795,12 +795,11 @@ stati

[Qemu-devel] [PATCH v2 04/15] vnc: tight: use the update frequency to choose between lossy and lossless

2010-11-11 Thread Corentin Chary
Use the new update frequency infrastructure to use jpeg for regions with high update frequency. Signed-off-by: Corentin Chary --- ui/vnc-enc-tight.c | 75 +++- 1 files changed, 62 insertions(+), 13 deletions(-) diff --git a/ui/vnc-enc-tight.c b/

[Qemu-devel] [PATCH v2 02/15] vnc: add a way to get the update frequency for a given region

2010-11-11 Thread Corentin Chary
This patch compute the update frequency (in Hz) for each 64x64 rects. Any adaptive encoding can get this value using vnc_update_freq(), and switch to a lossy encoding if the value is too high. The frequency is pre-calculated every 500ms, based on the last 10 updates per 64x64 rect. If a 64x64 rec

[Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-11 Thread Avi Kivity
On 11/11/2010 03:47 PM, Stefan Hajnoczi wrote: Some virtio devices are known to have guest drivers which expect a notify to be processed synchronously and spin waiting for completion. Only enable ioeventfd for virtio-blk and virtio-net for now. Which drivers are these? I only know of the virt

Re: [Qemu-devel] Log Console Output to File

2010-11-11 Thread Mulyadi Santosa
On Thu, Nov 11, 2010 at 12:50, wrote: > Hi, > > Is there a way to log / copy the console output (like the Linux boot info, if > booting QEMU to Linux) to a file? I think you could consider booting Linux in serial console...then start Qemu with -nographic. From there, everything will be spilled

[Qemu-devel] [PATCH v2 14/15] vnc: tight: tweak adaptive tight settings

2010-11-11 Thread Corentin Chary
The force_jpeg threshold was too low. Signed-off-by: Corentin Chary --- ui/vnc-enc-tight.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 81024d5..82c1e96 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc

[Qemu-devel] [PATCH v2 05/15] vnc: palette: use a pool to reduce memory allocations

2010-11-11 Thread Corentin Chary
We now that the palette will never have more than 256 elements. Let's use a pool to reduce malloc calls. Signed-off-by: Corentin Chary --- ui/vnc-palette.c | 18 ++ ui/vnc-palette.h |3 ++- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/ui/vnc-palette.c b/u

[Qemu-devel] [PATCH v2 12/15] vnc: use the new generic bitmap functions

2010-11-11 Thread Corentin Chary
Switch to bitmap.h and bitops.h instead of redefining our own bitmap helpers. Signed-off-by: Corentin Chary --- ui/vnc.c | 91 ++--- ui/vnc.h |7 +++-- 2 files changed, 25 insertions(+), 73 deletions(-) diff --git a/ui/vnc.c b/ui/vnc

[Qemu-devel] [PATCH v2 03/15] vnc: refresh lossy rect after a given timeout

2010-11-11 Thread Corentin Chary
If an adaptive encoding has choosen to send a lossy update based on the result of vnc_update_freq(), then it should advertise it with vnc_sent_lossy_rect(). This will allow to automatically refresh this rect once it's static again. Signed-off-by: Corentin Chary --- ui/vnc-jobs-async.c |2 +

[Qemu-devel] [PATCH v2 01/15] vnc: don't set the quality if lossy encoding are disabled

2010-11-11 Thread Corentin Chary
This should not change the current behavior, but if any new encoding try to use the tight quality, it will always be set to -1 when lossy encodings are disabled. Signed-off-by: Corentin Chary --- ui/vnc.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/v

[Qemu-devel] [PATCH v2 10/15] vnc: fix lossy rect refreshing

2010-11-11 Thread Corentin Chary
The for loop in send_lossy_rect was totally wrong, and we can't call vnc_set_bits() because it does not really do what it should. Use vnc_set_bit() directly instead. Signed-off-by: Corentin Chary --- ui/vnc.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ui/

[Qemu-devel] [PATCH v2 07/15] vnc: palette: and fill and color calls.

2010-11-11 Thread Corentin Chary
These two helpers are needed for zrle and zywrle. Signed-off-by: Corentin Chary --- ui/vnc-palette.c | 33 + ui/vnc-palette.h |3 +++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c index f93250b..d691a0c 1

[Qemu-devel] [PATCH v2 00/15] vnc: adapative tight, zrle, zywrle, and bitmap module

2010-11-11 Thread Corentin Chary
Hi, I rebased the series against current master, it contains: - Adaptive Tight Encoding: send lossy or lossless updates depending on the update frequency of the screen region. If a lossy update is forced, then it will be refreshed with a lossless update as soon as the update frequency goes ba

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 16:47:41 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 10 Nov 2010 14:20:12 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > [...] > >> > diff --git a/qmp-commands.hx b/qmp-commands.hx > >> > index 793cf1c..b344096 100644 > >>

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 16:39:52 + "Daniel P. Berrange" wrote: > On Thu, Nov 11, 2010 at 10:30:47AM -0600, Anthony Liguori wrote: > > On 11/11/2010 09:55 AM, Daniel P. Berrange wrote: > > >On Thu, Nov 11, 2010 at 04:47:41PM +0100, Markus Armbruster wrote: > > > 3. Query Commands > > > =

[Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-11 Thread Christoph Hellwig
On Thu, Nov 11, 2010 at 01:47:21PM +, Stefan Hajnoczi wrote: > Some virtio devices are known to have guest drivers which expect a notify to > be > processed synchronously and spin waiting for completion. Only enable > ioeventfd > for virtio-blk and virtio-net for now. Who guarantees that le

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Daniel P. Berrange
On Thu, Nov 11, 2010 at 10:30:47AM -0600, Anthony Liguori wrote: > On 11/11/2010 09:55 AM, Daniel P. Berrange wrote: > >On Thu, Nov 11, 2010 at 04:47:41PM +0100, Markus Armbruster wrote: > > 3. Query Commands > > = > > > In the real human monitor, cpu-in

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-11 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 11 Nov 2010 16:30:26 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > This driver handles in-memory chardev operations. That's, all writes >> > to this driver are stored in an internal buffer and it doesn't talk >> > to the external world

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Anthony Liguori
On 11/11/2010 09:55 AM, Daniel P. Berrange wrote: On Thu, Nov 11, 2010 at 04:47:41PM +0100, Markus Armbruster wrote: Luiz Capitulino writes: On Wed, 10 Nov 2010 14:20:12 +0100 Markus Armbruster wrote: Luiz Capitulino writes: [...] diff --git a/qmp-comma

Re: [Qemu-devel] [PATCH v1 0/3]: QMP: Human Monitor passthrough

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 18:22:13 +0200 Avi Kivity wrote: > On 10/29/2010 04:28 PM, Luiz Capitulino wrote: > > Simple example: > > > > -> { "execute": "hmp_passthrough", "arguments": { "command-line": "print > > /i 10+25" } } > > <- { "return": "35\r\n" } > > > > Why are the names so cryptic? > >

Re: [Qemu-devel] [PATCH v1 0/3]: QMP: Human Monitor passthrough

2010-11-11 Thread Avi Kivity
On 10/29/2010 04:28 PM, Luiz Capitulino wrote: Simple example: -> { "execute": "hmp_passthrough", "arguments": { "command-line": "print /i 10+25" } } <- { "return": "35\r\n" } Why are the names so cryptic? -> { "execute": "human-monitor-command", ... } <- { "return": "42\r\n" } -- error c

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-11 Thread Gleb Natapov
On Thu, Nov 11, 2010 at 05:05:11PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > > On 11/10/10 18:34, Michael S. Tsirkin wrote: > > >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > >> > > >>Signed-off-by: Gleb Natapov > > > > >

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Daniel P. Berrange
On Thu, Nov 11, 2010 at 04:47:41PM +0100, Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 10 Nov 2010 14:20:12 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > [...] > >> > diff --git a/qmp-commands.hx b/qmp-commands.hx > >> > index 793cf1c..b344096 100644

[Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 01:47:21PM +, Stefan Hajnoczi wrote: > Virtqueue notify is currently handled synchronously in userspace virtio. This > prevents the vcpu from executing guest code while hardware emulation code > handles the notify. > > On systems that support KVM, the ioeventfd mechani

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Markus Armbruster
Luiz Capitulino writes: > This command allows QMP clients to execute HMP commands. > > Please, check the documentation added to the qmp-commands.hx file > for additional details about the interface and its limitations. > > Signed-off-by: Luiz Capitulino > --- > monitor.c | 39 ++

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 16:30:26 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > This driver handles in-memory chardev operations. That's, all writes > > to this driver are stored in an internal buffer and it doesn't talk > > to the external world in any way. > > > > Right now it's v

  1   2   >