[Qemu-devel] [Bug 568445] Re: LVM backed drives should default to cache='none'

2010-08-13 Thread Jamin W. Collins
Can't seem to find anything in the upstream changelogs or source to indicate that such a change was made. -- LVM backed drives should default to cache='none' https://bugs.launchpad.net/bugs/568445 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Qemu-devel] [Bug 568445] Re: LVM backed drives should default to cache='none'

2010-08-13 Thread Anthony Liguori
cache=writethrough and cache=none have equivalent data integrity. FWIW, I believe most recent versions of virt-manager default to cache=none for physical devices. -- LVM backed drives should default to cache='none' https://bugs.launchpad.net/bugs/568445 You received this bug notification because

[Qemu-devel] [Bug 568445] Re: LVM backed drives should default to cache='none'

2010-08-13 Thread Jamin W. Collins
@Anthony, I'm aware that I can manipulate the cache settings via libvirt's XML. That's currently what I've been doing, manually after every VM creation. However, my point is that qemu clearly recommends that caching not be used with disks stored on raw volumes. Additionally, virt-manager does not

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-13 Thread malc
On Fri, 13 Aug 2010, Blue Swirl wrote: > On Fri, Aug 13, 2010 at 9:01 PM, malc wrote: > > On Fri, 13 Aug 2010, Blue Swirl wrote: > > > >> On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: > >> > Add memory management rules, somewhat like libvirt HACKING. > >> > > >> > Signed-off-by: Blue Swirl

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-13 Thread Blue Swirl
On Fri, Aug 13, 2010 at 9:01 PM, malc wrote: > On Fri, 13 Aug 2010, Blue Swirl wrote: > >> On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: >> > Add memory management rules, somewhat like libvirt HACKING. >> > >> > Signed-off-by: Blue Swirl >> > --- >> >  CODING_STYLE |    8 >> >  1 f

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-13 Thread malc
On Fri, 13 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: > > Add memory management rules, somewhat like libvirt HACKING. > > > > Signed-off-by: Blue Swirl > > --- > >  CODING_STYLE |    8 > >  1 files changed, 8 insertions(+), 0 deletions(-) > > > > di

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-13 Thread malc
On Fri, 13 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 6:56 PM, malc wrote: > > On Thu, 12 Aug 2010, Blue Swirl wrote: > > > >> Add a few rules, based loosely on libvirt HACKING. > >> > >> Blue Swirl (5): > >>   CODING_STYLE: add preprocessor rules > >>   CODING_STYLE: add C type rules

[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-13 Thread Anthony Liguori
On 08/13/2010 02:37 PM, Stefano Stabellini wrote: On Fri, 13 Aug 2010, Anthony Liguori wrote: On 08/12/2010 09:10 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Xen currently uses a different BIOS (hvmloader + rombios) therefore the Qemu acpi_piix4 implementation wo

[Qemu-devel] Re: [PATCH 00/15] RFC xen device model support

2010-08-13 Thread Anthony Liguori
On 08/13/2010 02:35 PM, Stefano Stabellini wrote: We should limit XenStore interactions to strictly be device model setup. Any management operations should be done through QMP. The main reason to take this approach is to ensure that we don't end up with a more powerful interface via xenstore ve

[Qemu-devel] Re: sparc scsi/iommu/dma (was NMI handling)

2010-08-13 Thread Blue Swirl
On Fri, Aug 13, 2010 at 8:25 PM, Artyom Tarasenko wrote: > 2010/7/30 Blue Swirl : >> On Tue, Jul 27, 2010 at 8:10 PM, Artyom Tarasenko >> wrote: >>> 2010/7/27 Blue Swirl : On Mon, Jul 26, 2010 at 10:23 PM, Artyom Tarasenko wrote: > 2010/7/26 Blue Swirl : >> On Mon, Jul 26, 2010

[Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization

2010-08-13 Thread Artyom Tarasenko
2010/8/6 Artyom Tarasenko : > 2010/8/2 Artyom Tarasenko : >> Btw, it would be nice to get this patch applied for 0.13: it's a pure >> fix, and it allows running the OBP v2.10 for LX and some older OBP >> versions for SS-20 too. > > ping? Objections? > No feedback? Are 0.13 patches only accepted wi

[Qemu-devel] Re: sparc scsi/iommu/dma (was NMI handling)

2010-08-13 Thread Artyom Tarasenko
2010/7/30 Blue Swirl : > On Tue, Jul 27, 2010 at 8:10 PM, Artyom Tarasenko > wrote: >> 2010/7/27 Blue Swirl : >>> On Mon, Jul 26, 2010 at 10:23 PM, Artyom Tarasenko >>> wrote: 2010/7/26 Blue Swirl : > On Mon, Jul 26, 2010 at 4:53 PM, Artyom Tarasenko > wrote: >> 2010/6/21 Artyom

[Qemu-devel] Re: [PATCH 00/15] RFC xen device model support

2010-08-13 Thread Anthony Liguori
Hi Stefano/Anthony, On 08/12/2010 09:08 AM, Stefano Stabellini wrote: Hi all, this is the long awaited patch series to add xen device model support in qemu; the main author is Anthony Perard. Thanks for sending this out. Overall, the series looks pretty good. I think there's just a coup

[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-13 Thread Stefano Stabellini
On Fri, 13 Aug 2010, Anthony Liguori wrote: > On 08/12/2010 09:10 AM, stefano.stabell...@eu.citrix.com wrote: > > From: Anthony PERARD > > > > Xen currently uses a different BIOS (hvmloader + rombios) therefore the > > Qemu acpi_piix4 implementation wouldn't work correctly with Xen. > > We plan on

[Qemu-devel] Re: [PATCH 5/5] CODING_STYLE: add rules for printf-like functions

2010-08-13 Thread Blue Swirl
On Thu, Aug 12, 2010 at 5:51 PM, Blue Swirl wrote: > Add rules for printf-like functions, based on libvirt HACKING. > > Signed-off-by: Blue Swirl > --- >  CODING_STYLE |   10 ++ >  1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index b230a

[Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules

2010-08-13 Thread Blue Swirl
On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: > Add C type rules from libvirt HACKING. Also include > a description of special QEMU scalar types. > > Signed-off-by: Blue Swirl > --- >  CODING_STYLE |   56 >  1 files changed, 56 inserti

[Qemu-devel] Re: [PATCH 00/15] RFC xen device model support

2010-08-13 Thread Stefano Stabellini
On Fri, 13 Aug 2010, Anthony Liguori wrote: > Hi Stefano/Anthony, > > On 08/12/2010 09:08 AM, Stefano Stabellini wrote: > > Hi all, > > this is the long awaited patch series to add xen device model support in > > qemu; the main author is Anthony Perard. > > > > Thanks for sending this out. O

[Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-13 Thread Blue Swirl
On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: > Add memory management rules, somewhat like libvirt HACKING. > > Signed-off-by: Blue Swirl > --- >  CODING_STYLE |    8 >  1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index 3f10d72..08

[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-13 Thread Anthony Liguori
On 08/12/2010 09:10 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Xen currently uses a different BIOS (hvmloader + rombios) therefore the Qemu acpi_piix4 implementation wouldn't work correctly with Xen. We plan on fixing this properly but at the moment we are just adding a new

[Qemu-devel] Re: [PATCH 14/15] xen: destroy the VM when shutdown is requested

2010-08-13 Thread Anthony Liguori
On 08/12/2010 09:10 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Handle shutdown and reset requests in helper.c. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- target-xen/helper.c | 17 + 1 files changed, 17 insertions(+), 0 deletion

[Qemu-devel] [Bug 617528] Re: Incorrect translation of unary PPC/SPE instructions (efdneg etc.)

2010-08-13 Thread Mike Pall
Oops, just noticed that the double-precision ops ought to copy the unmodified lower part of the GPR, too. Updated patch attached. Obviously this changes the sin(-1.0) result after the patch, too: $ qemu-ppc -cpu e500v2 sintest -1.0 -0.8414709848079 ** Patch added: "Updated fix for unary SPE ops

Re: [Qemu-devel] [PATCH 00/14] trace: Add static tracing to QEMU

2010-08-13 Thread Lluís
Stefan Hajnoczi writes: > 1. Writing the trace buffer is currently synchronous - fwrite(3) is > used by the unlucky caller that fills up the trace buffer. Ideally > traces should never block and write-out would be asynchronous. With a > regular file I'm not sure how much of an issue this is to p

[Qemu-devel] Re: [PATCH 09/15] xen: Initialize event channels and io rings

2010-08-13 Thread Anthony Liguori
On 08/12/2010 09:09 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Open and bind event channels; map ioreq and buffered ioreq rings. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen_machine_fv.c | 25 target-xen/cpu.h |1 + targe

[Qemu-devel] Re: [PATCH 10/15] xen: Introduce the Xen mapcache

2010-08-13 Thread Anthony Liguori
On 08/12/2010 09:09 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Introduce a mapcache to handle the 64bit address space of the guest from a 32bit userland process (Qemu). The mapcache maps chucks of guest memory on demand, unmaps them when they are not needed anymore. Signed

[Qemu-devel] Re: [PATCH 08/15] xen: Read and write the state of the VM in xenstore

2010-08-13 Thread Anthony Liguori
On 08/12/2010 09:09 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Introduce functions to read and write the state of the VM in xenstore. This basically creates a new management interface for QEMU via the xenstore. Our management interface is QMP. If you want to maintai

[Qemu-devel] Re: [PATCH 03/15] xen: Add a new target to qemu: target-xen

2010-08-13 Thread Anthony Liguori
On 08/12/2010 09:09 AM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD This patch adds a new Xen device model target to Qemu, called target-xen. A xen specific target is definitely the wrong approach. I understand the desire to avoid the TCG code. We would like to (optiona

[Qemu-devel] [Bug 617528] Re: Incorrect translation of unary PPC/SPE instructions (efdneg etc.)

2010-08-13 Thread Mike Pall
** Patch added: "Fix for unary SPE ops vs. 6cbf4c8c" https://bugs.launchpad.net/bugs/617528/+attachment/1488575/+files/qemu.diff -- Incorrect translation of unary PPC/SPE instructions (efdneg etc.) https://bugs.launchpad.net/bugs/617528 You received this bug notification because you are a mem

[Qemu-devel] [Bug 617528] [NEW] Incorrect translation of unary PPC/SPE instructions (efdneg etc.)

2010-08-13 Thread Mike Pall
Public bug reported: The translation for the following PPC/SPE (e500) instructions is wrong in QEMU git 6cbf4c8c: evfsabs, evfsnabs, evfsneg efdabs, efdnabs, efdneg efsabs, efsnabs, efsneg As you can see from the provided patch, these ought to write their result to the destination re

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-13 Thread Blue Swirl
On Thu, Aug 12, 2010 at 6:56 PM, malc wrote: > On Thu, 12 Aug 2010, Blue Swirl wrote: > >> Add a few rules, based loosely on libvirt HACKING. >> >> Blue Swirl (5): >>   CODING_STYLE: add preprocessor rules >>   CODING_STYLE: add C type rules >>   CODING_STYLE: add memory management rules >>   CODI

Re: [Qemu-devel] [PATCH 03/15] xen: Add a new target to qemu: target-xen

2010-08-13 Thread Blue Swirl
On Fri, Aug 13, 2010 at 1:10 PM, Stefano Stabellini wrote: > On Thu, 12 Aug 2010, Blue Swirl wrote: >> On Thu, Aug 12, 2010 at 2:09 PM,   wrote: >> > From: Anthony PERARD >> > >> > This patch adds a new Xen device model target to Qemu, called >> > target-xen. >> >> I don't understand why it would

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-13 Thread Blue Swirl
On Fri, Aug 13, 2010 at 3:22 PM, Miguel Di Ciurcio Filho wrote: > On Thu, Aug 12, 2010 at 3:56 PM, malc wrote: >> >> While intentions of this are good, i believe this goes too far, i doubt >> that the proposed additions are enforcable and have no doubts that they >> will be widely ignored and at

Re: [Xen-devel] Re: [Qemu-devel] [PATCH 03/15] xen: Add a new target to qemu: target-xen

2010-08-13 Thread Blue Swirl
On Fri, Aug 13, 2010 at 12:47 PM, Ian Jackson wrote: > Blue Swirl writes ("[Xen-devel] Re: [Qemu-devel] [PATCH 03/15] xen: Add a new > target to qemu: target-xen"): >> I don't understand why it would be a target, QEMU calls CPU >> architectures targets. Isn't it possible to have Xen for Sparc, PP

Re: [Qemu-devel] [PATCH 1/5] CODING_STYLE: add preprocessor rules

2010-08-13 Thread Blue Swirl
On Thu, Aug 12, 2010 at 6:47 PM, malc wrote: > On Thu, 12 Aug 2010, Blue Swirl wrote: > >> Add preprocessor rules from libvirt HACKING. >> >> Signed-off-by: Blue Swirl >> --- >>  CODING_STYLE |   13 + >>  1 files changed, 13 insertions(+), 0 deletions(-) >> >> diff --git a/CODING_STYL

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-13 Thread Miguel Di Ciurcio Filho
On Thu, Aug 12, 2010 at 3:56 PM, malc wrote: > > While intentions of this are good, i believe this goes too far, i doubt > that the proposed additions are enforcable and have no doubts that they > will be widely ignored and at the same time provide more grounds for > whining. Furthermore the exist

Re: [Qemu-devel] [PATCH 00/14] trace: Add static tracing to QEMU

2010-08-13 Thread Stefan Hajnoczi
On Thu, Aug 12, 2010 at 7:10 PM, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 10:36 AM, Stefan Hajnoczi > wrote: >> This patch series adds static tracing to QEMU.  It can be used to instrument >> QEMU code by means of lightweight logging called trace events. >> >> Prerna and I are now posting the

[Qemu-devel] [PATCH] vhost: Fix size of dirty log sync on resize

2010-08-13 Thread Alex Williamson
When the vhost log is resized, we want to sync up to the size of the old log. With that end address in place, ignore regions that start after then end rather than hitting assert. Signed-off-by: Alex Williamson --- hw/vhost.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) dif

Re: [Qemu-devel] Samsung S3C24xx SoC support

2010-08-13 Thread Stefan Weil
Am 23.03.2009 19:05, schrieb Vincent Sanders: We have updated the patches for basic Samsung S3c2410 support to the latest release. The patch also contain support for the Simtec bast board as an example use of the core support. This patch can be found on our website http://www.simtec.co.uk/produ

Re: [Qemu-devel] [PATCH 08/14] trace: Support for dynamically enabling/disabling trace events.

2010-08-13 Thread Stefan Hajnoczi
On Thu, Aug 12, 2010 at 7:02 PM, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 10:36 AM, Stefan Hajnoczi > wrote: >> From: Prerna Saxena >> +#if defined(CONFIG_SIMPLE_TRACE) >> +static void do_info_trace(Monitor *mon) >> +{ >> +    st_print_trace((FILE *)mon, &monitor_fprintf); > > The cast is ugl

Re: [Qemu-devel] [PATCH 03/15] xen: Add a new target to qemu: target-xen

2010-08-13 Thread Stefano Stabellini
On Thu, 12 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 2:09 PM, wrote: > > From: Anthony PERARD > > > > This patch adds a new Xen device model target to Qemu, called > > target-xen. > > I don't understand why it would be a target, QEMU calls CPU > architectures targets. Isn't it possi

Re: [Qemu-devel] [PATCH 11/15] piix3: introduce register_set_irq and register_map_irq

2010-08-13 Thread Stefano Stabellini
On Thu, 12 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 2:09 PM, wrote: > > From: Anthony PERARD > > > > This patch introduces a generic function registration mechanism for > > set_irq and map_irq in piix3, so that the two calls can be > > overridden with platform specific functions whe

Re: [Qemu-devel] [PATCH 09/15] xen: Initialize event channels and io rings

2010-08-13 Thread Stefano Stabellini
On Thu, 12 Aug 2010, Blue Swirl wrote: > > +static inline void read_physical(uint64_t addr, unsigned long size, void > > *val) > > +{ > > +return cpu_physical_memory_rw((target_phys_addr_t)addr, val, size, 0); > > +} > > + > > +static inline void write_physical(uint64_t addr, unsigned long siz

Re: [Qemu-devel] [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

2010-08-13 Thread Stefano Stabellini
On Thu, 12 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 2:10 PM, wrote: > > From: Anthony PERARD > > > > Xen currently uses a different BIOS (hvmloader + rombios) therefore the > > Qemu acpi_piix4 implementation wouldn't work correctly with Xen. > > We plan on fixing this properly but a

Re: [Qemu-devel] [PATCH 12/15] piix_pci: introduce a write_config notifier

2010-08-13 Thread Stefano Stabellini
On Thu, 12 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 2:09 PM, wrote: > > From: Anthony PERARD > > > > Introduce a write config notifier in piix_pci, so that clients can be > > notified every time a pci config write happens. > > The patch also makes use of the notification mechanism i

Re: [Qemu-devel] [PATCH 06/15] xen: Add the Xen platform pci device

2010-08-13 Thread Stefano Stabellini
Thanks for the very detailed review, all the comments make perfect sense, we'll address them in the next version of the series. On Thu, 12 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 2:09 PM, wrote: > > From: Anthony PERARD > > > > Introduce a new emulated PCI device, specific to full

[Xen-devel] Re: [Qemu-devel] [PATCH 03/15] xen: Add a new target to qemu: target-xen

2010-08-13 Thread Ian Jackson
Blue Swirl writes ("[Xen-devel] Re: [Qemu-devel] [PATCH 03/15] xen: Add a new target to qemu: target-xen"): > I don't understand why it would be a target, QEMU calls CPU > architectures targets. Isn't it possible to have Xen for Sparc, PPC or > ARM? It should really be just a machine, not copy&pas