[Qemu-devel] Re: [PATCH] QEMUFileBuffered: indicate that we're ready when the underlying file is ready

2010-08-02 Thread Avi Kivity
On 07/07/2010 07:44 PM, Avi Kivity wrote: QEMUFileBuffered stops writing when the underlying QEMUFile is not ready, and tells its producer so. However, when the underlying QEMUFile becomes ready, it neglects to pass that information along, resulting in stoppage of all data until the next tick (

[Qemu-devel] [Tracing][PATCH] Add options to specify trace file name at startup and runtime.

2010-08-02 Thread Prerna Saxena
This patch adds an optional command line switch '-trace' to specify the filename to write traces to, when qemu starts. Eg, If compiled with the 'simple' trace backend, [t...@system]$ qemu -trace FILENAME IMAGE Allows the binary traces to be written to FILENAME instead of the option set at config-

[Qemu-devel] Re: [RFC PATCH 04/14] KVM-test: Add a new subtest ping

2010-08-02 Thread Amos Kong
On Tue, Jul 27, 2010 at 10:15:49AM -0300, Lucas Meneghel Rodrigues wrote: > On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: > > This test use ping to check the virtual nics, it contains two kinds of test: > > 1. Packet loss ratio test, ping the guest with different size of packets. > > 2. Stres

Re: [Qemu-devel] [RFC PATCH 02/14] KVM Test: Add a function get_interface_name() to kvm_net_utils.py

2010-08-02 Thread Amos Kong
On Wed, Jul 28, 2010 at 01:29:22PM +0300, Michael Goldish wrote: > On 07/27/2010 05:08 AM, Lucas Meneghel Rodrigues wrote: > > On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: > >> The function get_interface_name is used to get the interface name of linux > >> guest through the macaddress of spe

Re: [Qemu-devel] [RFC PATCH 01/14] KVM-test: Add a new macaddress pool algorithm

2010-08-02 Thread Amos Kong
On Tue, Jul 20, 2010 at 06:53:27PM +0300, Michael Goldish wrote: > On 07/20/2010 04:44 PM, Amos Kong wrote: > > On Tue, Jul 20, 2010 at 01:19:39PM +0300, Michael Goldish wrote: > >> > > > > Michael, > > > > Thanks for your comments. Let's simplify this method together. I would produce a v2 later

[Qemu-devel] Re: KVM call agenda for August 3

2010-08-02 Thread Miguel Di Ciurcio Filho
On Mon, Aug 2, 2010 at 8:46 PM, Juan Quintela wrote: > > Please send in any agenda items you are interested in covering. > I would like to briefly RFC about some snapshot issues that I have being dealing, for the conversion of savevm/loadvm to QMP. They are listed here: http://wiki.qemu.org/Feat

[Qemu-devel] KVM call agenda for August 3

2010-08-02 Thread Juan Quintela
Please send in any agenda items you are interested in covering. thanks, Juan

[Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization

2010-08-02 Thread Artyom Tarasenko
Btw, it would be nice to get this patch applied for 0.13: it's a pure fix, and it allows running the OBP v2.10 for LX and some older OBP versions for SS-20 too. 2010/8/2 Blue Swirl : > Thanks, applied. Please remember to use Signed-off-by tag. Grrr. Git 1.6.2.5 seems to ignore the option signoff

[Qemu-devel] Re: [PATCH] e1000: Fix hotplug

2010-08-02 Thread Alex Williamson
rtl8139 has the same problem, except there's a much bigger pile of code in rtl8139_reset()? I think maybe we need to revisit this wholesale remove of reset calls from init functions, unless I'm missing how hotplug is supposed to work. Thanks, Alex On Mon, 2010-08-02 at 15:15 -0600, Alex Willia

[Qemu-devel] [PATCH] e1000: Fix hotplug

2010-08-02 Thread Alex Williamson
When we removed the call to e1000_reset() back in cset c1699988, we left some register state uninitialized. When we hotplug the device, we don't go through a reset cycle, which means a hot added e1000 is useless until the VM reboots. Duplicate the bits we need from e1000_reset(). Signed-off-by:

[Qemu-devel] Re: [Autotest][RFC PATCH 00/14] Patchset of network related subtests

2010-08-02 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:34 +0800, Amos Kong wrote: > The following series contain 11 network related subtests, welcome to give me > some suggestions about correctness, design, enhancement. > > Thank you so much! Ok Amos, now that I made the first review of this patchset, I'll wait for a v2 and s

[Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization

2010-08-02 Thread Blue Swirl
Thanks, applied. Please remember to use Signed-off-by tag. On Mon, Aug 2, 2010 at 5:58 PM, Artyom Tarasenko wrote: > The timer #0 is the system timer, so the timer #num_cpu is the > timer of the last CPU, and it must be initialized in slavio_timer_reset. > > Don't mark non-existing timers as run

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-08-02 Thread malc
On Mon, 2 Aug 2010, Christian Brunner wrote: > After the release of ceph 0.21 I felt it was about time to re-submit > the qemu block driver for ceph: > > This is an updated block driver for the distributed file system Ceph > (http://ceph.newdream.net/). This driver uses librados (which > is part

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Hollis Blanchard
On Mon, Aug 2, 2010 at 12:56 PM, Edgar E. Iglesias wrote: > On Mon, Aug 02, 2010 at 12:33:54PM -0700, Hollis Blanchard wrote: >> >> You mean the one architecture, which by the way doesn't even use this >> API? That doesn't seem like a strong argument to me. Anyways, it's > > Are we looking at the

Re: [gPXE-devel] [Qemu-devel] Netboot happens twice (first fail) when using etherboot ROMs

2010-08-02 Thread Marty Connor
On 8/2/10 2:14 PM, Stefan Hajnoczi wrote: > On Mon, Aug 2, 2010 at 5:43 PM, Michael Tokarev wrote: >> Not that it is a big issue, just... weird, and annoying -- >> in Debian for example we (re)build boot ROMs during >> package build instead of using the ones supplied in >> the source tarball, and

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Edgar E. Iglesias
On Mon, Aug 02, 2010 at 12:33:54PM -0700, Hollis Blanchard wrote: > On Mon, Aug 2, 2010 at 11:57 AM, Edgar E. Iglesias > wrote: > > On Mon, Aug 02, 2010 at 10:59:11AM -0700, Hollis Blanchard wrote: > >> On Sun, Aug 1, 2010 at 5:36 AM, Edgar E. Iglesias > >> wrote: > >> > On Sat, Jul 31, 2010 at 1

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-08-02 Thread Christian Brunner
After the release of ceph 0.21 I felt it was about time to re-submit the qemu block driver for ceph: This is an updated block driver for the distributed file system Ceph (http://ceph.newdream.net/). This driver uses librados (which is part of the Ceph server) for direct access to the Ceph object s

Re: [Qemu-devel] [PATCH] qemu-option: Include name of invalid parameter in error message

2010-08-02 Thread Stefan Weil
Am 02.08.2010 10:40, schrieb Markus Armbruster: Stefan Weil writes: All other error messages in qemu-option.c display the name of the invalid parameter. This seems to be reasonable for invalid identifiers, too. Without it, a debugger is needed to find the name. Cc: Markus Armbruster Cc: Anth

[Qemu-devel] Re: [PATCH] PPC4xx: don't unregister RAM at reset

2010-08-02 Thread Alexander Graf
On 02.08.2010, at 21:37, Hollis Blanchard wrote: > On Mon, Aug 2, 2010 at 1:41 AM, Alexander Graf wrote: >> >> On 30.07.2010, at 03:48, Hollis Blanchard wrote: >> >>> The PowerPC 4xx SDRAM controller emulation unregisters RAM in its reset >>> callback. However, qemu_system_reset() is now calle

[Qemu-devel] Re: [PATCH] PPC4xx: don't unregister RAM at reset

2010-08-02 Thread Hollis Blanchard
On Mon, Aug 2, 2010 at 1:41 AM, Alexander Graf wrote: > > On 30.07.2010, at 03:48, Hollis Blanchard wrote: > >> The PowerPC 4xx SDRAM controller emulation unregisters RAM in its reset >> callback. However, qemu_system_reset() is now called at initialization >> time, so RAM is unregistered before s

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Hollis Blanchard
On Mon, Aug 2, 2010 at 11:57 AM, Edgar E. Iglesias wrote: > On Mon, Aug 02, 2010 at 10:59:11AM -0700, Hollis Blanchard wrote: >> On Sun, Aug 1, 2010 at 5:36 AM, Edgar E. Iglesias >> wrote: >> > On Sat, Jul 31, 2010 at 12:56:42AM +0200, Edgar E. Iglesias wrote: >> >> On Thu, Jul 29, 2010 at 06:48:

[Qemu-devel] Re: [RFC PATCH 14/14] KVM-test: Add subtest of testing offload by ethtool

2010-08-02 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:36 +0800, Amos Kong wrote: > The latest case contains TX/RX/SG/TSO/GSO/GRO/LRO test. RTL8139 NIC doesn't > support TSO, LRO, it's too old, so drop offload test from rtl8139. LRO, GRO > are only supported by latest kernel, virtio nic doesn't support receive > offloading func

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Edgar E. Iglesias
On Mon, Aug 02, 2010 at 10:59:11AM -0700, Hollis Blanchard wrote: > On Sun, Aug 1, 2010 at 5:36 AM, Edgar E. Iglesias > wrote: > > On Sat, Jul 31, 2010 at 12:56:42AM +0200, Edgar E. Iglesias wrote: > >> On Thu, Jul 29, 2010 at 06:48:24PM -0700, Hollis Blanchard wrote: > >> > The kernel's BSS size

Re: [Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present

2010-08-02 Thread Anthony Liguori
On 08/02/2010 01:10 PM, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 11:52:22AM -0500, Anthony Liguori wrote: BTW, we need to document somewhere any assumptions SeaBIOS has about the JPEG. I see that it expects a 1024x768 image. Any additional restrictions on the jpeg image? I list

[Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2010-08-02 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: New => Fix Committed -- Windows 98 doesn't detect mouse on qemu and SeaBIOS. https://bugs.launchpad.net/bugs/521994 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Confirme

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-08-02 Thread Andy Lee Robinson
Andreas, The program that created the disk image seems confused, but it worked for creating a VM for FC11. Windows install seems to run fine, until wanting to boot from the drive it created. I don't know what creates the drive image and geometry, but it is broken. I think this is what I used to

Re: [Qemu-devel] Netboot happens twice (first fail) when using etherboot ROMs

2010-08-02 Thread Stefan Hajnoczi
On Mon, Aug 2, 2010 at 5:43 PM, Michael Tokarev wrote: > Not that it is a big issue, just... weird, and annoying -- > in Debian for example we (re)build boot ROMs during > package build instead of using the ones supplied in > the source tarball, and currently gpxe isn't packages > in debian, but e

Re: [Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present

2010-08-02 Thread Kevin O'Connor
On Mon, Aug 02, 2010 at 11:52:22AM -0500, Anthony Liguori wrote: > BTW, we need to document somewhere any assumptions SeaBIOS has about > the JPEG. I see that it expects a 1024x768 image. Any additional > restrictions on the jpeg image? I listed some notes in a previous email: >> Some notes: >>

[Qemu-devel] [Bug 612677] [NEW] qemu-kvm -curses displays garbled screen

2010-08-02 Thread Eugueny Kontsevoy
Public bug reported: when I launch qemu-kvm -curses (even without a guest OS) I get a garbled output, here's a screenshot: http://kontsevoy.com/qemu.png some more info: myarch ~: uname -a Linux myarch 2.6.34-ARCH #1 SMP PREEMPT Mon Jul 5 22:12:11 CEST 2010 x86_64 Intel(R) Core(TM)2 Duo CPU P87

[Qemu-devel] [PATCH] [sparc32] fix last cpu timer initialization

2010-08-02 Thread Artyom Tarasenko
The timer #0 is the system timer, so the timer #num_cpu is the timer of the last CPU, and it must be initialized in slavio_timer_reset. Don't mark non-existing timers as running. --- hw/slavio_timer.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/slavio_timer.c b/

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Hollis Blanchard
On Sun, Aug 1, 2010 at 5:36 AM, Edgar E. Iglesias wrote: > On Sat, Jul 31, 2010 at 12:56:42AM +0200, Edgar E. Iglesias wrote: >> On Thu, Jul 29, 2010 at 06:48:24PM -0700, Hollis Blanchard wrote: >> > The kernel's BSS size is lost by mkimage, which only considers file >> > size. As a result, loadin

Re: [Qemu-devel] RFC adding ioctl's to virtserial/virtconsole

2010-08-02 Thread Anthony Liguori
On 08/02/2010 12:28 PM, Alon Levy wrote: - "Anthony Liguori" wrote: On 08/02/2010 03:33 AM, Alon Levy wrote: Hi, This patch adds three CHR_IOCTLs and uses them in virtserial devices, to be used by a chardev backend, such as a spice vm channel (spice is a vdi

Re: [Qemu-devel] RFC adding ioctl's to virtserial/virtconsole

2010-08-02 Thread Alon Levy
- "Anthony Liguori" wrote: > On 08/02/2010 03:33 AM, Alon Levy wrote: > > Hi, > > > > This patch adds three CHR_IOCTLs and uses them in virtserial > devices, to be used > > by a chardev backend, such as a spice vm channel (spice is a vdi > solution). > > > > Basically virtio-serial provi

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-08-02 Thread Jt Loni
I had the same problem. I.ve tried with VirtualBox and KVM: Win Xp SP3 hang on the same point (mup.sys when "safe mode")... Both has the same problem I believe the libvirt maybe the cause. So I use "Raw Access" with VirtualBox that solved my problem 00:00:01.385 [/Devices/piix3ide/0/LUN#0

[Qemu-devel] [PATCH] Resend-3: target-arm: Handle 'smc' as an undefined instruction

2010-08-02 Thread Adam Lackorzynski
Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynski --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 6fcdd

Re: [Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present

2010-08-02 Thread Anthony Liguori
On 08/02/2010 11:47 AM, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 11:33:33AM -0500, Anthony Liguori wrote: On 08/02/2010 11:11 AM, Kevin O'Connor wrote: Load the "bootsplash.jpg" file into fw_cfg if it is found in the roms directory. Sorry, I should have provided this in

Re: [Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present

2010-08-02 Thread Kevin O'Connor
On Mon, Aug 02, 2010 at 11:33:33AM -0500, Anthony Liguori wrote: > On 08/02/2010 11:11 AM, Kevin O'Connor wrote: > >Load the "bootsplash.jpg" file into fw_cfg if it is found in the roms > >directory. > > Sorry, I should have provided this in the first response. > > Does the bootsplash cause a del

Re: [Qemu-devel] Netboot happens twice (first fail) when using etherboot ROMs

2010-08-02 Thread Michael Tokarev
02.08.2010 20:23, Gianni Tedesco wrote: > On Sun, 2010-08-01 at 21:27 +0100, Stefan Hajnoczi wrote: >> On Sun, Aug 1, 2010 at 10:44 AM, Michael Tokarev wrote: >>> I wonder why with etherboot ROMs, the network boot >>> happens two times (0.12.x), like this: >>> >>> - >>> Starting SeaBIOS (vers

Re: [Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present

2010-08-02 Thread Anthony Liguori
On 08/02/2010 11:11 AM, Kevin O'Connor wrote: Load the "bootsplash.jpg" file into fw_cfg if it is found in the roms directory. Sorry, I should have provided this in the first response. Does the bootsplash cause a delay in startup time? If so, we'll want to be able to disable this at boot

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 08/02/2010 11:29 AM, Blue Swirl wrote: Yeah, I'm neglecting the fact that we're not consistent as maintainers and I'm all for dropping it from CODING_STYLE. I'd rather expand the document. For example, I like the approach libvirt takes: http://libvirt.org/git/?p=libvirt.git;a=blob_plain

Re: [Qemu-devel] Netboot happens twice (first fail) when using etherboot ROMs

2010-08-02 Thread Gianni Tedesco
On Sun, 2010-08-01 at 21:27 +0100, Stefan Hajnoczi wrote: > On Sun, Aug 1, 2010 at 10:44 AM, Michael Tokarev wrote: > > I wonder why with etherboot ROMs, the network boot > > happens two times (0.12.x), like this: > > > > - > > Starting SeaBIOS (version 0.5.1-20100801_125707-gandalf) > > > >

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Blue Swirl
On Mon, Aug 2, 2010 at 4:18 PM, Anthony Liguori wrote: > On 08/02/2010 11:06 AM, malc wrote: >> >> On Mon, 2 Aug 2010, Anthony Liguori wrote: >> >> >>> >>> On 08/02/2010 10:41 AM, Kevin Wolf wrote: >>> > > But something like braces around an if doesn't seem like it creates a

[Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present

2010-08-02 Thread Kevin O'Connor
Load the "bootsplash.jpg" file into fw_cfg if it is found in the roms directory. Signed-off-by: Kevin O'Connor --- Changes v2->v3: Fix coding style (missing braces). Changes v1->v2: Add signed-off-by line. --- hw/fw_cfg.c |9 +++-- hw/pc.c |8 2 files changed, 15 i

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 08/02/2010 11:06 AM, malc wrote: On Mon, 2 Aug 2010, Anthony Liguori wrote: On 08/02/2010 10:41 AM, Kevin Wolf wrote: But something like braces around an if doesn't seem like it creates a big problem. Most C programmers are used to seeing braces in some statements and not

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Blue Swirl
On Mon, Aug 2, 2010 at 3:20 PM, Anthony Liguori wrote: > On 07/31/2010 06:49 PM, Aurelien Jarno wrote: >> >> On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: >> >>> >>> On Sat, Jul 31, 2010 at 4:23 PM, malc  wrote: >>> History has shown that this particular rule is unenforcabl

Re: [Qemu-devel] [PATCH 00/20] MIPS Magnum conversion to qdev

2010-08-02 Thread Blue Swirl
On Sun, Aug 1, 2010 at 1:42 PM, Hervé Poussineau wrote: > This series converts devices used by MIPS Magnum emulation to qdev devices. > Once applied, Magnum emulation will be fully creatable by a configuration > file (see attached file) > > usage: > qemu-system-mips64el -M empty -nodefaults -readc

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread malc
On Mon, 2 Aug 2010, Anthony Liguori wrote: > On 08/02/2010 10:41 AM, Kevin Wolf wrote: > > > > > But something like braces around an if doesn't seem like it creates a > > > big problem. Most C programmers are used to seeing braces in some > > > statements and not other. Therefore, it's hard to

Re: [Qemu-devel] [PATCHv2] Load "bootsplash.jpg" if present

2010-08-02 Thread Anthony Liguori
On 08/02/2010 10:32 AM, Kevin O'Connor wrote: Load the "bootsplash.jpg" file into fw_cfg if it is found in the roms directory. Signed-off-by: Kevin O'Connor --- Changes v1->v2: Add signed-off-by line. --- hw/fw_cfg.c |8 ++-- hw/pc.c |8 2 files changed, 14 insert

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 08/02/2010 10:55 AM, malc wrote: Rejecting a big patch because braces aren't used in single line if statements seems to be an unnecessary barrier to me. Taking such patches anyway is basically what we're doing today, right? And what malc is complaining about. Malc is mainly com

[Qemu-devel] Re: [TUHS & QEMU] Making progress with old DG/UX virtualization. Need advice.

2010-08-02 Thread Natalia Portillo
Hi, El 02/08/2010, a las 08:48, DG UX escribió: > Thanks Natalia, > > I'll start by answering the insultive part of your answer, as my ego > will not let me go on if I don't: > > I am not "begging on all the internet", I am simply seeking solutions, > help and advice, and making sure to update

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread malc
On Mon, 2 Aug 2010, Kevin Wolf wrote: > Am 02.08.2010 17:20, schrieb Anthony Liguori: > > On 07/31/2010 06:49 PM, Aurelien Jarno wrote: > >> On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: [..snip..] > > > So really, I think the problem is that we're enforcing the words of > > CODIN

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 08/02/2010 10:41 AM, Kevin Wolf wrote: But something like braces around an if doesn't seem like it creates a big problem. Most C programmers are used to seeing braces in some statements and not other. Therefore, it's hard to argue that the code gets really unreadable if this isn't strictly

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Kevin Wolf
Am 02.08.2010 17:20, schrieb Anthony Liguori: > On 07/31/2010 06:49 PM, Aurelien Jarno wrote: >> On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: >> >>> On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: >>> History has shown that this particular rule is unenforcable.

[Qemu-devel] [PATCHv2] Load "bootsplash.jpg" if present

2010-08-02 Thread Kevin O'Connor
Load the "bootsplash.jpg" file into fw_cfg if it is found in the roms directory. Signed-off-by: Kevin O'Connor --- Changes v1->v2: Add signed-off-by line. --- hw/fw_cfg.c |8 ++-- hw/pc.c |8 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/fw_cfg.c b

[Qemu-devel] [PATCH 2/4] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command

2010-08-02 Thread Bernhard Kohl
The header for the MODE SENSE(10) command is 8 bytes long. Signed-off-by: Bernhard Kohl --- hw/scsi-disk.c | 35 --- 1 files changed, 28 insertions(+), 7 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 57439f4..927df54 100644 --- a/hw/scsi-disk

[Qemu-devel] [PATCH 4/4] scsi-disk: fix the block descriptor returned by the MODE SENSE command

2010-08-02 Thread Bernhard Kohl
The block descriptor contains the number of blocks, not the highest LBA. Real hard disks return 0 if the number of blocks exceed the maximum 0xFF. SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.3.3 The number of blocks field specifies the number of logical blocks on the medium to w

[Qemu-devel] [PATCH 1/4] scsi-disk: fix the mode data length field returned by the MODE SENSE command

2010-08-02 Thread Bernhard Kohl
The MODE DATA LENGTH field indicates the length in bytes of the following data that is available to be transferred. The mode data length does not include the number of bytes in the MODE DATA LENGTH field. Signed-off-by: Bernhard Kohl --- hw/scsi-disk.c |2 +- 1 files changed, 1 insertions(+)

[Qemu-devel] [PATCH 3/4] scsi-disk: fix changeable values returned by the MODE SENSE command

2010-08-02 Thread Bernhard Kohl
If the page control (PC) field in the MODE SENSE command defines Changeable Values to be returned in the mode pages, don't return any mode page as there is no support to change any values. Signed-off-by: Bernhard Kohl --- hw/scsi-disk.c |9 ++--- 1 files changed, 6 insertions(+), 3 delet

[Qemu-devel] [PATCH 0/4] scsi-disk: improve the emulation of the MODE SENSE command

2010-08-02 Thread Bernhard Kohl
This series fixes some issues with the MODE SENSE command. I have an OS which fails during this command. It works fine with real SCSI disk hardware. Thanks Bernhard

[Qemu-devel] [PATCHv2] The USB tablet should not claim boot protocol support.

2010-08-02 Thread Kevin O'Connor
The USB tablet advertises that it supports the "boot" protocol. However, its reports aren't "boot" protocol compatible. So, it shouldn't claim that. Signed-off-by: Kevin O'Connor --- Changes v1->v2: Add signed-off-by line. --- hw/usb-hid.c |2 +- 1 files changed, 1 insertions(+), 1 deleti

[Qemu-devel] [PATCHv2] Fix USB mouse Set_Protocol behavior

2010-08-02 Thread Kevin O'Connor
The QEMU USB mouse claims to support the "boot" protocol (bInterfaceSubClass is 1). However, the mouse rejects the Set_Protocol command. The qemu mouse does support the "boot" protocol specification, so a simple fix is to enable the Set_Protocol request. Signed-off-by: Kevin O'Connor --- Change

Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-08-02 Thread Joel Schopp
> Is there some magic (= tool) which detected these "broken windows" > in hw/loader.c, qemu-io.c and vl.c, or was it just a manual code > review or luck? I used a proprietary static analysis tool called BEAM. http://domino.research.ibm.com/comm/research.nsf/pages/r.da.beam.html It found pages o

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-08-02 Thread Anthony Liguori
On 07/31/2010 06:49 PM, Aurelien Jarno wrote: On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: History has shown that this particular rule is unenforcable. Signed-off-by: malc --- CODING_STYLE | 11 ++- 1 files cha

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-08-02 Thread Andreas Jacob
Hi Andy When i look at your w7 partition table output, then there seems to be a problem with start/end cylinders. Your first partitions last cylinder is 13, but also the start cylinder of your second partition is 13. two partitions should not share the same cylinder/sector! Something seems to be

Re: [Qemu-devel] RFC adding ioctl's to virtserial/virtconsole

2010-08-02 Thread Anthony Liguori
On 08/02/2010 03:33 AM, Alon Levy wrote: Hi, This patch adds three CHR_IOCTLs and uses them in virtserial devices, to be used by a chardev backend, such as a spice vm channel (spice is a vdi solution). Basically virtio-serial provides three driver initiated events for guest open of a devi

Re: [Qemu-devel] [PATCH 17/20] [MIPS] qdev: convert esp scsi adapter to rc4030 device

2010-08-02 Thread Artyom Tarasenko
2010/8/1 Hervé Poussineau : > Use it in Jazz emulation > > Signed-off-by: Hervé Poussineau > --- >  hw/esp.c       |   83 > +--- >  hw/mips_jazz.c |    5 +--- >  2 files changed, 80 insertions(+), 8 deletions(-) > > diff --git a/hw/esp.c b/hw/es

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-08-02 Thread Andy Lee Robinson
Great solution Andreas, it worked for a Win2k image which I could only boot previously using an iso from http://www.resoo.org/docs/ntldr/files/ However, I have a w7 image that I have never managed to boot, apart from its installation cd image using virt-install 20Gb w7 image: # losetup /dev/loop

Re: [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-08-02 Thread Chris Lalancette
On 07/30/10 - 10:43:01AM, Luiz Capitulino wrote: > On Fri, 30 Jul 2010 11:34:57 +0200 > Markus Armbruster wrote: > > > Miguel Di Ciurcio Filho writes: > > > > > This patch address two issues. > > > > > > 1) When savevm is run using an previously saved snapshot id or name, it > > > will > > > d

[Qemu-devel] [PATCH] MIPS support for VInt and VEIC interrupt modes.

2010-08-02 Thread Edgar E. Iglesias
Hi, This patch adds the final bits for supporting Vectored Interrupts on MIPS. I also added VEIC mode, but only the logic that is part of the CPU. VInt is the mode where the MIPS internally computes a 3 bit (0-7) vector from the 8 hw interrupt lines. VEIC is the mode where an external interrupt

[Qemu-devel] [PATCH] msix: allow byte and word reading from mmio

2010-08-02 Thread Bernhard Kohl
It's legal that the guest reads a single byte or word from mmio. I have an OS which reads single bytes and it works fine on real hardware. Maybe this happens due to casting. Signed-off-by: Bernhard Kohl --- hw/msix.c | 20 1 files changed, 16 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH] pckbd: support for commands 0xf0-0xff: Pulse output bit

2010-08-02 Thread Bernhard Kohl
I have a guest OS which sends the command 0xfd to the keyboard controller during initialization. To get rid of the message "qemu: unsupported keyboard cmd=0x%02x\n" I added support for the pulse output bit commands. I found the following explanation here: http://www.win.tue.nl/~aeb/linux/kbd/scan

[Qemu-devel] Re: Migration issues in qemu.git

2010-08-02 Thread Avi Kivity
On 08/02/2010 12:06 PM, Avi Kivity wrote: 2. Intermittent migration failures Likely suspect is the IDE migration fixes. A merge of the commit just before these changes passes the test, I'm now testing the commit immediately after the changes. Looks like this was a byproduct of the first

[Qemu-devel] Re: Migration issues in qemu.git

2010-08-02 Thread Avi Kivity
On 08/02/2010 04:12 PM, Alex Williamson wrote: On Mon, 2010-08-02 at 12:42 +0300, Avi Kivity wrote: On 08/02/2010 12:06 PM, Avi Kivity wrote: I'm hitting some migration issues merging qemu.git into qemu-kvm.git: 1. Crash in mig_cancel test: (gdb) bt #0 0x003a91c83dbb in memcpy () from

[Qemu-devel] Re: Migration issues in qemu.git

2010-08-02 Thread Alex Williamson
On Mon, 2010-08-02 at 12:42 +0300, Avi Kivity wrote: > On 08/02/2010 12:06 PM, Avi Kivity wrote: > > I'm hitting some migration issues merging qemu.git into qemu-kvm.git: > > > > 1. Crash in mig_cancel test: > > > > (gdb) bt > > #0 0x003a91c83dbb in memcpy () from /lib64/libc.so.6 > > #1 0x0

[Qemu-devel] Still unable to complete Windows XP install

2010-08-02 Thread Laurent Léonard
Even with qemu-kvm 0.12.5, at the end of the first stage of Windows XP installation, the virtual machine reboots and the console shows: "A disk read error occured Press Ctrl+Alt+Del to restart" when using libvirt (-drive + -device options). -- Laurent Léonard

Re: [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code

2010-08-02 Thread Markus Armbruster
Miguel Di Ciurcio Filho writes: > On Fri, Jul 30, 2010 at 6:45 AM, Markus Armbruster wrote: >> Why? >> >> I figure the next patch wants it, but if that's the reason, the commit >> message should state it. >> > > To better identify what happened and where, IMHO. To let the *next* patch do a bett

Re: [Qemu-devel] [Bug 611646] [NEW] isa bus not working

2010-08-02 Thread Markus Armbruster
Isaku Yamahata writes: > Sorry for that. > Does the attached patch fix it? As far as I can see, yes. I'd prefer: diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 812ddfd..34c65d5 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -103,6 +103,7 @@ static void pc_init1(ram_addr_t ram_size, p

[Qemu-devel] Re: Migration issues in qemu.git

2010-08-02 Thread Avi Kivity
On 08/02/2010 12:06 PM, Avi Kivity wrote: I'm hitting some migration issues merging qemu.git into qemu-kvm.git: 1. Crash in mig_cancel test: (gdb) bt #0 0x003a91c83dbb in memcpy () from /lib64/libc.so.6 #1 0x0049c2ff in qemu_get_buffer (f=0x302d870, buf=optimized out>, size1=409

[Qemu-devel] Migration issues in qemu.git

2010-08-02 Thread Avi Kivity
I'm hitting some migration issues merging qemu.git into qemu-kvm.git: 1. Crash in mig_cancel test: (gdb) bt #0 0x003a91c83dbb in memcpy () from /lib64/libc.so.6 #1 0x0049c2ff in qemu_get_buffer (f=0x302d870, buf=optimized out>, size1=4096) at /usr/include/bits/string3.h:52 #2 0x0

Re: [Qemu-devel] RFC adding ioctl's to virtserial/virtconsole

2010-08-02 Thread Amit Shah
On (Mon) Aug 02 2010 [04:33:49], Alon Levy wrote: > Hi, > > This patch adds three CHR_IOCTLs and uses them in virtserial devices, to be > used > by a chardev backend, such as a spice vm channel (spice is a vdi solution). > > Basically virtio-serial provides three driver initiated events for gu

Re: [Qemu-devel] [Bug 611646] [NEW] isa bus not working

2010-08-02 Thread Isaku Yamahata
Sorry for that. Does the attached patch fix it? >From 20b13fa4a2c5e755346f7a91d44d23dd781a87fa Mon Sep 17 00:00:00 2001 Message-Id: <20b13fa4a2c5e755346f7a91d44d23dd781a87fa.1280738898.git.yamah...@valinux.co.jp> In-Reply-To: References: From: Isaku Yamahata Date: Mon, 2 Aug 2010 17:47:07 +090

[Qemu-devel] Re: [PATCH] PPC4xx: don't unregister RAM at reset

2010-08-02 Thread Alexander Graf
On 30.07.2010, at 03:48, Hollis Blanchard wrote: > The PowerPC 4xx SDRAM controller emulation unregisters RAM in its reset > callback. However, qemu_system_reset() is now called at initialization > time, so RAM is unregistered before starting the guest. So the registration should be moved to res

Re: [Qemu-devel] [PATCH] qemu-option: Include name of invalid parameter in error message

2010-08-02 Thread Markus Armbruster
Stefan Weil writes: > All other error messages in qemu-option.c display the name > of the invalid parameter. This seems to be reasonable for > invalid identifiers, too. Without it, a debugger is needed > to find the name. > > Cc: Markus Armbruster > Cc: Anthony Liguori > Signed-off-by: Stefan W

[Qemu-devel] RFC adding ioctl's to virtserial/virtconsole

2010-08-02 Thread Alon Levy
Hi, This patch adds three CHR_IOCTLs and uses them in virtserial devices, to be used by a chardev backend, such as a spice vm channel (spice is a vdi solution). Basically virtio-serial provides three driver initiated events for guest open of a device, guest close, and guest ready (driver port

Re: [Qemu-devel] [Bug 611646] [NEW] isa bus not working

2010-08-02 Thread Markus Armbruster
Victor Shkamerda <611...@bugs.launchpad.net> writes: > Public bug reported: > > isa bus emulation not working anymore. > > Try running "qemu -M isapc". It will crash with segmentation fault. > > This is a qemu HEAD from git on Fedora linux. > > ** Affects: qemu > Importance: Undecided >

[Qemu-devel] [Bug 612452] [NEW] Problems with the number of serial ports for more than two

2010-08-02 Thread qwe
Public bug reported: qemu --version QEMU emulator version 0.13.50, Copyright (c) 2003-2008 Fabrice Bellard Command line: qemu -serial null -serial null -serial file:test1 hd.img Error: isa irq 4 already assigned echo $? 1 ** Affects: qemu Importance: Undecided Status: New --

Re: [Qemu-devel] [Bug 611640] [NEW] snapshot mode is broken for raw images

2010-08-02 Thread Markus Armbruster
Victor Shkamerda <611...@bugs.launchpad.net> writes: > Public bug reported: > > The snapshot mode is not working if you use raw format for image instead > of qcow2. Create a raw disk image by running "dd of=xxx.img bs=1 count=0 > seek=8G". Then run "qemu -snapshot xxx.img". In monitor console run

[Qemu-devel] Re: [TUHS & QEMU] Making progress with old DG/UX virtualization. Need advice.

2010-08-02 Thread DG UX
Thanks Natalia, I'll start by answering the insultive part of your answer, as my ego will not let me go on if I don't: I am not "begging on all the internet", I am simply seeking solutions, help and advice, and making sure to update whoever is interested in the progress I am doing. Also, I wish t